Re: [Intel-wired-lan] Deadlock in pciehp on dock disconnect

2024-04-05 Thread Heiner Kallweit
On 05.04.2024 21:16, Lukas Wunner wrote: > On Fri, Apr 05, 2024 at 07:48:08PM +0200, Lukas Wunner wrote: >> Roman, does the below patch fix the issue? > > Actually the patch in my previous e-mail was crap as the unregistering > of the LEDs happened after unbind of the pdev, i.e. after > igc_releas

Re: [Intel-wired-lan] Deadlock in pciehp on dock disconnect

2024-04-05 Thread Heiner Kallweit
On 05.04.2024 19:48, Lukas Wunner wrote: > On Fri, Apr 05, 2024 at 03:31:34PM +0200, Heiner Kallweit wrote: >> On 05.04.2024 12:02, Lukas Wunner wrote: >>> On Fri, Apr 05, 2024 at 11:14:01AM +0200, Roman Lozko wrote: >>>> Hi, I'm using HP G4 Thunde

Re: [Intel-wired-lan] Deadlock in pciehp on dock disconnect

2024-04-05 Thread Heiner Kallweit
On 05.04.2024 12:02, Lukas Wunner wrote: > [cc += netdev maintainers] > > On Fri, Apr 05, 2024 at 11:14:01AM +0200, Roman Lozko wrote: >> Hi, I'm using HP G4 Thunderbolt docking station, and recently (?) >> kernel started to "partially" deadlock after disconnecting the dock >> station. This result

Re: [Intel-wired-lan] [PATCH iwl-next v2 1/2] igb: simplify pci ops declaration

2024-03-05 Thread Heiner Kallweit
On 06.03.2024 07:24, Paul Menzel wrote: > [Cc: +linux-...@vger.kernel.org] > > > Dear Jesse, > > > Am 06.03.24 um 03:50 schrieb Jesse Brandeburg: >> The igb driver was pre-declaring tons of functions just so that it could >> have an early declaration of the pci_driver struct. >> >> Delete a bun

Re: [Intel-wired-lan] [net-next v3] intel: make module parameters readable in sys filesystem

2024-02-13 Thread Heiner Kallweit
On 14.02.2024 08:22, Paul Menzel wrote: > Dear Jon, > > > Thank you very much for your patch. > > Am 13.02.24 um 11:23 PM schrieb Jon Maxwell: >> Linux users sometimes need an easy way to check current values of module >> parameters. For example the module may be manually reloaded with different

Re: [Intel-wired-lan] [PATCH net v3] net: ethtool: do runtime PM outside RTNL

2023-12-24 Thread Heiner Kallweit
On 24.12.2023 17:30, Marc MERLIN wrote: > On Fri, Dec 15, 2023 at 09:46:34AM -0800, Marc MERLIN wrote: >> On Fri, Dec 15, 2023 at 02:42:01PM +0100, Heiner Kallweit wrote: >>> Why don't you simply disable runtime pm for the affected device as a >>> workaround? Thi

Re: [Intel-wired-lan] [PATCH net v3] net: ethtool: do runtime PM outside RTNL

2023-12-15 Thread Heiner Kallweit
On 11.12.2023 05:52, Marc MERLIN wrote: > On Thu, Dec 07, 2023 at 09:40:21AM -0800, Jakub Kicinski wrote: >> On Thu, 7 Dec 2023 11:16:10 +0100 Przemek Kitszel wrote: >>> I have let know our igc TL, architect, and anybody that could be >>> interested via cc: IWL. And I'm happy that this could be don

Re: [Intel-wired-lan] [RFC PATCH] net: ethtool: do runtime PM outside RTNL

2023-12-06 Thread Heiner Kallweit
On 06.12.2023 10:37, Johannes Berg wrote: > On Wed, 2023-12-06 at 09:46 +0100, Przemek Kitszel wrote: >> >> That sounds right too; one could argue if your fix is orthogonal to that >> or not. I would say that your fix makes core net code more robust >> against drivers from past millennia. :) >> igc