set the reported verification state while the link is down
> */
> + if (mmsv->verify_enabled)
> + mmsv->status = ETHTOOL_MM_VERIFY_STATUS_INITIAL;
> +
> /* No link or pMAC not enabled */
> ethtool_mmsv_configure_pmac(mmsv, false);
> ethtool_mmsv_configure_tx(mmsv, false);
Reviewed-by: Furong Xu <0x1...@gmail.com>
/
> timer_shutdown_sync(&fpe_cfg->verify_timer);
>
> @@ -1271,7 +1273,6 @@ static int stmmac_set_mm(struct net_device *ndev,
> struct ethtool_mm_cfg *cfg,
> if (!cfg->verify_enabled)
> fpe_cfg->status = ETHTOOL_MM_VERIFY_STATUS_DISABLED;
>
> - stmmac_fpe_set_add_frag_size(priv, frag_size);
> stmmac_fpe_apply(priv);
>
> spin_unlock_irqrestore(&fpe_cfg->lock, flags);
Reviewed-by: Furong Xu <0x1...@gmail.com>
On Wed, 19 Feb 2025 21:53:41 -0500, Faizal Rahim
wrote:
> @@ -1258,23 +1236,8 @@ static int stmmac_set_mm(struct net_device *ndev,
> struct ethtool_mm_cfg *cfg,
> if (err)
> return err;
>
> - /* Wait for the verification that's currently in progress to finish */
> -
ot;max-verify-time": 128,
"verify-status": "DISABLED",
"statistics": {
"MACMergeFrameAssErrorCount": 0,
"MACMergeFrameSmdErrorCount": 0,
"MACMergeFrameAssOk
On Fri, 21 Feb 2025 11:56:51 +0200, Vladimir Oltean
wrote:
> On Fri, Feb 21, 2025 at 05:42:49PM +0800, Furong Xu wrote:
> > > +void ethtool_mmsv_link_state_handle(struct ethtool_mmsv *mmsv, bool up)
> > > +{
> > > + unsigned long flags;
> >
got stmmac to do something fairly clean, with the help and
> great perseverence of Furong Xu (now copied).
>
> I spent a bit of time extracting stmmac's core logic and putting it in
> ethtool. If Furong had such good will so as to regression-test the
> attached patch, do you t
