On 6/24/2025 7:26 AM, Emil Tantilov wrote:
Caution: This message originated from an External Source. Use proper caution
when opening attachments, clicking links, or responding.
Issuing a reset when the driver is loaded without RDMA support, will
results in a crash as it attempts to remove R
/ethernet/intel/igc/igc.h | 4
drivers/net/ethernet/intel/igc/igc_defines.h | 3 +++
2 files changed, 3 insertions(+), 4 deletions(-)
LGTM.
Reviewed-by: Brett Creeley
diff --git a/drivers/net/ethernet/intel/igc/igc.h
b/drivers/net/ethernet/intel/igc/igc.h
index 1525ae25fd3e
On 6/19/2025 8:37 AM, Song Yoong Siang wrote:
Caution: This message originated from an External Source. Use proper caution
when opening attachments, clicking links, or responding.
Introduce support for a lowest priority wildcard (catch-all) rule in
ethtool's Network Flow Classification (NFC) f
(pf)) {
+ if (err || ice_is_safe_mode(pf)) {
LGTM.
Reviewed-by: Brett Creeley
/* we already got function/device capabilities but these don't
* reflect what the driver needs to do in safe mode. Instead of
* adding conditional logi
;& (dev->netdev_ops == &ice_netdev_ops);
+ return dev && (dev->netdev_ops == &ice_netdev_ops ||
+ dev->netdev_ops == &ice_netdev_safe_mode_ops);
}
LGTM.
Reviewed-by: Brett Creeley
/**
--
2.45.0
On 9/20/2024 9:59 AM, Marcin Szycik wrote:
Caution: This message originated from an External Source. Use proper caution
when opening attachments, clicking links, or responding.
If DDP package is missing or corrupted, the driver should enter Safe Mode.
Instead, an error is returned and probe
On 9/20/2024 5:03 AM, Maciej Fijalkowski wrote:
Caution: This message originated from an External Source. Use proper caution
when opening attachments, clicking links, or responding.
On Fri, Sep 20, 2024 at 01:55:09PM +0200, Marcin Szycik wrote:
If DDP package is missing or corrupted, the d
On 7/24/2024 12:26 AM, Kurt Kanzenbach wrote:
On Tue Jul 23 2024, Brett Creeley wrote:
@@ -5811,11 +5815,29 @@ static void igc_watchdog_task(struct work_struct *work)
if (adapter->flags & IGC_FLAG_HAS_MSIX) {
u32 eics = 0;
- for (i = 0; i &l
On 7/18/2024 11:13 AM, Kamal Heib wrote:
Caution: This message originated from an External Source. Use proper caution
when opening attachments, clicking links, or responding.
Add support for reporting fw status via the devlink health report.
Example:
# devlink health show pci/:02:00.
On 6/20/2024 11:56 PM, Kurt Kanzenbach wrote:
Caution: This message originated from an External Source. Use proper caution
when opening attachments, clicking links, or responding.
When running the igc with XDP/ZC in busy polling mode with deferral of hard
interrupts, interrupts still happen
++--
1 file changed, 17 insertions(+), 2 deletions(-)
LGTM.
Reviewed-by: Brett Creeley
diff --git a/drivers/net/ethernet/intel/ice/ice_ddp.c
b/drivers/net/ethernet/intel/ice/ice_ddp.c
index ce5034ed2b24..77b81e5a5a44 100644
--- a/drivers/net/ethernet/intel/ice/ice_ddp.c
+++ b/
insertions(+), 10 deletions(-)
LGTM.
Reviewed-by: Brett Creeley
diff --git a/drivers/net/ethernet/intel/ice/devlink/devlink_port.c
b/drivers/net/ethernet/intel/ice/devlink/devlink_port.c
index c9fbeebf7fb9..00fed5a61d62 100644
--- a/drivers/net/ethernet/intel/ice/devlink/devlink_port.c
+++ b/drivers
On 5/16/2024 7:04 AM, Wojciech Drewek wrote:
Caution: This message originated from an External Source. Use proper caution
when opening attachments, clicking links, or responding.
ice_aqc_opc_download_pkg (0x0C40) AQ sporadically returns error due
to FW issue. Fix this by retrying five times
On 5/15/2024 2:21 PM, Keller, Jacob E wrote:
Caution: This message originated from an External Source. Use proper caution
when opening attachments, clicking links, or responding.
-Original Message-
From: Brett Creeley
Sent: Wednesday, May 15, 2024 9:53 AM
To: Karthik Sundaravel
On 5/15/2024 7:22 AM, Karthik Sundaravel wrote:
Caution: This message originated from an External Source. Use proper caution
when opening attachments, clicking links, or responding.
Changing the MAC address of the VFs is currently unsupported via devlink.
Add the function handlers to set an
On 3/15/2024 2:17 AM, Erwan Velu wrote:
Caution: This message originated from an External Source. Use proper
caution when opening attachments, clicking links, or responding.
Le 14/03/2024 à 21:31, Tony Nguyen a écrit :
[..]
Setting the mfs size to max values during init and reset would bet
On 3/14/2024 10:10 AM, Erwan Velu wrote:
Caution: This message originated from an External Source. Use proper
caution when opening attachments, clicking links, or responding.
Le 14/03/2024 à 17:10, Brett Creeley a écrit :
[...]
If this is how the max_mtu is determined, does it make sense
On 3/13/2024 2:07 AM, Erwan Velu wrote:
Caution: This message originated from an External Source. Use proper caution
when opening attachments, clicking links, or responding.
Commit 6871a7de705 ("[intelxl] Use admin queue to set port MAC address
and maximum frame size") from iPXE project set
er_addr_equal(addr, vf->default_lan_addr.addr)) {
+ if (i40e_can_vf_change_mac(vf))
+ was_unimac_deleted = true;
+ else
+ continue;
+ }
Seems okay to me.
Reviewed-by: Brett Creeley
ned-off-by: Wojciech Drewek
LGTM.
Reviewed-by: Brett Creeley
---
drivers/net/ethernet/intel/ice/ice.h | 1 +
drivers/net/ethernet/intel/ice/ice_debugfs.c | 10 ++
drivers/net/ethernet/intel/ice/ice_fwlog.c | 2 ++
drivers/net/ethernet/intel/ice/ice_main.c| 3 +--
e ice_debugfs_exit() call to ice_module_exit().
Nit, but the function is no longer ice_debugfs_fwlog_deinit() as it
changed from v2->v3.
Other than that, LGTM.
Reviewed-by: Brett Creeley
Suggested-by: Jiri Pirko
Reviewed-by: Przemek Kitszel
Reviewed-by: Vadim Fedorenko
Reviewed-by:
On 1/25/2024 12:54 AM, Wojciech Drewek wrote:
Caution: This message originated from an External Source. Use proper caution
when opening attachments, clicking links, or responding.
Recent changes to the devlink reload (commit 9b2348e2d6c9
("devlink: warn about existing entities during reload
ing prints.
Reviewed-by: Brett Creeley
[...]
), 106 deletions(-)
For the series:
Reviewed-by: Brett Creeley
base-commit: 67b40ee196fd2fd6d9b7f9b58912587c837bdc39
--
2.40.1
___
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
On 12/20/2023 6:19 AM, Plachno, Lukasz wrote:
Caution: This message originated from an External Source. Use proper
caution when opening attachments, clicking links, or responding.
On 12/19/2023 6:35 PM, Brett Creeley wrote:
On 12/13/2023 8:34 PM, Lukasz Plachno wrote:
Caution: This
On 12/13/2023 8:34 PM, Lukasz Plachno wrote:
Caution: This message originated from an External Source. Use proper caution
when opening attachments, clicking links, or responding.
From: Jakub Buchocki
Add support for 'flow-type ether' Flow Director rules via ethtool.
Rules not containing
| 2 ++
5 files changed, 41 insertions(+), 2 deletions(-)
[...]
Reviewed-by: Brett Creeley
___
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
On 12/12/2023 6:55 AM, Michal Kubiak wrote:
Caution: This message originated from an External Source. Use proper caution
when opening attachments, clicking links, or responding.
From: Joshua Hay
Tell hardware to writeback completed descriptors even when interrupts
are disabled. Otherwise,
On 12/12/2023 4:51 AM, Andrii Staikov wrote:
Caution: This message originated from an External Source. Use proper caution
when opening attachments, clicking links, or responding.
Switchdev mode allows to add mirroring rules to mirror incoming and
outgoing packets to the interface's port rep
On 12/13/2023 2:49 AM, Ke Xiao wrote:
Caution: This message originated from an External Source. Use proper caution
when opening attachments, clicking links, or responding.
Commit 3116f59c12bd ("i40e: fix use-after-free in
i40e_sync_filters_subtask()") avoided use-after-free issues,
by increasi
On 11/20/2023 6:51 PM, Yahui Cao wrote:
Caution: This message originated from an External Source. Use proper caution
when opening attachments, clicking links, or responding.
From: Lingyu Liu
During migration device resume stage, part of device state is loaded by
replaying logged virtual chan
On 11/20/2023 6:51 PM, Yahui Cao wrote:
Caution: This message originated from an External Source. Use proper caution
when opening attachments, clicking links, or responding.
Export TX queue context get and set function which is consumed by linux
live migration driver to save and load device st
On 11/20/2023 6:51 PM, Yahui Cao wrote:
Caution: This message originated from an External Source. Use proper caution
when opening attachments, clicking links, or responding.
Export RX queue context get function which is consumed by linux live
migration driver to save and load device state.
N
On 11/20/2023 6:51 PM, Yahui Cao wrote:
Caution: This message originated from an External Source. Use proper caution
when opening attachments, clicking links, or responding.
From: Lingyu Liu
Save the virtual channel messages sent by VF on the source side during
runtime. The logged virtchn
34 matches
Mail list logo
