Re: [Intel-wired-lan] [PATCH net-next 0/5] net: flower: validate encapsulation control flags

2024-06-13 Thread Asbjørn Sloth Tønnesen
Hi Jakub, On 6/13/24 1:04 AM, Jakub Kicinski wrote: On Sun, 9 Jun 2024 17:33:50 + Asbjørn Sloth Tønnesen wrote: Now that all drivers properly rejects unsupported flower control flags used with FLOW_DISSECTOR_KEY_CONTROL, then time has come to add similar checks to the drivers supporting

[Intel-wired-lan] [PATCH net-next 3/5] net/mlx5e: flower: validate encapsulation control flags

2024-06-09 Thread Asbjørn Sloth Tønnesen
, flow_rule_match_has_enc_control_flags() sets a NL extended error message, and we return -EOPNOTSUPP. Only compile tested. Signed-off-by: Asbjørn Sloth Tønnesen --- drivers/net/ethernet/mellanox/mlx5/core/en/tc_tun.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en

[Intel-wired-lan] [PATCH net-next 0/5] net: flower: validate encapsulation control flags

2024-06-09 Thread Asbjørn Sloth Tønnesen
ivers. NB: It is currently discussed[1] to use encapsulation control flags for tunnel flags instead of the new FLOW_DISSECTOR_KEY_ENC_FLAGS. [1] https://lore.kernel.org/netdev/zmfuxelwziyjz...@dcaratti.users.ipa.redhat.com/ Asbjørn Sloth Tønnesen (5): flow_offload: add encapsulation control

[Intel-wired-lan] [PATCH net-next 5/5] ice: flower: validate encapsulation control flags

2024-06-09 Thread Asbjørn Sloth Tønnesen
, flow_rule_match_has_enc_control_flags() sets a NL extended error message, and we return -EOPNOTSUPP. Only compile tested. Signed-off-by: Asbjørn Sloth Tønnesen --- drivers/net/ethernet/intel/ice/ice_tc_lib.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/net/ethernet/intel/ice/ice_tc_lib.c b/drivers/net

[Intel-wired-lan] [PATCH net-next 1/5] flow_offload: add encapsulation control flag helpers

2024-06-09 Thread Asbjørn Sloth Tønnesen
nc_" variant of flow_rule_match_has_control_flags(), as all drivers currently supporting FLOW_DISSECTOR_KEY_ENC_CONTROL, are already calling flow_rule_match_enc_control() directly. Only compile tested. Signed-off-by: Asbjørn Sloth Tønnesen --- include/net/flow_offload.h | 35 +++

[Intel-wired-lan] [PATCH net-next 4/5] nfp: flower: validate encapsulation control flags

2024-06-09 Thread Asbjørn Sloth Tønnesen
, flow_rule_match_has_enc_control_flags() sets a NL extended error message, and we return -EOPNOTSUPP. Only compile tested. Signed-off-by: Asbjørn Sloth Tønnesen --- drivers/net/ethernet/netronome/nfp/flower/offload.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/net/ethernet/netronome/nfp/flower

[Intel-wired-lan] [PATCH net-next 2/5] sfc: use flow_rule_is_supp_enc_control_flags()

2024-06-09 Thread Asbjørn Sloth Tønnesen
Change the existing check for unsupported encapsulation control flags, to use the new helper flow_rule_is_supp_enc_control_flags(). No functional change, only compile tested. Signed-off-by: Asbjørn Sloth Tønnesen --- drivers/net/ethernet/sfc/tc.c | 5 + 1 file changed, 1 insertion(+), 4

Re: [Intel-wired-lan] [PATCH iwl-next] iavf: flower: validate control flags

2024-05-06 Thread Asbjørn Sloth Tønnesen
, if it's not supported. Try with: ethtool -K $iface hw-tc-offload on tc qdisc add dev $iface ingress tc filter add dev $iface protocol ip parent : prio 1 flower dst_mac 3c:fd:fe:a0:d6:70 ip_flags frag skip_sw hw_tc 1 -- Best regards Asbjørn Sloth Tønnesen Network Engineer Fiberby - AS42541

Re: [Intel-wired-lan] [PATCH iwl-next] i40e: flower: validate control flags

2024-05-06 Thread Asbjørn Sloth Tønnesen
.intel.com/ -- Best regards Asbjørn Sloth Tønnesen Network Engineer Fiberby - AS42541

Re: [Intel-wired-lan] [PATCH iwl-next] ice: flower: validate control flags

2024-05-03 Thread Asbjørn Sloth Tønnesen
Hi Sujai, On 5/3/24 5:57 AM, Buvaneswaran, Sujai wrote: -Original Message- From: Intel-wired-lan On Behalf Of Asbjørn Sloth Tønnesen Sent: Tuesday, April 16, 2024 8:14 PM To: intel-wired-...@lists.osuosl.org Cc: net...@vger.kernel.org; linux-ker...@vger.kernel.org; Eric Dumazet

[Intel-wired-lan] [PATCH iwl-next] igb: flower: validate control flags

2024-04-16 Thread Asbjørn Sloth Tønnesen
, and we return -EOPNOTSUPP. Only compile-tested. Signed-off-by: Asbjørn Sloth Tønnesen --- drivers/net/ethernet/intel/igb/igb_main.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/ethernet/intel/igb/igb_main.c index 74a998f

[Intel-wired-lan] [PATCH iwl-next] ice: flower: validate control flags

2024-04-16 Thread Asbjørn Sloth Tønnesen
eturn -EOPNOTSUPP. Only compile-tested. Signed-off-by: Asbjørn Sloth Tønnesen --- drivers/net/ethernet/intel/ice/ice_tc_lib.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/net/ethernet/intel/ice/ice_tc_lib.c b/drivers/net/ethernet/intel/ice/ice_tc_lib.c index 2f2fce285ecd..361abd7

[Intel-wired-lan] [PATCH iwl-next] i40e: flower: validate control flags

2024-04-16 Thread Asbjørn Sloth Tønnesen
eturn -EOPNOTSUPP. Only compile-tested. Signed-off-by: Asbjørn Sloth Tønnesen --- drivers/net/ethernet/intel/i40e/i40e_main.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c index 0bdcdea0be3e..e219f75

[Intel-wired-lan] [PATCH iwl-next] iavf: flower: validate control flags

2024-04-16 Thread Asbjørn Sloth Tønnesen
eturn -EOPNOTSUPP. Only compile-tested. Signed-off-by: Asbjørn Sloth Tønnesen --- drivers/net/ethernet/intel/iavf/iavf_main.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/net/ethernet/intel/iavf/iavf_main.c b/drivers/net/ethernet/intel/iavf/iavf_main.c index 13361a780ece..f14355d