Re: [Intel-wired-lan] [PATCH v8 10/12] pps: generators: Add PPS Generator TIO Driver

2024-05-30 Thread Andy Shevchenko
On Thu, May 30, 2024 at 8:52 AM D, Lakshmi Sowjanya wrote: > > -Original Message- > > From: Andy Shevchenko > > Sent: Monday, May 27, 2024 8:04 PM > > Mon, May 27, 2024 at 11:48:54AM +, D, Lakshmi Sowjanya kirjoitti: > > > > -Original Messag

Re: [Intel-wired-lan] [PATCH v8 12/12] ABI: pps: Add ABI documentation for Intel TIO

2024-05-27 Thread Andy Shevchenko
Mon, May 27, 2024 at 11:53:07AM +, D, Lakshmi Sowjanya kirjoitti: > > -Original Message- > > From: Andy Shevchenko > > Sent: Monday, May 13, 2024 4:52 PM > > On Mon, May 13, 2024 at 04:08:13PM +0530, lakshmi.sowjany...@intel.com > > wrote: ... >

Re: [Intel-wired-lan] [PATCH v8 10/12] pps: generators: Add PPS Generator TIO Driver

2024-05-27 Thread Andy Shevchenko
Mon, May 27, 2024 at 11:48:54AM +, D, Lakshmi Sowjanya kirjoitti: > > -Original Message- > > From: Andy Shevchenko > > Sent: Monday, May 13, 2024 4:49 PM > > On Mon, May 13, 2024 at 04:08:11PM +0530, lakshmi.sowjany...@intel.com > > wrote: ... >

Re: [Intel-wired-lan] [PATCH v8 12/12] ABI: pps: Add ABI documentation for Intel TIO

2024-05-13 Thread Andy Shevchenko
closes on Sunday, 2024-08-04 and release on Sunday, 2024-09-29" > +KernelVersion: 6.11 -- With Best Regards, Andy Shevchenko

Re: [Intel-wired-lan] [PATCH v8 10/12] pps: generators: Add PPS Generator TIO Driver

2024-05-13 Thread Andy Shevchenko
On Mon, May 13, 2024 at 02:18:49PM +0300, Andy Shevchenko wrote: > On Mon, May 13, 2024 at 04:08:11PM +0530, lakshmi.sowjany...@intel.com wrote: > > + pps_tio_disable(tio); > > This... > > + tio->enabled = false; > > ...and this should go together, which mak

Re: [Intel-wired-lan] [PATCH v8 10/12] pps: generators: Add PPS Generator TIO Driver

2024-05-13 Thread Andy Shevchenko
ed to sync it with the reality. I would think of something like this: pps_tio_direction_output() ==> true pps_tio_disable(tio) ==> false where "==> X" means assignment of enabled flag. And perhaps this: tio->enabled = pps_generate_next_pulse(tio, expires + SAFE_TIME_NS); if (!tio->enabled) ... But the above is just thinking out loudly, you may find the better approach(es). > + platform_set_drvdata(pdev, tio); > + > + return 0; > +} -- With Best Regards, Andy Shevchenko

Re: [Intel-wired-lan] [PATCH v7 10/12] pps: generators: Add PPS Generator TIO Driver

2024-05-10 Thread Andy Shevchenko
On Thu, May 09, 2024 at 04:38:49AM +, D, Lakshmi Sowjanya wrote: > Will update as suggested. Just a side note: Since the series most likely missed v6.10, don't forget to bump dates and versions in ABI documentation in the next version. -- With Best Regards, Andy Shevchenko

Re: [Intel-wired-lan] [PATCH net-next v2 1/1] net: intel: Use *-y instead of *-objs in Makefile

2024-05-08 Thread Andy Shevchenko
On Wed, May 08, 2024 at 11:23:39AM -0700, Jacob Keller wrote: > On 5/8/2024 11:00 AM, Andy Shevchenko wrote: ... > FWIW I applied v1 and v2, and got only the following range-diff: > This matches the changes described w.r.t ordering, and everything built > properly when I tested i

Re: [Intel-wired-lan] [PATCH net-next v1 1/1] net: intel: Use *-y instead of *-objs in Makefile

2024-05-08 Thread Andy Shevchenko
On Wed, May 08, 2024 at 10:58:37AM -0700, Jacob Keller wrote: > On 5/8/2024 7:42 AM, Loktionov, Aleksandr wrote: > >> From: Alexander Lobakin > >> Date: Wed, 8 May 2024 16:39:21 +0200 > >>> From: Andy Shevchenko > >>> Date: Wed, 8 May 2024 17:25:31 +0

[Intel-wired-lan] [PATCH net-next v2 1/1] net: intel: Use *-y instead of *-objs in Makefile

2024-05-08 Thread Andy Shevchenko
d-off-by: Andy Shevchenko --- v2: added tags (Olek, Aleksandr), fixed misplaced line in one case (LKP) drivers/net/ethernet/intel/e1000/Makefile | 2 +- drivers/net/ethernet/intel/e1000e/Makefile | 7 +++ drivers/net/ethernet/intel/i40e/Makefile| 2 +- drivers/net/ethernet/intel/iavf/Mak

Re: [Intel-wired-lan] [PATCH net-next v1 1/1] net: intel: Use *-y instead of *-objs in Makefile

2024-05-08 Thread Andy Shevchenko
On Thu, May 09, 2024 at 01:28:19AM +0800, kernel test robot wrote: > Hi Andy, > > kernel test robot noticed the following build errors: > > [auto build test ERROR on net-next/main] > > url: > https://github.com/intel-lab-lkp/linux/commits/Andy-Shevchenko/net-intel-

Re: [Intel-wired-lan] [PATCH net-next v1 1/1] net: intel: Use *-y instead of *-objs in Makefile

2024-05-08 Thread Andy Shevchenko
erence that -objs is for userspace and we should > clearly use -y? Sure. Luckily it's documented in Documentation/kbuild/makefiles.rst "Composite Host Programs" (mind the meaning of the word "host"!). -- With Best Regards, Andy Shevchenko

[Intel-wired-lan] [PATCH net-next v1 1/1] net: intel: Use *-y instead of *-objs in Makefile

2024-05-08 Thread Andy Shevchenko
*-objs suffix is reserved rather for (user-space) host programs while usually *-y suffix is used for kernel drivers (although *-objs works for that purpose for now). Let's correct the old usages of *-objs in Makefiles. Signed-off-by: Andy Shevchenko --- drivers/net/ethernet/intel/

Re: [Intel-wired-lan] [PATCH v7 10/12] pps: generators: Add PPS Generator TIO Driver

2024-04-30 Thread Andy Shevchenko
RT; > + hrtimer_forward(timer, now, NSEC_PER_SEC / 2); > + return HRTIMER_RESTART; > +err: > + dev_err(tio->dev, "Event missed, Disabling Timed I/O"); > + pps_tio_disable(tio); > + return HRTIMER_NORESTART; > +} -- With Best Regards, Andy Shevchenko

Re: [Intel-wired-lan] [PATCH v6 11/11] ABI: pps: Add ABI documentation for Intel TIO

2024-04-10 Thread Andy Shevchenko
On Wed, Apr 10, 2024 at 05:18:28PM +0530, lakshmi.sowjany...@intel.com wrote: > From: Lakshmi Sowjanya D > > Document sysfs interface for Intel Timed I/O PPS driver. ... > +Date:March 2024 > +KernelVersion6.9 This boat is already sailed... -- With Bes

Re: [Intel-wired-lan] [PATCH net-next v6 02/21] lib/test_bitmap: add tests for bitmap_{read, write}()

2024-03-27 Thread Andy Shevchenko
197][T1] test_bitmap: Time spent in test_bitmap_write_perf: > 916313 > > (numbers from a Intel(R) Xeon(R) Gold 6154 CPU @ 3.00GHz machine running > QEMU). > > Signed-off-by: Alexander Potapenko > Reviewed-by: Andy Shevchenko > Acked-by: Yury Norov > Signed-off-by: Yury Norov

Re: [Intel-wired-lan] [PATCH net] ice: Fix freeing uninitialized pointers

2024-03-21 Thread Andy Shevchenko
= NULL; > if (ice_lbtest_create_frame(pf, &tx_frame, ...)) > { ... } > ... when any > +} > + > valid_frames = ice_lbtest_receive_frames(...); I believe you don't understand what the scope of the above can be. -- With Best Regards, Andy Shevchenko

Re: [Intel-wired-lan] [RFC PATCH v3 00/11] Add support for Intel PPS Generator

2024-01-06 Thread Andy Shevchenko
PS device. Each Timed I/O pin is represented by a PPS > device. When enabled, a pulse-per-second(PPS) synchronized with the > system clock is continuously produced on the Timed I/O pin, otherwise it > is pulled low. > > The Timed I/O signal on the motherboard is enabled in the BIOS setup. At some point you should announce v1 of the series. RFC is usually being neglected by many (busy) maintainers. -- With Best Regards, Andy Shevchenko

Re: [Intel-wired-lan] [RFC PATCH v2 10/10] ABI: pps: Add ABI documentation for Intel TIO

2023-12-21 Thread Andy Shevchenko
On Thu, Dec 21, 2023 at 03:02:54PM +0530, lakshmi.sowjany...@intel.com wrote: > From: Lakshmi Sowjanya D > > Document sysfs interface for Intel Timed I/O PPS driver ... > +Date:January 2024 > +KernelVersion6.8 No way, use next one. -- With Bes

Re: [Intel-wired-lan] [RFC PATCH v2 08/10] pps: generators: Add PPS Generator TIO Driver

2023-12-21 Thread Andy Shevchenko
vent precisely at the > requested system time without software involvement. ... > +#include > +#include > +#include + container_of.h > +#include + device.h + err.h + hrtimer.h > +#include + kstrtox.h > +#include > +#include > +#include

Re: [Intel-wired-lan] [RFC PATCH v2 04/10] igc: remove convert_art_to_tsc()

2023-12-21 Thread Andy Shevchenko
em_counterval_t) { > + .cs_id= CSID_X86_ART, > + .cycles= tstamp, > + .nsecs= true, Either you should remove the extra spaces before '=' or replace them by TAB(s). > + }; -- With Best Regards, Andy Shevchenko