> The E810 Ethernet controller firmware provides a certain level of security,
> which includes a mechanism to prevent firmware downgrades (to past, less
> secure versions).
Is there anything Ethernet specific here? I assume the same API could
be used for GPU firmware, ATA controller firmware, mice
> > > You forgot to Cc: the PTP maintainer.
> >
> > Who is the PTP maintainer? Is it necessary? This is only Intel's driver,
> > I am not sure if PTP maintainer is necessary.
>
> I was curious for a moment too, but just for a moment :)
>
> We develop network drivers in the public, so we CC peopl
On Tue, Nov 26, 2024 at 11:23:11AM +0100, Przemyslaw Korba wrote:
> ptp4l application reports too high offset when ran on E823 device
> with a 100GB/s link. Those values cannot go under 100ns, like in a
> PTP working case when using 100 GB/s cable.
> This is due to incorrect frequency settings on t
On Wed, Nov 06, 2024 at 02:07:55AM +0100, Arkadiusz Kubalewski wrote:
> Currently HW support of ptp/timesync solutions in network PHY chips can be
> implemented with two different approaches, the timestamp maybe latched
> either at the beginning or after the Start of Frame Delimiter (SFD) [1].
>
>
On Fri, Oct 11, 2024 at 09:54:12PM +0200, Gerhard Engleder wrote:
> From: Gerhard Engleder
>
> Link down and up triggers update of MTA table. This update executes many
> PCIe writes and a final flush. Thus, PCIe will be blocked until all writes
> are flushed. As a result, DMA transfers of other t
> This was originally worked out by Doug Boom at Intel. It had to do
> with autonegotiation not being the part of the SFP optics when the
> Denverton X550 Si was released and was thus not POR for DNV. The
> Juniper switches however won't exit their AN sequence unless an AN37
> transaction is seen
> It turns out that the patch works fine for the specific issue it's trying to
> address (Juniper switch),
> but for (seemingly all) other devices it breaks the autonegotiation.
So it sounds like you need to figure out the nitty-gritty details of
what is going on with the Juniper switch. Once yo
On Fri, Sep 06, 2024 at 06:41:45AM -0400, Jeff Daly wrote:
> Resubmit commit 565736048bd5 ("ixgbe: Manual AN-37 for troublesome link
> partners for X550 SFI")
>
> Some (Juniper MX5) SFP link partners exhibit a disinclination to
> autonegotiate with X550 configured in SFI mode. This patch enables
On Wed, Sep 04, 2024 at 02:56:46PM +0900, Takamitsu Iwai wrote:
> > So you have confirmed with the datsheet that the write is not needed?
> >
> > As i said, this is a hardware register, not memory. Writes are not
> > always idempotent. It might be necessary to write it twice.
>
> I have checked fo
On Tue, Sep 03, 2024 at 07:46:42PM +0900, Takamitsu Iwai wrote:
> > Did the same sequence of read/writes happen before 0845d45e900c? Or
> > did 0845d45e900c add additional writes, not just move them around?
>
> The sequence of read/writes happened before 0845d45e900c because the similar
> writel()
On Mon, Sep 02, 2024 at 03:14:54PM +0900, Takamitsu Iwai wrote:
> Duplicated register initialization codes exist in e1000_configure_tx()
> and e1000_configure_rx().
What does the datasheet say about these registers? Since we are
talking about hardware here, before you remove anything you need to b
On Sun, Jun 09, 2024 at 04:57:35PM +0800, Richard chien wrote:
> This patch adds support for firmware update to the in-tree ixgbe driver and
> it is actually a port
> from the out-of-tree ixgbe driver. In-band firmware update is one of the
> essential system maintenance
> tasks. To simplify this
On Sun, Jun 09, 2024 at 04:15:26PM +0800, Richard chien wrote:
> This patch adds support for firmware update to the in-tree igb driver and it
> is actually a port from the out-of-tree igb driver.
> In-band firmware update is one of the essential system maintenance tasks. To
> simplify this task,
> Yea, its extremely easy to break things if you don't know what you're
> doing here. So its more a question of "are we ok exposing yet another
> way root can brick things?"
Many MAC drivers allow it, and we have not had complaints. It is not
really something i'm a fan of, it in theory allows user
On Wed, Jun 05, 2024 at 01:51:24PM -0700, Jacob Keller wrote:
>
>
> On 6/3/2024 8:10 PM, jackie.j...@alliedtelesis.co.nz wrote:
> > From: Jackie Jone
> >
> > To facilitate running PHY parametric tests, add support for the SIOCSMIIREG
> > ioctl. This allows a userspace application to write to th
On Mon, May 13, 2024 at 03:42:50PM +0700, Bagas Sanjaya wrote:
> Hi,
>
> reported on Bugzilla
> (https://bugzilla.kernel.org/show_bug.cgi?id=218826) regression on his
> Thinkpad
> T480 with Intel I219-LM:
>
> > After updating from kernel version 6.1.90 to 6.6.30, the e1000e driver
> > exhibits
> > It would be interesting to see what the link partner sees. What does
> > it think the I219-LM is advertising? Is it advertising 1000BaseT_Half?
>
> i219 parts come with LSI PHY. 1000BASE-T half-duplex is not supported.
> 1000BASET half-duplex not advertised in IEEE 1000BASE-T Control Register
On Thu, May 09, 2024 at 12:13:27PM +0300, Ruinskiy, Dima wrote:
> On 08/05/2024 8:05, Sasha Neftin wrote:
> > On 07/05/2024 15:31, Andrew Lunn wrote:
> > > On Fri, May 03, 2024 at 06:18:36PM +0800, Ricky Wu wrote:
> > > > As described in https://bugzilla.ker
On Fri, May 03, 2024 at 06:18:36PM +0800, Ricky Wu wrote:
> As described in https://bugzilla.kernel.org/show_bug.cgi?id=218642,
> Intel I219-LM reports link up -> link down -> link up after hot-plugging
> the Ethernet cable.
Please could you quote some parts of 802.3 which state this is a
problem.
> > (1) How serious this problem is. It is normal for link establishment to
> > take a few seconds from plugging the cable (due to PHY
> > auto-negotiation), and I can accept some link instability during that time.
> Actually, the problem is not critical since the link will be up
> permanently afte
On Tue, May 07, 2024 at 11:24:05AM +0200, En-Wei WU wrote:
> > Why PHY is this?
> It's the Intel I219-LM, and I haven't found any other device having
> the same issue.
There is no Linux PHY driver for this device, only the code buried in
the e1000e MAC driver. Sometimes Intel use Marvell PHYs, and
On Thu, May 02, 2024 at 05:12:15PM +0800, Ricky Wu wrote:
> As described in https://bugzilla.kernel.org/show_bug.cgi?id=218642,
> some e1000e NIC reports link up -> link down -> link up when hog-plugging
> the Ethernet cable.
>
> The problem is because the unstable behavior of Link Status bit in
>
On Tue, Apr 23, 2024 at 12:24:54PM +0200, Corinna Vinschen wrote:
> During successful probe, igc logs this:
>
> [5.133667] igc :01:00.0 (unnamed net_device) (uninitialized): PHC
> added
>
> The reason is that igc_ptp_ini
On Fri, Apr 12, 2024 at 03:21:24PM +0200, Wojciech Drewek wrote:
>
>
> On 09.04.2024 15:39, Andrew Lunn wrote:
> >> This is something my current design supports I think. Using
> >> ETHTOOL_A_MODULE_MAX_POWER_SET user can get what cage supports
> >> and chan
> This is something my current design supports I think. Using
> ETHTOOL_A_MODULE_MAX_POWER_SET user can get what cage supports
> and change it.
> This could be done using ethtool_module_power_mode_policy I think.
All these 'I think' don't give me a warm fuzzy feeling this is a well
thought out a
On Thu, Apr 04, 2024 at 02:45:43PM +0200, Wojciech Drewek wrote:
>
>
> On 03.04.2024 15:49, Andrew Lunn wrote:
> >>> $ ethtool --set-module enp1s0f0np0 power-max-set 4000
> >>>
> >>> actually talk to the SFP module and tell it the maximum power it
> > $ ethtool --set-module enp1s0f0np0 power-max-set 4000
> >
> > actually talk to the SFP module and tell it the maximum power it can
> > consume. So in this case, it is not the cage, but the module?
>
> It does not work that way in ice example.
> >
> > Or is it talking to some entity which is
On Wed, Apr 03, 2024 at 03:18:44PM +0200, Wojciech Drewek wrote:
>
>
> On 02.04.2024 16:46, Andrew Lunn wrote:
> > On Tue, Apr 02, 2024 at 01:38:59PM +0200, Wojciech Drewek wrote:
> >>
> >>
> >> On 30.03.2024 22:57, Andrew Lunn wrote:
> >>&
On Tue, Apr 02, 2024 at 07:25:47AM -0700, Jakub Kicinski wrote:
> On Tue, 2 Apr 2024 13:38:59 +0200 Wojciech Drewek wrote:
> > > Also, this is about the board, the SFP cage, not the actual SFP
> > > module? Maybe the word cage needs to be in these names?
> >
> > It's about cage. Thanks for brin
On Tue, Apr 02, 2024 at 01:38:59PM +0200, Wojciech Drewek wrote:
>
>
> On 30.03.2024 22:57, Andrew Lunn wrote:
> > On Fri, Mar 29, 2024 at 10:23:18AM +0100, Wojciech Drewek wrote:
> >> Some ethernet modules use nonstandard power levels [1]. Extend ethtool
> >>
On Fri, Mar 29, 2024 at 10:23:20AM +0100, Wojciech Drewek wrote:
> Some modules use nonstandard power levels. Adjust ethtool
> module implementation to support new attributes that will allow user
> to change maximum power.
>
> Add three new get attributes:
> ETHTOOL_A_MODULE_MAX_POWER_SET (used fo
On Fri, Mar 29, 2024 at 10:23:18AM +0100, Wojciech Drewek wrote:
> Some ethernet modules use nonstandard power levels [1]. Extend ethtool
> module implementation to support new attributes that will allow user
> to change maximum power. Rename structures and functions to be more
> generic. Introduce
On Tue, Feb 27, 2024 at 05:04:47PM +0100, Jiri Pirko wrote:
> Tue, Feb 27, 2024 at 04:41:52PM CET, and...@lunn.ch wrote:
> >> What if it would not be unique, should they then proceed to add generic
> >> (other word would be "common") param, and make the other driver/s use
> >> it? Without deprecati
> What if it would not be unique, should they then proceed to add generic
> (other word would be "common") param, and make the other driver/s use
> it? Without deprecating the old method ofc.
If it is useful, somebody else will copy it and it will become
common. If nobody copies it, its probably n
All MAC drivers have been converted to use the link mode members of
keee. So remove the _u32 values, and the code in the ethtool core to
convert the legacy _u32 values to link modes.
Reviewed-by: Simon Horman
Signed-off-by: Andrew Lunn
---
include/linux/ethtool.h | 3 ---
net/ethtool/eee.c
Make use of the existing linkmode helpers for converting PHY EEE
register values into links modes, now that ethtool_keee uses link
modes, rather than u32 values.
Reviewed-by: Simon Horman
Signed-off-by: Andrew Lunn
---
drivers/net/ethernet/intel/igc/igc_ethtool.c | 9 +
1 file changed
Make use of the existing linkmode helpers for converting PHY EEE
register values into links modes, now that ethtool_keee uses link
modes, rather than u32 values.
Reviewed-by: Simon Horman
Signed-off-by: Andrew Lunn
---
drivers/net/ethernet/intel/igb/igb_ethtool.c | 35
Make use of the existing linkmode helpers for converting PHY EEE
register values into links modes, now that ethtool_keee uses link
modes, rather than u32 values.
Reviewed-by: Simon Horman
Signed-off-by: Andrew Lunn
---
drivers/net/ethernet/intel/e1000e/ethtool.c | 17 -
1 file
Jacob Keller
Signed-off-by: Andrew Lunn
---
drivers/net/ethernet/intel/i40e/i40e_ethtool.c | 7 +--
drivers/net/ethernet/intel/igc/igc_ethtool.c | 4
2 files changed, 1 insertion(+), 10 deletions(-)
diff --git a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c
b/drivers/net/ethernet/intel
Convert the tables to make use of ETHTOOL link mode bits, rather than
the old u32 SUPPORTED speeds. Make use of the linkmode helps to set
bits and compare linkmodes. As a result, the _u32 members of keee are
no longer used, a step towards removing them.
Signed-off-by: Andrew Lunn
---
drivers
Make use of the existing linkmode helpers for bit manipulation of EEE
advertise, support and link partner support. The aim is to drop the
restricted _u32 variants in the near future.
Reviewed-by: Simon Horman
Signed-off-by: Andrew Lunn
---
drivers/net/ethernet/qlogic/qede/qede_ethtool.c | 60
Make use of the existing linkmode helpers for converting PHY EEE
register values into links modes, now that ethtool_keee uses link
modes, rather than u32 values.
Signed-off-by: Andrew Lunn
---
drivers/net/usb/ax88179_178a.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff
valid in for the current link mode. This then requires that PHYLIB is
selected.
Reviewed-by: Simon Horman
Signed-off-by: Andrew Lunn
---
drivers/net/usb/Kconfig | 1 +
drivers/net/usb/r8152.c | 33 -
2 files changed, 17 insertions(+), 17 deletions(-)
diff --git
deletes
this code.
With all users of the legacy _u32 changed to link modes, the _u32
values are removed from keee, and support for them in the ethtool core
is removed.
Signed-off-by: Andrew Lunn
---
Changes in v5:
- Restore zeroing eee_data.advertised in ax8817_178a
- Fix lp_advertised -> supported
On Wed, Feb 21, 2024 at 10:28:51AM +, Simon Horman wrote:
> On Tue, Feb 20, 2024 at 03:45:28PM +0100, Andrew Lunn wrote:
> > > > + unsupp = linkmode_andnot(tmp, edata->advertised, supported);
> > >
> > > nit: Given the types involved, I might have wr
On Tue, Feb 20, 2024 at 12:06:43PM +, Simon Horman wrote:
> On Sun, Feb 18, 2024 at 11:07:01AM -0600, Andrew Lunn wrote:
> > Convert the tables to make use of ETHTOOL link mode bits, rather than
> > the old u32 SUPPORTED speeds. Make use of the linkmode helps to set
>
> > + unsupp = linkmode_andnot(tmp, edata->advertised, supported);
>
> nit: Given the types involved, I might have written this as:
>
> unsupp = !!linkmode_andnot(tmp, edata->advertised, supported);
linkmode_andnot() calls bitmap_andnot():
static inline bool bitmap_andnot(unsigned long
On Tue, Feb 20, 2024 at 12:39:24PM +, Simon Horman wrote:
> On Sun, Feb 18, 2024 at 11:06:59AM -0600, Andrew Lunn wrote:
> > Make use of the existing linkmode helpers for converting PHY EEE
> > register values into links modes, now that ethtool_keee uses link
> > modes, r
All MAC drivers have been converted to use the link mode members of
keee. So remove the _u32 values, and the code in the ethtool core to
convert the legacy _u32 values to link modes.
Signed-off-by: Andrew Lunn
---
include/linux/ethtool.h | 3 ---
net/ethtool/eee.c | 31
Make use of the existing linkmode helpers for converting PHY EEE
register values into links modes, now that ethtool_keee uses link
modes, rather than u32 values.
Signed-off-by: Andrew Lunn
---
drivers/net/ethernet/intel/igc/igc_ethtool.c | 9 +
1 file changed, 5 insertions(+), 4
Make use of the existing linkmode helpers for converting PHY EEE
register values into links modes, now that ethtool_keee uses link
modes, rather than u32 values.
Signed-off-by: Andrew Lunn
---
drivers/net/ethernet/intel/igb/igb_ethtool.c | 35 ++--
1 file changed, 23
Make use of the existing linkmode helpers for converting PHY EEE
register values into links modes, now that ethtool_keee uses link
modes, rather than u32 values.
Signed-off-by: Andrew Lunn
---
drivers/net/ethernet/intel/e1000e/ethtool.c | 17 -
1 file changed, 12 insertions
Jacob Keller
Signed-off-by: Andrew Lunn
---
drivers/net/ethernet/intel/i40e/i40e_ethtool.c | 7 +--
drivers/net/ethernet/intel/igc/igc_ethtool.c | 4
2 files changed, 1 insertion(+), 10 deletions(-)
diff --git a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c
b/drivers/net/ethernet/intel
Convert the tables to make use of ETHTOOL link mode bits, rather than
the old u32 SUPPORTED speeds. Make use of the linkmode helps to set
bits and compare linkmodes. As a result, the _u32 members of keee are
no longer used, a step towards removing them.
Signed-off-by: Andrew Lunn
---
drivers
Make use of the existing linkmode helpers for converting PHY EEE
register values into links modes, now that ethtool_keee uses link
modes, rather than u32 values.
Signed-off-by: Andrew Lunn
---
drivers/net/usb/ax88179_178a.c | 9 -
1 file changed, 4 insertions(+), 5 deletions(-)
diff
Make use of the existing linkmode helpers for bit manipulation of EEE
advertise, support and link partner support. The aim is to drop the
restricted _u32 variants in the near future.
Signed-off-by: Andrew Lunn
---
drivers/net/ethernet/qlogic/qede/qede_ethtool.c | 60 -
1
deletes
this code.
With all users of the legacy _u32 changed to link modes, the _u32
values are removed from keee, and support for them in the ethtool core
is removed.
Signed-off-by: Andrew Lunn
---
Changes in v4:
- Add missing conversion in igb
- Add missing conversion in r8152
- Add patch to remove
valid in for the current link mode. This then requires that PHYLIB is
selected.
Signed-off-by: Andrew Lunn
---
drivers/net/usb/Kconfig | 1 +
drivers/net/usb/r8152.c | 33 -
2 files changed, 17 insertions(+), 17 deletions(-)
diff --git a/drivers/net/usb/Kconfig b
On Sat, Feb 17, 2024 at 12:08:22PM -0600, Andrew Lunn wrote:
> Make use of the existing linkmode helpers for converting PHY EEE
> register values into links modes, now that ethtool_keee uses link
> modes, rather than u32 values.
>
> Rework determining if EEE is active to make is si
Make use of the existing linkmode helpers for converting PHY EEE
register values into links modes, now that ethtool_keee uses link
modes, rather than u32 values.
Signed-off-by: Andrew Lunn
---
drivers/net/ethernet/intel/igc/igc_ethtool.c | 9 +
1 file changed, 5 insertions(+), 4
Make use of the existing linkmode helpers for converting PHY EEE
register values into links modes, now that ethtool_keee uses link
modes, rather than u32 values.
Signed-off-by: Andrew Lunn
---
drivers/net/ethernet/intel/igb/igb_ethtool.c | 33 ++--
1 file changed, 22
Make use of the existing linkmode helpers for converting PHY EEE
register values into links modes, now that ethtool_keee uses link
modes, rather than u32 values.
Signed-off-by: Andrew Lunn
---
drivers/net/ethernet/intel/e1000e/ethtool.c | 17 -
1 file changed, 12 insertions
Jacob Keller
Signed-off-by: Andrew Lunn
---
drivers/net/ethernet/intel/i40e/i40e_ethtool.c | 7 +--
drivers/net/ethernet/intel/igc/igc_ethtool.c | 4
2 files changed, 1 insertion(+), 10 deletions(-)
diff --git a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c
b/drivers/net/ethernet/intel
Convert the tables to make use of ETHTOOL link mode bits, rather than
the old u32 SUPPORTED speeds. Make use of the linkmode helps to set
bits and compare linkmodes. As a result, the _u32 members of keee are
no longer used, a step towards removing them.
Signed-off-by: Andrew Lunn
---
drivers
Make use of the existing linkmode helpers for bit manipulation of EEE
advertise, support and link partner support. The aim is to drop the
restricted _u32 variants in the near future.
Signed-off-by: Andrew Lunn
---
drivers/net/ethernet/qlogic/qede/qede_ethtool.c | 60 -
1
does not display
it, and EEE is always negotiated. One patch in this series deletes
this code. Comments on why its actually useful and should be kept are
gratefully received.
Signed-off-by: Andrew Lunn
---
Changes in v3:
- Add list of commits adding linkmodes to EEE to cover letter
- Fix grammar
Make use of the existing linkmode helpers for converting PHY EEE
register values into links modes, now that ethtool_keee uses link
modes, rather than u32 values.
Signed-off-by: Andrew Lunn
---
drivers/net/usb/ax88179_178a.c | 9 -
1 file changed, 4 insertions(+), 5 deletions(-)
diff
valid in for the current link mode. This then requires that PHYLIB is
selected.
Signed-off-by: Andrew Lunn
---
drivers/net/usb/Kconfig | 1 +
drivers/net/usb/r8152.c | 31 +++
2 files changed, 16 insertions(+), 16 deletions(-)
diff --git a/drivers/net/usb/Kconfig b
> Am 15.02.24 um 12:13 AM schrieb Andrew Lunn:
> > EEE has until recently been limited to lower speeds due to the use of
> > the legacy u32 for link speeds. This restriction has been lifted, with
> > the use of linkmode bitmaps. This patchset convert some MAC drivers
>
Make use of the existing linkmode helpers for converting PHY EEE
register values into links modes, now that ethtool_keee uses link
modes, rather than u32 values.
Signed-off-by: Andrew Lunn
---
drivers/net/ethernet/intel/igc/igc_ethtool.c | 9 +
1 file changed, 5 insertions(+), 4
Make use of the existing linkmode helpers for converting PHY EEE
register values into links modes, now that ethtool_keee uses link
modes, rather than u32 values.
Signed-off-by: Andrew Lunn
---
drivers/net/ethernet/intel/igb/igb_ethtool.c | 33 ++--
1 file changed, 22
Make use of the existing linkmode helpers for converting PHY EEE
register values into links modes, now that ethtool_keee uses link
modes, rather than u32 values.
Signed-off-by: Andrew Lunn
---
drivers/net/ethernet/intel/e1000e/ethtool.c | 17 -
1 file changed, 12 insertions
Energy Efficient Ethernet should always be negotiated with the link
peer. Don't include SUPPORTED_Autoneg in the results of get_eee() for
supported, advertised or lp_advertised, since it is
assumed. Additionally, ethtool(1) ignores the set bit, and no other
driver sets this.
Signed-off-by: A
Convert the tables to make use of ETHTOOL link mode bits, rather than
the old u32 SUPPORTED speeds. Make use of the linkmode helps to set
bits and compare linkmodes. As a result, the _u32 members of keee are
no longer used, a step towards removing them.
Signed-off-by: Andrew Lunn
---
drivers
Make use of the existing linkmode helpers for bit manipulation of EEE
advertise, support and link partner support. The aim is to drop the
restricted _u32 variants in the near future.
Signed-off-by: Andrew Lunn
---
drivers/net/ethernet/qlogic/qede/qede_ethtool.c | 60 -
1
Make use of the existing linkmode helpers for converting PHY EEE
register values into links modes, now that ethtool_keee uses link
modes, rather than u32 values.
Signed-off-by: Andrew Lunn
---
drivers/net/usb/ax88179_178a.c | 9 -
1 file changed, 4 insertions(+), 5 deletions(-)
diff
valid in for the current link mode. This then requires that PHYLIB is
selected.
Signed-off-by: Andrew Lunn
---
drivers/net/usb/Kconfig | 1 +
drivers/net/usb/r8152.c | 31 +++
2 files changed, 16 insertions(+), 16 deletions(-)
diff --git a/drivers/net/usb/Kconfig b
should be kept are
gratefully received.
Signed-off-by: Andrew Lunn
---
Changes in v2:
- igb: Fix type 100BaseT to 1000BaseT.
- Link to v1:
https://lore.kernel.org/r/20240204-keee-u32-cleanup-v1-0-fb6e08329...@lunn.ch
---
Andrew Lunn (8):
net: usb: r8152: Use linkmode helpers for EEE
On Fri, Feb 09, 2024 at 09:18:02AM +1100, Jon Maxwell wrote:
> v2: Remove the "debug" module parameter as per Andrew Lunns suggestion.
> It's not really needed as ethtool msglvl can control that.
It is normal to places comments like the above under the ---. In its
current place, it will be par
On Thu, Feb 08, 2024 at 10:04:30AM +1100, Jon Maxwell wrote:
> Linux users sometimes need an easy way to check current values of module
> parameters. For example the module may be manually reloaded with different
> parameters. Make these visible and readable in the /sys filesystem to allow
> that.
upported. Other modes are simulated
> in software by using on/off. Tested on Intel i225.
>
> Signed-off-by: Kurt Kanzenbach
It looks like the mutex could be a spinlock, which is probably
cheaper. But the code is O.K. as it is:
Reviewed-by: Andrew Lunn
Andrew
> > - adv100m_eee = !!(edata->advertised_u32 & ADVERTISE_100_FULL);
> > - adv1g_eee = !!(edata->advertised_u32 & ADVERTISE_1000_FULL);
> > + adv100m_eee = linkmode_test_bit(
> > + ETHTOOL_LINK_MODE_100baseT_Full_BIT,
> > + edata->adv
On Sun, Feb 04, 2024 at 05:40:17PM -0600, Andrew Lunn wrote:
> EEE has until recently been limited to lower speeds due to the use of
> the legacy u32 for link speeds. This restriction has been lifted, with
> the use of linkmode bitmaps. This patchset convert some MAC drivers
> still u
Make use of the existing linkmode helpers for converting PHY EEE
register values into links modes, now that ethtool_keee uses link
modes, rather than u32 values.
Signed-off-by: Andrew Lunn
---
drivers/net/ethernet/intel/igc/igc_ethtool.c | 9 +
1 file changed, 5 insertions(+), 4
Make use of the existing linkmode helpers for converting PHY EEE
register values into links modes, now that ethtool_keee uses link
modes, rather than u32 values.
Signed-off-by: Andrew Lunn
---
drivers/net/ethernet/intel/igb/igb_ethtool.c | 33 ++--
1 file changed, 22
Make use of the existing linkmode helpers for converting PHY EEE
register values into links modes, now that ethtool_keee uses link
modes, rather than u32 values.
Signed-off-by: Andrew Lunn
---
drivers/net/ethernet/intel/e1000e/ethtool.c | 17 -
1 file changed, 12 insertions
Energy Efficient Ethernet should always be negotiated with the link
peer. Don't include SUPPORTED_Autoneg in the results of get_eee() for
supported, advertised or lp_advertised, since it is
assumed. Additionally, ethtool(1) ignores the set bit, and no other
driver sets this.
Signed-off-by: A
Convert the tables to make use of ETHTOOL link mode bits, rather than
the old u32 SUPPORTED speeds. Make use of the linkmode helps to set
bits and compare linkmodes. As a result, the _u32 members of keee are
no longer used, a step towards removing them.
Signed-off-by: Andrew Lunn
---
drivers
Make use of the existing linkmode helpers for bit manipulation of EEE
advertise, support and link partner support. The aim is to drop the
restricted _u32 variants in the near future.
Signed-off-by: Andrew Lunn
---
drivers/net/ethernet/qlogic/qede/qede_ethtool.c | 60 -
1
Make use of the existing linkmode helpers for converting PHY EEE
register values into links modes, now that ethtool_keee uses link
modes, rather than u32 values.
Signed-off-by: Andrew Lunn
---
drivers/net/usb/ax88179_178a.c | 9 -
1 file changed, 4 insertions(+), 5 deletions(-)
diff
valid in for the current link mode. This then requires that PHYLIB is
selected.
Signed-off-by: Andrew Lunn
---
drivers/net/usb/Kconfig | 1 +
drivers/net/usb/r8152.c | 31 +++
2 files changed, 16 insertions(+), 16 deletions(-)
diff --git a/drivers/net/usb/Kconfig b
should be kept are
gratefully received.
Signed-off-by: Andrew Lunn
---
Andrew Lunn (8):
net: usb: r8152: Use linkmode helpers for EEE
net: usb: ax88179_178a: Use linkmode helpers for EEE
net: qlogic: qede: Use linkmode helpers for EEE
net: ethernet: ixgbe: Convert EEE to
On Thu, Feb 01, 2024 at 01:59:46PM +0100, Kurt Kanzenbach wrote:
> Add support for LEDs on i225/i226. The LEDs can be controlled via sysfs
> from user space using the netdev trigger. The LEDs are named as
> igc-- to be easily identified.
>
> Offloading link speed is supported. Other modes are simu
On Thu, Jan 25, 2024 at 08:31:54AM +0100, Kurt Kanzenbach wrote:
> On Wed Jan 24 2024, Andrew Lunn wrote:
> > On Wed, Jan 24, 2024 at 09:24:08AM +0100, Kurt Kanzenbach wrote:
> >> Add support for LEDs on i225/i226. The LEDs can be controlled via sysfs
> >> from user spa
On Wed, Jan 24, 2024 at 09:24:08AM +0100, Kurt Kanzenbach wrote:
> Add support for LEDs on i225/i226. The LEDs can be controlled via sysfs
> from user space using the netdev trigger. The LEDs are named as
> igc-- to be easily identified.
>
> Offloading activity and link speed is supported. Tested
intf(&data, buffer[i].name);
> or when it's used with format string: "%s"
> | ethtool_sprintf(&data, "%s", buffer[i].name);
> which both now become:
> | ethtool_puts(&data, buffer[i].name);
>
On Wed, Dec 06, 2023 at 11:16:10PM +, justinst...@google.com wrote:
> Use strscpy() to implement ethtool_puts().
>
> Functionally the same as ethtool_sprintf() when it's used with two
> arguments or with just "%s" format specifier.
>
> Signed-off-by: Justin
> Yes, this info is available via the "devlink dev info" command.
> Adding this info in dmesg ensures the version information is
> available when someone is looking at the dmesg log to debug an issue.
Ideally you would train your users to use devlink info, since you get
more useful information,
On Wed, Nov 29, 2023 at 09:56:04AM -0800, Sachin Bahadur wrote:
> Print NIC FW version during PF initialization. FW version in dmesg is used
> to identify and isolate issues. Particularly useful when dmesg is read
> after reboot.
>
> Example log from dmesg:
> ice :ca:00.0: fw 6.2.9 api 1.7.9 n
> > + vmxnet3_rq_driver_stats[i].desc);
> > }
> >
> > for (i = 0; i < ARRAY_SIZE(vmxnet3_global_stats); i++)
> > - ethtool_sprintf(&buf, vmxnet3_global_stats[i].desc);
> > + ethtool_puts(&buf, vmxnet3_global_stats[i].desc);
> > }
> >
> > netdev_featur
1 - 100 of 107 matches
Mail list logo
