> -Original Message-
> From: Intel-wired-lan On Behalf Of
> Jesse Brandeburg
> Sent: Tuesday, April 8, 2025 1:20 AM
> To: intel-wired-...@lists.osuosl.org
> Cc: net...@vger.kernel.org; Nguyen, Anthony L
> ; Kitszel, Przemyslaw
> ; Andrew Lunn ;
> David S. Miller ; Dumazet, Eric
> ; Jaku
在 2025/3/27 18:22, Przemek Kitszel 写道:
On 3/25/25 03:01, Xuanqiang Luo wrote:
From: Xuanqiang Luo
As mentioned in the commit baeb705fd6a7 ("ice: always check VF VSI
pointer values"), we need to perform a null pointer check on the return
value of ice_get_vf_vsi() before using it.
v2: Add "iw
在 2025/4/7 22:02, Simon Horman 写道:
On Tue, Mar 25, 2025 at 10:01:49AM +0800, Xuanqiang Luo wrote:
From: Xuanqiang Luo
As mentioned in the commit baeb705fd6a7 ("ice: always check VF VSI
pointer values"), we need to perform a null pointer check on the return
value of ice_get_vf_vsi() before us
Hi Przemek,
kernel test robot noticed the following build errors:
[auto build test ERROR on tnguy-net-queue/dev-queue]
url:
https://github.com/intel-lab-lkp/linux/commits/Przemek-Kitszel/ice-use-DSN-instead-of-PCI-BDF-for-ice_adapter-index/20250407-192849
base: https://git.kernel.org/pub
On Mon, Apr 07, 2025 at 11:49:35PM +0200, Oleksandr Natalenko wrote:
> $ make drivers/net/ethernet/intel/ice/ice.o
> …
> LD [M] drivers/net/ethernet/intel/ice/ice.o
> drivers/net/ethernet/intel/ice/ice.o: error: objtool:
> ice_free_prof_mask.isra.0() falls through to next function
> ice_free_f
This patch implements the software flows to handle SRIOV VF
communication across an Active/Active link aggregate. The same
restrictions apply as are in place for the support of Active/Backup
bonds.
- the two interfaces must be on the same NIC
- the FW LLDP engine needs to be disabled
- the DDP pa
From: Jesse Brandeburg
The driver was being inconsistent when de-registering its PTP clock. Make
sure to NULL out the pointer once it is freed in all cases. The driver was
mostly already doing so, but a couple spots were missed.
Signed-off-by: Jesse Brandeburg
---
NOTE: we saw some odd behavior
Hello.
On pondělí 7. dubna 2025 23:42:51, středoevropský letní čas Josh Poimboeuf
wrote:
> On Mon, Apr 07, 2025 at 11:21:27AM +0200, Oleksandr Natalenko wrote:
> > It's not a new warning, I've observe it for several recent major kernel
> > releases already.
> >
> > I do not build with CONFIG_CO
On Mon, Apr 07, 2025 at 12:35:37PM +, Marek Pazdan wrote:
> Signal Definition section (Other signals) of SFF-8636 Spec mentions that
> additional signals like reset and module present may be implemented for
> a specific hardware. There is currently no user space API for control of
> those signa
In preparation for implementing SRIOV Active-Active LAG support,
cleanup several unneeded variable initializations in declaration
blocks.
Also move a couple of variable initializations into declaration
block that shouold be there.
Reviewed-by: Przemek Kitszel
Signed-off-by: Dave Ertman
---
dri
A define in the LAG code is missing a driver specific prefix.
Add a prefix to the define.
Also shorten a defines name and move to a more logical place.
Reviewed-by: Przemek Kitszel
Signed-off-by: Dave Ertman
---
drivers/net/ethernet/intel/ice/ice_lag.c | 20 +---
1 file changed
When evaluating the capabilities field, the ICE_AQC_BIT_ROCEV2_LAG and
ICE_AQC_BIT_SRIOV_LAG defines were both not using the BIT operator, instead
simply setting a hex value that set the correct bits. While not inaccurate,
this method is misleading, and when it is expanded in the following
impleme
Use the new virtchnl2 OP codes to communicate with the Control Plane to
add flow steering filters. We add the basic functionality for ADD/Delete
with TCP/UDP IPv4 only. Support for other OP codes and protocols will be
added later.
Standard 'ethtool -N|--config-ntuple' should be used, for example:
Add basic flow steering. For now, we support IPv4 and TCP/UDP only.
Patch 1 renames "enum virtchnl2_cap_rss" to a more generic "enum
virtchnl2_flow_types" that can be used with RSS and flow steering.
Patch 2 adds the required flow steering virtchnl2 OP codes and patch 3
adds the required flow st
The "enum virtchnl2_cap_rss" will be used for negotiating flow
steering capabilities. Instead of adding a new enum, rename
virtchnl2_cap_rss to virtchnl2_flow_types. Also rename the enum's
constants.
Flow steering will use this enum in the next patches.
Reviewed-by: Sridhar Samudrala
Signed-off-
Signal Definition section (Other signals) of SFF-8636 Spec mentions that
additional signals like reset and module present may be implemented for
a specific hardware. There is currently no user space API for control of
those signals so user space management applications have no chance to
perform som
On Mon, 7 Apr 2025 12:35:37 +
Marek Pazdan wrote:
> Signal Definition section (Other signals) of SFF-8636 Spec mentions that
> additional signals like reset and module present may be implemented for
> a specific hardware. There is currently no user space API for control of
> those signals so
On Mon, 7 Apr 2025 12:35:38 +
Marek Pazdan wrote:
> Commit f3c1c896f5a8 ("ethtool: transceiver reset and presence pin control")
> adds ioctl API extension for get/set-phy-tunable so that transceiver
> reset and presence pin control is enabled.
I don't think pointing and explaining the first
Hello.
With v6.15-rc1, CONFIG_OBJTOOL_WERROR=y and gcc 14.2.1 the following happens:
```
drivers/net/ethernet/intel/ice/ice.o: error: objtool:
ice_free_prof_mask.isra.0() falls through to next function
ice_free_flow_profs.cold()
drivers/net/ethernet/intel/ice/ice.o: error: objtool:
ice_free_pr
Hello.
On pondělí 7. dubna 2025 11:03:31, středoevropský letní čas Przemek Kitszel
wrote:
> On 4/7/25 08:20, Oleksandr Natalenko wrote:
> > Hello.
> >
> > With v6.15-rc1, CONFIG_OBJTOOL_WERROR=y and gcc 14.2.1 the following
> > happens:
>
> have you COMPILE_TEST'ed whole kernel and this is the
The e1000_suspend_workarounds_ich8lan() calls e1e_rphy_locked to disable
the SMB release, but does not check its return value. A proper
implementation can be found in e1000_resume_workarounds_pchlan() from
/source/drivers/net/ethernet/intel/e1000e/ich8lan.c.
Add an error check for e1e_rphy_locked(
Commit f3c1c896f5a8 ("ethtool: transceiver reset and presence pin control")
adds ioctl API extension for get/set-phy-tunable so that transceiver
reset and presence pin control is enabled.
This commit adds functionality to utilize the API in ice driver.
According to E810 datasheet QSFP reset and pre
On 4/7/25 13:42, Michal Kubiak wrote:
On Mon, Apr 07, 2025 at 01:20:05PM +0200, Przemek Kitszel wrote:
Use Device Serial Number instead of PCI bus/device/function for
index of struct ice_adapter.
Functions on the same physical device should point to the very same
ice_adapter instance.
This is n
struct ice_adapter {
refcount_t refcount;
/* For access to the GLTSYN_TIME register */
spinlock_t ptp_gltsyn_time_lock;
struct ice_pf *ctrl_pf;
struct ice_port_list ports;
+ u64 device_serial_number;
};
+ index = ice_adapter_index(dsn);
On Fri, Mar 21, 2025 at 02:52:38PM +0100, Kurt Kanzenbach wrote:
> Limit netdev_tc calls to MQPRIO. Currently these calls are made in
> igc_tsn_enable_offload() and igc_tsn_disable_offload() which are used by
> TAPRIO and ETF as well. However, these are only required for MQPRIO.
>
> Signed-off-by:
On Fri, Mar 21, 2025 at 02:52:39PM +0100, Kurt Kanzenbach wrote:
> The current MQPRIO offload implementation uses the legacy TSN Tx mode. In
> this mode the hardware uses four packet buffers and considers queue
> priorities.
>
> In order to harmonize the TAPRIO implementation with MQPRIO, switch t
Mon, Apr 07, 2025 at 01:20:05PM +0200, przemyslaw.kits...@intel.com wrote:
>Use Device Serial Number instead of PCI bus/device/function for
>index of struct ice_adapter.
>Functions on the same physical device should point to the very same
>ice_adapter instance.
>
>This is not only simplification, b
On Mon, Apr 07, 2025 at 01:20:05PM +0200, Przemek Kitszel wrote:
> Use Device Serial Number instead of PCI bus/device/function for
> index of struct ice_adapter.
> Functions on the same physical device should point to the very same
> ice_adapter instance.
>
> This is not only simplification, but a
Use Device Serial Number instead of PCI bus/device/function for
index of struct ice_adapter.
Functions on the same physical device should point to the very same
ice_adapter instance.
This is not only simplification, but also fixes things up when PF
is passed to VM (and thus has a random BDF).
Sug
On Fri, Apr 04, 2025 at 12:54:21PM +0200, Michal Swiatkowski wrote:
> In case of failing on rss_data->rss_key allocation the function is
> freeing vport without freeing earlier allocated q_vector_idxs. Fix it.
>
> Move from freeing in error branch to goto scheme.
>
> Fixes: 95af467d9a4e ("idpf: c
On 4/7/25 08:20, Oleksandr Natalenko wrote:
Hello.
With v6.15-rc1, CONFIG_OBJTOOL_WERROR=y and gcc 14.2.1 the following happens:
have you COMPILE_TEST'ed whole kernel and this is the only (new) error?
```
drivers/net/ethernet/intel/ice/ice.o: error: objtool:
ice_free_prof_mask.isra.0() fal
31 matches
Mail list logo
