Re: [Intel-wired-lan] [PATCH net] igc: Fix passing 0 to ERR_PTR in igc_xdp_run_prog()

2024-10-17 Thread Kurt Kanzenbach
On Thu Oct 17 2024, Jacob Keller wrote: > On 10/17/2024 4:03 AM, Maciej Fijalkowski wrote: >> On Thu, Oct 17, 2024 at 11:55:05AM +0800, Yue Haibing wrote: >>> On 2024/10/17 7:12, Jacob Keller wrote: On 10/16/2024 4:06 PM, Jacob Keller wrote: > I don't like this fix, I think we could drop t

Re: [Intel-wired-lan] [PATCH iwl-next v9 2/7] ixgbe: Add support for E610 device capabilities detection

2024-10-17 Thread Kalesh Anakkur Purayil
On Thu, Oct 3, 2024 at 7:48 PM Piotr Kwapulinski wrote: > > Add low level support for E610 device capabilities detection. The > capabilities are discovered via the Admin Command Interface. Discover the > following capabilities: > - function caps: vmdq, dcb, rss, rx/tx qs, msix, nvm, orom, reset >

[Intel-wired-lan] [PATCH v2 net 1/4] igc: Fix passing 0 to ERR_PTR in igc_xdp_run_prog()

2024-10-17 Thread Yue Haibing
igc_xdp_run_prog() converts customed xdp action to a negative error code with the sk_buff pointer type which be checked with IS_ERR in igc_clean_rx_irq(). Remove this error pointer handing instead use plain int return value to fix this smatch warnings: drivers/net/ethernet/intel/igc/igc_main.c:253

[Intel-wired-lan] [PATCH v2 net 2/4] igb: Fix passing 0 to ERR_PTR in igb_run_xdp()

2024-10-17 Thread Yue Haibing
igb_run_xdp() converts customed xdp action to a negative error code with the sk_buff pointer type which be checked with IS_ERR in igb_clean_rx_irq(). Remove this error pointer handing instead use plain int return value. Fixes: 9cbc948b5a20 ("igb: add XDP support") Signed-off-by: Yue Haibing ---

[Intel-wired-lan] [PATCH v2 net 3/4] ixgbe: Fix passing 0 to ERR_PTR in ixgbe_run_xdp()

2024-10-17 Thread Yue Haibing
ixgbe_run_xdp() converts customed xdp action to a negative error code with the sk_buff pointer type which be checked with IS_ERR in ixgbe_clean_rx_irq(). Remove this error pointer handing instead use plain int return value. Fixes: 924708081629 ("ixgbe: add XDP support for pass and drop actions") S

[Intel-wired-lan] [PATCH v2 net 4/4] ixgbevf: Fix passing 0 to ERR_PTR in ixgbevf_run_xdp()

2024-10-17 Thread Yue Haibing
ixgbevf_run_xdp() converts customed xdp action to a negative error code with the sk_buff pointer type which be checked with IS_ERR in ixgbevf_clean_rx_irq(). Remove this error pointer handing instead use plain int return value. Fixes: c7aec59657b6 ("ixgbevf: Add XDP support for pass and drop actio

[Intel-wired-lan] [PATCH v2 net 0/4] Fix passing 0 to ERR_PTR in intel ether drivers

2024-10-17 Thread Yue Haibing
Fixing sparse error in xdp run code by introducing new variable xdp_res instead of overloading this into the skb pointer as i40e drivers done in commit 12738ac4754e ("i40e: Fix sparse errors in i40e_txrx.c") and commit ae4393dfd472 ("i40e: fix broken XDP support"). v2: Fix this as i40e drivers don

Re: [Intel-wired-lan] [PATCH -next 0/4] Fix passing 0 to ERR_PTR in intel ether drivers

2024-10-17 Thread Yue Haibing
Pls ignore this corrupt patch, sorry for noise. On 2024/10/18 10:29, Yue Haibing wrote: > Fixing sparse error in xdp run code by introducing new variable xdp_res > instead of overloading this into the skb pointer as i40e drivers done > in commit 12738ac4754e ("i40e: Fix sparse errors in i40e_txrx.

[Intel-wired-lan] [PATCH net 1/4] igc: Fix passing 0 to ERR_PTR in igc_xdp_run_prog()

2024-10-17 Thread Yue Haibing
igc_xdp_run_prog() converts customed xdp action to a negative error code with the sk_buff pointer type which be checked with IS_ERR in igc_clean_rx_irq(). Remove this error pointer handing instead use plain int return value to fix this smatch warnings: drivers/net/ethernet/intel/igc/igc_main.c:253

[Intel-wired-lan] [PATCH -next 0/4] Fix passing 0 to ERR_PTR in intel ether drivers

2024-10-17 Thread Yue Haibing
Fixing sparse error in xdp run code by introducing new variable xdp_res instead of overloading this into the skb pointer as i40e drivers done in commit 12738ac4754e ("i40e: Fix sparse errors in i40e_txrx.c") and commit ae4393dfd472 ("i40e: fix broken XDP support"). Yue Haibing (4): igc: Fix pass

Re: [Intel-wired-lan] [PATCH] ixgbe: Break include dependency cycle

2024-10-17 Thread Diomidis Spinellis
On 17-Oct-24 23:36, Jacob Keller wrote: > > On 10/17/2024 1:58 AM, Diomidis Spinellis wrote: >> Header ixgbe_type.h includes ixgbe_mbx.h. Also, header >> ixgbe_mbx.h included ixgbe_type.h, thus introducing a circular >> dependency. >> [...] >> >> Signed-off-by: Diomidis Spinellis >> --- > > The

Re: [Intel-wired-lan] [PATCH] ixgbe: Break include dependency cycle

2024-10-17 Thread Jacob Keller
On 10/17/2024 1:58 AM, Diomidis Spinellis wrote: > Header ixgbe_type.h includes ixgbe_mbx.h. Also, header > ixgbe_mbx.h included ixgbe_type.h, thus introducing a circular > dependency. > > - Remove ixgbe_mbx.h inclusion from ixgbe_type.h. > > - ixgbe_mbx.h requires the definition of struct ix

Re: [Intel-wired-lan] [PATCH iwl-next v3] i40e: add ability to reset vf for tx and rx mdd events

2024-10-17 Thread Loktionov, Aleksandr
> -Original Message- > From: Loktionov, Aleksandr > Sent: Thursday, October 17, 2024 12:02 PM > To: Kitszel, Przemyslaw ; > Fijalkowski, Maciej > Cc: intel-wired-...@lists.osuosl.org; Nguyen, Anthony L > ; net...@vger.kernel.org; Sokolowski, > Jan ; Connolly, Padraig J > > Subject: RE:

[Intel-wired-lan] [tnguy-next-queue:10GbE] BUILD SUCCESS 53bac8330865417332d4cf80cb671b15956b049d

2024-10-17 Thread kernel test robot
gclang-20 arc randconfig-001-20241017gcc-14.1.0 arc randconfig-002-20241017gcc-14.1.0 arm allmodconfigclang-20 arm allnoconfiggcc-14.1.0 arm allyesconfig

Re: [Intel-wired-lan] [PATCH net] igc: Fix passing 0 to ERR_PTR in igc_xdp_run_prog()

2024-10-17 Thread Jacob Keller
On 10/17/2024 4:03 AM, Maciej Fijalkowski wrote: > On Thu, Oct 17, 2024 at 11:55:05AM +0800, Yue Haibing wrote: >> On 2024/10/17 7:12, Jacob Keller wrote: >>> On 10/16/2024 4:06 PM, Jacob Keller wrote: I don't like this fix, I think we could drop the igc_xdp_run_prog wrapper, call __ig

Re: [Intel-wired-lan] [PATCH net] igc: Fix passing 0 to ERR_PTR in igc_xdp_run_prog()

2024-10-17 Thread Jacob Keller
On 10/17/2024 7:16 AM, Simon Horman wrote: > On Wed, Oct 16, 2024 at 04:06:34PM -0700, Jacob Keller wrote: >> >> Not quite. PTR_ERR_OR_ZERO is intended for the case where you are >> extracting an error from a pointer. This is converting an error into a >> pointer. > > Yes, silly me. > >> I am

Re: [Intel-wired-lan] [RESEND PATCH iwl-next] ice: Unbind the workqueue

2024-10-17 Thread Pucha, HimasekharX Reddy
> -Original Message- > From: Intel-wired-lan On Behalf Of Tony > Nguyen > Sent: Tuesday, October 8, 2024 3:14 AM > To: intel-wired-...@lists.osuosl.org > Cc: Kitszel, Przemyslaw ; Frederic Weisbecker > ; net...@vger.kernel.org; linux-ker...@vger.kernel.org; > Zaremba, Larysa > Subject:

[Intel-wired-lan] [tnguy-net-queue:main] BUILD SUCCESS 11d06f0aaef89f4cad68b92510bd9decff2d7b87

2024-10-17 Thread kernel test robot
hexagon allyesconfigclang-20 i386 allmodconfigclang-18 i386 allnoconfigclang-18 i386 allyesconfigclang-18 i386buildonly-randconfig-001-20241017clang-18 i386

Re: [Intel-wired-lan] [PATCH iwl-next 1/2] PCI: Add PCI_VDEVICE_SUB helper macro

2024-10-17 Thread Bjorn Helgaas
On Thu, Oct 17, 2024 at 03:16:47PM +0200, Piotr Kwapulinski wrote: > PCI_VDEVICE_SUB generates the pci_device_id struct layout for > the specific PCI device/subdevice. The subvendor field is set > to PCI_ANY_ID. Private data may follow the output. > > Reviewed-by: Przemek Kitszel > Signed-off-by:

Re: [Intel-wired-lan] [PATCH net] igc: Fix passing 0 to ERR_PTR in igc_xdp_run_prog()

2024-10-17 Thread Simon Horman
On Wed, Oct 16, 2024 at 04:06:34PM -0700, Jacob Keller wrote: > > > On 10/16/2024 11:53 AM, Simon Horman wrote: > > On Wed, Oct 16, 2024 at 06:53:10PM +0800, Yue Haibing wrote: > >> Return NULL instead of passing to ERR_PTR while res is IGC_XDP_PASS, > >> which is zero, this fix smatch warnings:

Re: [Intel-wired-lan] [PATCH iwl-next v9 3/7] ixgbe: Add link management support for E610 device

2024-10-17 Thread Kalesh Anakkur Purayil
On Thu, Oct 3, 2024 at 7:49 PM Piotr Kwapulinski wrote: > > Add low level link management support for E610 device. Link management > operations are handled via the Admin Command Interface. Add the following > link management operations: > - get link capabilities > - set up link > - get media type

[Intel-wired-lan] [PATCH iwl-next 2/2] ixgbevf: Add support for Intel(R) E610 device

2024-10-17 Thread Piotr Kwapulinski
Add support for Intel(R) E610 Series of network devices. The E610 is based on X550 but adds firmware managed link, enhanced security capabilities and support for updated server manageability Reviewed-by: Przemek Kitszel Signed-off-by: Piotr Kwapulinski --- drivers/net/ethernet/intel/ixgbevf/def

[Intel-wired-lan] [PATCH iwl-next 1/2] PCI: Add PCI_VDEVICE_SUB helper macro

2024-10-17 Thread Piotr Kwapulinski
PCI_VDEVICE_SUB generates the pci_device_id struct layout for the specific PCI device/subdevice. The subvendor field is set to PCI_ANY_ID. Private data may follow the output. Reviewed-by: Przemek Kitszel Signed-off-by: Piotr Kwapulinski --- include/linux/pci.h | 14 ++ 1 file change

[Intel-wired-lan] [PATCH iwl-next 0/2] ixgbevf: Add support for Intel(R) E610 device

2024-10-17 Thread Piotr Kwapulinski
Add support for Intel(R) E610 Series of network devices. The E610 is based on X550 but adds firmware managed link, enhanced security capabilities and support for updated server manageability. Piotr Kwapulinski (2): PCI: Add PCI_VDEVICE_SUB helper macro ixgbevf: Add support for Intel(R) E610 de

Re: [Intel-wired-lan] [PATCH net] igc: Fix passing 0 to ERR_PTR in igc_xdp_run_prog()

2024-10-17 Thread Maciej Fijalkowski
On Thu, Oct 17, 2024 at 11:55:05AM +0800, Yue Haibing wrote: > On 2024/10/17 7:12, Jacob Keller wrote: > > > > > > On 10/16/2024 4:06 PM, Jacob Keller wrote: > >> > >> > >> On 10/16/2024 11:53 AM, Simon Horman wrote: > >>> On Wed, Oct 16, 2024 at 06:53:10PM +0800, Yue Haibing wrote: > Return

Re: [Intel-wired-lan] [PATCH iwl-next v2 1/2] ice: refactor "last" segment of DDP pkg

2024-10-17 Thread Simon Horman
On Thu, Oct 03, 2024 at 02:10:31AM +0200, Przemek Kitszel wrote: > Add ice_ddp_send_hunk() that buffers "sent FW hunk" calls to AQ in order > to mark the "last" one in more elegant way. Next commit will add even > more complicated "sent FW" flow, so it's better to untangle a bit before. > > Note t

Re: [Intel-wired-lan] [PATCH iwl-next v3] i40e: add ability to reset vf for tx and rx mdd events

2024-10-17 Thread Loktionov, Aleksandr
> -Original Message- > From: Kitszel, Przemyslaw > Sent: Tuesday, September 10, 2024 1:11 PM > To: Loktionov, Aleksandr ; > Fijalkowski, Maciej > Cc: intel-wired-...@lists.osuosl.org; Nguyen, Anthony L > ; net...@vger.kernel.org; Sokolowski, > Jan ; Connolly, Padraig J > > Subject: Re:

Re: [Intel-wired-lan] [PATCH iwl-next v9 5/7] ixgbe: Add ixgbe_x540 multiple header inclusion protection

2024-10-17 Thread Simon Horman
On Thu, Oct 03, 2024 at 04:16:48PM +0200, Piotr Kwapulinski wrote: > Required to adopt x540 specific functions by E610 device. > > Signed-off-by: Piotr Kwapulinski Reviewed-by: Simon Horman

Re: [Intel-wired-lan] [PATCH iwl-next v9 3/7] ixgbe: Add link management support for E610 device

2024-10-17 Thread Simon Horman
On Thu, Oct 03, 2024 at 04:16:46PM +0200, Piotr Kwapulinski wrote: > Add low level link management support for E610 device. Link management > operations are handled via the Admin Command Interface. Add the following > link management operations: > - get link capabilities > - set up link > - get med

Re: [Intel-wired-lan] [PATCH iwl-next v9 2/7] ixgbe: Add support for E610 device capabilities detection

2024-10-17 Thread Simon Horman
On Thu, Oct 03, 2024 at 04:16:45PM +0200, Piotr Kwapulinski wrote: > Add low level support for E610 device capabilities detection. The > capabilities are discovered via the Admin Command Interface. Discover the > following capabilities: > - function caps: vmdq, dcb, rss, rx/tx qs, msix, nvm, orom,

[Intel-wired-lan] [PATCH] ixgbe: Break include dependency cycle

2024-10-17 Thread Diomidis Spinellis
Header ixgbe_type.h includes ixgbe_mbx.h. Also, header ixgbe_mbx.h included ixgbe_type.h, thus introducing a circular dependency. - Remove ixgbe_mbx.h inclusion from ixgbe_type.h. - ixgbe_mbx.h requires the definition of struct ixgbe_mbx_operations so move its definition there. While at it, ad

Re: [Intel-wired-lan] [PATCH iwl-net] idpf: set completion tag for "empty" bufs associated with a packet

2024-10-17 Thread Simon Horman
On Mon, Oct 07, 2024 at 01:24:35PM -0700, Joshua Hay wrote: > Commit d9028db618a6 ("idpf: convert to libeth Tx buffer completion") > inadvertently removed code that was necessary for the tx buffer cleaning > routine to iterate over all buffers associated with a packet. > > When a frag is too large

[Intel-wired-lan] [iwl-next v1] ice: only allow Tx promiscuous for multicast

2024-10-17 Thread Michal Swiatkowski
From: Brett Creeley Currently when any VF is trusted and true promiscuous mode is enabled on the PF, the VF will receive all unicast traffic directed to the device's internal switch. This includes traffic external to the NIC and also from other VSI (i.e. VFs). This does not match the expected beh