Re: [Intel-wired-lan] [RFC net-next 0/2] igc: Link IRQs and queues to NAPIs

2024-10-07 Thread Vinicius Costa Gomes
Joe Damato writes: > Greetings: > > This is an RFC to get feedback before submitting an actual series and > because I have a question for igc maintainers, see below. > > This series addss support for netdev-genl to igc so that userland apps > can query IRQ, queue, and NAPI instance relationships.

[Intel-wired-lan] [RESEND PATCH iwl-next] ice: Unbind the workqueue

2024-10-07 Thread Tony Nguyen
From: Frederic Weisbecker The ice workqueue doesn't seem to rely on any CPU locality and should therefore be able to run on any CPU. In practice this is already happening through the unbound ice_service_timer that may fire anywhere and queue the workqueue accordingly to any CPU. Make this offici

Re: [Intel-wired-lan] [PATCH] ice: Unbind the workqueue

2024-10-07 Thread Tony Nguyen
On 10/7/2024 3:29 AM, Frederic Weisbecker wrote: Le Mon, Sep 23, 2024 at 11:28:20AM -0700, Tony Nguyen a écrit : ... Thank you for the patch, it would make sense for our iwl-next tree, with such assumption: Reviewed-by: Przemek Kitszel @Tony, do you want it resent with target tree in the

[Intel-wired-lan] [PATCH iwl-net] idpf: set completion tag for "empty" bufs associated with a packet

2024-10-07 Thread Joshua Hay
Commit d9028db618a6 ("idpf: convert to libeth Tx buffer completion") inadvertently removed code that was necessary for the tx buffer cleaning routine to iterate over all buffers associated with a packet. When a frag is too large for a single data descriptor, it will be split across multiple data d

Re: [Intel-wired-lan] [RFC bpf-next 0/4] Add XDP rx hw hints support performing XDP_REDIRECT

2024-10-07 Thread Stanislav Fomichev
On 10/06, Toke Høiland-Jørgensen wrote: > Stanislav Fomichev writes: > > > On 10/04, Jesper Dangaard Brouer wrote: > >> > >> > >> On 04/10/2024 04.13, Daniel Xu wrote: > >> > On Thu, Oct 03, 2024 at 01:26:08PM GMT, Stanislav Fomichev wrote: > >> > > On 10/03, Arthur Fabre wrote: > >> > > > On T

Re: [Intel-wired-lan] [RFC PATCH 0/2] ptp: add control over HW timestamp latch point

2024-10-07 Thread Richard Cochran
On Thu, Oct 03, 2024 at 11:37:52PM +0200, Arkadiusz Kubalewski wrote: > HW support of PTP/timesync solutions in network PHY chips can be > achieved with two different approaches, the timestamp maybe latched > either in the beginning or after the Start of Frame Delimiter (SFD) [1]. > > Allow ptp de

Re: [Intel-wired-lan] [PATCH v8 net-next 00/15] net: introduce TX H/W shaping API

2024-10-07 Thread Jiri Pirko
Mon, Sep 30, 2024 at 03:53:47PM CEST, pab...@redhat.com wrote: >We have a plurality of shaping-related drivers API, but none flexible >enough to meet existing demand from vendors[1]. > >This series introduces new device APIs to configure in a flexible way >TX H/W shaping. The new functionalities ar

Re: [Intel-wired-lan] (subset) [PATCH 00/35] Reorganize kerneldoc parameter names

2024-10-07 Thread Bjorn Andersson
On Mon, 30 Sep 2024 13:20:46 +0200, Julia Lawall wrote: > Reorganize kerneldoc parameter names to match the parameter > order in the function header. > > The misordered cases were identified using the following > Coccinelle semantic patch: > > // > @initialize:ocaml@ > @@ > > [...] Applied,

Re: [Intel-wired-lan] [PATCH iwl-next v7 5/5] igb: Add AF_XDP zero-copy Tx support

2024-10-07 Thread Kurt Kanzenbach
On Mon Oct 07 2024, Maciej Fijalkowski wrote: >> +bool igb_xmit_zc(struct igb_ring *tx_ring) >> +{ >> +unsigned int budget = igb_desc_unused(tx_ring); >> +struct xsk_buff_pool *pool = tx_ring->xsk_pool; >> +u32 cmd_type, olinfo_status, nb_pkts, i = 0; >> +struct xdp_desc *descs = po

Re: [Intel-wired-lan] [PATCH iwl-next v7 4/5] igb: Add AF_XDP zero-copy Rx support

2024-10-07 Thread Kurt Kanzenbach
Hi Maciej, On Mon Oct 07 2024, Maciej Fijalkowski wrote: > On Mon, Oct 07, 2024 at 02:31:26PM +0200, Kurt Kanzenbach wrote: >> From: Sriram Yagnaraman >> >> Add support for AF_XDP zero-copy receive path. >> >> When AF_XDP zero-copy is enabled, the rx buffers are allocated from the >> xsk buff p

Re: [Intel-wired-lan] [PATCH iwl-next v7 5/5] igb: Add AF_XDP zero-copy Tx support

2024-10-07 Thread Maciej Fijalkowski
On Mon, Oct 07, 2024 at 02:31:27PM +0200, Kurt Kanzenbach wrote: > From: Sriram Yagnaraman > > Add support for AF_XDP zero-copy transmit path. > > A new TX buffer type IGB_TYPE_XSK is introduced to indicate that the Tx > frame was allocated from the xsk buff pool, so igb_clean_tx_ring() and > ig

Re: [Intel-wired-lan] [PATCH iwl-next v7 1/5] igb: Remove static qualifiers

2024-10-07 Thread Maciej Fijalkowski
On Mon, Oct 07, 2024 at 02:31:23PM +0200, Kurt Kanzenbach wrote: > From: Sriram Yagnaraman > > Remove static qualifiers on the following functions to be able to call > from XSK specific file that is added in the later patches: > - igb_xdp_tx_queue_mapping() > - igb_xdp_ring_update_tail() > - igb_

Re: [Intel-wired-lan] [PATCH iwl-next v7 4/5] igb: Add AF_XDP zero-copy Rx support

2024-10-07 Thread Maciej Fijalkowski
On Mon, Oct 07, 2024 at 02:31:26PM +0200, Kurt Kanzenbach wrote: > From: Sriram Yagnaraman > > Add support for AF_XDP zero-copy receive path. > > When AF_XDP zero-copy is enabled, the rx buffers are allocated from the > xsk buff pool using igb_alloc_rx_buffers_zc(). > > Use xsk_pool_get_rx_fram

[Intel-wired-lan] [PATCH iwl-next v7 3/5] igb: Introduce XSK data structures and helpers

2024-10-07 Thread Kurt Kanzenbach
From: Sriram Yagnaraman Add the following ring flag: - IGB_RING_FLAG_TX_DISABLED (when xsk pool is being setup) Add a xdp_buff array for use with XSK receive batch API, and a pointer to xsk_pool in igb_adapter. Add enable/disable functions for TX and RX rings. Add enable/disable functions for X

[Intel-wired-lan] [PATCH iwl-next v7 1/5] igb: Remove static qualifiers

2024-10-07 Thread Kurt Kanzenbach
From: Sriram Yagnaraman Remove static qualifiers on the following functions to be able to call from XSK specific file that is added in the later patches: - igb_xdp_tx_queue_mapping() - igb_xdp_ring_update_tail() - igb_clean_tx_ring() - igb_clean_rx_ring() - igb_xdp_xmit_back() - igb_process_skb_f

[Intel-wired-lan] [PATCH iwl-next v7 5/5] igb: Add AF_XDP zero-copy Tx support

2024-10-07 Thread Kurt Kanzenbach
From: Sriram Yagnaraman Add support for AF_XDP zero-copy transmit path. A new TX buffer type IGB_TYPE_XSK is introduced to indicate that the Tx frame was allocated from the xsk buff pool, so igb_clean_tx_ring() and igb_clean_tx_irq() can clean the buffers correctly based on type. igb_xmit_zc()

[Intel-wired-lan] [PATCH iwl-next v7 4/5] igb: Add AF_XDP zero-copy Rx support

2024-10-07 Thread Kurt Kanzenbach
From: Sriram Yagnaraman Add support for AF_XDP zero-copy receive path. When AF_XDP zero-copy is enabled, the rx buffers are allocated from the xsk buff pool using igb_alloc_rx_buffers_zc(). Use xsk_pool_get_rx_frame_size() to set SRRCTL rx buf size when zero-copy is enabled. Signed-off-by: Sri

[Intel-wired-lan] [PATCH iwl-next v7 0/5] igb: Add support for AF_XDP zero-copy

2024-10-07 Thread Kurt Kanzenbach
This is version v7 of the AF_XDP zero-copy support for igb. Since Sriram's duties changed I am sending this instead. Additionally, I've tested this on real hardware, Intel i210 [1]. Changes since v6: - Rebase to v6.12 - Collect tags - Merged first patch via -net - Inline small functions (Maci

[Intel-wired-lan] [PATCH iwl-next v7 2/5] igb: Introduce igb_xdp_is_enabled()

2024-10-07 Thread Kurt Kanzenbach
From: Sriram Yagnaraman Introduce igb_xdp_is_enabled() to check if an XDP program is assigned to the device. Use that wherever xdp_prog is read and evaluated. Signed-off-by: Sriram Yagnaraman [Kurt: Split patches and use READ_ONCE()] Signed-off-by: Kurt Kanzenbach Acked-by: Maciej Fijalkowski

Re: [Intel-wired-lan] [PATCH] ice: Unbind the workqueue

2024-10-07 Thread Frederic Weisbecker
Le Mon, Sep 23, 2024 at 11:28:20AM -0700, Tony Nguyen a écrit : > > > On 9/23/2024 1:57 AM, Przemek Kitszel wrote: > > On 9/23/24 00:24, Frederic Weisbecker wrote: > > > The ice workqueue doesn't seem to rely on any CPU locality and should > > > therefore be able to run on any CPU. In practice th

Re: [Intel-wired-lan] [RFC net-next 2/2] igc: Link queues to NAPI instances

2024-10-07 Thread Kurt Kanzenbach
Hi Joe, On Thu Oct 03 2024, Joe Damato wrote: > Link queues to NAPI instances via netdev-genl API so that users can > query this information with netlink: > > $ ./tools/net/ynl/cli.py --spec Documentation/netlink/specs/netdev.yaml \ > --dump queue-get --json='{"ifindex": 2