On Mon, 2 Sep 2024 12:10:50 +0200 Paolo Abeni wrote:
> >> Was that way a couple of iterations ago. Jiri explicitly asked for the
> >> separation, I asked for confirmation and nobody objected.
> >
> > Could you link to that? I must have not read it.
>
> https://lore.kernel.org/netdev/ZqzIoZaGV
On Wed, Aug 28, 2024 at 01:57:26PM -0700, Jacob Keller wrote:
> The major difference with is that it expects the unpacked
> data will always be a u64. This is somewhat limiting, but can be worked
> around by using a local temporary u64.
>
> As with the other implementations, we handle the error c
Hi Jacob,
It's very cool that you and Przemek (and possibly others) spent the time
to untangle this. Thanks! Just a microscopic nitpick below.
On Wed, Aug 28, 2024 at 01:57:24PM -0700, Jacob Keller wrote:
> The QUIRK_MSB_ON_THE_RIGHT quirk is intended to modify pack() and unpack()
> so that the m
On 02/09/24 06:46, Simon Horman wrote:
ethtool_puts() is the preferred method for copying ethtool strings.
And ethtool_puts() is already used to copy ethtool strings in
igc_ethtool_get_strings(). With this patch igc_ethtool_get_strings()
uses it for all such cases.
In general, the compiler ca
On Mon, Sep 02, 2024 at 03:14:54PM +0900, Takamitsu Iwai wrote:
> Duplicated register initialization codes exist in e1000_configure_tx()
> and e1000_configure_rx().
What does the datasheet say about these registers? Since we are
talking about hardware here, before you remove anything you need to b
On Fri, Aug 30, 2024 at 9:28 PM Aleksandr Loktionov
wrote:
>
> In cases when vf sends malformed packets that are classified as
> malicious, sometimes it causes tx queue to freeze. This frozen queue can be
> stuck for several minutes being unusable. When mdd event occurs, there is a
> posibility to
On 8/30/24 20:39, Jakub Kicinski wrote:
On Fri, 30 Aug 2024 12:55:05 +0200 Paolo Abeni wrote:
#define NETLINK_CTX_SIZE 48
and use such define above and in linux/netlink.h
Aha, would be good to also have a checking macro. Maybe rename
NL_ASSERT_DUMP_CTX_FITS()
to apply more broadly? or add a
Hello:
This patch was applied to netdev/net.git (main)
by David S. Miller :
On Thu, 29 Aug 2024 22:22:45 +0300 you wrote:
> Call rtnl_unlock() on this error path, before returning.
>
> Fixes: bc23aa949aeb ("igc: Add pcie error handler support")
> Signed-off-by: Dan Carpenter
> ---
> drivers/ne
ethtool_puts() is the preferred method for copying ethtool strings.
And ethtool_puts() is already used to copy ethtool strings in
igc_ethtool_get_strings(). With this patch igc_ethtool_get_strings()
uses it for all such cases.
In general, the compiler can't use fortification to verify that the
des
On Mon, Sep 02, 2024 at 12:06:52PM +0200, Michal Schmidt wrote:
> The description of function ice_find_vsi_list_entry says:
> Search VSI list map with VSI count 1
>
> However, since the blamed commit (see Fixes below), the function no
> longer checks vsi_count. This causes a problem in ice_add_v
On 8/30/24 21:14, Jakub Kicinski wrote:
On Fri, 30 Aug 2024 17:43:08 +0200 Paolo Abeni wrote:
Please allow me to put a few high level questions together, to both
underline them as most critical, and keep the thread focused.
On 8/30/24 03:20, Jakub Kicinski wrote:
> This 'binding' has the s
The description of function ice_find_vsi_list_entry says:
Search VSI list map with VSI count 1
However, since the blamed commit (see Fixes below), the function no
longer checks vsi_count. This causes a problem in ice_add_vlan_internal,
where the decision to share VSI lists between filter rules r
On Wed, Aug 28, 2024 at 04:38:25PM -0600, Ahmed Zaki wrote:
> The VF's dynamic interrupt ctl "dyn_ctl_intrvl_s" is not initialized
> in idpf_vf_intr_reg_init(). This resulted in the following UBSAN error
> whenever a VF is created:
>
> [ 564.345655] UBSAN: shift-out-of-bounds in
> drivers/net/et
13 matches
Mail list logo
