On Tue, Aug 20, 2024 at 06:15:24PM +0200, Dawid Osuchowski wrote:
> Ethtool callbacks can be executed while reset is in progress and try to
> access deleted resources, e.g. getting coalesce settings can result in a
> NULL pointer dereference seen below.
>
> Reproduction steps:
> Once the driver is
On 20. 08. 24, 23:30, Bjorn Helgaas wrote:
On Tue, Aug 20, 2024 at 11:13:54PM +0200, Petr Valenta wrote:
Dne 20. 08. 24 v 20:09 Bjorn Helgaas napsal(a):
On Mon, Aug 19, 2024 at 07:23:42AM +0200, Jiri Slaby wrote:
On 19. 08. 24, 6:50, Jiri Slaby wrote:
CC e1000e guys + Jesse (due to 75a3f93b53
Dne 20. 08. 24 v 20:09 Bjorn Helgaas napsal(a):
[+to Petr, -cc Jesse, bouncing]
On Mon, Aug 19, 2024 at 07:23:42AM +0200, Jiri Slaby wrote:
On 19. 08. 24, 6:50, Jiri Slaby wrote:
CC e1000e guys + Jesse (due to 75a3f93b5383) + Bjorn (due to b2c289415b2b)
Bjorn,
I am confused by these chan
On 8/14/2024 12:54 PM, Sergey Temerkhanov wrote:
...
+static inline bool ice_is_primary(struct ice_hw *hw)
No 'inline' functions in c files please.
+{
+ return ice_is_e825c(hw) && ice_is_dual(hw) ?
+ !!(hw->dev_caps.nac_topo.mode & ICE_NAC_TOPO_PRIMARY_M) : true;
+}
+
E830 adds hardware support to prevent the VF from overflowing the PF
mailbox with VIRTCHNL messages. E830 will use the hardware feature
(ICE_F_MBX_LIMIT) instead of the software solution ice_is_malicious_vf().
To prevent a VF from overflowing the PF, the PF sets the number of
messages per VF that
On 8/19/2024 3:14 AM, Michal Swiatkowski wrote:
> The filters set that will reproduce the problem:
> $ tc filter add dev $VF0_PR ingress protocol arp prio 0 flower \
> skip_sw dst_mac ff:ff:ff:ff:ff:ff action mirred egress \
> redirect dev $PF0
> $ tc filter add dev $VF0_PR ingress p
On Tue, Aug 20, 2024 at 11:13:54PM +0200, Petr Valenta wrote:
> Dne 20. 08. 24 v 20:09 Bjorn Helgaas napsal(a):
> > On Mon, Aug 19, 2024 at 07:23:42AM +0200, Jiri Slaby wrote:
> > > On 19. 08. 24, 6:50, Jiri Slaby wrote:
> > > > CC e1000e guys + Jesse (due to 75a3f93b5383) + Bjorn (due to
> > > >
On 8/19/2024 2:27 AM, Aleksandr Loktionov wrote:
> Add "EEE: Enabled/Disabled" to dmesg for supported X710 Base-T/KR/KX cards.
> According to the IEEE standard report the EEE ability and and the
> EEE Link Partner ability. Use the kernel's 'ethtool_keee' structure
> and report EEE link modes.
>
On 8/19/2024 12:17 AM, Michal Swiatkowski wrote:
> Use always the same pf id in devlink port number. When doing
> pass-through the PF to VM bus info func number can be any value.
>
Reviewed-by: Jacob Keller
> Fixes: 2ae0aa4758b0 ("ice: Move devlink port to PF/VF struct")
> Reviewed-by: Wojci
gcc-13.2.0
arc allyesconfig gcc-13.2.0
arc randconfig-001-20240820 gcc-13.2.0
arc randconfig-002-20240820 gcc-13.2.0
arm allmodconfig gcc-14.1.0
arm allnoconfig clang
[+to Tony, Przemek for e1000e questions; -cc Jesse]
On Mon, Aug 19, 2024 at 07:23:42AM +0200, Jiri Slaby wrote:
> On 19. 08. 24, 6:50, Jiri Slaby wrote:
> > CC e1000e guys + Jesse (due to 75a3f93b5383) + Bjorn (due to b2c289415b2b)
>
> Bjorn,
>
> I am confused by these changes:
> ===
[+to Petr, -cc Jesse, bouncing]
On Mon, Aug 19, 2024 at 07:23:42AM +0200, Jiri Slaby wrote:
> On 19. 08. 24, 6:50, Jiri Slaby wrote:
> > CC e1000e guys + Jesse (due to 75a3f93b5383) + Bjorn (due to b2c289415b2b)
>
> Bjorn,
>
> I am confused by these changes:
> ===
-13.2.0
arc allnoconfig gcc-13.2.0
arc allyesconfig gcc-13.2.0
arc defconfig gcc-13.2.0
arc randconfig-001-20240820 gcc-13.2.0
arc randconfig-002-20240820 gcc-13.2.0
Ethtool callbacks can be executed while reset is in progress and try to
access deleted resources, e.g. getting coalesce settings can result in a
NULL pointer dereference seen below.
Reproduction steps:
Once the driver is fully initialized, trigger reset:
# echo 1 > /sys/class/net//device/r
On Tue, Aug 20, 2024 at 6:07 AM Yunsheng Lin wrote:
>
> On 2024/8/19 23:54, Alexander Duyck wrote:
>
> ...
>
>
> "There are three types of API as proposed in this patchset instead of
> two types of API:
> 1. page_frag_alloc_va() returns [va].
> 2. page_frag_alloc_pg() retu
allmodconfig gcc-13.2.0
arc allnoconfig gcc-13.2.0
arc allyesconfig gcc-13.2.0
arc defconfig gcc-13.2.0
archsdk_defconfig gcc-13.2.0
arc randconfig-001-20240820
-20240820 clang-18
i386 buildonly-randconfig-002-20240820 clang-18
i386 buildonly-randconfig-003-20240820 clang-18
i386 buildonly-randconfig-004-20240820 clang-18
i386 buildonly-randconfig-005-20240820 clang-18
i386 buildonly-randconfig-006-20240820
From: Dan Carpenter
Date: Tue, 20 Aug 2024 16:43:46 +0300
> BIT() is unsigned long but ->pu.flg_msk and ->pu.flg_val are u64 type.
> On 32 bit systems, unsigned long is a u32 and the mismatch between u32
> and u64 will break things for the high 32 bits.
>
> Fixes: 9a4c07aaa0f5 ("ice: add parser
BIT() is unsigned long but ->pu.flg_msk and ->pu.flg_val are u64 type.
On 32 bit systems, unsigned long is a u32 and the mismatch between u32
and u64 will break things for the high 32 bits.
Fixes: 9a4c07aaa0f5 ("ice: add parser execution main loop")
Signed-off-by: Dan Carpenter
---
drivers/net/e
Hello Junfeng Guo,
Commit 9a4c07aaa0f5 ("ice: add parser execution main loop") from Jul
25, 2024 (linux-next), leads to the following Smatch static checker
warning:
drivers/net/ethernet/intel/ice/ice_parser_rt.c:124 ice_bst_key_init() error:
buffer overflow 'key' 10 <= 19
drivers/net/ethernet/in
On Tue, Aug 20, 2024 at 02:47:31PM +0200, Larysa Zaremba wrote:
> On Tue, Aug 20, 2024 at 02:31:51PM +0200, Maciej Fijalkowski wrote:
> > On Mon, Aug 19, 2024 at 12:05:38PM +0200, Larysa Zaremba wrote:
> > > Currently, netif_queue_set_napi() is called from ice_vsi_rebuild() that is
> > > not rtnl-l
On 2024/8/19 23:54, Alexander Duyck wrote:
...
"There are three types of API as proposed in this patchset instead of
two types of API:
1. page_frag_alloc_va() returns [va].
2. page_frag_alloc_pg() returns [page, offset].
3. page_frag_alloc() returns [va] & [page, off
>From: Jakub Kicinski
>Sent: Saturday, August 10, 2024 6:16 AM
>
>On Thu, 8 Aug 2024 13:20:12 +0200 Arkadiusz Kubalewski wrote:
>> +Device may provide ability to use Embedded SYNC feature. It allows
>> +to embed additional SYNC signal into the base frequency of a pin - a one
>> +special pulse of
On Tue, Aug 20, 2024 at 02:31:51PM +0200, Maciej Fijalkowski wrote:
> On Mon, Aug 19, 2024 at 12:05:38PM +0200, Larysa Zaremba wrote:
> > Currently, netif_queue_set_napi() is called from ice_vsi_rebuild() that is
> > not rtnl-locked when called from the reset. This creates the need to take
> > the
> Hi Sriram,
>
> On Mon Aug 19 2024, Sriram Yagnaraman wrote:
> >> -Original Message-
> >> From: Maciej Fijalkowski
> >> Sent: Monday, 19 August 2024 16:11
> >> To: Kurt Kanzenbach
> >> Cc: Tony Nguyen ; Przemek Kitszel
> >> ; David S. Miller ;
> >> Eric Dumazet ; Jakub Kicinski ;
> >> P
On Mon, Aug 19, 2024 at 12:05:38PM +0200, Larysa Zaremba wrote:
> Currently, netif_queue_set_napi() is called from ice_vsi_rebuild() that is
> not rtnl-locked when called from the reset. This creates the need to take
> the rtnl_lock just for a single function and complicates the
> synchronization w
Hi Sriram,
On Mon Aug 19 2024, Sriram Yagnaraman wrote:
>> -Original Message-
>> From: Maciej Fijalkowski
>> Sent: Monday, 19 August 2024 16:11
>> To: Kurt Kanzenbach
>> Cc: Tony Nguyen ; Przemek Kitszel
>> ; David S. Miller ;
>> Eric Dumazet ; Jakub Kicinski ;
>> Paolo Abeni ; Alexei St
From: Jacob Keller
The E830 and E82x devices use essentially the same logic for performing
a crosstimestamp. The only difference is that E830 hardware has
different offsets. Instead of having two implementations, combine them
into a single ice_capture_crosststamp() function.
Also combine the wra
E830 PHY supports timestamp ready bitmap.
Enable the bitmap by refactoring tx init function.
Reviewed-by: Przemek Kitszel
Signed-off-by: Karol Kolacinski
---
drivers/net/ethernet/intel/ice/ice_ptp.c | 56 +++-
drivers/net/ethernet/intel/ice/ice_ptp.h | 3 +-
2 files changed
Simplify TSYN IRQ processing by moving it to a separate function and
having appropriate behavior per PHY model, instead of multiple
conditions not related to HW, but to specific timestamping modes.
Reviewed-by: Przemek Kitszel
Signed-off-by: Karol Kolacinski
---
drivers/net/ethernet/intel/ice/i
From: Michal Michalik
Add specific functions and definitions for E830 devices to enable
PTP support.
Introduce new PHY model ICE_PHY_E830.
E830 devices support direct write to GLTSYN_ registers without shadow
registers and 64 bit read of PHC time.
Reviewed-by: Przemek Kitszel
Co-developed-by: M
Instead of using shifts and casts, use FIELD_PREP after reading 40b
timestamp values.
Signed-off-by: Karol Kolacinski
---
V5 -> V6: Replaced removed macros with the new ones
drivers/net/ethernet/intel/ice/ice_ptp_hw.c | 9 ++---
drivers/net/ethernet/intel/ice/ice_ptp_hw.h | 13 +---
Remove unnecessary ice_is_e8xx() functions and PHY model. Instead, use
MAC type where applicable.
Signed-off-by: Karol Kolacinski
---
drivers/net/ethernet/intel/ice/ice_common.c | 128 +---
drivers/net/ethernet/intel/ice/ice_common.h | 19 ++-
drivers/net/ethernet/intel/ice/ice_
Add specific functions and definitions for E830 devices to enable
PTP support.
Refactor processing of timestamping interrupt and cross timestamp
to avoid code redundancy.
Jacob Keller (1):
ice: combine cross timestamp functions for E82x and E830
Karol Kolacinski (4):
ice: Remove unncecessary
>-Original Message-
>From: Jiri Pirko
>Sent: Thursday, August 8, 2024 1:54 PM
>
>Thu, Aug 08, 2024 at 01:20:12PM CEST, arkadiusz.kubalew...@intel.com wrote:
>>Implement and document new pin attributes for providing Embedded SYNC
>>capabilities to the DPLL subsystem users through a netlink
On 19.08.2024 10:47, Przemek Kitszel wrote:
On 8/19/24 10:21, Dawid Osuchowski wrote:
@@ -7731,6 +7733,10 @@ static void ice_rebuild(struct ice_pf *pf, enum
ice_reset_req reset_type)
ice_rebuild_arfs(pf);
}
+ struct ice_vsi *vsi = ice_get_main_vsi(pf);
you should separate d
On Tue, Aug 20, 2024 at 09:40:31AM +0300, Shay Drori wrote:
>
>
> On 15/08/2024 13:22, Joe Damato wrote:
> > External email: Use caution opening links or attachments
> >
> >
> > On Wed, Aug 14, 2024 at 05:20:46PM -0700, Jakub Kicinski wrote:
> > > On Wed, 14 Aug 2024 19:01:40 +0100 Joe Damato w
On 06/08/2024 16:23, Vitaly Lifshits wrote:
Occasionally when the system goes into pm_suspend, the suspend might fail
due to a PHY access error on the network adapter. Previously, this would
have caused the whole system to fail to go to a low power state.
An example of this was reported in the fo
38 matches
Mail list logo
