Re: [Intel-wired-lan] [iwl-next v3 1/8] ice: devlink PF MSI-X max and min parameter

2024-08-09 Thread Jiri Pirko
Fri, Aug 09, 2024 at 01:39:42PM CEST, michal.swiatkow...@linux.intel.com wrote: >On Fri, Aug 09, 2024 at 01:29:29PM +0200, Jiri Pirko wrote: >> Fri, Aug 09, 2024 at 01:05:00PM CEST, michal.swiatkow...@linux.intel.com >> wrote: >> >On Fri, Aug 09, 2024 at 12:51:58PM +0200, Jiri Pirko wrote: >> >> F

Re: [Intel-wired-lan] [PATCH iwl-net v1] igb: Fix not clearing TimeSync interrupts for 82580

2024-08-09 Thread Richard Cochran
On Fri, Aug 09, 2024 at 05:23:02PM -0700, Vinicius Costa Gomes wrote: > It was reported that 82580 NICs have a hardware bug that makes it > necessary to write into the TSICR (TimeSync Interrupt Cause) register > to clear it. Bug, or was it a feature? Or IOW, maybe i210 changed the semantics of th

Re: [Intel-wired-lan] [PATCH iwl-net v1] igb: Fix not clearing TimeSync interrupts for 82580

2024-08-09 Thread Paul Menzel
Dear Vinicius, Thank you for the patch. Am 10.08.24 um 02:23 schrieb Vinicius Costa Gomes: It was reported that 82580 NICs have a hardware bug that makes it necessary to write into the TSICR (TimeSync Interrupt Cause) register to clear it. Were you able to verify that report by checking aga

Re: [Intel-wired-lan] [PATCH net-next v1 1/2] dpll: add Embedded SYNC feature for a pin

2024-08-09 Thread Jakub Kicinski
On Thu, 8 Aug 2024 13:20:12 +0200 Arkadiusz Kubalewski wrote: > +Device may provide ability to use Embedded SYNC feature. It allows > +to embed additional SYNC signal into the base frequency of a pin - a one > +special pulse of base frequency signal every time SYNC signal pulse > +happens. The use

[Intel-wired-lan] [PATCH iwl-net v1] igb: Fix not clearing TimeSync interrupts for 82580

2024-08-09 Thread Vinicius Costa Gomes
It was reported that 82580 NICs have a hardware bug that makes it necessary to write into the TSICR (TimeSync Interrupt Cause) register to clear it. Add a conditional so only for 82580 we write into the TSICR register, so we don't risk losing events for other models. This (partially) reverts comm

Re: [Intel-wired-lan] [PATCH iwl-next v8 06/14] iavf: add initial framework for registering PTP clock

2024-08-09 Thread Keller, Jacob E
> -Original Message- > From: Lobakin, Aleksander > Sent: Thursday, August 8, 2024 5:25 AM > To: Polchlopek, Mateusz > Cc: intel-wired-...@lists.osuosl.org; net...@vger.kernel.org; Keller, Jacob E > ; Drewek, Wojciech ; Sai > Krishna ; Simon Horman ; Zaki, > Ahmed > Subject: Re: [Intel-

[Intel-wired-lan] [tnguy-next-queue:100GbE] BUILD SUCCESS bc4b2020b5a741c0e4d50fb71e3d6655bf60ebac

2024-08-09 Thread kernel test robot
gcc-13.2.0 arc allmodconfig gcc-13.2.0 arc allnoconfig gcc-13.2.0 arc allyesconfig gcc-13.2.0 arc defconfig gcc-13.2.0 arc randconfig-001-20240809 gcc

Re: [Intel-wired-lan] [iwl-net v2 2/2] igb: Fix missing time sync events

2024-08-09 Thread Vinicius Costa Gomes
Daiwei Li writes: > Hi, > > It appears this change breaks PTP on the 82580 controller, as ptp4l reports: > >> timed out while polling for tx timestamp increasing tx_timestamp_timeout or >> increasing kworker priority may correct this issue, but a driver bug likely >> causes it > > The 82580 contr

[Intel-wired-lan] [tnguy-next-queue:1GbE] BUILD SUCCESS b014c38b53cd384394afe470f07b3136e426db57

2024-08-09 Thread kernel test robot
allnoconfig gcc-13.2.0 arc allyesconfig gcc-13.2.0 arc defconfig gcc-13.2.0 arc randconfig-001-20240809 gcc-13.2.0 arc randconfig-002-20240809 gcc-13.2.0 arm

Re: [Intel-wired-lan] [PATCH iwl-next v1] i40e: Add Energy Efficient Ethernet ability for X710 Base-T/KR/KX cards

2024-08-09 Thread Simon Horman
On Thu, Aug 08, 2024 at 01:22:17PM +0200, Aleksandr Loktionov wrote: ... > diff --git a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c > b/drivers/net/ethernet/intel/i40e/i40e_ethtool.c > index 1d0d2e5..cd7509f 100644 > --- a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c > +++ b/drivers/net/eth

[Intel-wired-lan] [PATCH] ice: Fix improper handling of refcount in ice_dpll_init_rclk_pins()

2024-08-09 Thread Gui-Dong Han
This patch addresses a reference count handling issue in the ice_dpll_init_rclk_pins() function. The function calls ice_dpll_get_pins(), which increments the reference count of the relevant resources. However, if the condition WARN_ON((!vsi || !vsi->netdev)) is met, the function currently returns a

Re: [Intel-wired-lan] [iwl-net v2 2/2] igb: Fix missing time sync events

2024-08-09 Thread Daiwei Li
Hi, It appears this change breaks PTP on the 82580 controller, as ptp4l reports: > timed out while polling for tx timestamp increasing tx_timestamp_timeout or > increasing kworker priority may correct this issue, but a driver bug likely > causes it The 82580 controller has a hardware bug in whic

[Intel-wired-lan] [PATCH] ice: Fix improper handling of refcount in ice_sriov_set_msix_vec_count()

2024-08-09 Thread Gui-Dong Han
This patch addresses an issue with improper reference count handling in the ice_sriov_set_msix_vec_count() function. Specifically, the function calls ice_get_vf_by_id(), which increments the reference count of the vf pointer. If the subsequent call to ice_get_vf_vsi() fails, the function currently

Re: [Intel-wired-lan] [PATCH iwl-next v2] ice: add E830 HW VF mailbox message limit support

2024-08-09 Thread Alexander Lobakin
From: Paul Greenwalt Date: Wed, 31 Jul 2024 21:58:29 -0400 > E830 adds hardware support to prevent the VF from overflowing the PF > mailbox with VIRTCHNL messages. E830 will use the hardware feature > (ICE_F_MBX_LIMIT) instead of the software solution ice_is_malicious_vf(). > > To prevent a VF f

Re: [Intel-wired-lan] [iwl-next v3 1/8] ice: devlink PF MSI-X max and min parameter

2024-08-09 Thread Michal Swiatkowski
On Fri, Aug 09, 2024 at 01:29:29PM +0200, Jiri Pirko wrote: > Fri, Aug 09, 2024 at 01:05:00PM CEST, michal.swiatkow...@linux.intel.com > wrote: > >On Fri, Aug 09, 2024 at 12:51:58PM +0200, Jiri Pirko wrote: > >> Fri, Aug 09, 2024 at 07:13:34AM CEST, michal.swiatkow...@linux.intel.com > >> wrote:

Re: [Intel-wired-lan] [iwl-next v3 1/8] ice: devlink PF MSI-X max and min parameter

2024-08-09 Thread Jiri Pirko
Fri, Aug 09, 2024 at 01:05:00PM CEST, michal.swiatkow...@linux.intel.com wrote: >On Fri, Aug 09, 2024 at 12:51:58PM +0200, Jiri Pirko wrote: >> Fri, Aug 09, 2024 at 07:13:34AM CEST, michal.swiatkow...@linux.intel.com >> wrote: >> >On Thu, Aug 08, 2024 at 05:34:35PM +0200, Jiri Pirko wrote: >> >> T

Re: [Intel-wired-lan] [iwl-next v3 1/8] ice: devlink PF MSI-X max and min parameter

2024-08-09 Thread Michal Swiatkowski
On Fri, Aug 09, 2024 at 12:51:58PM +0200, Jiri Pirko wrote: > Fri, Aug 09, 2024 at 07:13:34AM CEST, michal.swiatkow...@linux.intel.com > wrote: > >On Thu, Aug 08, 2024 at 05:34:35PM +0200, Jiri Pirko wrote: > >> Thu, Aug 08, 2024 at 09:20:09AM CEST, michal.swiatkow...@linux.intel.com > >> wrote:

[Intel-wired-lan] [tnguy-next-queue:main] BUILD SUCCESS 91d516d4de48532d967a77967834e00c8c53dfe6

2024-08-09 Thread kernel test robot
-13.2.0 arc randconfig-001-20240808 gcc-13.2.0 arc randconfig-001-20240809 gcc-13.2.0 arc randconfig-002-20240808 gcc-13.2.0 arc randconfig-002-20240809 gcc-13.2.0 arm allmodconfig gcc-13.2.0

Re: [Intel-wired-lan] [iwl-next v3 1/8] ice: devlink PF MSI-X max and min parameter

2024-08-09 Thread Jiri Pirko
Fri, Aug 09, 2024 at 07:18:38AM CEST, pmen...@molgen.mpg.de wrote: >Dear Michal, > > >Thank you for your patch. > >Am 09.08.24 um 07:13 schrieb Michal Swiatkowski: >> On Thu, Aug 08, 2024 at 05:34:35PM +0200, Jiri Pirko wrote: >> > Thu, Aug 08, 2024 at 09:20:09AM CEST, michal.swiatkow...@linux.inte

Re: [Intel-wired-lan] [iwl-next v3 1/8] ice: devlink PF MSI-X max and min parameter

2024-08-09 Thread Jiri Pirko
Fri, Aug 09, 2024 at 07:13:34AM CEST, michal.swiatkow...@linux.intel.com wrote: >On Thu, Aug 08, 2024 at 05:34:35PM +0200, Jiri Pirko wrote: >> Thu, Aug 08, 2024 at 09:20:09AM CEST, michal.swiatkow...@linux.intel.com >> wrote: >> >Use generic devlink PF MSI-X parameter to allow user to change MSI-