Re: [Intel-wired-lan] [PATCH iwl-next v3 3/3] ice: Implement driver functionality to dump serdes equalizer values

2024-06-24 Thread Pucha, HimasekharX Reddy
> -Original Message- > From: Intel-wired-lan On Behalf Of Anil > Samal > Sent: Friday, June 14, 2024 6:28 PM > To: intel-wired-...@lists.osuosl.org > Cc: net...@vger.kernel.org; Czapnik, Lukasz ; > Samal, Anil ; Pepiak, Leszek ; > Nguyen, Anthony L ; Simon Horman > ; Kitszel, Przemysla

Re: [Intel-wired-lan] [PATCH iwl-next v3 3/3] ice: Implement driver functionality to dump serdes equalizer values

2024-06-24 Thread Pucha, HimasekharX Reddy
> -Original Message- > From: Intel-wired-lan On Behalf Of Anil > Samal > Sent: Friday, May 24, 2024 7:21 PM > To: intel-wired-...@lists.osuosl.org > Cc: net...@vger.kernel.org; Czapnik, Lukasz ; > Samal, Anil ; Pepiak, Leszek ; > Nguyen, Anthony L ; Simon Horman > ; Kitszel, Przemyslaw

Re: [Intel-wired-lan] [PATCH iwl-next v3 2/3] ice: Implement driver functionality to dump fec statistics

2024-06-24 Thread Pucha, HimasekharX Reddy
> -Original Message- > From: Intel-wired-lan On Behalf Of Anil > Samal > Sent: Friday, June 14, 2024 6:28 PM > To: intel-wired-...@lists.osuosl.org > Cc: net...@vger.kernel.org; Czapnik, Lukasz ; > Samal, Anil ; Pepiak, Leszek ; > Nguyen, Anthony L ; Simon Horman > ; Kitszel, Przemysla

Re: [Intel-wired-lan] [PATCH iwl-next v3 1/3] ice: Extend Sideband Queue command to support flags

2024-06-24 Thread Pucha, HimasekharX Reddy
> -Original Message- > From: Intel-wired-lan On Behalf Of Anil > Samal > Sent: Friday, June 14, 2024 6:28 PM > To: intel-wired-...@lists.osuosl.org > Cc: net...@vger.kernel.org; Czapnik, Lukasz ; > Samal, Anil ; Pepiak, Leszek ; > Nguyen, Anthony L ; Simon Horman > ; Kitszel, Przemysla

Re: [Intel-wired-lan] [PATCH net-next] net: igc: return error for link autoneg=off

2024-06-24 Thread Íñigo Huguet
Sorry, I thought I had done `git pull` on my net-next tree, but I didn't and the patch doesn't apply due to context differences. I will send an updated patch in one or two days, including the requested changes if there are any. On Mon, Jun 24, 2024 at 11:53 AM Íñigo Huguet wrote: > > The driver

[Intel-wired-lan] [PATCH net-next] net: igc: return error for link autoneg=off

2024-06-24 Thread Íñigo Huguet
The driver doesn't support force mode for the link settings. However, if the user request it, it's just ignored and success is returned. Return ENOTSUPP instead. Signed-off-by: Íñigo Huguet --- drivers/net/ethernet/intel/igc/igc_ethtool.c | 18 ++ 1 file changed, 10 insertions(+)

[Intel-wired-lan] [PATCH iwl-net v2] i40e: Fix XDP program unloading while removing the driver

2024-06-24 Thread Michal Kubiak
The commit 6533e558c650 ("i40e: Fix reset path while removing the driver") introduced a new PF state "__I40E_IN_REMOVE" to block modifying the XDP program while the driver is being removed. Unfortunately, such a change is useful only if the ".ndo_bpf()" callback was called out of the rmmod context

[Intel-wired-lan] [PATCH iwl-next v2 5/7] ice: Optimize switch recipe creation

2024-06-24 Thread Marcin Szycik
Currently when creating switch recipes, switch ID is always added as the first word in every recipe. There are only 5 words in a recipe, so one word is always wasted. This is also true for the last recipe, which stores result indexes (in case of chain recipes). Therefore the maximum usable length o

[Intel-wired-lan] [PATCH iwl-next v2 7/7] ice: Add tracepoint for adding and removing switch rules

2024-06-24 Thread Marcin Szycik
Track the number of rules and recipes added to switch. Add a tracepoint to ice_aq_sw_rules(), which shows both rule and recipe count. This information can be helpful when designing a set of rules to program to the hardware, as it shows where the practical limit is. Actual limits are known (64 recip

[Intel-wired-lan] [PATCH iwl-next v2 6/7] ice: Remove unused members from switch API

2024-06-24 Thread Marcin Szycik
Remove several members of struct ice_sw_recipe and struct ice_prot_lkup_ext. Remove struct ice_recp_grp_entry and struct ice_pref_recipe_group, since they are now unused as well. All of the deleted members were only written to and never read, so it's pointless to keep them. Reviewed-by: Przemek K

[Intel-wired-lan] [PATCH iwl-next v2 3/7] ice: Simplify bitmap setting in adding recipe

2024-06-24 Thread Marcin Szycik
From: Michal Swiatkowski Remove unnecessary size checks when copying bitmaps in ice_add_sw_recipe() and replace them with compile time assert. Check if the bitmaps are equal size, as they are copied both ways. Signed-off-by: Michal Swiatkowski Reviewed-by: Przemek Kitszel Co-developed-by: Marc

[Intel-wired-lan] [PATCH iwl-next v2 4/7] ice: remove unused recipe bookkeeping data

2024-06-24 Thread Marcin Szycik
From: Michal Swiatkowski Remove root_buf from recipe struct. Its only usage was in ice_find_recp(), where if recipe had an inverse action, it was skipped, but actually the driver never adds inverse actions, so effectively it was pointless. Without root_buf, the recipe data element in ice_add_sw_

[Intel-wired-lan] [PATCH iwl-next v2 2/7] ice: Remove reading all recipes before adding a new one

2024-06-24 Thread Marcin Szycik
From: Michal Swiatkowski The content of the first read recipe is used as a template when adding a recipe. It isn't needed - only prune index is directly set from there. Set it in the code instead. Also, now there's no need to set rid and lookup indexes to 0, as the whole recipe buffer is initiali

[Intel-wired-lan] [PATCH iwl-next v2 1/7] ice: Remove unused struct ice_prot_lkup_ext members

2024-06-24 Thread Marcin Szycik
Remove field_off as it's never used. Remove done bitmap, as its value is only checked and never assigned. Reusing sub-recipes while creating new root recipes is currently not supported in the driver. Reviewed-by: Przemek Kitszel Signed-off-by: Marcin Szycik --- .../ethernet/intel/ice/ice_proto

[Intel-wired-lan] [PATCH iwl-next v2 0/7] Switch API optimizations

2024-06-24 Thread Marcin Szycik
Optimize the process of creating a recipe in the switch block by removing duplicate switch ID words and changing how result indexes are fitted into recipes. In many cases this can decrease the number of recipes required to add a certain set of rules, potentially allowing a more varied set of rules

Re: [Intel-wired-lan] [PATCH iwl-net v4] i40e: fix hot issue NVM content is corrupted after nvmupdate

2024-06-24 Thread Przemek Kitszel
On 6/18/24 16:21, Loktionov, Aleksandr wrote: -Original Message- From: Kitszel, Przemyslaw Sent: Tuesday, June 18, 2024 3:50 PM To: Loktionov, Aleksandr ; Nguyen, Anthony L Cc: net...@vger.kernel.org; Kang, Kelvin ; Kubalewski, Arkadiusz ; intel-wired- l...@lists.osuosl.org Subject:

Re: [Intel-wired-lan] [RFC PATCH iwl-next v1 0/4] Replace auxbus with ice_adapter in the PTP support code

2024-06-24 Thread Michal Schmidt
On Fri, Jun 21, 2024 at 10:44 AM Sergey Temerkhanov wrote: > This series replaces multiple aux buses and devices used in > the PTP support code with struct ice_adapter holding the necessary > shared data > > Patches 1,2 add convenience wrappers > Patch 3 does the main refactoring > Patch 4 finaliz

[Intel-wired-lan] [iwl-next v1] ice: remove eswitch rebuild

2024-06-24 Thread Michal Swiatkowski
Since the port representors are added one by one there is no need to do eswitch rebuild. Each port representor is detached and attached in VF reset path. Reviewed-by: Wojciech Drewek Signed-off-by: Michal Swiatkowski --- drivers/net/ethernet/intel/ice/ice_eswitch.c | 16 driver