Re: [Intel-wired-lan] [PATCH iwl-net v3] i40e: fix hot issue NVM content is corrupted after nvmupdate

2024-06-13 Thread Loktionov, Aleksandr
> -Original Message- > From: Nguyen, Anthony L > Sent: Thursday, June 13, 2024 11:27 PM > To: Loktionov, Aleksandr ; intel-wired- > l...@lists.osuosl.org > Cc: net...@vger.kernel.org; Kang, Kelvin ; > Kubalewski, Arkadiusz ; Kitszel, > Przemyslaw > Subject: Re: [PATCH iwl-net v3] i40e:

Re: [Intel-wired-lan] [PATCH iwl-net v1 1/1] e1000e: fix force smbus during suspend flow

2024-06-13 Thread Hui Wang
Hi Vitaly I tested the patch on a laptop with the ethernet card [8086:550A], the system suspend and resume worked well with the cable plugged or unplugged. But I still think that reverting 2 regression commits is a better solution. Thanks. And some comment below: On 6/13/24 20:01, Vitaly Li

[Intel-wired-lan] [tnguy-next-queue:dev-queue 52/84] ld.lld: error: undefined symbol: ptp_clock_register

2024-06-13 Thread kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/tnguy/next-queue.git dev-queue head: 5f94b437aa6a1f7a19022db2b3524417ca06d232 commit: 709eab0aad17cbe55b6ffe6a9bab375640d9216a [52/84] iavf: add initial framework for registering PTP clock config: i386-randconfig-016-20240614 (https://dow

Re: [Intel-wired-lan] [PATCH iwl-net v3] i40e: fix hot issue NVM content is corrupted after nvmupdate

2024-06-13 Thread Tony Nguyen
On 6/12/2024 4:04 AM, Aleksandr Loktionov wrote: As Przemek has pointed out... "hot issue" doesn't necessarily carry the same meaning; better to just drop that out of the title. The bug affects users only at the time when they try to update NVM, and only F/W versions that generate errors whi

Re: [Intel-wired-lan] [PATCH net-next 0/5] net: flower: validate encapsulation control flags

2024-06-13 Thread Asbjørn Sloth Tønnesen
Hi Jakub, On 6/13/24 1:04 AM, Jakub Kicinski wrote: On Sun, 9 Jun 2024 17:33:50 + Asbjørn Sloth Tønnesen wrote: Now that all drivers properly rejects unsupported flower control flags used with FLOW_DISSECTOR_KEY_CONTROL, then time has come to add similar checks to the drivers supporting FL

Re: [Intel-wired-lan] [PATCH iwl-next] igc: Get rid of spurious interrupts

2024-06-13 Thread Vinicius Costa Gomes
Sebastian Andrzej Siewior writes: > On 2024-06-12 12:49:21 [-0700], Vinicius Costa Gomes wrote: >> > diff --git a/drivers/net/ethernet/intel/igc/igc_main.c >> > b/drivers/net/ethernet/intel/igc/igc_main.c >> > index 305e05294a26..e666739dfac7 100644 >> > --- a/drivers/net/ethernet/intel/igc/igc_

Re: [Intel-wired-lan] [PATCH v3 iwl-net 1/8] ice: respect netif readiness in AF_XDP ZC related ndo's

2024-06-13 Thread Maciej Fijalkowski
On Thu, Jun 13, 2024 at 05:51:25PM +0200, Maciej Fijalkowski wrote: > On Wed, Jun 12, 2024 at 11:15:31AM +0200, Alexander Lobakin wrote: > > From: Alexander Lobakin > > Date: Wed, 12 Jun 2024 11:09:10 +0200 > > > > > From: Maciej Fijalkowski > > > Date: Tue, 11 Jun 2024 16:21:27 +0200 > > > > [

Re: [Intel-wired-lan] [PATCH v3 iwl-net 1/8] ice: respect netif readiness in AF_XDP ZC related ndo's

2024-06-13 Thread Maciej Fijalkowski
On Wed, Jun 12, 2024 at 11:15:31AM +0200, Alexander Lobakin wrote: > From: Alexander Lobakin > Date: Wed, 12 Jun 2024 11:09:10 +0200 > > > From: Maciej Fijalkowski > > Date: Tue, 11 Jun 2024 16:21:27 +0200 > > [...] > > diff --git a/drivers/net/ethernet/intel/ice/ice_xsk.c > b/drive

Re: [Intel-wired-lan] [PATCH iwl-net 0/3] ice: fix synchronization between .ndo_bpf() and reset

2024-06-13 Thread Jakub Kicinski
On Thu, 13 Jun 2024 17:36:16 +0200 Larysa Zaremba wrote: > > > AFAIK, netif_device_detach() does not affect .ndo_bpf() calls. We were > > > trying > > > such approach with idpf and it does work for ethtool, but not for XDP. > > > > I reckon that's an unintentional omission. In theory XDP is "p

Re: [Intel-wired-lan] [PATCH iwl-net 0/3] ice: fix synchronization between .ndo_bpf() and reset

2024-06-13 Thread Larysa Zaremba
On Thu, Jun 13, 2024 at 07:13:43AM -0700, Jakub Kicinski wrote: > On Thu, 13 Jun 2024 10:54:12 +0200 Larysa Zaremba wrote: > > > > The locking mechanisms I use here do not look pretty, but if I am not > > > > missing > > > > anything, the synchronization they provide must be robust. > > > > >

Re: [Intel-wired-lan] [PATCH iwl-next v12] ice: Add get/set hw address for VFs using devlink commands

2024-06-13 Thread Romanowski, Rafal
> -Original Message- > From: Intel-wired-lan On Behalf Of > Karthik Sundaravel > Sent: Tuesday, May 28, 2024 5:02 PM > To: Brandeburg, Jesse ; Drewek, Wojciech > ; sum...@marvell.com; Keller, Jacob E > ; Nguyen, Anthony L ; > da...@davemloft.net; eduma...@google.com; k...@kernel.org; > pab

Re: [Intel-wired-lan] [PATCH iwl-net 0/3] ice: fix synchronization between .ndo_bpf() and reset

2024-06-13 Thread Jakub Kicinski
On Thu, 13 Jun 2024 10:54:12 +0200 Larysa Zaremba wrote: > > > The locking mechanisms I use here do not look pretty, but if I am not > > > missing > > > anything, the synchronization they provide must be robust. > > > > Robust as in they may be correct here, but you lose lockdep and all > > ot

Re: [Intel-wired-lan] [PATCH iwl-net v3] i40e: fix hot issue NVM content is corrupted after nvmupdate

2024-06-13 Thread Brelinski, Tony
> -Original Message- > From: Intel-wired-lan On Behalf Of > Aleksandr Loktionov > Sent: Wednesday, June 12, 2024 4:04 AM > To: intel-wired-...@lists.osuosl.org; Nguyen, Anthony L > ; Loktionov, Aleksandr > > Cc: net...@vger.kernel.org; Kang, Kelvin ; > Kubalewski, Arkadiusz > Subject: [I

Re: [Intel-wired-lan] [PATCH iwl-next 01/12] libeth: add cacheline / struct alignment helpers

2024-06-13 Thread Jakub Kicinski
On Thu, 13 Jun 2024 12:47:33 +0200 Alexander Lobakin wrote: > > Having per-driver grouping defines is a no-go. > > Without it, kdoc warns when I want to describe group fields =\ > > > Do you need the defines in the first place? > > They allow to describe CLs w/o repeating boilerplates like >

Re: [Intel-wired-lan] [PATCH iwl-net] idpf: extend tx watchdog timeout

2024-06-13 Thread Alexander Lobakin
From: Josh Hay Date: Wed, 12 Jun 2024 23:36:29 -0700 > > > On 6/12/2024 2:34 AM, Alexander Lobakin wrote: >> From: Josh Hay >> Date: Tue, 11 Jun 2024 11:13:53 -0700 >> >>> >>> >>> On 6/11/2024 3:44 AM, Alexander Lobakin wrote: From: David Decotigny Date: Tue, 4 Jun 2024 16:34:48 -07

[Intel-wired-lan] [tnguy-net-queue:1GbE] BUILD SUCCESS c96737dd95ba96be2398e4a785177d30f1c9d7b8

2024-06-13 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/tnguy/net-queue.git 1GbE branch HEAD: c96737dd95ba96be2398e4a785177d30f1c9d7b8 Revert "igc: fix a log entry using uninitialized netdev" elapsed time: 2609m configs tested: 76 configs skipped: 3 The following configs have been built

[Intel-wired-lan] [PATCH iwl-net v1 1/1] e1000e: fix force smbus during suspend flow

2024-06-13 Thread Vitaly Lifshits
Commit bfd546a552e1 ("e1000e: move force SMBUS near the end of enable_ulp function") fixed an issue with loss of PHY access during suspend on Meteor Lake systems. However, it introduced a regression on older devices, such as [8086:15B8], [8086:15F9], [8086:15BE]. This patch aims to fix the seconda

Re: [Intel-wired-lan] [PATCH iwl-next 12/12] idpf: use libeth Rx buffer management for payload buffer

2024-06-13 Thread Alexander Lobakin
From: Simon Horman Date: Sat, 1 Jun 2024 10:08:42 +0100 > + Dan Carpenter > > On Tue, May 28, 2024 at 03:48:46PM +0200, Alexander Lobakin wrote: >> idpf uses Page Pool for data buffers with hardcoded buffer lengths of >> 4k for "classic" buffers and 2k for "short" ones. This is not flexible >> a

Re: [Intel-wired-lan] [PATCH iwl-next 03/12] idpf: split &idpf_queue into 4 strictly-typed queue structures

2024-06-13 Thread Alexander Lobakin
From: Simon Horman Date: Sat, 1 Jun 2024 09:53:08 +0100 > On Tue, May 28, 2024 at 03:48:37PM +0200, Alexander Lobakin wrote: >> Currently, sizeof(struct idpf_queue) is 32 Kb. >> This is due to the 12-bit hashtable declaration at the end of the queue. >> This HT is needed only for Tx queues when t

Re: [Intel-wired-lan] [PATCH iwl-next 11/12] idpf: convert header split mode to libeth + napi_build_skb()

2024-06-13 Thread Alexander Lobakin
From: Jakub Kicinski Date: Wed, 29 May 2024 18:40:12 -0700 > On Tue, 28 May 2024 15:48:45 +0200 Alexander Lobakin wrote: >> Currently, idpf uses the following model for the header buffers: >> >> * buffers are allocated via dma_alloc_coherent(); >> * when receiving, napi_alloc_skb() is called and

Re: [Intel-wired-lan] [PATCH iwl-next 01/12] libeth: add cacheline / struct alignment helpers

2024-06-13 Thread Alexander Lobakin
From: Jakub Kicinski Date: Wed, 29 May 2024 18:34:09 -0700 > On Tue, 28 May 2024 15:48:35 +0200 Alexander Lobakin wrote: >> diff --git a/scripts/kernel-doc b/scripts/kernel-doc >> index 95a59ac78f82..d0cf9a2d82de 100755 >> --- a/scripts/kernel-doc >> +++ b/scripts/kernel-doc >> @@ -1155,6 +1155,7

Re: [Intel-wired-lan] [PATCH iwl-net 0/3] ice: fix synchronization between .ndo_bpf() and reset

2024-06-13 Thread Przemek Kitszel
On 6/13/24 10:54, Larysa Zaremba wrote: On Wed, Jun 12, 2024 at 02:09:35PM -0700, Jakub Kicinski wrote: On Wed, 12 Jun 2024 08:56:38 +0200 Larysa Zaremba wrote: On Tue, Jun 11, 2024 at 07:38:37PM -0700, Jakub Kicinski wrote: On Mon, 10 Jun 2024 17:37:12 +0200 Larysa Zaremba wrote: Fix the pro

Re: [Intel-wired-lan] [PATCH iwl-net] idpf: extend tx watchdog timeout

2024-06-13 Thread Alexander Lobakin
From: David Decotigny Date: Wed, 12 Jun 2024 11:01:46 -0700 > On Tue, Jun 11, 2024 at 11:13 AM Josh Hay wrote: >> >> >> >> On 6/11/2024 3:44 AM, Alexander Lobakin wrote: >>> From: David Decotigny >>> Date: Tue, 4 Jun 2024 16:34:48 -0700 >>> On 6/3/2024 11:47 AM, Joshua Hay wrote:

Re: [Intel-wired-lan] [PATCH iwl-net 0/3] ice: fix synchronization between .ndo_bpf() and reset

2024-06-13 Thread Larysa Zaremba
On Wed, Jun 12, 2024 at 02:09:35PM -0700, Jakub Kicinski wrote: > On Wed, 12 Jun 2024 08:56:38 +0200 Larysa Zaremba wrote: > > On Tue, Jun 11, 2024 at 07:38:37PM -0700, Jakub Kicinski wrote: > > > On Mon, 10 Jun 2024 17:37:12 +0200 Larysa Zaremba wrote: > > > > Fix the problems that are triggered