Re: [Intel-wired-lan] [PATCH iwl-net 0/3] ice: fix synchronization between .ndo_bpf() and reset

2024-06-11 Thread Larysa Zaremba
On Tue, Jun 11, 2024 at 07:38:37PM -0700, Jakub Kicinski wrote: > On Mon, 10 Jun 2024 17:37:12 +0200 Larysa Zaremba wrote: > > Fix the problems that are triggered by tx_timeout and ice_xdp() calls, > > including both pool and program operations. > > Is there really no way for ice to fix the lockin

[Intel-wired-lan] [tnguy-net-queue:200GbE] BUILD SUCCESS 36534d3c54537bf098224a32dc31397793d4594d

2024-06-11 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/tnguy/net-queue.git 200GbE branch HEAD: 36534d3c54537bf098224a32dc31397793d4594d tcp: use signed arithmetic in tcp_rtx_probe0_timed_out() elapsed time: 1466m configs tested: 64 configs skipped: 3 The following configs have been buil

Re: [Intel-wired-lan] [PATCH iwl-net 0/3] ice: fix synchronization between .ndo_bpf() and reset

2024-06-11 Thread Jakub Kicinski
On Mon, 10 Jun 2024 17:37:12 +0200 Larysa Zaremba wrote: > Fix the problems that are triggered by tx_timeout and ice_xdp() calls, > including both pool and program operations. Is there really no way for ice to fix the locking? :( The busy loops and trylocks() are not great, and seem like duct tape

Re: [Intel-wired-lan] [PATCH iwl-next v7 09/12] iavf: refactor iavf_clean_rx_irq to support legacy and flex descriptors

2024-06-11 Thread Jacob Keller
On 6/11/2024 4:47 AM, Alexander Lobakin wrote: > From: Mateusz Polchlopek > Date: Tue, 4 Jun 2024 09:13:57 -0400 > >> From: Jacob Keller >> >> Using VIRTCHNL_VF_OFFLOAD_FLEX_DESC, the iAVF driver is capable of >> negotiating to enable the advanced flexible descriptor layout. Add the >> flexi

Re: [Intel-wired-lan] [PATCH v3 iwl-net 1/8] ice: respect netif readiness in AF_XDP ZC related ndo's

2024-06-11 Thread Tony Nguyen
On 6/11/2024 10:21 AM, Maciej Fijalkowski wrote: On Tue, Jun 11, 2024 at 01:59:37PM +0200, Alexander Lobakin wrote: ice_clean_xdp_irq_zc(xdp_ring); + if (!netif_carrier_ok(xdp_ring->vsi->netdev) || + !netif_running(xdp_ring->vsi->netdev)) + return true;

Re: [Intel-wired-lan] [PATCH] igb: Add support for firmware update

2024-06-11 Thread Jacob Keller
On 6/11/2024 12:55 AM, Chien, Richard (Options Engineering) wrote: >> However, this implementation is wrong. It is exposing the >> ETHTOOL_GEEPROM and ETHTOOL_SEEPROM interface and abusing it to >> implement a non-standard interface that is custom to the out-of-tree Intel >> drivers to support t

Re: [Intel-wired-lan] [PATCH iwl-net] idpf: extend tx watchdog timeout

2024-06-11 Thread Josh Hay
On 6/11/2024 3:44 AM, Alexander Lobakin wrote: From: David Decotigny Date: Tue, 4 Jun 2024 16:34:48 -0700 On 6/3/2024 11:47 AM, Joshua Hay wrote: There are several reasons for a TX completion to take longer than usual to be written back by HW. For example, the completion for a packet th

Re: [Intel-wired-lan] [PATCH 1/6] auxbus: make to_auxiliary_drv accept and return a constant pointer

2024-06-11 Thread Mark Brown
On Tue, Jun 11, 2024 at 03:01:04PM +0200, Greg Kroah-Hartman wrote: > In the quest to make struct device constant, start by making > to_auziliary_drv() return a constant pointer so that drivers that call > this can be fixed up before the driver core changes. Acked-by: Mark Brown signature.asc D

Re: [Intel-wired-lan] [PATCH net-next 0/5] net: flower: validate encapsulation control flags

2024-06-11 Thread Davide Caratti
On Sun, Jun 09, 2024 at 05:33:50PM +, Asbjørn Sloth Tønnesen wrote: > Now that all drivers properly rejects unsupported flower control flags > used with FLOW_DISSECTOR_KEY_CONTROL, then time has come to add similar > checks to the drivers supporting FLOW_DISSECTOR_KEY_ENC_CONTROL. > > There ar

Re: [Intel-wired-lan] [PATCH] ixgbe: Add support for firmware update

2024-06-11 Thread Chien, Richard (Options Engineering)
> I would also think about why Intel has not submitted this code before? > Maybe because it does things the wrong way? Please look at how other > Ethernet drivers support firmware. Is it the same? It might be you need to > throw away this code and reimplement it to mainline standards, maybe using >

Re: [Intel-wired-lan] [PATCH 1/6] auxbus: make to_auxiliary_drv accept and return a constant pointer

2024-06-11 Thread Sakari Ailus
Hi Greg, On Tue, Jun 11, 2024 at 03:01:04PM +0200, Greg Kroah-Hartman wrote: > In the quest to make struct device constant, start by making > to_auziliary_drv() return a constant pointer so that drivers that call s/z/s/ Acked-by: Sakari Ailus # drivers/media/pci/intel/ipu6 > this can be fixed

Re: [Intel-wired-lan] [PATCH] igb: Add support for firmware update

2024-06-11 Thread Chien, Richard (Options Engineering)
> However, this implementation is wrong. It is exposing the > ETHTOOL_GEEPROM and ETHTOOL_SEEPROM interface and abusing it to > implement a non-standard interface that is custom to the out-of-tree Intel > drivers to support the flash update utility. > > This implementation was widely rejected when

Re: [Intel-wired-lan] [PATCH net-next 4/5] nfp: flower: validate encapsulation control flags

2024-06-11 Thread Louis Peens
On Sun, Jun 09, 2024 at 05:33:54PM +, Asbjørn Sloth Tønnesen wrote: > Encapsulation control flags are currently not used anywhere, > so all flags are currently unsupported by all drivers. > > This patch adds validation of this assumption, so that > encapsulation flags may be used in the future

Re: [Intel-wired-lan] [PATCH v3 iwl-net 1/8] ice: respect netif readiness in AF_XDP ZC related ndo's

2024-06-11 Thread Maciej Fijalkowski
On Tue, Jun 11, 2024 at 01:59:37PM +0200, Alexander Lobakin wrote: > From: Maciej Fijalkowski > Date: Tue, 4 Jun 2024 15:21:48 +0200 > > > From: Michal Kubiak > > > > Address a scenario in which XSK ZC Tx produces descriptors to XDP Tx > > ring when link is either not yet fully initialized or

Re: [Intel-wired-lan] [PATCH 1/6] auxbus: make to_auxiliary_drv accept and return a constant pointer

2024-06-11 Thread Greg Kroah-Hartman
On Tue, Jun 11, 2024 at 02:22:37PM +0100, Mark Brown wrote: > On Tue, Jun 11, 2024 at 03:01:04PM +0200, Greg Kroah-Hartman wrote: > > In the quest to make struct device constant, start by making > > to_auziliary_drv() return a constant pointer so that drivers that call > > this can be fixed up befo

Re: [Intel-wired-lan] [PATCH 1/6] auxbus: make to_auxiliary_drv accept and return a constant pointer

2024-06-11 Thread Greg Kroah-Hartman
On Tue, Jun 11, 2024 at 01:44:07PM +, Sakari Ailus wrote: > Hi Greg, > > On Tue, Jun 11, 2024 at 03:01:04PM +0200, Greg Kroah-Hartman wrote: > > In the quest to make struct device constant, start by making > > to_auziliary_drv() return a constant pointer so that drivers that call > > s/z/s/

Re: [Intel-wired-lan] [PATCH 1/6] auxbus: make to_auxiliary_drv accept and return a constant pointer

2024-06-11 Thread Przemek Kitszel
On 6/11/24 15:01, Greg Kroah-Hartman wrote: In the quest to make struct device constant, start by making just curious, how far it will go? eg. do you plan to convert get/put_device() to accept const? or convert devlink API to accept consts? to_auziliary_drv() return a constant pointer so that

[Intel-wired-lan] [PATCH 1/6] auxbus: make to_auxiliary_drv accept and return a constant pointer

2024-06-11 Thread Greg Kroah-Hartman
In the quest to make struct device constant, start by making to_auziliary_drv() return a constant pointer so that drivers that call this can be fixed up before the driver core changes. As the return type previously was not constant, also fix up all callers that were assuming that the pointer was n

Re: [Intel-wired-lan] [PATCH v3 iwl-net 1/8] ice: respect netif readiness in AF_XDP ZC related ndo's

2024-06-11 Thread Alexander Lobakin
From: Maciej Fijalkowski Date: Tue, 4 Jun 2024 15:21:48 +0200 > From: Michal Kubiak > > Address a scenario in which XSK ZC Tx produces descriptors to XDP Tx > ring when link is either not yet fully initialized or process of > stopping the netdev has already started. To avoid this, add checks >

Re: [Intel-wired-lan] [PATCH iwl-next v7 09/12] iavf: refactor iavf_clean_rx_irq to support legacy and flex descriptors

2024-06-11 Thread Alexander Lobakin
From: Mateusz Polchlopek Date: Tue, 4 Jun 2024 09:13:57 -0400 > From: Jacob Keller > > Using VIRTCHNL_VF_OFFLOAD_FLEX_DESC, the iAVF driver is capable of > negotiating to enable the advanced flexible descriptor layout. Add the > flexible NIC layout (RXDID=2) as a member of the Rx descriptor un

[Intel-wired-lan] [tnguy-next-queue:dev-queue 65/95] ld.lld: error: undefined symbol: ptp_schedule_worker

2024-06-11 Thread kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/tnguy/next-queue.git dev-queue head: 10d0e5f67bf964e5e8cc7a99ab8c1942ce3d97c7 commit: cad731b65625243ce2b7b83375ab76c7828398be [65/95] iavf: periodically cache PHC time config: riscv-randconfig-002-20240611 (https://download.01.org/0day

Re: [Intel-wired-lan] [PATCH] igb: Add MII write support

2024-06-11 Thread Pucha, HimasekharX Reddy
> -Original Message- > From: Intel-wired-lan On Behalf Of > jackie.j...@alliedtelesis.co.nz > Sent: Tuesday, June 4, 2024 8:40 AM > To: da...@davemloft.net > Cc: jackie.j...@alliedtelesis.co.nz; net...@vger.kernel.org; > linux-ker...@vger.kernel.org; Nguyen, Anthony L ; > chris.pack...@

Re: [Intel-wired-lan] [PATCH iwl-net] idpf: extend tx watchdog timeout

2024-06-11 Thread Alexander Lobakin
From: David Decotigny Date: Tue, 4 Jun 2024 16:34:48 -0700 > > > On 6/3/2024 11:47 AM, Joshua Hay wrote: >> >> There are several reasons for a TX completion to take longer than usual >> to be written back by HW. For example, the completion for a packet that >> misses a rule will have increased

Re: [Intel-wired-lan] [iwl-next v1] ice: Check all ice_vsi_rebuild() errors in function

2024-06-11 Thread Paul Menzel
Dear Eric, dear Karen, Thank you for the patch. Am 28.05.24 um 11:01 schrieb Karen Ostrowska: From: Eric Joyner Check the return value from ice_vsi_rebuild() and prevent the usage of incorrectly configured VSI. Was this found during code review, or is this seen in practice? If the latter

[Intel-wired-lan] [PATCH iwl-net v2] i40e: fix hot issue NVM content is corrupted after nvmupdate

2024-06-11 Thread Aleksandr Loktionov
The bug affects users ionly at the time when they try to update NVM, and only F/W versions that generate errors while nvmupdate. For example X710DA2 with 0x8000ECB7 F/W is affected, but there are probably more... After 230f3d53a547 patch, which should only replace F/W specific error codes into Lin

Re: [Intel-wired-lan] [PATCH iwl-net] i40e: fix hot issue NVM content is corrupted after nvmupdate

2024-06-11 Thread Loktionov, Aleksandr
> -Original Message- > From: Paul Menzel > Sent: Monday, June 10, 2024 2:26 PM > To: Loktionov, Aleksandr ; Kang, Kelvin > > Cc: Sokolowski, Jan ; net...@vger.kernel.org; > Kubalewski, Arkadiusz ; Nguyen, Anthony L > ; intel-wired-...@lists.osuosl.org; Leon > Romanovsky > Subject: Re: