tree: https://git.kernel.org/pub/scm/linux/kernel/git/tnguy/next-queue.git
dev-queue
head: ace679d6a9e3623d89804105baaca54d4e5e9c49
commit: c3bafac0365a81a223dff3ca0a68665926ef077d [70/81] ice: support Rx
timestamp on flex descriptor
config: arm-randconfig-004-20240607
(https://download.01.o
Use the ice_netdev_to_pf() helper in more places and remove a bunch of
boilerplate code. Not every instance could be replaced due to use of the
netdev_priv() output or the vsi variable within a bunch of functions.
Reviewed-by: Jacob Keller
Reviewed-by: Przemek Kitszel
Reviewed-by: Jakub Kicinski
As a pre-requisite to implementing timestamp statistics, start tracking
successful PTP timestamps. There already existed a trace event, but
add a counter as well so it can be displayed by the next patch.
Good count is a u64 as it is much more likely to be incremented. The
existing error stats are
The kernel now has common statistics for transmit timestamps, so
implement them in the ice driver.
use via
ethtool -I -T eth0
Reviewed-by: Jacob Keller
Reviewed-by: Jakub Kicinski
Reviewed-by: Hariprasad Kelam
Signed-off-by: Jesse Brandeburg
---
$ sudo ethtool -I -T eth0
Time stamping parame
Add support for MAC/pause/RMON stats. This enables reporting hardware
statistics in a common way via:
ethtool -S eth0 --all-groups
and
ethtool --include-statistics --show-pause eth0
While doing so, add support for one new stat, receive length error
(RLEC), which is extremely unlikely to happen si
While trying to figure out ethtool -I | --include-statistics, I noticed
some docs got missed when implementing commit 0e9c127729be ("ethtool:
add interface to read Tx hardware timestamping statistics").
Fix up the docs to match the kernel code, and while there, sort them in
alphabetical order.
Cc
The main point of this series is to implement the standard stats for the
ice driver, but also add a related documentation fix and finish the
series off with a cleanup that removes a bunch of code.
Changelog:
v2: address review comments on 1/5 (Jakub) regarding backticks,
fix email address for
On 6/6/2024 11:31 AM, Andrew Lunn wrote:
>> Yea, its extremely easy to break things if you don't know what you're
>> doing here. So its more a question of "are we ok exposing yet another
>> way root can brick things?"
>
> Many MAC drivers allow it, and we have not had complaints. It is not
> re
> Yea, its extremely easy to break things if you don't know what you're
> doing here. So its more a question of "are we ok exposing yet another
> way root can brick things?"
Many MAC drivers allow it, and we have not had complaints. It is not
really something i'm a fan of, it in theory allows user
Hello Ying,
On 6/6/24 01:03, Ying Hsu wrote:
> On the CalDigit Thunderbolt Station 3 Plus, we've encountered an issue
> when the USB downstream display connection state changes. The
> problematic sequence observed is:
> ```
> igb_io_error_detected
> igb_down
> igb_io_error_detected
> igb_down
> ``
Hi all,
This commit introduced a regression. What does not work with this commit is an
AER without a surprise removal event.
On 5/18/23 00:26, Ying Hsu wrote:
> In a setup where a Thunderbolt hub connects to Ethernet and a display
> through USB Type-C, users may experience a hung task timeout w
On the CalDigit Thunderbolt Station 3 Plus, we've encountered an issue
when the USB downstream display connection state changes. The
problematic sequence observed is:
```
igb_io_error_detected
igb_down
igb_io_error_detected
igb_down
```
The second igb_down call blocks at napi_synchronize.
Simply a
On 6/06/24 09:16, Jacob Keller wrote:
>
> On 6/5/2024 2:10 PM, Chris Packham wrote:
>> On 6/06/24 08:51, Jacob Keller wrote:
>>> On 6/3/2024 8:10 PM, jackie.j...@alliedtelesis.co.nz wrote:
From: Jackie Jone
To facilitate running PHY parametric tests, add support for the SIOCSMIIREG
On 6/06/24 08:51, Jacob Keller wrote:
>
> On 6/3/2024 8:10 PM, jackie.j...@alliedtelesis.co.nz wrote:
>> From: Jackie Jone
>>
>> To facilitate running PHY parametric tests, add support for the SIOCSMIIREG
>> ioctl. This allows a userspace application to write to the PHY registers
>> to enable the
On Tue, May 21, 2024 at 10:34 AM Sasha Neftin wrote:
>
> Any thought? Revert?
>
Sorry for the noise. Is there any solution?
--
Best Regards,
Mike Gavrilov.
On 6/3/2024 11:47 AM, Joshua Hay wrote:
There are several reasons for a TX completion to take longer than usual
to be written back by HW. For example, the completion for a packet that
misses a rule will have increased latency. The side effect of these
variable latencies for any given packet i
On 6/5/2024 5:48 PM, Jakub Kicinski wrote:
> On Tue, 4 Jun 2024 15:13:21 -0700 Jesse Brandeburg wrote:
>> - - `ETHTOOL_MSG_PAUSE_GET`
>>- `ETHTOOL_MSG_FEC_GET`
>> + - 'ETHTOOL_MSG_LINKSTATE_GET'
>>- `ETHTOOL_MSG_MM_GET`
>> + - `ETHTOOL_MSG_PAUSE_GET`
>> + - 'ETHTOOL_MSG_TSINFO_GET'
On 6/6/2024 8:41 AM, Andrew Lunn wrote:
> On Wed, Jun 05, 2024 at 01:51:24PM -0700, Jacob Keller wrote:
>>
>>
>> On 6/3/2024 8:10 PM, jackie.j...@alliedtelesis.co.nz wrote:
>>> From: Jackie Jone
>>>
>>> To facilitate running PHY parametric tests, add support for the SIOCSMIIREG
>>> ioctl. This
From: Dima Ruinskiy
On vPro systems, the configuration of the I219-LM to achieve power
gating and S0ix residency is split between the driver and the CSME FW.
It was discovered that in some scenarios, where the network cable is
connected and then disconnected, S0ix residency is not always reached.
On 6/5/2024 5:48 PM, Jakub Kicinski wrote:
> On Tue, 4 Jun 2024 15:13:21 -0700 Jesse Brandeburg wrote:
>> - - `ETHTOOL_MSG_PAUSE_GET`
>>- `ETHTOOL_MSG_FEC_GET`
>> + - 'ETHTOOL_MSG_LINKSTATE_GET'
>>- `ETHTOOL_MSG_MM_GET`
>> + - `ETHTOOL_MSG_PAUSE_GET`
>> + - 'ETHTOOL_MSG_TSINFO_GET'
>
On Wed, Jun 05, 2024 at 01:51:24PM -0700, Jacob Keller wrote:
>
>
> On 6/3/2024 8:10 PM, jackie.j...@alliedtelesis.co.nz wrote:
> > From: Jackie Jone
> >
> > To facilitate running PHY parametric tests, add support for the SIOCSMIIREG
> > ioctl. This allows a userspace application to write to th
Allow the driver to be compatible with different FW API versions based
on the device's MAC type. Currently, E810 is only compatible with one
FW API version. Now the driver can be compatible with different FW API
versions for both E810 and E830. For example, E810 FW API version is
1.5.0 and E830 is
On 09.05.2024 18:11, Tony Nguyen wrote:
Seems like commit message, and probably title, need to get updated for
this change?
During testing of the change, it turns out at the current state our
driver is in we have to use the approach with returning -EBUSY. Will
update the description in v5 to
From: Piotr Raczynski
Use previously implemented SF aux driver. It is probe during SF
activation and remove after deactivation.
Reviewed-by: Simon Horman
Signed-off-by: Piotr Raczynski
Signed-off-by: Michal Swiatkowski
---
.../ethernet/intel/ice/devlink/devlink_port.c | 173 +
Implement add / delete vlan for subfunction type VSI.
Reviewed-by: Simon Horman
Reviewed-by: Wojciech Drewek
Signed-off-by: Michal Swiatkowski
---
drivers/net/ethernet/intel/ice/Makefile | 1 +
.../ethernet/intel/ice/ice_sf_vsi_vlan_ops.c | 21 +++
.../ethernet/intel/ic
Flow for creating Tx topology is the same as for VF port representors,
but the devlink port is stored in different place (sf->devlink_port).
When creating VF devlink lock isn't taken, when creating subfunction it
is. Setting Tx topology function needs to take this lock, check if it
was taken befor
Subfunction port representor needs the basic netdevice ops to work
correctly. Create them.
Reviewed-by: Wojciech Drewek
Reviewed-by: Jiri Pirko
Signed-off-by: Michal Swiatkowski
---
drivers/net/ethernet/intel/ice/ice_repr.c | 57 +--
1 file changed, 43 insertions(+), 14 del
Add check for subfunction before setting target VSI. It is needed for PF
in switchdev mode but not for subfunction (even in switchdev mode).
Reviewed-by: Simon Horman
Signed-off-by: Michal Swiatkowski
---
drivers/net/ethernet/intel/ice/ice_txrx.c | 2 +-
1 file changed, 1 insertion(+), 1 deleti
Now there is another type of port representor. Correct checking if
parent device is ready to reflect also new PR type.
Reviewed-by: Simon Horman
Reviewed-by: Wojciech Drewek
Signed-off-by: Michal Swiatkowski
---
drivers/net/ethernet/intel/ice/ice_ethtool.c | 7 +++
drivers/net/ethernet/in
Implement attaching and detaching SF port representor. It is done in the
same way as the VF port representor.
SF port representor is always added or removed with devlink
lock taken.
Reviewed-by: Simon Horman
Signed-off-by: Michal Swiatkowski
---
.../ethernet/intel/ice/devlink/devlink_port.c |
Keep the same flow of port representor creation, but instead of general
attach function create helpers for specific representor type.
Store function pointer for add and remove representor.
Type of port representor can be also known based on VSI type, but it
is more clean to have it directly saved
From: Piotr Raczynski
Configure netdevice for subfunction usecase. Mostly it is reusing ops
from the PF netdevice.
SF netdev is linked to devlink port registered after SF activation.
Reviewed-by: Simon Horman
Reviewed-by: Jiri Pirko
Signed-off-by: Piotr Raczynski
Signed-off-by: Michal Swiatk
From: Piotr Raczynski
Implement subfunction driver. It is probe when subfunction port is
activated.
VSI is already created. During the probe VSI is being configured.
MAC unicast and broadcast filter is added to allow traffic to pass.
Store subfunction pointer in VSI struct. The same is done for
From: Piotr Raczynski
Make devlink allocation function generic to use it for PF and for SF.
Add function for SF devlink port creation. It will be used in next
patch.
Create header file for subfunction device. Define subfunction device
structure there as it is needed for devlink allocation and p
When subfunction VSI is open the same code as for PF VSI should be
executed. Also when up is complete. Reflect that in code by adding
subfunction VSI to consideration.
In case of stopping, PF doesn't have additional tasks, so the same
is with subfunction VSI.
Reviewed-by: Simon Horman
Signed-off
From: Piotr Raczynski
Implement devlink port handlers responsible for ethernet type devlink
subfunctions. Create subfunction devlink port and setup all resources
needed for a subfunction netdev to operate. Configure new VSI for each
new subfunction, initialize and configure interrupts and Tx/Rx r
From: Piotr Raczynski
Make some of the netdevice_ops functions visible from outside for
another VSI type created netdev.
Reviewed-by: Simon Horman
Reviewed-by: Przemek Kitszel
Reviewed-by: Wojciech Drewek
Signed-off-by: Piotr Raczynski
Signed-off-by: Michal Swiatkowski
---
drivers/net/ethe
From: Piotr Raczynski
Add required plumbing for new VSI type dedicated to devlink subfunctions.
Make sure that the vsi is properly configured and destroyed. Also allow
loading XDP and AF_XDP sockets.
The first implementation of devlink subfunctions supports only one Tx/Rx
queue pair per given su
Hi,
Currently ice driver does not allow creating more than one networking
device per physical function. The only way to have more hardware backed
netdev is to use SR-IOV.
Following patchset adds support for devlink port API. For each new
pcisf type port, driver allocates new VSI, configures all r
> The kernel now has common statistics for transmit timestamps, so implement
> them in the ice driver.
>
> use via
> ethtool -I -T eth0
>
> Reviewed-by: Jacob Keller
> Signed-off-by: Jesse Brandeburg
> ---
>
> $ sudo ethtool -I -T eth0
> Time stamping parameters for eth0:
> Capabilities:
>
On 04.06.2024 11:09, Wojciech Drewek wrote:
>
>
> On 04.06.2024 07:56, Hariprasad Kelam wrote:
>>
>>
>>> From: Pawel Kaminski
>>>
>>> Add support for driver-specific devlink local_forwarding param.
>>> Supported values are "enabled", "disabled" and "prioritized".
>>> Default configuration is
41 matches
Mail list logo
