[Intel-wired-lan] [PATCH iwl-next] ice: use irq_update_affinity_hint()

2024-05-22 Thread Michal Schmidt
irq_set_affinity_hint() is deprecated. Use irq_update_affinity_hint() instead. This removes the side-effect of actually applying the affinity. The driver does not really need to worry about spreading its IRQs across CPUs. The core code already takes care of that. On the contrary, when the driver a

Re: [Intel-wired-lan] [PATCH iwl-net] ice: check for unregistering correct number of devlink params

2024-05-22 Thread Jacob Keller
On 5/22/2024 3:38 AM, Przemek Kitszel wrote: > On 5/21/24 23:26, Jacob Keller wrote: >> >> >> On 5/20/2024 3:20 PM, Dave Ertman wrote: >>> On module load, the ice driver checks for the lack of a specific PF >>> capabilty to determine if it should reduce the number of devlink params >>> to regist

[Intel-wired-lan] [PATCH iwl-next 13/13] iavf: add support for offloading tc U32 cls filters

2024-05-22 Thread Ahmed Zaki
Add support for offloading cls U32 filters. Only "skbedit queue_mapping" and "drop" actions are supported. Also, only "ip" and "802_3" tc protocols are allowed. The PF must advertise the VIRTCHNL_VF_OFFLOAD_TC_U32 capability flag. Since the filters will be enabled via the FD stage at the PF, a new

[Intel-wired-lan] [PATCH iwl-next 12/13] iavf: refactor add/del FDIR filters

2024-05-22 Thread Ahmed Zaki
In preparation for a second type of FDIR filters that can be added by tc-u32, move the add/del of the FDIR logic to be entirely contained in iavf_fdir.c. The iavf_find_fdir_fltr_by_loc() is renamed to iavf_find_fdir_fltr() to be more agnostic to the filter ID parameter (for now @loc, which is rele

[Intel-wired-lan] [PATCH iwl-next 11/13] ice: enable FDIR filters from raw binary patterns for VFs

2024-05-22 Thread Ahmed Zaki
From: Junfeng Guo Enable VFs to create FDIR filters from raw binary patterns. The corresponding processes for raw flow are added in the Parse / Create / Destroy stages. Reviewed-by: Marcin Szycik Signed-off-by: Junfeng Guo Co-developed-by: Ahmed Zaki Signed-off-by: Ahmed Zaki --- .../net/et

[Intel-wired-lan] [PATCH iwl-next 10/13] ice: add method to disable FDIR SWAP option

2024-05-22 Thread Ahmed Zaki
From: Junfeng Guo The SWAP Flag in the FDIR Programming Descriptor doesn't work properly, it is always set and cannot be unset (hardware bug). Thus, add a method to effectively disable the FDIR SWAP option by setting the FDSWAP instead of FDINSET registers. Reviewed-by: Marcin Szycik Signed-off

[Intel-wired-lan] [PATCH iwl-next 08/13] ice: add API for parser profile initialization

2024-05-22 Thread Ahmed Zaki
From: Junfeng Guo Add API ice_parser_profile_init() to init a parser profile based on a parser result and a mask buffer. The ice_parser_profile struct is used by the low level FXP engine to create HW profile/field vectors. Reviewed-by: Marcin Szycik Signed-off-by: Qi Zhang Signed-off-by: Junfe

[Intel-wired-lan] [PATCH iwl-next 09/13] virtchnl: support raw packet in protocol header

2024-05-22 Thread Ahmed Zaki
From: Junfeng Guo The patch extends existing virtchnl_proto_hdrs structure to allow VF to pass a pair of buffers as packet data and mask that describe a match pattern of a filter rule. Then the kernel PF driver is requested to parse the pair of buffer and figure out low level hardware metadata (p

[Intel-wired-lan] [PATCH iwl-next 07/13] ice: add UDP tunnels support to the parser

2024-05-22 Thread Ahmed Zaki
From: Junfeng Guo Add support for the vxlan, geneve, ecpri UDP tunnels through the following APIs: - ice_parser_vxlan_tunnel_set() - ice_parser_geneve_tunnel_set() - ice_parser_ecpri_tunnel_set() Reviewed-by: Marcin Szycik Signed-off-by: Qi Zhang Signed-off-by: Junfeng Guo Signed-off-by: Ahme

[Intel-wired-lan] [PATCH iwl-next 05/13] ice: add parser execution main loop

2024-05-22 Thread Ahmed Zaki
From: Junfeng Guo Implement the core work of the runtime parser via: - ice_parser_rt_execute() - ice_parser_rt_reset() - ice_parser_rt_pkt_buf_set() Reviewed-by: Marcin Szycik Signed-off-by: Qi Zhang Signed-off-by: Junfeng Guo Signed-off-by: Ahmed Zaki --- drivers/net/ethernet/intel/ice/Mak

[Intel-wired-lan] [PATCH iwl-next 06/13] ice: support turning on/off the parser's double vlan mode

2024-05-22 Thread Ahmed Zaki
From: Junfeng Guo Add API ice_parser_dvm_set() to support turning on/off the parser's double vlan mode. Reviewed-by: Marcin Szycik Signed-off-by: Qi Zhang Signed-off-by: Junfeng Guo Co-developed-by: Ahmed Zaki Signed-off-by: Ahmed Zaki --- drivers/net/ethernet/intel/ice/ice_parser.c | 77 +

[Intel-wired-lan] [PATCH iwl-next 03/13] ice: add debugging functions for the parser sections

2024-05-22 Thread Ahmed Zaki
From: Junfeng Guo Add debug for all parser sections. Reviewed-by: Marcin Szycik Signed-off-by: Qi Zhang Signed-off-by: Junfeng Guo Signed-off-by: Ahmed Zaki --- drivers/net/ethernet/intel/ice/ice_parser.c | 470 1 file changed, 470 insertions(+) diff --git a/drivers/ne

[Intel-wired-lan] [PATCH iwl-next 04/13] ice: add parser internal helper functions

2024-05-22 Thread Ahmed Zaki
From: Junfeng Guo Add the following internal helper functions: - ice_bst_tcam_match(): to perform ternary match on boost TCAM. - ice_pg_cam_match(): to perform parse graph key match in cam table. - ice_pg_nm_cam_match(): to perform parse graph key no match in cam table. - ice_ptype_mk_t

[Intel-wired-lan] [PATCH iwl-next 02/13] ice: parse and init various DDP parser sections

2024-05-22 Thread Ahmed Zaki
From: Junfeng Guo Parse the following DDP sections: - ICE_SID_RXPARSER_IMEM into an array of struct ice_imem_item - ICE_SID_RXPARSER_METADATA_INIT into an array of struct ice_metainit_item - ICE_SID_RXPARSER_CAM or ICE_SID_RXPARSER_PG_SPILL into an array of struct ice_pg_cam_item - ICE_SID

[Intel-wired-lan] [PATCH iwl-next 01/13] ice: add parser create and destroy skeleton

2024-05-22 Thread Ahmed Zaki
From: Junfeng Guo Add new parser module which can parse a packet in binary and generate information like ptype, protocol/offset pairs and flags which can be later used to feed the FXP profile creation directly. Add skeleton of the create and destroy APIs: ice_parser_create() ice_parser_destroy()

[Intel-wired-lan] [PATCH iwl-next 00/13] ice: iavf: add support for TC U32 filters on VFs

2024-05-22 Thread Ahmed Zaki
The IntelĀ® Ethernet 800 Series is designed with a pipeline that has an on-chip programmable capability called Dynamic Device Personalization (DDP). A DDP package is loaded by the driver during probe time. The DDP package programs functionality in both the parser and switching blocks in the pipeline

Re: [Intel-wired-lan] [PATCH iwl-net v3] ice: avoid infinite loop if NVM has invalid TLV length

2024-05-22 Thread Jacob Keller
On 5/20/2024 1:33 AM, Przemek Kitszel wrote: > On 5/18/24 01:22, Jacob Keller wrote: >> The ice_get_pfa_module_tlv() function iterates over the TLVs in the >> Preserved Fields Area (PFA) of the NVM. This is used to access data such as >> the Part Board Assembly identifier. >> >> Some NVMs in the

Re: [Intel-wired-lan] [PATCH iwl-net] ice: fix reads from NVM Shadow RAM on E830 and E825-C devices

2024-05-22 Thread Jacob Keller
On 5/21/2024 9:11 PM, Paul Menzel wrote: > Dear Jacob, > > > Am 21.05.24 um 21:27 schrieb Jacob Keller: > >> On 5/20/2024 10:55 PM, Paul Menzel wrote: > >>> Am 20.05.24 um 23:39 schrieb Jacob Keller: The ice driver reads data from the Shadow RAM portion of the NVM during initializa

Re: [Intel-wired-lan] [PATCH iwl-next v5 5/5] ixgbe: Enable link management in E610 device

2024-05-22 Thread Kwapulinski, Piotr
>-Original Message- >From: Paul Menzel >Sent: Wednesday, April 24, 2024 4:53 PM >To: Kwapulinski, Piotr >Cc: intel-wired-...@lists.osuosl.org; j...@resnulli.us; >net...@vger.kernel.org; Jagielski, Jedrzej ; >ho...@kernel.org; Wyborny, Carolyn ; Glaza, Jan > >Subject: Re: [Intel-wired-

Re: [Intel-wired-lan] [PATCH iwl-net] ice: check for unregistering correct number of devlink params

2024-05-22 Thread Przemek Kitszel
On 5/21/24 23:26, Jacob Keller wrote: On 5/20/2024 3:20 PM, Dave Ertman wrote: On module load, the ice driver checks for the lack of a specific PF capabilty to determine if it should reduce the number of devlink params to register. One situation when this test returns true is when the driver

[Intel-wired-lan] [PATCH iwl-next v1 1/1] igc: add support for ethtool.set_phys_id

2024-05-22 Thread Vitaly Lifshits
Add support for ethtool.set_phys_id callback to initiate LED blinking and stopping them by the ethtool interface. This is done by storing the initial LEDCTL register value and restoring it when LED blinking is terminated. In addition, moved IGC_LEDCTL related defines from igc_leds.c to igc_defines

[Intel-wired-lan] [iwl-net v1 1/1] igc: Fix Energy Efficient Ethernet support declaration

2024-05-22 Thread Sasha Neftin
The commit 01cf893bf0f4 ("net: intel: i40e/igc: Remove setting Autoneg in EEE capabilities") removed SUPPORTED_Autoneg field but left inappropriate ethtool_keee structure initialization. When "ethtool --show " (get_eee) invoke, the 'ethtool_keee' structure was accidentally overridden. Remove the 'e