[Intel-wired-lan] [iwl-next v2 7/7] ice: allow to activate and deactivate subfunction

2024-04-09 Thread Michal Swiatkowski
From: Piotr Raczynski Use previously implemented SF aux driver. It is probe during SF activation and remove after deactivation. Signed-off-by: Piotr Raczynski Signed-off-by: Michal Swiatkowski --- .../ethernet/intel/ice/devlink/devlink_port.c | 7 ++ .../ethernet/intel/ice/devlink/devlink_p

[Intel-wired-lan] [iwl-next v2 6/7] ice: implement netdev for subfunction

2024-04-09 Thread Michal Swiatkowski
From: Piotr Raczynski Configure netdevice for subfunction usecase. Mostly it is reusing ops from the PF netdevice. SF netdev is linked to devlink port registered after SF activation. Signed-off-by: Piotr Raczynski Signed-off-by: Michal Swiatkowski --- drivers/net/ethernet/intel/ice/ice_sf_et

[Intel-wired-lan] [iwl-next v2 5/7] ice: base subfunction aux driver

2024-04-09 Thread Michal Swiatkowski
From: Piotr Raczynski Implement subfunction driver. It is probe when subfunction port is activated. VSI is already created. During the probe VSI is being configured. MAC unicast and broadcast filter is added to allow traffic to pass. Signed-off-by: Piotr Raczynski Signed-off-by: Michal Swiatko

[Intel-wired-lan] [iwl-next v2 4/7] ice: allocate devlink for subfunction

2024-04-09 Thread Michal Swiatkowski
From: Piotr Raczynski Make devlink allocation function generic to use it for PF and for SF. Add function for SF devlink port creation. It will be used in next patch. Signed-off-by: Piotr Raczynski Signed-off-by: Michal Swiatkowski --- .../net/ethernet/intel/ice/devlink/devlink.c | 41 ++

[Intel-wired-lan] [iwl-next v2 3/7] ice: add basic devlink subfunctions support

2024-04-09 Thread Michal Swiatkowski
From: Piotr Raczynski Implement devlink port handlers responsible for ethernet type devlink subfunctions. Create subfunction devlink port and setup all resources needed for a subfunction netdev to operate. Configure new VSI for each new subfunction, initialize and configure interrupts and Tx/Rx r

[Intel-wired-lan] [iwl-next v2 2/7] ice: export ice ndo_ops functions

2024-04-09 Thread Michal Swiatkowski
From: Piotr Raczynski Make some of the netdevice_ops functions visible from outside for another VSI type created netdev. Reviewed-by: Przemek Kitszel Reviewed-by: Wojciech Drewek Signed-off-by: Piotr Raczynski Signed-off-by: Michal Swiatkowski --- drivers/net/ethernet/intel/ice/ice.h |

[Intel-wired-lan] [iwl-next v2 1/7] ice: add new VSI type for subfunctions

2024-04-09 Thread Michal Swiatkowski
From: Piotr Raczynski Add required plumbing for new VSI type dedicated to devlink subfunctions. Make sure that the vsi is properly configured and destroyed. Also allow loading XDP and AF_XDP sockets. The first implementation of devlink subfunctions supports only one Tx/Rx queue pair per given su

[Intel-wired-lan] [iwl-next v2 0/7] ice: support devlink subfunction

2024-04-09 Thread Michal Swiatkowski
Hi, This is second patchset split from subfunction patchset [1]. Important changes from previous version: * remove unnecessary checks for devlink port type * link correct devlink port to subfunction netdev Follow up patchset with subfunction port representor will be the last patchset for subfun

[Intel-wired-lan] [intel-next 2/2] net/i40e: add support for per queue netlink stats

2024-04-09 Thread Joe Damato
Make i40e compatible with the newly added netlink per queue stats. $ ./cli.py --spec ../../../Documentation/netlink/specs/netdev.yaml \ --dump qstats-get --json '{"scope": "queue"}' [{'ifindex': 3, 'queue-id': 0, 'queue-type': 'rx', 'rx-alloc-fail': 0, 'rx-bytes': 45540208, '

[Intel-wired-lan] [intel-next 1/2] net/i40e: link NAPI instances to queues and IRQs

2024-04-09 Thread Joe Damato
Make i40e compatible with the newly added netlink queue GET APIs. $ ./cli.py --spec ../../../Documentation/netlink/specs/netdev.yaml \ --do queue-get --json '{"ifindex": 3, "id": 1, "type": "rx"}' {'id': 1, 'ifindex': 3, 'napi-id': 162, 'type': 'rx'} $ ./cli.py --spec ../../../Documentation/ne

[Intel-wired-lan] [intel-next 0/2] i40e: Add support for netlink API

2024-04-09 Thread Joe Damato
Greetings: This change adds support for the new netlink APIs to i40e which: - link queues, NAPI IDs, and IRQs together - export per-queue stats This change is inspired by a similar change made to the ice driver commit 91fdbce7e8d6 ("ice: Add support in the driver for associating queue with na

Re: [Intel-wired-lan] [PATCH iwl-net] ice: Fix checking for unsupported keys on non-tunnel device

2024-04-09 Thread Jacob Keller
On 4/9/2024 8:45 AM, Marcin Szycik wrote: > Add missing FLOW_DISSECTOR_KEY_ENC_* checks to TC flower filter parsing. > Without these checks, it would be possible to add filters with tunnel > options on non-tunnel devices. enc_* options are only valid for tunnel > devices. > > Example: > devli

[Intel-wired-lan] [tnguy-next-queue:1GbE] BUILD SUCCESS 75f16e06dfb8035a89548ca33d26b362c934acc9

2024-04-09 Thread kernel test robot
-20240409 gcc arc randconfig-002-20240409 gcc arm allmodconfig gcc arm allnoconfig clang arm allyesconfig gcc arm at91_dt_defconfig clang arm

Re: [Intel-wired-lan] [PATCH net-next v9 7/9] libeth: add Rx buffer management

2024-04-09 Thread Kees Cook
On Mon, Apr 08, 2024 at 11:45:32AM +0200, Alexander Lobakin wrote: > From: Alexander Lobakin > Date: Mon, 8 Apr 2024 11:11:12 +0200 > > > From: Jakub Kicinski > > Date: Fri, 5 Apr 2024 21:25:13 -0700 > > > >> On Thu, 4 Apr 2024 17:44:00 +0200 Alexander Lobakin wrote: > >>> +/** > >>> + * struc

[Intel-wired-lan] [PATCH iwl-net] ice: Fix checking for unsupported keys on non-tunnel device

2024-04-09 Thread Marcin Szycik
Add missing FLOW_DISSECTOR_KEY_ENC_* checks to TC flower filter parsing. Without these checks, it would be possible to add filters with tunnel options on non-tunnel devices. enc_* options are only valid for tunnel devices. Example: devlink dev eswitch set $PF1_PCI mode switchdev echo 1 > /sys/

Re: [Intel-wired-lan] [iwl-next v1 4/7] ice: allocate devlink for subfunction

2024-04-09 Thread Michal Swiatkowski
On Tue, Apr 09, 2024 at 10:34:27AM +0200, Mateusz Polchlopek wrote: > > > On 4/8/2024 12:30 PM, Michal Swiatkowski wrote: > > From: Piotr Raczynski > > > > Make devlink allocation function generic to use it for PF and for SF. > > > > Add function for SF devlink port creation. It will be used i

[Intel-wired-lan] [tnguy-next-queue:dev-queue] BUILD SUCCESS c7218b2fabcf8a5182c21414ecae0f10e2075d65

2024-04-09 Thread kernel test robot
allmodconfig gcc arc allnoconfig gcc arc allyesconfig gcc arc defconfig gcc arc randconfig-001-20240409 gcc arc randconfig-002

Re: [Intel-wired-lan] [PATCH net-next 0/3] ethtool: Max power support

2024-04-09 Thread Andrew Lunn
> This is something my current design supports I think. Using > ETHTOOL_A_MODULE_MAX_POWER_SET user can get what cage supports > and change it. > This could be done using ethtool_module_power_mode_policy I think. All these 'I think' don't give me a warm fuzzy feeling this is a well thought out a

[Intel-wired-lan] [tnguy-net-queue:dev-queue] BUILD SUCCESS 3ca3256cde596573d060eda8c477996435c6d63f

2024-04-09 Thread kernel test robot
gcc arc allnoconfig gcc arc allyesconfig gcc arc defconfig gcc arc randconfig-001-20240409 gcc arc randconfig-002-20240409 gcc arc

Re: [Intel-wired-lan] [PATCH net-next 0/3] ethtool: Max power support

2024-04-09 Thread Wojciech Drewek
On 04.04.2024 15:53, Andrew Lunn wrote: > On Thu, Apr 04, 2024 at 02:45:43PM +0200, Wojciech Drewek wrote: >> >> >> On 03.04.2024 15:49, Andrew Lunn wrote: > $ ethtool --set-module enp1s0f0np0 power-max-set 4000 > > actually talk to the SFP module and tell it the maximum power it can

Re: [Intel-wired-lan] [PATCH net-next v9 7/9] libeth: add Rx buffer management

2024-04-09 Thread Przemek Kitszel
On 4/8/24 11:09, Alexander Lobakin wrote: From: Przemek Kitszel Date: Fri, 5 Apr 2024 12:32:55 +0200 On 4/4/24 17:44, Alexander Lobakin wrote: Add a couple intuitive helpers to hide Rx buffer implementation details [...] +struct libeth_fqe { +    struct page    *page; +    u32

Re: [Intel-wired-lan] [iwl-next v1 4/7] ice: allocate devlink for subfunction

2024-04-09 Thread Mateusz Polchlopek
On 4/8/2024 12:30 PM, Michal Swiatkowski wrote: From: Piotr Raczynski Make devlink allocation function generic to use it for PF and for SF. Add function for SF devlink port creation. It will be used in next patch. Signed-off-by: Piotr Raczynski Signed-off-by: Michal Swiatkowski --- ...

Re: [Intel-wired-lan] [PATCH iwl-net] ice: fix LAG and VF lock dependency in ice_reset_vf()

2024-04-09 Thread Mateusz Polchlopek
On 4/9/2024 1:03 AM, Jacob Keller wrote: 9f74a3dfcf83 ("ice: Fix VF Reset paths when interface in a failed over aggregate"), the ice driver has acquired the LAG mutex in ice_reset_vf(). The commit placed this lock acquisition just prior to the acquisition of the VF configuration lock. If ice_