[Intel-wired-lan] [tnguy-net-queue:dev-queue] BUILD SUCCESS 275878c3d97f5279ef52e62def46b7f3a117d133

tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/tnguy/net-queue.git dev-queue branch HEAD: 275878c3d97f5279ef52e62def46b7f3a117d133 i40e: Fix VF MAC filter removal elapsed time: 733m configs tested: 153 configs skipped: 3 The following configs have been built successfully. More c

Re: [Intel-wired-lan] intel i225 NIC loses PCIe link, network becomes unusable)

On 2024-02-26 17:10, Arno Lehmann wrote: > Hi all, > > I couldn't see any replies to this issue (but I'm also not subscribed to the > list, probably something I should consider...) but I have another instance of > the issue reported. > > Now cc'ing other parties in the hope to get indication th

Re: [Intel-wired-lan] [PATCH iwl-next v7 1/6] devlink: extend devlink_param *set pointer

On Fri, Mar 08, 2024 at 06:39:14AM -0500, Mateusz Polchlopek wrote: > Extend devlink_param *set function pointer to take extack as a param. > Sometimes it is needed to pass information to the end user from set > function. It is more proper to use for that netlink instead of passing > message to dme

Re: [Intel-wired-lan] [iwl-net v1] ice: tc: do default match on all profiles

On Tue, Mar 12, 2024 at 11:52:59AM +0100, Michal Swiatkowski wrote: > A simple non-tunnel rule (e.g. matching only on destination MAC) in > hardware will be hit only if the packet isn't a tunnel. In software > execution of the same command, the rule will match both tunnel and > non-tunnel packets.

Re: [Intel-wired-lan] [PATCH v4 iwl-net] i40e: Prevent setting MTU if greater than MFS

On Wed, Mar 13, 2024 at 10:07:16AM +0100, Erwan Velu wrote: > Commit 6871a7de705 ("[intelxl] Use admin queue to set port MAC address > and maximum frame size") from iPXE project set the MFS to 0x600 = 1536. > See https://github.com/ipxe/ipxe/commit/6871a7de705 > > At boot time the i40e driver comp

Re: [Intel-wired-lan] [PATCH iwl-net v1] ice: Fix package download algorithm

Dear Paul, dear Dan, Thank you for the patch. Am 18.03.24 um 17:29 schrieb Paul Greenwalt: From: Dan Nowlin Previously, the code would assume that only "Modular Signature Segment" existed. Given a package with both a "Reference Signature Segment" and a "Modular Signature Segment" the downloa

[Intel-wired-lan] [PATCH iwl-net v1] ice: Fix package download algorithm

From: Dan Nowlin Previously, the code would assume that only "Modular Signature Segment" existed. Given a package with both a "Reference Signature Segment" and a "Modular Signature Segment" the download would not have been successful because an incorrect sequence of buffers would be sent to the f

[Intel-wired-lan] [PATCH] ice: Remove newlines in NL_SET_ERR_MSG_MOD

Fixes Coccinelle/coccicheck warnings reported by newline_in_nl_msg.cocci. Signed-off-by: Thorsten Blum --- drivers/net/ethernet/intel/ice/ice_devlink.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/intel/ice/ice_devlink.c b/drivers/net/ethernet/i

[Intel-wired-lan] INFO: rcu detected stall in gc_worker

Hello, when using Healer to fuzz the latest Linux Kernel, the following crash was triggered on: HEAD commit: 0dd3ee31125508cd67f7e7172247f05b7fd1753a (tag: v6.7) git tree: upstream console output: https://pastebin.com/raw/0bRkEgvF kernel config: https://pastebin.com/raw/VecrLrRN C reprodu

Re: [Intel-wired-lan] [EXTERNAL] [PATCH v5] ice: Add get/set hw address for VFs using devlink commands

On 18.03.2024 12:55, Karthik Sundaravel wrote: > On Fri, Mar 8, 2024 at 3:28 PM Suman Ghosh wrote: >> >>> -- >>> Changing the MAC address of the VFs are not available via devlink. Add >>> the function handlers to set and get th

[Intel-wired-lan] [PATCH iwl-next 6/7] i40e: Add helper to access main VEB

Add a helper to access main VEB: i40e_pf_get_main_veb(pf) replaces 'pf->veb[pf->lan_veb]' Signed-off-by: Ivan Vecera --- drivers/net/ethernet/intel/i40e/i40e.h| 11 .../net/ethernet/intel/i40e/i40e_ethtool.c| 9 +++ drivers/net/ethernet/intel/i40e/i40e_main.c | 27 ++

[Intel-wired-lan] [PATCH iwl-next 7/7] i40e: Add and use helper to reconfigure TC for given VSI

Add helper i40e_vsi_reconfig_tc(vsi) that configures TC for given VSI using previously stored TC bitmap. Effectively replaces open-coded patterns: enabled_tc = vsi->tc_config.enabled_tc; vsi->tc_config.enabled_tc = 0; i40e_vsi_config_tc(vsi, enabled_tc); Signed-off-by: Ivan Vecera --- drivers/

[Intel-wired-lan] [PATCH iwl-next 5/7] i40e: Consolidate checks whether given VSI is main

In the driver code there are 3 types of checks whether given VSI is main or not: 1. vsi->type ==/!= I40E_VSI_MAIN 2. vsi ==/!= pf->vsi[pf->lan_vsi] 3. vsi->seid ==/!= pf->vsi[pf->lan_vsi]->seid All of them are equivalent and can be consolidated. Convert cases 2 and 3 to case 1. Signed-off-by: Iva

[Intel-wired-lan] [PATCH iwl-next 4/7] i40e: Add helper to access main VSI

Add simple helper i40e_pf_get_main_vsi(pf) to access main VSI that replaces pattern 'pf->vsi[pf->lan_vsi]' Signed-off-by: Ivan Vecera --- drivers/net/ethernet/intel/i40e/i40e.h| 11 ++ drivers/net/ethernet/intel/i40e/i40e_client.c | 10 +- drivers/net/ethernet/intel/i40e/i40e_ddp.c

[Intel-wired-lan] [PATCH iwl-next 3/7] i40e: Change argument of i40e_detect_recover_hung()

Commit 07d44190a389 ("i40e/i40evf: Detect and recover hung queue scenario") changes i40e_detect_recover_hung() argument type from i40e_pf* to i40e_vsi* to be shareable by both i40e and i40evf. Because the i40evf does not exist anymore and the function is exclusively used by i40e we can revert this

[Intel-wired-lan] [PATCH iwl-next 2/7] i40e: Change argument of several client notification functions

Commit 0ef2d5afb12d ("i40e: KISS the client interface") simplified the client interface so in practice it supports only one client per i40e netdev. But we have still 2 notification functions that uses as parameter a pointer to VSI of netdevice associated with the client. After the mentioned commit

[Intel-wired-lan] [PATCH iwl-next 1/7] i40e: Remove flags field from i40e_veb

The field is initialized always to zero and it is never read. Remove it. Signed-off-by: Ivan Vecera --- drivers/net/ethernet/intel/i40e/i40e.h | 3 +-- drivers/net/ethernet/intel/i40e/i40e_debugfs.c | 2 +- drivers/net/ethernet/intel/i40e/i40e_main.c| 13 + 3 files chan

[Intel-wired-lan] [PATCH iwl-next 0/7] i40e: cleanups & refactors

This series do following: Patch 1 - Removes write-only flags field from i40e_veb structure and from i40e_veb_setup() parameters Patch 2 - Changes parameter of i40e_notify_client_of_l2_param_changes() and i40e_notify_client_of_netdev_close() Patch 3 - Changes parameter of i40e_de

Re: [Intel-wired-lan] [PATCH] ice: set ethtool autoneg based on active cfg

Hi Tony, > On 15. Mar 2024, at 22:39, Tony Nguyen wrote: > > > > On 3/14/2024 2:15 AM, Ulrich Weber wrote: >> Current logic uses ICE_AQ_AN_COMPLETED information to >> flag if autonegotiation is enabled or disabled. >> Since new ethtool netlink interface checks if there is >> a configuration ch

Re: [Intel-wired-lan] [EXTERNAL] [PATCH v5] ice: Add get/set hw address for VFs using devlink commands

On Fri, Mar 8, 2024 at 3:28 PM Suman Ghosh wrote: > > >-- > >Changing the MAC address of the VFs are not available via devlink. Add > >the function handlers to set and get the HW address for the VFs. > > > >Signed-off-by: Karthik

Re: [Intel-wired-lan] [PATCH net] ice: Fix freeing uninitialized pointers

On Mon, Mar 18, 2024 at 08:58:24AM +0100, Jiri Pirko wrote: > Sat, Mar 16, 2024 at 10:44:40AM CET, dan.carpen...@linaro.org wrote: > >Automatically cleaned up pointers need to be initialized before exiting > >their scope. In this case, they need to be initialized to NULL before > >any return state

Re: [Intel-wired-lan] [PATCH net] ice: Fix freeing uninitialized pointers

Sat, Mar 16, 2024 at 10:44:40AM CET, dan.carpen...@linaro.org wrote: >Automatically cleaned up pointers need to be initialized before exiting >their scope. In this case, they need to be initialized to NULL before >any return statement. > >Fixes: 90f821d72e11 ("ice: avoid unnecessary devm_ usage")