Re: [Intel-wired-lan] [PATCH] ice: set ethtool autoneg based on active cfg

2024-03-15 Thread Tony Nguyen
On 3/14/2024 2:15 AM, Ulrich Weber wrote: Current logic uses ICE_AQ_AN_COMPLETED information to flag if autonegotiation is enabled or disabled. Since new ethtool netlink interface checks if there is a configuration change or not and ignores the call, if there is no change, this makes is impos

Re: [Intel-wired-lan] [PATCH net v3] i40e: Enforce software interrupt during busy-poll exit

2024-03-15 Thread Tony Nguyen
On 3/15/2024 2:20 AM, Ivan Vecera wrote: ... -static inline u32 i40e_buildreg_itr(const int type, u16 itr) +/** + * i40e_buildreg_itr - build a value for writing to I40E_PFINT_DYN_CTLN register + * @itr_idx - interrupt throttling index + * @interval - interrupt throttling interval value in use

Re: [Intel-wired-lan] [PATCH v4 iwl-net] i40e: Prevent setting MTU if greater than MFS

2024-03-15 Thread Brett Creeley
On 3/15/2024 2:17 AM, Erwan Velu wrote: Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding. Le 14/03/2024 à 21:31, Tony Nguyen a écrit : [..] Setting the mfs size to max values during init and reset would bet

[Intel-wired-lan] [iwl-net v1 2/2] ice: tc: allow zero flags in parsing tc flower

2024-03-15 Thread Michal Swiatkowski
The check for flags is done to not pass empty lookups to adding switch rule functions. Since metadata is always added to lookups there is no need to check against the flag. It is also fixing the problem with such rule: $ tc filter add dev gtp_dev ingress protocol ip prio 0 flower \ enc_dst

[Intel-wired-lan] [iwl-net v1 1/2] ice: tc: check src_vsi in case of traffic from VF

2024-03-15 Thread Michal Swiatkowski
In case of traffic going from the VF (so ingress for port representor) source VSI should be consider during packet classification. It is needed for hardware to not match packets from different ports with filters added on other port. It is only for "from VF" traffic, because other traffic direction

[Intel-wired-lan] [iwl-net v1 0/2] ice: two fixes for tc code

2024-03-15 Thread Michal Swiatkowski
Hi, Fix how ice driver is parsing tc filter. First is a fix to always add match for src_vsi in case filter is added on VF. Second is removing the flag check as it isn't needed and in some case can lead to a problem. Michal Swiatkowski (2): ice: tc: check src_vsi in case of traffic from VF ice

Re: [Intel-wired-lan] [PATCH net v3] i40e: Enforce software interrupt during busy-poll exit

2024-03-15 Thread Michal Schmidt
On Fri, Mar 15, 2024 at 10:20 AM Ivan Vecera wrote: > As for ice bug fixed by commit b7306b42beaf ("ice: manage interrupts > during poll exit") followed by commit 23be7075b318 ("ice: fix software > generating extra interrupts") I'm seeing the similar issue also with > i40e driver. > > In certain s

[Intel-wired-lan] [tnguy-net-queue:dev-queue] BUILD SUCCESS 2ee6b39038f6b6bc0ce1db7332b9654385cd1c5d

2024-03-15 Thread kernel test robot
gcc arc allnoconfig gcc arc allyesconfig gcc arc defconfig gcc arc randconfig-001-20240315 gcc arc randconfig-002-20240315 gcc arm

[Intel-wired-lan] [tnguy-next-queue:dev-queue] BUILD SUCCESS 21800674f8b93df218cef40ca1831cd0116fb0dc

2024-03-15 Thread kernel test robot
allnoconfig gcc arc allyesconfig gcc arc defconfig gcc arc randconfig-001-20240315 gcc arc randconfig-002-20240315 gcc arm

[Intel-wired-lan] [tnguy-net-queue:200GbE] BUILD SUCCESS e30cef001da259e8df354b813015d0e5acc08740

2024-03-15 Thread kernel test robot
allnoconfig gcc arc allyesconfig gcc arc defconfig gcc arcnsim_700_defconfig gcc arc randconfig-001-20240315 gcc arc randconfig-002

[Intel-wired-lan] [PATCH net v3] i40e: Enforce software interrupt during busy-poll exit

2024-03-15 Thread Ivan Vecera
As for ice bug fixed by commit b7306b42beaf ("ice: manage interrupts during poll exit") followed by commit 23be7075b318 ("ice: fix software generating extra interrupts") I'm seeing the similar issue also with i40e driver. In certain situation when busy-loop is enabled together with adaptive coales

Re: [Intel-wired-lan] [PATCH net] i40e: Enforce software interrupt during busy-poll exit

2024-03-15 Thread Ivan Vecera
On 15. 03. 24 1:53, Jesse Brandeburg wrote: On 3/13/2024 5:54 AM, Ivan Vecera wrote: As for ice bug fixed by commit b7306b42beaf ("ice: manage interrupts during poll exit") I'm seeing the similar issue also with i40e driver. In certain situation when busy-loop is enabled together with adapti

Re: [Intel-wired-lan] [PATCH v4 iwl-net] i40e: Prevent setting MTU if greater than MFS

2024-03-15 Thread Erwan Velu
Le 14/03/2024 à 21:31, Tony Nguyen a écrit : [..] Setting the mfs size to max values during init and reset would better; this is what the ice driver does. However, this would take implementing new AdminQ calls. IMO this patch is ok to prevent the issue being reported and allow for ease of ba

Re: [Intel-wired-lan] [PATCH net v2] i40e: Enforce software interrupt during busy-poll exit

2024-03-15 Thread Ivan Vecera
On 15. 03. 24 2:03, Jesse Brandeburg wrote: On 3/14/2024 5:00 AM, Ivan Vecera wrote: As for ice bug fixed by commit b7306b42beaf ("ice: manage interrupts during poll exit") followed by commit 23be7075b318 ("ice: fix software generating extra interrupts") I'm seeing the similar issue also with i4

Re: [Intel-wired-lan] [PATCH net-next v3 0/3] ice: lighter locking for PTP time reading

2024-03-15 Thread Przemek Kitszel
On 3/7/24 23:25, Michal Schmidt wrote: This series removes the use of the heavy-weight PTP hardware semaphore in the gettimex64 path. Instead, serialization of access to the time register is done using a host-side spinlock. The timer hardware is shared between PFs on the PCI adapter, so the spinl

Re: [Intel-wired-lan] [PATCH iwl-net] igc: Remove stale comment about Tx timestamping

2024-03-15 Thread Przemek Kitszel
On 3/14/24 11:35, Sebastian Andrzej Siewior wrote: On 2024-03-14 11:21:38 [+0100], Przemek Kitszel wrote: On 3/13/24 14:03, Kurt Kanzenbach wrote: The initial igc Tx timestamping implementation used only one register for retrieving Tx timestamps. Commit 3ed247e78911 ("igc: Add support for multi