Re: [Intel-wired-lan] [PATCH iwl-next v2 2/2] net: intel: implement modern PM ops declarations

2024-03-12 Thread Pucha, HimasekharX Reddy
> -Original Message- > From: Intel-wired-lan On Behalf Of Jesse > Brandeburg > Sent: Wednesday, March 6, 2024 8:20 AM > To: intel-wired-...@lists.osuosl.org > Cc: pmen...@molgen.mpg.de; net...@vger.kernel.org; Eric Dumazet > ; Nguyen, Anthony L ; Brady, > Alan ; ho...@kernel.org; Jakub

Re: [Intel-wired-lan] [PATCH iwl-next v2 1/2] igb: simplify pci ops declaration

2024-03-12 Thread Pucha, HimasekharX Reddy
> -Original Message- > From: Intel-wired-lan On Behalf Of Jesse > Brandeburg > Sent: Wednesday, March 6, 2024 8:20 AM > To: intel-wired-...@lists.osuosl.org > Cc: pmen...@molgen.mpg.de; net...@vger.kernel.org; Eric Dumazet > ; Nguyen, Anthony L ; Brady, > Alan ; ho...@kernel.org; Jakub

Re: [Intel-wired-lan] [PATCH v3] i40e: Prevent setting MTU if greater than MFS

2024-03-12 Thread Tony Nguyen
On 3/12/2024 3:29 AM, Erwan Velu wrote: On Tue, 2024-03-12 at 10:42 +0100, Erwan Velu wrote: This looks like a legit fix that should target the 'net' tree, @Tony: do you agree? If so, Erwan, please include a suitable fixes tag in the next revision. Please include into the subj prefix a suitabl

Re: [Intel-wired-lan] [PATCH iwl-next] i40e: avoid forward declarations in i40e_nvm.c

2024-03-12 Thread Pucha, HimasekharX Reddy
> -Original Message- > From: Intel-wired-lan On Behalf Of > Maciej Fijalkowski > Sent: Wednesday, March 6, 2024 10:01 PM > To: intel-wired-...@lists.osuosl.org > Cc: net...@vger.kernel.org; Fijalkowski, Maciej > ; Nguyen, Anthony L > ; Karlsson, Magnus > Subject: [Intel-wired-lan] [PAT

Re: [Intel-wired-lan] [PATCH iwl-net v2] ice: fix memory corruption bug with suspend and rebuild

2024-03-12 Thread Pucha, HimasekharX Reddy
> -Original Message- > From: Intel-wired-lan On Behalf Of Jesse > Brandeburg > Sent: Wednesday, March 6, 2024 4:32 AM > To: pmen...@molgen.mpg.de; intel-wired-...@lists.osuosl.org > Cc: net...@vger.kernel.org; Kitszel, Przemyslaw > ; Eric Dumazet ; Nguyen, > Anthony L ; ho...@kernel.org

Re: [Intel-wired-lan] [PATCH Linux-6.8-rc5 1/1] ixgbevf: start negotiate with api version 1.4

2024-03-12 Thread yifei . l . liu
Hi Paul, I apologize for possible html text in the previous email. I cleared the format and resend them as plain text. Thank you. Yifei From: Yifei Liu Sent: Monday, March 4, 2024 1:48 PM To: Paul Menzel Cc: jesse.brandeb...@intel.com ; anthony.l.ngu...@intel.com ; da...@davemloft.net ;

[Intel-wired-lan] [iwl-net v1] ice: tc: do default match on all profiles

2024-03-12 Thread Michal Swiatkowski
A simple non-tunnel rule (e.g. matching only on destination MAC) in hardware will be hit only if the packet isn't a tunnel. In software execution of the same command, the rule will match both tunnel and non-tunnel packets. Change the hardware behaviour to match tunnel and non-tunnel packets in thi

Re: [Intel-wired-lan] [PATCH iwl-net] i40e: fix i40e_count_filters() to count only active/new filters

2024-03-12 Thread Loktionov, Aleksandr
> -Original Message- > From: Paul Menzel > Sent: Tuesday, March 12, 2024 10:36 AM > To: Loktionov, Aleksandr > Cc: intel-wired-...@lists.osuosl.org; Nguyen, Anthony L > ; net...@vger.kernel.org; Kubalewski, > Arkadiusz > Subject: Re: [Intel-wired-lan] [PATCH iwl-net] i40e: fix > i40e_c

Re: [Intel-wired-lan] [PATCH v3] i40e: Prevent setting MTU if greater than MFS

2024-03-12 Thread Erwan Velu
> On Tue, 2024-03-12 at 10:42 +0100, Erwan Velu wrote: > > Commit 6871a7de705b6f6a4046f0d19da9bcd689c3bc8e from iPXE project is > > Please use the checkpatch-friendly commit reference: <12char hash> > ("") Done. > This looks like a legit fix that should target the 'net' tree, @Tony: > do you agree

Re: [Intel-wired-lan] [PATCH v3] i40e: Prevent setting MTU if greater than MFS

2024-03-12 Thread Erwan Velu
> Am 12.03.24 um 10:42 schrieb Erwan Velu: > > Commit 6871a7de705b6f6a4046f0d19da9bcd689c3bc8e from iPXE project is > > setting the MFS to 0x600 = 1536. > > Please add a link, as most people do not have the iPXE archive checked > out. Maybe also add the commit message summary. I will, thanks. > >

Re: [Intel-wired-lan] [PATCH v3] i40e: Prevent setting MTU if greater than MFS

2024-03-12 Thread Paolo Abeni
Hi, On Tue, 2024-03-12 at 10:42 +0100, Erwan Velu wrote: > Commit 6871a7de705b6f6a4046f0d19da9bcd689c3bc8e from iPXE project is Please use the checkpatch-friendly commit reference: <12char hash> ("") > setting the MFS to 0x600 = 1536. > > At boot time the i40e driver complains about it with > t

[Intel-wired-lan] [tnguy-net-queue:dev-queue] BUILD SUCCESS 9b3d82e976156d765ff2e4b7c902c5b3c536b6b3

2024-03-12 Thread kernel test robot
arc allnoconfig gcc arc allyesconfig gcc arc defconfig gcc arc randconfig-001-20240312 gcc arc randconfig-002-20240312 gcc arc

[Intel-wired-lan] [tnguy-next-queue:dev-queue] BUILD SUCCESS 3cb4323c0ed292b6ba9b8836224ed90eea0efc98

2024-03-12 Thread kernel test robot
allnoconfig gcc arc allyesconfig gcc arc axs101_defconfig gcc arc defconfig gcc arc randconfig-001-20240312 gcc arc randconfig-002

[Intel-wired-lan] [tnguy-next-queue:10GbE] BUILD SUCCESS 44208f59362e7099877f9ba79e1472f6bd321e2e

2024-03-12 Thread kernel test robot
allnoconfig gcc arc allyesconfig gcc arc axs101_defconfig gcc arc defconfig gcc arc randconfig-001-20240312 gcc arc randconfig-002-20240312

Re: [Intel-wired-lan] [PATCH v3] i40e: Prevent setting MTU if greater than MFS

2024-03-12 Thread Paul Menzel
Dear Erwan, Thank you very umch for your patch. Am 12.03.24 um 10:42 schrieb Erwan Velu: Commit 6871a7de705b6f6a4046f0d19da9bcd689c3bc8e from iPXE project is setting the MFS to 0x600 = 1536. Please add a link, as most people do not have the iPXE archive checked out. Maybe also add the commi

[Intel-wired-lan] [PATCH v3] i40e: Prevent setting MTU if greater than MFS

2024-03-12 Thread Erwan Velu
Commit 6871a7de705b6f6a4046f0d19da9bcd689c3bc8e from iPXE project is setting the MFS to 0x600 = 1536. At boot time the i40e driver complains about it with the following message but continues. MFS for port 1 has been set below the default: 600 If the MTU size is increased, the driver acce

[Intel-wired-lan] [PATCH v2] i40e: Prevent setting MTU if greater than MFS

2024-03-12 Thread Erwan Velu
Commit 6871a7de705b6f6a4046f0d19da9bcd689c3bc8e from iPXE project is setting the MFS to 0x600 = 1536. At boot time the i40e driver complains about it with the following message but continues. MFS for port 1 has been set below the default: 600 If the MTU size is increased, the driver acce

Re: [Intel-wired-lan] [PATCH iwl-net] i40e: fix i40e_count_filters() to count only active/new filters

2024-03-12 Thread Paul Menzel
Dear Aleksandr, Thank you for your patch. Am 12.03.24 um 09:13 schrieb Aleksandr Loktionov: Fix counter to be bumped only for new or active filters. Although it’s a small diffstat, could you please elaborate, and at least describe the problem in more detail. How can this be tested? Fixe

Re: [Intel-wired-lan] [PATCH iwl-net] i40e: fix i40e_count_filters() to count only active/new filters

2024-03-12 Thread Przemek Kitszel
On 3/12/24 09:13, Aleksandr Loktionov wrote: Fix counter to be bumped only for new or active filters. Fixes: 621650cabee5 ("i40e: Refactoring VF MAC filters counting to make more reliable") Signed-off-by: Aleksandr Loktionov Reviewed-by: Arkadiusz Kubalewski --- drivers/net/ethernet/intel/i

[Intel-wired-lan] [PATCH iwl-net] i40e: fix i40e_count_filters() to count only active/new filters

2024-03-12 Thread Aleksandr Loktionov
Fix counter to be bumped only for new or active filters. Fixes: 621650cabee5 ("i40e: Refactoring VF MAC filters counting to make more reliable") Signed-off-by: Aleksandr Loktionov Reviewed-by: Arkadiusz Kubalewski --- drivers/net/ethernet/intel/i40e/i40e_main.c | 7 +-- 1 file changed, 5 i

Re: [Intel-wired-lan] [PATCH 1/1] idpf: Clean up the vmvf_type for ctlq_recv functions

2024-03-12 Thread Przemek Kitszel
On 3/12/24 07:15, Zhu Yanjun wrote: From: Zhu Yanjun In the original source code, add vmvf_type to ctrl_msg for ctlq_recv functions. These new types will be implemented and used. But currently these types are not used. So remove them. This commit message is hard to read. Also please try to us