On 3/7/24 00:51, Kees Cook wrote:
The norm should be flexible array structures with __counted_by
annotations, so DEFINE_FLEX() is updated to expect that. Rename
the non-annotated version to DEFINE_RAW_FLEX(), and update the
few existing users.
Signed-off-by: Kees Cook
---
Cc: Przemek Kitszel
C
On 3/6/2024 5:33 PM, Jesse Brandeburg wrote:
On 3/6/2024 8:56 AM, Maciej Fijalkowski wrote:
Fixes: b3e7b3a6ee92 ("ice: prevent NULL pointer deref during reload")
Reported-by: Robert Elliott
Signed-off-by: Jesse Brandeburg
Reviewed-by: Maciej Fijalkowski
Well, that refactor of config path i
On 3/6/2024 8:56 AM, Maciej Fijalkowski wrote:
Fixes: b3e7b3a6ee92 ("ice: prevent NULL pointer deref during reload")
Reported-by: Robert Elliott
Signed-off-by: Jesse Brandeburg
Reviewed-by: Maciej Fijalkowski
Well, that refactor of config path introduced lots of issues. Could
validation fol
On 3/6/24 17:51, Kees Cook wrote:
The norm should be flexible array structures with __counted_by
annotations, so DEFINE_FLEX() is updated to expect that. Rename
the non-annotated version to DEFINE_RAW_FLEX(), and update the
few existing users.
Signed-off-by: Kees Cook
LGTM:
Reviewed-by: G
On 3/4/2024 6:22 PM, Erwan Velu wrote:
I was also wondering if I shouldn't subtract I40E_PACKET_HDR_PAD from
the mfs to be more accurate, can you confirm this ?
Yes, you're correct, we should take the packet header out however...
If one can have a look at what is the exact procedure to fix th
On Wed, Mar 06, 2024 at 08:06:29AM +0100, Przemek Kitszel wrote:
> On 3/6/24 04:25, Gustavo A. R. Silva wrote:
> >
> >
> > On 05/03/24 19:07, Kees Cook wrote:
> > > The norm should be flexible array structures with __counted_by
> > > annotations, so DEFINE_FLEX() is updated to expect that. Rename
The norm should be flexible array structures with __counted_by
annotations, so DEFINE_FLEX() is updated to expect that. Rename
the non-annotated version to DEFINE_RAW_FLEX(), and update the
few existing users.
Signed-off-by: Kees Cook
---
Cc: Przemek Kitszel
Cc: Jesse Brandeburg
Cc: Tony Nguyen
On 3/1/2024 10:28 AM, javi.mer...@kernel.org wrote:
From: Ross Lagerwall
I'm unsure about the error path if `pci_enable_sriov()` fails. Do we
have to undo what `ice_start_vfs()` has started? I can see that
`ice_start_vfs()` has a teardown at the end, so maybe we need the same
code if `pci_ena
On Wed, Mar 06, 2024 at 05:14:12PM -0600, Bjorn Helgaas wrote:
> [+cc Paul for __maybe_unused cleanup]
>
> On Tue, Mar 05, 2024 at 06:50:21PM -0800, Jesse Brandeburg wrote:
> > The igb driver was pre-declaring tons of functions just so that it could
> > have an early declaration of the pci_driver
[+cc Paul for __maybe_unused cleanup]
On Tue, Mar 05, 2024 at 06:50:21PM -0800, Jesse Brandeburg wrote:
> The igb driver was pre-declaring tons of functions just so that it could
> have an early declaration of the pci_driver struct.
>
> Delete a bunch of the declarations and move the struct to th
> -Original Message-
> From: Intel-wired-lan On
> Behalf Of Simon Horman
> Sent: Wednesday, March 6, 2024 9:04 PM
> To: Brandeburg, Jesse
> Cc: pmen...@molgen.mpg.de; Michal Swiatkowski
> ; net...@vger.kernel.org;
> Kitszel, Przemyslaw ; Eric Dumazet
> ; Nguyen, Anthony L
> ; Jakub Kic
On Tue, Mar 05, 2024 at 03:02:03PM -0800, Jesse Brandeburg wrote:
> The ice driver would previously panic after suspend. This is caused
> from the driver *only* calling the ice_vsi_free_q_vectors() function by
> itself, when it is suspending. Since commit b3e7b3a6ee92 ("ice: prevent
> NULL pointer
On Wed, Mar 6, 2024 at 6:00 PM Jiri Pirko wrote:
> Wed, Mar 06, 2024 at 05:29:05PM CET, mschm...@redhat.com wrote:
> >There is a need for synchronization between ice PFs on the same physical
> >adapter.
> >
> >Add a "struct ice_adapter" for holding data shared between PFs of the
> >same multifunct
On Sun, Mar 03, 2024 at 04:32:25PM +0800, Song Yoong Siang wrote:
> This patch adds support to per-packet Tx hardware timestamp request to
> AF_XDP zero-copy packet via XDP Tx metadata framework. Please note that
> user needs to enable Tx HW timestamp capability via igc_ioctl() with
> SIOCSHWTSTAMP
Wed, Mar 06, 2024 at 05:29:05PM CET, mschm...@redhat.com wrote:
>There is a need for synchronization between ice PFs on the same physical
>adapter.
>
>Add a "struct ice_adapter" for holding data shared between PFs of the
>same multifunction PCI device. The struct is refcounted - each ice_pf
>holds
On Wed, Mar 06, 2024 at 05:46:02PM +0100, Maciej Fijalkowski wrote:
> On Mon, Mar 04, 2024 at 03:08:44PM -0800, Jesse Brandeburg wrote:
> > The ice driver would previously panic during suspend. This is caused
> > from the driver *only* calling the ice_vsi_free_q_vectors() function by
> > itself, wh
On Mon, Mar 04, 2024 at 03:08:44PM -0800, Jesse Brandeburg wrote:
> The ice driver would previously panic during suspend. This is caused
> from the driver *only* calling the ice_vsi_free_q_vectors() function by
> itself, when it is suspending. Since commit b3e7b3a6ee92 ("ice: prevent
> NULL pointer
Move code around to get rid of forward declarations. No functional
changes.
After a plain code juggling, checkpatch reported:
total: 0 errors, 7 warnings, 12 checks, 1581 lines checked
so while at it let's address old issues as well. Should we ever address
the remaining unnecessary forward declar
This is a cleanup. It is unnecessary to have this function just to call
another function.
Signed-off-by: Michal Schmidt
---
drivers/net/ethernet/intel/ice/ice_ptp.c | 25 +++-
1 file changed, 3 insertions(+), 22 deletions(-)
diff --git a/drivers/net/ethernet/intel/ice/ice_pt
The PTP hardware semaphore (PFTSYN_SEM) is used to synchronize
operations that program the PTP timers. The operations involve issuing
commands to the sideband queue. The E810 does not have a hardware
sideband queue, so the admin queue is used. The admin queue is slow.
I have observed delays in hund
There is a need for synchronization between ice PFs on the same physical
adapter.
Add a "struct ice_adapter" for holding data shared between PFs of the
same multifunction PCI device. The struct is refcounted - each ice_pf
holds a reference to it.
Its first use will be for PTP. I expect it will be
This series removes the use of the heavy-weight PTP hardware semaphore
in the gettimex64 path. Instead, serialization of access to the time
register is done using a host-side spinlock. The timer hardware is
shared between PFs on the PCI adapter, so the spinlock must be shared
between ice_pf instanc
> -Original Message-
> From: Intel-wired-lan On Behalf Of Steven
> Zou
> Sent: Thursday, February 8, 2024 8:49 AM
> To: intel-wired-...@lists.osuosl.org
> Cc: net...@vger.kernel.org; Zou, Steven ; Staikov,
> Andrii
> ; Lobakin, Aleksander
> ; Nguyen, Anthony L
> ; Simon Horman ; Kitszel,
allnoconfig gcc
arc allyesconfig gcc
arc defconfig gcc
arc randconfig-001-20240306 gcc
arc randconfig-002-20240306 gcc
arm
On Wed, 6 Mar 2024 22:55:48 +0800 Zou, Steven wrote:
> > We are seeing following kernel compilation error while compiling next
> > kernel:
> >
> > "error: dereferencing pointer to incomplete type 'struct dpll_pin'"
>
> Thanks Mayank!
> The patch does not touch 'stuct dpll_pin', I do not think t
On 3/6/2024 9:48 PM, Sharma, Mayank wrote:
-Original Message-
From: Intel-wired-lan On Behalf Of Steven
Zou
Sent: Thursday, February 8, 2024 8:49 AM
To: intel-wired-...@lists.osuosl.org
Cc: net...@vger.kernel.org; Zou, Steven ; Staikov, Andrii
; Lobakin, Aleksander
; Nguyen, Anthony L
On Tue, Mar 05, 2024 at 11:54:50AM -0800, Jakub Kicinski wrote:
> On Sat, 2 Mar 2024 01:50:03 +0100 Larysa Zaremba wrote:
> > For RX: match on Ethertype and mirror, every trusted VF should be able to
> > scan
> > neighbors.
> >
> > For TX this is more complicated and is done not through eswitch,
On Tue, Mar 05, 2024 at 06:50:22PM -0800, Jesse Brandeburg wrote:
> Switch the Intel networking drivers to use the new power management ops
> declaration formats and macros, which allows us to drop __maybe_unused,
> as well as a bunch of ifdef checking CONFIG_PM.
>
> This is safe to do because the
On Tue, Mar 05, 2024 at 06:50:21PM -0800, Jesse Brandeburg wrote:
> The igb driver was pre-declaring tons of functions just so that it could
> have an early declaration of the pci_driver struct.
>
> Delete a bunch of the declarations and move the struct to the bottom of the
> file, after all the f
gcc
arc allnoconfig gcc
arc allyesconfig gcc
arc defconfig gcc
arc randconfig-001-20240306 gcc
arc randconfig-002-20240306 gcc
arm
gcc
arc allmodconfig gcc
arc allnoconfig gcc
arc allyesconfig gcc
arc defconfig gcc
arc randconfig-001-20240305 gcc
arc randconfig-00
> -Original Message-
> From: Intel-wired-lan On Behalf Of Ivan
> Vecera
> Sent: Wednesday, February 28, 2024 10:56 PM
> To: net...@vger.kernel.org
> Cc: moderated list:INTEL ETHERNET DRIVERS ;
> Brandeburg, Jesse ; open list
> ; Eric Dumazet ; Nguyen,
> Anthony L ; Jakub Kicinski ;
>
> -Original Message-
> From: Intel-wired-lan On Behalf Of
> Przemek Kitszel
> Sent: Tuesday, February 27, 2024 8:01 PM
> To: intel-wired-...@lists.osuosl.org
> Cc: Nebojsa Stevanovic ;
> net...@vger.kernel.org; Czapnik, Lukasz ; Lobakin,
> Aleksander ; Nguyen, Anthony L
> ; Kitszel, Pr
Tue, Mar 05, 2024 at 03:39:42PM CET, mateusz.polchlo...@intel.com wrote:
>From: Michal Wilczynski
>
>New driver specific parameter 'tx_scheduling_layers' was introduced.
>Describe parameter in the documentation.
>
>Signed-off-by: Michal Wilczynski
>Acked-by: Jakub Kicinski
>Co-developed-by: Mate
Tue, Mar 05, 2024 at 03:39:41PM CET, mateusz.polchlo...@intel.com wrote:
>From: Lukasz Czapnik
>
>It was observed that Tx performance was inconsistent across all queues
>and/or VSIs and that it was directly connected to existing 9-layer
>topology of the Tx scheduler.
>
>Introduce new private devli
On 2/21/2024 01:57, Vinicius Costa Gomes wrote:
Fix "double" clearing of interrupts, which can cause external events
or timestamps to be missed.
The IGC_TSIRC Time Sync Interrupt Cause register can be cleared in two
ways, by either reading it or by writing '1' into the specific cause
bit. This i
On 05.03.2024 16:26, Karthik Sundaravel wrote:
> Changing the MAC address of the VFs are not available
> via devlink. Add the function handlers to set and get
> the HW address for the VFs.
>
> Signed-off-by: Karthik Sundaravel
> ---
> drivers/net/ethernet/intel/ice/ice_devlink.c | 78
Tue, Mar 05, 2024 at 03:39:37PM CET, mateusz.polchlo...@intel.com wrote:
>Extend devlink_param *set function pointer to take extack as a param.
>Sometimes it is needed to pass information to the end user from set
>function. It is more proper to use for that netlink instead of passing
>message to dm
38 matches
Mail list logo
