Refactoring of the field gets conversion introduced a regression in the
legacy Wake On Lan from a magic packet with i219 devices. Rx address
copied not correctly from MAC to PHY with FIELD_GET macro.
Fixes: b9a452545075 ("intel: legacy: field get conversion")
Suggested-by: Vitaly Lifshits
Signed-
gcc
i386 allyesconfig gcc
i386 buildonly-randconfig-001-20240217 gcc
i386 buildonly-randconfig-002-20240217 clang
i386 buildonly-randconfig-003-20240217 gcc
i386 buildonly-randconfig-004-20240217 gcc
i386
allmodconfig gcc
arc allnoconfig gcc
arc allyesconfig gcc
arc defconfig gcc
arc randconfig-001-20240217 gcc
arc randconfig-002-20240217 gcc
arm
On Sat, Feb 17, 2024 at 12:08:22PM -0600, Andrew Lunn wrote:
> Make use of the existing linkmode helpers for converting PHY EEE
> register values into links modes, now that ethtool_keee uses link
> modes, rather than u32 values.
>
> Rework determining if EEE is active to make is similar as to how
Make use of the existing linkmode helpers for converting PHY EEE
register values into links modes, now that ethtool_keee uses link
modes, rather than u32 values.
Signed-off-by: Andrew Lunn
---
drivers/net/ethernet/intel/igc/igc_ethtool.c | 9 +
1 file changed, 5 insertions(+), 4 deletion
Make use of the existing linkmode helpers for converting PHY EEE
register values into links modes, now that ethtool_keee uses link
modes, rather than u32 values.
Signed-off-by: Andrew Lunn
---
drivers/net/ethernet/intel/igb/igb_ethtool.c | 33 ++--
1 file changed, 22 inse
Make use of the existing linkmode helpers for converting PHY EEE
register values into links modes, now that ethtool_keee uses link
modes, rather than u32 values.
Signed-off-by: Andrew Lunn
---
drivers/net/ethernet/intel/e1000e/ethtool.c | 17 -
1 file changed, 12 insertions(+), 5
Energy Efficient Ethernet should always be negotiated with the link
peer. Don't include SUPPORTED_Autoneg in the results of get_eee() for
supported, advertised or lp_advertised, since it is
assumed. Additionally, ethtool(1) ignores the set bit, and no other
driver sets this.
Reviewed-by: Jacob Kel
Convert the tables to make use of ETHTOOL link mode bits, rather than
the old u32 SUPPORTED speeds. Make use of the linkmode helps to set
bits and compare linkmodes. As a result, the _u32 members of keee are
no longer used, a step towards removing them.
Signed-off-by: Andrew Lunn
---
drivers/net
Make use of the existing linkmode helpers for bit manipulation of EEE
advertise, support and link partner support. The aim is to drop the
restricted _u32 variants in the near future.
Signed-off-by: Andrew Lunn
---
drivers/net/ethernet/qlogic/qede/qede_ethtool.c | 60 -
1
EEE has until recently been limited to lower speeds due to the use of
the legacy u32 for link speeds. This restriction has been lifted, with
the use of linkmode bitmaps, added in the following patches:
1f069de63602 ethtool: add linkmode bitmap support to struct ethtool_keee
1d756ff13da6 ethtool: a
Make use of the existing linkmode helpers for converting PHY EEE
register values into links modes, now that ethtool_keee uses link
modes, rather than u32 values.
Signed-off-by: Andrew Lunn
---
drivers/net/usb/ax88179_178a.c | 9 -
1 file changed, 4 insertions(+), 5 deletions(-)
diff --g
Make use of the existing linkmode helpers for converting PHY EEE
register values into links modes, now that ethtool_keee uses link
modes, rather than u32 values.
Rework determining if EEE is active to make is similar as to how
phylib decides, and make use of a phylib helper to validate if EEE is
v
defconfig clang
i386 allmodconfig gcc
i386 allnoconfig gcc
i386 allyesconfig gcc
i386 buildonly-randconfig-001-20240217 gcc
i386 buildonly-randconfig-002
On Sat, Feb 17, 2024 at 07:05:07AM -0800, Richard Cochran wrote:
> Does setting ICR.Time_Sync[TXTS] also clear ICR.Time_Sync[RXTS] ?
>
> That is what you seem to be saying.
Okay, so you really mean that if the _same_ bit becomes set between
the read and the acknowledgment, then that event will b
FYI, this cover letter is missing netdev, lkml on CC.
Thanks,
Richard
On Fri, Feb 16, 2024 at 05:04:54PM -0800, Vinicius Costa Gomes wrote:
> Fix "double" clearing of interrupts, which can cause external events
> or timestamps to be missed.
>
> The E1000_TSIRC Time Sync Interrupt Cause register can be cleared in two
> ways, by either reading it or by writing '1' int
17 matches
Mail list logo
