Re: [Intel-wired-lan] [PATCH v1 iwl-next] igc: Add support for LEDs on i225/i226

2024-01-24 Thread Kurt Kanzenbach
On Wed Jan 24 2024, Andrew Lunn wrote: > On Wed, Jan 24, 2024 at 09:24:08AM +0100, Kurt Kanzenbach wrote: >> Add support for LEDs on i225/i226. The LEDs can be controlled via sysfs >> from user space using the netdev trigger. The LEDs are named as >> igc-- to be easily identified. >> >> Offloading

Re: [Intel-wired-lan] [PATCH v1 iwl-next] igc: Add support for LEDs on i225/i226

2024-01-24 Thread Kurt Kanzenbach
On Wed Jan 24 2024, Simon Horman wrote: > On Wed, Jan 24, 2024 at 09:24:08AM +0100, Kurt Kanzenbach wrote: > > ... > >> +static int igc_led_hw_control_set(struct led_classdev *led_cdev, >> + unsigned long flags) >> +{ >> +struct igc_led_classdev *ldev = lcdev_to_igc

Re: [Intel-wired-lan] [PATCH 4/6 iwl-next] idpf: refactor remaining virtchnl messages

2024-01-24 Thread Willem de Bruijn
Alan Brady wrote: > This takes care of RSS/SRIOV/MAC and other misc virtchnl messages. This > again is mostly mechanical. There's some added functionality with MAC > filters which makes sure we remove bad filters now that we can better > handle asynchronous messages. Can you split the part that is

Re: [Intel-wired-lan] [PATCH 0/6 iwl-next] idpf: refactor virtchnl messages

2024-01-24 Thread Willem de Bruijn
Alan Brady wrote: > The motivation for this series has two primary goals. We want to enable > support of multiple simultaneous messages and make the channel more > robust. The way it works right now, the driver can only send and receive > a single message at a time and if something goes really wron

Re: [Intel-wired-lan] [PATCH iwl-next v4 2/2] ice: Implement 'flow-type ether' rules

2024-01-24 Thread Paul Menzel
Dear Lukasz, dear Jakub, dear Mateusz, Thank you for your patch. Am 24.01.24 um 16:21 schrieb Lukasz Plachno: From: Jakub Buchocki Add support for 'flow-type ether' Flow Director rules via ethtool. Can you please elaborate on the implementation? Rules not containing masks are processed b

Re: [Intel-wired-lan] [PATCH iwl-next v4 2/2] ice: Implement 'flow-type ether' rules

2024-01-24 Thread Brett Creeley
On 1/24/2024 7:21 AM, Lukasz Plachno wrote: Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding. From: Jakub Buchocki Add support for 'flow-type ether' Flow Director rules via ethtool. Rules not containing m

Re: [Intel-wired-lan] [PATCH v1 iwl-next] igc: Add support for LEDs on i225/i226

2024-01-24 Thread Andrew Lunn
On Wed, Jan 24, 2024 at 09:24:08AM +0100, Kurt Kanzenbach wrote: > Add support for LEDs on i225/i226. The LEDs can be controlled via sysfs > from user space using the netdev trigger. The LEDs are named as > igc-- to be easily identified. > > Offloading activity and link speed is supported. Tested

[Intel-wired-lan] [PATCH iwl-next v4 2/2] ice: Implement 'flow-type ether' rules

2024-01-24 Thread Lukasz Plachno
From: Jakub Buchocki Add support for 'flow-type ether' Flow Director rules via ethtool. Rules not containing masks are processed by the Flow Director, and support the following set of input parameters in all combinations: src, dst, proto, vlan-etype, vlan, action. It is possible to specify addr

[Intel-wired-lan] [PATCH iwl-next v4 1/2] ice: Remove unnecessary argument from ice_fdir_comp_rules()

2024-01-24 Thread Lukasz Plachno
Passing v6 argument is unnecessary as flow_type is still analyzed inside the function. Reviewed-by: Przemek Kitszel Signed-off-by: Lukasz Plachno Reviewed-by: Simon Horman --- drivers/net/ethernet/intel/ice/ice_fdir.c | 85 +++ 1 file changed, 39 insertions(+), 46 deletions

[Intel-wired-lan] [PATCH iwl-next v4 0/2] ice: Support flow director ether type filters

2024-01-24 Thread Lukasz Plachno
Ethtool allows creating rules with type=ether, add support for such filters in ice driver. Patch 1 allows extending ice_fdir_comp_rules() with handling additional type of filters. v4: added warning explaining that masks other than broadcast and unicast are not supported, added check for empty

Re: [Intel-wired-lan] [PATCH iwl-next] ice: remove duplicate comment

2024-01-24 Thread Simon Horman
On Mon, Jan 22, 2024 at 10:24:17AM -0800, Tony Nguyen wrote: > From: Paul M Stillwell Jr > > Remove a comment that was not correct; this structure has nothing > to do with FW alignment. > > Reviewed-by: Przemek Kitszel > Signed-off-by: Paul M Stillwell Jr Sure, but the subject doesn't seem to

Re: [Intel-wired-lan] [PATCH v1 iwl-next] igc: Add support for LEDs on i225/i226

2024-01-24 Thread Simon Horman
On Wed, Jan 24, 2024 at 09:24:08AM +0100, Kurt Kanzenbach wrote: ... > +static int igc_led_hw_control_set(struct led_classdev *led_cdev, > + unsigned long flags) > +{ > + struct igc_led_classdev *ldev = lcdev_to_igc_ldev(led_cdev); > + struct igc_adapter *ada

Re: [Intel-wired-lan] [REGRESSION] Intel ICE Ethernet driver in linux >= 6.6.9 triggers extra memory consumption and cause continous kswapd* usage and continuous swapping

2024-01-24 Thread Paul Menzel
Dear Jaroslav, Am 24.01.24 um 15:29 schrieb Linux regression tracking (Thorsten Leemhuis): On 11.01.24 09:26, Jaroslav Pulchart wrote: On 1/8/2024 2:49 AM, Jaroslav Pulchart wrote: First, thank you for your work trying to chase this! I would like to report a regression triggered by recent ch

Re: [Intel-wired-lan] [PATCH iwl v2] i40e: print correct hw max rss count in kernel ring buffer

2024-01-24 Thread suresh ks
Hi Simon, Thanks a lot for getting back to me. I would say, it's not fixing any issue. This is since the beginning. My analysis is given below: [1] If I check the i40e_reconfig_rss_queues() function history, I see 'pf->rss_size_max' has been used since the beginning. Later via the below comm

Re: [Intel-wired-lan] [REGRESSION] Intel ICE Ethernet driver in linux >= 6.6.9 triggers extra memory consumption and cause continous kswapd* usage and continuous swapping

2024-01-24 Thread Linux regression tracking (Thorsten Leemhuis)
Hi, Thorsten here, the Linux kernel's regression tracker. On 11.01.24 09:26, Jaroslav Pulchart wrote: >> On 1/8/2024 2:49 AM, Jaroslav Pulchart wrote: >> First, thank you for your work trying to chase this! >>> I would like to report a regression triggered by recent change in >>> Intel ICE Etherne

Re: [Intel-wired-lan] [PATCH iwl-next v3 3/3] ixgbe: Cleanup after type convertion

2024-01-24 Thread Jagielski, Jedrzej
From: Kitszel, Przemyslaw Sent: Thursday, January 18, 2024 3:34 PM >On 1/18/24 14:43, Jedrzej Jagielski wrote: >> Clean up code where touched during type convertion by the patch >> 8035560dbfaf. Rearrange to fix reverse Christmas tree >I don't see this SHA in my copy, please fix it. I see this

Re: [Intel-wired-lan] [PATCH iwl-next 2/2] ice: make ice_vsi_cfg_txq() static

2024-01-24 Thread Simon Horman
On Tue, Jan 23, 2024 at 12:58:46PM +0100, Maciej Fijalkowski wrote: > Currently, XSK control path in ice driver calls directly > ice_vsi_cfg_txq() whereas we have ice_vsi_cfg_single_txq() for that > purpose. Use the latter from XSK side and make ice_vsi_cfg_txq() static. > > ice_vsi_cfg_txq() resi

Re: [Intel-wired-lan] [PATCH iwl-next 1/2] ice: make ice_vsi_cfg_rxq() static

2024-01-24 Thread Simon Horman
On Tue, Jan 23, 2024 at 12:58:45PM +0100, Maciej Fijalkowski wrote: > Currently, XSK control path in ice driver calls directly > ice_vsi_cfg_rxq() whereas we have ice_vsi_cfg_single_rxq() for that > purpose. Use the latter from XSK side and make ice_vsi_cfg_rxq() static. > > ice_vsi_cfg_rxq() resi

[Intel-wired-lan] [PATCH v2 iwl-next 3/3] igc: Unify filtering rule fields

2024-01-24 Thread Kurt Kanzenbach
All filtering parameters such as EtherType and VLAN TCI are stored in host byte order except for the VLAN EtherType. Unify it. Signed-off-by: Kurt Kanzenbach Acked-by: Vinicius Costa Gomes --- drivers/net/ethernet/intel/igc/igc.h | 2 +- drivers/net/ethernet/intel/igc/igc_ethtool.c |

[Intel-wired-lan] [PATCH v2 iwl-next 1/3] igc: Use reverse xmas tree

2024-01-24 Thread Kurt Kanzenbach
Use reverse xmas tree coding style convention in igc_add_flex_filter(). Signed-off-by: Kurt Kanzenbach Acked-by: Vinicius Costa Gomes --- drivers/net/ethernet/intel/igc/igc_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/intel/igc/igc_main.c b/dr

[Intel-wired-lan] [PATCH v2 iwl-next 0/3] igc: ethtool: Flex filter cleanup

2024-01-24 Thread Kurt Kanzenbach
Hi, this series contains some cosmetics for the flex filter code. The fixes have been merged separately via -net already. Changes since v1: * Add Vinicius Ack * Rebase to v6.8-rc1 * Wrap commit messages at 75 chars Previous versions: * v1: https://lore.kernel.org/netdev/20231128074849.1686

[Intel-wired-lan] [PATCH v2 iwl-next 2/3] igc: Use netdev printing functions for flex filters

2024-01-24 Thread Kurt Kanzenbach
All igc filter implementations use netdev_*() printing functions except for the flex filters. Unify it. Signed-off-by: Kurt Kanzenbach Acked-by: Vinicius Costa Gomes --- drivers/net/ethernet/intel/igc/igc_main.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/driver

[Intel-wired-lan] [PATCH v1 iwl-next] igc: Add support for LEDs on i225/i226

2024-01-24 Thread Kurt Kanzenbach
Add support for LEDs on i225/i226. The LEDs can be controlled via sysfs from user space using the netdev trigger. The LEDs are named as igc-- to be easily identified. Offloading activity and link speed is supported. Tested on Intel i225. Signed-off-by: Kurt Kanzenbach --- drivers/net/ethernet/i