Re: [Intel-wired-lan] [PATCH iwl-net v3] ice: reset first in crash dump kernels

2023-10-10 Thread Pucha, HimasekharX Reddy
> -Original Message- > From: Intel-wired-lan On Behalf Of Jesse > Brandeburg > Sent: Wednesday, October 4, 2023 10:32 PM > To: intel-wired-...@lists.osuosl.org > Cc: pmen...@molgen.mpg.de; Vishal Agrawal ; > linux-...@vger.kernel.org; Brandeburg, Jesse ; > net...@vger.kernel.org; j...@r

Re: [Intel-wired-lan] [PATCH net] i40e: prevent crash on probe if hw registers have invalid values

2023-10-10 Thread Pucha, HimasekharX Reddy
> -Original Message- > From: Intel-wired-lan On Behalf Of > Michal Schmidt > Sent: Friday, October 6, 2023 4:42 PM > To: intel-wired-...@lists.osuosl.org > Cc: Brandeburg, Jesse ; net...@vger.kernel.org; > Nguyen, Anthony L ; Jeff Kirsher > ; Shannon Nelson > Subject: [Intel-wired-lan]

Re: [Intel-wired-lan] [PATCH net-next v4 0/5] dpll: add phase-offset and phase-adjust

2023-10-10 Thread Jakub Kicinski
On Tue, 10 Oct 2023 00:26:11 +0200 Arkadiusz Kubalewski wrote: > Improve monitoring and control over dpll devices. > Allow user to receive measurement of phase difference between signals > on pin and dpll (phase-offset). > Allow user to receive and control adjustable value of pin's signal > phase (

Re: [Intel-wired-lan] [PATCH net-next] ethtool: ice: Support for RSS settings to GTP from ethtool

2023-10-10 Thread Jakub Kicinski
On Wed, 11 Oct 2023 10:56:17 +0900 takeru hayasaka wrote: > GTP generates a flow that includes an ID called TEID to identify the > tunnel. This tunnel is created for each UE (User Equipment). > By performing RSS based on this flow, it is possible to apply RSS for > each communication unit from the

Re: [Intel-wired-lan] [PATCH iwl-next v3 00/13] Add E800 live migration driver

2023-10-10 Thread Jacob Keller
On 9/17/2023 11:25 PM, Yahui Cao wrote: > This series adds vfio live migration support for Intel E810 VF devices > based on the v2 migration protocol definition series discussed here[0]. > > Steps to test: > 1. Bind one or more E810 VF devices to the module ice_vfio_pci.ko > 2. Assign the VFs to

Re: [Intel-wired-lan] [PATCH] igbvf: replace deprecated strncpy with strscpy

2023-10-10 Thread Jakub Kicinski
On Tue, 10 Oct 2023 17:47:31 -0700 Jakub Kicinski wrote: > Please do read the netdev rules Jesse pointed you at. > Maybe it's the combined flow of strncpy and __counted_by patches > but managing the state of the "hardening" patches is getting > a bit tedious :( > > Please group them into reasonab

Re: [Intel-wired-lan] [PATCH] igbvf: replace deprecated strncpy with strscpy

2023-10-10 Thread Jakub Kicinski
On Tue, 10 Oct 2023 14:41:10 -0700 Justin Stitt wrote: > > Thanks Justin for these patches, please make sure you mark the subject > > line as per the netdev rules: > > [PATCH net-next v1] etc etc > > Sure, I'll resend! Please do read the netdev rules Jesse pointed you at. Maybe it's the combine

Re: [Intel-wired-lan] [PATCH net-next 0/7] net: intel: replace deprecated strncpy uses

2023-10-10 Thread Kees Cook
interfaces. > > Previously, each of these patches was sent individually at: > 1) > https://lore.kernel.org/all/20231009-strncpy-drivers-net-ethernet-intel-e100-c-v1-1-ca0ff9686...@google.com/ > 2) > https://lore.kernel.org/all/20231010-strncpy-drivers-net-ethernet-intel-e

Re: [Intel-wired-lan] [PATCH net-next 0/7] net: intel: replace deprecated strncpy uses

2023-10-10 Thread Kees Cook
these patches was sent individually at: > > > 1) > > > https://lore.kernel.org/all/20231009-strncpy-drivers-net-ethernet-intel-e100-c-v1-1-ca0ff9686...@google.com/ > > > 2) > > > https://lore.kernel.org/all/20231010-strncpy-drivers-net-ethernet-intel-e1

Re: [Intel-wired-lan] [PATCH net-next 0/7] net: intel: replace deprecated strncpy uses

2023-10-10 Thread Jesse Brandeburg
> Previously, each of these patches was sent individually at: > 1) > https://lore.kernel.org/all/20231009-strncpy-drivers-net-ethernet-intel-e100-c-v1-1-ca0ff9686...@google.com/ > 2) > https://lore.kernel.org/all/20231010-strncpy-drivers-net-ethernet-intel-e1000-e1000

Re: [Intel-wired-lan] [PATCH net-next v3 1/6] net: ethtool: allow symmetric-xor RSS hash for any flow type

2023-10-10 Thread Ahmed Zaki
On 2023-10-10 14:40, Willem de Bruijn wrote: On Tue, Oct 10, 2023 at 4:05 PM Ahmed Zaki wrote: Symmetric RSS hash functions are beneficial in applications that monitor both Tx and Rx packets of the same flow (IDS, software firewalls, ..etc). Getting all traffic of the same flow on the same RX

Re: [Intel-wired-lan] [PATCH] igbvf: replace deprecated strncpy with strscpy

2023-10-10 Thread Jesse Brandeburg
On 10/10/2023 2:20 PM, Jesse Brandeburg wrote: > On 10/10/2023 2:12 PM, Justin Stitt wrote: >> `strncpy` is deprecated for use on NUL-terminated destination strings >> [1] and as such we should prefer more robust and less ambiguous string >> interfaces. >> >> We expect netdev->name to be NUL-termin

Re: [Intel-wired-lan] [PATCH] igc: replace deprecated strncpy with strscpy

2023-10-10 Thread Jesse Brandeburg
On 10/10/2023 2:15 PM, Justin Stitt wrote: > `strncpy` is deprecated for use on NUL-terminated destination strings > [1] and as such we should prefer more robust and less ambiguous string > interfaces. > > We expect netdev->name to be NUL-terminated based on its use with format > strings: > |

Re: [Intel-wired-lan] [PATCH] igb: replace deprecated strncpy with strscpy

2023-10-10 Thread Jesse Brandeburg
On 10/10/2023 2:07 PM, Justin Stitt wrote: > `strncpy` is deprecated for use on NUL-terminated destination strings > [1] and as such we should prefer more robust and less ambiguous string > interfaces. > > We see that netdev->name is expected to be NUL-terminated based on its > usage with format s

Re: [Intel-wired-lan] [PATCH] i40e: use scnprintf over strncpy+strncat

2023-10-10 Thread Jesse Brandeburg
On 10/10/2023 1:53 PM, Justin Stitt wrote: > `strncpy` is deprecated for use on NUL-terminated destination strings > [1] and as such we should prefer more robust and less ambiguous string > interfaces. > > Moreover, `strncat` shouldn't really be used either as per > fortify-string.h: > * Do not u

Re: [Intel-wired-lan] [PATCH] igbvf: replace deprecated strncpy with strscpy

2023-10-10 Thread Jesse Brandeburg
On 10/10/2023 2:12 PM, Justin Stitt wrote: > `strncpy` is deprecated for use on NUL-terminated destination strings > [1] and as such we should prefer more robust and less ambiguous string > interfaces. > > We expect netdev->name to be NUL-terminated based on its usage with > `strlen` and format st

Re: [Intel-wired-lan] [PATCH iwl-next v2] ice: read internal temperature sensor

2023-10-10 Thread Jacob Keller
On 10/5/2023 2:15 AM, Konrad Knitter wrote: > Since 4.30 firmware exposes internal thermal sensor reading via admin > queue commands. Expose those readouts via hwmon API when supported. > > Driver provides current reading from HW as well as device specific > thresholds for thermal alarm (Warning

Re: [Intel-wired-lan] [PATCH iwl-net v2 1/1] e1000e: Workaround for sporadic MDI error on Meteor Lake systems

2023-10-10 Thread Jacob Keller
On 10/4/2023 10:44 PM, Vitaly Lifshits wrote: > On some Meteor Lake systems accessing the PHY via the MDIO interface may > result in an MDI error. This issue happens sporadically and in most cases > a second access to the PHY via the MDIO interface results in success. > > As a workaround, intro

Re: [Intel-wired-lan] [PATCH net-next v3 1/6] net: ethtool: allow symmetric-xor RSS hash for any flow type

2023-10-10 Thread Willem de Bruijn
On Tue, Oct 10, 2023 at 4:05 PM Ahmed Zaki wrote: > > Symmetric RSS hash functions are beneficial in applications that monitor > both Tx and Rx packets of the same flow (IDS, software firewalls, ..etc). > Getting all traffic of the same flow on the same RX queue results in > higher CPU cache effic

Re: [Intel-wired-lan] [PATCH iwl-net v2 1/1] e1000e: Workaround for sporadic MDI error on Meteor Lake systems

2023-10-10 Thread Keller, Jacob E
> -Original Message- > From: Neftin, Sasha > Sent: Monday, October 9, 2023 10:20 PM > To: Keller, Jacob E ; intel-wired-lan@osuosl.org; > Ruinskiy, Dima ; Efrati, Nir ; > Lifshits, Vitaly > Cc: Neftin, Sasha > Subject: Re: [Intel-wired-lan] [PATCH iwl-net v2 1/1] e1000e: Workaround fo

Re: [Intel-wired-lan] [PATCH net-next v2 1/6] net: ethtool: allow symmetric RSS hash for any flow type

2023-10-10 Thread Ahmed Zaki
On 2023-10-07 03:01, Willem de Bruijn wrote: On Fri, Oct 6, 2023 at 7:22 PM Jakub Kicinski wrote: On Fri, 6 Oct 2023 16:47:21 -0600 Ahmed Zaki wrote: Symmetric RSS hash functions are beneficial in applications that monitor both Tx and Rx packets of the same flow (IDS, software firewalls, ..e

Re: [Intel-wired-lan] [PATCH net-next v2 2/6] ice: fix ICE_AQ_VSI_Q_OPT_RSS_* register values

2023-10-10 Thread Ahmed Zaki
On 2023-10-09 10:37, Jakub Kicinski wrote: On Fri, 6 Oct 2023 16:47:22 -0600 Ahmed Zaki wrote: Fixes: 7bd527aa174f ("ice: Adjust naming for inner VLAN operations") If there is v3 please drop the Fixes tag. If the mistake doesn't result in a triggerable bug there's no need to backport this a

[Intel-wired-lan] [PATCH net-next v3 5/6] ice: enable symmetric RSS Toeplitz hash for any flow type

2023-10-10 Thread Ahmed Zaki
From: Jeff Guo The hash function in the E800 NICs is set per-VSI and a specific AQ command is needed to modify the hash function. Use the AQ command to enable setting the symmetric Toeplitz RSS hash function for any VSI. When the Symmetric Toeplitz hash function is used, the hardware sets the in

[Intel-wired-lan] [PATCH net-next v3 6/6] iavf: enable symmetric RSS Toeplitz hash

2023-10-10 Thread Ahmed Zaki
Allow the VFs to support symmetric RSS for any flow type. The symmetric RSS will not be supported on PFs not advertising the ADV RSS Offload flag (ADV_RSS_SUPPORT()), for example the E700 series (i40e). Reviewed-by: Madhu Chittim Signed-off-by: Ahmed Zaki --- .../net/ethernet/intel/iavf/iavf_ad

[Intel-wired-lan] [PATCH net-next v3 4/6] ice: refactor the FD and RSS flow ID generation

2023-10-10 Thread Ahmed Zaki
The flow director and RSS blocks use separate methods to generate a unique 64 bit ID for the flow. This is not extendable, especially for the RSS that already uses all 64 bit space. Refactor the flow generation API so that the ID is generated within ice_flow_add_prof(). The FD and RSS blocks cache

[Intel-wired-lan] [PATCH net-next v3 3/6] ice: refactor RSS configuration

2023-10-10 Thread Ahmed Zaki
From: Qi Zhang Refactor the driver to use a communication data structure for RSS config. To do so we introduce the new ice_rss_hash_cfg struct, and then pass it as an argument to several functions. Also introduce enum ice_rss_cfg_hdr_type to specify a more granular and flexible RSS configuration

[Intel-wired-lan] [PATCH net-next v3 1/6] net: ethtool: allow symmetric-xor RSS hash for any flow type

2023-10-10 Thread Ahmed Zaki
Symmetric RSS hash functions are beneficial in applications that monitor both Tx and Rx packets of the same flow (IDS, software firewalls, ..etc). Getting all traffic of the same flow on the same RX queue results in higher CPU cache efficiency. A NIC that supports "symmetric-xor" can achieve this

[Intel-wired-lan] [PATCH net-next v3 0/6] Support symmetric RSS (Toeplitz) hash

2023-10-10 Thread Ahmed Zaki
Patch 1 adds the support at the Kernel level, allowing the user to set a symmetric RSS hash for any flow type via: # ethtool -N|-U eth0 rx-flow-hash s|d|f|n symmetric-xor Support for the new "symmetric-xor" flag will be later sent to the "ethtool" user-space tool. Patch 2 fixes a long stand

[Intel-wired-lan] [PATCH net-next v3 2/6] ice: fix ICE_AQ_VSI_Q_OPT_RSS_* register values

2023-10-10 Thread Ahmed Zaki
Fix the values of the ICE_AQ_VSI_Q_OPT_RSS_* registers. Shifting is already done when the values are used, no need to double shift. Bug was not discovered earlier since only ICE_AQ_VSI_Q_OPT_RSS_TPLZ (Zero) is currently used. Also, rename ICE_AQ_VSI_Q_OPT_RSS_XXX to ICE_AQ_VSI_Q_OPT_RSS_HASH_XXX f

Re: [Intel-wired-lan] [PATCH net-next] ethtool: ice: Support for RSS settings to GTP from ethtool

2023-10-10 Thread Jakub Kicinski
On Sun, 8 Oct 2023 07:52:22 + Takeru Hayasaka wrote: > This is a patch that enables RSS functionality for GTP packets using > ethtool. > A user can include her TEID and make RSS work for GTP-U over IPv4 by > doing the following: > `ethtool -N ens3 rx-flow-hash gtpu4 sd` > In addition to gtpu(4

[Intel-wired-lan] [PATCH iwl-next v2] ice: Fix SRIOV LAG disable on non-compliant aggreagate

2023-10-10 Thread Dave Ertman
If an attribute of an aggregate interface disqualifies it from supporting SRIOV, the driver will unwind the SRIOV support. Currently the driver is clearing the feature bit for all interfaces in the aggregate, but this is not allowing the other interfaces to unwind successfully on driver unload. O

Re: [Intel-wired-lan] [PATCH iwl-next] ice: Fix SRIOV LAG disable on non-compliant aggreagate

2023-10-10 Thread Ertman, David M
> -Original Message- > From: Simon Horman > Sent: Sunday, October 8, 2023 7:10 AM > To: Ertman, David M > Cc: intel-wired-...@lists.osuosl.org; net...@vger.kernel.org > Subject: Re: [PATCH iwl-next] ice: Fix SRIOV LAG disable on non-compliant > aggreagate > > On Fri, Oct 06, 2023 at 02:0

Re: [Intel-wired-lan] [PATCH net-next 4/5] iavf: in iavf_down, disable queues when removing the driver

2023-10-10 Thread Drewek, Wojciech
> -Original Message- > From: Michal Schmidt > Sent: Tuesday, October 10, 2023 2:22 PM > To: Drewek, Wojciech ; intel-wired- > l...@lists.osuosl.org > Cc: Nguyen, Anthony L ; Radoslaw Tyl > ; Brandeburg, Jesse > Subject: Re: [Intel-wired-lan] [PATCH net-next 4/5] iavf: in iavf_down, >

Re: [Intel-wired-lan] [PATCH net-next 4/5] iavf: in iavf_down, disable queues when removing the driver

2023-10-10 Thread Michal Schmidt
Dne 10. 10. 23 v 13:39 Drewek, Wojciech napsal: -Original Message- From: Intel-wired-lan On Behalf Of Michal Schmidt Sent: Tuesday, October 10, 2023 2:25 AM To: intel-wired-...@lists.osuosl.org Cc: Nguyen, Anthony L ; Radoslaw Tyl ; Brandeburg, Jesse Subject: [Intel-wired-lan] [PATCH

Re: [Intel-wired-lan] [PATCH net-next 2/5] iavf: simplify mutex_trylock+sleep loops

2023-10-10 Thread Drewek, Wojciech
> -Original Message- > From: Michal Schmidt > Sent: Tuesday, October 10, 2023 1:57 PM > To: Drewek, Wojciech ; intel-wired- > l...@lists.osuosl.org > Cc: Nguyen, Anthony L ; Radoslaw Tyl > ; Brandeburg, Jesse > Subject: Re: [Intel-wired-lan] [PATCH net-next 2/5] iavf: simplify > mutex_

Re: [Intel-wired-lan] [PATCH net-next 2/5] iavf: simplify mutex_trylock+sleep loops

2023-10-10 Thread Michal Schmidt
Dne 10. 10. 23 v 13:30 Drewek, Wojciech napsal: -Original Message- From: Intel-wired-lan On Behalf Of Michal Schmidt Sent: Tuesday, October 10, 2023 2:25 AM To: intel-wired-...@lists.osuosl.org Cc: Nguyen, Anthony L ; Radoslaw Tyl ; Brandeburg, Jesse Subject: [Intel-wired-lan] [PATCH ne

Re: [Intel-wired-lan] [PATCH net-next 5/5] iavf: fix the waiting time for initial reset

2023-10-10 Thread Drewek, Wojciech
> -Original Message- > From: Intel-wired-lan On Behalf Of > Michal Schmidt > Sent: Tuesday, October 10, 2023 2:25 AM > To: intel-wired-...@lists.osuosl.org > Cc: Nguyen, Anthony L ; Radoslaw Tyl > ; Brandeburg, Jesse > Subject: [Intel-wired-lan] [PATCH net-next 5/5] iavf: fix the waiti

Re: [Intel-wired-lan] [PATCH net-next 4/5] iavf: in iavf_down, disable queues when removing the driver

2023-10-10 Thread Drewek, Wojciech
> -Original Message- > From: Intel-wired-lan On Behalf Of > Michal Schmidt > Sent: Tuesday, October 10, 2023 2:25 AM > To: intel-wired-...@lists.osuosl.org > Cc: Nguyen, Anthony L ; Radoslaw Tyl > ; Brandeburg, Jesse > Subject: [Intel-wired-lan] [PATCH net-next 4/5] iavf: in iavf_down,

Re: [Intel-wired-lan] [PATCH net-next 0/5] iavf: cleanup, improvements in init and

2023-10-10 Thread Przemek Kitszel
On 10/10/23 02:24, Michal Schmidt wrote: Here are a couple of iavf cleanups and then improvements for the initialization flow (waiting for the VF reset) and driver removal. Michal Schmidt (5): iavf: fix comments about old bit locks iavf: simplify mutex_trylock+sleep loops iavf: in iavf_

Re: [Intel-wired-lan] [PATCH net-next 3/5] iavf: in iavf_down, don't queue watchdog_task if comms failed

2023-10-10 Thread Drewek, Wojciech
> -Original Message- > From: Intel-wired-lan On Behalf Of > Michal Schmidt > Sent: Tuesday, October 10, 2023 2:25 AM > To: intel-wired-...@lists.osuosl.org > Cc: Nguyen, Anthony L ; Radoslaw Tyl > ; Brandeburg, Jesse > Subject: [Intel-wired-lan] [PATCH net-next 3/5] iavf: in iavf_down,

Re: [Intel-wired-lan] [PATCH net-next 2/5] iavf: simplify mutex_trylock+sleep loops

2023-10-10 Thread Drewek, Wojciech
> -Original Message- > From: Intel-wired-lan On Behalf Of > Michal Schmidt > Sent: Tuesday, October 10, 2023 2:25 AM > To: intel-wired-...@lists.osuosl.org > Cc: Nguyen, Anthony L ; Radoslaw Tyl > ; Brandeburg, Jesse > Subject: [Intel-wired-lan] [PATCH net-next 2/5] iavf: simplify > mu

Re: [Intel-wired-lan] [PATCH net-next 1/5] iavf: fix comments about old bit locks

2023-10-10 Thread Drewek, Wojciech
> -Original Message- > From: Intel-wired-lan On Behalf Of > Michal Schmidt > Sent: Tuesday, October 10, 2023 2:25 AM > To: intel-wired-...@lists.osuosl.org > Cc: Nguyen, Anthony L ; Radoslaw Tyl > ; Brandeburg, Jesse > Subject: [Intel-wired-lan] [PATCH net-next 1/5] iavf: fix comments abo

Re: [Intel-wired-lan] [PATCH net-next v4 0/5] dpll: add phase-offset and phase-adjust

2023-10-10 Thread Vadim Fedorenko
On 09/10/2023 23:26, Arkadiusz Kubalewski wrote: Improve monitoring and control over dpll devices. Allow user to receive measurement of phase difference between signals on pin and dpll (phase-offset). Allow user to receive and control adjustable value of pin's signal phase (phase-adjust). v3->v4

Re: [Intel-wired-lan] [PATCH net v2] ixgbe: fix crash with empty VF macvlan list

2023-10-10 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (main) by Paolo Abeni : On Fri, 6 Oct 2023 15:53:09 +0300 you wrote: > The adapter->vf_mvs.l list needs to be initialized even if the list is > empty. Otherwise it will lead to crashes. > > Fixes: a1cbb15c1397 ("ixgbe: Add macvlan support for VF")

Re: [Intel-wired-lan] [PATCH net-next v4 0/5] dpll: add phase-offset and phase-adjust

2023-10-10 Thread Jiri Pirko
Tue, Oct 10, 2023 at 12:26:11AM CEST, arkadiusz.kubalew...@intel.com wrote: >Improve monitoring and control over dpll devices. >Allow user to receive measurement of phase difference between signals >on pin and dpll (phase-offset). >Allow user to receive and control adjustable value of pin's signal