[PATCH] drm/i915/selftests: Increasing the sleep time for live_rc6_manual

2024-02-08 Thread Sk Anirban
From: Anirban Sk To rule out the sporadic failure, updating the sleep time (time period to measure the power). Signed-off-by: Anirban Sk --- drivers/gpu/drm/i915/gt/selftest_rc6.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/gt/selftest_rc6.c b/

[PATCH v2] drm/i915/selftests: Increasing the sleep time for live_rc6_manual

2024-02-09 Thread Sk Anirban
From: Anirban Sk Sometimes gt_pm live_rc6_manual selftest fails due to no power being measured for the rc6 disabled period. Therefore increasing the rc6 disable period from 250ms to 1000ms to rule out such sporadic failure. Signed-off-by: Anirban Sk Reviewed-by: Anshuman Gupta Change log: v2:

[PATCH v3] drm/i915/selftests: Increasing the sleep time for live_rc6_manual

2024-02-11 Thread Sk Anirban
From: Anirban Sk Sometimes gt_pm live_rc6_manual selftest fails due to no power being measured for the rc6 disabled period. Therefore increasing the rc6 disable period from 250ms to 1000ms to rule out such sporadic failure. v3 : More descriptive and improved commit message (Anshuman) Signed-off

[PATCH] drm/i915/selftests: Implement Frequency Check for Energy Reading Validation

2024-09-17 Thread Sk Anirban
This commit introduces a frequency check mechanism aimed at ensuring the accuracy of energy readings. Signed-off-by: Sk Anirban --- drivers/gpu/drm/i915/gt/selftest_rc6.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/gpu/drm/i915/gt/selftest_rc6.c b/drivers/gpu/drm/i915/gt

[v2] drm/i915/selftests: Implement frequency check for energy reading validation

2024-09-17 Thread Sk Anirban
This commit introduces a frequency check mechanism aimed at ensuring the accuracy of energy readings. v2 : Improved commit message Signed-off-by: Anirban Sk --- drivers/gpu/drm/i915/gt/selftest_rc6.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/gpu/drm/i915/gt/selftest_rc6.

[PATCH v5] drm/i915/selftests: Implement frequency logging for energy reading validation

2024-09-30 Thread sk . anirban
From: Sk Anirban Introduce RC6 & RC0 frequency logging mechanism aimed at ensuring the accuracy of energy readings in case of GPU energy leak. v2: - Improved commit message. v3: - Used pr_err log to display frequency. (Anshuman) - Sorted headers alphabetically. (Sai Teja) v4: - Impr

[PATCH v5] drm/i915/selftests: Implement frequency logging for energy reading validation

2024-10-10 Thread Sk Anirban
ency (Anshuman) - Sorted headers alphabetically (Sai Teja) v4: - Improved commit message - Fix pr_err log (Sai Teja) v5: -Add error & debug logging for RC0 power and frequency checks (Anshuman) Signed-off-by: Sk Anirban Reviewed-by: Sai Teja Pottumuttu --- drivers/gpu/drm/i915/gt/self

[PATCH v6] drm/i915/selftests: Implement frequency logging for energy reading validation

2024-11-13 Thread Sk Anirban
ency (Anshuman) - Sorted headers alphabetically (Sai Teja) v4: - Improved commit message. - Fix pr_err log (Sai Teja) v5: - Add error & debug logging for RC0 power and frequency checks (Anshuman) v6: - Modify debug logging for RC0 power and frequency checks (Sai Teja) Signed-off-by: Sk

[PATCH v4] drm/i915/selftests: Implement frequency logging for energy reading validation

2024-09-27 Thread sk . anirban
From: Sk Anirban Introduce RC6 & RC0 frequency logging mechanism aimed at ensuring the accuracy of energy readings in case of GPU energy leak. v2: - Improved commit message. v3: - Used pr_err log to display frequency. (Anshuman) - Sorted headers alphabetically. (Sai Teja) v4: - Impr

[PATCH v3] drm/i915/selftests: Implement frequency check for energy reading validation

2024-09-19 Thread Sk Anirban
This commit introduces a frequency check mechanism aimed at ensuring the accuracy of energy readings. v2: - Improved commit message. v3: - Used pr_err log to display frequency. (Anshuman) - Sorted headers alphabetically. (Sai Teja) Signed-off-by: Sk Anirban --- drivers/gpu/drm/i915/gt

[PATCH v7] drm/i915/selftests: Implement frequency logging for energy reading validation

2024-11-29 Thread Sk Anirban
measured but frequency is (Anshuman) - Improved commit message (Badal) - Change API to read actual frequency without applying forcewake (Badal) - Update sleep time for RC6 mode (Anshuman) Signed-off-by: Sk Anirban Reviewed-by: Sai Teja Pottumuttu --- drivers/gpu/drm/i915/gt/selfte

[PATCH v1] drm/i915/selftests: Add delay to stabilize frequency in live_rps_power

2024-12-02 Thread Sk Anirban
Add delays to allow frequency stabilization before power measurement to fix sporadic power conservation issues in live_rps_power test. Signed-off-by: Sk Anirban --- drivers/gpu/drm/i915/gt/selftest_rps.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/i915/gt

[PATCH v2] drm/i915/selftests: Add delay to stabilize frequency in live_rps_power

2024-12-02 Thread Sk Anirban
Add delays to allow frequency stabilization before power measurement to fix sporadic power conservation issues in live_rps_power test. v2: - Move delay to respective function (Badal) Signed-off-by: Sk Anirban --- drivers/gpu/drm/i915/gt/selftest_rps.c | 1 + 1 file changed, 1 insertion

[PATCH v1] drm/i915/selftests: Improve RC6 power measurement and error handling

2025-02-11 Thread Sk Anirban
Improve RC6 power measurement and error handling. Add detailed error messages, and introduce a threshold check for RC6 residency. Signed-off-by: Sk Anirban --- drivers/gpu/drm/i915/gt/selftest_rc6.c | 61 +- 1 file changed, 40 insertions(+), 21 deletions(-) diff --git a

[PATCH 1/2] drm/i915/selftests: Correct frequency handling in RPS power measurement

2025-01-13 Thread Sk Anirban
Fix the frequency calculation by ensuring it uses the raw frequency only. Update live_rps_power test to use the correct frequency values for logging and comparison. Signed-off-by: Sk Anirban --- drivers/gpu/drm/i915/gt/selftest_rps.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH 0/2] drm/i915/selftests: Correct frequency handling in RPS power measurement

2025-01-13 Thread Sk Anirban
Add dedicated functions to measuring power in SLPC and for rps use read_cagf to use the raw frequency to measure power, ensuring more accurate and reliable power measurements. Sk Anirban (2): drm/i915/selftests: Correct frequency handling in RPS power measurement drm/i915/guc/slpc: Add

[PATCH 2/2] drm/i915/guc/slpc: Add helper function slpc_measure_power

2025-01-13 Thread Sk Anirban
Previously, the RPS function was being used, which utilizes raw frequency to calculate measured power. This commit introduces a dedicated function specifically for measuring power in SLPC, ensuring more accurate and reliable power measurements. Signed-off-by: Sk Anirban --- drivers/gpu/drm/i915

[PATCH v1] drm/i915/selftests: Correct frequency handling in RPS power measurement

2025-01-07 Thread sk . anirban
From: Sk Anirban Fix the frequency calculation by ensuring it is adjusted only once during power measurement. Update live_rps_power test to use the correct frequency values for logging and comparison. Signed-off-by: Sk Anirban --- drivers/gpu/drm/i915/gt/selftest_rps.c | 9 + 1 file

[PATCH v2] drm/i915/selftests: Correct frequency handling in RPS power measurement

2025-01-09 Thread sk . anirban
From: Sk Anirban Fix the frequency calculation by ensuring it is adjusted only once during power measurement. Update live_rps_power test to use the correct frequency values for logging and comparison. v2: - Improved frequency logging (Riana) Signed-off-by: Sk Anirban Reviewed-by: Riana

[PATCH v4] drm/i915/selftests: Refactor RC6 power measurement and error handling

2025-03-18 Thread sk . anirban
From: Sk Anirban Refactor power measurement logic to store and compare energy values. Previously, the code only checked whether the system had entered the RC6 state, without considering any potential interruptions in that state. This update introduces a threshold check to ensure that the GPU

[PATCH v5] drm/i915/selftests: Refactor RC6 power measurement and error handling

2025-03-19 Thread Sk Anirban
state properly during the specified sleep duration. v3: - Reorder threshold check (Badal) v4: - Improved commit message (Anshuman) v5: - Rename variables for improved readability (Anshuman) Signed-off-by: Sk Anirban --- drivers/gpu/drm/i915/gt/selftest_rc6.c | 51

[PATCH v5] drm/i915/selftests: Refactor RC6 power measurement and error handling

2025-03-27 Thread Sk Anirban
state properly during the specified sleep duration. v3: - Reorder threshold check (Badal) v4: - Improved commit message (Anshuman) v5: - Rename variables for improved readability (Anshuman) Signed-off-by: Sk Anirban Reviewed-by: Badal Nilawar --- drivers/gpu/drm/i915/gt/selftest_rc6.c

[PATCH] drm/i915/slpc: Avoid negative num_waiters to ensure correct waitboost behavior

2025-04-21 Thread sk . anirban
From: Sk Anirban In SLPC, the num_waiters atomic variable can become negative if a request retires without a proper frequency boost. This issue prevents the frequency boost from being triggered in subsequent boost iterations. This check stops the counter from going negative to ensures the

[PATCH v2] drm/i915/selftests: Refactor RC6 power measurement and error handling

2025-03-04 Thread sk . anirban
From: Sk Anirban Refactor power measurement logic to store and compare energy values. Introduce a threshold check to ensure the GPU enters RC6 properly. v2: - Improved commit message (Badal) Signed-off-by: Sk Anirban --- drivers/gpu/drm/i915/gt/selftest_rc6.c | 61

[PATCH v3] drm/i915/selftests: Refactor RC6 power measurement and error handling

2025-03-06 Thread sk . anirban
From: Sk Anirban Refactor power measurement logic to store and compare energy values. Introduce a threshold check to ensure the GPU enters RC6 properly. v2: - Improved commit message (Badal) v3: - Reorder threshold check (Badal) Signed-off-by: Sk Anirban --- drivers/gpu/drm/i915/gt

[v3] drm/i915: Disable RPG during live selftest

2025-03-11 Thread Sk Anirban
i Cc: Andrzej Hajda Signed-off-by: Badal Nilawar Signed-off-by: Sk Anirban --- drivers/gpu/drm/i915/gt/intel_rc6.c | 19 --- .../gpu/drm/i915/selftests/i915_selftest.c| 18 ++ 2 files changed, 22 insertions(+), 15 deletions(-) diff --git a/dri

[PATCH] drm/i915/selftests: Re-enable power gating after live_selftest

2025-02-20 Thread sk . anirban
From: Sk Anirban The current implementation of live_rc6_manual disables power gating after execution due to the deactivation of RC6. This update aims to re-enable power gating following the completion of the self-test. However, as a temporary workaround for forcewake timeouts, power gating will

[PATCH] drm/i915/selftests: Re-enable power gating after live_selftest

2025-02-19 Thread sk . anirban
From: Sk Anirban The current implementation of live_rc6_manual disables power gating after execution due to the deactivation of RC6. This update aims to re-enable power gating following the completion of the self-test. However, as a temporary workaround for forcewake timeouts, power gating will