Hey Lyude,
Looks good to me.
Reviewed-by: Robert Foss
On Fri, 26 Mar 2021 at 21:40, Lyude Paul wrote:
>
> Now that we've added a back-pointer to drm_device to drm_dp_aux, made
> drm_dp_aux available to any functions in drm_dp_helper.c which need to
> print to the kernel log
Hey Lyude,
This patch looks good, but I have one question below. With it
addressed, feel free to add my r-b.
Reviewed-by: Robert Foss
>
> -static bool drm_dp_sideband_parse_req(struct drm_dp_sideband_msg_rx *raw,
> +static bool drm_dp_sideband_parse_req(const struct drm_dp_mst_top
Hey Lyude,
I'm seeing no issues with this patch and the reasoning behind the
patch is sound to me.
Reviewed-by: Robert Foss
On Fri, 26 Mar 2021 at 21:39, Lyude Paul wrote:
>
> Since we're about to move drm_dp_helper.c over to drm_dbg_*(), we'll want
> to make s
Hey Lyude,
This patch looks good to me.
Reviewed-by: Robert Foss
On Fri, 26 Mar 2021 at 21:40, Lyude Paul wrote:
>
> Checkpatch was complaining about this - there's no need for us to print
> errors when kzalloc() fails, as kzalloc() will already WARN for us. So,
> let&
This is a reminder of this series.
On 2016-06-29 07:22 AM, robert.f...@collabora.com wrote:
From: Robert Foss
igt_crtc_prop_names and igt_atomic_crtc_properties have different orders of
properties, which is fixed in this patch.
Signed-off-by: Robert Foss
---
lib/igt_kms.c | 2 +-
1 file
From: Robert Foss
Test for libdrm_intel and build for it if present.
Also expose the HAVE_INTEL #define to allow code to be conditionally
compiled.
Signed-off-by: Robert Foss
Reviewed-by: Emil Velikov
---
configure.ac | 19 ++-
1 file changed, 18 insertions(+), 1 deletion
From: Robert Foss
Changes since v1:
- Replaced the automake flags HAVE_VC4/NOUVEAU/INTEL with HAVE_LIBDRM_XXX.
- Move conditionals from Makefile.sources to Arduino.mk/Makefile.am.
- Removed duplicated i915_drm.h symbols from intel_drm_stubs.h.
- Replaced igt_require with igt_require_f to
From: Robert Foss
Always set HAVE_LIBDRM_INTEL to true for Android targets.
Signed-off-by: Robert Foss
Reviewed-by: Emil Velikov
---
Android.mk | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Android.mk b/Android.mk
index 681d114..3690fc5 100644
--- a/Android.mk
+++ b/Android.mk
From: Robert Foss
Use the HAS_INTEL automake flag to avoid building benchmarks that won't
compile unless libdrm_intel is available in the build system.
Signed-off-by: Robert Foss
Reviewed-by: Emil Velikov
---
benchmarks/Android.mk | 4
benchmarks/Makefile.am
From: Robert Foss
Replace the automake flag HAVE_XXX for VC4/NOUVEAU with HAVE_LIBDRM_XXX in
order for the flags to be more descriptive and also follow the same convention
as HAVE_LIBDRM_INTEL.
Signed-off-by: Robert Foss
Reviewed-by: Emil Velikov
---
configure.ac | 8
lib
From: Robert Foss
Use the HAS_INTEL automake flag to avoid building tools that won't
compile unless libdrm_intel is available in the build system.
Signed-off-by: Robert Foss
Reviewed-by: Emil Velikov
---
tools/Android.mk | 5 +
tools/Makefile.am | 5 +
From: Robert Foss
Harmonize tabs/spaces etc.
Signed-off-by: Robert Foss
Reviewed-by: Emil Velikov
---
tools/Makefile.sources | 57 +-
1 file changed, 29 insertions(+), 28 deletions(-)
diff --git a/tools/Makefile.sources b/tools
From: Robert Foss
Replace the automake specific name of listings in Makefile.sources
with something not automake specific.
Signed-off-by: Robert Foss
Reviewed-by: Emil Velikov
---
demos/Android.mk | 2 +-
demos/Makefile.am | 2 ++
demos/Makefile.sources | 2 +-
3 files changed, 4
From: Robert Foss
This patch provides stubs for functionality otherwise provided by intel_bufmgr.
The stubbed functions all fail with a call to igt_require_f(false,"").
Defines and enums have been copied from libdrm_intel.
Due to the stubbed tests failing with an igt_require_f() c
From: Robert Foss
Replace the automake specific name of listings in Makefile.sources
with something not automake specific.
Signed-off-by: Robert Foss
Reviewed-by: Emil Velikov
---
benchmarks/Android.mk | 2 +-
benchmarks/Makefile.am | 2 ++
benchmarks/Makefile.sources | 2 +-
3
From: Robert Foss
Use the HAS_INTEL automake flag to avoid building tools that won't
compile unless libdrm_intel is available in the build system.
Signed-off-by: Robert Foss
Reviewed-by: Emil Velikov
---
demos/Android.mk | 5 -
demos/Makefile.am | 8 +---
From: Robert Foss
Replace the automake specific names of listings in Makefile.sources with
something not automake specific.
Signed-off-by: Robert Foss
Reviewed-by: Emil Velikov
---
tools/Android.mk | 1 +
tools/Makefile.am | 2 ++
tools/Makefile.sources | 2 +-
3 files changed, 4
From: Robert Foss
Replace the automake specific names of listings with something that isn't
automake specific.
Signed-off-by: Robert Foss
Reviewed-by: Emil Velikov
---
lib/tests/Android.mk | 2 +-
lib/tests/Makefile.am | 3 +++
lib/tests/Makefile.sources | 8
3
From: Robert Foss
Replace the automake specific variable names for listings in Makefile.sources
with something not automake specific.
Signed-off-by: Robert Foss
Reviewed-by: Emil Velikov
---
lib/Android.mk | 2 +-
lib/Makefile.am | 2 ++
lib/Makefile.sources | 2 +-
3 files
Hey Lyude,
Thanks for the patch.
On Fri, 19 Feb 2021 at 23:03, Lyude Paul wrote:
>
> Since this is one of the few functions in drm_dp_mst_topology.c that
> doesn't have any way of getting access to a drm_device, let's pass the
> drm_dp_mst_topology_mgr down to this function so that it can use
>
Hey Lyude,
Thanks for the patch, it looks good to me.
Reviewed-by: Robert Foss
On Fri, 19 Feb 2021 at 22:58, Lyude Paul wrote:
>
> Another drive-by fix I found when fixing DP AUX adapter across the kernel
> tree - make sure we don't leak resources (and by proxy-AUX adapters) on
Hey Lyude,
Thanks for the patch.
On Fri, 19 Feb 2021 at 23:03, Lyude Paul wrote:
>
> Now that we've added a back-pointer to drm_device to drm_dp_aux, made
> drm_dp_aux available to any functions in drm_dp_helper.c which need to
> print to the kernel log, and ensured all of our logging uses a con
Hey Lyude,
This patch looks good to me.
Reviewed-by: Robert Foss
On Fri, 19 Feb 2021 at 22:56, Lyude Paul wrote:
>
> Since this is a bridge, we don't start out with a respective DRM device.
> Likewise this means we don't have a connector, which also means that we
&g
Hey Lyude,
Thanks for the patch, it looks good to me.
Reviewed-by: Robert Foss
On Fri, 19 Feb 2021 at 22:56, Lyude Paul wrote:
>
> Since encoder mappings for connectors are exposed to userspace, we should
> be attaching the encoder before exposing the connector to userspace. Just a
&
Hey Lyude,
Thanks for the patch, it looks good to me.
Reviewed-by: Robert Foss
On Fri, 19 Feb 2021 at 22:56, Lyude Paul wrote:
>
> Just another issue I noticed while correcting usages of
> drm_dp_aux_init()/drm_dp_aux_register() around the tree. If any of the
> steps in anx78xx_b
Hey Lyude,
Thanks for the patch, it looks good to me.
Reviewed-by: Robert Foss
On Fri, 19 Feb 2021 at 22:58, Lyude Paul wrote:
>
> Another case of linking an encoder to a connector after the connector's
> been registered. The proper place to do this is before connector
>
Hey Lyude,
Thanks for the patch,
On Fri, 19 Feb 2021 at 22:59, Lyude Paul wrote:
>
> Since we're about to move drm_dp_helper.c over to drm_dbg_*(), we'll want
> to make sure that we can also add ratelimited versions of these macros in
> order to retain some of the previous debugging output behav
Hey Lyude,
Thanks for the patch, it looks good to me.
Reviewed-by: Robert Foss
On Fri, 19 Feb 2021 at 22:58, Lyude Paul wrote:
>
> Another driver I found that seems to forget to unregister it's DP AUX
> device. Let's fix this by adding anx6345_bridge_detach().
>
>
Hey Lyude,
Thanks for the patch, it looks good to me.
Reviewed-by: Robert Foss
On Fri, 19 Feb 2021 at 22:58, Lyude Paul wrote:
>
> Just another drive-by fix I noticed while going through the tree to cleanup
> DP aux adapter registration - make sure we unregister the DP A
Hey Lyude,
Thanks for the patch, it looks good to me.
Reviewed-by: Robert Foss
On Fri, 19 Feb 2021 at 22:56, Lyude Paul wrote:
>
> Surprisingly, this bridge actually registers it's AUX adapter at the
> correct time already. Nice job! However, it does forget to actually
> u
Hey Lyude,
Thanks for the patch
On Fri, 19 Feb 2021 at 23:03, Lyude Paul wrote:
>
> And finally, convert all of the code in drm_dp_mst_topology.c over to using
> drm_err() and drm_dbg*(). Note that this refactor would have been a lot
> more complicated to have tried writing a coccinelle script f
From: Robert Foss
Add subtest test_sync_merge that tests merging fences and the validity of the
resulting merged fence.
Signed-off-by: Robert Foss
---
tests/sw_sync.c | 67 +
1 file changed, 67 insertions(+)
diff --git a/tests/sw_sync.c
From: Robert Foss
This subtest verifies that merging two fences works in the simples possible
case.
Signed-off-by: Robert Foss
---
tests/sw_sync.c | 23 +++
1 file changed, 23 insertions(+)
diff --git a/tests/sw_sync.c b/tests/sw_sync.c
index 102647d..851430e 100644
--- a
From: Robert Foss
This subtest verifies merging a fence with itself does not fail.
Signed-off-by: Robert Foss
---
tests/sw_sync.c | 27 +++
1 file changed, 27 insertions(+)
diff --git a/tests/sw_sync.c b/tests/sw_sync.c
index 00ac44b..db03f48 100644
--- a/tests
From: Robert Foss
Add subtest alloc_fence that verifies that it's possible to allocate a fence
on a timeline.
Signed-off-by: Robert Foss
---
tests/sw_sync.c | 16
1 file changed, 16 insertions(+)
diff --git a/tests/sw_sync.c b/tests/sw_sync.c
index d2d4c42..a8c8ca4 1
From: Robert Foss
Base functions to help testing the Sync File Framework (explicit fencing
mechanism ported from Android).
These functions allow you to create, use and destroy timelines and fences.
Signed-off-by: Gustavo Padovan
Signed-off-by: Robert Foss
---
lib/Makefile.sources | 2
From: Robert Foss
This subtest verifies that waiting on fences works properly.
Signed-off-by: Robert Foss
---
tests/sw_sync.c | 38 ++
1 file changed, 38 insertions(+)
diff --git a/tests/sw_sync.c b/tests/sw_sync.c
index 851430e..07e9638 100644
--- a/tests
From: Robert Foss
This subtests tests that creating fences on negative timelines fail.
Signed-off-by: Robert Foss
---
tests/sw_sync.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/tests/sw_sync.c b/tests/sw_sync.c
index a8c8ca4..102647d 100644
--- a/tests/sw_sync.c
+++ b/tests
From: Robert Foss
Add initial tests for sw_sync.
Signed-off-by: Gustavo Padovan
Signed-off-by: Robert Foss
---
lib/sw_sync.c | 13 ++---
lib/sw_sync.h | 2 +-
tests/Makefile.sources | 1 +
tests/sw_sync.c| 51
From: Robert Foss
This series implements the sw_sync test and the lib/sw_sync helper functions
for said test.
Gustavo Padovans sw_sync series was just de-staged in
gregkh-staging/staging-next [1], and this test is targeted at verifying the
functionality implemented in that series.
The sw_sync
From: Robert Foss
This subtest verifies that creating many timelines and merging random fences
from each timeline with eachother results in merged fences that are fully
functional.
Signed-off-by: Robert Foss
---
tests/sw_sync.c | 73 +
1
From: Robert Foss
This subtest runs a single consumer thread and multiple producer thread that
are synchronized using multiple timelines.
Signed-off-by: Robert Foss
---
tests/sw_sync.c | 139
1 file changed, 139 insertions(+)
diff
From: Robert Foss
This subtest verifies that waiting, timing out on a wait and that counting
fences in various states works.
Signed-off-by: Robert Foss
---
tests/sw_sync.c | 66 +
1 file changed, 66 insertions(+)
diff --git a/tests
From: Robert Foss
This subtest verifies the access ordering of multiple consumer threads.
Signed-off-by: Robert Foss
---
tests/sw_sync.c | 103
1 file changed, 103 insertions(+)
diff --git a/tests/sw_sync.c b/tests/sw_sync.c
index
From: Robert Foss
This test verifies that stressing the kernel by creating multiple
consumer/producer threads that wait on a single timeline to be incremented
by another conumer/producer thread does not fail.
And that the order amongst the threads is maintained.
Signed-off-by: Robert Foss
From: Robert Foss
Base functions to help testing the Sync File Framework (explicit fencing
mechanism ported from Android).
These functions allow you to create, use and destroy timelines and fences.
Signed-off-by: Gustavo Padovan
Signed-off-by: Robert Foss
---
lib/Makefile.sources | 2
From: Robert Foss
This series implements the sw_sync test and the lib/sw_sync helper functions
for said test.
Gustavo Padovans sw_sync series was just de-staged in
gregkh-staging/staging-next [1], and this test is targeted at verifying the
functionality implemented in that series.
The sw_sync
From: Robert Foss
Add subtest alloc_fence that verifies that it's possible to allocate a fence
on a timeline.
Signed-off-by: Robert Foss
---
tests/sw_sync.c | 16
1 file changed, 16 insertions(+)
diff --git a/tests/sw_sync.c b/tests/sw_sync.c
index d2d4c42..a8c8ca4 1
From: Robert Foss
Add subtest test_sync_merge that tests merging fences and the validity of the
resulting merged fence.
Signed-off-by: Robert Foss
---
tests/sw_sync.c | 67 +
1 file changed, 67 insertions(+)
diff --git a/tests/sw_sync.c
From: Robert Foss
This subtest verifies merging a fence with itself does not fail.
Signed-off-by: Robert Foss
---
tests/sw_sync.c | 27 +++
1 file changed, 27 insertions(+)
diff --git a/tests/sw_sync.c b/tests/sw_sync.c
index 00ac44b..db03f48 100644
--- a/tests
From: Robert Foss
This subtests tests that creating fences on negative timelines fail.
Signed-off-by: Robert Foss
---
tests/sw_sync.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/tests/sw_sync.c b/tests/sw_sync.c
index a8c8ca4..102647d 100644
--- a/tests/sw_sync.c
+++ b/tests
From: Robert Foss
This subtest verifies that waiting, timing out on a wait and that counting
fences in various states works.
Signed-off-by: Robert Foss
---
tests/sw_sync.c | 66 +
1 file changed, 66 insertions(+)
diff --git a/tests
From: Robert Foss
This subtest verifies that creating many timelines and merging random fences
from each timeline with eachother results in merged fences that are fully
functional.
Signed-off-by: Robert Foss
---
tests/sw_sync.c | 73 +
1
From: Robert Foss
Add initial tests for sw_sync.
Signed-off-by: Gustavo Padovan
Signed-off-by: Robert Foss
---
lib/sw_sync.c | 13 ++---
lib/sw_sync.h | 2 +-
tests/Makefile.sources | 1 +
tests/sw_sync.c| 51
From: Robert Foss
This subtest verifies that merging two fences works in the simples possible
case.
Signed-off-by: Robert Foss
---
tests/sw_sync.c | 23 +++
1 file changed, 23 insertions(+)
diff --git a/tests/sw_sync.c b/tests/sw_sync.c
index 102647d..851430e 100644
--- a
From: Robert Foss
This test verifies that stressing the kernel by creating multiple
consumer/producer threads that wait on a single timeline to be incremented
by another conumer/producer thread does not fail.
And that the order amongst the threads is maintained.
Signed-off-by: Robert Foss
From: Robert Foss
This subtest runs a single consumer thread and multiple producer thread that
are synchronized using multiple timelines.
Signed-off-by: Robert Foss
---
tests/sw_sync.c | 139
1 file changed, 139 insertions(+)
diff
From: Robert Foss
This subtest verifies the access ordering of multiple consumer threads.
Signed-off-by: Robert Foss
---
tests/sw_sync.c | 103
1 file changed, 103 insertions(+)
diff --git a/tests/sw_sync.c b/tests/sw_sync.c
index
From: Robert Foss
This subtest verifies that waiting on fences works properly.
Signed-off-by: Robert Foss
---
tests/sw_sync.c | 38 ++
1 file changed, 38 insertions(+)
diff --git a/tests/sw_sync.c b/tests/sw_sync.c
index 851430e..07e9638 100644
--- a/tests
On 2016-08-24 02:01 AM, Daniel Vetter wrote:
On Tue, Aug 23, 2016 at 01:56:02PM -0400, robert.f...@collabora.com wrote:
From: Robert Foss
This series implements the sw_sync test and the lib/sw_sync helper functions
for said test.
Gustavo Padovans sw_sync series was just de-staged in
gregkh
On 2016-08-23 06:56 PM, Eric Engestrom wrote:
On Tue, Aug 23, 2016 at 01:56:02PM -0400, robert.f...@collabora.com wrote:
From: Robert Foss
This series implements the sw_sync test and the lib/sw_sync helper functions
for said test.
Gustavo Padovans sw_sync series was just de-staged in
From: Robert Foss
Base functions to help testing the Sync File Framework (explicit fencing
mechanism ported from Android).
These functions allow you to create, use and destroy timelines and fences.
Signed-off-by: Gustavo Padovan
Signed-off-by: Robert Foss
Reviewed-by: Eric Engestrom
---
lib
From: Robert Foss
Add subtest alloc_fence that verifies that it's possible to allocate a fence
on a timeline.
Signed-off-by: Robert Foss
Reviewed-by: Eric Engestrom
---
tests/sw_sync.c | 16
1 file changed, 16 insertions(+), 0 deletions(-)
diff --git a/tests/sw_syn
From: Robert Foss
This series implements the sw_sync test and the lib/sw_sync helper functions
for said test.
Gustavo Padovans sw_sync series was just de-staged in
gregkh-staging/staging-next [1], and this test is targeted at verifying the
functionality implemented in that series.
The sw_sync
From: Robert Foss
Add initial tests for sw_sync.
Signed-off-by: Robert Foss
Signed-off-by: Gustavo Padovan
Reviewed-by: Eric Engestrom
---
tests/Makefile.sources | 1 +-
tests/sw_sync.c| 51 +++-
2 files changed, 52 insertions(+), 0 deletions
From: Robert Foss
Add subtest test_sync_merge that tests merging fences and the validity of the
resulting merged fence.
Signed-off-by: Robert Foss
Reviewed-by: Eric Engestrom
---
tests/sw_sync.c | 67 ++-
1 file changed, 67 insertions(+), 0
From: Robert Foss
This subtest verifies merging a fence with itself does not fail.
Signed-off-by: Robert Foss
Reviewed-by: Eric Engestrom
---
tests/sw_sync.c | 27 +++
1 file changed, 27 insertions(+), 0 deletions(-)
diff --git a/tests/sw_sync.c b/tests/sw_sync.c
From: Robert Foss
This subtest verifies that waiting on fences works properly.
Signed-off-by: Robert Foss
Reviewed-by: Eric Engestrom
---
tests/sw_sync.c | 38 ++
1 file changed, 38 insertions(+), 0 deletions(-)
diff --git a/tests/sw_sync.c b/tests
From: Robert Foss
This subtests tests that creating fences on negative timelines fail.
Signed-off-by: Robert Foss
Reviewed-by: Eric Engestrom
---
tests/sw_sync.c | 7 +++
1 file changed, 7 insertions(+), 0 deletions(-)
diff --git a/tests/sw_sync.c b/tests/sw_sync.c
index a8c8ca4
From: Robert Foss
This subtest runs a single consumer thread and multiple producer thread that
are synchronized using multiple timelines.
Signed-off-by: Robert Foss
Reviewed-by: Eric Engestrom
---
tests/sw_sync.c | 139 +-
1 file changed, 139
From: Robert Foss
This subtest verifies that creating many timelines and merging random fences
from each timeline with eachother results in merged fences that are fully
functional.
Signed-off-by: Robert Foss
Reviewed-by: Eric Engestrom
---
tests/sw_sync.c | 73
From: Robert Foss
This subtest verifies that merging two fences works in the simples possible
case.
Signed-off-by: Robert Foss
Reviewed-by: Eric Engestrom
---
tests/sw_sync.c | 23 +++
1 file changed, 23 insertions(+), 0 deletions(-)
diff --git a/tests/sw_sync.c b/tests
From: Robert Foss
This test verifies that stressing the kernel by creating multiple
consumer/producer threads that wait on a single timeline to be incremented
by another conumer/producer thread does not fail.
And that the order amongst the threads is maintained.
Signed-off-by: Robert Foss
From: Robert Foss
This subtest verifies that waiting, timing out on a wait and that counting
fences in various states works.
Signed-off-by: Robert Foss
Reviewed-by: Eric Engestrom
---
tests/sw_sync.c | 66 ++-
1 file changed, 66 insertions
From: Robert Foss
This subtest verifies the access ordering of multiple consumer threads.
Signed-off-by: Robert Foss
Reviewed-by: Eric Engestrom
---
tests/sw_sync.c | 103 +-
1 file changed, 103 insertions(+), 0 deletions(-)
diff --git a/tests
Thanks for catching this Marius.
Reviewed-by Robert Foss
Rob.
On 2016-09-07 05:59 AM, Marius Vlad wrote:
Introduced with commit cd86866dec.
Signed-off-by: Marius Vlad
CC: Robert Foss
---
demos/Makefile.sources | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/demos
A cursor plane may not always be available. Since there
already exist variables that signal the existance or
non-existance of cursor planes like pipe->plane_cursor and
display->has_cursor_plane, allow the pipes that have no
cursor plane.
Signed-off-by: Robert Foss
---
lib/igt_kms.
On 2016-05-24 04:07 AM, Daniel Vetter wrote:
On Fri, May 20, 2016 at 06:59:32PM -0400, robert.f...@collabora.com wrote:
From: Robert Foss
Replace intel specific header includes with intel_drm_stubs.h.
The stubbed functions will all call igt_require(false) and cause a skip.
Signed-off-by
From: Robert Foss
Test for libdrm_intel and build for it if present.
Also expose the HAVE_INTEL #define to allow code to be conditionally
compiled.
Signed-off-by: Robert Foss
---
configure.ac | 14 +-
1 file changed, 13 insertions(+), 1 deletion(-)
diff --git a/configure.ac b
From: Robert Foss
Changes since v1:
- Replaced the automake flags HAVE_VC4/NOUVEAU/INTEL with HAVE_LIBDRM_XXX.
- Move conditionals from Makefile.sources to Arduino.mk/Makefile.am.
- Removed duplicated i915_drm.h symbols from intel_drm_stubs.h.
- Replaced igt_require with igt_require_f to
From: Robert Foss
Replace the automake flag HAVE_XXX for VC4/NOUVEAU with HAVE_LIBDRM_XXX in
order for the flags to be more descriptive and also follow the same convention
as HAVE_LIBDRM_INTEL.
---
configure.ac | 8
lib/Makefile.am | 2 +-
tests/Makefile.am | 4 ++--
3 files
From: Robert Foss
Use the HAS_INTEL automake flag to avoid building tools that won't
compile unless libdrm_intel is available in the build system.
Signed-off-by: Robert Foss
---
tools/Android.mk | 8
tools/Makefile.am | 8
tools/Makefile.sources
From: Robert Foss
This patch provides stubs for functionality otherwise provided by intel_bufmgr.
The stubbed functions all fail with a call to igt_require_f(false,"").
Defines and enums have been copied from libdrm_intel.
Due to the stubbed tests failing with an igt_require_f() c
From: Robert Foss
Harmonize tabs/spaces etc.
Signed-off-by: Robert Foss
---
tools/Makefile.sources | 57 +-
1 file changed, 29 insertions(+), 28 deletions(-)
diff --git a/tools/Makefile.sources b/tools/Makefile.sources
index 07d8d9b..7ed5fe5
From: Robert Foss
Use the HAS_INTEL automake flag to avoid building tools that won't
compile unless libdrm_intel is available in the build system.
Signed-off-by: Robert Foss
---
demos/Android.mk | 5 -
demos/Makefile.am | 8 +---
demos/Makefile.sources | 7 +++
3
From: Robert Foss
Use the HAS_INTEL automake flag to avoid building benchmarks that won't
compile unless libdrm_intel is available in the build system.
Signed-off-by: Robert Foss
---
benchmarks/Android.mk | 6 ++
benchmarks/Makefile.am | 5 -
benchmarks/Makefile.so
From: Robert Foss
Add support for configure flag --disable-pciaccess and the associated
automake define HAVE_PCIACCESS.
Signed-off-by: Robert Foss
---
configure.ac | 13 -
1 file changed, 12 insertions(+), 1 deletion(-)
diff --git a/configure.ac b/configure.ac
index 11b1d46
From: Robert Foss
Don't try to build overlay if libpciaccess is unavailable.
This is useful for platforms that typically don't have pci hardware,
like ARM platforms.
Robert Foss (2):
configure.ac: Add support for configure flag --disable-pciaccess.
overlay/Makefile: Don'
From: Robert Foss
Don't try to build overlay if libpciaccess is unavailable.
This is useful for platforms that typically don't have pci hardware, like ARM
platforms.
Signed-off-by: Robert Foss
---
overlay/Makefile.am | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
di
Forward to ML.
On 2016-05-25 03:55 PM, Emil Velikov wrote:
On Wednesday, May 25, 2016 19:18 BST, robert.f...@collabora.com wrote:
From: Robert Foss
Use the HAS_INTEL automake flag to avoid building benchmarks that won't
compile unless libdrm_intel is available in the build system.
S
On Wednesday, May 25, 2016 19:18 BST, robert.f...@collabora.com wrote:
From: Robert Foss
Use the HAS_INTEL automake flag to avoid building tools that won't
compile unless libdrm_intel is available in the build system.
Signed-off-by: Robert Foss
---
demos/Android.mk
On Wednesday, May 25, 2016 19:18 BST, robert.f...@collabora.com wrote:
From: Robert Foss
Harmonize tabs/spaces etc.
Signed-off-by: Robert Foss
---
tools/Makefile.sources | 57 +-
1 file changed, 29 insertions(+), 28 deletions(-)
diff --git a
From: Robert Foss
Use the HAS_INTEL automake flag to avoid building tools that won't
compile unless libdrm_intel is available in the build system.
Signed-off-by: Robert Foss
---
tools/Android.mk | 8
tools/Makefile.am | 8
tools/Makefile.sources
Forward to ML.
On Wed, May 25, 2016 at 02:43:59PM -0400, robert.f...@collabora.com wrote:
From: Robert Foss
Don't try to build overlay if libpciaccess is unavailable.
This is useful for platforms that typically don't have pci hardware, like ARM
platforms.
Ok, I should be able t
Forward to ML.
On Wednesday, May 25, 2016 19:18 BST, robert.f...@collabora.com wrote:
From: Robert Foss
This patch provides stubs for functionality otherwise provided by intel_bufmgr.
The stubbed functions all fail with a call to igt_require_f(false,"").
Defines and enums have b
Forward to ML.
On Wednesday, May 25, 2016 19:18 BST, robert.f...@collabora.com wrote:
+if test "x$INTEL" = xyes; then
+ PKG_CHECK_MODULES(DRM_INTEL, [libdrm_intel >= 2.4.64])
+ AC_DEFINE(HAVE_LIBDRM_INTEL, 1, [Have intel support])
+fi
+AM_CONDITIONAL(HAVE_LIBDRM_INTEL, [test "x$INTE
Forward to ML.
On Wednesday, May 25, 2016 21:04 BST, Robert Foss
wrote:
> And this is why ladies and gentlemen you don't align on the \ character. As
one adds a test/file with long name, you'll need to re-indent the whole lot. Then
again... people like these, for wh
Verified working on rpi2.
Tested-by: Robert Foss
On 2016-05-31 05:25 PM, Chris Wilson wrote:
Since the introduction of (struct_mutex) lockless GEM bo freeing, there
are a pair of driver vfuncs for freeing the GEM bo, of which the driver
may choose to only implement driver
On 2016-05-25 03:55 PM, Emil Velikov wrote:
On Wednesday, May 25, 2016 19:18 BST, robert.f...@collabora.com wrote:
From: Robert Foss
Use the HAS_INTEL automake flag to avoid building benchmarks that won't
compile unless libdrm_intel is available in the build system.
Signed-off-by: R
From: Robert Foss
Always set HAVE_LIBDRM_INTEL to true for Android targets.
---
Android.mk | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Android.mk b/Android.mk
index 681d114..3690fc5 100644
--- a/Android.mk
+++ b/Android.mk
@@ -1,2 +1,4 @@
+HAVE_LIBDRM_INTEL := true
+
include $(call
1 - 100 of 703 matches
Mail list logo
