Re: [Intel-gfx] [PATCH 5/8] drm/tilcdc: Drop drm_gem_fb_create wrapper

On 15/11/2019 11:21, Daniel Vetter wrote: > Doesn't do anything. > > Signed-off-by: Daniel Vetter > Cc: Jyri Sarha > Cc: Tomi Valkeinen Acked-by: Jyri Sarha > --- > drivers/gpu/drm/tilcdc/tilcdc_drv.c | 8 +--- > 1 file changed, 1 insertion(+), 7 deletions

Re: [Intel-gfx] [PATCH 29/44] drm/tidss: Delete tidss->saved_state

On 03/04/2020 16:58, Daniel Vetter wrote: > Not used anymore since the switch to suspend/resume helpers. > > Signed-off-by: Daniel Vetter > Cc: Jyri Sarha > Cc: Tomi Valkeinen Tested-by: Jyri Sarha > --- > drivers/gpu/drm/tidss/tidss_drv.h | 2 -- > 1 file changed,

Re: [Intel-gfx] [PATCH 27/44] drm/tidss: Use devm_drm_dev_alloc

On 03/04/2020 16:58, Daniel Vetter wrote: > Already using devm_drm_dev_init, so very simple replacment. > > Signed-off-by: Daniel Vetter > Cc: Jyri Sarha > Cc: Tomi Valkeinen Tested-by: Jyri Sarha > --- > drivers/gpu/drm/tidss/tidss_drv.c | 15 ---

Re: [Intel-gfx] [PATCH 28/44] drm/tidss: Don't use drm_device->dev_private

On 03/04/2020 16:58, Daniel Vetter wrote: > Upcasting using a container_of macro is more typesafe, faster and > easier for the compiler to optimize. > > Signed-off-by: Daniel Vetter > Cc: Jyri Sarha > Cc: Tomi Valkeinen Tested-by: Jyri Sarha > --- > drivers/gpu/drm/

Re: [Intel-gfx] [PATCH 12/13] drm/tilcdc: Provide ddc symlink in connector sysfs directory

On 31/07/2019 19:58, Andrzej Pietrasiewicz wrote: > Use the ddc pointer provided by the generic connector. > > Signed-off-by: Andrzej Pietrasiewicz > Acked-by: Sam Ravnborg > Reviewed-by: Emil Velikov Acked-by: Jyri Sarha > --- > drivers/gpu/drm/tilcdc/tilcdc_tfp410.c

Re: [Intel-gfx] [PATCH 14/25] drm/tidss: Annotate dma-fence critical section in commit path

On 07/07/2020 23:12, Daniel Vetter wrote: > Ends right after hw_done(), totally standard case. > > Signed-off-by: Daniel Vetter > Cc: Jyri Sarha > Cc: Tomi Valkeinen Acked-by: Jyri Sarha > --- > drivers/gpu/drm/tidss/tidss_kms.c | 4 > 1 file changed, 4 inserti

Re: [Intel-gfx] [PATCH] drm/tilcdc: Use standard drm_atomic_helper_commit

t but it does not finish and nothing comes visible on the screen until couple of "flip_done timed outs". A new kernel log is attached. Best regards, Jyri > Signed-off-by: Daniel Vetter > Cc: Jyri Sarha > Cc: Tomi Valkeinen > -- > I'm not really sure whether the

Re: [Intel-gfx] [PATCH 15/25] drm/tilcdc: Use standard drm_atomic_helper_commit

andling also seems to exist (albeit with much hand-rolling and > probably some races, could perhaps be converted over to > drm_crtc_arm_vblank_event without any real loss). > > Motivated by me not having to hand-roll the dma-fence annotations for > this. > > Signed-off-by: D

Re: [Intel-gfx] [PATCH] drm/tilcdc: Use standard drm_atomic_helper_commit

le display helpers would work out really > nice. > Probably. Should take a closer looks some day when I have time. > Signed-off-by: Daniel Vetter > Cc: Jyri Sarha > Cc: Tomi Valkeinen Tested-by: Jyri Sarha Reviewed-by: Jyri Sarha > -- > From logs looks like we

Re: [Intel-gfx] [PATCH 11/51] drm/tidss: Use drmm_add_final_kfree

On 21/02/2020 23:02, Daniel Vetter wrote: > With this we can drop the final kfree from the release function. > > Signed-off-by: Daniel Vetter > Cc: Jyri Sarha > Cc: Tomi Valkeinen Acked-by: Jyri Sarha > --- > drivers/gpu/drm/tidss/tidss_drv.c | 4 ++-- > 1 file cha

Re: [Intel-gfx] [PATCH 41/51] drm/tidss: Drop explicit drm_mode_config_cleanup call

_ versions for all the drm objects (planes, crtc, ...), so that > the cleanup actually happens before even drmm_kzalloc would release > the underlying memory. Not quite there yet. > > v2: Explain why this cleanup is possible (Laurent). > > Cc: Laurent Pinchart > S

Re: [Intel-gfx] [PATCH v2 9/9] drm/tilcdc: Use drm_connector_has_possible_encoder()

ssible_encoder() call > > Cc: Jyri Sarha > Cc: Tomi Valkeinen > Signed-off-by: Ville Syrjälä Acked-by: Jyri Sarha I guess you are going to merge these at one go trough drm-misc. > --- > drivers/gpu/drm/tilcdc/tilcdc_external.c | 9 - > 1 file changed, 4 inser

Re: [Intel-gfx] [PATCH v2 09/12] drm/tilcdc: Handle drm_atomic_helper_swap_state failure

On 07/11/17 17:33, Maarten Lankhorst wrote: > drm_atomic_helper_swap_state() will be changed to interruptible waiting > in the next few commits, so all drivers have to be changed to handling > failure. > > Signed-off-by: Maarten Lankhorst > Cc: Jyri Sarha > Cc: Tomi

Re: [Intel-gfx] [PATCH 1/8] drm: Add optional COLOR_ENCODING and COLOR_RANGE properties to drm_plane

On 19/02/18 22:19, Ville Syrjälä wrote: >>> +int drm_plane_create_color_properties(struct drm_plane *plane, >>> + u32 supported_encodings, >>> + u32 supported_ranges, >> Is 0 in the above two supported_ masks a valid value? If yes, sho

Re: [Intel-gfx] [PATCH 08/19] drm/tilcdc: Drop calls to modeset_lock_crtc

On 03/22/17 23:50, Daniel Vetter wrote: > Again this is an internal helper, not the official way to lock a crtc. > > Cc: Jyri Sarha > Cc: Tomi Valkeinen > Signed-off-by: Daniel Vetter Acked-by: Jyri Sarha > --- > drivers/gpu/drm/tilcdc/tilcdc_crtc.c | 12 ++--

Re: [PATCH 9/9] drm/tilcdc: Use backlight power constants

o > change in functionality or semantics. > > Signed-off-by: Thomas Zimmermann > Cc: Jyri Sarha > Cc: Tomi Valkeinen > --- Acked-by: Jyri Sarha Thank, Jyri > drivers/gpu/drm/tilcdc/tilcdc_panel.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff -

Re: [PATCH v3 43/81] drm/tilcdc: Run DRM default client setup

t drm_driver, so that > the client setup can start the common fbdev client. > > v3: > - add DRM_FBDEV_DMA_DRIVER_OPS macro > > Signed-off-by: Thomas Zimmermann > Cc: Jyri Sarha > Cc: Tomi Valkeinen Acked-by: Jyri Sarha Thanks, Jyri > --- > drivers/gpu/drm/tilcdc/ti

Re: [PATCH v4 42/80] drm/tilcdc: Run DRM default client setup

t drm_driver, so that > the client setup can start the common fbdev client. > > v3: > - add DRM_FBDEV_DMA_DRIVER_OPS macro > > Signed-off-by: Thomas Zimmermann > Cc: Jyri Sarha > Cc: Tomi Valkeinen > Acked-by: Javier Martinez Canillas > tilcdc patch looks id

Re: [PATCH v5 42/80] drm/tilcdc: Run DRM default client setup

t drm_driver, so that > the client setup can start the common fbdev client. > > v5: > - select DRM_CLIENT_SELECTION > v3: > - add DRM_FBDEV_DMA_DRIVER_OPS macro > > Signed-off-by: Thomas Zimmermann > Cc: Jyri Sarha > Cc: Tomi Valkeinen > Acked-by: Javier Martinez