Re: [Intel-gfx] [-next PATCH 2/4] treewide: Use DEVICE_ATTR_RW

2017-12-20 Thread Zhang Rui
  |  2 +- >  drivers/gpu/drm/i915/i915_sysfs.c|  6 ++--- >  drivers/platform/x86/compal-laptop.c | 18 +-- >  drivers/s390/cio/device.c|  2 +- >  drivers/scsi/lpfc/lpfc_attr.c| 43 > >  drivers/thermal

Re: [Intel-gfx] [-next PATCH 3/4] treewide: Use DEVICE_ATTR_RO

2017-12-20 Thread Zhang Rui
ers/scsi/hpsa.c  | 10 +- >  drivers/scsi/lpfc/lpfc_attr.c| 18 > -- >  drivers/staging/media/atomisp/pci/atomisp2/hmm/hmm.c |  8 >  drivers/thermal/thermal_sysfs.c   

Re: [Intel-gfx] [PATCH v1] ACPI: Switch to use generic UUID API

2017-05-09 Thread Zhang Rui
t; Cc: Amir Goldstein > Cc: Jarkko Sakkinen > Cc: Jani Nikula > Cc: Ben Skeggs > Cc: Benjamin Tissoires > Cc: Joerg Roedel > Cc: Adrian Hunter > Cc: Yisen Zhuang > Cc: Bjorn Helgaas > Cc: Zhang Rui > Cc: Felipe Balbi > Cc: Mathias Nyman > Cc: Heikki Kroger

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for x86/topology: fix erroneous smp_num_siblings on Intel Hybrid platform

2023-03-27 Thread Zhang, Rui
Hi, Imre, Thanks for raising this. On Tue, 2023-03-28 at 00:26 +0300, Imre Deak wrote: > Hi Rui, > > after applying your > "x86/topology: fix erroneous smp_num_siblings on Intel Hybrid > platform" > > fix on the drm-tip tree (see the patchwork URL below) the CI tests > show > some regression on

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for x86/topology: fix erroneous smp_num_siblings on Intel Hybrid platform

2023-03-27 Thread Zhang, Rui
On Tue, 2023-03-28 at 09:14 +0800, Zhang Rui wrote: > Hi, Imre, > > Thanks for raising this. > > On Tue, 2023-03-28 at 00:26 +0300, Imre Deak wrote: > > Hi Rui, > > > > after applying your > > "x86/topology: fix erroneous smp_num_siblings on Intel

Re: [Intel-gfx] [RFC PATCH 3/3] i915: ignore lid open event when resuming

2013-02-03 Thread Zhang Rui
On Tue, 2013-01-29 at 11:10 +0100, Daniel Vetter wrote: > On Mon, Jan 28, 2013 at 06:06:38PM +0800, Zhang Rui wrote: > > On Mon, 2013-01-28 at 09:31 +0100, Daniel Vetter wrote: > > > On Mon, Jan 28, 2013 at 3:36 AM, Zhang Rui wrote: > > > >> Given that this essen

[Intel-gfx] [PATCH V2 1/3] PM: Introduce suspend state PM_SUSPEND_FREEZE

2013-02-03 Thread Zhang Rui
s than 0.2s 2. Freeze: (From pressing power button to screen back) 2.50s 3. Suspend to Memory: (From pressing power button to screen back) 4.33s >From the results, we can see that all the platforms should benefit from this patch, even if it does not have Low Power S0. Signed-o

[Intel-gfx] [PATCH V2 2/3] ACPI: enable ACPI SCI during suspend

2013-02-03 Thread Zhang Rui
til arch_suspend_irq_disable() is run. Signed-off-by: Zhang Rui --- drivers/acpi/osl.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/acpi/osl.c b/drivers/acpi/osl.c index 3ff2678..3adeb10 100644 --- a/drivers/acpi/osl.c +++ b/drivers/acpi/osl.c @@ -787,7 +78

[Intel-gfx] [PATCH V2 3/3] i915: ignore lid open event when resuming

2013-02-03 Thread Zhang Rui
_DONE is set so that duplicate lid open events will be ignored. 3. when system suspends, MODESET_ON_RESUME is set. In this case, we will not do modeset on any lid events. Plus, locking mechanism is also introduced to avoid racing. Signed-off-by: Zhang Rui --- drivers/gpu/drm/i915/i915_

Re: [Intel-gfx] [PATCH V2 3/3] i915: ignore lid open event when resuming

2013-02-04 Thread Zhang Rui
On Mon, 2013-02-04 at 16:25 +0100, Daniel Vetter wrote: > On Mon, Feb 04, 2013 at 03:10:11PM +0800, Zhang Rui wrote: > > i915 driver needs to do modeset when > > 1. system resumes from sleep > > 2. lid is opened > > > > In PM_SUSPEND_MEM state, all the GPE

Re: [Intel-gfx] [PATCH V2 3/3] i915: ignore lid open event when resuming

2013-02-05 Thread Zhang Rui
On Tue, 2013-02-05 at 07:58 +0800, Zhang Rui wrote: > On Mon, 2013-02-04 at 16:25 +0100, Daniel Vetter wrote: > > On Mon, Feb 04, 2013 at 03:10:11PM +0800, Zhang Rui wrote: > > > i915 driver needs to do modeset when > > > 1. system resumes from sleep > > &

Re: [Intel-gfx] [PATCH V2 3/3] i915: ignore lid open event when resuming

2013-02-05 Thread Zhang Rui
On Tue, 2013-02-05 at 11:07 +0100, Daniel Vetter wrote: > On Tue, Feb 05, 2013 at 03:41:53PM +0800, Zhang Rui wrote: > > oops, forgot to update the changelog and comments. > > refreshed patch attached. > > > > From b584fcebb6d715a317f192c88606b875ee88ce78 Mon Sep 17 00

Re: [Intel-gfx] [PATCH V2 3/3] i915: ignore lid open event when resuming

2013-02-05 Thread Zhang Rui
On Tue, 2013-02-05 at 11:14 +0100, Rafael J. Wysocki wrote: > On Tuesday, February 05, 2013 11:07:11 AM Daniel Vetter wrote: > > On Tue, Feb 05, 2013 at 03:41:53PM +0800, Zhang Rui wrote: > > > oops, forgot to update the changelog and comments. > > > refreshed patch

Re: [Intel-gfx] [PATCH V2 1/3] PM: Introduce suspend state PM_SUSPEND_FREEZE

2013-02-05 Thread Zhang Rui
On Mon, 2013-02-04 at 15:10 +0800, Zhang Rui wrote: > PM_SUSPEND_FREEZE state is a general state that > does not need any platform specific support, it equals > frozen processes + suspended devices + idle processors. > > Compared with PM_SUSPEND_MEMORY, > PM_SUSPEND_FREEZ

Re: [Intel-gfx] [PATCH V3 3/3] i915: introduce modeset_on_resume

2013-01-25 Thread Zhang Rui
On Fri, 2013-01-25 at 09:59 +0800, Zhenyu Wang wrote: > On 2013.01.24 19:49:40 +0800, Zhang Rui wrote: > > I need some graphics experts' comments before sending it out. > > > > Please send to intel-gfx@lists.freedesktop.org for i915 specific issue. > I want to get

[Intel-gfx] [RFC PATCH 1/3] PM: Introduce suspend state PM_SUSPEND_FREEZE

2013-01-27 Thread Zhang Rui
s than 0.2s 2. Freeze: (From pressing power button to screen back) 2.50s 3. Suspend to Memory: (From pressing power button to screen back) 4.33s >From the results, we can see that all the platforms should benefit from this patch, even if it does not have Low Power S0. Signed-o

[Intel-gfx] [RFC PATCH 2/3] ACPI: enable ACPI SCI during suspend

2013-01-27 Thread Zhang Rui
til arch_suspend_irq_disable() is run. Signed-off-by: Zhang Rui --- drivers/acpi/osl.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/acpi/osl.c b/drivers/acpi/osl.c index 3ff2678..3adeb10 100644 --- a/drivers/acpi/osl.c +++ b/drivers/acpi/osl.c @@ -787,7 +78

[Intel-gfx] [RFC PATCH 3/3] i915: ignore lid open event when resuming

2013-01-27 Thread Zhang Rui
ngore all the lid events. 0: do not do modeset when there is a lid-open event. 1: do modeset when there is a lid-open event. In this way, only device resume code will do modeset in a suspend/resume cycle. Signed-off-by: Zhang Rui --- drivers/gpu/drm/i915/i915_drv.c |4 ++-- drivers/gpu/drm

Re: [Intel-gfx] [RFC PATCH 3/3] i915: ignore lid open event when resuming

2013-01-27 Thread Zhang Rui
On Sun, 2013-01-27 at 16:45 +0100, Daniel Vetter wrote: > On Sun, Jan 27, 2013 at 4:21 PM, Zhang Rui wrote: > > i915 driver needs to do modeset when > > 1. system resumes from sleep > > 2. lid is opened > > > > In PM_SUSPEND_MEM state, all the GPEs are cleared wh

Re: [Intel-gfx] [RFC PATCH 3/3] i915: ignore lid open event when resuming

2013-01-28 Thread Zhang Rui
On Mon, 2013-01-28 at 09:31 +0100, Daniel Vetter wrote: > On Mon, Jan 28, 2013 at 3:36 AM, Zhang Rui wrote: > >> Given that this essentially requires users to manually set this module > >> option to make stuff work I don't like this. > >> > > sorry,