[Intel-gfx] [PATCH] drm/i915: Refine the has_audio assignment

From: Yang Shi Refine the has_audio assignment for dp and hdmi. Signed-off-by: Yang Shi --- drivers/gpu/drm/i915/intel_dp.c | 2 +- drivers/gpu/drm/i915/intel_hdmi.c | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm

[Intel-gfx] [PATCH 1/1] drm/i915: move audio component intialization before audio driver use it

From: Yang Shi snd_hdac driver would use the component interface from i915 driver. if i915 driver do the audio component intialization too late, snd_hdac driver will meet ipanic. Signed-off-by: Bo He Signed-off-by: Yang Shi --- drivers/gpu/drm/i915/i915_drv.c | 2 -- drivers/gpu/drm

[Intel-gfx] [PATCH] [v2]drm/i915: move audio component initialization before audio driver use it

From: Yang Shi issue: snd_soc_skl meet "failed to add i915 component master (-19)" when platform don't connect any display output. i915 do initialization before than skl_probe, but if there is no display output connect, in function drm_dp_dpcd_access, there is a 32 re

[Intel-gfx] [PATCH] drm/i915/gvt: Convert from atomic_t to refcount_t on intel_vgpu_ppgtt_spt->refcount

refcount_t type and corresponding API can protect refcounters from accidental underflow and overflow and further use-after-free situations Signed-off-by: Xiyu Yang Signed-off-by: Xin Tan --- drivers/gpu/drm/i915/gvt/gtt.c | 11 ++- drivers/gpu/drm/i915/gvt/gtt.h | 3 ++- 2 files

[Intel-gfx] [PATCH] drm/i915: set proper N/M in modeset

From: Libin Yang When modeset occurs and the LS_CLK is set to some special values in DP mode, the N/M need to be set manually if audio is playing. Also, the patch applies commit 7e8275c2f2bb ("drm/i915: set proper N/CTS in modeset") to APL platform. Signed-off-by: Libin Yang --- d

Re: [Intel-gfx] [PATCH] drm/i915: Acquire intel_runtime_pm for HD-Audio registers

Hi Wilson, > -Original Message- > From: Chris Wilson [mailto:ch...@chris-wilson.co.uk] > Sent: Thursday, July 14, 2016 10:34 PM > To: Mika Kuoppala ; intel- > g...@lists.freedesktop.org; Takashi Iwai ; Yang, Libin > > Subject: Re: [Intel-gfx] [PATCH] drm/i915: Acq

Re: [Intel-gfx] [PATCH] drm/i915: Acquire intel_runtime_pm for HD-Audio registers

essage- > From: Chris Wilson [mailto:ch...@chris-wilson.co.uk] > Sent: Friday, July 15, 2016 4:45 PM > To: Yang, Libin > Cc: Mika Kuoppala ; intel- > g...@lists.freedesktop.org; Takashi Iwai > Subject: Re: [Intel-gfx] [PATCH] drm/i915: Acquire intel_runtime_pm for HD- > Aud

Re: [Intel-gfx] ✗ Ro.CI.BAT: failure for drm/i915: set proper N/M in modeset

Hi All, I submitted a patch and it show to fail in CI. Does the message means it is failed because of "ro-bdw-i7-5557U failed to connect after reboot". And how can I get the dmesg? Regards, Libin > -Original Message- > From: Intel-gfx [mailto:intel-gfx-boun...@lists.freedesktop.org] O

[Intel-gfx] [PATCH] intel: Export pooled EU and min no. of eus in a pool.

need to know min no. of eus in a pool. V2: use return value as the query results. ret < 0 when error, ret = 0 when not support, and ret > 0 indicate query results.(Chris) V3: Correct V2 errors. Signed-off-by: Yang Rong --- include/drm/i915_drm.h | 2 ++ intel/intel_bufmgr.h

Re: [Intel-gfx] [PATCH] drm/i915: set proper N/M in modeset

ibin.y...@linux.intel.com [mailto:libin.y...@linux.intel.com] > Sent: Thursday, July 14, 2016 3:06 PM > To: intel-gfx@lists.freedesktop.org; jani.nik...@linux.intel.com; > ville.syrj...@linux.intel.com; Vetter, Daniel ; > ti...@suse.de > Cc: Yang, Libin ; Libin Yang > > Subject: [PATCH]

Re: [Intel-gfx] [PATCH] drm/i915: set proper N/M in modeset

Hi Ville, > -Original Message- > From: Ville Syrjälä [mailto:ville.syrj...@linux.intel.com] > Sent: Thursday, July 28, 2016 3:42 PM > To: libin.y...@linux.intel.com > Cc: intel-gfx@lists.freedesktop.org; jani.nik...@linux.intel.com; Vetter, > Daniel ; ti...@su

Re: [Intel-gfx] [PATCH] drm/i915: set proper N/M in modeset

Hi Ville, > -Original Message- > From: Ville Syrjälä [mailto:ville.syrj...@linux.intel.com] > Sent: Friday, July 29, 2016 5:47 PM > To: Yang, Libin > Cc: libin.y...@linux.intel.com; intel-gfx@lists.freedesktop.org; > jani.nik...@linux.intel.com; Vetter, Daniel ; > ti

[Intel-gfx] [PATCH] drm/i915: set proper N/M in modeset

From: Libin Yang When modeset occurs and the LS_CLK is set to some special values in DP mode, the N/M need to be set manually if audio is playing. The relationship of Maud and Naud is expressed in the following equation: Maud/Naud = 512 * fs / f_LS_Clk Please refer VESA DisplayPort Standard

[Intel-gfx] [PATCH] drm/i915: HDMI audio gets the TMDS clock by crtc_clock

From: Libin Yang HDMI audio should use crtc_clock to get the TMDS clock. Besides, this patch renames mode to adjusted_mode to unify the name. Signed-off-by: Libin Yang --- drivers/gpu/drm/i915/intel_audio.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a

Re: [Intel-gfx] [PATCH] drm/i915: HDMI audio gets the TMDS clock by crtc_clock

> ville.syrj...@linux.intel.com; Vetter, Daniel ; > ti...@suse.de > Cc: Yang, Libin ; Libin Yang > > Subject: [PATCH] drm/i915: HDMI audio gets the TMDS clock by crtc_clock > > From: Libin Yang > > HDMI audio should use crtc_clock to get the TMDS clock. > > Besi

Re: [Intel-gfx] [PATCH] drm/i915: set proper N/M in modeset

Hi Ville > -Original Message- > From: Ville Syrjälä [mailto:ville.syrj...@linux.intel.com] > Sent: Tuesday, August 2, 2016 6:47 PM > To: libin.y...@linux.intel.com > Cc: intel-gfx@lists.freedesktop.org; jani.nik...@linux.intel.com; Vetter, > Daniel > ; ti...

Re: [Intel-gfx] [PATCH] drm/i915: set proper N/M in modeset

Hi Jani, > -Original Message- > From: Jani Nikula [mailto:jani.nik...@linux.intel.com] > Sent: Tuesday, August 2, 2016 6:53 PM > To: libin.y...@linux.intel.com; intel-gfx@lists.freedesktop.org; > ville.syrj...@linux.intel.com; Vetter, Daniel ; > ti...@suse.de > Cc

Re: [Intel-gfx] [PATCH 1/3] drm/i915: start adding dp mst audio

Add Takashi Regards, Libin > -Original Message- > From: Pandiyan, Dhinakaran > Sent: Wednesday, August 3, 2016 9:47 AM > To: intel-gfx@lists.freedesktop.org > Cc: cp...@redhat.com; ville.syrj...@linux.intel.com; Yang, Libin > ; Libin Yang > Subject: [PATCH 1/3] d

Re: [Intel-gfx] Prep. for DP audio MST support

linux.intel.com; Yang, Libin > > Subject: Prep. for DP audio MST support > > This series lays the groundwork for more DP MST audio work that will follow. > Patch 1 got possibly reverted because Patch 3 was missing. > > The APIs between i915 and audio drivers have to modi

Re: [Intel-gfx] [PATCH 3/3] drm/i915: Fix enc_to_dig_port for MST encoders

Add Takashi Regards, Libin > -Original Message- > From: Pandiyan, Dhinakaran > Sent: Wednesday, August 3, 2016 9:47 AM > To: intel-gfx@lists.freedesktop.org > Cc: cp...@redhat.com; ville.syrj...@linux.intel.com; Yang, Libin > ; Pandiyan, Dhinakaran > > Subje

Re: [Intel-gfx] [PATCH 2/3] drm/i915: Move audio_connector to intel_encoder

Add Takashi Regards, Libin > -Original Message- > From: Pandiyan, Dhinakaran > Sent: Wednesday, August 3, 2016 9:47 AM > To: intel-gfx@lists.freedesktop.org > Cc: cp...@redhat.com; ville.syrj...@linux.intel.com; Yang, Libin > ; Pandiyan, Dhinakaran > > Subje

Re: [Intel-gfx] [PATCH] drm/i915: set proper N/M in modeset

Hi Ville, > -Original Message- > From: Yang, Libin > Sent: Tuesday, August 2, 2016 9:59 PM > To: Ville Syrjälä ; libin.y...@linux.intel.com > Cc: intel-gfx@lists.freedesktop.org; jani.nik...@linux.intel.com; Vetter, > Daniel > ; ti...@suse.de > Subject: RE: [PATCH

Re: [Intel-gfx] [PATCH] drm/i915: set proper N/M in modeset

Hi Ville, > -Original Message- > From: Ville Syrjälä [mailto:ville.syrj...@linux.intel.com] > Sent: Wednesday, August 3, 2016 12:59 AM > To: Yang, Libin > Cc: libin.y...@linux.intel.com; intel-gfx@lists.freedesktop.org; > jani.nik...@linux.intel.com; Vetter, Daniel

Re: [Intel-gfx] [PATCH] drm/i915: set proper N/M in modeset

Hi Ville, > -Original Message- > From: Ville Syrjälä [mailto:ville.syrj...@linux.intel.com] > Sent: Thursday, August 4, 2016 1:39 PM > To: Yang, Libin > Cc: 'libin.y...@linux.intel.com' ; 'intel- > g...@lists.freedesktop.org' ; > 'jani.ni

Re: [Intel-gfx] [PATCH] drm/i915: set proper N/M in modeset

Hi Ville, > -Original Message- > From: Ville Syrjälä [mailto:ville.syrj...@linux.intel.com] > Sent: Thursday, August 4, 2016 2:06 PM > To: Yang, Libin > Cc: libin.y...@linux.intel.com; intel-gfx@lists.freedesktop.org; > jani.nik...@linux.intel.com; Vetter, Daniel

Re: [Intel-gfx] [PATCH] drm/i915: set proper N/M in modeset

Hi Ville, > -Original Message- > From: Ville Syrjälä [mailto:ville.syrj...@linux.intel.com] > Sent: Thursday, August 4, 2016 2:24 PM > To: Yang, Libin > Cc: 'libin.y...@linux.intel.com' ; 'intel- > g...@lists.freedesktop.org' ; > 'jani.ni

[Intel-gfx] [PATCH v3 1/3] drm/i915: set proper N/M in modeset

From: Libin Yang When modeset occurs and the LS_CLK is set to some special values in DP mode, the N/M need to be set manually if audio is playing. Otherwise the first several seconds may be silent in audio playback. The relationship of Maud and Naud is expressed in the following equation: Maud

[Intel-gfx] [PATCH v3 2/3] drm/i915: set proper N/MCTS on more platforms

From: Libin Yang This patch applies setting proper N/M, N/CTS on more platforms. Signed-off-by: Libin Yang --- drivers/gpu/drm/i915/intel_audio.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_audio.c b/drivers/gpu/drm/i915/intel_audio.c

[Intel-gfx] [PATCH v3 3/3] drm/i915: HDMI audio gets the TMDS clock by crtc_clock

From: Libin Yang HDMI audio should use crtc_clock to get the TMDS clock. Besides, this patch renames mode to adjusted_mode to unify the name. Signed-off-by: Libin Yang --- drivers/gpu/drm/i915/intel_audio.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a

Re: [Intel-gfx] [PATCH] drm/i915/dp: DP audio API changes for MST

> -Original Message- > From: Intel-gfx [mailto:intel-gfx-boun...@lists.freedesktop.org] On Behalf Of > Ville Syrjälä > Sent: Friday, August 5, 2016 4:48 AM > To: Takashi Iwai > Cc: libin.y...@linux.intel.com; intel-gfx@lists.freedesktop.org; alsa- > de...@alsa-project.org; Pandiyan, Dhina

Re: [Intel-gfx] [PATCH] drm/i915/dp: DP audio API changes for MST

> -Original Message- > From: Intel-gfx [mailto:intel-gfx-boun...@lists.freedesktop.org] On Behalf Of > Dhinakaran Pandiyan > Sent: Wednesday, August 3, 2016 10:15 AM > To: intel-gfx@lists.freedesktop.org > Cc: alsa-de...@alsa-project.org; ti...@suse.de; libin.y...@linux.intel.com; > Pandiy

Re: [Intel-gfx] [PATCH v3 1/3] drm/i915: set proper N/M in modeset

linux.intel.com; Vetter, > Daniel > ; ti...@suse.de; Yang, Libin > Subject: Re: [PATCH v3 1/3] drm/i915: set proper N/M in modeset > > On Thu, Aug 04, 2016 at 03:58:02PM +0800, libin.y...@linux.intel.com wrote: > > From: Libin Yang > > > > When modeset occurs an

Re: [Intel-gfx] [PATCH v3 2/3] drm/i915: set proper N/MCTS on more platforms

> -Original Message- > From: Ville Syrjälä [mailto:ville.syrj...@linux.intel.com] > Sent: Thursday, August 4, 2016 4:54 PM > To: libin.y...@linux.intel.com > Cc: intel-gfx@lists.freedesktop.org; jani.nik...@linux.intel.com; Vetter, > Daniel > ; ti...@suse.de; Yang,

Re: [Intel-gfx] [PATCH v3 1/3] drm/i915: set proper N/M in modeset

Hi Ville, > -Original Message- > From: Ville Syrjälä [mailto:ville.syrj...@linux.intel.com] > Sent: Friday, August 5, 2016 1:57 PM > To: Yang, Libin > Cc: libin.y...@linux.intel.com; intel-gfx@lists.freedesktop.org; > jani.nik...@linux.intel.com; Vetter, Daniel

Re: [Intel-gfx] [PATCH] drm/i915/dp: DP audio API changes for MST

> -Original Message- > From: Pandiyan, Dhinakaran > Sent: Friday, August 5, 2016 1:57 PM > To: Yang, Libin > Cc: intel-gfx@lists.freedesktop.org; ti...@suse.de; alsa-devel@alsa- > project.org; libin.y...@linux.intel.com > Subject: Re: [Intel-gfx] [PATCH] drm/i915/dp:

Re: [Intel-gfx] [PATCH v3 1/3] drm/i915: set proper N/M in modeset

> -Original Message- > From: Ville Syrjälä [mailto:ville.syrj...@linux.intel.com] > Sent: Friday, August 5, 2016 2:36 PM > To: Yang, Libin > Cc: libin.y...@linux.intel.com; intel-gfx@lists.freedesktop.org; > jani.nik...@linux.intel.com; Vetter, Daniel ; > ti...@

Re: [Intel-gfx] [PATCH] drm/i915/dp: DP audio API changes for MST

> -Original Message- > From: Pandiyan, Dhinakaran > Sent: Friday, August 5, 2016 2:42 PM > To: Yang, Libin > Cc: intel-gfx@lists.freedesktop.org; ti...@suse.de; alsa-devel@alsa- > project.org; libin.y...@linux.intel.com > Subject: Re: [Intel-gfx] [PATCH] drm/

Re: [Intel-gfx] [PATCH v3 1/3] drm/i915: set proper N/M in modeset

> -Original Message- > From: Ville Syrjälä [mailto:ville.syrj...@linux.intel.com] > Sent: Friday, August 5, 2016 3:17 PM > To: Yang, Libin > Cc: libin.y...@linux.intel.com; intel-gfx@lists.freedesktop.org; > jani.nik...@linux.intel.com; Vetter, Daniel ; > ti...@

Re: [Intel-gfx] [PATCH v3 1/3] drm/i915: set proper N/M in modeset

> -Original Message- > From: Ville Syrjälä [mailto:ville.syrj...@linux.intel.com] > Sent: Friday, August 5, 2016 4:45 PM > To: Yang, Libin > Cc: libin.y...@linux.intel.com; intel-gfx@lists.freedesktop.org; > jani.nik...@linux.intel.com; Vetter, Daniel ; > ti...@

[Intel-gfx] [PATCH] drm/i915: avoid division by zero on skl_calc_wrpll_link

From: Young Xiao If for some unexpected reason the registers all read zero it's better to WARN and return instead of dividing by zero and completely freezing the machine. See commit 0e005888b833 ("drm/i915: avoid division by zero on cnl_calc_wrpll_link") for detail. Signed-off-by: Young Xiao -

[Intel-gfx] [PATCH] drm/i915: Fix i915_gem_wait_for_idle oops due to active_requests check

dule_lite Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=109005 Signed-off-by: Bin Yang --- drivers/gpu/drm/i915/i915_drv.h | 1 + drivers/gpu/drm/i915/i915_gem.c | 2 +- drivers/gpu/drm/i915/i915_request.c | 10 +++--- 3 files changed, 9 insertions(+), 4 deletions(-) dif

Re: [Intel-gfx] [PATCH] drm/i915: Fix i915_gem_wait_for_idle oops due to active_requests check

On Thu, 2018-12-20 at 08:35 +, Chris Wilson wrote: > Quoting Bin Yang (2018-12-20 08:01:35) > > Normally, i915_request_alloc() and i915_request_add() will be called > > in sequence with drm.struct_mutex locked. But in > > intel_vgpu_create_workload(), it will pre-all

[Intel-gfx] [PATCH] drm/i915/gt: Do not add same i915_request to intel_context twice

From: "Yang, Dong" With unknow race condition, the i915_request will be added to intel_context list twice, and result in system panic. If node alreay exist then do not add it again. Signed-off-by: Yang, Dong --- drivers/gpu/drm/i915/gt/intel_breadcrumbs.c | 3 +++ 1 file

Re: [Intel-gfx] [PATCH] drm/i915/gt: Do not add same i915_request to intel_context twice

and the loop will never break continue the i915_request. hwsp_seqno be changed, and invalid address access error reported followed by system panic. Thanks, Dong -Original Message- From: Tvrtko Ursulin Sent: Friday, December 10, 2021 4:51 PM To: Yang, Dong ; intel-gfx@lists.freedeskto

Re: [Intel-gfx] [PATCH] drm/i915/gt: Do not add same i915_request to intel_context twice

Sent: Monday, December 13, 2021 5:37 PM To: Yang, Dong ; intel-gfx@lists.freedesktop.org Subject: Re: [Intel-gfx] [PATCH] drm/i915/gt: Do not add same i915_request to intel_context twice On 13/12/2021 01:53, Yang, Dong wrote: > I am working on a customized kernel based on 5.4.39, issue can o

[Intel-gfx] [PATCH -next] drm/i915/gvt: Fix intel_vgpu_default_mmio_write() kernel-doc comment

pe was for intel_vgpu_default_mmio_write() instead. Reported-by: Abaci Robot Fixes: e39c5add3221 ("drm/i915/gvt: vGPU MMIO virtualization") Signed-off-by: Yang Li --- drivers/gpu/drm/i915/gvt/handlers.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/gvt/handlers.c b/

[Intel-gfx] [PATCH -next v2] drm/i915/fbc: replace DEFINE_SIMPLE_ATTRIBUTE with DEFINE_DEBUGFS_ATTRIBUTE

Fix the following coccicheck warning: ./drivers/gpu/drm/i915/display/intel_fbc.c:1757:0-23: WARNING: intel_fbc_debugfs_false_color_fops should be defined with DEFINE_DEBUGFS_ATTRIBUTE Reported-by: Abaci Robot Signed-off-by: Yang Li --- drivers/gpu/drm/i915/display/intel_fbc.c | 8 1

[Intel-gfx] [PATCH -next] drm/i915/fbc: replace DEFINE_SIMPLE_ATTRIBUTE with DEFINE_DEBUGFS_ATTRIBUTE

Fix the following coccicheck warning: ./drivers/gpu/drm/i915/display/intel_fbc.c:1757:0-23: WARNING: intel_fbc_debugfs_false_color_fops should be defined with DEFINE_DEBUGFS_ATTRIBUTE Reported-by: Abaci Robot Signed-off-by: Yang Li --- drivers/gpu/drm/i915/display/intel_fbc.c | 2 +- 1 file

Re: [Intel-gfx] [PATCH] drm/i915: avoid concurrent writes to aux_inv

>> @@ -157,6 +163,9 @@ int gen11_emit_flush_rcs(struct i915_request *rq, >> u32 mode) >> intel_ring_advance(rq, cs); >> } >> >> +/* hsdes: 1809175790. No fixup needed for gen11 rcs */ >> +rq->aux_inv_fixup = NULL; > > This is a little ugly to me. Can we just set this to

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: avoid concurrent writes to aux_inv (rev5)

Confirmed this is a regression caused by the patch. Will debug further. From: Summers, Stuart Sent: Tuesday, March 15, 2022 8:23 PM To: intel-gfx@lists.freedesktop.org; Yang, Fei Subject: Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: avoid concurrent writes to aux_inv (rev5) On Sat, 2022

Re: [Intel-gfx] [PATCH] drm/i915: avoid concurrent writes to aux_inv

>>> diff --git a/drivers/gpu/drm/i915/gt/intel_execlists_submission.c >>> b/drivers/gpu/drm/i915/gt/intel_execlists_submission.c >>> index e1470bb60f34..7e8552414275 100644 >>> --- a/drivers/gpu/drm/i915/gt/intel_execlists_submission.c >>> +++ b/drivers/gpu/drm/i915/gt/intel_execlists_submission.c

Re: [Intel-gfx] [PATCH] drm/i915: avoid concurrent writes to aux_inv

>> diff --git a/drivers/gpu/drm/i915/gt/gen2_engine_cs.c >> b/drivers/gpu/drm/i915/gt/gen2_engine_cs.c >> index 1c82caf525c3..0ec4986e4805 100644 >> --- a/drivers/gpu/drm/i915/gt/gen2_engine_cs.c >> +++ b/drivers/gpu/drm/i915/gt/gen2_engine_cs.c >> @@ -37,6 +37,9 @@ int gen2_emit_flush(struct i915

[Intel-gfx] [PATCH] drm/i915: avoid concurrent writes to aux_inv

From: Fei Yang GPU hangs have been observed when multiple engines write to the same aux_inv register at the same time. To avoid this each engine should only invalidate its own auxiliary table. The function gen12_emit_flush_xcs() currently invalidate the auxiliary table for all engines because

[Intel-gfx] [PATCH] drm/i915: avoid concurrent writes to aux_inv

From: Fei Yang GPU hangs have been observed when multiple engines write to the same aux_inv register at the same time. To avoid this each engine should only invalidate its own auxiliary table. The function gen12_emit_flush_xcs() currently invalidate the auxiliary table for all engines because

Re: [Intel-gfx] [PATCH] drm/i915: avoid concurrent writes to aux_inv

>> static u32 *gen12_emit_aux_table_inv(const i915_reg_t inv_reg, u32 *cs) >> { >> *cs++ = MI_LOAD_REGISTER_IMM(1); >> @@ -296,7 +272,7 @@ int gen12_emit_flush_xcs(struct i915_request *rq, u32 >> mode) >> if (!HAS_FLAT_CCS(rq->engine->i915)) { >> aux_inv

[Intel-gfx] [PATCH] drm/i915: avoid concurrent writes to aux_inv

From: Fei Yang GPU hangs have been observed when multiple engines write to the same aux_inv register at the same time. To avoid this each engine should only invalidate its own auxiliary table. The function gen12_emit_flush_xcs() currently invalidate the auxiliary table for all engines because

[Intel-gfx] [PATCH] drm/i915: avoid concurrent writes to aux_inv

From: Fei Yang GPU hangs have been observed when multiple engines write to the same aux_inv register at the same time. To avoid this each engine should only invalidate its own auxiliary table. The function gen12_emit_flush_xcs() currently invalidate the auxiliary table for all engines because

[Intel-gfx] [PATCH] drm/i915: avoid concurrent writes to aux_inv

From: Fei Yang GPU hangs have been observed when multiple engines write to the same aux_inv register at the same time. To avoid this each engine should only invalidate its own auxiliary table. The function gen12_emit_flush_xcs() currently invalidate the auxiliary table for all engines because

Re: [Intel-gfx] [PATCH] drm/i915: avoid concurrent writes to aux_inv

>> +u32 *gen12_emit_aux_table_inv(const i915_reg_t inv_reg, u32 *cs) >> -static u32 *gen12_emit_aux_table_inv(const i915_reg_t inv_reg, u32 *cs) > > I think all helpers which emit to ring take cs as the first argument so it > would be good to make this consistent. Updated the patch, please review

Re: [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: avoid concurrent writes to aux_inv (rev10)

> On 29/03/2022 03:30, Patchwork wrote: >> *Patch Details* >> *Series:*drm/i915: avoid concurrent writes to aux_inv (rev10) >> *URL:* https://patchwork.freedesktop.org/series/100772/ >> >> *State:* success >> *Details:* >> https://in

Re: [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: avoid concurrent writes to aux_inv (rev10)

*Patch Details* *Series:* drm/i915: avoid concurrent writes to aux_inv (rev10) *URL:* https://patchwork.freedesktop.org/series/100772/ *State:* success *Details:* https://intel-gfx-ci.01.org/tree/drm-tip/Pa

Re: [Intel-gfx] [PATCH 1/2] drm/i915/xehp: Add compute engine ABI

>> > --- a/drivers/gpu/drm/i915/gt/intel_gt.c >> > +++ b/drivers/gpu/drm/i915/gt/intel_gt.c >> > @@ -1175,6 +1175,7 @@ void intel_gt_invalidate_tlbs(struct intel_gt *gt) >> >[VIDEO_DECODE_CLASS]= GEN12_VD_TLB_INV_CR, >> >[VIDEO_ENHANCEMENT_CLASS] = GEN12_VE

[Intel-gfx] [PATCH] drm/i915: avoid concurrent writes to aux_inv

From: Fei Yang GPU hangs have been observed when multiple engines write to the same aux_inv register at the same time. To avoid this each engine should only invalidate its own auxiliary table. The function gen12_emit_flush_xcs() currently invalidate the auxiliary table for all engines because

[Intel-gfx] [PATCH] drm/i915: avoid concurrent writes to aux_inv

From: Fei Yang GPU hangs have been observed when multiple engines write to the same aux_inv register at the same time. To avoid this each engine should only invalidate its own auxiliary table. The function gen12_emit_flush_xcs() currently invalidate the auxiliary table for all engines because

[Intel-gfx] [PATCH] drm/i915: avoid concurrent writes to aux_inv

From: Fei Yang GPU hangs have been observed when multiple engines write to the same aux_inv register at the same time. To avoid this each engine should only invalidate its own auxiliary table. The function gen12_emit_flush_xcs() currently invalidate the auxiliary table for all engines because

Re: [Intel-gfx] [intel-gfx] [PATCH] drm/i915: avoid concurrent writes to aux_inv (rev3)

Hi Chris, for some reason I didn't receive the review email, so I copied your comments from patchwork and faked this email. >> static void execlists_dequeue(struct intel_engine_cs *engine) >> { >> struct intel_engine_execlists * const execlists = &engine->execlists; >> @@ -1538,6 +1566,

[Intel-gfx] [PATCH] drm/i915: avoid concurrent writes to aux_inv

From: Fei Yang GPU hangs have been observed when multiple engines write to the same aux_inv register at the same time. To avoid this each engine should only invalidate its own auxiliary table. The function gen12_emit_flush_xcs() currently invalidate the auxiliary table for all engines because

[Intel-gfx] [PATCH] drm/i915: avoid concurrent writes to aux_inv

From: Fei Yang GPU hangs have been observed when multiple engines write to the same aux_inv register at the same time. To avoid this each engine should only invalidate its own auxiliary table. The function gen12_emit_flush_xcs() currently invalidate the auxiliary table for all engines because

[Intel-gfx] [PATCH] drm/i915/userptr: Try to acquire the page lock around set_page_dirty()

From: Fei Yang This is a backport of cee7fb437edcdb2f9f8affa959e274997f5dca4d to linux-4.4.y set_page_dirty says: For pages with a mapping this should be done under the page lock for the benefit of asynchronous memory errors who prefer a consistent dirty state. This

[Intel-gfx] [PATCH] drm/i915/selftests: Fix i915_address_space refcnt leak

"out_vm" label when i915_gem_object_create_internal() returns IS_ERR. Fixes: 4049866f0913 ("drm/i915/selftests: huge page tests") Signed-off-by: Xiyu Yang Signed-off-by: Xin Tan --- drivers/gpu/drm/i915/gem/selftests/huge_pages.c | 12 1 file changed, 8 insertions(+), 4 deletions(-

[Intel-gfx] patc push failed

Hi, I have clone the drm-intel code-base, after I apply my patch locally and I want upstream the patch, but it report error: fatal: unable to access 'https://anongit.freedesktop.org/git/drm-intel.git/': The requested URL returned error: 403 I use git clone to clone the code-base: git clone http

[Intel-gfx] [PATCH] drm/i915: Remove i915 ggtt WA since GT E

From: "Yang, Dong" The APL already fixed this bug since GT E, bug exist from 0 to D, apply WA according GT stepping. Signed-off-by: Yang, Dong --- drivers/gpu/drm/i915/i915_drv.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_drv.h

[Intel-gfx] [PATCH] drm/i915: Remove i915 ggtt WA since GT E

From: "Yang, Dong" The APL already fixed this bug since GT E, bug exist from 0 to D, apply WA according GT stepping. Signed-off-by: Yang, Dong --- drivers/gpu/drm/i915/i915_drv.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_drv.h

Re: [Intel-gfx] [PATCH] drm/i915: Remove i915 ggtt WA since GT E

comments updated, please review again. -Original Message- From: Joonas Lahtinen [mailto:joonas.lahti...@linux.intel.com] Sent: Tuesday, August 13, 2019 8:47 PM To: Yang, Dong ; intel-gfx@lists.freedesktop.org Cc: y...@freedesktop.org Subject: Re: [Intel-gfx] [PATCH] drm/i915: Remove i915

[Intel-gfx] [PATCH] drm/i915: Remove i915 ggtt WA since GT E0

From: "Yang, Dong" Broxton steppings starting from GT E0 have fixed the bug, remove WA since stepping GT E0. Signed-off-by: Yang, Dong --- drivers/gpu/drm/i915/i915_drv.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drive

[Intel-gfx] [PATCH v2] drm/i915: Remove i915 ggtt WA since GT E0

From: "Yang, Dong" Broxton steppings starting from GT E0 have fixed the bug, remove WA since stepping GT E0. v2: add comment in code, by: Joonas Lahtinen Signed-off-by: Yang, Dong --- drivers/gpu/drm/i915/i915_drv.h | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) di

[Intel-gfx] [PATCH v2] drm/i915: Remove i915 ggtt WA since GT E0

From: "Yang, Dong" Broxton steppings starting from GT E0 have fixed the bug, remove WA since stepping GT E0. v2: use BXT_REVID_D_LAST replace BXT_REVID_D0, by: Joonas Lahtinen Signed-off-by: Yang, Dong --- drivers/gpu/drm/i915/i915_drv.h | 4 +++- 1 file changed, 3 insertions(+),

[Intel-gfx] [PATCH] drm: Replace deprecated function in drm_crtc_helper

Replace deprecated function drm_modeset_lock/unlock_all with helper function DRM_MODESET_LOCK_ALL_BEGIN/END. Signed-off-by: Sidong Yang --- drivers/gpu/drm/drm_crtc_helper.c | 19 --- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm

Re: [Intel-gfx] [PATCH] mm: Skip opportunistic reclaim for dma pinned pages

On Wed, Jun 24, 2020 at 1:23 PM Yang Shi wrote: > > On Wed, Jun 24, 2020 at 12:21 PM Jason Gunthorpe wrote: > > > > On Wed, Jun 24, 2020 at 08:14:17PM +0100, Chris Wilson wrote: > > > A general rule of thumb is that shrinkers should be fast and effective. > &

Re: [Intel-gfx] [PATCH] mm: Skip opportunistic reclaim for dma pinned pages

On Thu, Jun 25, 2020 at 4:42 AM Matthew Wilcox wrote: > > On Wed, Jun 24, 2020 at 08:14:17PM +0100, Chris Wilson wrote: > > A side effect of the LRU shrinker not being dma aware is that we will > > often attempt to perform direct reclaim on the persistent group of dma > > pages while continuing to

Re: [Intel-gfx] [PATCH] mm: Skip opportunistic reclaim for dma pinned pages

On Wed, Jun 24, 2020 at 12:21 PM Jason Gunthorpe wrote: > > On Wed, Jun 24, 2020 at 08:14:17PM +0100, Chris Wilson wrote: > > A general rule of thumb is that shrinkers should be fast and effective. > > They are called from direct reclaim at the most incovenient of times when > > the caller is wait

Re: [Intel-gfx] [PATCH v3 1/3] drm/i915: set proper N/M in modeset

> -Original Message- > From: Ville Syrjälä [mailto:ville.syrj...@linux.intel.com] > Sent: Friday, August 5, 2016 6:54 PM > To: Yang, Libin > Cc: libin.y...@linux.intel.com; intel-gfx@lists.freedesktop.org; > jani.nik...@linux.intel.com; Vetter, Daniel ; > ti...@

[Intel-gfx] [PATCH v4 0/3] drm/i915: fix some audio support 4K resolution issues

From: Libin Yang changelog: v1: initial patches v2: change to use crtc->config->port_clock instead of mode->clock for dp change to use mode->crtc_clock instead of mode->clock rename mode to adjusted_mode v3: add support for 270MHz add more platforms support

[Intel-gfx] [PATCH v4 1/3] drm/i915: set proper N/M in modeset

From: Libin Yang When modeset occurs and the LS_CLK is set to some special values in DP mode, the N/M need to be set manually if audio is playing. Otherwise the first several seconds may be silent in audio playback. The relationship of Maud and Naud is expressed in the following equation: Maud

[Intel-gfx] [PATCH v4 2/3] drm/i915: set proper N/MCTS on more platforms

From: Libin Yang This patch applies setting proper N/M, N/CTS on more platforms. Signed-off-by: Libin Yang --- drivers/gpu/drm/i915/intel_audio.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_audio.c b/drivers/gpu/drm/i915/intel_audio.c

[Intel-gfx] [PATCH v4 3/3] drm/i915: HDMI audio gets the TMDS clock by crtc_clock

From: Libin Yang HDMI audio should use crtc_clock to get the TMDS clock. This patch renames mode to adjusted_mode to unify the name. Signed-off-by: Libin Yang --- drivers/gpu/drm/i915/intel_audio.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/gpu

Re: [Intel-gfx] [PATCH v4 0/3] drm/i915: fix some audio support 4K resolution issues

, Daniel ; > ti...@suse.de > Cc: Yang, Libin ; Libin Yang > > Subject: [PATCH v4 0/3] drm/i915: fix some audio support 4K resolution > issues > > From: Libin Yang > > changelog: > v1: initial patches > > v2: change to use crtc->config->port_clo

Re: [Intel-gfx] [PATCH v4 0/3] drm/i915: fix some audio support 4K resolution issues

Sorry for disturb. Is there any comments for the patches? Regards, Libin > -Original Message- > From: Yang, Libin > Sent: Monday, August 22, 2016 9:16 AM > To: libin.y...@linux.intel.com; intel-gfx@lists.freedesktop.org; > jani.nik...@linux.intel.com; ville.syrj...@

Re: [Intel-gfx] [PATCH v4 0/3] drm/i915: fix some audio support 4K resolution issues

Hi Daniel, Thanks. Let's wait for Ville back from vacation. :) Regards, Libin > -Original Message- > From: Daniel Vetter [mailto:daniel.vet...@ffwll.ch] On Behalf Of Daniel > Vetter > Sent: Wednesday, August 24, 2016 1:53 PM > To: Yang, Libin > Cc: 

Re: [Intel-gfx] [alsa-devel] [PATCH v4] drm/i915/dp: DP audio API changes for MST

> -Original Message- > From: alsa-devel-boun...@alsa-project.org [mailto:alsa-devel- > boun...@alsa-project.org] On Behalf Of Pandiyan, Dhinakaran > Sent: Thursday, September 1, 2016 3:48 PM > To: intel-gfx@lists.freedesktop.org > Cc: alsa-de...@alsa-project.org; ti...@suse.de; jim.br...@l

Re: [Intel-gfx] [PATCH v3] mm, drm/i915: mark pinned shmemfs pages as unevictable

On Wed, Oct 31, 2018 at 5:42 PM Chris Wilson wrote: > Will do. As you are confident, I'll try a few different machines. :) > -Chris Great! Thanks for your help. :) Vovo ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop

Re: [Intel-gfx] [PATCH v3] mm, drm/i915: mark pinned shmemfs pages as unevictable

On Thu, Nov 1, 2018 at 12:42 AM Michal Hocko wrote: > On Wed 31-10-18 07:40:14, Dave Hansen wrote: > > Didn't we create the unevictable lists in the first place because > > scanning alone was observed to be so expensive in some scenarios? > > Yes, that is the case. I might just misunderstood the c

Re: [Intel-gfx] [PATCH v3] mm, drm/i915: mark pinned shmemfs pages as unevictable

On Wed, Oct 31, 2018 at 10:19 PM Dave Hansen wrote: > On 10/31/18 1:19 AM, owner-linux...@kvack.org wrote: > > -These are currently used in two places in the kernel: > > +These are currently used in three places in the kernel: > > > > (1) By ramfs to mark the address spaces of its inodes when th

Re: [Intel-gfx] [PATCH v3] mm, drm/i915: mark pinned shmemfs pages as unevictable

On Thu, Nov 1, 2018 at 9:10 PM Michal Hocko wrote: > OK, so that explain my question about the test case. Even though you > generate a lot of page cache, the amount is still too small to trigger > pagecache mostly reclaim and anon LRUs are scanned as well. > > Now to the difference with the previo

[Intel-gfx] Checking the amount of memory pinned by i915_gem_object_get_pages_gtt()

Is there a way to check the amount of memory pinned by i915_gem_object_get_pages_gtt(), it would be very helpful to check system memory usage. I think the pinned field in i915_gem_gtt has a different meaning and doesn't indicate whether a gem object is pinned by i915_gem_object_get_pages_gtt(). #

Re: [Intel-gfx] [PATCH v3] mm, drm/i915: mark pinned shmemfs pages as unevictable

On Thu, Nov 1, 2018 at 10:30 PM Dave Hansen wrote: > On 11/1/18 5:06 AM, Vovo Yang wrote: > >> mlock() and ramfs usage are pretty easy to track down. /proc/$pid/smaps > >> or /proc/meminfo can show us mlock() and good ol' 'df' and friends can > >&

Re: [Intel-gfx] [PATCH] drm/i915/audio: not to set N/M value manually for KBL.

>-Original Message- >From: Jani Nikula [mailto:jani.nik...@linux.intel.com] >Sent: Tuesday, April 4, 2017 6:55 PM >To: Wang, Quanxian ; intel- >g...@lists.freedesktop.org >Cc: Yang, Libin >Subject: Re: [Intel-gfx] [PATCH] drm/i915/audio: not to set N/M value >man

Re: [Intel-gfx] [PATCH] drm/i915/audio: not to set N/M value manually for KBL.

Hi Quanxian, >-Original Message- >From: Wang, Quanxian >Sent: Wednesday, April 5, 2017 10:21 AM >To: Jani Nikula ; intel-gfx@lists.freedesktop.org >Cc: Yang, Libin >Subject: RE: [Intel-gfx] [PATCH] drm/i915/audio: not to set N/M value >manually for KBL. > >

Re: [Intel-gfx] HDMI audio to support extcon

Hi Daniel, >-Original Message- >From: Vetter, Daniel >Sent: Friday, May 12, 2017 2:06 AM >To: Bossart, Pierre-louis ; Yang, Libin >; jani.nik...@linux.intel.com >Cc: Girdwood, Liam R ; Lin, Mengdong > >Subject: Re: HDMI audio to support extcon > >On Thu, 201

Re: [Intel-gfx] HDMI audio to support extcon

>-Original Message- >From: Daniel Vetter [mailto:daniel.vet...@ffwll.ch] On Behalf Of Daniel Vetter >Sent: Monday, May 15, 2017 9:49 PM >To: Yang, Libin >Cc: Vetter, Daniel ; Bossart, Pierre-louis louis.boss...@intel.com>; jani.nik...@linux.intel.com; intel- >g...@

  1   2   3   4   5   6   >