Remove the KBL check from IS_SKYLAKE() following the kernel definition.
Then, add the KBL check to IS_GEN9().
The idea is to avoid confusion. On the kernel side, the mix of SKY
and KBL was nacked so the platforms are split.
Cc: Rodrigo Vivi
Signed-off-by: Wayne Boyer
---
lib/intel_chipset.h
Add the Kabylake GT4 PCI IDs as defined in this kernel patch.
commit 8b10c0cf21ec84618d4bf02c73c0543500ece68d
Author: Deepak S
Date: Wed Oct 28 12:21:12 2015 -0700
drm/i915/kbl: Add Kabylake GT4 PCI ID
Cc: Rodrigo Vivi
Signed-off-by: Wayne Boyer
---
lib/intel_chipset.h
.
Cc: Rodrigo Vivi
Signed-off-by: Wayne Boyer
---
drivers/gpu/drm/i915/i915_drv.c | 137 ++--
1 file changed, 35 insertions(+), 102 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
index 90faa8e..5f8b0ff 100644
--- a
.is_cherryview in the cherryview
device info structure and defines the HAS_GEN7_LP_FEATURES macro.
Then where appropriate, instances of IS_VALLEYVIEW are replaced with
HAS_GEN7_LP_FEATURES to test for either a valleyview or a cherryview
device.
Cc: Rodrigo Vivi
Signed-off-by: Wayne Boyer
---
drivers/gpu
: Use VLV_FEATURES for the gen7 low power devices. (Jani)
Cc: Rodrigo Vivi
Signed-off-by: Wayne Boyer
---
drivers/gpu/drm/i915/i915_drv.c | 137 ++--
1 file changed, 35 insertions(+), 102 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu
: Use VLV_FEATURES for the gen7 low power devices. (Jani)
v3: Include HSW_FEATURES definition in intel_skylake_gt3_info. (Chris)
Cc: Rodrigo Vivi
Signed-off-by: Wayne Boyer
---
drivers/gpu/drm/i915/i915_drv.c | 138 +++-
1 file changed, 36 insertions(+), 102
VLV_FEATURES for the gen7 low power devices. (Jani)
v3: Include HSW_FEATURES definition in intel_skylake_gt3_info. (Chris)
v4: Fix commit message.
Cc: Rodrigo Vivi
Signed-off-by: Wayne Boyer
---
drivers/gpu/drm/i915/i915_drv.c | 138 +++-
1 file changed, 36
rjälä
Cc: Rodrigo Vivi
Signed-off-by: Wayne Boyer
---
drivers/gpu/drm/i915/i915_gem_context.c | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_gem_context.c
b/drivers/gpu/drm/i915/i915_gem_context.c
index 4b1161d..e4de433 100644
--- a/driver
Do some further clean up based on the initial review of
drm/i915: Separate cherryview from valleyview.
In this case remove a hack for VLV A0.
Cc: Ville Syrjälä
Cc: Rodrigo Vivi
Signed-off-by: Wayne Boyer
---
drivers/gpu/drm/i915/i915_gem.c | 8
1 file changed, 8 deletions(-)
diff
patches to fix issues discovered during the first
review. (Ville)
Cc: Ville Syrjälä
Cc: Rodrigo Vivi
Signed-off-by: Wayne Boyer
---
drivers/gpu/drm/i915/i915_debugfs.c | 68 -
drivers/gpu/drm/i915/i915_dma.c | 8 ++--
drivers/gpu/drm/i915/i915_drv.c
identified
in the first iteration of the separation changes.
Wayne Boyer (5):
drm/i915: Separate cherryview from valleyview
drm/i915: Use HAS_PCH_SPLIT to determine correct devices
drm/i915: Remove VLV A0 hack
drm/i915: Only set gem object L3 cache level for IVB devices
drm/i915: Remove BUG_ON
Do some further clean up based on the initial review of
drm/i915: Separate cherryview from valleyview.
In this case check for '(GEN7 || GEN8) && HAS_PCH_SPLIT' since we're
reading FUSE_STRAP and SFUSE_STRAP which live in the PCH.
Cc: Ville Syrjälä
Cc: Rodrigo Vivi
Sig
Do some further clean up based on the initial review of
drm/i915: Separate cherryview from valleyview.
In this case remove the BUG_ON call in vlv_enable_pll().
Cc: Ville Syrjälä
Cc: Rodrigo Vivi
Signed-off-by: Wayne Boyer
---
drivers/gpu/drm/i915/intel_display.c | 3 ---
1 file changed, 3
Do some further clean up based on the initial review of
drm/i915: Separate cherryview from valleyview.
In this case remove the BUG_ON call in vlv_enable_pll().
v2: Also remove the BUG_ON call in chv_enable_pll(). (Ville)
Cc: Ville Syrjälä
Cc: Rodrigo Vivi
Signed-off-by: Wayne Boyer
mment to mention snooping requirement. (Ville, Imre)
Cc: Ville Syrjälä
Cc: Rodrigo Vivi
Signed-off-by: Wayne Boyer
---
drivers/gpu/drm/i915/i915_gem_context.c | 9 -
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/i915_gem_context.c
b/drivers/gpu/drm
patches to fix issues discovered during the first
review. (Ville)
v3: Fix some style issues and one gen check. Remove CRT related changes
as CRT is not supported on CHV. (Imre, Ville)
Cc: Ville Syrjälä
Cc: Rodrigo Vivi
Signed-off-by: Wayne Boyer
---
drivers/gpu/drm/i915/i915_debugfs.c
patches to fix issues discovered during the first
review. (Ville)
v3: Fix some style issues and one gen check. Remove CRT related changes
as CRT is not supported on CHV. (Imre, Ville)
v4: Make a few more optimizations. (Ville)
Cc: Ville Syrjälä
Cc: Rodrigo Vivi
Signed-off-by: Wayne Boyer
se Barnes
Cc: sta...@vger.kernel.org
Reviewed-by: Deepak S
Signed-off-by: Wayne Boyer
---
drivers/gpu/drm/i915/intel_fbdev.c | 15 +++
1 file changed, 15 insertions(+)
diff --git a/drivers/gpu/drm/i915/intel_fbdev.c
b/drivers/gpu/drm/i915/intel_fbdev.c
index 6532912..c6aa4f9 100644
; review. (Wayne)
Signed-off-by: Chris Wilson
Cc: "Goel, Akash"
Cc: Daniel Vetter
Cc: Jesse Barnes
Cc: sta...@vger.kernel.org
Reviewed-by: Deepak S
Signed-off-by: Wayne Boyer
---
drivers/gpu/drm/i915/intel_fbdev.c | 15 +++
1 file changed, 15 insertions(+)
diff --git
mutex
for all aux channel communication is not recommended.
Cc: Rodrigo Vivi
Signed-off-by: Wayne Boyer
---
drivers/gpu/drm/i915/i915_drv.h | 1 +
drivers/gpu/drm/i915/i915_reg.h | 5
drivers/gpu/drm/i915/intel_dp.c | 52 -
3 files changed, 57
the sink crc request based
on feedback from the H/W designers indicating that using the mutex
for all aux channel communication is not recommended.
v2: Improved commit message to explain the case where the HW mutex is
helpful. Also added bug reference.
Signed-off-by: Wayne Boyer
Bugzilla: https
in commit message.
Signed-off-by: Wayne Boyer
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=91437
Reviewed-by: Rodrigo Vivi
Tested-by: Rodrigo Vivi
---
drivers/gpu/drm/i915/i915_drv.h | 1 +
drivers/gpu/drm/i915/i915_reg.h | 5
drivers/gpu/drm/i915/intel
Add the Kabylake GT4 PCI IDs as defined in this kernel patch.
commit 8b10c0cf21ec84618d4bf02c73c0543500ece68d
Author: Deepak S
Date: Wed Oct 28 12:21:12 2015 -0700
drm/i915/kbl: Add Kabylake GT4 PCI ID
Signed-off-by: Wayne Boyer
---
lib/intel_chipset.h | 12
Remove the KBL check from IS_SKYLAKE() following the kernel definition.
Then, add the KBL check to IS_GEN9().
The idea is to avoid confusion. On the kernel side, the mix of SKY
and KBL was nacked so the platforms are split.
Signed-off-by: Wayne Boyer
---
lib/intel_chipset.h | 7 ---
1
;t warn if the workaround list is empty.
Cc: Rodrigo Vivi
Signed-off-by: Wayne Boyer
---
drivers/gpu/drm/i915/intel_lrc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/intel_lrc.c b/drivers/gpu/drm/i915/intel_lrc.c
index 06180dc..b46e6af 100644
--- a/d
2015 -0700
drm/i915/kbl: Add Kabylake GT4 PCI ID
Cc: Rodrigo Vivi
Cc: Chris Wilson
Signed-off-by: Wayne Boyer
---
src/i915_pciids.h | 36
src/intel_module.c | 6 ++
2 files changed, 42 insertions(+)
diff --git a/src/i915_pciids.h b/src
w these registers and settings work after version 12.
Bspec: 45921, 45858, 45863
Cc: Joonas Lahtinen
Cc: Jordan Justen
Cc: Lionel Landwerlin
Suggested-by: Joonas Lahtinen
Signed-off-by: Matt Roper
Reviewed-by: Wayne Boyer
---
drivers/gpu/drm/i915/gt/intel_workarounds.c | 58
: Aravind Iddamsetty
Reviewed-by: Caz Yokoyama
Signed-off-by: Lucas De Marchi
Reviewed-by: Wayne Boyer
diff --git a/drivers/gpu/drm/i915/gem/i915_gem_stolen.c
b/drivers/gpu/drm/i915/gem/i915_gem_stolen.c
index acc561c0f0aa..3665f9b035bb 100644
--- a/drivers/gpu/drm/i915/gem/i915_gem_stolen.c
+* Make sure we don't clobber the GTT if it's within stolen memory
+*
* TODO: We have yet too encounter the case where the GTT wasn't at the
nit: as long as you're updating this comment block, s/too/to/
Otherwise,
Reviewed-by: Wayne Boyer
└─renderD128
drm:/dev/dri/renderD128
Signed-off-by: Lucas De Marchi
Reviewed-by: Wayne Boyer
diff --git a/drivers/gpu/drm/i915/gem/i915_gem_stolen.c
b/drivers/gpu/drm/i915/gem/i915_gem_stolen.c
index 6edf4e374f54..c5a4035c99cd 100644
--- a/drivers/gpu
As per the performance tuning guide, set the HOSTCACHEEN bit to
implement the recommended caching policy on PVC.
Signed-off-by: Wayne Boyer
---
drivers/gpu/drm/i915/gt/intel_gt_regs.h | 1 +
drivers/gpu/drm/i915/gt/intel_workarounds.c | 1 +
2 files changed, 2 insertions(+)
diff --git a
k_111491v1/shard-iclb1/igt@kms_psr2...@overlay-plane-move-continuous-exceed-fully-sf.html>
> (i915#658 <https://gitlab.freedesktop.org/drm/intel/issues/658>)
> *
>
> igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area:
>
> o shard-iclb: SKIP
>
> <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12456/shard-iclb2/igt@kms_psr2...@overlay-primary-update-sf-dmg-area.html>
> (i915#2920 <https://gitlab.freedesktop.org/drm/intel/issues/2920>) -> SKIP
> <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111491v1/shard-iclb7/igt@kms_psr2...@overlay-primary-update-sf-dmg-area.html>
> (fdo#111068 <https://bugs.freedesktop.org/show_bug.cgi?id=111068> / i915#658
> <https://gitlab.freedesktop.org/drm/intel/issues/658>)
> *
>
> igt@kms_psr2_sf@plane-move-sf-dmg-area:
>
> o shard-iclb: SKIP
>
> <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12456/shard-iclb1/igt@kms_psr2...@plane-move-sf-dmg-area.html>
> (fdo#111068 <https://bugs.freedesktop.org/show_bug.cgi?id=111068> / i915#658
> <https://gitlab.freedesktop.org/drm/intel/issues/658>) -> SKIP
> <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111491v1/shard-iclb2/igt@kms_psr2...@plane-move-sf-dmg-area.html>
> (i915#2920 <https://gitlab.freedesktop.org/drm/intel/issues/2920>)
> *
>
> igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-big-fb:
>
> o shard-iclb: SKIP
>
> <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12456/shard-iclb1/igt@kms_psr2...@primary-plane-update-sf-dmg-area-big-fb.html>
> (i915#658 <https://gitlab.freedesktop.org/drm/intel/issues/658>) -> SKIP
> <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111491v1/shard-iclb2/igt@kms_psr2...@primary-plane-update-sf-dmg-area-big-fb.html>
> (i915#2920 <https://gitlab.freedesktop.org/drm/intel/issues/2920>)
> *
>
> igt@runner@aborted:
>
> o shard-apl: (FAIL
>
> <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12456/shard-apl2/igt@run...@aborted.html>,
> FAIL
> <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12456/shard-apl3/igt@run...@aborted.html>,
> FAIL
> <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12456/shard-apl1/igt@run...@aborted.html>)
> (fdo#109271 <https://bugs.freedesktop.org/show_bug.cgi?id=109271> /
> i915#3002 <https://gitlab.freedesktop.org/drm/intel/issues/3002> / i915#4312
> <https://gitlab.freedesktop.org/drm/intel/issues/4312>) -> (FAIL
> <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111491v1/shard-apl8/igt@run...@aborted.html>,
> FAIL
> <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111491v1/shard-apl6/igt@run...@aborted.html>,
> FAIL
> <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111491v1/shard-apl6/igt@run...@aborted.html>,
> FAIL
> <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111491v1/shard-apl1/igt@run...@aborted.html>)
> (fdo#109271 <https://bugs.freedesktop.org/show_bug.cgi?id=109271> / i915#180
> <https://gitlab.freedesktop.org/drm/intel/issues/180> / i915#3002
> <https://gitlab.freedesktop.org/drm/intel/issues/3002> / i915#4312
> <https://gitlab.freedesktop.org/drm/intel/issues/4312>)
>
> {name}: This element is suppressed. This means it is ignored when computing
> the status of the difference (SUCCESS, WARNING, or FAILURE).
>
>
> Build changes
>
> * Linux: CI_DRM_12456 -> Patchwork_111491v1
>
> CI-20190529: 20190529
> CI_DRM_12456: 7a3c5315507ed0f4a9b0aa07ce6df1b3d28ebc35 @
> git://anongit.freedesktop.org/gfx-ci/linux
> IGT_7076: 888725538e0d6bbb941ac278d4afcbbbdad0 @
> https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
> Patchwork_111491v1: 7a3c5315507ed0f4a9b0aa07ce6df1b3d28ebc35 @
> git://anongit.freedesktop.org/gfx-ci/linux
> piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @
> git://anongit.freedesktop.org/piglit
>
--
Wayne Boyer
Graphics Software Engineer
AXG SCSS Platform Enablement
+ Sai Nandan as Lakshmi is out of the office.
On 12/1/22 7:13 AM, Wayne Boyer wrote:
> The failures below appear to be unrelated to my change which is
> restricted to PVC.
>
> On 12/1/22 12:59 AM, Patchwork wrote:
>> *Patch Details*
>> *Series:*drm/i915/pvc: Imple
WA 18017747507 applies to all DG2 skus.
BSpec: 56035, 46121, 68173
Signed-off-by: Wayne Boyer
---
drivers/gpu/drm/i915/gt/intel_gt_regs.h | 3 +++
drivers/gpu/drm/i915/gt/intel_workarounds.c | 3 +++
2 files changed, 6 insertions(+)
diff --git a/drivers/gpu/drm/i915/gt/intel_gt_regs.h
b
hard-iclb: SKIP
>
> <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12325/shard-iclb2/igt@kms_psr2...@cursor-plane-move-continuous-sf.html>
> (i915#2920 <https://gitlab.freedesktop.org/drm/intel/issues/2920>) -> SKIP
> <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110323v1/shard-iclb3/igt@kms_psr2...@cursor-plane-move-continuous-sf.html>
> (i915#658 <https://gitlab.freedesktop.org/drm/intel/issues/658>)
> *
>
> igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-big-fb:
>
> o shard-iclb: SKIP
>
> <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12325/shard-iclb1/igt@kms_psr2...@primary-plane-update-sf-dmg-area-big-fb.html>
> (i915#658 <https://gitlab.freedesktop.org/drm/intel/issues/658>) -> SKIP
> <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110323v1/shard-iclb2/igt@kms_psr2...@primary-plane-update-sf-dmg-area-big-fb.html>
> (i915#2920 <https://gitlab.freedesktop.org/drm/intel/issues/2920>)
> *
>
> igt@runner@aborted:
>
> o
>
> shard-apl: (FAIL
>
> <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12325/shard-apl6/igt@run...@aborted.html>,
> FAIL
> <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12325/shard-apl6/igt@run...@aborted.html>,
> FAIL
> <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12325/shard-apl2/igt@run...@aborted.html>,
> FAIL
> <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12325/shard-apl7/igt@run...@aborted.html>)
> (fdo#109271 <https://bugs.freedesktop.org/show_bug.cgi?id=109271> /
> i915#3002 <https://gitlab.freedesktop.org/drm/intel/issues/3002> / i915#4312
> <https://gitlab.freedesktop.org/drm/intel/issues/4312>) -> (FAIL
> <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110323v1/shard-apl8/igt@run...@aborted.html>,
> FAIL
> <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110323v1/shard-apl2/igt@run...@aborted.html>)
> (i915#3002 <https://gitlab.freedesktop.org/drm/intel/issues/3002> /
> i915#4312 <https://gitlab.freedesktop.org/drm/intel/issues/4312>)
>
> o
>
> shard-skl: (FAIL
>
> <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12325/shard-skl10/igt@run...@aborted.html>,
> FAIL
> <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12325/shard-skl4/igt@run...@aborted.html>)
> (i915#3002 <https://gitlab.freedesktop.org/drm/intel/issues/3002> /
> i915#4312 <https://gitlab.freedesktop.org/drm/intel/issues/4312>) -> (FAIL
> <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110323v1/shard-skl3/igt@run...@aborted.html>,
> FAIL
> <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110323v1/shard-skl10/igt@run...@aborted.html>,
> FAIL
> <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110323v1/shard-skl9/igt@run...@aborted.html>,
> FAIL
> <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110323v1/shard-skl5/igt@run...@aborted.html>)
> (i915#3002 <https://gitlab.freedesktop.org/drm/intel/issues/3002> /
> i915#4312 <https://gitlab.freedesktop.org/drm/intel/issues/4312> / i915#6949
> <https://gitlab.freedesktop.org/drm/intel/issues/6949>)
>
> {name}: This element is suppressed. This means it is ignored when computing
> the status of the difference (SUCCESS, WARNING, or FAILURE).
>
>
> Build changes
>
> * Linux: CI_DRM_12325 -> Patchwork_110323v1
>
> CI-20190529: 20190529
> CI_DRM_12325: 1a90222aa5e5bb86ffcbde5ba9611659a23f0df6 @
> git://anongit.freedesktop.org/gfx-ci/linux
> IGT_7032: 372c56225e12578a7a4a6bcc5b79eb40b643fcde @
> https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
> Patchwork_110323v1: 1a90222aa5e5bb86ffcbde5ba9611659a23f0df6 @
> git://anongit.freedesktop.org/gfx-ci/linux
> piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @
> git://anongit.freedesktop.org/piglit
>
--
Wayne Boyer
Graphics Software Engineer
AXG SCSS Platform Enablement
On 10/25/22 11:03 AM, Matt Atwood wrote:
> Wa_18018764978 applies to specific steppings of DG2 (G11 C0+,
> G11 and G12 A0+).
>
> Bspec: 66622
>
> Signed-off-by: Matt Atwood
With fixups to commit messages as mentioned by Gustavo,
Reviewed-by: Wayne Boyer
> ---
>
36 matches
Mail list logo
