Re: [Intel-gfx] [PATCH 2/5] drm/i915: check dri root before debugfs init

2021-10-12 Thread Wang, Zhi A
On 10/8/21 9:17 AM, Nirmoy Das wrote: > Return early if dri minor root dentry is NULL. > > CC: Zhenyu Wang > CC: Zhi Wang > CC: Jani Nikula > CC: Joonas Lahtinen > CC: Rodrigo Vivi > CC: David Airlie > CC: Daniel Vetter > Signed-off-by: Nirmoy Das > --- > drivers/gpu/drm/i915/gvt/debugfs

Re: [Intel-gfx] [PATCH] drm/i915/gvt: clean up kernel-doc in gtt.c

2021-10-12 Thread Wang, Zhi A
On 10/3/21 5:23 AM, Randy Dunlap wrote: > Fix kernel-doc warnings in gtt.c: > > gtt.c:1152: warning: This comment starts with '/**', but isn't a kernel-doc > comment. Refer Documentation/doc-guide/kernel-doc.rst > * Check if can do 2M page > gtt.c:1152: warning: missing initial short descriptio

Re: [Intel-gfx] refactor the i915 GVT support

2021-09-28 Thread Wang, Zhi A
Hey guys: After some investigation, I found the root cause this problem ("i915" module loading will be stuck with Christoph's refactor patches), which can be reproduced by building both i915 and kvmgt as kernel module and the loading i915. The root cause is: in Linux kernel loading, before a k

Re: [Intel-gfx] refactor the i915 GVT support

2021-09-28 Thread Wang, Zhi A
On 9/28/21 2:00 PM, Luis Chamberlain wrote: > On Tue, Sep 28, 2021 at 07:41:00AM +0000, Wang, Zhi A wrote: >> Hey guys: >> >> After some investigation, I found the root cause this problem ("i915" >> module loading will be stuck with Christoph's refact

Re: [Intel-gfx] refactor the i915 GVT support

2021-09-29 Thread Wang, Zhi A
On 9/28/21 3:05 PM, Jason Gunthorpe wrote: > On Tue, Sep 28, 2021 at 02:35:06PM +0000, Wang, Zhi A wrote: > >> Yes. I was thinking of the possibility of putting off some work later so >> that we don't need to make a lot of changes. GVT-g needs to take a >> snapshot of

Re: [Intel-gfx] refactor the i915 GVT support

2021-10-01 Thread Wang, Zhi A
On 9/29/21 6:55 PM, Jason Gunthorpe wrote: > On Wed, Sep 29, 2021 at 06:27:16PM +0000, Wang, Zhi A wrote: >> On 9/28/21 3:05 PM, Jason Gunthorpe wrote: >>> On Tue, Sep 28, 2021 at 02:35:06PM +, Wang, Zhi A wrote: >>> >>>> Yes. I was thinking of the possib

Re: [Intel-gfx] refactor the i915 GVT support

2021-10-05 Thread Wang, Zhi A
e can continue our development and pull-request to upstream. Thanks so much for the patch and the discussion. Thanks, Zhi. On 10/1/21 1:01 PM, Wang, Zhi A wrote: > On 9/29/21 6:55 PM, Jason Gunthorpe wrote: >> On Wed, Sep 29, 2021 at 06:27:16PM +0000, Wang, Zhi A wrote: >>> On

Re: [Intel-gfx] refactor the i915 GVT support

2021-07-22 Thread Wang, Zhi A
was thinking is to put a document about the background and more description in the MPT headers. So it won't confuse more people. Feel free to drop more comments. 😊 Thanks, Zhi. -Original Message- From: Christoph Hellwig Sent: Wednesday, July 21, 2021 6:54 PM To: Jani Nikula

Re: [Intel-gfx] refactor the i915 GVT support

2021-07-28 Thread Wang, Zhi A
there is only one MPT module. Thanks so much for the comments. Thanks, Zhi. -Original Message- From: Jason Gunthorpe Sent: Tuesday, July 27, 2021 3:12 PM To: Gerd Hoffmann Cc: Wang, Zhi A ; Christoph Hellwig ; Jani Nikula ; Joonas Lahtinen ; Vivi, Rodrigo ; Zh

Re: [Intel-gfx] refactor the i915 GVT support

2021-07-29 Thread Wang, Zhi A
On 7/28/2021 8:59 PM, Jason Gunthorpe wrote: > On Wed, Jul 28, 2021 at 01:38:58PM +0000, Wang, Zhi A wrote: > >> I guess those APIs you were talking about are KVM-only. For other >> hypervisors, e.g. Xen, ARCN cannot use the APIs you mentioned. Not >> sure if you have alre

Re: [Intel-gfx] [PATCH 2/9] drm/i915/gvt: Constify intel_gvt_gtt_pte_ops

2021-12-10 Thread Wang, Zhi A
On 12/4/2021 12:55 PM, Rikard Falkeborn wrote: > These are never modified, so make them const to allow the compiler to > put them in read-only memory. > > Signed-off-by: Rikard Falkeborn > --- > drivers/gpu/drm/i915/gvt/gtt.c | 62 +- > drivers/gpu/drm/i915/gvt/g

Re: [Intel-gfx] [PATCH 3/9] drm/i915/gvt: Constify intel_gvt_irq_ops

2021-12-10 Thread Wang, Zhi A
On 12/4/2021 12:55 PM, Rikard Falkeborn wrote: > These are never modified, so make them const to allow the compiler to > put them in read-only memory. > > Signed-off-by: Rikard Falkeborn > --- > drivers/gpu/drm/i915/gvt/interrupt.c | 10 +- > drivers/gpu/drm/i915/gvt/interrupt.h | 2 +-

Re: [Intel-gfx] [PATCH 4/9] drm/i915/gvt: Constify intel_gvt_sched_policy_ops

2021-12-10 Thread Wang, Zhi A
On 12/4/2021 12:55 PM, Rikard Falkeborn wrote: > These are never modified, so make them const to allow the compiler to > put them in read-only memory. > > Signed-off-by: Rikard Falkeborn > --- > drivers/gpu/drm/i915/gvt/sched_policy.c | 2 +- > drivers/gpu/drm/i915/gvt/scheduler.h| 2 +- >

Re: [Intel-gfx] [PATCH 5/9] drm/i915/gvt: Constify gvt_mmio_block

2021-12-10 Thread Wang, Zhi A
On 12/4/2021 12:55 PM, Rikard Falkeborn wrote: > These are never modified, so make them const to allow the compiler to > put it in read-only memory. > > Signed-off-by: Rikard Falkeborn > --- > drivers/gpu/drm/i915/gvt/gvt.h | 2 +- > drivers/gpu/drm/i915/gvt/handlers.c | 12 ++-- >

Re: [Intel-gfx] [PATCH 6/9] drm/i915/gvt: Constify cmd_interrupt_events

2021-12-10 Thread Wang, Zhi A
On 12/4/2021 12:55 PM, Rikard Falkeborn wrote: > It is never modified, so make it const to allow the compiler to put it > in read-only memory. > > Signed-off-by: Rikard Falkeborn > --- > drivers/gpu/drm/i915/gvt/cmd_parser.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

Re: [Intel-gfx] [PATCH 7/9] drm/i915/gvt: Constify formats

2021-12-10 Thread Wang, Zhi A
On 12/4/2021 12:55 PM, Rikard Falkeborn wrote: > These are never modified, so make them const to allow the compiler to > put them in read-only memory. WHile at it, make the description const > char* since it is never modified. > > Signed-off-by: Rikard Falkeborn > --- > drivers/gpu/drm/i915/gvt/

Re: [Intel-gfx] [PATCH 8/9] drm/i915/gvt: Constify gtt_type_table_entry

2021-12-10 Thread Wang, Zhi A
On 12/4/2021 12:55 PM, Rikard Falkeborn wrote: > It is never modified, so make it const to allow the compiler to put it > in read-only memory. > > Signed-off-by: Rikard Falkeborn > --- > drivers/gpu/drm/i915/gvt/gtt.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/driv

Re: [Intel-gfx] [PATCH 9/9] drm/i915/gvt: Constify vgpu_types

2021-12-10 Thread Wang, Zhi A
On 12/4/2021 12:55 PM, Rikard Falkeborn wrote: > It is never modified, so make it const to allow the compiler to put it > in read-only memory. While at it, make name a const char*. > > Signed-off-by: Rikard Falkeborn > --- > drivers/gpu/drm/i915/gvt/vgpu.c | 4 ++-- > 1 file changed, 2 insertio

Re: [Intel-gfx] [PATCH 1/9] drm/i915/gvt: Constify intel_gvt_gtt_pte_ops

2021-12-10 Thread Wang, Zhi A
On 12/4/2021 12:55 PM, Rikard Falkeborn wrote: > These are never modified, so make them const to allow the compiler to > put them in read-only memory. > > Signed-off-by: Rikard Falkeborn > --- > drivers/gpu/drm/i915/gvt/gtt.c | 4 ++-- > drivers/gpu/drm/i915/gvt/gtt.h | 2 +- > 2 files changed

Re: [Intel-gfx] [PATCH 0/9] drm/i915/gvt: Constify static structs

2021-12-10 Thread Wang, Zhi A
On 12/4/2021 12:55 PM, Rikard Falkeborn wrote: > Constify a number of static structs that are never modified to allow the > compiler to put them in read-only memory. In order to do this, constify a > number of local variables and pointers in structs. > > This is most important for structs that cont

Re: [Intel-gfx] [PATCH 0/9] drm/i915/gvt: Constify static structs

2021-12-16 Thread Wang, Zhi A
On 12/12/2021 3:25 PM, Rikard Falkeborn worte: > On Fri, Dec 10, 2021 at 09:00:56AM +0000, Wang, Zhi A wrote: >> On 12/4/2021 12:55 PM, Rikard Falkeborn wrote: >>> Constify a number of static structs that are never modified to allow the >>> compiler to put them in read-

Re: [Intel-gfx] [PATCH v4 1/2] i915/gvt: Introduce the mmio_info_table.c to support VFIO new mdev API

2021-12-17 Thread Wang, Zhi A
On 11/30/2021 6:46 PM, Christoph Hellwig wrote: > I still think this goes into the wrong direction. > > Something closer to your first version that also saves away the > gvt->mmio.mmio_attribute flags in the core i915 module, and which > splits the MMIO table into one that contains just the offset,

[Intel-gfx] [GIT PULL] GVT next changes for drm-intel-next-queued

2022-01-07 Thread Wang, Zhi A
Hi folks: Happy holidays! This pull mostly contains the code re-factors patches from Guenter Roeck and Rikard. Also a minor change from Zhenyu. Zhi The following changes since commit 3bfa7d40ce736ffbbfe07127061f54b359ee2b12:   drm/i915/dg2: Add support for new DG2-G11 revid 0x5 (2021-08-06 0

Re: [Intel-gfx] [GIT PULL] GVT next changes for drm-intel-next-queued

2022-01-10 Thread Wang, Zhi A
On 1/11/2022 12:52 AM, Vivi, Rodrigo wrote: > On Fri, 2022-01-07 at 14:43 +0000, Wang, Zhi A wrote: >> Hi folks: >> >> Happy holidays! This pull mostly contains the code re-factors patches >> from Guenter Roeck and Rikard. Also a minor change from Zhenyu. >> &

Re: [Intel-gfx] [GIT PULL] GVT next changes for drm-intel-next-queued

2022-01-11 Thread Wang, Zhi A
On 1/11/22 6:08 AM, Wang, Zhi A wrote: > On 1/11/2022 12:52 AM, Vivi, Rodrigo wrote: >> On Fri, 2022-01-07 at 14:43 +0000, Wang, Zhi A wrote: >>> Hi folks: >>> >>> Happy holidays! This pull mostly contains the code re-factors patches >>> from Guent

[Intel-gfx] [GIT PULL RESEND] GVT next changes for drm-intel-next-queued

2022-01-11 Thread Wang, Zhi A
Hi folks: Happy holidays! This pull mostly contains the code re-factors patches from Guenter Roeck and Rikard. Also a minor change from Zhenyu. v2: - Fix the problem of message body encoding in Thunderbird. The following changes since commit 3bfa7d40ce736ffbbfe07127061f54b359ee2b12: drm/i91

Re: [Intel-gfx] [PATCH] drm/i915/gvt: Make DRM_I915_GVT depend on X86

2022-01-11 Thread Wang, Zhi A
On 1/7/22 9:52 AM, Mullati Siva wrote: > From: Siva Mullati > > GVT is not supported on non-x86 platforms, So add > dependency of X86 on config parameter DRM_I915_GVT. > > Signed-off-by: Siva Mullati > --- > drivers/gpu/drm/i915/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a

[Intel-gfx] [GIT PULL RESEND] GVT next changes for drm-intel-next-queued

2022-01-11 Thread Wang, Zhi A
Hi folks: Happy holidays! This pull mostly contains the code re-factors patches from Guenter Roeck and Rikard. Also a minor change from Zhenyu. v3: - Merge drm-intel-next-2021-12-14 into gvt-next v2: - Fix the problem of message body encoding in Thunderbird. The following changes since commi

Re: [Intel-gfx] [GIT PULL] GVT next changes for drm-intel-next-queued

2022-01-11 Thread Wang, Zhi A
On 1/11/22 2:40 PM, Vivi, Rodrigo wrote: > On Tue, Jan 11, 2022 at 06:08:28AM -0500, Wang, Zhi A wrote: >> On 1/11/22 6:08 AM, Wang, Zhi A wrote: >>> On 1/11/2022 12:52 AM, Vivi, Rodrigo wrote: >>>> On Fri, 2022-01-07 at 14:43 +, Wang, Zhi A wrote: >>>

Re: [Intel-gfx] [PATCH v6 1/3] i915/gvt: Introduce the mmio table to support VFIO new mdev API

2022-03-15 Thread Wang, Zhi A
I was actually testing it for almost two weeks, but still I met some hang and I was trying to figure where the problem is as this is quite a big change. Let's see if I can figure it out this week. Thanks, Zhi. On 3/15/22 8:48 AM, Christoph Hellwig wrote: > On Tue, Mar 15, 2022 at 10:46:53AM +02

Re: [Intel-gfx] [PATCH] drm/i915/reg: Fix spelling mistake "Unsupport" -> "Unsupported"

2022-03-21 Thread Wang, Zhi A
Thanks for the contribution, Colin. Queued. On 3/15/22 8:24 PM, Colin Ian King wrote: > There is a spelling mistake in a gvt_vgpu_err error message. Fix it. > > Signed-off-by: Colin Ian King > --- > drivers/gpu/drm/i915/gvt/handlers.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >

Re: [Intel-gfx] [PATCH v7 1/3] i915/gvt: Separate the MMIO tracking table from GVT-g

2022-03-31 Thread Wang, Zhi A
Hi Jani and Joonas: Are you OK with these patches? I noticed I need to change the license of the new file. Will do that when check-in if you are OK with these. Thanks, Zhi. On 3/28/22 6:50 AM, Christoph Hellwig wrote: > On Fri, Mar 25, 2022 at 01:52:49PM -0400, Zhi Wang wrote: >> >> v7: >> >> -

Re: [Intel-gfx] [PATCH v7 1/3] i915/gvt: Separate the MMIO tracking table from GVT-g

2022-03-31 Thread Wang, Zhi A
Hi Chris: Thanks for the testing. Can you attach the dmesg? I tested mostly on my skylake desktop with some 3D workload. Thanks, Zhi. On 3/31/22 7:42 AM, Christoph Hellwig wrote: > On Thu, Mar 31, 2022 at 07:11:07AM +0000, Wang, Zhi A wrote: >> Hi Jani and Joonas: >> >>

Re: [Intel-gfx] [PATCH v7 1/3] i915/gvt: Separate the MMIO tracking table from GVT-g

2022-04-01 Thread Wang, Zhi A
Hi Jani: Thanks so much for the guidance. :) I included it in the v8 patch. :) Thanks, Zhi. On 3/31/22 8:25 AM, Jani Nikula wrote: > On Thu, 31 Mar 2022, "Wang, Zhi A" wrote: >> Hi Jani and Joonas: >> >> Are you OK with these patches? I noticed I need to change

Re: [Intel-gfx] [PATCH v4 5/7] drm/i915/gvt: Change from vfio_group_(un)pin_pages to vfio_(un)pin_pages

2022-05-11 Thread Wang, Zhi A
On 5/6/22 12:08 AM, Jason Gunthorpe wrote: > Use the existing vfio_device versions of vfio_(un)pin_pages(). There is no > reason to use a group interface here, kvmgt has easy access to a > vfio_device. > > Delete kvmgt_vdev::vfio_group since these calls were the last users. > > Reviewed-by: Kevin

Re: [Intel-gfx] [PATCH v3 1/1] vfio: remove VFIO_GROUP_NOTIFY_SET_KVM

2022-05-24 Thread Wang, Zhi A
On 5/23/22 4:41 PM, Alex Williamson wrote: > > Hi Zhi & Zhenyu, > > Please review gvt changes below, I'd prefer to get your ack included. > Thanks! > > Alex > > On Thu, 19 May 2022 14:33:11 -0400 > Matthew Rosato wrote: > >> Rather than relying on a notifier for associating the KVM with >> th

Re: [Intel-gfx] [PATCH v9 1/3] i915/gvt: Separate the MMIO tracking table from GVT-g

2022-04-07 Thread Wang, Zhi A
Thanks so much! Jani and Joonas, it would be better to have one rb from i915 maintainers as this patches also modify i915 code. Thanks, Zhi. On 4/7/22 8:06 AM, Christoph Hellwig wrote: > The whole series looks good and works fine on by Kaby Lake Thinkpad: > > Reviewed-by: Christoph Hellwig >

Re: [Intel-gfx] [PATCH v9 1/3] i915/gvt: Separate the MMIO tracking table from GVT-g

2022-04-08 Thread Wang, Zhi A
Hi Jani: Thanks so much for the help. Can you generate a new tag on drm-intel-next? I noticed that there was one patch moving the DMC related registers into display/intel_dmc_regs.h, which is not included in the latest tag on drm-intel-next. Guess it would be better that I can change this patc

Re: [Intel-gfx] [PATCH v9 1/3] i915/gvt: Separate the MMIO tracking table from GVT-g

2022-04-11 Thread Wang, Zhi A
Ping. :) On 4/8/22 2:07 PM, Zhi Wang wrote: > Hi Jani: > > Thanks so much for the help. Can you generate a new tag on drm-intel-next? I > noticed that there was one patch moving the DMC related registers into > display/intel_dmc_regs.h, which is not included in the latest tag on > drm-intel-ne

Re: [Intel-gfx] [PATCH v9 1/3] i915/gvt: Separate the MMIO tracking table from GVT-g

2022-04-13 Thread Wang, Zhi A
my pull request not based on a tag in drm-intel-next, just the latest drm-intel-next? Thanks, Zhi. On 4/13/22 9:31 AM, Jani Nikula wrote: > On Fri, 08 Apr 2022, "Wang, Zhi A" wrote: >> Hi Jani: >> >> Thanks so much for the help. Can you generate a new tag on &g

Re: [Intel-gfx] [PATCH 05/34] drm/i915/gvt: cleanup the Makefile

2022-04-13 Thread Wang, Zhi A
On 4/13/22 12:33 PM, Jani Nikula wrote: > On Mon, 11 Apr 2022, Christoph Hellwig wrote: >> On Mon, Apr 11, 2022 at 07:11:03PM +0300, Jani Nikula wrote: Up to you but I usually sort these lists >>> >>> Yeah, please do. Otherwise matches what I sent, so ack. >> >> Let's just merge your 2 patch

Re: [Intel-gfx] [PATCH 0/2] drm/i915/gvt: clean up makefile

2022-04-13 Thread Wang, Zhi A
On 4/13/22 12:25 PM, Jani Nikula wrote: > This is [1] rebased on gvt-next. (Which means it won't build on CI.) > > BR, > Jani. > > > [1] https://patchwork.freedesktop.org/series/102003/ > > > Cc: Zhi Wang > Cc: Christoph Hellwig > > > Jani Nikula (2): > drm/i915/gvt: fix trace TRACE_INCL

Re: [Intel-gfx] refactor the i915 GVT support and move to the modern mdev API v3

2022-04-13 Thread Wang, Zhi A
On 4/11/22 2:13 PM, Christoph Hellwig wrote: > Hi all, > > the GVT code in the i915 is a bit of a mess right now due to strange > abstractions and lots of indirect calls. This series refactors various > bits to clean that up. The main user visible change is that almost all > of the GVT code move

Re: [Intel-gfx] [PATCH 05/34] drm/i915/gvt: cleanup the Makefile

2022-04-13 Thread Wang, Zhi A
On 4/13/22 1:43 PM, Jason Gunthorpe wrote: > On Wed, Apr 13, 2022 at 01:39:35PM +0000, Wang, Zhi A wrote: > >> It seems Jani's makefile clean patch has already included this one, I can >> just simply drop this one so that Christoph won't need to re-send everything. >

Re: [Intel-gfx] [PATCH 1/9] vfio: Make vfio_(un)register_notifier accept a vfio_device

2022-04-13 Thread Wang, Zhi A
On 4/13/22 5:37 PM, Jason Gunthorpe wrote: > On Wed, Apr 13, 2022 at 06:29:46PM +0200, Christoph Hellwig wrote: >> On Wed, Apr 13, 2022 at 01:18:14PM -0300, Jason Gunthorpe wrote: >>> Yeah, I was thinking about that too, but on the other hand I think it >>> is completely wrong that gvt requires kvm

Re: [Intel-gfx] [PATCH 1/9] vfio: Make vfio_(un)register_notifier accept a vfio_device

2022-04-13 Thread Wang, Zhi A
On 4/13/22 8:04 PM, Jason Gunthorpe wrote: > On Wed, Apr 13, 2022 at 07:17:52PM +0000, Wang, Zhi A wrote: >> On 4/13/22 5:37 PM, Jason Gunthorpe wrote: >>> On Wed, Apr 13, 2022 at 06:29:46PM +0200, Christoph Hellwig wrote: >>>> On Wed, Apr 13, 2022 at 01:18:14P

Re: [Intel-gfx] refactor the i915 GVT support and move to the modern mdev API v3

2022-04-13 Thread Wang, Zhi A
Apr 2022, Christoph Hellwig wrote: >> On Wed, Apr 13, 2022 at 01:47:05PM +0000, Wang, Zhi A wrote: >>>> the GVT code in the i915 is a bit of a mess right now due to strange >>>> abstractions and lots of indirect calls. This series refactors various >>>> bits to cl

Re: [Intel-gfx] refactor the i915 GVT support and move to the modern mdev API v3

2022-04-14 Thread Wang, Zhi A
On 4/13/22 11:20 PM, Jason Gunthorpe wrote: > On Wed, Apr 13, 2022 at 11:13:06PM +0000, Wang, Zhi A wrote: >> Hi folks: >> >> Thanks so much for the efforts. I prepared a branch which contains all our >> patches.The aim of the branch is for the VFIO maintainers to pull

Re: [Intel-gfx] refactor the i915 GVT support and move to the modern mdev API v3

2022-04-14 Thread Wang, Zhi A
On 4/14/22 1:34 PM, Jason Gunthorpe wrote: > On Thu, Apr 14, 2022 at 12:20:42PM +0000, Wang, Zhi A wrote: >> On 4/13/22 11:20 PM, Jason Gunthorpe wrote: >>> On Wed, Apr 13, 2022 at 11:13:06PM +, Wang, Zhi A wrote: >>>> Hi folks: >>>> >>>&g

Re: [Intel-gfx] refactor the i915 GVT support and move to the modern mdev API v3

2022-04-14 Thread Wang, Zhi A
On 4/14/22 1:43 PM, Jason Gunthorpe wrote: > On Thu, Apr 14, 2022 at 04:40:11PM +0300, Jani Nikula wrote: > >> git clone https://github.com/intel/gvt-linux -b for-christoph > > There are alot of extra commits on there - is it possible to base this > straight on rc1 not on some kind

Re: [Intel-gfx] refactor the i915 GVT support and move to the modern mdev API v3

2022-04-20 Thread Wang, Zhi A
On 4/20/22 7:08 AM, Christoph Hellwig wrote: > On Thu, Apr 14, 2022 at 11:38:59AM -0300, Jason Gunthorpe wrote: >> pull requests can flow through more than one tree concurrently. The >> purpose of the topic branch is to allow all the commits to be in all >> the trees they need to be in at once. >>

[Intel-gfx] [PULL] gvt-next

2022-04-20 Thread Wang, Zhi A
Hi folks: Here is the PR of gvt-next. Mostly it includes the patch bundle of GVT-g re-factor patches for adapting the GVT-g with the new MDEV interfaces: - Separating the MMIO table from GVT-g. (Zhi) - GVT-g re-factor. (Christoph) - GVT-g mdev API cleanup. (Jason) - GVT-g trace/makefile cleanup

Re: [Intel-gfx] [PULL] gvt-next

2022-04-20 Thread Wang, Zhi A
On 4/20/22 12:13 PM, Jason Gunthorpe wrote: > On Wed, Apr 20, 2022 at 08:04:31AM +0000, Wang, Zhi A wrote: >> Hi folks: >> >> Here is the PR of gvt-next. >> >> Mostly it includes the patch bundle of GVT-g re-factor patches for adapting >> th

Re: [Intel-gfx] [PULL] gvt-next

2022-04-20 Thread Wang, Zhi A
On 4/20/22 3:02 PM, Jason Gunthorpe wrote: > On Wed, Apr 20, 2022 at 02:41:04PM +0000, Wang, Zhi A wrote: >> On 4/20/22 12:13 PM, Jason Gunthorpe wrote: >>> On Wed, Apr 20, 2022 at 08:04:31AM +, Wang, Zhi A wrote: >>>> Hi folks: >>>> >>&g

[Intel-gfx] [PULL v2] gvt-next

2022-04-20 Thread Wang, Zhi A
Hi folks: Here is the PR of gvt-next. Thanks so much for the patience. Mostly it includes the patch bundle of GVT-g re-factor patches for adapting the GVT-g with the new MDEV interfaces: - Separating the MMIO table from GVT-g. (Zhi) - GVT-g re-factor. (Christoph) - GVT-g mdev API cleanup. (Jaso

Re: [Intel-gfx] [PULL v2] gvt-next

2022-04-20 Thread Wang, Zhi A
gt;> On Wed, Apr 20, 2022 at 04:34:47PM +, Wang, Zhi A wrote: >>>>> Hi folks: >>>>> >>>>> Here is the PR of gvt-next. Thanks so much for the patience. >>>>> >>>>> Mostly it includes the patch bundle of GVT-g re-factor p

Re: [Intel-gfx] [PULL v2] gvt-next

2022-04-21 Thread Wang, Zhi A
On 4/21/22 1:14 PM, Jason Gunthorpe wrote: > On Thu, Apr 21, 2022 at 09:41:30AM +0300, Joonas Lahtinen wrote: >> + Tvrtko >> >> Quoting Christoph Hellwig (2022-04-21 08:47:38) >>> On Thu, Apr 21, 2022 at 04:57:34AM +, Wang, Zhi A wrote: >>>> Is it p

[Intel-gfx] [PULL v3] gvt-next

2022-04-21 Thread Wang, Zhi A
Hi folks: Here is the PR of gvt-next. Thanks so much for the patience. Mostly it includes the patch bundle of GVT-g re-factor patches for adapting the GVT-g with the new MDEV interfaces: - Separating the MMIO table from GVT-g. (Zhi) - GVT-g re-factor. (Christoph) - GVT-g mdev API cleanup. (Jaso

Re: [Intel-gfx] [PULL v3] gvt-next

2022-04-25 Thread Wang, Zhi A
On 4/25/22 12:33 PM, Jani Nikula wrote: > On Mon, 25 Apr 2022, Jani Nikula wrote: >> On Thu, 21 Apr 2022, "Wang, Zhi A" wrote: >>> Hi folks: >>> >>> Here is the PR of gvt-next. Thanks so much for the patience. >> >> Thanks, pull

Re: [Intel-gfx] [PATCH] drm/i915/gvt: Add missing symbol export.

2022-04-25 Thread Wang, Zhi A
On 4/25/22 10:03 PM, Zhi Wang wrote: > When CONFIG_DRM_I915_DEBUG_RUNTIME and CONFIG_DRM_I915_DEBUG_PM > are enabled, two more extra symols in i915 are required to be > exported. > > Cc: Jani Nikula > Signed-off-by: Zhi Wang > --- > drivers/gpu/drm/i915/intel_gvt.c | 2 ++ > 1 file changed, 2 i

[Intel-gfx] [PULL] gvt-next

2022-04-26 Thread Wang, Zhi A
Hi folks: Here is the pull of gvt-next which fixs the compilation error when i915 debug is open after the GVT-g refactor patches. Thanks so much for the efforts. Thanks, Zhi. The following changes since commit 2917f53113be3b7a0f374e02cebe6d6b749366b5: vfio/mdev: Remove mdev drvdata (2022-04-

[Intel-gfx] [PULL v2] gvt-next

2022-04-26 Thread Wang, Zhi A
Hi folks: I updated the branch again. Please use this pull. Here is the pull of gvt-next which fixes the compilation error when i915 debug is open after the GVT-g refactor patches. Thanks so much for the efforts. Thanks, Zhi. The following changes since commit 2917f53113be3b7a0f374e02cebe6d6b74

Re: [Intel-gfx] [PULL] gvt-next

2022-04-26 Thread Wang, Zhi A
On 4/26/22 8:37 AM, Jani Nikula wrote: > On Tue, 26 Apr 2022, "Wang, Zhi A" wrote: >> Hi folks: >> >> Here is the pull of gvt-next which fixs the compilation error when i915 debug >> is open after the GVT-g refactor patches. >> >> Thanks so m

Re: [Intel-gfx] [PULL] gvt-next

2022-04-26 Thread Wang, Zhi A
On 4/26/22 8:37 AM, Jani Nikula wrote: > On Tue, 26 Apr 2022, "Wang, Zhi A" wrote: >> Hi folks: >> >> Here is the pull of gvt-next which fixs the compilation error when i915 debug >> is open after the GVT-g refactor patches. >> >> Thanks so m

Re: [Intel-gfx] [PULL] gvt-next

2022-04-26 Thread Wang, Zhi A
On 4/26/22 3:53 PM, Jason Gunthorpe wrote: > On Tue, Apr 26, 2022 at 07:58:59AM +0000, Wang, Zhi A wrote: >> Hi folks: >> >> Here is the pull of gvt-next which fixs the compilation error when i915 debug >> is open after the GVT-g refactor patches. >> >> Thank

Re: [Intel-gfx] [PATCH 1/2] drm/i915/gvt: Fix missing static

2022-04-28 Thread Wang, Zhi A
On 4/28/22 8:40 PM, De Marchi, Lucas wrote: > Fix broken build: > > $ make W=1 drivers/gpu/drm/i915/gvt/handlers.o > ... > CC [M] drivers/gpu/drm/i915/gvt/handlers.o > drivers/gpu/drm/i915/gvt/handlers.c:75:6: error: no previous prototype > for ‘intel_gvt_match_device

[Intel-gfx] [PULL] gvt-next-2022-04-29

2022-04-28 Thread Wang, Zhi A
Hi folks: Here is the pull of gvt-next which fixes the compilation error and warnings for the the GVT-g refactor patches: - Fix a compiling warning of non-static function only having one caller. - Fix a potential NULL pointer reference in the code re-factor. - Fix a compiling error when CONFIG_D

Re: [Intel-gfx] refactor the i915 GVT support and move to the modern mdev API v2

2021-11-04 Thread Wang, Zhi A
he design opens in the re-factor patches wouldn’t block the process of mdev API improvement? Thanks, Zhi. -Original Message- From: Joonas Lahtinen Sent: Thursday, November 4, 2021 2:59 PM To: Christoph Hellwig ; Jani Nikula ; Vivi, Rodrigo ; Zhenyu Wang ; Wang, Zhi A Cc: Jason Guntho

Re: [Intel-gfx] [PATCH 1/3] i915/gvt: seperate tracked MMIO table from handlers.c

2021-11-09 Thread Wang, Zhi A
On 11/9/2021 12:58 PM, h...@lst.de wrote: > On Tue, Nov 09, 2021 at 10:51:27AM +0000, Wang, Zhi A wrote: >> Can you elaborate more about this? We need the hash query from the table >> ASAP when the hypervisor trapped a mmio access. It's a critical path and >> we tried d

Re: [Intel-gfx] [PATCH] drm/i915/gvt: #include drm_edid.h for drm_edid_block_valid()

2022-02-16 Thread Wang, Zhi A
On 2/15/22 12:20 PM, Nikula, Jani wrote: > As the excessive #includes from i915_drv.h were axed, kvmgt.c build > started failing. Add the necessary #include where needed. > > Reported-by: Stephen Rothwell > Fixes: 14da21cc4671 ("drm/i915: axe lots of unnecessary includes from > i915_drv.h") > Cc

[Intel-gfx] [GIT PULL] GVT next changes for drm-intel-next

2022-03-07 Thread Wang, Zhi A
Hi folks: Here is a new pull request of gvt-next. It contains a small patch to add the missing mdev attribute name, which will be used by the middleware, like kubevirt. This pull has been tested by: $ dim apply-pull drm-intel-next < this_email.eml The following changes since commit 30424ebae8d

Re: [Intel-gfx] [GIT PULL] GVT next changes for drm-intel-next

2022-03-08 Thread Wang, Zhi A
Which suits better for you? For me, I am OK with both. If you are not in a rush of closing the window, I can submit through drm-intel-next-fixes. Thanks, Zhi. On 3/8/22 9:56 AM, Nikula, Jani wrote: > On Tue, 08 Mar 2022, "Wang, Zhi A" wrote: >> Hi folks: >> >> He

Re: [Intel-gfx] [GIT PULL] GVT next changes for drm-intel-next

2022-03-08 Thread Wang, Zhi A
Hi Joonas: Thanks so much. Will do. :) Thanks, Zhi. On 3/8/22 3:19 PM, Joonas Lahtinen wrote: > Quoting Wang, Zhi A (2022-03-08 12:07:04) >> Which suits better for you? For me, I am OK with both. If you are not in a >> rush of closing the window, I can submit through drm-i

Re: [Intel-gfx] [GVT PULL] gvt-fixes for drm-intel-fixes

2022-02-09 Thread Wang, Zhi A
@lists.freedesktop.org; Wang, Zhi A Subject: [GVT PULL] gvt-fixes for drm-intel-fixes Hi folks: Here is the gvt-fixes pull for drm-intel-fixes. It contains: - Make DRM_I915_GVT depend on X86 (Siva Mullati) - Clean kernel doc in gtt.c (Randy Dunlap) This pull has been tested by: dim apply-pull drm-intel-fixes

Re: [Intel-gfx] [PATCH v6 2/3] i915/gvt: Save the initial HW state snapshot in i915

2022-02-09 Thread Wang, Zhi A
On 2/9/22 7:32 AM, Christoph Hellwig wrote: > On Tue, Feb 08, 2022 at 06:11:50AM -0500, Zhi Wang wrote: >> +struct drm_i915_private *dev_priv = iter->i915; >> +u32 *mmio, i; >> + >> +for (i = offset; i < offset + size; i += 4) { >> +mmio = iter->data + i; >> +*mm

Re: [Intel-gfx] [PATCH v6 1/3] i915/gvt: Introduce the mmio table to support VFIO new mdev API

2022-02-09 Thread Wang, Zhi A
On 2/9/22 7:28 AM, Christoph Hellwig wrote: > On Tue, Feb 08, 2022 at 05:15:00PM +0200, Jani Nikula wrote: >>> #ifdef CONFIG_DRM_I915_GVT >>> + >>> +#define D_BDW (1 << 0) >>> +#define D_SKL (1 << 1) >>> +#define D_KBL (1 << 2) >>> +#define D_BXT (1 << 3) >>> +#define D_CFL (

Re: [Intel-gfx] [PATCH v6 1/3] i915/gvt: Introduce the mmio table to support VFIO new mdev API

2022-02-09 Thread Wang, Zhi A
On 2/9/22 9:04 AM, Jani Nikula wrote: > On Wed, 09 Feb 2022, Christoph Hellwig wrote: >> On Tue, Feb 08, 2022 at 05:15:00PM +0200, Jani Nikula wrote: #ifdef CONFIG_DRM_I915_GVT + +#define D_BDW (1 << 0) +#define D_SKL (1 << 1) +#define D_KBL (1 << 2) +#defi

Re: [Intel-gfx] [GVT PULL] gvt-fixes for drm-intel-fixes

2022-02-10 Thread Wang, Zhi A
Feel free to let me know if I need to re-base on the newest tag since it has been quite some time. On 2/10/22 8:51 AM, Jani Nikula wrote: > > +Tvrtko > > On Wed, 09 Feb 2022, "Wang, Zhi A" wrote: >> Hi folks: >> >> Ping. This pull se

Re: [Intel-gfx] [PATCH 1/2] Revert "drm/i915: Introduce private PAT management"

2019-07-12 Thread Wang, Zhi A
, Zhi. -Original Message- From: Zhenyu Wang [mailto:zhen...@linux.intel.com] Sent: Friday, July 12, 2019 11:29 AM To: Joonas Lahtinen Cc: Winiarski, Michal ; Chris Wilson ; intel-gfx@lists.freedesktop.org; Zhenyu Wang ; Vivi, Rodrigo ; Wang, Zhi A Subject: Re: [PATCH 1/2] Revert &quo

Re: [Intel-gfx] [PULL] topic/gvt-ww-lock

2020-11-07 Thread Wang, Zhi A
: Wednesday, September 30, 2020 2:55 PM To: Wang, Zhi A ; Joonas Lahtinen ; Nikula, Jani ; intel-gfx ; Yuan, Hang ; Lv, Zhiyuan ; intel-gvt-dev Subject: Re: [Intel-gfx] [PULL] topic/gvt-ww-lock Hey, Op 22-09-2020 om 13:51 schreef Wang, Zhi A: > > Hi, > > Here's the patch which

[Intel-gfx] [PULL] topic/gvt-ww-lock

2020-09-22 Thread Wang, Zhi A
Hi, Here's the patch which introduces GVT-g ww lock support against drm-intel-gt-next branch. Thanks -- The following changes since commit 4316b19dee27cc5cd34a95fdbc0a3a5237507701:   drm/i915: Fix uninitialised variable in intel_context_create_request. (2020-09-21 11:09:46 +0200) are av

Re: [Intel-gfx] [PULL] gvt-next for 4.18

2018-05-14 Thread Wang, Zhi A
Thanks for the reminder! :) Thanks, Zhi. -Original Message- From: Nikula, Jani Sent: Monday, May 14, 2018 11:36 AM To: Wang, Zhi A ; Zhenyu Wang ; Joonas Lahtinen ; Vivi, Rodrigo Cc: intel-gfx ; intel-gvt-dev ; Lv, Zhiyuan ; Yuan, Hang Subject: Re: [PULL] gvt-next for 4.18 On Mon

Re: [Intel-gfx] [PULL] drm-intel-next

2018-05-15 Thread Wang, Zhi A
iel Vetter ; Jani Nikula ; Joonas Lahtinen ; Vivi, Rodrigo ; Sean Paul ; Gustavo Padovan ; Maarten Lankhorst ; dri-de...@lists.freedesktop.org; intel-gfx@lists.freedesktop.org; dim-to...@lists.freedesktop.org; Wang, Zhi A ; Zhenyu Wang ; Srinivas, Vidya Subject: [PULL] drm-intel-next Hi Dave

Re: [Intel-gfx] [PATCH v4] drm/i915: Remove i915.enable_ppgtt override

2018-10-08 Thread Wang, Zhi A
[mailto:zhen...@linux.intel.com] Sent: Monday, October 8, 2018 12:54 PM To: Joonas Lahtinen Cc: He, Min ; Wang, Zhi A ; intel-gfx@lists.freedesktop.org; Chris Wilson ; Zhenyu Wang ; Auld, Matthew Subject: Re: [PATCH v4] drm/i915: Remove i915.enable_ppgtt override On 2018.09.26 11:02:15 +0300, Joonas

[Intel-gfx] FW: Wrt golden MMIO/CFG snaphot in GVT-g

2016-05-27 Thread Wang, Zhi A
For me I think maybe i915 could save the snapshot for GVT, then GVT-g patch the snapshot itself, then there won't be leaking happened I think. Even we wrote a dedicated little program, we would do the same thing. From: Wang, Zhi A Sent: Friday, May 27, 2016 12:59 PM To: joonas.

Re: [Intel-gfx] [PATCH 0/9] Introduce the implementation of GVT context

2016-06-02 Thread Wang, Zhi A
Drop this one. Will resend it later. > -Original Message- > From: Wang, Zhi A > Sent: Thursday, June 02, 2016 7:27 PM > To: intel-gfx@lists.freedesktop.org; tvrtko.ursu...@linux.intel.com; > joonas.lahti...@linux.intel.com; Tian, Kevin ; Lv, > Zhiyuan ; ch...@chris-wilso

Re: [Intel-gfx] [PATCH v6 8/9] drm/i915: Support LRC context single submission

2016-06-07 Thread Wang, Zhi A
to:joonas.lahti...@linux.intel.com] > Sent: Friday, June 03, 2016 12:47 PM > To: Wang, Zhi A ; intel-gfx@lists.freedesktop.org; > tvrtko.ursu...@linux.intel.com; Tian, Kevin ; Lv, > Zhiyuan > ; ch...@chris-wilson.co.uk > Subject: Re: [PATCH v6 8/9] drm/i915: Support LRC context single submissio

Re: [Intel-gfx] [PATCH v6 7/9] drm/i915: Introduce execlist context status change notification

2016-06-07 Thread Wang, Zhi A
> -Original Message- > From: Joonas Lahtinen [mailto:joonas.lahti...@linux.intel.com] > Sent: Friday, June 03, 2016 12:40 PM > To: Wang, Zhi A ; intel-gfx@lists.freedesktop.org; > tvrtko.ursu...@linux.intel.com; Tian, Kevin ; Lv, > Zhiyuan > ; ch...@chris-wilso

Re: [Intel-gfx] [PATCH v7 03/11] drm/i915: Fold vGPU active check into inner functions

2016-06-08 Thread Wang, Zhi A
OK. Will do in the next version. :) > -Original Message- > From: Joonas Lahtinen [mailto:joonas.lahti...@linux.intel.com] > Sent: Wednesday, June 08, 2016 11:05 AM > To: Wang, Zhi A ; ch...@chris-wilson.co.uk; Lv, Zhiyuan > ; Tian, Kevin ; > tvrtko.ursu...@linux.in

Re: [Intel-gfx] [PATCH v7 08/11] drm/i915: Make addressing mode bits in context descriptor configurable

2016-06-08 Thread Wang, Zhi A
Good idea. :) > -Original Message- > From: Chris Wilson [mailto:ch...@chris-wilson.co.uk] > Sent: Wednesday, June 08, 2016 10:13 AM > To: Wang, Zhi A > Cc: Lv, Zhiyuan ; Tian, Kevin ; > tvrtko.ursu...@linux.intel.com; intel-gfx@lists.freedesktop.org > Subject: Re:

Re: [Intel-gfx] [PATCH v7 01/11] drm/i915: Factor out i915_pvinfo.h

2016-06-08 Thread Wang, Zhi A
Sure. Moving code in one patch, "offsetof()" guy will be in another patch > -Original Message- > From: Joonas Lahtinen [mailto:joonas.lahti...@linux.intel.com] > Sent: Wednesday, June 08, 2016 10:55 AM > To: Wang, Zhi A ; ch...@chris-wilson.co.uk; Lv, Z

Re: [Intel-gfx] [PATCH v8 00/10] Introduce the implementation of GVT context

2016-06-08 Thread Wang, Zhi A
Sure. That's a good idea. :) > -Original Message- > From: Chris Wilson [mailto:ch...@chris-wilson.co.uk] > Sent: Wednesday, June 08, 2016 7:01 PM > To: Wang, Zhi A > Cc: Lv, Zhiyuan ; Tian, Kevin ; > tvrtko.ursu...@linux.intel.com; intel-gfx@lists.freedesktop.org &

Re: [Intel-gfx] [PATCH v8 07/10] drm/i915: Make addressing mode bits in context descriptor configurable

2016-06-08 Thread Wang, Zhi A
Sure. Will improve that in v9. > -Original Message- > From: Chris Wilson [mailto:ch...@chris-wilson.co.uk] > Sent: Wednesday, June 08, 2016 7:09 PM > To: Wang, Zhi A > Cc: Lv, Zhiyuan ; Tian, Kevin ; > tvrtko.ursu...@linux.intel.com; intel-gfx@lists.freedesktop.org >

Re: [Intel-gfx] ✗ Ro.CI.BAT: warning for Introduce the implementation of GVT context (rev7)

2016-06-09 Thread Wang, Zhi A
- > From: Patchwork [mailto:patchw...@emeril.freedesktop.org] > Sent: Thursday, June 09, 2016 11:01 AM > To: Wang, Zhi A > Cc: intel-gfx@lists.freedesktop.org > Subject: ✗ Ro.CI.BAT: warning for Introduce the implementation of GVT context > (rev7) > > == Series Detai

Re: [Intel-gfx] [PATCH v9 08/10] drm/i915: Introduce execlist context status change notification

2016-06-09 Thread Wang, Zhi A
> -Original Message- > From: Joonas Lahtinen [mailto:joonas.lahti...@linux.intel.com] > Sent: Thursday, June 09, 2016 1:45 PM > To: Wang, Zhi A ; intel-gfx@lists.freedesktop.org > Cc: ch...@chris-wilson.co.uk; Lv, Zhiyuan ; Tian, Kevin > ; tvrtko.ursu...@linux.intel

Re: [Intel-gfx] ✗ Ro.CI.BAT: failure for Introduce the implementation of GVT context (rev8)

2016-06-09 Thread Wang, Zhi A
The failed test case is related to the following bug: https://bugs.freedesktop.org/show_bug.cgi?id=95372 > -Original Message- > From: Patchwork [mailto:patchw...@emeril.freedesktop.org] > Sent: Friday, June 10, 2016 8:32 AM > To: Wang, Zhi A > Cc: intel-gfx@lists.

Re: [Intel-gfx] [PATCH v10 00/10] Introduce the implementation of GVT context

2016-06-13 Thread Wang, Zhi A
Hi Chris: As Joonas is on vacation, can you pick my patches? or if you have some comments I can continue improving them. Thanks, Zhi. > -Original Message- > From: Wang, Zhi A > Sent: Thursday, June 09, 2016 9:44 PM > To: intel-gfx@lists.freedesktop.org > Cc: ch...@chr

Re: [Intel-gfx] [PATCH v10 00/10] Introduce the implementation of GVT context

2016-06-13 Thread Wang, Zhi A
Also CC Daniel. I have got "Reviewed-by" and passed the ABAT tests. Is there anything I should do before patches get picked? Thanks, Zhi. > -Original Message- > From: Wang, Zhi A > Sent: Monday, June 13, 2016 4:17 PM > To: intel-gfx@lists.freedesktop.org > Cc:

Re: [Intel-gfx] ✗ Ro.CI.BAT: warning for Introduce the implementation of GVT context (rev9)

2016-06-14 Thread Wang, Zhi A
The dmesg warning message issue has been reported at: https://bugs.freedesktop.org/show_bug.cgi?id=96448 > -Original Message- > From: Patchwork [mailto:patchw...@emeril.freedesktop.org] > Sent: Tuesday, June 14, 2016 4:52 PM > To: Wang, Zhi A > Cc: intel-gfx@lists.

Re: [Intel-gfx] ✗ Ro.CI.BAT: failure for Introduce the implementation of GVT context (rev10)

2016-06-16 Thread Wang, Zhi A
The failure has been reported at: https://bugs.freedesktop.org/show_bug.cgi?id=95236 > -Original Message- > From: Patchwork [mailto:patchw...@emeril.freedesktop.org] > Sent: Thursday, June 16, 2016 3:27 PM > To: Wang, Zhi A > Cc: intel-gfx@lists.freedesktop.org > Su

  1   2   3   >