[Intel-gfx] [PATCH] drm/i915: Fix mode_get() for Broxton

2015-12-01 Thread Vandana Kannan
implementation, these value will be incorrect, thus impacting DPST. Signed-off-by: Vandana Kannan --- drivers/gpu/drm/i915/intel_display.c | 66 +--- 1 file changed, 62 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm

[Intel-gfx] [RFC 1/2] drm: Add aux plane verification in addFB2

2015-12-08 Thread Vandana Kannan
render compression. v2: Based on a discussion with Siva Move num_planes check below the increment. Signed-off-by: Daniel Vetter Signed-off-by: Vandana Kannan Cc: Sivakumar Thulasimani --- drivers/gpu/drm/drm_crtc.c | 19 ++- drivers/gpu/drm/drm_ioctl.c | 3 +++ include/drm

[Intel-gfx] [RFC 2/2] drm/i915: Render decompression support for Gen9

2015-12-08 Thread Vandana Kannan
decomp is enabled (bit 7:6) 2. Render decompression must not be used in VTd pass-through mode 3. Program hashing select CHICKEN_MISC1 bit 15 Note: This patch is based on top of Chandra's and Ville's NV12/fb->offset related patches series. Signed-off-by: Vandana Kannan Cc: Konduru

[Intel-gfx] [PATCH v2 2/2] drm/i915: Render decompression support for Gen9 and above

2016-04-29 Thread Vandana Kannan
Testing is in progress for v2 of the patch. Signed-off-by: Vandana Kannan Cc: Ville Syrjälä Cc: Smith, Gary K --- drivers/gpu/drm/i915/i915_drv.h | 1 + drivers/gpu/drm/i915/i915_reg.h | 22 + drivers/gpu/drm/i915/intel_atomic_plane.c | 24 +- drivers/gpu/drm/i915/in

[Intel-gfx] [PATCH v3 2/2] drm/i915: Render decompression support for Gen9 and above

2016-05-13 Thread Vandana Kannan
ala/linux.git fb_offsets_15) - Userspace is expected to pass aux offset through fb->offsets[1]. Testing is in progress for v3 of the patch. Signed-off-by: Vandana Kannan Cc: Ville Syrjälä Cc: Smith, Gary K --- drivers/gpu/drm/i915/i915_drv.h | 1 + drivers/gpu/drm/i915/i915_reg.h

[Intel-gfx] [PATCH 1/2] drm: Add aux plane verification in addFB2

2016-03-19 Thread Vandana Kannan
render compression. v2: Based on a discussion with Siva Move num_planes check below the increment. Signed-off-by: Daniel Vetter Signed-off-by: Vandana Kannan Cc: Sivakumar Thulasimani --- drivers/gpu/drm/drm_crtc.c | 19 ++- drivers/gpu/drm/drm_ioctl.c | 3 +++ include/drm

[Intel-gfx] [PATCH 2/2] drm/i915: Render decompression support for Gen9 and above

2016-03-19 Thread Vandana Kannan
plane check in skl_check_compression() Signed-off-by: Vandana Kannan Cc: Smith, Gary K Cc: Daniel Stone Cc: Daniel Vetter --- drivers/gpu/drm/i915/i915_drv.h | 1 + drivers/gpu/drm/i915/i915_reg.h | 22 drivers/gpu/drm/i915/intel_atomic_plane.c | 24 +++- drivers

[Intel-gfx] [PATCH] drm/i915: BXT DDI PHY sequence BUN

2016-03-20 Thread Vandana Kannan
According to the BSpec update, bit 7 of PORT_CL1CM_DW0 register needs to be checked to ensure that the register is in accessible state. Also, based on a BSpec update, changing the timeout value to check iphypwrgood, from 10ms to wait for up to 100us. Signed-off-by: Vandana Kannan Reported-by

[Intel-gfx] [PATCH v2] drm/i915: BXT DDI PHY sequence BUN

2016-03-31 Thread Vandana Kannan
. Signed-off-by: Vandana Kannan Reported-by: Philippe Lecluse Cc: Deak, Imre Cc: Nikula, Jani --- drivers/gpu/drm/i915/i915_reg.h | 1 + drivers/gpu/drm/i915/intel_ddi.c | 15 +-- 2 files changed, 14 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_reg.h b

[Intel-gfx] [PATCH v3] drm/i915: BXT DDI PHY sequence BUN

2016-03-31 Thread Vandana Kannan
atomic call. v3: [Jani/Imre] read register only once Signed-off-by: Vandana Kannan Reported-by: Philippe Lecluse Cc: Deak, Imre Cc: Nikula, Jani --- drivers/gpu/drm/i915/i915_reg.h | 1 + drivers/gpu/drm/i915/intel_ddi.c | 13 +++-- 2 files changed, 12 insertions(+), 2 deletions

[Intel-gfx] [PATCH 0/2] Introducing crtc_clock_get()

2015-10-15 Thread Vandana Kannan
The implementation of crtc_clock_get() will not work for BXT. The 2 patches in this series, cleans up the code related to crtc_clock_get() and includes implementation for BXT (DSI and otherwise). A patch to correct crtc_mode_get() for BXT DSI will follow shortly. Vandana Kannan (2): drm/i915

[Intel-gfx] [PATCH 1/2] drm/i915: Create crtc_clock_get function pointers

2015-10-15 Thread Vandana Kannan
There are separate functions i9xx_crtc_clock_get(), vlv_crtc_clock_get(), chv_crtc_clock_get(). instead of calling these using if-else, making func pointers. This will also be useful going forward when the implementation for BXT is done. Signed-off-by: Vandana Kannan --- drivers/gpu/drm/i915

[Intel-gfx] [PATCH 2/2] drm/i915: Add crtc_clock_get for hsw, skl, bxt

2015-10-15 Thread Vandana Kannan
Reusing the ddi_clock_get functions for hsw, skl, bxt and creating a common crtc_clock_get function. for BXT, there is a difference in clock between DSI and DDI. Taking care of this as well. Signed-off-by: Vandana Kannan --- drivers/gpu/drm/i915/intel_display.c | 43

[Intel-gfx] [PATCH] drm: Add aux plane verification in addFB2

2015-11-02 Thread Vandana Kannan
. Suggested-by: Daniel Vetter Signed-off-by: Vandana Kannan --- drivers/gpu/drm/drm_crtc.c | 16 +++- drivers/gpu/drm/drm_ioctl.c | 3 +++ include/drm/drm_crtc.h | 3 +++ include/uapi/drm/drm.h | 1 + include/uapi/drm/drm_mode.h | 1 + 5 files changed, 23 insertions(+), 1

[Intel-gfx] [PATCH] drm: Add aux plane verification in addFB2

2015-11-05 Thread Vandana Kannan
render compression. v2: Based on a discussion with Siva Moving num_planes check below the increment. Changing the author to Daniel instead of suggested-by, since the core logic is his. Signed-off-by: Daniel Vetter Signed-off-by: Vandana Kannan Cc: Sivakumar Thulasimani --- drivers/gpu/drm

Re: [Intel-gfx] [PATCH 1/3] drm/crtc: Add property for aspect ratio

2014-04-20 Thread Vandana Kannan
On Apr-07-2014 3:24 PM, Vandana Kannan wrote: > On Apr-07-2014 3:33 PM, Kannan, Vandana wrote: >> Added a property to enable user space to set aspect ratio. >> This patch contains declaration of the property and code to create the >> property. >> >> Signed-off-

Re: [Intel-gfx] [PATCH v9 3/6] drm/i915: Add support for DRRS to switch RR

2014-04-20 Thread Vandana Kannan
On Apr-11-2014 4:51 PM, Vandana Kannan wrote: > On Apr-11-2014 2:56 PM, Daniel Vetter wrote: >> On Fri, Apr 11, 2014 at 02:48:53PM +0530, Vandana Kannan wrote: >>> On Apr-10-2014 2:28 PM, Daniel Vetter wrote: >>>> On Thu, Apr 10, 2014 at 11:43:15AM +0300, Jani Nikula

[Intel-gfx] [PATCH v2] drm/i915: State readout and cross-checking for dp_m2_n2

2014-05-05 Thread Vandana Kannan
evant state readout code for M2_N2. dp_m2_n2 comparison to be done only when high RR is not in use (This is because alternate m_n register programming will be done only when low RR is being used). Signed-off-by: Vandana Kannan Cc: Daniel Vetter --- drivers/gpu/drm/i915/intel_ddi.c | 1 + driver

Re: [Intel-gfx] [PATCH v2] drm/i915: State readout and cross-checking for dp_m2_n2

2014-05-13 Thread Vandana Kannan
On May-12-2014 3:57 PM, Ville Syrjälä wrote: > On Mon, May 05, 2014 at 01:49:31PM +0530, Vandana Kannan wrote: >> Adding relevant read out comparison code, in check_crtc_state, for the new >> member of crtc_config, dp_m2_n2, which was introduced to store link_m_n >> values fo

Re: [Intel-gfx] [PATCH v2] drm/i915: State readout and cross-checking for dp_m2_n2

2014-05-13 Thread Vandana Kannan
On May-13-2014 2:28 PM, Daniel Vetter wrote: > On Tue, May 13, 2014 at 01:56:04PM +0530, Vandana Kannan wrote: >> On May-12-2014 3:57 PM, Ville Syrjälä wrote: >>> On Mon, May 05, 2014 at 01:49:31PM +0530, Vandana Kannan wrote: >>>> Adding relevant read out comparison

Re: [Intel-gfx] [PATCH v2] drm/i915: State readout and cross-checking for dp_m2_n2

2014-05-15 Thread Vandana Kannan
On May-13-2014 3:10 PM, Vandana Kannan wrote: > On May-13-2014 2:28 PM, Daniel Vetter wrote: >> On Tue, May 13, 2014 at 01:56:04PM +0530, Vandana Kannan wrote: >>> On May-12-2014 3:57 PM, Ville Syrjälä wrote: >>>> On Mon, May 05, 2014 at 01:49:31PM +0530, Vand

Re: [Intel-gfx] [PATCH v2] drm/i915: State readout and cross-checking for dp_m2_n2

2014-05-15 Thread Vandana Kannan
On May-15-2014 3:01 PM, Ville Syrjälä wrote: > On Thu, May 15, 2014 at 02:48:02PM +0530, Vandana Kannan wrote: >> On May-13-2014 3:10 PM, Vandana Kannan wrote: >>> On May-13-2014 2:28 PM, Daniel Vetter wrote: >>>> On Tue, May 13, 2014 at 01:56:04PM +0530, Vandana Kann

Re: [Intel-gfx] [PATCH v2] drm/i915: State readout and cross-checking for dp_m2_n2

2014-05-19 Thread Vandana Kannan
On May-15-2014 2:48 PM, Vandana Kannan wrote: > On May-13-2014 3:10 PM, Vandana Kannan wrote: >> On May-13-2014 2:28 PM, Daniel Vetter wrote: >>> On Tue, May 13, 2014 at 01:56:04PM +0530, Vandana Kannan wrote: >>>> On May-12-2014 3:57 PM, Ville Syrjälä wrote: >&

[Intel-gfx] [PATCH 2/2] drm/i915: State readout and cross-checking for dp_m2_n2

2014-05-21 Thread Vandana Kannan
7 and below. compare the structures based on DRRS state for gen 8 and above. Save and restore M2 N2 registers for gen 7 and below v4: For Gen>=8, check M_N registers against dp_m_n and dp_m2_n2 as there is only one set of M_N registers Signed-off-by: Vandana Kannan Cc: Daniel Vetter --- dri

[Intel-gfx] [PATCH 1/2] drm/i915: Set M2_N2 registers during mode set

2014-05-21 Thread Vandana Kannan
For Gen < 8, set M2_N2 registers on every mode set. This is required to make sure M2_N2 registers are set during boot, resume from sleep for cross- checking the state. The register is set only if DRRS is supported. Signed-off-by: Vandana Kannan Cc: Daniel Vetter --- drivers/gpu/drm/i

Re: [Intel-gfx] [PATCH 2/2] drm/i915: State readout and cross-checking for dp_m2_n2

2014-05-21 Thread Vandana Kannan
On May-21-2014 6:03 PM, Daniel Vetter wrote: > On Wed, May 21, 2014 at 04:40:04PM +0530, Vandana Kannan wrote: >> Adding relevant read out comparison code, in check_crtc_state, for the new >> member of crtc_config, dp_m2_n2, which was introduced to store link_m_n >> values fo

[Intel-gfx] [PATCH v5 2/2] drm/i915: State readout and cross-checking for dp_m2_n2

2014-05-21 Thread Vandana Kannan
egisters. Modified get_m_n() to get M2_N2 registers as well. Modified the macro which compares hw.dp_m_n against sw.dp_m2_n2/sw.dp_m_n for gen > 8. Signed-off-by: Vandana Kannan Cc: Daniel Vetter --- drivers/gpu/drm/i915/intel_display.c | 68 +++- 1 file changed, 60

[Intel-gfx] [PATCH 1/3] drm/crtc: Add property for aspect ratio

2014-05-22 Thread Vandana Kannan
Added a property to enable user space to set aspect ratio. This patch contains declaration of the property and code to create the property. Signed-off-by: Vandana Kannan Cc: dri-de...@lists.freedesktop.org --- drivers/gpu/drm/drm_crtc.c | 31 +++ include/drm

[Intel-gfx] [PATCH 2/3] drm/edid: Check for user aspect ratio input

2014-05-22 Thread Vandana Kannan
In case user has specified an input for aspect ratio through the property, then the user space value for PAR would take preference over the value from CEA mode list. Signed-off-by: Vandana Kannan Cc: dri-de...@lists.freedesktop.org --- drivers/gpu/drm/drm_edid.c | 9 +++-- 1 file changed, 7

[Intel-gfx] [PATCH 3/3] drm/i915: Add aspect ratio property for HDMI

2014-05-22 Thread Vandana Kannan
Create and attach the drm property to set aspect ratio. If there is no user specified value, then PAR_NONE/Automatic option is set by default. User can select aspect ratio 4:3 or 16:9. The aspect ratio selected by user would come into effect with a mode set. Signed-off-by: Vandana Kannan

Re: [Intel-gfx] [PATCH 3/3] drm/i915: Add aspect ratio property for HDMI

2014-05-22 Thread Vandana Kannan
ser would > come into effect with a mode set. > > Signed-off-by: Vandana Kannan > --- > drivers/gpu/drm/i915/i915_drv.h | 5 + > drivers/gpu/drm/i915/intel_drv.h | 1 + > drivers/gpu/drm/i915/intel_hdmi.c | 31 +++ > 3 files changed, 3

Re: [Intel-gfx] [PATCH 1/3] drm/crtc: Add property for aspect ratio

2014-05-23 Thread Vandana Kannan
On May-22-2014 5:08 PM, Thierry Reding wrote: > On Thu, May 22, 2014 at 04:50:48PM +0530, Vandana Kannan wrote: >> Added a property to enable user space to set aspect ratio. >> This patch contains declaration of the property and code to create the >> property. >> >&

Re: [Intel-gfx] [PATCH 2/3] drm/edid: Check for user aspect ratio input

2014-05-23 Thread Vandana Kannan
On May-22-2014 5:12 PM, Thierry Reding wrote: > On Thu, May 22, 2014 at 04:50:49PM +0530, Vandana Kannan wrote: >> In case user has specified an input for aspect ratio through the property, >> then the user space value for PAR would take preference over the value from &

Re: [Intel-gfx] [PATCH 1/3] drm/crtc: Add property for aspect ratio

2014-05-23 Thread Vandana Kannan
On May-22-2014 5:46 PM, Daniel Vetter wrote: > On Thu, May 22, 2014 at 04:50:48PM +0530, Vandana Kannan wrote: >> Added a property to enable user space to set aspect ratio. >> This patch contains declaration of the property and code to create the >> property. >> >&

Re: [Intel-gfx] [PATCH 1/3] drm/crtc: Add property for aspect ratio

2014-05-25 Thread Vandana Kannan
On May-23-2014 4:18 PM, Vandana Kannan wrote: > On May-22-2014 5:46 PM, Daniel Vetter wrote: >> On Thu, May 22, 2014 at 04:50:48PM +0530, Vandana Kannan wrote: >>> Added a property to enable user space to set aspect ratio. >>> This patch contains declaration of the prop

[Intel-gfx] [PATCH v2 1/4] drm/crtc: Add property for aspect ratio

2014-05-26 Thread Vandana Kannan
ratio variable Signed-off-by: Vandana Kannan Cc: Thierry Reding Cc: Daniel Vetter --- drivers/gpu/drm/drm_crtc.c | 27 +++ include/drm/drm_crtc.h | 2 ++ include/uapi/drm/drm_mode.h | 5 + 3 files changed, 34 insertions(+) diff --git a/drivers/gpu/drm/drm_crt

[Intel-gfx] [PATCH v2 2/4] drm/edid: Check for user aspect ratio input

2014-05-26 Thread Vandana Kannan
In case user has specified an input for aspect ratio through the property, then the user space value for PAR would take preference over the value from CEA mode list. v2: Thierry's review comments. - Modified the comment "Populate..." as per review comments Signed-off-by:

[Intel-gfx] [PATCH v2 3/4] drm/i915: Add aspect ratio property for HDMI

2014-05-26 Thread Vandana Kannan
changes to aspect ratio enum list. Signed-off-by: Vandana Kannan Cc: Thierry Reding Cc: Daniel Vetter --- drivers/gpu/drm/i915/intel_drv.h | 1 + drivers/gpu/drm/i915/intel_hdmi.c | 31 +++ 2 files changed, 32 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_drv.h

[Intel-gfx] [PATCH 4/4] Documentation/drm: Describing aspect ratio property

2014-05-26 Thread Vandana Kannan
Updated drm documentation to include description of aspect ratio property. HTML table structure created by Sagar Kamble. Signed-off-by: Vandana Kannan Cc: Sagar Kamble Cc: Daniel Vetter Cc: Thierry Reding --- Documentation/DocBook/drm.tmpl | 31 +++ 1 file changed

Re: [Intel-gfx] [PATCH v5 2/2] drm/i915: State readout and cross-checking for dp_m2_n2

2014-05-29 Thread Vandana Kannan
st dp_m_n and dp_m2_n2 as there is > only one set of M_N registers > > v5: Removed the chunk which saves and restores M2_N2 registers. Modified > get_m_n() to get M2_N2 registers as well. Modified the macro which compares > hw.dp_m_n against sw.dp_m2_n2/sw.dp_m_n for gen > 8. >

[Intel-gfx] [PATCH v3 1/4] drm/crtc: Add property for aspect ratio

2014-06-05 Thread Vandana Kannan
ratio variable v3: Thierry's review comments. - Fixed indentation drm_mode_create_aspect_ratio_property() Signed-off-by: Vandana Kannan Cc: Thierry Reding --- drivers/gpu/drm/drm_crtc.c | 27 +++ include/drm/drm_crtc.h | 2 ++ include/uapi/drm/drm_mode.h |

[Intel-gfx] [PATCH v3 2/4] drm/edid: Check for user aspect ratio input

2014-06-05 Thread Vandana Kannan
27;s review comments. - Modified the comment to block comment format. Signed-off-by: Vandana Kannan Cc: Thierry Reding --- drivers/gpu/drm/drm_edid.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c in

Re: [Intel-gfx] [PATCH v3 1/4] drm/crtc: Add property for aspect ratio

2014-06-10 Thread Vandana Kannan
On Jun-05-2014 2:58 PM, Thierry Reding wrote: > On Thu, Jun 05, 2014 at 02:40:08PM +0530, Vandana Kannan wrote: > [...] >> diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c > [...] >> /** >> + * drm_mode_create_aspect_ratio_property - create aspect

[Intel-gfx] [PATCH v4 1/4] drm/crtc: Add property for aspect ratio

2014-06-10 Thread Vandana Kannan
ratio variable v3: Thierry's review comments. - Fixed indentation v4: Thierry's review comments. - Return ENOMEM when property creation fails Signed-off-by: Vandana Kannan Cc: Thierry Reding --- drivers/gpu/drm/drm_crtc.c | 33 + include

[Intel-gfx] [PATCH v3 3/4] drm/i915: Add aspect ratio property for HDMI

2014-06-10 Thread Vandana Kannan
aspect ratio enum changes v3: Modified the patch according the change in the earlier patch to return errno in case property creation fails. With this change, property will be attached only if creation is successful Signed-off-by: Vandana Kannan Cc: Thierry Reding Cc: Daniel Vetter --- drivers

[Intel-gfx] [PATCH v2 4/4] Documentation/drm: Describing aspect ratio property

2014-06-11 Thread Vandana Kannan
Updated drm documentation to include desscription of aspect ratio property. v2: Updated aspect ratio specific documentation on top of the HTML table created. Signed-off-by: Vandana Kannan Cc: Sagar Kamble Cc: Daniel Vetter --- Documentation/DocBook/drm.tmpl | 13 +++-- 1 file

[Intel-gfx] [PATCH] drm/i915: Initialize downclock mode in panel init

2014-02-10 Thread Vandana Kannan
Instead of modifying intel_panel in lvds_init_connector/dsi_init_connector/ edp_init_connector, making changes to move intel_panel->downclock_mode initialization to intel_panel_init() Signed-off-by: Vandana Kannan Signed-off-by: Pradeep Bhat --- drivers/gpu/drm/i915/intel_dp.c|

Re: [Intel-gfx] [PATCH 2/5] drm/i915: Parse EDID probed modes for DRRS support

2014-02-10 Thread Vandana Kannan
On Jan-30-2014 9:03 AM, Vandana Kannan wrote: > On Jan-22-2014 7:03 PM, Jani Nikula wrote: >> On Mon, 23 Dec 2013, Vandana Kannan wrote: >>> From: Pradeep Bhat >>> >>> This patch and finds out the lowest refresh rate supported for the >>> resolu

[Intel-gfx] [PATCH] drm/i915: Initialize downclock mode in panel init

2014-02-11 Thread Vandana Kannan
Signed-off-by: Vandana Kannan Signed-off-by: Pradeep Bhat --- drivers/gpu/drm/i915/intel_dp.c|2 +- drivers/gpu/drm/i915/intel_drv.h |3 ++- drivers/gpu/drm/i915/intel_dsi.c |2 +- drivers/gpu/drm/i915/intel_lvds.c | 10 +- drivers/gpu/drm/i915/intel_panel.c |4

[Intel-gfx] [PATCH 0/5] v5: Enabling DRRS in the kernel

2014-02-14 Thread Vandana Kannan
[Intel-gfx] drm/i915: Parse EDID probed modes for DRRS support [Intel-gfx] drm/i915: Add support for DRRS to switch RR Vandana Kannan (2): [Intel-gfx] drm/i915: Idleness detection for DRRS [Intel-gfx] drm/i915/bdw: Add support for DRRS to switch RR drivers/gpu/drm/i915/i915_drv.h

[Intel-gfx] [PATCH 3/5] drm/i915: Add support for DRRS to switch RR

2014-02-14 Thread Vandana Kannan
ts Removed superfluous return statements. Changed support for Gen 7 and above. Corrected indentation. Re-structured the code which finds crtc and connector from encoder. Changed some logs to be less verbose. Signed-off-by: Pradeep Bhat Signed-off-by: Vandana Kannan --- drivers/gpu/drm/i915/

[Intel-gfx] [PATCH 2/5] drm/i915: Parse EDID probed modes for DRRS support

2014-02-14 Thread Vandana Kannan
5: Incorporated Jani's review comments Modify intel_dp_drrs_initialize to return downclock mode. Support for Gen7 and above. Signed-off-by: Pradeep Bhat Signed-off-by: Vandana Kannan --- drivers/gpu/drm/i915/intel_dp.c | 53 +- drivers/gpu/drm/i91

[Intel-gfx] [PATCH 4/5] drm/i915: Idleness detection for DRRS

2014-02-14 Thread Vandana Kannan
ls in i9xx_crtc_enable/disable and valleyview_crtc_enable. v4: Jani's review comments incorporated. Change in sequence in intel_update_drrs. Comment modified to remove details of update param. Modified DRRS idleness interval to a module parameter. Signed-off-by: Vandana Kannan Signed-off-by: Pr

[Intel-gfx] [PATCH 1/5] drm/i915: Adding VBT fields to support eDP DRRS feature

2014-02-14 Thread Vandana Kannan
quot; as a prefix for DRRS specific declarations. v3: Incorporated Jani's review comments Removed function which deducts drrs mode from panel_type. Modified some print statements. Made changes to use DRRS_NOT_SUPPORTED as 0 instead of -1. Signed-off-by: Pradeep Bhat Signed-off-by:

[Intel-gfx] [PATCH 5/5] drm/i915/bdw: Add support for DRRS to switch RR

2014-02-14 Thread Vandana Kannan
next frame that is output. v2: Incorporated Chris's review comments Changed to check for gen >=8 or gen > 5 before setting M/N registers v3: Incorporated Jani's review comments Re-use cpu_transcoder_set_m_n for BDW. Signed-off-by: Vandana Kannan Signed-off-by: Pradeep Bhat ---

[Intel-gfx] [PATCH 0/6] v6: Enabling DRRS in the kernel

2014-03-05 Thread Vandana Kannan
support eDP DRRS feature [Intel-gfx] drm/i915: Parse EDID probed modes for DRRS support [Intel-gfx] drm/i915: Add support for DRRS to switch RR Vandana Kannan (3): [Intel-gfx] drm/i915: Idleness detection for DRRS [Intel-gfx] drm/i915/bdw: Add support for DRRS to switch RR [Intel-gfx] drm

[Intel-gfx] [PATCH 1/6] drm/i915: Adding VBT fields to support eDP DRRS feature

2014-03-05 Thread Vandana Kannan
quot; as a prefix for DRRS specific declarations. v3: Incorporated Jani's review comments Removed function which deducts drrs mode from panel_type. Modified some print statements. Made changes to use DRRS_NOT_SUPPORTED as 0 instead of -1. Signed-off-by: Pradeep Bhat Signed-off-by: Vandana K

[Intel-gfx] [PATCH 5/6] drm/i915/bdw: Add support for DRRS to switch RR

2014-03-05 Thread Vandana Kannan
next frame that is output. v2: Incorporated Chris's review comments Changed to check for gen >=8 or gen > 5 before setting M/N registers v3: Incorporated Jani's review comments Re-use cpu_transcoder_set_m_n for BDW. Signed-off-by: Vandana Kannan Signed-off-by: Pradeep Bhat ---

[Intel-gfx] [PATCH 6/6] drm/i915: Support for RR switching on VLV

2014-03-05 Thread Vandana Kannan
Definition of VLV RR switch bit and corresponding toggling in set_drrs function. Signed-off-by: Vandana Kannan Signed-off-by: Uma Shankar --- drivers/gpu/drm/i915/i915_reg.h |1 + drivers/gpu/drm/i915/intel_dp.c | 10 -- 2 files changed, 9 insertions(+), 2 deletions(-) diff

[Intel-gfx] [PATCH 2/6] drm/i915: Parse EDID probed modes for DRRS support

2014-03-05 Thread Vandana Kannan
view comments Modify intel_dp_drrs_initialize to return downclock mode. Support for Gen7 and above. v6: Incorporated Chris's review comments. Changed initialize to init in intel_drrs_initialize Signed-off-by: Pradeep Bhat Signed-off-by: Vandana Kannan --- drivers/gpu/dr

[Intel-gfx] [PATCH 3/6] drm/i915: Add support for DRRS to switch RR

2014-03-05 Thread Vandana Kannan
from intel connector when required. Signed-off-by: Pradeep Bhat Signed-off-by: Vandana Kannan --- drivers/gpu/drm/i915/i915_drv.h |5 ++ drivers/gpu/drm/i915/i915_reg.h |1 + drivers/gpu/drm/i915/intel_dp.c | 101 ++ drivers/gpu/drm/i915/intel_drv.h |

[Intel-gfx] [PATCH 4/6] drm/i915: Idleness detection for DRRS

2014-03-05 Thread Vandana Kannan
e. Added a flag to track dual-display configuration. Remove print statement for "cancel DRR work" and print "DRRS not supported" only once. Signed-off-by: Vandana Kannan Signed-off-by: Pradeep Bhat --- drivers/gpu/drm/i915/i915_drv.h |7 ++ drivers/gpu/drm/i915/i915_pa

[Intel-gfx] [PATCH 5/6] drm/i915/bdw: Add support for DRRS to switch RR

2014-03-06 Thread Vandana Kannan
next frame that is output. v2: Incorporated Chris's review comments Changed to check for gen >=8 or gen > 5 before setting M/N registers v3: Incorporated Jani's review comments Re-use cpu_transcoder_set_m_n for BDW. Signed-off-by: Vandana Kannan Signed-off-by: Pradeep Bhat ---

[Intel-gfx] [PATCH 2/6] drm/i915: Parse EDID probed modes for DRRS support

2014-03-06 Thread Vandana Kannan
view comments Modify intel_dp_drrs_initialize to return downclock mode. Support for Gen7 and above. v6: Incorporated Chris's review comments. Changed initialize to init in intel_drrs_initialize Signed-off-by: Pradeep Bhat Signed-off-by: Vandana Kannan --- drivers/gpu/dr

[Intel-gfx] [PATCH 4/6] drm/i915: Idleness detection for DRRS

2014-03-06 Thread Vandana Kannan
s would be taken care of with calls to crtc page flip itself. This will have to be revisited later if flip infrastructure changes for sprite. Signed-off-by: Vandana Kannan Signed-off-by: Pradeep Bhat --- drivers/gpu/drm/i915/i915_drv.h |7 ++ drivers/gpu/drm/i915/i915_params.

[Intel-gfx] [PATCH 3/6] drm/i915: Add support for DRRS to switch RR

2014-03-06 Thread Vandana Kannan
from intel connector when required. v7: As per internal review comments, acquiring mutex just before accessing drrs RR. As per Chris's review comments, added documentation about the use of locking in the function. Signed-off-by: Pradeep Bhat Signed-off-by: Vandana Kannan --- drivers/gpu/drm/

[Intel-gfx] [PATCH 6/6] drm/i915: Support for RR switching on VLV

2014-03-06 Thread Vandana Kannan
Definition of VLV RR switch bit and corresponding toggling in set_drrs function. Signed-off-by: Vandana Kannan Signed-off-by: Uma Shankar --- drivers/gpu/drm/i915/i915_reg.h |1 + drivers/gpu/drm/i915/intel_dp.c | 10 -- 2 files changed, 9 insertions(+), 2 deletions(-) diff

[Intel-gfx] [PATCH 0/6] v6: Enabling DRRS in the kernel

2014-03-06 Thread Vandana Kannan
support eDP DRRS feature [Intel-gfx] drm/i915: Parse EDID probed modes for DRRS support [Intel-gfx] drm/i915: Add support for DRRS to switch RR Vandana Kannan (3): [Intel-gfx] drm/i915: Idleness detection for DRRS [Intel-gfx] drm/i915/bdw: Add support for DRRS to switch RR [Intel-gfx] drm

[Intel-gfx] [PATCH 1/6] drm/i915: Adding VBT fields to support eDP DRRS feature

2014-03-06 Thread Vandana Kannan
quot; as a prefix for DRRS specific declarations. v3: Incorporated Jani's review comments Removed function which deducts drrs mode from panel_type. Modified some print statements. Made changes to use DRRS_NOT_SUPPORTED as 0 instead of -1. Signed-off-by: Pradeep Bhat Signed-off-by: Vandana K

Re: [Intel-gfx] [PATCH 3/6] drm/i915: Add support for DRRS to switch RR

2014-03-07 Thread Vandana Kannan
On Mar-05-2014 3:28 PM, Chris Wilson wrote: > On Wed, Mar 05, 2014 at 03:13:06PM +0530, Vandana Kannan wrote: >> +void intel_dp_set_drrs_state(struct drm_device *dev, int refresh_rate) >> +{ >> +struct drm_i915_private *dev_priv = dev->dev_private; >> +

[Intel-gfx] [PATCH] drm/edid: Fill PAR in AVI infoframe based on CEA mode list

2014-03-20 Thread Vandana Kannan
property that would enable a user space app to set aspect ratio. (will be pushed as a separate patch) Signed-off-by: Vandana Kannan Cc: Jesse Barnes Cc: Vijay Purushothaman Cc: Ville Syrjälä Cc: intel-gfx@lists.freedesktop.org --- drivers/gpu/drm/drm_edid.c | 34

[Intel-gfx] [PATCH] drm/i915: Add property to set HDMI aspect ratio

2014-03-24 Thread Vandana Kannan
: Vandana Kannan Cc: Jesse Barnes Cc: Vijay Purushothaman Cc: Ville Syrjälä --- drivers/gpu/drm/i915/i915_drv.h|1 + drivers/gpu/drm/i915/intel_drv.h |2 ++ drivers/gpu/drm/i915/intel_hdmi.c | 10 ++ drivers/gpu/drm/i915/intel_modes.c | 28 4

[Intel-gfx] [PATCH] drm/i915: Add property to set HDMI aspect ratio

2014-03-25 Thread Vandana Kannan
x27;s review comments incorporated. Call for a mode set to update property. Suggested-by: Ville Syrjälä Signed-off-by: Vandana Kannan Cc: Jesse Barnes Cc: Vijay Purushothaman Cc: Ville Syrjälä Cc: Daniel Vetter --- drivers/gpu/drm/i915/i915_drv.h|1 + drivers/gpu/drm/i915/intel_drv.h |

Re: [Intel-gfx] [PATCH 2/6] drm/i915: Parse EDID probed modes for DRRS support

2014-03-27 Thread Vandana Kannan
On Mar-26-2014 6:19 PM, Jani Nikula wrote: > On Wed, 26 Mar 2014, Jani Nikula wrote: >> This and the following patches need to be rebased on top of current >> -nightly. >> >> On Fri, 07 Mar 2014, Vandana Kannan wrote: >>> From: Pradeep Bhat >>> &g

Re: [Intel-gfx] [PATCH 3/6] drm/i915: Add support for DRRS to switch RR

2014-03-27 Thread Vandana Kannan
On Mar-26-2014 6:25 PM, Jani Nikula wrote: > On Fri, 07 Mar 2014, Vandana Kannan wrote: >> From: Pradeep Bhat >> >> This patch computes and stored 2nd M/N/TU for switching to different >> refresh rate dynamically. PIPECONF_EDP_RR_MODE_SWITCH bit helps toggle >>

Re: [Intel-gfx] [PATCH 1/6] drm/i915: Adding VBT fields to support eDP DRRS feature

2014-03-27 Thread Vandana Kannan
On Mar-26-2014 6:06 PM, Jani Nikula wrote: > On Fri, 07 Mar 2014, Vandana Kannan wrote: >> From: Pradeep Bhat >> >> This patch reads the DRRS support and Mode type from VBT fields. >> The read information will be stored in VBT struct during BIOS >> parsing. The

Re: [Intel-gfx] [PATCH 4/6] drm/i915: Idleness detection for DRRS

2014-03-27 Thread Vandana Kannan
On Mar-26-2014 6:35 PM, Jani Nikula wrote: > On Fri, 07 Mar 2014, Vandana Kannan wrote: >> Adding support to detect display idleness by tracking page flip from >> user space. Switch to low refresh rate is triggered after 2 seconds of >> idleness. The delay is configurable. If

[Intel-gfx] [PATCH 6/6] drm/i915: Support for RR switching on VLV

2014-03-27 Thread Vandana Kannan
Definition of VLV RR switch bit and corresponding toggling in set_drrs function. Signed-off-by: Vandana Kannan Signed-off-by: Uma Shankar --- drivers/gpu/drm/i915/i915_reg.h |1 + drivers/gpu/drm/i915/intel_dp.c | 10 -- 2 files changed, 9 insertions(+), 2 deletions(-) diff

[Intel-gfx] [PATCH 1/6] drm/i915: Adding VBT fields to support eDP DRRS feature

2014-03-27 Thread Vandana Kannan
tions around setting vbt drrs_type. Signed-off-by: Pradeep Bhat Signed-off-by: Vandana Kannan Acked-by: Jesse Barnes Cc: Jani Nikula --- drivers/gpu/drm/i915/i915_drv.h | 12 drivers/gpu/drm/i915/intel_bios.c | 34 +- drivers/gpu/drm/i915

[Intel-gfx] [PATCH 2/6] drm/i915: Parse EDID probed modes for DRRS support

2014-03-27 Thread Vandana Kannan
y. Make drrs_state and unnamed struct. Move Gen based check inside drrs_init. Signed-off-by: Pradeep Bhat Signed-off-by: Vandana Kannan Cc: Jani Nikula --- drivers/gpu/drm/i915/intel_dp.c | 53 +- drivers/gpu/drm/i915/intel_drv.h | 16 2 file

[Intel-gfx] [PATCH 5/6] drm/i915/bdw: Add support for DRRS to switch RR

2014-03-27 Thread Vandana Kannan
next frame that is output. v2: Incorporated Chris's review comments Changed to check for gen >=8 or gen > 5 before setting M/N registers v3: Incorporated Jani's review comments Re-use cpu_transcoder_set_m_n for BDW. Signed-off-by: Vandana Kannan Signed-off-by: Pradeep Bhat ---

[Intel-gfx] [PATCH 0/6] v7: Enabling DRRS in the kernel

2014-03-27 Thread Vandana Kannan
Bhat (3): drm/i915: Adding VBT fields to support eDP DRRS feature drm/i915: Parse EDID probed modes for DRRS support drm/i915: Add support for DRRS to switch RR Vandana Kannan (3): drm/i915: Idleness detection for DRRS drm/i915/bdw: Add support for DRRS to switch RR drm/i915: Support for

[Intel-gfx] [PATCH 3/6] drm/i915: Add support for DRRS to switch RR

2014-03-27 Thread Vandana Kannan
gned-off-by: Pradeep Bhat Signed-off-by: Vandana Kannan Cc: Jani Nikula --- drivers/gpu/drm/i915/i915_drv.h |5 ++ drivers/gpu/drm/i915/i915_reg.h |1 + drivers/gpu/drm/i915/intel_dp.c | 108 ++ drivers/gpu/drm/i915/intel_drv.h |6 ++- 4 files cha

[Intel-gfx] [PATCH 4/6] drm/i915: Idleness detection for DRRS

2014-03-27 Thread Vandana Kannan
s would be taken care of with calls to crtc page flip itself. This will have to be revisited later if flip infrastructure changes for sprite. v8: Incorporated Jani's review comments. Added space after the periods in the module param description. Changes around drrs-fini to remove seamless DR

Re: [Intel-gfx] [PATCH] drm/edid: Fill PAR in AVI infoframe based on CEA mode list

2014-03-31 Thread Vandana Kannan
On Apr-01-2014 12:35 AM, Daniel Vetter wrote: > On Fri, Mar 21, 2014 at 08:31:29AM +0530, Vandana Kannan wrote: >> Populate PAR in infoframe structure. If there is a user setting for PAR, then >> that value is set. Else, value is taken from CEA mode list if VIC is found. >> El

Re: [Intel-gfx] [PATCH] drm/edid: Fill PAR in AVI infoframe based on CEA mode list

2014-04-01 Thread Vandana Kannan
On Apr-01-2014 12:57 PM, Daniel Vetter wrote: > On Tue, Apr 01, 2014 at 08:06:04AM +0530, Vandana Kannan wrote: >> On Apr-01-2014 12:35 AM, Daniel Vetter wrote: >>> On Fri, Mar 21, 2014 at 08:31:29AM +0530, Vandana Kannan wrote: >>>> Populate PAR in infoframe structu

[Intel-gfx] [PATCH v2] drm/edid: Fill PAR in AVI infoframe based on CEA mode list

2014-04-01 Thread Vandana Kannan
which sets PAR according to user input, based on Daniel's review comments. A separate patch will be submitted to create a property that would enable a user space app to set aspect ratio for AVI infoframe. Signed-off-by: Vandana Kannan Cc: Jesse Barnes Cc: Vijay Purushothaman Cc: Ville Syrjäl

Re: [Intel-gfx] [PATCH v2] drm/edid: Fill PAR in AVI infoframe based on CEA mode list

2014-04-01 Thread Vandana Kannan
On Apr-01-2014 5:04 PM, Ville Syrjälä wrote: > On Tue, Apr 01, 2014 at 04:26:59PM +0530, Vandana Kannan wrote: >> Populate PAR in infoframe structure. If there is a user setting for PAR, then >> that value is set. Else, value is taken from CEA mode list if VIC is found. >> El

[Intel-gfx] [PATCH v3] drm/edid: Fill PAR in AVI infoframe based on CEA mode list

2014-04-01 Thread Vandana Kannan
ff-by: Vandana Kannan Cc: Jesse Barnes Cc: Vijay Purushothaman Cc: Ville Syrjälä Cc: intel-gfx@lists.freedesktop.org Reviewed-by: Jesse Barnes --- drivers/gpu/drm/drm_edid.c | 21 + include/drm/drm_crtc.h | 1 + 2 files changed, 22 insertions(+) diff --git a/drivers/gp

[Intel-gfx] [PATCH v4] drm/edid: Fill PAR in AVI infoframe based on CEA mode list

2014-04-01 Thread Vandana Kannan
et aspect ratio for AVI infoframe. Signed-off-by: Vandana Kannan Cc: Jesse Barnes Cc: Vijay Purushothaman Cc: Ville Syrjälä Cc: intel-gfx@lists.freedesktop.org Cc: Wu, Fengguang Reviewed-by: Jesse Barnes --- drivers/gpu/drm/drm_edid.c | 22 ++ include/drm/drm_crtc.h

Re: [Intel-gfx] [PATCH 3/6] drm/i915: Add support for DRRS to switch RR

2014-04-01 Thread Vandana Kannan
On Apr-01-2014 6:55 PM, Jani Nikula wrote: > On Fri, 28 Mar 2014, Vandana Kannan wrote: >> From: Pradeep Bhat >> >> This patch computes and stored 2nd M/N/TU for switching to different >> refresh rate dynamically. PIPECONF_EDP_RR_MODE_SWITCH bit helps toggle >>

[Intel-gfx] [PATCH v8 2/6] drm/i915: Parse EDID probed modes for DRRS support

2014-04-03 Thread Vandana Kannan
y. Make drrs_state and unnamed struct. Move Gen based check inside drrs_init. v8: Made changes to track PSR enable/disable throughout system use (instead of just in the init sequence) for disabling/enabling DRRS. Jani's review comments. Signed-off-by: Pradeep Bhat Signed-off-by: Vandana Kannan

[Intel-gfx] [PATCH v9 3/6] drm/i915: Add support for DRRS to switch RR

2014-04-03 Thread Vandana Kannan
. v9: Jani's review comments. Modified comment in set_drrs. Changed index to type edp_drrs_refresh_rate_type. Check if PSR is enabled before setting registers fo DRRS. Signed-off-by: Pradeep Bhat Signed-off-by: Vandana Kannan Cc: Jani Nikula --- drivers/gpu/drm/i915/i915_drv.h | 1 + driver

[Intel-gfx] [PATCH v9 4/6] drm/i915: Idleness detection for DRRS

2014-04-03 Thread Vandana Kannan
check. v9: Added checks for PSR before updating DRRS. Added check for module param drrs_interval before updating DRRS (this is required if the interval is modified by the user during system use). DRRS disabled by default. Changes based on Jani's review comments Signed-off-by: Vandana Kannan

[Intel-gfx] [PATCH v9 2/6] drm/i915: Parse EDID probed modes for DRRS support

2014-04-03 Thread Vandana Kannan
patch. Removed PSR state tracker in i915_drrs. Jani's review comments. Signed-off-by: Pradeep Bhat Signed-off-by: Vandana Kannan Cc: Jani Nikula --- drivers/gpu/drm/i915/intel_dp.c | 43 +++- drivers/gpu/drm/i915/intel_drv.h | 16 +++ 2 fil

[Intel-gfx] [PATCH v9 3/6] drm/i915: Add support for DRRS to switch RR

2014-04-03 Thread Vandana Kannan
. v9: Jani's review comments. Modified comment in set_drrs. Changed index to type edp_drrs_refresh_rate_type. Check if PSR is enabled before setting registers fo DRRS. Signed-off-by: Pradeep Bhat Signed-off-by: Vandana Kannan Cc: Jani Nikula --- drivers/gpu/drm/i915/i915_drv.h | 5 ++ driver

[Intel-gfx] [PATCH v10 4/6] drm/i915: Idleness detection for DRRS

2014-04-03 Thread Vandana Kannan
check. v9: Added checks for PSR before updating DRRS. Added check for module param drrs_interval before updating DRRS (this is required if the interval is modified by the user during system use). DRRS disabled by default. Changes based on Jani's review comments v10: Disable/enable DRRS when PS

[Intel-gfx] [PATCH v10 2/6] drm/i915: Parse EDID probed modes for DRRS support

2014-04-04 Thread Vandana Kannan
patch. Removed PSR state tracker in i915_drrs. Jani's review comments. v10: Added log for DRRS not supported in drrs_init Signed-off-by: Pradeep Bhat Signed-off-by: Vandana Kannan Cc: Jani Nikula --- drivers/gpu/drm/i915/intel_dp.c | 45 +++

[Intel-gfx] [PATCH v11 4/6] drm/i915: Idleness detection for DRRS

2014-04-04 Thread Vandana Kannan
PSR is enable/disabled. v11: Moved DRRS not supported log to patch2. Signed-off-by: Vandana Kannan Signed-off-by: Pradeep Bhat Cc: Jani Nikula --- drivers/gpu/drm/i915/i915_drv.h | 7 ++ drivers/gpu/drm/i915/i915_params.c | 8 ++ drivers/gpu/drm/i915/intel_display.c | 16 +++

Re: [Intel-gfx] [PATCH v10 2/6] drm/i915: Parse EDID probed modes for DRRS support

2014-04-04 Thread Vandana Kannan
On Apr-04-2014 4:25 PM, Jani Nikula wrote: > On Fri, 04 Apr 2014, Vandana Kannan wrote: >> From: Pradeep Bhat >> >> This patch and finds out the lowest refresh rate supported for the resolution >> same as the fixed_mode. >> It also checks the VBT fields to see i

  1   2   3   >