[Intel-gfx] [PATCH i-g-t] lib: Make sure we don't use a negative offset

2017-01-06 Thread Tomeu Vizoso
As bytes_read can contain an error condition under some circumstances, in which we want to error out. Signed-off-by: Tomeu Vizoso --- lib/igt_debugfs.c | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/igt_debugfs.c b/lib/igt_debugfs.c index d828687a62ca..b1b67e740041 100644 --- a/lib

[Intel-gfx] [RESEND PATCH v14 0/2] New debugfs API for capturing CRC of frames

2017-01-10 Thread Tomeu Vizoso
Hi, here are the last two patches that remain to be merged in this series, rebased on today's drm-tip. Thanks, Tomeu Tomeu Vizoso (2): drm/i915: Use new CRC debugfs API drm/i915: Put "cooked" vlank counters in frame CRC lines drivers/gpu/drm/i915/i915_drv.h | 1 +

[Intel-gfx] [RESEND PATCH v14 1/2] drm/i915: Use new CRC debugfs API

2017-01-10 Thread Tomeu Vizoso
the new ABI we skip the 1st or 2nd frames. v9: - Add stub for intel_crtc_set_crc_source. v12: - Rebased. - Remove stub for intel_crtc_set_crc_source and instead set the callback to NULL (Jani Nikula). v15: - Rebased. Signed-off-by: Tomeu Vizoso Reviewed-by: Emil

[Intel-gfx] [RESEND PATCH v14 2/2] drm/i915: Put "cooked" vlank counters in frame CRC lines

2017-01-10 Thread Tomeu Vizoso
Use drm_accurate_vblank_count so we have the full 32 bit to represent the frame counter and userspace has a simpler way of knowing when the counter wraps around. Signed-off-by: Tomeu Vizoso Reviewed-by: Emil Velikov Reviewed-by: Robert Foss --- drivers/gpu/drm/i915/i915_irq.c | 6 +++--- 1

Re: [Intel-gfx] [RESEND PATCH v14 2/2] drm/i915: Put "cooked" vlank counters in frame CRC lines

2017-01-16 Thread Tomeu Vizoso
On 10 January 2017 at 17:31, Daniel Vetter wrote: > On Tue, Jan 10, 2017 at 05:54:57PM +0200, Ville Syrjälä wrote: >> On Tue, Jan 10, 2017 at 02:43:05PM +0100, Tomeu Vizoso wrote: >> > Use drm_accurate_vblank_count so we have the full 32 bit to represent >> > the frame

Re: [Intel-gfx] [PATCH] drm/vblank: WARN_ON nested use of drm_vblank_on/off

2015-06-26 Thread Tomeu Vizoso
On 22 June 2015 at 14:02, Daniel Vetter wrote: > We should never nest these since in theory kms drivers should know > when a pipe is on/off and call the corresponding enable/disable > functions for the vblank helper code only once. But for historical > reasons (the shared-with-ums version of this

<    1   2   3