(printing the supported formats), and skip the test if there
aren't enough overlay planes.
Thanks,
Tomeu
Tomeu Vizoso (2):
lib: Check format of framebuffer before SetPlane
kms_plane_scaling: Skip if we don't have enough overlays
lib/igt_kms.c
ke machine with just one overlay.
Signed-off-by: Tomeu Vizoso
---
lib/igt_kms.c | 35 +++
1 file changed, 35 insertions(+)
diff --git a/lib/igt_kms.c b/lib/igt_kms.c
index 989704e14803..3234fa1bbdc4 100644
--- a/lib/igt_kms.c
+++ b/lib/igt_kms.c
@@ -1670,6 +16
intel_display_crc_init accept a drm_i915_private instead.
v12: Rebased.
Signed-off-by: Tomeu Vizoso
Reviewed-by: Emil Velikov
---
drivers/gpu/drm/i915/Makefile | 2 +-
drivers/gpu/drm/i915/i915_debugfs.c | 882 +--
drivers/gpu/drm/i915/intel_drv.h | 5 +
drivers
the new ABI we
skip the 1st or 2nd frames.
v9:
- Add stub for intel_crtc_set_crc_source.
v12:
- Rebased.
- Remove stub for intel_crtc_set_crc_source and instead set the
callback to NULL (Jani Nikula).
Signed-off-by: Tomeu Vizoso
Reviewed-by: Emil Velikov
---
drivers/g
Tomeu Vizoso (4):
drm/i915/debugfs: Move out pipe CRC code
drm: Move locking into drm_debugfs_crtc_crc_add
drm/i915: Use new CRC debugfs API
drm/i915: Put "cooked" vlank counters in frame CRC lines
drivers/gpu/drm/drm_debugfs_crc.c |9 +-
drivers/gpu/drm/i915/Makefile
Use drm_accurate_vblank_count so we have the full 32 bit to represent
the frame counter and userspace has a simpler way of knowing when the
counter wraps around.
Signed-off-by: Tomeu Vizoso
Reviewed-by: Emil Velikov
---
drivers/gpu/drm/i915/i915_irq.c | 6 +++---
1 file changed, 3 insertions
The kernel has now a new debugfs ABI that can also allow capturing frame
CRCs for drivers other than i915.
Add alternative codepaths so the new ABI is used if the kernel is recent
enough, and fall back to the legacy ABI if not.
Signed-off-by: Tomeu Vizoso
---
Hi,
this has been rebased so
Hi Robert,
looks pretty good to me, have just found a few nits.
With those addressed:
Reviewed-by: Tomeu Vizoso
Regards,
Tomeu
On 22 November 2016 at 14:28, wrote:
> From: Robert Foss
>
> Base functions to help testing the Sync File Framework (explicit fencing
> mechanism
On 22 November 2016 at 14:28, wrote:
> From: Robert Foss
>
> This subtest verifies the access ordering of multiple consumer threads.
>
> Signed-off-by: Robert Foss
> Reviewed-by: Eric Engestrom
> ---
> tests/sw_sync.c | 103
>
> 1 file
This series has my Reviewed-by tag with the small issues I pointed out
addressed. But I think it would be very good if you could go through
all the igt_assert* calls and make sure that no information is being
lost that could aid in triaging and debugging.
The messages you chose for igt_assert_f we
Add a few subtests that check that lossless compressed render targets
are properly displayed. Also test a few error conditions.
Cc: Ville Syrjälä
Cc: Ben Widawsky
Signed-off-by: Tomeu Vizoso
---
Hi,
this has been tested with Ville's branch at:
https://github.com/vsyrjala/linux
So that debug logs contain the unexpected value.
Signed-off-by: Tomeu Vizoso
---
lib/igt_kms.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/igt_kms.c b/lib/igt_kms.c
index 989704e14803..1e30ddcc5373 100644
--- a/lib/igt_kms.c
+++ b/lib/igt_kms.c
@@ -1681,7 +1681,7
On 21 November 2016 at 23:32, Lyude wrote:
> Unfortunately the assumption that we only have 6 display pipes available
> is specific to Intel, and seems to be breaking igt_display_init() on
> both radeon and nouveau since this causes us not to leave enough space
> in the igt_display_t struct to hol
On 21 November 2016 at 23:32, Lyude wrote:
> On certain models of nvidia and AMD GPUs, we can have a primary plane
> without any DRM plane for the cursor plane. Check for this so we don't
> segfault on non-intel hardware.
>
> Signed-off-by: Lyude
> ---
> lib/igt_kms.c | 27 +++---
Hi Lyude,
this looks very good. Some minor comments below.
Regards,
Tomeu
On 1 December 2016 at 02:24, Lyude wrote:
> For the purpose of testing things such as hotplugging and bad monitors,
> the ChromeOS team ended up designing a neat little device known as the
> Chamelium. More information o
On 7 December 2016 at 20:56, Lyude Paul wrote:
> On Wed, 2016-12-07 at 12:27 +0100, Tomeu Vizoso wrote:
>> On 1 December 2016 at 02:24, Lyude wrote:
(big snip)
>> > + * By default, this file is expected to exist in
>> > ~/.igt_chamelium_rc . The
>> > + * di
ris Wilson
Cc: Tomi Sarvela
Cc: intel-gfx@lists.freedesktop.org
Signed-off-by: Tomeu Vizoso
---
drivers/gpu/drm/drm_edid.c | 13 -
1 file changed, 8 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c
index 6798c3ad9d53..db79bc949216 10
intel_display_crc_init accept a drm_i915_private instead.
v12: Rebased.
Signed-off-by: Tomeu Vizoso
Reviewed-by: Emil Velikov
---
drivers/gpu/drm/i915/Makefile | 2 +-
drivers/gpu/drm/i915/i915_debugfs.c | 882 +--
drivers/gpu/drm/i915/intel_drv.h | 5 +
drivers
Use drm_accurate_vblank_count so we have the full 32 bit to represent
the frame counter and userspace has a simpler way of knowing when the
counter wraps around.
Signed-off-by: Tomeu Vizoso
Reviewed-by: Emil Velikov
---
drivers/gpu/drm/i915/i915_irq.c | 6 +++---
1 file changed, 3 insertions
Hi,
here are the patches that remain to be merged in this series.
I have only rebased them since last time.
Thanks,
Tomeu
Tomeu Vizoso (3):
drm: Move locking into drm_debugfs_crtc_crc_add
drm/i915: Use new CRC debugfs API
drm/i915: Put "cooked" vlank counters in frame
the new ABI we
skip the 1st or 2nd frames.
v9:
- Add stub for intel_crtc_set_crc_source.
v12:
- Rebased.
- Remove stub for intel_crtc_set_crc_source and instead set the
callback to NULL (Jani Nikula).
Signed-off-by: Tomeu Vizoso
Reviewed-by: Emil Velikov
---
drivers/g
On 20 April 2016 at 20:16, wrote:
> From: Ville Syrjälä
>
> create_bo_for_fb() expects the drm format as a parameter since
> commit 8a1a38661f56 ("lib: Add igt_create_bo_with_dimensions")
> but not all callers were updated. Fix that up.
>
> Cc: Tomeu Vizoso
&
On 20 April 2016 at 16:59, wrote:
> From: Robert Foss
>
> Fix issue where the plane counting fails due to the number and
> configuration of planes being unlike the intel configuration.
>
> Signed-off-by: Robert Foss
> ---
> lib/igt_kms.c | 6 --
> 1 file changed, 4 insertions(+), 2 deletio
On 20 April 2016 at 16:59, wrote:
> From: Robert Foss
>
> Avoid overwriting planes with statically asigned indices
> with planes that have dynamically assigned indices.
>
> Signed-off-by: Robert Foss
> ---
> lib/igt_kms.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/lib/igt_kms.c
On 20 April 2016 at 16:59, wrote:
> From: Robert Foss
>
> Avoid moving the cursor plane when on non-intel hardware.
> Running the move block on hardware with more than IGT_PLANE_CURSOR
> number of planes causes planes do be zeroed out.
>
> Signed-off-by: Robert Foss
> ---
> lib/igt_kms.c | 2 +
up calling just create_bo_for_fb with
a zero size because now the later is more generic than the former.
Also, create_bo_for_fb now returns the handle of the BO that was
created, as there's no point anymore in having it be a parameter passed
by reference.
Signed-off-by: Tomeu Vizoso
---
On 20 April 2016 at 16:12, Daniel Vetter wrote:
> On Wed, Apr 20, 2016 at 03:57:53PM +0200, Tomeu Vizoso wrote:
>> On 20 April 2016 at 15:10, Daniel Vetter wrote:
>> > On Mon, Apr 18, 2016 at 01:42:48PM +0200, Tomeu Vizoso wrote:
>> >> Hi,
>> >>
>>
On 25 April 2016 at 15:13, Tomeu Vizoso wrote:
> On 20 April 2016 at 16:12, Daniel Vetter wrote:
>> On Wed, Apr 20, 2016 at 03:57:53PM +0200, Tomeu Vizoso wrote:
>>> On 20 April 2016 at 15:10, Daniel Vetter wrote:
>>> > On Mon, Apr 18, 2016 at 01:42:48PM +0200,
On 21 April 2016 at 11:20, Daniel Vetter wrote:
> On Wed, Apr 20, 2016 at 12:25:50PM -0400, robert.f...@collabora.com wrote:
>> From: Robert Foss
>>
>> This series enables tests/core_getversion to test vc4.
>> It's been tested on rpi2 hardware and kernel 4.6.0-rc1.
>
> Ack on both from my side.
On 25 April 2016 at 17:05, wrote:
> From: Robert Foss
>
> Increase the number of planes supported to 10.
>
> kmstest_plane_name only previously supported 4 planes,
> this patch adds support for up to 10 planes.
>
> Signed-off-by: Robert Foss
> ---
> lib/igt_kms.c | 6 ++
> lib/igt_kms.h |
On 25 April 2016 at 16:35, wrote:
> From: Robert Foss
>
>
> Changes since v1:
> - Squash patches
> - Based patch on
> https://lists.freedesktop.org/archives/intel-gfx/2016-March/090617.html
Thanks for the patches, you can add my Reviewed-by tag to all except
the 6th patch, about which I don't
On 25 April 2016 at 17:05, wrote:
> From: Robert Foss
>
> Previously crtc0 was statically used for VBLANK tests, but
> that assumption is not valid for the VC4 platform.
> Instead we're now explicitly setting the mode.
>
> Also add support for testing all connected connectors during
> the same t
Paint the color key with cairo, so the test doesn't have to map the BO
by itself, which depends on the driver being tested.
Signed-off-by: Tomeu Vizoso
---
Don't know what's the purpose of drawing this rect, so it would be
better to remove it if it isn't needed.
---
test
So that this test can be run in drivers other than i915.
Signed-off-by: Tomeu Vizoso
---
tests/testdisplay.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/testdisplay.c b/tests/testdisplay.c
index f821bcc64779..45280e4cad82 100644
--- a/tests/testdisplay.c
+++ b
Allow users of autogen.sh to skip the call to configure, which is needed
when building out of tree.
Signed-off-by: Tomeu Vizoso
---
autogen.sh | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/autogen.sh b/autogen.sh
index 629a2575532d..ec633f3efefd 100755
--- a/autogen.sh
For drivers other than i915, the "auto" source for a given CRTC may be
only able to generate CRCs in specific modeset configurations.
So allow the tests to find out if CRC generation is possible by
returning an error when CRC capture would start so tests can be skipped.
Signed-off
The kernel has now a new debugfs ABI that can also allow capturing frame
CRCs for drivers other than i915.
Add alternative codepaths so the new ABI is used if the kernel is recent
enough, and fall back to the legacy ABI if not.
Signed-off-by: Tomeu Vizoso
---
lib/igt_debugfs.c | 236
for hardware that can provide frame CRCs (including eDP
panels that support self-refresh) can easily implement the new callback
and provide userspace with the CRC values.
Thanks,
Tomeu
Tomeu Vizoso (4):
drm/i915/debugfs: Move out pipe CRC code
drm: Add API for capturing frame CRCs
drm/i915
In preparation to using a generic API in the DRM core for continuous CRC
generation, move the related code out of i915_debugfs.c into a new file.
Eventually, only the Intel-specific code will remain in this new file.
v2: Rebased.
v6: Rebased.
v7: Fix whitespace issue.
Signed-off-by: Tomeu
Use drm_accurate_vblank_count so we have the full 32 bit to represent
the frame counter and userspace has a simpler way of knowing when the
counter wraps around.
Signed-off-by: Tomeu Vizoso
Reviewed-by: Emil Velikov
---
drivers/gpu/drm/i915/i915_irq.c | 6 +++---
1 file changed, 3 insertions
the new ABI we
skip the 1st or 2nd frames.
Signed-off-by: Tomeu Vizoso
Reviewed-by: Emil Velikov
---
drivers/gpu/drm/i915/i915_drv.h | 1 +
drivers/gpu/drm/i915/i915_irq.c | 83 +--
drivers/gpu/drm/i915/intel_display.c | 1 +
drivers/gpu/drm/i915
On 8 September 2016 at 15:35, Emil Velikov wrote:
> Hi Tomeu,
>
> Just a couple of nitpicks. Nothing that has to be fixed or (if you
> agree) cannot be done on top/later on.
>
> On 7 September 2016 at 11:27, Tomeu Vizoso wrote:
>> The core provides now an ABI to userspace
for hardware that can provide frame CRCs (including eDP
panels that support self-refresh) can easily implement the new callback
and provide userspace with the CRC values.
Thanks,
Tomeu
Tomeu Vizoso (4):
drm/i915/debugfs: Move out pipe CRC code
drm: Add API for capturing frame CRCs
drm/i915
Use drm_accurate_vblank_count so we have the full 32 bit to represent
the frame counter and userspace has a simpler way of knowing when the
counter wraps around.
Signed-off-by: Tomeu Vizoso
Reviewed-by: Emil Velikov
---
drivers/gpu/drm/i915/i915_irq.c | 6 +++---
1 file changed, 3 insertions
In preparation to using a generic API in the DRM core for continuous CRC
generation, move the related code out of i915_debugfs.c into a new file.
Eventually, only the Intel-specific code will remain in this new file.
v2: Rebased.
v6: Rebased.
v7: Fix whitespace issue.
Signed-off-by: Tomeu
the new ABI we
skip the 1st or 2nd frames.
Signed-off-by: Tomeu Vizoso
Reviewed-by: Emil Velikov
---
drivers/gpu/drm/i915/i915_drv.h | 1 +
drivers/gpu/drm/i915/i915_irq.c | 83 +--
drivers/gpu/drm/i915/intel_display.c | 1 +
drivers/gpu/drm/i915
On 12 September 2016 at 09:11, Liu Ying wrote:
> Allowing modeset may prevent the test case from failing in case the atomic
> check phase finds the userspace doesn't allow modeset for the commit and
> returns -EINVAL. A real case is to run the test case on imx-drm which
> requires a full modeset
So, let's add CRC debugfs files
> only for those drivers that do modeset.
>
> Signed-off-by: Dhinakaran Pandiyan
> Cc: Tomeu Vizoso
> Cc: Daniel Vetter
> Cc: Emil Velikov
Reviewed-by: Tomeu Vizoso
But I would prefer if drm_for_each_crtc was safe to call in any de
The kernel has now a new debugfs ABI that can also allow capturing frame
CRCs for drivers other than i915.
Add alternative codepaths so the new ABI is used if the kernel is recent
enough, and fall back to the legacy ABI if not.
Signed-off-by: Tomeu Vizoso
---
lib/igt_debugfs.c | 236
The kernel has now a new debugfs ABI that can also allow capturing frame
CRCs for drivers other than i915.
Add alternative codepaths so the new ABI is used if the kernel is recent
enough, and fall back to the legacy ABI if not.
Signed-off-by: Tomeu Vizoso
---
Have just dropped the additional
Add stub for intel_crtc_set_crc_source() and fix arguments of stub for
intel_display_crc_init().
Signed-off-by: Tomeu Vizoso
Fixes: 21165bd933ac ("drm/i915/debugfs: Move out pipe CRC code")
Fixes: 13fa0253d97a ("drm/i915: Use new CRC debugfs API")
---
drivers/gpu/drm/
Add stub for intel_crtc_set_crc_source() and fix arguments of
intel_display_crc_init().
Signed-off-by: Tomeu Vizoso
Fixes: 21165bd933ac ("drm/i915/debugfs: Move out pipe CRC code")
Fixes: 13fa0253d97a ("drm/i915: Use new CRC debugfs API")
---
drivers/gpu/drm/i915/
.load callback (tested on
Tegra124).
Thanks,
Tomeu
Tomeu Vizoso (4):
drm/i915/debugfs: Move out pipe CRC code
drm: Add API for capturing frame CRCs
drm/i915: Use new CRC debugfs API
drm/i915: Put "cooked" vlank counters in frame CRC lines
Documentation/gpu/drm-uapi.rst|
Use drm_accurate_vblank_count so we have the full 32 bit to represent
the frame counter and userspace has a simpler way of knowing when the
counter wraps around.
Signed-off-by: Tomeu Vizoso
Reviewed-by: Emil Velikov
---
drivers/gpu/drm/i915/i915_irq.c | 6 +++---
1 file changed, 3 insertions
intel_display_crc_init accept a drm_i915_private instead.
Signed-off-by: Tomeu Vizoso
Reviewed-by: Emil Velikov
---
drivers/gpu/drm/i915/Makefile | 2 +-
drivers/gpu/drm/i915/i915_debugfs.c | 886 +---
drivers/gpu/drm/i915/intel_drv.h | 5 +
drivers/gpu/drm/i915
the new ABI we
skip the 1st or 2nd frames.
v9:
- Add stub for intel_crtc_set_crc_source.
Signed-off-by: Tomeu Vizoso
Reviewed-by: Emil Velikov
---
drivers/gpu/drm/i915/i915_drv.h | 1 +
drivers/gpu/drm/i915/i915_irq.c | 83 +--
drivers/g
for hardware that can provide frame CRCs (including eDP
panels that support self-refresh) can easily implement the new callback
and provide userspace with the CRC values.
In this v10 debugfs creation failures don't abort CRTC registration, as
suggested by Emil Velikov.
Thanks,
Tomeu
Tomeu V
the new ABI we
skip the 1st or 2nd frames.
v9:
- Add stub for intel_crtc_set_crc_source.
Signed-off-by: Tomeu Vizoso
Reviewed-by: Emil Velikov
---
drivers/gpu/drm/i915/i915_drv.h | 1 +
drivers/gpu/drm/i915/i915_irq.c | 83 +--
drivers/g
intel_display_crc_init accept a drm_i915_private instead.
Signed-off-by: Tomeu Vizoso
Reviewed-by: Emil Velikov
---
drivers/gpu/drm/i915/Makefile | 2 +-
drivers/gpu/drm/i915/i915_debugfs.c | 886 +---
drivers/gpu/drm/i915/intel_drv.h | 5 +
drivers/gpu/drm/i915
Use drm_accurate_vblank_count so we have the full 32 bit to represent
the frame counter and userspace has a simpler way of knowing when the
counter wraps around.
Signed-off-by: Tomeu Vizoso
Reviewed-by: Emil Velikov
---
drivers/gpu/drm/i915/i915_irq.c | 6 +++---
1 file changed, 3 insertions
for hardware that can provide frame CRCs (including eDP
panels that support self-refresh) can easily implement the new callback
and provide userspace with the CRC values.
Sorry about that, but there was a dangling brace in v10 breaking the build so
here is this v11.
Thanks,
Tomeu
Tomeu Vizoso (4
intel_display_crc_init accept a drm_i915_private instead.
Signed-off-by: Tomeu Vizoso
Reviewed-by: Emil Velikov
---
drivers/gpu/drm/i915/Makefile | 2 +-
drivers/gpu/drm/i915/i915_debugfs.c | 886 +---
drivers/gpu/drm/i915/intel_drv.h | 5 +
drivers/gpu/drm/i915
the new ABI we
skip the 1st or 2nd frames.
v9:
- Add stub for intel_crtc_set_crc_source.
Signed-off-by: Tomeu Vizoso
Reviewed-by: Emil Velikov
---
drivers/gpu/drm/i915/i915_drv.h | 1 +
drivers/gpu/drm/i915/i915_irq.c | 83 +--
drivers/g
Use drm_accurate_vblank_count so we have the full 32 bit to represent
the frame counter and userspace has a simpler way of knowing when the
counter wraps around.
Signed-off-by: Tomeu Vizoso
Reviewed-by: Emil Velikov
---
drivers/gpu/drm/i915/i915_irq.c | 6 +++---
1 file changed, 3 insertions
When moving the call to gem_set_tiling into the subtests, the one needed
by addfb25-framebuffer-vs-set-tiling was left out.
Signed-off-by: Tomeu Vizoso
---
tests/kms_addfb_basic.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/tests/kms_addfb_basic.c b/tests/kms_addfb_basic.c
index
) = 0; \
^
tests/kms_addfb_basic.c:245:3: note: in expansion of macro 'igt_fixture'
igt_fixture {
Signed-off-by: Tomeu Vizoso
---
lib/igt_core.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/igt_core.h b/lib/igt_core.h
i
So those subtests that require tiling don't cause unrelated subtests to
be skipped.
Signed-off-by: Tomeu Vizoso
---
tests/kms_addfb_basic.c | 148
1 file changed, 73 insertions(+), 75 deletions(-)
diff --git a/tests/kms_addfb_basic.c b/
Hello,
can these two patches be pushed if everybody is fine with them?
Thanks,
Tomeu
On 9 March 2016 at 16:57, Tomeu Vizoso wrote:
> Hi,
>
> these two patches remove the two last uses of
> DRM_IOCTL_I915_GET_PIPE_FROM_CRTC_ID, with the intention of making the
> tests runnable
So the test runs on other drivers, drop the usage of the i915-specific
DRM_IOCTL_I915_GET_PIPE_FROM_CRTC_ID ioctl.
Wait for a vblank event on pipe0 and if we get it, then the test can
proceed (code copied from kms_vblank).
Signed-off-by: Tomeu Vizoso
---
tests/drm_read.c | 44
Hi,
these patches allow a few more tests to run on drivers other than i915,
mainly by removing the last usage of
DRM_IOCTL_I915_GET_PIPE_FROM_CRTC_ID and removing superfluous dependencies
on bufmgr and tiled BOs.
Thanks,
Tomeu
Tomeu Vizoso (7):
tests/drm_read: Drop
Because attempts to create a tiled BO will cause a igt_require call to
fail on drivers that don't support tiling, do so in the subtest that
actually needs it so that other subtests aren't skipped without reason.
Signed-off-by: Tomeu Vizoso
---
tests/kms_flip.c | 11 +++
1 fi
Batchbuffers are only needed in the subtest that does the blit on the
GPU, so move that dependency into it so the other subtest can be ran on
!i915.
Signed-off-by: Tomeu Vizoso
---
tests/kms_render.c | 21 -
1 file changed, 12 insertions(+), 9 deletions(-)
diff --git a
So that this test can be run in drivers other than i915.
Signed-off-by: Tomeu Vizoso
---
tests/kms_flip_event_leak.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/kms_flip_event_leak.c b/tests/kms_flip_event_leak.c
index 0a4a755ee954..a1389b4c5e1d 100644
--- a
So that this test can be run in drivers other than i915.
Signed-off-by: Tomeu Vizoso
---
tests/kms_flip.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/kms_flip.c b/tests/kms_flip.c
index 58b167d46d90..dc251e902bef 100644
--- a/tests/kms_flip.c
+++ b/tests
Because bufmgr is currently a i915-only thing and it's only needed in a
subset of the subtests, require it only in the subtests that actually
need it so that the other subtests aren't skipped without a reason.
Signed-off-by: Tomeu Vizoso
---
tests/kms_flip.c | 12 ++--
1 fi
As the test doesn't actually need tiled BOs, drop the tiled formats so
the test can run on drivers other than i915.
Signed-off-by: Tomeu Vizoso
---
tests/kms_flip_event_leak.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/kms_flip_event_leak.c b/
On 18 April 2016 at 14:09, Daniel Vetter wrote:
> On Wed, Mar 09, 2016 at 04:57:37PM +0100, Tomeu Vizoso wrote:
>> From: Micah Fedke
>>
>> This function uses an intel-specific ioctl to fetch a mapping between pipes
>> and
>> crtc ids, but this technique is outd
instead of
querying for the pipe number (which should return the same value).
Thanks,
Tomeu
Tomeu Vizoso (2):
lib: Remove superfluous kmstest_connector_config.pipe
tests/kms_setmode: Remove superfluous call to
kmstest_get_pipe_from_crtc_id
lib/igt_kms.c
connector_config.crtc_idx already contains the pipe ID, so just use that
and drop the call to kmstest_get_pipe_from_crtc_id which is problematic
on drivers other than i915 because it uses
DRM_IOCTL_I915_GET_PIPE_FROM_CRTC_ID.
Signed-off-by: Tomeu Vizoso
danvet
---
tests/kms_setmode.c | 5
nning the tests on drivers other than i915.
Signed-off-by: Tomeu Vizoso
---
lib/igt_kms.c | 24 +++-
lib/igt_kms.h | 1 -
tests/kms_crtc_background_color.c | 2 +-
tests/kms_flip.c | 10 +-
tests/kms_flip_til
On 20 April 2016 at 15:10, Daniel Vetter wrote:
> On Mon, Apr 18, 2016 at 01:42:48PM +0200, Tomeu Vizoso wrote:
>> Hi,
>>
>> these patches allow a few more tests to run on drivers other than i915,
>> mainly by removing the last usage of
>> DRM_IOCTL_I915_G
s and calculates an acceptable difference taking into account
the vertical refresh rate of the current mode.
Signed-off-by: Tomeu Vizoso
References: https://bugs.freedesktop.org/show_bug.cgi?id=98289
---
tests/kms_flip.c | 16
1 file changed, 12 insertions(+), 4 deletions(-)
diff
Patch looks good to me, but I think the signal changes should be in
their own commit.
On 7 February 2017 at 16:12, Maarten Lankhorst
wrote:
...
> +#define VG(x) x
> +#else
> +#define VG(x)
> +#endif
Wouldn't be better to stub VALGRIND_MAKE_MEM_DEFINED instead?
Regards,
Tomeu
__
bug.cgi?id=99869
Signed-off-by: Tomeu Vizoso
---
drivers/gpu/drm/drm_edid.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c
index 24e7b282f16c..d994ccf94f88 100644
--- a/drivers/gpu/drm/drm_edid.c
+++ b/drivers/gpu/drm/drm_edid.c
@@ -148,6
Looks good to me:
Reviewed-by: Tomeu Vizoso
I guess you have tested this with IGT? In any case, I think it would
be good to mention how a patch has been tested in the changelog. That
can be very useful to others if things go wrong at some point.
Thanks,
Tomeu
On 21 June 2017 at 13:00
Instead of checking for "i915_error_state" within dri/N/, check for
"name".
This allows more tests to run against drivers other than i915.
Signed-off-by: Tomeu Vizoso
---
lib/igt_debugfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/igt_debugfs.c
Some frame sources such as sinks aren't able to provide meaningful frame
numbers, so in those cases just skip the TEST_SEQUENCE tests.
Signed-off-by: Tomeu Vizoso
---
tests/kms_pipe_crc_basic.c | 29 +++--
1 file changed, 23 insertions(+), 6 deletions(-)
diff --
On 2 March 2017 at 11:12, Chris Wilson wrote:
> On Thu, Mar 02, 2017 at 11:08:25AM +0100, Tomeu Vizoso wrote:
>> Instead of checking for "i915_error_state" within dri/N/, check for
>> "name".
>>
>> This allows more tests to run against drivers
On 2 March 2017 at 14:46, Chris Wilson wrote:
> On Thu, Mar 02, 2017 at 02:39:16PM +0100, Tomeu Vizoso wrote:
>> On 2 March 2017 at 11:12, Chris Wilson wrote:
>> > On Thu, Mar 02, 2017 at 11:08:25AM +0100, Tomeu Vizoso wrote:
>> >> Instead of checking for "i91
Some frame sources such as sinks aren't able to provide meaningful frame
numbers, so in those cases just skip the TEST_SEQUENCE tests.
Signed-off-by: Tomeu Vizoso
---
tests/kms_pipe_crc_basic.c | 29 +++--
1 file changed, 23 insertions(+), 6 deletions(-)
diff --
When opening a DRM debugfs file, locate the right path based on the
given DRM device FD.
This is needed so, in setups with more than one DRM device, any
operations on debugfs files affect the expected DRM device.
Signed-off-by: Tomeu Vizoso
---
Guess we could be more conservative and just
When opening a DRM debugfs file, locate the right path based on the
given DRM device FD.
This is needed so, in setups with more than one DRM device, any
operations on debugfs files affect the expected DRM device.
v2: rebased and fixed new API additions
Signed-off-by: Tomeu Vizoso
Reviewed-by
Some frame sources such as sinks aren't able to provide meaningful frame
numbers, so in those cases just skip the TEST_SEQUENCE tests.
v2: Rebased
Signed-off-by: Tomeu Vizoso
---
tests/kms_pipe_crc_basic.c | 28 ++--
1 file changed, 22 insertions(+), 6 dele
missed previously
- use the minor of the device for the debugfs path, not the major
- have a proper exit handler for calling igt_hpd_storm_reset with the
right device fd.
Signed-off-by: Tomeu Vizoso
Reviewed-by: Robert Foss
---
benchmarks/gem_latency.c | 2 +-
lib
Some frame sources such as sinks aren't able to provide meaningful frame
numbers, so in those cases just skip the TEST_SEQUENCE tests.
v2: Rebased
Signed-off-by: Tomeu Vizoso
---
tests/kms_pipe_crc_basic.c | 28 ++--
1 file changed, 22 insertions(+), 6 dele
Thanks for doing this.
Reviewed-by: Tomeu Vizoso
On 22 March 2017 at 09:36, Daniel Vetter wrote:
> This was missed in Tomeu's patch. Also remove the kerneldoc for the
> internal function, we don't document that in general.
>
> While at it word-smith the docs slightly fo
mp;validation stuff together and give the CRC
>> section a heading for prettier output.
>>
>> Cc: Tomeu Vizoso
>> Cc: Jani Nikula
>> Signed-off-by: Daniel Vetter
>> ---
>> Documentation/gpu/drm-uapi.rst | 25 +++--
>> 1 file cha
could be dropped if it's preferred that userspace waits
for the first frame CRC to come before assuming that the HW is ready.
The other patches are unchanged.
Thanks,
Tomeu
Tomeu Vizoso (4):
drm: Move locking into drm_debugfs_crtc_crc_add
drm: crc: Wait for a frame before returning
Use drm_accurate_vblank_count so we have the full 32 bit to represent
the frame counter and userspace has a simpler way of knowing when the
counter wraps around.
Signed-off-by: Tomeu Vizoso
Reviewed-by: Emil Velikov
Reviewed-by: Robert Foss
---
drivers/gpu/drm/i915/i915_irq.c | 6 +++---
1
the new ABI we
skip the 1st or 2nd frames.
v9:
- Add stub for intel_crtc_set_crc_source.
v12:
- Rebased.
- Remove stub for intel_crtc_set_crc_source and instead set the
callback to NULL (Jani Nikula).
Signed-off-by: Tomeu Vizoso
Reviewed-by: Emil Velikov
Reviewed-by: R
101 - 200 of 206 matches
Mail list logo
