[Intel-gfx] [PATCH 03/17] drm/i915: Add a delay in Displayport AUX transactions for compliance testing

. V2: - Changed udelay() to usleep_range() Signed-off-by: Todd Previte --- drivers/gpu/drm/i915/intel_dp.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c index 1b452cc..b6f5a72 100644 --- a/drivers/gpu/drm

[Intel-gfx] [PATCH 08/17] drm/i915: Add Displayport link configuration structure

s only and should not be used during normal operations. Signed-off-by: Todd Previte --- drivers/gpu/drm/i915/intel_drv.h | 14 ++ 1 file changed, 14 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_drv.h b/drivers/gpu/drm/i915/intel_drv.h index d1a807a..5a8b1d6 100644 --- a/drive

[Intel-gfx] [PATCH 04/17] drm/i915: Add debugfs information for Displayport compliance testing

structures added to support debugfs output for Displayport compliance testing. Signed-off-by: Todd Previte --- drivers/gpu/drm/i915/i915_debugfs.c | 41 + 1 file changed, 41 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gp

[Intel-gfx] [PATCH 15/17] drm/i915: Update debugfs functions for Displayport compliance testing

Updates displayport_config_ctl_write and displayport_config_ctl_show to use the dp_connector_is_valid() function. This saves on code and improves maintainability by unifying the code in a single, common path. Signed-off-by: Todd Previte --- drivers/gpu/drm/i915/i915_debugfs.c | 42

[Intel-gfx] [PATCH 16/17] drm/i915: Add new debugfs file for Displaypor compliance test control

code from the user application. This response code is then sent to the sink device upon completion of the test. Signed-off-by: Todd Previte --- drivers/gpu/drm/i915/i915_debugfs.c | 66 - drivers/gpu/drm/i915/intel_drv.h| 1 + 2 files changed, 66 insertions

[Intel-gfx] [PATCH 13/17] drm/i915: Update intel_dp_hpd_pulse() to check link status for non-MST operation

handler. Signed-off-by: Todd Previte --- drivers/gpu/drm/i915/intel_dp.c | 22 -- 1 file changed, 12 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c index 4a55ca6..73014d8 100644 --- a/drivers/gpu/drm/i915

[Intel-gfx] [PATCH 14/17] drm/i915: Add debugfs function to check connector status for compliance testing

connector is a Displayport connector and whether or not that connector is active. Signed-off-by: Todd Previte --- drivers/gpu/drm/i915/i915_debugfs.c | 29 + 1 file changed, 29 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915

[Intel-gfx] [PATCH 17/17] drm/i915: Add debugfs write and test param parsing function for DP test control

Adds and implements the 'write' function for the debugfs i915_dp_test_ctrl file. Also adds in the required parsing function to read in the data from the file once the user app has written its data to it. Signed-off-by: Todd Previte --- drivers/gpu/drm/i915/i915_debug

[Intel-gfx] [PATCH 12/17] drm/i915: Update intel_dp_compute_config() to handle compliance test requests

Adds provisions in intel_dp_compute_config() to accommodate compliance testing. Mostly this invovles circumventing the automatic link configuration parameters and allowing the compliance code to set those parameters as required by the tests. Signed-off-by: Todd Previte --- drivers/gpu/drm/i915

Re: [Intel-gfx] [PATCH 05/11] drm/fb_helper: allow adding/removing connectors later

Minor formatting issues - there's a number of lines that exceed 80 characters in length. One other comment inline below. Reviewed-by: Todd Previte Dave Airlie <mailto:airl...@gmail.com> Tuesday, May 20, 2014 7:54 PM From: Dave Airlie This is required to get fbcon probing to

Re: [Intel-gfx] [PATCH 09/11] drm/i915: check connector->encoder before using it.

Looks good. Reviewed-by: Todd Previte Dave Airlie <mailto:airl...@gmail.com> Tuesday, May 20, 2014 7:55 PM From: Dave Airlie DP MST will need connectors that aren't connected to specific encoders, add some checks in advance to avoid oopses. Signed-off-by: Dave Airlie --- driv

Re: [Intel-gfx] [PATCH 06/11] drm: add a path blob property

This one looks fine to me. Reviewed-by: Todd Previte Dave Airlie <mailto:airl...@gmail.com> Tuesday, May 20, 2014 7:54 PM From: Dave Airlie This property will be used by the MST code to provide userspace with a path to parse so it can recognise connectors around hotplugs. Signed-

Re: [Intel-gfx] [PATCH 08/11] i915: split some DP modesetting code into a separate function

Looks good to me. Reviewed-by: Todd Previte Dave Airlie <mailto:airl...@gmail.com> Tuesday, May 20, 2014 7:55 PM From: Dave Airlie this is just prep work for mst support. Signed-off-by: Dave Airlie --- drivers/gpu/drm/i915/intel_ddi.c | 20 +--- drivers/gpu/dr

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Add #defines for short/long pulse on gmch platforms

These look like they're already integrated into -nightly? But for the record... Reviewed-by: Todd Previte -T Dave Airlie <mailto:airl...@gmail.com> Tuesday, June 17, 2014 6:29 PM From: Daniel Vetter For no reason at all the public docs lack them, and Dave needs them for his hp

Re: [Intel-gfx] [PATCH 2/2] drm/i915: rework digital port IRQ handling (v2)

This looks like it's good to go. As an aside, I don't *think* any of the compliance testing stuff I'm working on cares whether it's short of long pulse (1.1a compliance), but it will be interesting to see if/when/where it might have an effect. Reviewed-by: Todd Pr

[Intel-gfx] [PATCH 1/6] drm/i915: Add automated testing support for Displayport compliance testing

Add the skeleton framework for supporting automation for Displayport compliance testing. This patch adds the necessary framework for the source device to appropriately responded to test automation requests from a sink device. Signed-off-by: Todd Previte --- drivers/gpu/drm/i915/intel_dp.c

[Intel-gfx] [PATCH 5/6] drm/i915: Update Displayport compliance testing for link training

Adds basic link training test functionality for Displayport compliance. Signed-off-by: Todd Previte --- drivers/gpu/drm/i915/intel_dp.c | 24 1 file changed, 24 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c index 4c5d229

[Intel-gfx] [PATCH 6/6] drm/i915: Update intel_dp_check_link_status() for Displayport compliance testing

Move the DPCD read to the top and check for an interrupt from the sink to catch Displayport automated testing requests necessary to support Displayport compliance testing. The checks for active connectors and link status are moved below the check for the interrupt. Signed-off-by: Todd Previte

[Intel-gfx] [PATCH 2/6] drm/i915: Add a delay in Displayport AUX transactions for compliance testing

Several compliance tests require that follow-up AUX transactions (after a failure or no response) are not resent sooner than 400us later. Add a 400us delay to the response time of any failed transaction to account for this. Signed-off-by: Todd Previte --- drivers/gpu/drm/i915/intel_dp.c | 6

[Intel-gfx] i915 Displayport Compliance Testing

This patch set adds the foundational support for Displayport compliance testing in the i915 driver. It implements the framework for automated test support that preclude the need (most) for operator input during testing. Tests for AUX transactions, EDID reads and basic link training have also bee

[Intel-gfx] [PATCH 4/6] drm/i915: Update Displayport compliance test for EDID operations

the mode is included as well. Signed-off-by: Todd Previte --- drivers/gpu/drm/i915/intel_dp.c | 100 +--- 1 file changed, 93 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c index d060853..4c5d229

[Intel-gfx] [PATCH 3/6] drm/i915: Implement basic Displayport automated testing function for EDID operations

Implements some of the basic EDID tests for Displayport compliance. These tests include reading the EDID, verifying the checksum and writing the test responses back to the sink device. Signed-off-by: Todd Previte --- drivers/gpu/drm/i915/intel_dp.c | 36 +++- 1

[Intel-gfx] [PATCH v2] Displayport compliance testing

>This patch set adds the foundational support for Displayport compliance >testing in the >i915 driver. It implements the framework for automated test support that >preclude the >need (most) for operator input during testing. Tests for AUX transactions, >EDID reads >and basic link training have a

[Intel-gfx] [PATCH 01/12] drm/i915: Add automated testing support for Displayport compliance testing

Add the skeleton framework for supporting automation for Displayport compliance testing. This patch adds the necessary framework for the source device to appropriately responded to test automation requests from a sink device. Signed-off-by: Todd Previte --- drivers/gpu/drm/i915/intel_dp.c

[Intel-gfx] [PATCH 05/12] drm/i915: Add a function to get the EDID preferred mode for Displayport compliance testing

Add a simple function to pull the preferred mode out of an EDID block. This function is designed for use during Displayport compliance testing. Signed-off-by: Todd Previte --- drivers/gpu/drm/i915/intel_dp.c | 25 + 1 file changed, 25 insertions(+) diff --git a/drivers

[Intel-gfx] [PATCH 06/12] drm/i915: Add a constant and function for getting the Displayport compliance failsafe video mode

Adds the failsafe mode (640x480@60hz) as a constant and a function that retrieves it. These are designed for use in Displayport compliance testing only and should not be used outside that context. Signed-off-by: Todd Previte --- drivers/gpu/drm/i915/intel_dp.c | 12 1 file

[Intel-gfx] [PATCH 02/12] drm/i915: Add a function to compute the EDID checksum for Displayport compliance

This function computes the EDID checksum for a block of EDID data. This function is necessary for Displayport compliance testing as it does not not require the complete EDID checking functionality provided by the DRM layer functions. Signed-off-by: Todd Previte --- drivers/gpu/drm/i915

[Intel-gfx] [PATCH 04/12] drm/i915: Add wrapper function for intel_crtc_set_config()

Add a wrapper around intel_crtc_set_config() to allow it to be called from the DP compliance test functions. This is necessary to perform the internal mode set operations required for compliance testing. Signed-off-by: Todd Previte --- drivers/gpu/drm/i915/intel_display.c | 6 ++ drivers

[Intel-gfx] [PATCH 03/12] drm/i915: Add counters in the drm_dp_aux struct for I2C NACKs and DEFERs

These counters are used for Displayort complinace testing to detect error conditions when executing certain compliance tests. Currently these are used in the EDID tests to determine if the video mode needs to be set to the preferred mode or the failsafe mode. Signed-off-by: Todd Previte

[Intel-gfx] [PATCH 08/12] drm/i915: Improve reliability for Displayport link training

successful link training. This patch updates the link training functions and where/how they're used to be more intelligent about failures and to stop trying to train the link when it's a lost cause. Signed-off-by: Todd Previte --- drivers/gpu/drm/i915/intel_ddi.c | 23 +-- drive

[Intel-gfx] [PATCH 12/12] drm/i915: Add a delay in Displayport AUX transactions for compliance testing

. Signed-off-by: Todd Previte --- drivers/gpu/drm/i915/intel_dp.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c index 0e207aaf..f0664cd 100644 --- a/drivers/gpu/drm/i915/intel_dp.c +++ b/drivers/gpu/drm/i915

[Intel-gfx] [PATCH 07/12] drm/i915: Update EDID automated test function for Displayport compliance

Implements an updated version of the automated testing function that handles Displayport compliance for EDID operations. Signed-off-by: Todd Previte --- drivers/gpu/drm/i915/intel_dp.c | 77 - 1 file changed, 76 insertions(+), 1 deletion(-) diff --git a

[Intel-gfx] [PATCH 11/12] drm/i915: Minor code clean up in intel_dp.c

Cleans up a couple of unused variables and an extraneous debug log message that was unintentionally left behind. Signed-off-by: Todd Previte --- drivers/gpu/drm/i915/intel_dp.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu

[Intel-gfx] [PATCH 09/12] drm/i915: Update intel_dp_check_link_status() for Displayport compliance testing

led, resulting in a faied test. Signed-off-by: Todd Previte --- drivers/gpu/drm/i915/intel_dp.c | 32 ++-- 1 file changed, 18 insertions(+), 14 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c index 1c6ee34..65830e9 100644 --

[Intel-gfx] [PATCH 10/12] drm/i915: Update link training automated test function for Displayport compliance

Implements basic link training functionality for Displayport automated compliance testing. Signed-off-by: Todd Previte --- drivers/gpu/drm/i915/intel_dp.c | 47 + 1 file changed, 47 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers

Re: [Intel-gfx] [PATCH 12/12] drm/i915: Add a delay in Displayport AUX transactions for compliance testing

Daniel Vetter <mailto:dan...@ffwll.ch> Tuesday, July 15, 2014 12:46 AM On Mon, Jul 14, 2014 at 12:10:47PM -0700, Todd Previte wrote: The Displayport Link Layer Compliance Testing Specification 1.2 rev 1.1 specifies that repeated AUX transactions after a failure (NACK, DEFER or no re

Re: [Intel-gfx] [PATCH 11/12] drm/i915: Minor code clean up in intel_dp.c

Daniel Vetter <mailto:dan...@ffwll.ch> Tuesday, July 15, 2014 12:47 AM On Mon, Jul 14, 2014 at 12:10:46PM -0700, Todd Previte wrote: Cleans up a couple of unused variables and an extraneous debug log message that was unintentionally left behind. Signed-off-by: Todd Previte This sho

Re: [Intel-gfx] [PATCH v2] Displayport compliance testing

Paulo Zanoni Tuesday, July 29, 2014 2:53 PM 2014-07-22 18:11 GMT-03:00 Jesse Barnes: On Tue, 22 Jul 2014 22:53:44 +0200 Daniel Vetter wrote: On Tue, Jul 22, 2014 at 10:48 PM, Jesse Barnes wrote: Are you saying you'll reject this approach entirely? I'm saying t

Re: [Intel-gfx] [PATCH 07/12] drm/i915: Update EDID automated test function for Displayport compliance

Paulo Zanoni <mailto:przan...@gmail.com> Tuesday, July 29, 2014 3:37 PM 2014-07-14 16:10 GMT-03:00 Todd Previte: Implements an updated version of the automated testing function that handles Displayport compliance for EDID operations. Both the commit message and the code should menti

[Intel-gfx] [PATCH 1/3] drm/i915: Displayport compliance test 4.2.2.9 support

. The DRM EDID read code already does the 4-block read, so the checksum just needs to be adjusted to the one that we need based on the number of extensions detected in the block. Signed-off-by: Todd Previte --- drivers/gpu/drm/i915/intel_dp.c | 10 +- 1 file changed, 9 insertions(+), 1

[Intel-gfx] [PATCH 3/3] drm/i915: Displayport compliance test 4.2.2.8 support

: Todd Previte --- drivers/gpu/drm/i915/intel_dp.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c index 697857a..99d2e81 100644 --- a/drivers/gpu/drm/i915/intel_dp.c +++ b/drivers/gpu/drm/i915/intel_dp.c @@ -4220,6

[Intel-gfx] [PATCH 2/3] drm/i915: Displayport compliance test 4.2.2.7 support

here for compatibility for pre-HDCP 1.3 devices. V1: - Fixed formatting errors V2: - Updated for versioning Signed-off-by: Todd Previte --- drivers/gpu/drm/i915/intel_dp.c | 12 +++- drivers/gpu/drm/i915/intel_drv.h | 4 2 files changed, 15 insertions(+), 1 deletion(-) diff --git a

[Intel-gfx] Add support for Displayport CTS 4.2.2.7, 4.2.2.8 and 4.2.2.9

Three patches to add support for the above-mentioned compliance tests. The first two are branch device tests and the third is a 4-block E-DDC read. Todd Previte (3) drm/i915: Displayport compliance test 4.2.2.8 support drm/i915: Displayport compliance test 4.2.2.7 support drm/i915

Re: [Intel-gfx] [PATCH 07/11] drm/i915: Update intel_dp_hpd_pulse() for non-MST operation

On 4/14/15 4:29 AM, Paulo Zanoni wrote: 2015-04-10 13:12 GMT-03:00 Todd Previte : Update the hot plug function to handle the SST case. Instead of placing the SST case within the long/short pulse block, it is now handled after determining that MST mode is not in use. This way, the topology

Re: [Intel-gfx] [PATCH 08/13] drm/i915: Support EDID compliance tests with the intel_dp_autotest_edid() function

On 4/14/15 6:35 AM, Paulo Zanoni wrote: 2015-04-10 14:42 GMT-03:00 Todd Previte : Updates the EDID compliance test function to perform the EDID read as required by the tests. This read needs to take place in the kernel for reasons of speed and efficiency. The results of the EDID read

Re: [Intel-gfx] [PATCH 03/11] drm/i915: Move the DPCD read further up in intel_dp_check_link_status()

x27;s back where it belongs in the updated patch. -T On 4/10/15 9:12 AM, Todd Previte wrote: Move the DPCD read to the top and check for an interrupt from the sink to catch Displayport automated testing requests necessary to support Displayport compliance testing. The checks for active connector

Re: [Intel-gfx] [PATCH 07/11] drm/i915: Update intel_dp_hpd_pulse() for non-MST operation

On 4/14/15 12:00 PM, Paulo Zanoni wrote: 2015-04-14 14:36 GMT-03:00 Todd Previte : On 4/14/15 4:29 AM, Paulo Zanoni wrote: 2015-04-10 13:12 GMT-03:00 Todd Previte : Update the hot plug function to handle the SST case. Instead of placing the SST case within the long/short pulse block, it is

Re: [Intel-gfx] [PATCH 06/13] drm: Add supporting structure for Displayport Link CTS test 4.2.2.6

On 4/13/15 3:18 PM, Paulo Zanoni wrote: 2015-04-13 11:53 GMT-03:00 Todd Previte : Displayport compliance test 4.2.2.6 requires that a source device be capable of detecting a corrupt EDID. The test specification states that the sink device sets up the EDID with an invalid checksum. To do this

Re: [Intel-gfx] [PATCH 04/13] drm/i915: Add EDID read in intel_dp_check_link_status() for Link CTS 4.2.2.1

On 4/14/2015 9:53 AM, Paulo Zanoni wrote: 2015-04-13 11:53 GMT-03:00 Todd Previte : Adds in an EDID read after the DPCD read to accommodate test 4.2.2.1 in the Displayport Link CTS Core 1.2 rev1.1. This test requires an EDID read for all HPD plug events. To reduce the amount of code, this

[Intel-gfx] [PATCH 05/10] drm: Add supporting structure for Displayport Link CTS test 4.2.2.6

flag to the end of the test handler in intel_dp.c - Changed the usage of the new function prototype in several places to use NULL where it is not needed by compliance testing Signed-off-by: Todd Previte Cc: dri-de...@lists.freedesktop.org --- drivers/gpu/drm/drm_edid.c | 30

[Intel-gfx] [PATCH 03/10] drm/i915: Add EDID read in intel_dp_check_link_status() for Link CTS 4.2.2.1

ff-by: Todd Previte --- drivers/gpu/drm/i915/intel_dp.c | 13 + 1 file changed, 13 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c index 1352c00..c112359 100644 --- a/drivers/gpu/drm/i915/intel_dp.c +++ b/drivers/gpu/drm/i915/intel_dp.c @@ -41

[Intel-gfx] [PATCH V6] Displayport compliance testing V6

This is the 6th iteration of the Displayport compliance testing patch set for performing compliance testing operations of the i915 driver. High level changes are listed below, with the specifics for each patch listed in the commit messages. Kernel: Changes for V4: - Removed the code for link c

[Intel-gfx] [PATCH 06/10] drm/i915: Update intel_dp_hpd_pulse() for non-MST operation

tection of the HPD pin status in in order to determine connected status - Reformatted the if-statements in the function so the braces are consistent for those with single statements after the if-statement Signed-off-by: Todd Previte --- drivers/gpu/drm/i915/intel_

[Intel-gfx] [PATCH 07/10] drm/i915: Support EDID compliance tests with the intel_dp_autotest_edid() function

ded previously Signed-off-by: Todd Previte --- drivers/gpu/drm/i915/intel_dp.c | 47 +++- drivers/gpu/drm/i915/intel_drv.h | 4 2 files changed, 50 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c in

[Intel-gfx] [PATCH 08/10] drm: Fix for DP CTS test 4.2.2.5 - I2C DEFER handling

count. - Combined the increment of the defer count into the if-statement V4: - Removed i915 tag from subject as the patch is not i915-specific V5: - Updated the for-loop to add the number of i2c defers to the retry counter such that the correct number of retry attempts will be made Signed-off-by:

[Intel-gfx] [PATCH 01/10] drm/i915: Add automated testing support for Displayport compliance testing

t_active variable declaration and initialization out of this patch and into the patch where it's used - Changed variable name compliance_testing_active to compliance_test_active to unify the naming convention - Added initialization for compliance_test_type variable Signed-off-by: Todd Previte

[Intel-gfx] [PATCH 04/10] drm/i915: Add a delay in Displayport AUX transactions for compliance testing

(review feedback) V7: - Updated the commit message to remove verbage about the HW timeout case that is no longer valid. Signed-off-by: Todd Previte Reviewed-by: Paulo Zanoni --- drivers/gpu/drm/i915/intel_dp.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a

[Intel-gfx] [PATCH 10/10] drm: Fix the 'native defer' message in drm_dp_i2c_do_msg()

The debug message is missing a newline at the end and it makes the logs hard to read when a device defers a lot. Simple 2-character fix adds the newline at the end. Signed-off-by: Todd Previte Cc: dri-de...@lists.freedesktop.org Reviewed-by: Paulo Zanoni Reviewed-by: Alex Deucher --- drivers

[Intel-gfx] [PATCH 09/10] drm/i915: Add debugfs test control files for Displayport compliance testing

a NULL pointer dereference if the encoder on the connector is invalid Signed-off-by: Todd Previte --- drivers/gpu/drm/i915/i915_debugfs.c | 209 1 file changed, 209 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915

[Intel-gfx] [PATCH 02/10] drm/i915: Update intel_dp_check_link_status() for Displayport compliance testing

status of the HPD pin to determine if a sink device is connected V3: - Removed duplicate code from the hpd_pulse -> check_link_status path Signed-off-by: Todd Previte --- drivers/gpu/drm/i915/intel_dp.c | 32 +--- 1 file changed, 13 insertions(+), 19 deletions(-) di

[Intel-gfx] [PATCH 03/12] drm/i915: Add EDID read in intel_dp_check_link_status() for Link CTS 4.2.2.1

Added propagation of the long_hpd flag from the hot_pulse function Signed-off-by: Todd Previte --- drivers/gpu/drm/i915/intel_dp.c | 19 +-- 1 file changed, 17 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c index 1352c00..23

[Intel-gfx] [PATCH 05/12] drm: Add supporting structure for Displayport Link CTS test 4.2.2.6

flag to the end of the test handler in intel_dp.c - Changed the usage of the new function prototype in several places to use NULL where it is not needed by compliance testing V7: - Updated to account for long_pulse flag propagation Signed-off-by: Todd Previte Cc: dri-de

[Intel-gfx] [PATCH 06/12] drm/i915: Update intel_dp_hpd_pulse() for non-MST operation

tection of the HPD pin status in in order to determine connected status - Reformatted the if-statements in the function so the braces are consistent for those with single statements after the if-statement V8: - Updated to account for long_hpd flag propagation Signed-off-by: Todd Previte --- d

[Intel-gfx] [PATCH 07/12] drm/i915: Support EDID compliance tests with the intel_dp_autotest_edid() function

ded previously V9: - Updated for the long_hpd flag propagation Signed-off-by: Todd Previte --- drivers/gpu/drm/i915/intel_dp.c | 47 +++- drivers/gpu/drm/i915/intel_drv.h | 4 2 files changed, 50 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i

[Intel-gfx] [PATCH 02/12] drm/i915: Update intel_dp_check_link_status() for Displayport compliance testing

from previous split - Updated the commit message Signed-off-by: Todd Previte --- drivers/gpu/drm/i915/intel_dp.c | 33 +++-- 1 file changed, 15 insertions(+), 18 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c index 263eff3..

[Intel-gfx] [PATCH 03/12] drm/i915: Add EDID read in intel_dp_check_link_status() for Link CTS 4.2.2.1

Added propagation of the long_hpd flag from the hot_pulse function V6: - Versioning, accommodating changes from previous patch Signed-off-by: Todd Previte --- drivers/gpu/drm/i915/intel_dp.c | 19 +-- 1 file changed, 17 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm

Re: [Intel-gfx] [PATCH 05/12] drm: Add supporting structure for Displayport Link CTS test 4.2.2.6

On 4/15/2015 1:25 PM, Paulo Zanoni wrote: 2015-04-15 14:15 GMT-03:00 Todd Previte : Displayport compliance test 4.2.2.6 requires that a source device be capable of detecting a corrupt EDID. The test specification states that the sink device sets up the EDID with an invalid checksum. To do

[Intel-gfx] [PATCH 05/12] drm: Add supporting structure for Displayport Link CTS test 4.2.2.6

handler in intel_dp.c - Added clearing of header_corrupt flag in the drm_edid_block_valid function Signed-off-by: Todd Previte Cc: dri-de...@lists.freedesktop.org --- drivers/gpu/drm/drm_edid.c | 35 +-- drivers/gpu/drm/drm_edid_load.c | 7 +-- drivers/gpu

[Intel-gfx] [PATCH 06/12] drm/i915: Update intel_dp_hpd_pulse() for non-MST operation

Change the return type for the SST case to IRQ_NONE to allow for proper invocation of other hot plug functions Signed-off-by: Todd Previte --- drivers/gpu/drm/i915/intel_dp.c | 54 drivers/gpu/drm/i915/intel_drv.h | 1 + 2 files changed, 34 insertions(+), 21

Re: [Intel-gfx] [PATCH 05/12] drm: Add supporting structure for Displayport Link CTS test 4.2.2.6

On 4/16/2015 6:34 AM, Paulo Zanoni wrote: 2015-04-15 19:03 GMT-03:00 Todd Previte : Displayport compliance test 4.2.2.6 requires that a source device be capable of detecting a corrupt EDID. The test specification states that the sink device sets up the EDID with an invalid checksum. To do

Re: [Intel-gfx] [PATCH 04/13] drm/i915: Add EDID read in intel_dp_check_link_status() for Link CTS 4.2.2.1

On 4/15/2015 10:42 AM, Paulo Zanoni wrote: 2015-04-15 12:37 GMT-03:00 Todd Previte : On 4/14/2015 9:53 AM, Paulo Zanoni wrote: 2015-04-13 11:53 GMT-03:00 Todd Previte : Adds in an EDID read after the DPCD read to accommodate test 4.2.2.1 in the Displayport Link CTS Core 1.2 rev1.1. This

[Intel-gfx] [PATCH 05/12] drm: Add supporting structure for Displayport Link CTS test 4.2.2.6

header_corrupt flag from the test handler in intel_dp.c - Added clearing of header_corrupt flag in the drm_edid_block_valid function V9: - Renamed header_corrupt flag to edid_corrupt to more accurately reflect its value and purpose - Updated commit message Signed-off-by: Todd Previte Cc: dri-de

Re: [Intel-gfx] [PATCH 04/13] drm/i915: Add EDID read in intel_dp_check_link_status() for Link CTS 4.2.2.1

On 4/16/2015 9:31 AM, Daniel Vetter wrote: On Thu, Apr 16, 2015 at 08:41:33AM -0700, Todd Previte wrote: On 4/15/2015 10:42 AM, Paulo Zanoni wrote: 2015-04-15 12:37 GMT-03:00 Todd Previte : On 4/14/2015 9:53 AM, Paulo Zanoni wrote: 2015-04-13 11:53 GMT-03:00 Todd Previte : Adds in an EDID

Re: [Intel-gfx] [PATCH] igt/dp: Displayport Compliance Testing - Userspace Component

On 4/17/2015 6:44 AM, Thomas Wood wrote: On 10 April 2015 at 16:54, Todd Previte wrote: This is the userspace component of the Displayport compliance testing software requried for compliance testing of the i915 driver. The README included in the dp_compliance/ directory contains the most up

Re: [Intel-gfx] [PATCH] igt/dp: Displayport Compliance Testing - Userspace Component

On 4/17/2015 11:42 AM, Dave Gordon wrote: On 10/04/15 16:54, Todd Previte wrote: This is the userspace component of the Displayport compliance testing software requried for compliance testing of the i915 driver. The README included in the dp_compliance/ directory contains the most up to date

[Intel-gfx] [PATCH V7] Displayport compliance testing V7

This is the 6th iteration of the Displayport compliance testing patch set for performing compliance testing operations of the i915 driver. High level changes are listed below, with the specifics for each patch listed in the commit messages. Kernel: Changes for V4: - Removed the code for link c

[Intel-gfx] [PATCH 5/5] drm/i915: Add debugfs test control files for Displayport compliance testing

a NULL pointer dereference if the encoder on the connector is invalid Signed-off-by: Todd Previte Reviewed-by: Paulo Zanoni --- drivers/gpu/drm/i915/i915_debugfs.c | 209 1 file changed, 209 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_debugfs.c

[Intel-gfx] [PATCH 1/5] drm/i915: Move Displayport test request and sink IRQ logic to intel_dp_detect()

normal operational paths, eliminating as much special case code as possible. Signed-off-by: Todd Previte --- drivers/gpu/drm/i915/intel_dp.c | 29 ++--- 1 file changed, 14 insertions(+), 15 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915

[Intel-gfx] [PATCH 3/5] drm/i915: Implement the intel_dp_autotest_edid function for DP EDID complaince tests

lag propagation V10: - Updated to use actual checksum from the EDID read that occurs during normal hot plug path execution - Removed variables from intel_dp struct that are no longer needed - Updated the patch subject to more closely match the nature and contents of the patch Signed-off-by: Todd Prev

[Intel-gfx] [PATCH 4/5] drm: Fix for DP CTS test 4.2.2.5 - I2C DEFER handling

count. - Combined the increment of the defer count into the if-statement V4: - Removed i915 tag from subject as the patch is not i915-specific V5: - Updated the for-loop to add the number of i2c defers to the retry counter such that the correct number of retry attempts will be made Signed-off-by:

[Intel-gfx] [PATCH 2/5] drm: Add edid_corrupt flag for Displayport Link CTS 4.2.2.6

- Revised the title to more accurately reflect the nature and contents of the patch Signed-off-by: Todd Previte Cc: dri-de...@lists.freedesktop.org --- drivers/gpu/drm/drm_edid.c | 30 -- drivers/gpu/drm/drm_edid_load.c | 7 +-- include/drm/drm_crtc.h

[Intel-gfx] [PATCH] drm/i915: Move Displayport test request and sink IRQ logic to intel_dp_detect()

normal operational paths, eliminating as much special case code as possible. Signed-off-by: Todd Previte --- drivers/gpu/drm/i915/intel_dp.c | 29 ++--- 1 file changed, 14 insertions(+), 15 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915

Re: [Intel-gfx] [PATCH 04/13] drm/i915: Add EDID read in intel_dp_check_link_status() for Link CTS 4.2.2.1

On 4/16/15 9:31 AM, Daniel Vetter wrote: On Thu, Apr 16, 2015 at 08:41:33AM -0700, Todd Previte wrote: On 4/15/2015 10:42 AM, Paulo Zanoni wrote: 2015-04-15 12:37 GMT-03:00 Todd Previte : On 4/14/2015 9:53 AM, Paulo Zanoni wrote: 2015-04-13 11:53 GMT-03:00 Todd Previte : Adds in an EDID

[Intel-gfx] [PATCH 4/8] drm/i915: Move Displayport test request and sink IRQ logic to intel_dp_detect()

requests in the short pulses for now since they are for future test implementations. Signed-off-by: Todd Previte --- drivers/gpu/drm/i915/intel_dp.c | 17 - 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915

[Intel-gfx] [PATCH 2/5] drm: Add edid_corrupt flag for Displayport Link CTS 4.2.2.6

: - Updated for versioning and patch swizzle - Revised the title to more accurately reflect the nature and contents of the patch - Fixed formatting/whitespace problems - Added set flag when computed checksum is invalid Signed-off-by: Todd Previte Cc: dri-de...@lists.freedesktop.org --- drivers/gpu/drm

[Intel-gfx] [PATCH 06/10] drm/i915: Implement the intel_dp_autotest_edid function for DP EDID complaince tests

lem (long line) V11: - Removed extra debug messages - Updated comments to be more informative - Removed extra variable V12: - Removed the 4 bit offset of the resolution setting in compliance data - Changed to DRM_DEBUG_KMS instead of DRM_DEBUG_DRIVER Signed-off-by: Todd Previte Reviewed-by: Paulo Zan

[Intel-gfx] [PATCH] drm: Fix missing kerneldoc for the edid_corrupt field in struct drm_connector

The kerneldoc for this newly added parameter was missing from the original patch. This patch adds the appropriate kerneldoc entry. Signed-off-by: Todd Previte --- include/drm/drm_crtc.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/drm/drm_crtc.h b/include/drm/drm_crtc.h index

Re: [Intel-gfx] [PATCH] drm/i915/hsw: Fix workaround for server AUX channel clock divisor

loop again after changing AUX channel clock dividers would be good information to put in there. That's probably more of a bikeshed though. Reviewed-by: Todd Previte -T On 5/19/2015 9:13 AM, jim.br...@linux.intel.com wrote: From: Jim Bride According to the HSW b-spec we need to try cloc

[Intel-gfx] [PATCH] drm/edid: Fix DDC probe for passive DP dongles

nce and still continue operations. A second NAK will result in breaking the loop as it would have before and stopping the DDC probe. Signed-off-by: Todd Previte Cc: intel-gfx@lists.freedesktop.org --- drivers/gpu/drm/drm_edid.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --gi

Re: [Intel-gfx] [PATCH] drm/edid: Fix DDC probe for passive DP dongles

On 5/21/2015 1:28 AM, Jani Nikula wrote: On Thu, 21 May 2015, Todd Previte wrote: Passive DP->DVI/HDMI dongles show up to the system as HDMI devices, as they do not have a sink device in them to respond to any AUX traffic. When probing these dongles over the DDC, sometimes they will NAK

Re: [Intel-gfx] [PATCH 03/17] drm/i915: Add a delay in Displayport AUX transactions for compliance testing

On 12/15/2014 10:35 AM, Paulo Zanoni wrote: 2014-12-10 21:53 GMT-02:00 Todd Previte: The Displayport Link Layer Compliance Testing Specification 1.2 rev 1.1 specifies that repeated AUX transactions after a failure (no response / invalid response) must have a minimum delay of 400us before the

Re: [Intel-gfx] [PATCH 02/17] drm/i915: Update intel_dp_check_link_status() for Displayport compliance testing

On 12/15/2014 9:36 AM, Paulo Zanoni wrote: 2014-12-10 21:53 GMT-02:00 Todd Previte: Move the DPCD read to the top and check for an interrupt from the sink to catch Displayport automated testing requests necessary to support Displayport compliance testing. The checks for active connectors and

Re: [Intel-gfx] [PATCH 04/17] drm/i915: Add debugfs information for Displayport compliance testing

On 12/15/14 6:11 AM, Jani Nikula wrote: On Thu, 11 Dec 2014, Todd Previte wrote: This patch was part of "[PATCH 05/10] drm/i915: Add debugfs interface for Displayport debug and compliance testing". That patch has been split into smaller patches for ease of review and integration.

Re: [Intel-gfx] [PATCH 07/17] drm/i915: Add and implement the debugfs 'show' functions for Displayport compliance

Responses inline below. Any changes have been rolled into the monster patch. -T On 12/16/14 12:00 PM, Paulo Zanoni wrote: 2014-12-10 21:53 GMT-02:00 Todd Previte: This patch was previously part of "[PATCH 05/10] drm/i915: Add debugfs interface for Displayport debug and compliance te

Re: [Intel-gfx] [PATCH 01/17] drm/i915: Add automated testing support for Displayport compliance testing

On 12/12/14 1:25 PM, Paulo Zanoni wrote: 2014-12-10 21:53 GMT-02:00 Todd Previte: Add the skeleton framework for supporting automation for Displayport compliance testing. This patch adds the necessary framework for the source device to appropriately respond to test automation requests from a

Re: [Intel-gfx] [PATCH 07/17] drm/i915: Add and implement the debugfs 'show' functions for Displayport compliance

On 12/17/14 1:12 PM, Daniel Vetter wrote: On Tue, Dec 16, 2014 at 05:00:38PM -0200, Paulo Zanoni wrote: 2014-12-10 21:53 GMT-02:00 Todd Previte: + if (intel_encoder->type == INTEL_OUTPUT_DISPLAYPORT) { + if (intel_encoder->ne

Re: [Intel-gfx] [PATCH 11/17] drm/i915: Update the EDID automated compliance test function

On 12/17/14 9:25 AM, Paulo Zanoni wrote: 2014-12-10 21:53 GMT-02:00 Todd Previte: Updates the EDID compliance test function to perform the EDID read as required by the tests. This read needs to take place in the kernel for reasons of speed and efficiency. The results of the EDID read are handed

Re: [Intel-gfx] [PATCH 12/17] drm/i915: Update intel_dp_compute_config() to handle compliance test requests

On 1/7/15 12:28 PM, Clint Taylor wrote: On 12/17/2014 09:04 AM, Paulo Zanoni wrote: 2014-12-10 21:53 GMT-02:00 Todd Previte : Adds provisions in intel_dp_compute_config() to accommodate compliance testing. Mostly this invovles circumventing the automatic link configuration parameters and

Re: [Intel-gfx] [PATCH 13/17] drm/i915: Update intel_dp_hpd_pulse() to check link status for non-MST operation

On 12/17/14 10:57 AM, Paulo Zanoni wrote: 2014-12-10 21:53 GMT-02:00 Todd Previte: Moves the non-MST case out of the if-statement and places it at the beginning of the function to handle HPD events for SST mode. The reasoning behind this is to accommodate link status checks for compliance

Re: [Intel-gfx] [PATCH 13/17] drm/i915: Update intel_dp_hpd_pulse() to check link status for non-MST operation

On 12/17/14 1:30 PM, Daniel Vetter wrote: On Wed, Dec 17, 2014 at 03:57:21PM -0200, Paulo Zanoni wrote: 2014-12-10 21:53 GMT-02:00 Todd Previte: Moves the non-MST case out of the if-statement and places it at the beginning of the function to handle HPD events for SST mode. The reasoning behind

<    1   2   3   >