Re: [Intel-gfx] [PATCH 2/2] igt/gem_workarounds: igt to test workaround registers

2014-08-20 Thread Thomas Wood
On 20 August 2014 15:52, Arun Siluvery wrote: > Some of the workarounds are lost followed by a gpu reset, suspend/resume; > this patch adds a test which compares register state before and after > the test scenario. > > This test currently verifies only bdw workarounds. Just a few points from an i

Re: [Intel-gfx] [PATCH i-g-t 1/1] scripts: Add capability to resume interrupted run-tests.sh session

2014-08-29 Thread Thomas Wood
On 26 August 2014 21:31, Mike Mason wrote: > Piglit provides a 'resume' feature that can restart an interrupted > test run at the point where it stopped. This patch adds that > feature to run_tests.sh. > > Signed-off-by: Mike Mason > --- > scripts/run-tests.sh | 15 +++ > 1 file cha

[Intel-gfx] [PATCH i-g-t v2 6/6] tests/kms_3d: skip if connectors cannot be forced

2014-09-05 Thread Thomas Wood
Signed-off-by: Thomas Wood --- tests/kms_3d.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/kms_3d.c b/tests/kms_3d.c index ddf4dc6..c11873b 100644 --- a/tests/kms_3d.c +++ b/tests/kms_3d.c @@ -60,7 +60,8 @@ igt_simple_main &le

[Intel-gfx] [PATCH i-g-t v2 0/6] 3D stereo mode testing

2014-09-05 Thread Thomas Wood
This updated and rebased series fixes various issues with the previous one and also skips testing on gen 7 and 8 where it is not currently possible to force the HDMI and DP connector states. There is also a small documentation fix for igt_create_fb. Thomas Wood (6): lib: add kmstest_edid_add_3d

[Intel-gfx] [PATCH i-g-t v2 5/6] lib: don't force HDMI or DP connectors on gen 7 and 8

2014-09-05 Thread Thomas Wood
Forcing HDMI or DP connectors on gen 7 and 8 doesn't currently work, so fail early to allow the test to skip if required. Signed-off-by: Thomas Wood --- lib/igt_kms.c | 12 1 file changed, 12 insertions(+) diff --git a/lib/igt_kms.c b/lib/igt_kms.c index 0dc46f9..e9455aa 1

[Intel-gfx] [PATCH i-g-t v2 1/6] lib: add kmstest_edid_add_3d

2014-09-05 Thread Thomas Wood
kmstest_edid_add_3d adds an EDID extension block with 3D support to a copy of the specified EDID. v2: Avoid using an invalid CEC SPA (Clint Taylor) Signed-off-by: Thomas Wood --- lib/igt_kms.c | 80 +++ lib/igt_kms.h | 1 + 2 files

[Intel-gfx] [PATCH i-g-t v2 4/6] lib/igt_fb: ensure igt_create_fb parameters are consistent

2014-09-05 Thread Thomas Wood
Make sure the parameters in the prototype and implementation of igt_create_fb match and are complete so that the documentation is correct. Signed-off-by: Thomas Wood --- lib/igt_fb.c | 2 +- lib/igt_fb.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/igt_fb.c b/lib

[Intel-gfx] [PATCH i-g-t v2 3/6] tests: add kms_3d test

2014-09-05 Thread Thomas Wood
Add a test to verify creation and use of 3D stereo modes. v2: update for API changes Signed-off-by: Thomas Wood --- tests/.gitignore | 1 + tests/Android.mk | 1 + tests/Makefile.sources | 1 + tests/kms_3d.c | 120 + 4

[Intel-gfx] [PATCH i-g-t v2 2/6] lib: move create_stereo_fb from testdisplay to igt_fb

2014-09-05 Thread Thomas Wood
Move create_stereo_fb from testdisplay to igt_create_stereo_fb in igt_fb so that it can be used in other tests. v2: update for new igt_create_fb API add parameters for format and tiling remove some old debug code Signed-off-by: Thomas Wood --- lib/Makefile.am | 4 +- lib/igt_fb.c

[Intel-gfx] [PATCH i-g-t] lib: keep a list of modified connectors to reset

2014-09-05 Thread Thomas Wood
Avoid calling functions in igt_reset_connectors that are not safe to use in signal handlers by keeping a list of connectors that have been modified, instead of enumerating all connectors. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=83498 Cc: Paulo Zanoni Signed-off-by: Thomas Wood

[Intel-gfx] [PATCH i-g-t] lib: included igt_edid.h in igt_kms.c

2014-09-08 Thread Thomas Wood
Include the generic_edid array inside igt_kms.c to avoid having to include it separately in tests. This also means it can be included in the i-g-t kms section of the documentation. Signed-off-by: Thomas Wood --- docs/reference/intel-gpu-tools/Makefile.am | 3 ++- docs/reference

Re: [Intel-gfx] [PATCH i-g-t] lib: included igt_edid.h in igt_kms.c

2014-09-08 Thread Thomas Wood
On 8 September 2014 13:07, Daniel Vetter wrote: > On Mon, Sep 08, 2014 at 12:12:21PM +0100, Thomas Wood wrote: > > Include the generic_edid array inside igt_kms.c to avoid having to > include > > it separately in tests. This also means it can be included in the i-g-t > k

Re: [Intel-gfx] [PATCH 00/89] Basic Skylake enabling (reviewers)

2014-09-16 Thread Thomas Wood
r-b tag, having another look has some > value as patches get rebased and churned a bit. Some people have 2 lines > below. > > I've left some people out of the list as they're just jumping on the > list and give feedback already. If you expect some big delays in the > rev

Re: [Intel-gfx] [PATCH 08/89] drm/i915/skl: Use gen8_ring_dispatch_execbuffer() on GEN9

2014-09-16 Thread Thomas Wood
On 4 September 2014 12:26, Damien Lespiau wrote: > Signed-off-by: Damien Lespiau While discussing this with Damien, he mentioned that legacy ring buffer submission is not supported on gen 9 and perhaps dispatch_execbuffer should be set to null instead. > --- > drivers/gpu/drm/i915/intel_ringb

Re: [Intel-gfx] [PATCH 11/89] drm/i915/skl: Framebuffers need to be aligned to 256Kb on Skylake

2014-09-16 Thread Thomas Wood
On 4 September 2014 12:26, Damien Lespiau wrote: > Signed-off-by: Damien Lespiau Does the X tiling alignment value need to be set too? A minor point, but perhaps use KB in the subject rather than Kb? > --- > drivers/gpu/drm/i915/intel_display.c | 4 +++- > 1 file changed, 3 insertions(+), 1

Re: [Intel-gfx] [PATCH 11/89 v2] drm/i915/skl: Framebuffers need to be aligned to 256KB on Skylake

2014-09-19 Thread Thomas Wood
On 19 September 2014 12:26, Damien Lespiau wrote: > v2: Also align X tiled fbs to 256KB (Thomas) > > Signed-off-by: Damien Lespiau Reviewed-by: Thomas Wood > --- > drivers/gpu/drm/i915/intel_display.c | 12 +--- > 1 file changed, 9 insertions(+), 3 deletions(-

[Intel-gfx] [PATCH i-g-t 2/4] doc: various spelling and typo fixes

2014-09-29 Thread Thomas Wood
Signed-off-by: Thomas Wood --- lib/igt_aux.c| 12 ++-- lib/igt_core.c | 22 +++--- lib/igt_core.h | 4 ++-- lib/igt_debugfs.c| 6 +++--- lib/igt_debugfs.h| 2 +- lib/igt_kms.h| 2 +- lib/intel_mmio.c | 8 lib

[Intel-gfx] [PATCH i-g-t 4/4] tests/sysfs_l3_parity: fix warnings in test enumeration

2014-09-29 Thread Thomas Wood
Source drm_lib.sh before skipping the test to ensure that subtest enumeration is always handled correctly. Signed-off-by: Thomas Wood --- tests/sysfs_l3_parity | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/sysfs_l3_parity b/tests/sysfs_l3_parity index e9d4411

[Intel-gfx] [PATCH i-g-t 3/4] lib: ensure any buffers are flushed before fork

2014-09-29 Thread Thomas Wood
Flush any buffers before forking to prevent duplicated output. Signed-off-by: Thomas Wood --- lib/igt_core.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/lib/igt_core.c b/lib/igt_core.c index f2b4560..6e1c51a 100644 --- a/lib/igt_core.c +++ b/lib/igt_core.c @@ -928,6 +928,10

[Intel-gfx] [PATCH i-g-t 1/4] tests/kms_flip: only print the activity indicator if output is a terminal

2014-09-29 Thread Thomas Wood
Signed-off-by: Thomas Wood --- tests/kms_flip.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/tests/kms_flip.c b/tests/kms_flip.c index 3d3aa9b..8551f64 100644 --- a/tests/kms_flip.c +++ b/tests/kms_flip.c @@ -885,7 +885,10 @@ static unsigned int run_test_step(struct

Re: [Intel-gfx] [PATCH libdrm 1/3] intel/skl: Add SKL PCI ids

2014-09-30 Thread Thomas Wood
On 26 September 2014 14:19, Damien Lespiau wrote: > v2: Add more PCI IDs (Michael H. Nguyen) > v3: Synchronize one more with the kernel PCI IDs (Damien) > > Signed-off-by: Damien Lespiau > Signed-off-by: Ben Widawsky > Signed-off-by: Michael H. Nguyen Reviewed-by: Thomas Woo

[Intel-gfx] [PATCH i-g-t] lib: add a function to indicate activity

2014-09-30 Thread Thomas Wood
Signed-off-by: Thomas Wood --- lib/igt_aux.c | 15 +++ lib/igt_aux.h | 1 + tests/kms_cursor_crc.c | 3 ++- tests/kms_fence_pin_leak.c | 4 ++-- tests/kms_flip.c | 2 +- 5 files changed, 21 insertions(+), 4 deletions(-) diff --git a/lib

Re: [Intel-gfx] [PATCH] lib/Android.mk: add define of IGT_DATADIR for igt_fb.c

2014-10-02 Thread Thomas Wood
On 2 October 2014 16:26, wrote: > From: Tim Gore > > Since the igt_create_stereo_fb function moved into igt_fb.c > we need to add the definition of IGT_DATADIR in the Android > makefile in order to build the cairo dependent tests. > > Signed-off-by: Tim Gore Patch merged, thanks. > --- > li

Re: [Intel-gfx] [PATCH 2/2] Don't use += to append to a shell variable.

2014-10-09 Thread Thomas Wood
On 7 October 2014 17:41, Adam Sampson wrote: > POSIX only requires "=" to be supported; "+=" works in bash but not in > dash. > > Signed-off-by: Adam Sampson Both patches merged, thanks. > --- > configure.ac | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/configure.ac

[Intel-gfx] [PATCH i-g-t 1/2] tests/kms_force_connector: ensure igt_exit is called at exit

2014-10-09 Thread Thomas Wood
Since commit 5782eca (lib/igt_core.c: disable lowmemorykiller during tests), igt_exit needs to be called before the test exits. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=84771 Cc: Tim Gore Signed-off-by: Thomas Wood --- tests/kms_force_connector.c | 2 +- 1 file changed, 1

[Intel-gfx] [PATCH i-g-t 2/2] tests/kms_force_connect: skip if a VGA connector is not available

2014-10-09 Thread Thomas Wood
Signed-off-by: Thomas Wood --- tests/kms_force_connector.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/kms_force_connector.c b/tests/kms_force_connector.c index 96881c7..361bf84 100644 --- a/tests/kms_force_connector.c +++ b/tests/kms_force_connector.c @@ -54,7

Re: [Intel-gfx] [PATCH i-g-t 1/2] tests/kms_force_connector: ensure igt_exit is called at exit

2014-10-09 Thread Thomas Wood
On 9 October 2014 17:00, Gore, Tim wrote: >> -Original Message- >> From: Thomas Wood [mailto:thomas.w...@intel.com] >> Sent: Thursday, October 09, 2014 4:51 PM >> To: intel-gfx@lists.freedesktop.org >> Cc: Gore, Tim >> Subject: [PATCH i-g-t 1/2] tests/

Re: [Intel-gfx] [PATCH] lib: fix warnings on ignoring return values

2014-10-15 Thread Thomas Wood
On 15 October 2014 12:43, Mika Kuoppala wrote: > Signed-off-by: Mika Kuoppala > --- > lib/igt_core.c| 21 - > lib/igt_debugfs.c | 6 +++--- > lib/igt_kms.c | 22 +- > lib/intel_os.c| 2 +- > 4 files changed, 33 insertions(+), 18 deletions(-)

[Intel-gfx] [PATCH i-g-t] tests/kms_force_connector: fix assertion when VGA is already connected

2014-10-16 Thread Thomas Wood
Compare the number of modes available when the edid is reset with the number before the edid was overridden. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=82230 Signed-off-by: Thomas Wood --- tests/kms_force_connector.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff

[Intel-gfx] [PATCH i-g-t 0/7] Miscellaneous fixes and improvements

2014-10-16 Thread Thomas Wood
The following series includes various fixes and improvements to intel-gpu-tools, including a new check for command line handling. Thomas Wood (7): Fix uninitialised variable warnings lib: various documentation fixes lib: add common min and max macros quick_dump: fix distcheck configure

[Intel-gfx] [PATCH i-g-t 7/7] tests: add a check for command line handling

2014-10-16 Thread Thomas Wood
Check that command line handling works consistently across all tests. Signed-off-by: Thomas Wood --- tests/Makefile.sources| 6 + tests/igt_command_line.sh | 61 +++ 2 files changed, 67 insertions(+) create mode 100755 tests

[Intel-gfx] [PATCH i-g-t 6/7] drm_lib.sh: add standard command line options

2014-10-16 Thread Thomas Wood
Signed-off-by: Thomas Wood --- tests/drm_lib.sh | 11 +++ 1 file changed, 11 insertions(+) diff --git a/tests/drm_lib.sh b/tests/drm_lib.sh index d71e6ae..6a8a310 100755 --- a/tests/drm_lib.sh +++ b/tests/drm_lib.sh @@ -9,6 +9,17 @@ for arg in $@ ; do --run-subtest

[Intel-gfx] [PATCH i-g-t 2/7] lib: various documentation fixes

2014-10-16 Thread Thomas Wood
Signed-off-by: Thomas Wood --- lib/igt_core.h| 1 + lib/igt_debugfs.h | 4 ++-- lib/rendercopy_gen9.c | 6 +++--- 3 files changed, 6 insertions(+), 5 deletions(-) diff --git a/lib/igt_core.h b/lib/igt_core.h index e42dc33..b8f6702 100644 --- a/lib/igt_core.h +++ b/lib/igt_core.h

[Intel-gfx] [PATCH i-g-t 1/7] Fix uninitialised variable warnings

2014-10-16 Thread Thomas Wood
Signed-off-by: Thomas Wood --- benchmarks/gem_userptr_benchmark.c | 4 ++-- tests/gem_ppgtt.c | 6 +++--- tests/gem_userptr_blits.c | 16 tools/intel_reg_dumper.c | 8 4 files changed, 17 insertions(+), 17 deletions(-) diff --git

[Intel-gfx] [PATCH i-g-t 4/7] quick_dump: fix distcheck

2014-10-16 Thread Thomas Wood
efore just the reference to base_display.txt needs removing. Cc: Damien Lespiau Signed-off-by: Thomas Wood --- tools/quick_dump/Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/quick_dump/Makefile.am b/tools/quick_dump/Makefile.am index b183af5..e7e1f62 1

[Intel-gfx] [PATCH i-g-t 3/7] lib: add common min and max macros

2014-10-16 Thread Thomas Wood
Signed-off-by: Thomas Wood --- lib/igt_aux.h| 4 tests/eviction_common.c | 2 -- tests/gem_userptr_blits.c| 2 -- tests/kms_flip.c | 8 +++- tools/intel_display_poller.c | 4 +--- 5 files changed, 8 insertions(+), 12 deletions(-) diff --git a/lib

<    1   2   3   4   5