Re: [Intel-gfx] [PATCH i-g-t v3 1/2] tests: Add blob-property test

2015-09-10 Thread Thomas Wood
On 10 September 2015 at 14:02, Daniel Stone wrote: > Hi Thomas, > > On 10 September 2015 at 13:31, Thomas Wood wrote: >> On 10 September 2015 at 07:06, Daniel Stone wrote: >>> On 10 September 2015 at 06:57, Daniel Stone wrote: >>>> Exercises the new blob-c

[Intel-gfx] [ANNOUNCE] intel-gpu-tools 1.12

2015-09-11 Thread Thomas Wood
mp; Active kms_frontbuffer_tracking: add slow_draw() subtest kms_frontbuffer_tracking: print the status when it's not what we expect Thomas Wood (31): NEWS: Post-release bump docs: override section id to avoid '/' in filenames docs: add the annotation g

Re: [Intel-gfx] [PATCH v3 0/7] igt: adding parameter to drm_open_any and drm_open_any_master to allow specification of non-intel GPUs

2015-09-11 Thread Thomas Wood
t; -mf > > > On 09/09/2015 09:54 AM, Thomas Wood wrote: >> >> On 14 August 2015 at 16:22, Micah Fedke >> wrote: >>> >>> Changes since last version of patch: >>> >>> Now using the core_* tests as demonstrations rather than drm_read. >

[Intel-gfx] [PATCH i-g-t] scripts: add quick-testlist.py

2015-09-15 Thread Thomas Wood
Add a script to take a piglit results file and create a list of tests that ran in under 60 seconds. This list can be used by the --test-list option of piglit. Signed-off-by: Thomas Wood --- scripts/quick-testlist.py | 44 1 file changed, 44

[Intel-gfx] [PATCH i-g-t] lib: allow wildcard matching when specifying subtests

2015-09-16 Thread Thomas Wood
This allows multiple subtests to be specified using standard wildcard characters when using the --run-subtest command line option. Signed-off-by: Thomas Wood --- lib/igt_core.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/igt_core.c b/lib/igt_core.c index 129476c

[Intel-gfx] [PATCH i-g-t v2] scripts: add quick-testlist.py

2015-09-17 Thread Thomas Wood
Add a script to take a piglit results file and create a list of tests that ran in under 60 seconds. This list can be used by the --test-list option of piglit. v2: exclude incomplete tests Signed-off-by: Thomas Wood --- scripts/quick-testlist.py | 46

Re: [Intel-gfx] [PATCH i-g-t v2] scripts: add quick-testlist.py

2015-09-17 Thread Thomas Wood
On 17 September 2015 at 13:09, Chris Wilson wrote: > On Thu, Sep 17, 2015 at 12:42:44PM +0100, Thomas Wood wrote: >> Add a script to take a piglit results file and create a list of tests >> that ran in under 60 seconds. This list can be used by the --test-list >> option of p

Re: [Intel-gfx] [PATCH i-g-t v2] scripts: add quick-testlist.py

2015-09-17 Thread Thomas Wood
On 17 September 2015 at 13:43, Chris Wilson wrote: > On Thu, Sep 17, 2015 at 01:16:18PM +0100, Thomas Wood wrote: >> On 17 September 2015 at 13:09, Chris Wilson wrote: >> > On Thu, Sep 17, 2015 at 12:42:44PM +0100, Thomas Wood wrote: >> >> Add a script to take a pi

Re: [Intel-gfx] [PATCH i-g-t v2] scripts: add quick-testlist.py

2015-09-17 Thread Thomas Wood
o.uk] > Sent: Thursday, September 17, 2015 3:43 PM > To: Wood, Thomas > Cc: Intel Graphics Development > Subject: Re: [Intel-gfx] [PATCH i-g-t v2] scripts: add quick-testlist.py > > On Thu, Sep 17, 2015 at 01:16:18PM +0100, Thomas Wood wrote: >> On 17 September 2015 at 13:09

Re: [Intel-gfx] [PATCH] tests/gem_ctx_param_basic: fix up non-root-set-no-zeromap subtest

2015-09-18 Thread Thomas Wood
It's helpful to include "i-g-t" in the subject line for intel-gpu-tools patches so that they are easily identified. This can be done by using the --subject-prefix "PATCH i-g-t" option when using git format-patch or send-email and can also be set as a local configuration option using the following c

Re: [Intel-gfx] [PATCH i-g-t] gem_ppgtt: Test VMA leak on context destruction

2015-09-18 Thread Thomas Wood
On 11 September 2015 at 15:31, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > Test that VMAs associated with a context are cleaned up when > contexts are destroyed. > > In practice this emulates the leak seen between fbcon and X server. > Every time the X server exits we gain one VMA on the fbc

Re: [Intel-gfx] [PATCH] tests/gem_ctx_param_basic: fix up non-root-set-no-zeromap subtest

2015-09-18 Thread Thomas Wood
On 18 September 2015 at 17:02, Jesse Barnes wrote: > On 09/18/2015 03:22 AM, Thomas Wood wrote: >> It's helpful to include "i-g-t" in the subject line for >> intel-gpu-tools patches so that they are easily identified. This can >> be done by using the --subj

[Intel-gfx] [PATCH i-g-t] lib: add igt_debugfs_search

2015-09-23 Thread Thomas Wood
Add igt_debugfs_search to search each line in a debugfs file for a specified substring. Signed-off-by: Thomas Wood --- lib/igt_debugfs.c | 31 +++ lib/igt_debugfs.h | 1 + tests/gem_ppgtt.c | 35 ++- tests

Re: [Intel-gfx] [PATCH i-g-t] gem_ppgtt: Test VMA leak on context destruction

2015-09-23 Thread Thomas Wood
On 23 September 2015 at 13:36, Tvrtko Ursulin wrote: > > Hi, > > On 09/18/2015 12:17 PM, Thomas Wood wrote: >> >> On 11 September 2015 at 15:31, Tvrtko Ursulin >> wrote: >>> >>> From: Tvrtko Ursulin >>> >>> Test that VMAs associ

Re: [Intel-gfx] [PATCH i-g-t] tests/gem_storedw_loop: Fix use after free for bufmgr

2015-09-23 Thread Thomas Wood
On 23 September 2015 at 17:01, Daniel Vetter wrote: > On Tue, Sep 22, 2015 at 12:08:05PM -0700, Jesse Barnes wrote: >> On 09/22/2015 11:02 AM, robert.beck...@intel.com wrote: >> > From: Robert Beckett >> > >> > Move bufmgr destruction to end of tests. This avoids use after free on >> > successive

[Intel-gfx] [PATCH i-g-t] gem_storedw_loop: fix segfault when listing subtests

2015-09-24 Thread Thomas Wood
subtests. Cc: Robert Beckett Cc: Jesse Barnes Cc: Daniel Vetter Signed-off-by: Thomas Wood --- tests/gem_storedw_loop.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/tests/gem_storedw_loop.c b/tests/gem_storedw_loop.c index e7ebcc2..e17e190 100644 --- a/tests

[Intel-gfx] [PATCH i-g-t] lib/tests: explicitly raise SIGSEGV

2015-09-24 Thread Thomas Wood
Dereferencing a NULL pointer is undefined behaviour and may not always result in a segmentation fault. Explicitly raise the SIGSEGV signal to test handling of this signal. Signed-off-by: Thomas Wood --- lib/tests/igt_segfault.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff

Re: [Intel-gfx] [PATCH 2/2] man: add man page for intel_reg in rst format

2015-04-16 Thread Thomas Wood
On 15 April 2015 at 11:15, Jani Nikula wrote: > Produce the man page from rst using rst2man. > > FIXME: configure support for checking rst2man. I think this can be done with a fairly straightforward AC_CHECK_PROG and AM_CONDITIONAL in configure.ac: AC_CHECK_PROG(RST2MAN, rst2man, yes, no) AM_CON

Re: [Intel-gfx] [PATCH] igt/dp: Displayport Compliance Testing - Userspace Component

2015-04-17 Thread Thomas Wood
On 10 April 2015 at 16:54, Todd Previte wrote: > This is the userspace component of the Displayport compliance testing > software requried for compliance testing of the i915 driver. The README > included in the dp_compliance/ directory contains the most up to date > information on the use and oper

Re: [Intel-gfx] [PATCH] igt/dp: Displayport Compliance Testing - Userspace Component

2015-04-20 Thread Thomas Wood
On 17 April 2015 at 18:52, Todd Previte wrote: > > > On 4/17/2015 6:44 AM, Thomas Wood wrote: >> >> On 10 April 2015 at 16:54, Todd Previte wrote: >>> >>> This is the userspace component of the Displayport compliance testing >>> software requrie

[Intel-gfx] [PATCH i-g-t] docs: avoid escaping characters in documentation comments

2015-04-21 Thread Thomas Wood
Avoid having to escape certain characters in documentation comments by not allowing docbook markup tags. Markdown formatting in documentation comments is still supported. Signed-off-by: Thomas Wood --- docs/reference/intel-gpu-tools/Makefile.am | 2 +- lib/igt_aux.c

Re: [Intel-gfx] [PATCH] i-g-t: Adding rotation to plane scaling test

2015-04-22 Thread Thomas Wood
"kms_plane_scaling" would be a better tag for this commit. You can still make sure that "i-g-t" appears in the subject line by using the --subject-prefix="PATCH i-g-t" option when using git send-email. On 16 April 2015 at 00:19, Chandra Konduru wrote: > From: chandra konduru > > Adding rotation

Re: [Intel-gfx] [PATCH] kms_rotation_crc: Adding test for 90/270 rotation

2015-04-22 Thread Thomas Wood
On 22 April 2015 at 14:37, Tvrtko Ursulin wrote: > > Hi, > > On 04/22/2015 12:14 PM, Sonika Jindal wrote: >> >> Adding 90/270 rotation testcase for primary and sprite planes. >> >> v2: Added position test for sprite. Checking for gen > 9 for 90/270. >> Some cleanup and rebase. >> v3: Added test fo

Re: [Intel-gfx] [PATCH i-g-t] tests/tools_test: Find tools in source or installed locations

2015-04-22 Thread Thomas Wood
On 17 April 2015 at 23:10, Mike Mason wrote: > Signed-off-by: Mike Mason I've pushed this patch, but I'm not actually sure if this test should actually be included in the test suite or part of the package check scripts. Daniel might be able to confirm the original intention. > --- > tests/too

Re: [Intel-gfx] [PATCH i-g-t] lib/igt_core.c : only disable low mem killer once

2015-04-24 Thread Thomas Wood
On 24 April 2015 at 14:43, wrote: > From: Tim Gore > > The call to low_mem_killer_disable(true) was being done > from within function oom_adjust_for_doom. However, > oom_adjust_for_doom gets called from 3 places. We only > want the call to low_mem_killer_disable(true) to happen > during common_i

Re: [Intel-gfx] PATCH i-g-t Fix a clang compile error.

2015-04-27 Thread Thomas Wood
On 23 April 2015 at 17:54, Yunlian Jiang wrote: > The bug entry is at > https://code.google.com/p/chromium/issues/detail?id=476001 > > The patch below makes clang happy. Thanks for the patch; Ben Widawsky reviewed it and added his reviewed-by tag. Unfortunately it doesn't apply cleanly because ta

Re: [Intel-gfx] [PATCH i-g-t] kms_atomic: Measure speed of some plane ioctls

2015-04-27 Thread Thomas Wood
On 24 April 2015 at 16:27, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > Measures DRM_IOCTL_MODE_SETCRTC and DRM_IOCTL_MODE_SETPLANE as proxy for > drm_atomic_helper_update_plane if I got it right. > > Discovered some slow cursor updates (1.6ms) so needed something to test > different kernel c

Re: [Intel-gfx] [PATCH i-g-t] tests/drm_hw_lock: Tests for hw_lock fixes.

2015-04-27 Thread Thomas Wood
On 23 April 2015 at 15:07, Peter Antoine wrote: > There are several issues with the hardware locks functions that stretch > from kernel crashes to priority escalations. This new test will test the > the fixes for these features. > > This test will cause a driver/kernel crash on un-patched kernels,

Re: [Intel-gfx] [PATCH i-g-t 7/7] kms_rotation_crc: Use main test for negative cases

2015-04-27 Thread Thomas Wood
On 23 April 2015 at 10:41, Jindal, Sonika wrote: > Thanks Tvrtko. > This series makes kms_rotation_crc much cleaner :) > > Reviewed-by: Sonika Jindal Thanks, I've pushed the whole series. > > > > On 4/22/2015 9:16 PM, Tvrtko Ursulin wrote: >> >> From: Tvrtko Ursulin >> >> Saves a good amount

Re: [Intel-gfx] [PATCH i-g-t] tests/gem_mmap_gtt: Use PAGE_SIZE instead of hard coded value

2015-04-27 Thread Thomas Wood
On 24 April 2015 at 08:38, Joonas Lahtinen wrote: > Now that there is PAGE_SIZE define, use it. Thanks, I've pushed this patch. I also noticed PAGE_SIZE gets defined in several tests, so at some point it might be worth moving it into the library. > > Signed-off-by: Joonas Lahtinen > --- > tes

Re: [Intel-gfx] [PATCH i-g-t 2/2] kms_plane_scaling: Find the image regardless how the test is run

2015-05-01 Thread Thomas Wood
On 30 April 2015 at 12:27, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > As it stands running the test like "sudo tests/kms_plane_scaling" > does not work. > > Fix it by using the same method igt_paint_image uses. Adding a new function to igt_kms would avoid duplicating stdio_read_func and ma

Re: [Intel-gfx] [PATCH i-g-t] igt_kms: Avoid NULL ptr deref when commiting disabled planes

2015-05-01 Thread Thomas Wood
On 28 April 2015 at 11:57, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > I think; > >commit a26f9f9ad0e679c7ce413a25d34f6914e1174151 >Author: chandra konduru >Date: Mon Mar 30 13:52:04 2015 -0700 > >i-g-t: Adding plane scaling test case > > introduced a condition where i

Re: [Intel-gfx] [PATCH i-g-t v2] lib/igt_core.c : only disable low mem killer once

2015-05-01 Thread Thomas Wood
to happen > during common_init, so call it from here instead of from > oom_adjust_for_doom. > > v2:Thomas Wood pointed out that the initial call to disable > the low_mem_killer does not get made when we are just > listing subtests; so I have qualified the call from the > exit handl

Re: [Intel-gfx] [PATCH igt] tests: Add KMS blob-property test

2015-05-12 Thread Thomas Wood
On 9 May 2015 at 15:57, Daniel Stone wrote: > Exercises the new blob-creation ioctl, testing lifetimes and behaviour > of user-created blobs, as well as exercising all the invariant > conditions we guarantee from modes exposed as blob properties. Since this isn't really a kms test, the test name

Re: [Intel-gfx] [PATCH 1/2] i-g-t: Prep work for adding NV12 testcase

2015-05-12 Thread Thomas Wood
On 2 May 2015 at 04:11, Chandra Konduru wrote: > From: chandra konduru > > This patch adds necessary prep work for nv12 testcase: > - updated fb allocation functions to handle NV12 format > - igt helper function to return png image size > - igt helper function to calculate start of uv in a

Re: [Intel-gfx] [PATCH] i-g-t: Adding display NV12 testcase

2015-05-12 Thread Thomas Wood
On 9 May 2015 at 05:32, Chandra Konduru wrote: > From: chandra konduru > > This patch adds kms_nv12 test case. It covers testing NV12 in > all supported linear/tile-X/tile-Y/tile-Yf tile formats in > 0 and 180 orientations. For each tiling format, it tests > various combinations of planes and sca

Re: [Intel-gfx] [PATCH i-g-t] tests/gem_cpu_reloc: Fix gem_cpu_reloc OOM failure

2015-05-13 Thread Thomas Wood
On 12 May 2015 at 13:09, Derek Morton wrote: > On android with small memory footprints gem_cpu_reloc can fail > due to OOM. > > Refactor gem_cpu_reloc into 2 tests, a basic test which performs > 10 relocations and a full test which skips if there is insufficient > memory. > > Changed the memory re

[Intel-gfx] [PATCH i-g-t 3/3] tests: match gem_create prototype in igt_eviction_test_ops create function

2015-05-14 Thread Thomas Wood
This avoids a warning when using gem_create as the create function. Signed-off-by: Thomas Wood --- tests/eviction_common.c | 2 +- tests/gem_userptr_blits.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/eviction_common.c b/tests/eviction_common.c index 6f2f194

[Intel-gfx] [PATCH i-g-t 1/3] docs: various documentation fixes

2015-05-14 Thread Thomas Wood
Fix various typos, add missing parameter documentation, include the igt_draw section and update the list of ignored headers. Signed-off-by: Thomas Wood --- docs/reference/intel-gpu-tools/Makefile.am | 3 ++- docs/reference/intel-gpu-tools/intel-gpu-tools-docs.xml | 1 + lib

[Intel-gfx] [PATCH i-g-t 2/3] igt.cocci: don't use igt_assert_neq to compare pointers

2015-05-14 Thread Thomas Wood
igt_assert_neq can only compare integers, not pointers. Signed-off-by: Thomas Wood --- lib/igt.cocci | 2 +- tests/prime_udl.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/igt.cocci b/lib/igt.cocci index f23b511..3aee72f 100644 --- a/lib/igt.cocci +++ b/lib

Re: [Intel-gfx] [PATCH i-g-t v2] tests/gem_cpu_reloc: Fix gem_cpu_reloc OOM failure

2015-05-15 Thread Thomas Wood
> Changed the memory required test to better estimate the actual > RAM used. > > v2: Addresed comments from Thomas Wood Thanks, patch merged. > > Signed-off-by: Derek Morton > --- > tests/gem_cpu_reloc.c | 52 > ++- &

Re: [Intel-gfx] [PATCH 3/3] igt/gem_create: Test to validate parameters for GEM_CREATE ioctl

2015-05-18 Thread Thomas Wood
On 13 May 2015 at 12:53, wrote: > From: Ankitprasad Sharma > > This test validates the two parameters (size and flags) GEM_CREATE ioctl. This test and the gem_stolen test in this series need a short description using the IGT_TEST_DESCRIPTION macro and the test binaries need to be added to .giti

Re: [Intel-gfx] [PATCH igt] tests: add kms_frontbuffer_tracking

2015-05-26 Thread Thomas Wood
On 25 May 2015 at 22:40, Paulo Zanoni wrote: > From: Paulo Zanoni > > This is a new test that should exercise the frontbuffer tracking > feature of the Kernel in a number of different ways. We use different > drawing methods, we use the primary, cursor and sprite planes, we can > test both on sin

Re: [Intel-gfx] [PATCH] igt: Add gem_ctx_thrash to fill the GGTT with contexts

2014-12-16 Thread Thomas Wood
On 16 December 2014 at 12:21, Chris Wilson wrote: > Signed-off-by: Chris Wilson > --- > tests/.gitignore | 1 + > tests/Makefile.am | 2 + > tests/Makefile.sources | 1 + > tests/gem_ctx_thrash.c | 152 > + > 4 files changed, 156

[Intel-gfx] [PATCH i-g-t 5/5] lib: print a message when receiving a handled signal

2014-12-17 Thread Thomas Wood
Signed-off-by: Thomas Wood --- lib/igt_core.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/lib/igt_core.c b/lib/igt_core.c index 925d78c..1307fa8 100644 --- a/lib/igt_core.c +++ b/lib/igt_core.c @@ -366,6 +366,7 @@ static void low_mem_killer_disable(bool disable

[Intel-gfx] [PATCH i-g-t 1/5] lib: print recent log output if a test fails

2014-12-17 Thread Thomas Wood
Print recent log entries if a test or subtest fails and the current log level is set to info. v2: Write log to stderr after test or subtest failure and make log buffering thread safe. Signed-off-by: Thomas Wood --- lib/igt_core.c | 103

[Intel-gfx] [PATCH i-g-t 4/5] lib: clear log buffer after writing it out or starting a new subtest

2014-12-17 Thread Thomas Wood
Signed-off-by: Thomas Wood --- lib/igt_core.c | 21 + 1 file changed, 21 insertions(+) diff --git a/lib/igt_core.c b/lib/igt_core.c index b98cb41..925d78c 100644 --- a/lib/igt_core.c +++ b/lib/igt_core.c @@ -366,6 +366,23 @@ static void low_mem_killer_disable(bool disable

[Intel-gfx] [PATCH i-g-t 2/5] lib: add a critical warning level

2014-12-17 Thread Thomas Wood
Signed-off-by: Thomas Wood --- lib/igt_core.c | 10 ++ lib/igt_core.h | 10 ++ 2 files changed, 16 insertions(+), 4 deletions(-) diff --git a/lib/igt_core.c b/lib/igt_core.c index 457b3b1..6159a8c 100644 --- a/lib/igt_core.c +++ b/lib/igt_core.c @@ -1494,9 +1494,10 @@ void

[Intel-gfx] [PATCH i-g-t 3/5] lib: use critical log level for assertion failure messages

2014-12-17 Thread Thomas Wood
Signed-off-by: Thomas Wood --- lib/igt_core.c | 19 --- lib/igt_core.h | 21 +++-- 2 files changed, 19 insertions(+), 21 deletions(-) diff --git a/lib/igt_core.c b/lib/igt_core.c index 6159a8c..b98cb41 100644 --- a/lib/igt_core.c +++ b/lib/igt_core.c @@ -951,27

Re: [Intel-gfx] [PATCH i-g-t 1/5] lib: print recent log output if a test fails

2014-12-17 Thread Thomas Wood
On 17 December 2014 at 17:19, Chris Wilson wrote: > On Wed, Dec 17, 2014 at 04:45:43PM +0000, Thomas Wood wrote: >> Print recent log entries if a test or subtest fails and the current log >> level is set to info. >> >> v2: Write log to stderr after test or s

Re: [Intel-gfx] [PATCH i-g-t] lib/Android.mk: add -DHAVE_LINUX_KD_H to fix android build

2015-01-09 Thread Thomas Wood
On 8 January 2015 at 14:18, wrote: > From: Tim Gore > > A recent change to igt_kms.c reqires HAVE_LINUX_KD_H to be set > in order to pick up the kd.h header file. Could you include a bit more detail about which commit introduced this change and why? > > Signed-off-by: Tim Gore > --- > lib/A

[Intel-gfx] [PATCH i-g-t] lib: remove unnecessary checks on the drm_open_any return value

2015-01-13 Thread Thomas Wood
drm_open_any always returns a valid file descriptor, so there is no need to check the return value. Signed-off-by: Thomas Wood --- lib/drmtest.c | 6 +++--- lib/igt.cocci | 14 ++ tests/gem_alive.c | 2 -- tests/gem_flink_race.c| 2 -- tests

[Intel-gfx] [PATCH i-g-t 2/2] tools: add intel_gpu_frequency to .gitignore

2015-01-13 Thread Thomas Wood
intel_gpu_frequency was added in commit 5fb26d1 (intel_gpu_frequency: A tool to manipulate Intel GPU frequency), but wasn't added to .gitignore. Cc: Ben Widawsky Signed-off-by: Thomas Wood --- tools/.gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/.gitignore b/

[Intel-gfx] [PATCH i-g-t 1/2] intel_gpu_frequency: fix array bounds warning

2015-01-13 Thread Thomas Wood
Add a parameter for the size of the act_upon array in the parse function since its size cannot be calculated with ARRAY_SIZE from just the pointer. Cc: Ben Widawsky Signed-off-by: Thomas Wood --- tools/intel_gpu_frequency.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff

Re: [Intel-gfx] [PATCH i-g-t 3/3] tests: Introduce kms_nuclear

2015-01-20 Thread Thomas Wood
On 20 January 2015 at 04:05, Matt Roper wrote: > A very simple testcase to exercise nuclear pageflip. We'll definitely > want to expand upon this in the future, but this is a good starting > point to sanity check nuclear pageflip support. Just a few comments from an i-g-t perspective: could you

Re: [Intel-gfx] [PATCH i-g-t 14/15] lib/igt_core: introduce --loop.

2015-01-21 Thread Thomas Wood
On 12 January 2015 at 18:22, Rodrigo Vivi wrote: > This loop option can help intensive tests everywhere. > The only caveat is that tests reimplementing main function has to implement > his own loop. Could you also add a short description of the new command line options to the test program docume

[Intel-gfx] [PATCH i-g-t 2/3] lib: print warning and critical messages when listing subtests

2015-01-27 Thread Thomas Wood
These messages are sent to stderr and could indicate an issue when enumerating subtests. Signed-off-by: Thomas Wood --- lib/igt_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/igt_core.c b/lib/igt_core.c index 2692fe4..bc588e2 100644 --- a/lib/igt_core.c +++ b/lib

[Intel-gfx] [PATCH i-g-t 3/3] lib: validate subtest names

2015-01-27 Thread Thomas Wood
Subtest names should only contain '-', '_' and alphanumeric characters. Signed-off-by: Thomas Wood --- lib/igt_core.c | 12 1 file changed, 12 insertions(+) diff --git a/lib/igt_core.c b/lib/igt_core.c index bc588e2..d74f6f8 100644 --- a/lib/igt_core.c

[Intel-gfx] [PATCH i-g-t 1/3] lib: warning messages should be sent to stderr

2015-01-27 Thread Thomas Wood
This is a regression from commit df11a0f (lib: add a critical warning level). Signed-off-by: Thomas Wood --- lib/igt_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/igt_core.c b/lib/igt_core.c index 7b47b32..2692fe4 100644 --- a/lib/igt_core.c +++ b/lib/igt_core.c

[Intel-gfx] [PATCH i-g-t 1/2] lib: add subtest start and exit status code messages to debug output

2015-01-27 Thread Thomas Wood
Signed-off-by: Thomas Wood --- lib/igt_core.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/igt_core.c b/lib/igt_core.c index d74f6f8..41f84bb 100644 --- a/lib/igt_core.c +++ b/lib/igt_core.c @@ -729,6 +729,7 @@ bool __igt_run_subtest(const char *subtest_name

[Intel-gfx] [PATCH i-g-t 2/2] lib: add exit status message to simple tests

2015-01-27 Thread Thomas Wood
Add an exit status message to simple tests, similar to the one printed for subtests. This includes the test outcome and the time taken to run the test. Signed-off-by: Thomas Wood --- lib/igt_core.c | 30 +- 1 file changed, 29 insertions(+), 1 deletion(-) diff --git

[Intel-gfx] [PATCH i-g-t 2/2] lib/tests: check that invalid subtest names are rejected

2015-01-28 Thread Thomas Wood
Signed-off-by: Thomas Wood --- lib/tests/Makefile.sources | 2 ++ lib/tests/igt_invalid_subtest_name.c | 31 +++ 2 files changed, 33 insertions(+) create mode 100644 lib/tests/igt_invalid_subtest_name.c diff --git a/lib/tests/Makefile.sources b/lib/tests

[Intel-gfx] [PATCH i-g-t 1/2] lib/tests: verify subtest enumeration output

2015-01-28 Thread Thomas Wood
Check that the subtest list is not empty if using --list-subtests returns with an exit code of 0, and that the list is empty if it returns with 79. Signed-off-by: Thomas Wood --- lib/tests/igt_command_line.sh | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/lib

[Intel-gfx] [PATCH i-g-t 0/2] printing log messages on test failure

2015-01-29 Thread Thomas Wood
This series replaces the earlier one dealing with printing recent log messages and avoids any issues with signal handlers by only printing the log on a test failure. Thomas Wood (2): lib: add a ring buffer for log entries lib: print recent log messages to stderr when a test or subtest fails

[Intel-gfx] [PATCH i-g-t 1/2] lib: add a ring buffer for log entries

2015-01-29 Thread Thomas Wood
Signed-off-by: Thomas Wood --- lib/Makefile.am | 3 ++- lib/igt_core.c | 72 - 2 files changed, 63 insertions(+), 12 deletions(-) diff --git a/lib/Makefile.am b/lib/Makefile.am index 3826a1c..a5a4390 100644 --- a/lib/Makefile.am +++ b

[Intel-gfx] [PATCH i-g-t 2/2] lib: print recent log messages to stderr when a test or subtest fails

2015-01-29 Thread Thomas Wood
Signed-off-by: Thomas Wood --- lib/igt_core.c | 40 +--- 1 file changed, 37 insertions(+), 3 deletions(-) diff --git a/lib/igt_core.c b/lib/igt_core.c index b03b7df..596ab77 100644 --- a/lib/igt_core.c +++ b/lib/igt_core.c @@ -236,6 +236,9 @@ enum

[Intel-gfx] [PATCH i-g-t 2/4] lib: use defines for igt_simple_init and igt_subtest_init

2015-02-18 Thread Thomas Wood
Signed-off-by: Thomas Wood --- lib/igt_core.c | 34 -- lib/igt_core.h | 36 2 files changed, 32 insertions(+), 38 deletions(-) diff --git a/lib/igt_core.c b/lib/igt_core.c index eef338b..afecdf1 100644 --- a/lib/igt_core.c

[Intel-gfx] [PATCH i-g-t 4/4] tests: remove extra file

2015-02-18 Thread Thomas Wood
Remove a file accidentally added in commit 6f582f7 (tests: Add gem_ctx_param_basic). Cc: Daniel Vetter Signed-off-by: Thomas Wood --- tests/gem_ctx_param_basic. | 172 - 1 file changed, 172 deletions(-) delete mode 100644 tests/gem_ctx_param_basic

[Intel-gfx] [PATCH i-g-t 3/4] lib: remove handled option arguments from argv

2015-02-18 Thread Thomas Wood
Remove options from argv that have been handled by getopt to allow additional non-option parameters to be processed in the test application. This fixes issues when using options such as --debug with tests that accept additional non-option parameters. Signed-off-by: Thomas Wood --- lib

[Intel-gfx] [PATCH i-g-t 1/4] tests: improve pipe enumeration

2015-02-18 Thread Thomas Wood
Signed-off-by: Thomas Wood --- tests/kms_flip_event_leak.c | 2 +- tests/kms_plane.c | 2 +- tests/kms_universal_plane.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/kms_flip_event_leak.c b/tests/kms_flip_event_leak.c index 8a5e6db..ea4ce4c 100644 --- a

[Intel-gfx] [PATCH i-g-t] lib: print the signal name to stderr when handling a signal

2015-02-19 Thread Thomas Wood
Signed-off-by: Thomas Wood --- lib/igt_core.c | 22 ++ 1 file changed, 18 insertions(+), 4 deletions(-) diff --git a/lib/igt_core.c b/lib/igt_core.c index 75b98f6..adfa597 100644 --- a/lib/igt_core.c +++ b/lib/igt_core.c @@ -1303,8 +1303,10 @@ static struct { static

Re: [Intel-gfx] [PATCH] i-g-t: Adding test case to test background color.

2015-02-23 Thread Thomas Wood
On 21 February 2015 at 00:12, Chandra Konduru wrote: > From: chandra konduru > > Adding i-g-t test case to test display crtc background color. > > Signed-off-by: chandra konduru > --- > lib/igt_kms.c | 60 +++ > lib/igt_kms.h | 4 + > tests/And

Re: [Intel-gfx] [PATCH i-g-t 2/4] lib: use defines for igt_simple_init and igt_subtest_init

2015-02-24 Thread Thomas Wood
o remove an extra function call. I'll add a suitable comment to the commit message. > -Daniel > > On Wed, Feb 18, 2015 at 05:06:14PM +, Thomas Wood wrote: >> Signed-off-by: Thomas Wood >> --- >> lib/igt_core.c | 34 ---

[Intel-gfx] [PATCH i-g-t 0/2] Enabling intel_reg on Android

2015-07-16 Thread Thomas Wood
intel_reg replaces various other register tools, so these patches attempt to enable building it on Android platforms. Thomas Wood (2): intel_reg: support platforms without sys/io.h tools/Android.mk: add any extra program sources configure.ac | 2 +- tools/Android.mk | 4 ++-- tools

[Intel-gfx] [PATCH i-g-t 1/2] intel_reg: support platforms without sys/io.h

2015-07-16 Thread Thomas Wood
Based on an idea from Jani Nikula. Cc: Jani Nikula Cc: Derek Morton Signed-off-by: Thomas Wood --- configure.ac | 2 +- tools/intel_reg.c | 17 - 2 files changed, 17 insertions(+), 2 deletions(-) diff --git a/configure.ac b/configure.ac index f3603c1..3770b2f 100644

[Intel-gfx] [PATCH i-g-t 2/2] tools/Android.mk: add any extra program sources

2015-07-16 Thread Thomas Wood
Cc: Derek Morton Signed-off-by: Thomas Wood --- tools/Android.mk | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/Android.mk b/tools/Android.mk index 39f4512..f7dc3bb 100644 --- a/tools/Android.mk +++ b/tools/Android.mk @@ -1,13 +1,13 @@ LOCAL_PATH := $(call my-dir

Re: [Intel-gfx] [PATCH i-g-t 2/2] tools/Android.mk: add any extra program sources

2015-07-16 Thread Thomas Wood
ent: Thursday, July 16, 2015 12:08 PM > >To: intel-gfx@lists.freedesktop.org > >Cc: Morton, Derek J > >Subject: [PATCH i-g-t 2/2] tools/Android.mk: add any extra program sources > > > >Cc: Derek Morton > >Signed-off-by: Thomas Wood > >--- > > t

[Intel-gfx] [PATCH i-g-t] lib: exit immediately if igt_fail is called in an exit handler

2015-07-16 Thread Thomas Wood
Exit immediately if the test is already exiting and igt_fail is called. This can happen if an igt_assert fails in an exit handler. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=91349 Signed-off-by: Thomas Wood --- lib/igt_core.c | 8 1 file changed, 8 insertions(+) diff --git

Re: [Intel-gfx] [PATCH] igt/kms_plane_scaling : plane scaling enhancement and plane support for bxt

2015-07-17 Thread Thomas Wood
On 17 July 2015 at 09:34, Nabendu Maiti wrote: > 1) Added more overlay plane support for BXT. > 2) Added and enhanced scaler test cases for additional planes. Please split the various separate changes in different patches. The i-g-t tag should also appear in the subject prefix rather than the su

Re: [Intel-gfx] [PATCH i-g-t v3] Android.mk: Disable tools that do not build for android

2015-07-17 Thread Thomas Wood
On 17 July 2015 at 10:15, Derek Morton wrote: > Disable the tools / demo code that do not currently build > for android until they can be fixed. > > Affected tools / demos > intel_display_crc > intel_sprite_on > > v2: intel_display_crc compiled conditionally on ANDROID_HAS_CAIRO > flag. > v3: remo

Re: [Intel-gfx] [PATCH i-g-t 0/3] gpgpu_fill test new hardware support

2015-07-20 Thread Thomas Wood
On 17 July 2015 at 10:25, Dominik Zeromski wrote: > This patches rearrange gpgpu fill library functions and add support for BDW > and SKL. Thanks, I've pushed these patches with a small fix to the first one to correct the gpgpu_fill header name in lib/Makefile.sources. > > Dominik Zeromski (3):

Re: [Intel-gfx] [PATCH i-g-t] tests/drm_import_export: Add tests for prime/flink sharing races

2015-07-24 Thread Thomas Wood
On 24 July 2015 at 10:24, Michał Winiarski wrote: > It is possible to race between unreference of the underlying BO and > importing it from prime_fd/name. Verify that the behaviour of libdrm > is consistent for prime/flink. Could you add this description into the source file as a comment? There a

Re: [Intel-gfx] [PATCH i-g-t v2] benchmark/: fix gem_exec_nop complie error on android

2015-07-24 Thread Thomas Wood
On 24 July 2015 at 14:43, Chris Wilson wrote: > On Fri, Jul 24, 2015 at 02:35:29PM +0100, Derek Morton wrote: >> There are two versions of gem_exec_nop.c in benchmarks and tests >> which causes the build system to have two build modules with >> the same name. >> This patch renames benchmarks/gem_e

Re: [Intel-gfx] [PATCH i-g-t v2] tests/drm_import_export: Add tests for prime/flink sharing races

2015-07-24 Thread Thomas Wood
tespace Thanks, patch pushed. > > Signed-off-by: Michał Winiarski > Cc: Thomas Wood > --- > tests/drm_import_export.c | 112 > ++ > 1 file changed, 112 insertions(+) > > diff --git a/tests/drm_import_export.c b/tests/drm_impor

Re: [Intel-gfx] [PATCH i-g-t v2] benchmark/: fix gem_exec_nop complie error on android

2015-07-24 Thread Thomas Wood
On 24 July 2015 at 14:35, Derek Morton wrote: > There are two versions of gem_exec_nop.c in benchmarks and tests > which causes the build system to have two build modules with > the same name. > This patch renames benchmarks/gem_exec_nop.c to > benchmarks/gem_exec_nop_benchmark.c using the existin

Re: [Intel-gfx] [PATCH i-g-t v2] benckmarks/Android.mk: Fix building benchmarks for Android

2015-08-13 Thread Thomas Wood
On 13 August 2015 at 11:27, Derek Morton wrote: > The commit "benchmarks: Do not install to system-wide bin/" changed > the benchmark file list from bin_PROGRAMS to benchmarks_PROGRAMS. > However Android.mk was not updated, resulting in IGT failing to > build for Android. > This commit adds that c

[Intel-gfx] [PATCH i-g-t] assembler: remove built sources with make clean

2015-08-17 Thread Thomas Wood
Built sources are generated by "make all", so should be removed by "make clean". This also ensures "distcleancheck" passes. Signed-off-by: Thomas Wood --- assembler/Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/assembler/Makef

[Intel-gfx] [PATCH i-g-t] lib: add a single include header

2015-08-17 Thread Thomas Wood
Add a header that includes all the headers for the library. This allows reorganisation of the library without affecting programs using it and also simplifies the headers that need to be included to use the library. Signed-off-by: Thomas Wood --- lib/igt.h | 49

Re: [Intel-gfx] [PATCH] drm: fix plane rotation when restoring fbdev configuration

2014-08-15 Thread Thomas Wood
On 14 August 2014 17:02, Daniel Vetter wrote: > On Thu, Aug 14, 2014 at 04:33:18PM +0100, Thomas Wood wrote: >> Make sure plane rotation is reset correctly when restoring the fbdev >> configuration by using drm_mode_plane_set_obj_prop. This calls the >> driver's set_pro

Re: [Intel-gfx] [PATCH] drm: fix plane rotation when restoring fbdev configuration

2014-08-15 Thread Thomas Wood
On 15 August 2014 10:42, Thomas Wood wrote: > On 14 August 2014 17:02, Daniel Vetter wrote: >> On Thu, Aug 14, 2014 at 04:33:18PM +0100, Thomas Wood wrote: >>> Make sure plane rotation is reset correctly when restoring the fbdev >>> configuration by using drm_mode_pla

Re: [Intel-gfx] [PATCH] drm: fix plane rotation when restoring fbdev configuration

2014-08-15 Thread Thomas Wood
On 15 August 2014 11:22, Daniel Vetter wrote: > On Fri, Aug 15, 2014 at 10:48:05AM +0100, Thomas Wood wrote: >> On 15 August 2014 10:42, Thomas Wood wrote: >> > On 14 August 2014 17:02, Daniel Vetter wrote: >> >> On Thu, Aug 14, 2014 at 04:33:18PM +0100, Thoma

Re: [Intel-gfx] [PATCH i-g-t 1/1] tests: Fix seg fault when gem_mmap is run without specifying a subtest

2014-08-18 Thread Thomas Wood
On 15 August 2014 22:08, Mason, Michael W wrote: > From: Mike Mason > This patch and the previous one (scripts: Allow multiple -t and -x regular expressions for run-tests.sh) look fine, but they don't apply because tabs have been converted to spaces. Can you check and re-send with this fixed?

Re: [Intel-gfx] [PATCH] intel-gpu-tools: skip kms_flip_event_leak unless we have cairo

2014-08-18 Thread Thomas Wood
On 18 August 2014 14:56, wrote: > From: Tim Gore > > kms_flip_event_leak depends on cairo, so add it to the > list of tests to skip (in Android.mk) if ANDROID_HAS_CAIRO > is not set to 1. Patch merged, thanks. > > Signed-off-by: Tim Gore > --- > tests/Android.mk | 3 ++- > 1 file changed, 2

Re: [Intel-gfx] [PATCH i-g-t 1/1] Add kms_flip_event_leak to .gitignore

2014-08-18 Thread Thomas Wood
On 15 August 2014 20:14, Mason, Michael W wrote: > This patch just adds kms_flip_event_leak to tests/.gitignore. Patch merged, thanks. > > Signed-off-by: Mike Mason > --- > tests/.gitignore | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tests/.gitignore b/tests/.gitignore index d14d8

Re: [Intel-gfx] [PATCH v2 i-g-t 1/1] tests: Fix seg fault when gem_mmap is run without specifying a subtest

2014-08-19 Thread Thomas Wood
On 18 August 2014 18:43, Mike Mason wrote: > gem_mmap seg faults when all tests are run together. This occurs because > the new-object subtest closes the gem object, but short-mmap assumes > it still exists. Thus gem_mmap__cpu() returns nil for addr and memset() > seg faults. This patch makes new-

[Intel-gfx] [PATCH i-g-t 1/3] lib: add kmstest_edid_add_3d

2014-08-20 Thread Thomas Wood
kmstest_edid_add_3d adds an EDID extension block with 3D support to a copy of the specified EDID. Signed-off-by: Thomas Wood --- lib/igt_kms.c | 80 +++ lib/igt_kms.h | 1 + 2 files changed, 81 insertions(+) diff --git a/lib/igt_kms.c b

[Intel-gfx] [PATCH i-g-t 2/3] lib: move create_stereo_fb from testdisplay to igt_fb

2014-08-20 Thread Thomas Wood
Move create_stereo_fb from testdisplay to igt_create_stereo_fb in igt_fb so that it can be used in other tests. Signed-off-by: Thomas Wood --- lib/Makefile.am | 4 +- lib/igt_fb.c| 131 lib/igt_fb.h| 2 + lib/igt_kms.h

[Intel-gfx] [PATCH i-g-t 3/3] tests: add kms_3d test

2014-08-20 Thread Thomas Wood
Add a test to verify creation and use of 3D stereo modes. Signed-off-by: Thomas Wood --- lib/igt_fb.c | 4 +- tests/.gitignore | 1 + tests/Android.mk | 1 + tests/Makefile.sources | 1 + tests/kms_3d.c | 118

[Intel-gfx] [PATCH v2] drm: fix plane rotation when restoring fbdev configuration

2014-08-20 Thread Thomas Wood
onika Jindal Cc: Ville Syrjälä Cc: Dave Airlie Cc: Daniel Vetter Signed-off-by: Thomas Wood --- drivers/gpu/drm/drm_crtc.c | 25 - drivers/gpu/drm/drm_fb_helper.c | 6 +++--- include/drm/drm_crtc.h | 3 +++ 3 files changed, 26 insertions(+), 8 dele

Re: [Intel-gfx] [PATCH] drm/i915: Print the pipe on which the vblank wait times out

2014-08-20 Thread Thomas Wood
ce. > > Signed-off-by: Damien Lespiau Reviewed-by: Thomas Wood > --- > drivers/gpu/drm/i915/intel_display.c | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/intel_display.c > b/drivers/gpu/drm/i915/intel_display.c > in

<    1   2   3   4   5   >