[Intel-gfx] [PATCH i-g-t 1/5] lib: share common logging code

2014-12-02 Thread Thomas Wood
Signed-off-by: Thomas Wood --- lib/igt_core.c | 14 +- 1 file changed, 1 insertion(+), 13 deletions(-) diff --git a/lib/igt_core.c b/lib/igt_core.c index 3fd4595..f7763b5 100644 --- a/lib/igt_core.c +++ b/lib/igt_core.c @@ -1433,20 +1433,8 @@ void igt_log(enum igt_log_level level

[Intel-gfx] [PATCH i-g-t 4/5] lib: add optional log domain filtering

2014-12-02 Thread Thomas Wood
Signed-off-by: Thomas Wood --- lib/igt_core.c | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/lib/igt_core.c b/lib/igt_core.c index 4f4cf96..d53fabb 100644 --- a/lib/igt_core.c +++ b/lib/igt_core.c @@ -228,6 +228,8 @@ enum { OPT_HELP = 'h' }; +s

[Intel-gfx] [PATCH i-g-t 5/5] lib: write out recent log output if a test fails

2014-12-02 Thread Thomas Wood
Signed-off-by: Thomas Wood --- lib/igt_core.c | 68 +- 1 file changed, 58 insertions(+), 10 deletions(-) diff --git a/lib/igt_core.c b/lib/igt_core.c index d53fabb..c369ed7 100644 --- a/lib/igt_core.c +++ b/lib/igt_core.c @@ -50,6 +50,7

[Intel-gfx] [PATCH i-g-t 3/5] lib: introduce log domains

2014-12-02 Thread Thomas Wood
Log domains can be used to identify the source of log messages, such as the test being run or the helper library. Signed-off-by: Thomas Wood --- lib/Makefile.am | 3 ++- lib/igt_core.c | 21 +++-- lib/igt_core.h | 18 +++--- lib/igt_kms.c | 2 +- 4 files

[Intel-gfx] [PATCH i-g-t] lib: always reset connectors after the state is forced

2014-12-03 Thread Thomas Wood
Install the exit handler to reset connector states whenever kmstest_force_connector is called, so that the connector states are always reset even if a test fails. Signed-off-by: Thomas Wood --- lib/igt_kms.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/lib

Re: [Intel-gfx] [PATCH i-g-t 3/5] lib: introduce log domains

2014-12-04 Thread Thomas Wood
On 3 December 2014 at 14:22, Daniel Vetter wrote: > On Tue, Dec 02, 2014 at 05:15:37PM +0000, Thomas Wood wrote: > > diff --git a/lib/igt_core.h b/lib/igt_core.h > > index a258348..5c5ee25 100644 > > --- a/lib/igt_core.h > > +++ b/lib/igt_core.h >

[Intel-gfx] [PATCH i-g-t] tests: add gem_gpgpu_fill to .gitignore

2014-12-04 Thread Thomas Wood
gem_gpgpu_fill was added in commit 4ec8479 (tests: Add gem_gpgpu_fill), but wasn't added to .gitignore. Cc: Zhenyu Wang Signed-off-by: Thomas Wood --- tests/.gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/.gitignore b/tests/.gitignore index 6e6ab58..a846cb3 100644

[Intel-gfx] [PATCH i-g-t] lib: add a function to lock memory into RAM

2014-12-08 Thread Thomas Wood
Add a function to lock memory into RAM and use it in the gem_tiled_swapping test to reduce the amount of allocated memory required to force swapping. This also reduces the amount of time required for the test to complete, since the data set is smaller. Signed-off-by: Thomas Wood --- lib

[Intel-gfx] [PATCH i-g-t 1/4] Update README

2014-12-10 Thread Thomas Wood
Signed-off-by: Thomas Wood --- README | 46 +- 1 file changed, 29 insertions(+), 17 deletions(-) diff --git a/README b/README index 8bdaebd..f1aab58 100644 --- a/README +++ b/README @@ -1,17 +1,22 @@ -This is a collection of tools for development and

[Intel-gfx] [PATCH i-g-t 2/4] Add a MAINTAINERS file

2014-12-10 Thread Thomas Wood
Signed-off-by: Thomas Wood --- CONTRIBUTING | 9 +++-- MAINTAINERS | 2 ++ 2 files changed, 5 insertions(+), 6 deletions(-) create mode 100644 MAINTAINERS diff --git a/CONTRIBUTING b/CONTRIBUTING index 0ad0c3a..a2ddf09 100644 --- a/CONTRIBUTING +++ b/CONTRIBUTING @@ -33,12 +33,9 @@ A

[Intel-gfx] [PATCH i-g-t 4/4] tools: add missing copyright headers

2014-12-10 Thread Thomas Wood
Signed-off-by: Thomas Wood --- tools/ddi_compute_wrpll.c | 23 +++ tools/intel_l3_udev_listener.c| 23 +++ tools/quick_dump/chipset_macro_wrap.c | 23 +++ tools/skl_ddb_allocation.c| 23

[Intel-gfx] [PATCH i-g-t 3/4] NEWS: Updates

2014-12-10 Thread Thomas Wood
Signed-off-by: Thomas Wood --- NEWS | 16 ++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/NEWS b/NEWS index 103c7cd..447ba77 100644 --- a/NEWS +++ b/NEWS @@ -1,18 +1,30 @@ Release 1.9 (-XX-XX) -- As usual piles of new testcases and

[Intel-gfx] [PATCH i-g-t v2 1/2] lib: introduce log domains

2014-12-10 Thread Thomas Wood
log level of the message in addition to the domain and pid. Print the expanded message only for warning and information messages. Signed-off-by: Thomas Wood --- lib/Makefile.am | 3 ++- lib/igt_core.c | 28 ++-- lib/igt_core.h | 18 +++--- lib

[Intel-gfx] [PATCH i-g-t v2 2/2] lib: add optional log domain filtering

2014-12-10 Thread Thomas Wood
v2: add an "application" filter for the default domain (used by applications) Signed-off-by: Thomas Wood --- docs/reference/intel-gpu-tools/igt_test_programs.xml | 6 -- lib/igt_core.c | 17 +++-- 2 files changed, 19 insert

[Intel-gfx] [PATCH i-g-t v2] lib: add a function to lock memory into RAM

2014-12-10 Thread Thomas Wood
systems with less RAM (Daniel Vetter) Signed-off-by: Thomas Wood --- lib/igt_aux.c | 57 ++ lib/igt_aux.h | 3 +++ tests/gem_tiled_swapping.c | 10 +++- 3 files changed, 69 insertions(+), 1 deletion(-) diff --git a/lib

Re: [Intel-gfx] [PATCH i-g-t] Demos/Android.mk: dont build intel_sprite_on

2014-12-12 Thread Thomas Wood
On 12 December 2014 at 10:18, wrote: > From: Tim Gore > > intel_sprite_on wont build on Android, due to use > of a particular API that has changed in Gmin > > Signed-off-by: Tim Gore > --- > demos/Android.mk | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/demos/A

Re: [Intel-gfx] [PATCH i-g-t v2] Android.mk: replace std=c99 with std=gnu99

2014-12-12 Thread Thomas Wood
On 12 December 2014 at 12:14, wrote: > From: Tim Gore > > The android makefiles were passing the -std=c99 flag to the > compiler which disables the typeof keyword. This causes a > build fail for a recent addition to igt_aux.h. > Change this to -std=gnu99, which is the flag used in the > linux bu

Re: [Intel-gfx] lib: Fix out of tree build of version.h

2014-12-12 Thread Thomas Wood
On 11 December 2014 at 13:11, Joonas Lahtinen wrote: > Currently out of tree build fails because the version.h.tmp is generated > into the source directory instead of the build directory where it is > later looked for. This commit fixes it. > > From 2c0617e21101d69e7219c6660936c0015f93f8ee Mon Sep

[Intel-gfx] [ANNOUNCE] intel-gpu-tools 1.9

2014-12-12 Thread Thomas Wood
2 vblanks before grabing the new crc." Revert "tests/kms_sink_crc_basic: Wait 2 vblanks before grabing the new crc." tests/pm_rc6_residency: Split RC6p and RC6pp. Sonika Jindal (1): kms_rotation_crc: Add test for cursor rotation (v2) Thomas Wood (65): doc:

Re: [Intel-gfx] [PATCH] tests: Add gem_blt_copy_align test

2014-12-12 Thread Thomas Wood
On 12 December 2014 at 16:53, Mika Kuoppala wrote: > Copy a block into destination object with varying dst/src offsets. > Put guard area before and after the blit target to see that it didn't > touch memory out of blit boundaries. > > References: https://bugs.freedesktop.org/show_bug.cgi?id=79053

[Intel-gfx] [PATCH i-g-t] lib: ensure igt_display_init clears the memory for the display struct

2014-06-16 Thread Thomas Wood
Vetter Signed-off-by: Thomas Wood --- lib/igt_kms.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/igt_kms.c b/lib/igt_kms.c index ec1ab38..1d9362d 100644 --- a/lib/igt_kms.c +++ b/lib/igt_kms.c @@ -544,6 +544,8 @@ void igt_display_init(igt_display_t *display, int drm_fd

[Intel-gfx] [PATCH i-g-t] lib: add missing includes to headers

2014-06-16 Thread Thomas Wood
Signed-off-by: Thomas Wood --- lib/debug.h | 3 +++ lib/gen7_render.h | 2 ++ lib/igt_aux.h | 1 + lib/igt_fb.h | 2 ++ lib/igt_kms.h | 1 + lib/rendercopy.h | 3 +++ 6 files changed, 12 insertions(+) diff --git a/lib/debug.h b/lib/debug.h index af9cf39..ca4b31e 100644 --- a

[Intel-gfx] [PATCH i-g-t 0/4] enabling connectors (v2)

2014-06-18 Thread Thomas Wood
The following series is a replacement for the previous series that enabled connector states to be modified. It now uses the debugfs interface to change the connection state of connectors and also adds the ability to override the EDID blocks on the connectors. Thomas Wood (4): lib: add function

[Intel-gfx] [PATCH i-g-t 1/4] lib: add function to change connector states

2014-06-18 Thread Thomas Wood
Add an API function and a test program to force a particular state on a connector. Signed-off-by: Thomas Wood --- lib/igt_kms.c | 57 + lib/igt_kms.h | 16 tests/Makefile.sources | 1 + tests/kms_force_connector.c | 89

[Intel-gfx] [PATCH i-g-t 2/4] lib: add the ability to set an EDID data block on a connector

2014-06-18 Thread Thomas Wood
Add a function to set an EDID data block on a connector and include a set of generic EDID blocks for testing. Signed-off-by: Thomas Wood --- .../intel-gpu-tools/intel-gpu-tools-docs.xml | 1 + lib/Makefile.sources | 1 + lib/igt_edid.h

[Intel-gfx] [PATCH i-g-t 4/4] tests: enable extra connectors in kms_flip and kms_pipe_crc_basic

2014-06-18 Thread Thomas Wood
Signed-off-by: Thomas Wood --- tests/kms_flip.c | 2 ++ tests/kms_pipe_crc_basic.c | 2 ++ 2 files changed, 4 insertions(+) diff --git a/tests/kms_flip.c b/tests/kms_flip.c index 46ce2ed..337e224 100644 --- a/tests/kms_flip.c +++ b/tests/kms_flip.c @@ -1595,6 +1595,8 @@ int main(int

[Intel-gfx] [PATCH i-g-t 3/4] lib: add igt_enable_connectors and igt_reset_connectors

2014-06-18 Thread Thomas Wood
igt_enable_connectors forces connectors to be enabled where doing so is known to work well. igt_reset_connectors resets the force state on all connectors. --- lib/igt_kms.c | 70 +++ lib/igt_kms.h | 3 +++ 2 files changed, 73 insertions(+)

Re: [Intel-gfx] [PATCH i-g-t 2/4] lib: add the ability to set an EDID data block on a connector

2014-06-18 Thread Thomas Wood
On 18 June 2014 14:57, Daniel Vetter wrote: > On Wed, Jun 18, 2014 at 02:44:11PM +0100, Thomas Wood wrote: >> +/** >> + * kmstest_generic_edid: >> + * @EDID_XGA: 1024x768 >> + * @EDID_SXGA: 1280x1024 >> + * @EDID_UXGA: 1600x1200 >> + * @EDID_WSXGA

[Intel-gfx] [PATCH v2 0/2] connector debugfs properties

2014-06-18 Thread Thomas Wood
The following patches update the last two patches in the original series with the suggested changes from David Herrmann. Thomas Wood (2): drm/debugfs: add a "force" file per connector drm/debugfs: add an "edid_override" file per connector drivers/gpu/drm/drm_

[Intel-gfx] [PATCH v2 2/2] drm/debugfs: add an "edid_override" file per connector

2014-06-18 Thread Thomas Wood
Herrmann) Signed-off-by: Thomas Wood --- drivers/gpu/drm/drm_crtc.c | 4 +++ drivers/gpu/drm/drm_debugfs.c | 68 ++ drivers/gpu/drm/drm_probe_helper.c | 9 - include/drm/drm_crtc.h | 1 + 4 files changed, 81 insertions(+), 1

[Intel-gfx] [PATCH v2 1/2] drm/debugfs: add a "force" file per connector

2014-06-18 Thread Thomas Wood
n fails in drm_debugfs_connector_add. (David Herrmann) Signed-off-by: Thomas Wood --- drivers/gpu/drm/drm_crtc.c| 17 ++- drivers/gpu/drm/drm_debugfs.c | 114 ++ include/drm/drmP.h| 11 include/drm/drm_crtc.h| 2 + 4 files changed, 143 insert

Re: [Intel-gfx] [PATCH] intel-gpu-tools: add igt_core init func calls to some tests

2014-06-20 Thread Thomas Wood
On 20 Jun 2014 11:28, wrote: > > From: Tim Gore > > igt-core.h/c provides some macros and initialisation > functions to support the tests but some of the single > tests do not use these. Modifying these tests to use > the igt_simple_main macro and igt_simple_init function > is the first step towa

Re: [Intel-gfx] [PATCH 1/2] intel-gpu-tools: pass argc/argv to simple main

2014-07-01 Thread Thomas Wood
On 27 June 2014 15:15, wrote: > From: Tim Gore > > Quite a few single tests do not use the igt_simple_main > macro because they want access to argc/argv. So change the > igt_simple_main macro to pass these arguments through to the > "__real_mainxxx" function, and change these tests to use > the

Re: [Intel-gfx] [PATCH 2/2] intel-gpu-tools: Re-use igt_subtest_init for simple tests

2014-07-01 Thread Thomas Wood
On 27 June 2014 15:15, wrote: > From: Tim Gore > > igt_subtest_init mainly does stuff that we also want for > simple/single tests, such as looking for --list-subtests > and --help options and calling common_init. So just call > this from igt_simple_init and then set tests_with_subtests > to fals

Re: [Intel-gfx] how to build intel-gpu-tools without cairo

2014-07-02 Thread Thomas Wood
On 1 July 2014 19:49, Liu, Ying2 wrote: > The latest intel-gpu-tools has dependency on cairo. We don’t use cairo. > > Is there any way to build intel-gpu-tools without cairo? Cairo has been a required dependency since version 1.2. It is used by various tests and tools and therefore there isn't a

[Intel-gfx] [PATCH i-g-t] scripts: add a script to help run tests with Piglit

2014-07-07 Thread Thomas Wood
Add a script to facilitate running the tests with Piglit by providing simplified options for listing, filtering and creating summaries of test runs. Signed-off-by: Thomas Wood --- .gitignore | 3 ++ scripts/Makefile.am | 2 +- scripts/run-tests.sh | 120

[Intel-gfx] Changes to running intel-gpu-tools with Piglit

2014-07-11 Thread Thomas Wood
I've just updated the instructions in the intel-gpu-tools README to detail the new ways to run the tests. The most important change is that the igt symlink support has been removed from Piglit. Anyone using the symlink to tell Piglit where to locate the tests needs to update to either use piglit.c

Re: [Intel-gfx] [PATCH] igt/build: Do not fail git build when there is no git

2014-07-22 Thread Thomas Wood
The following patch includes the changes to fix building from a git repository without git being installed and also combines the version.h generation from the Autotools and Android build systems, so the changes do not have to be duplicated. Thomas Wood (1): build: improve version.h generation

[Intel-gfx] [PATCH] build: improve version.h generation

2014-07-22 Thread Thomas Wood
es changes from Tvrtko Ursulin to prevent a build from within the git repository failing when git is not available. Signed-off-by: Thomas Wood Cc: Tvrtko Ursulin --- .gitignore | 1 - Makefile.am | 23 --- lib/.gitignore | 1 + lib/Android.mk

[Intel-gfx] [PATCH i-g-t 6/8] tests: convert simple tests to use igt_simple_init_parse_opts

2014-07-23 Thread Thomas Wood
Convert simple tests to use igt_simple_init_parse_opts if they require extra options. Signed-off-by: Thomas Wood --- lib/igt_core.h | 1 + tests/gem_ctx_basic.c | 20 +++-- tests/gem_render_copy.c | 25 +--- tests/gem_seqno_wrap.c | 82

[Intel-gfx] [PATCH i-g-t 4/8] lib: add igt_simple_init_parse_opts

2014-07-23 Thread Thomas Wood
This function allows simple tests to register additional command line options. Signed-off-by: Thomas Wood --- lib/igt_core.c | 22 ++ lib/igt_core.h | 5 + 2 files changed, 27 insertions(+) diff --git a/lib/igt_core.c b/lib/igt_core.c index ee6f90c..72c77e6 100644

[Intel-gfx] [PATCH i-g-t 0/8] command line parsing

2014-07-23 Thread Thomas Wood
The following series attempts to standardise command line parsing and options across the various types of tests. This allows all tests to respond to common options such as --help and --debug, and also warn when unknown or invalid options are used. Thomas Wood (8): lib: warn when attempting to

[Intel-gfx] [PATCH i-g-t 1/8] lib: warn when attempting to run an unknown subtest

2014-07-23 Thread Thomas Wood
Signed-off-by: Thomas Wood --- lib/igt_core.c | 18 +++--- 1 file changed, 15 insertions(+), 3 deletions(-) diff --git a/lib/igt_core.c b/lib/igt_core.c index b197932..5c20581 100644 --- a/lib/igt_core.c +++ b/lib/igt_core.c @@ -204,6 +204,7 @@ static unsigned int exit_handler_count

[Intel-gfx] [PATCH i-g-t 5/8] lib: don't ignore unknown options in multi-tests

2014-07-23 Thread Thomas Wood
None of the current tests have additional options that might make use of any unknown options and igt_subtest_init_parse_opts is available that integrates additional option parsing. Signed-off-by: Thomas Wood --- lib/igt_core.c | 13 + 1 file changed, 1 insertion(+), 12 deletions

[Intel-gfx] [PATCH i-g-t 3/8] lib: move option parsing into common_init

2014-07-23 Thread Thomas Wood
Move option parsing into common_init so it can be shared between simple tests and tests with subtests. This allows for more common command line behaviour across all tests. Signed-off-by: Thomas Wood --- lib/igt_core.c | 118 - 1 file

[Intel-gfx] [PATCH i-g-t 8/8] lib: add a command line option to enable debug output in tests

2014-07-23 Thread Thomas Wood
Add --debug as a common command line option for all tests to enable debug output. Signed-off-by: Thomas Wood --- lib/igt_core.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/lib/igt_core.c b/lib/igt_core.c index 42b22fc..d90e6bb 100644 --- a/lib/igt_core.c +++ b/lib

[Intel-gfx] [PATCH i-g-t 7/8] lib: always warn about unknown options

2014-07-23 Thread Thomas Wood
All tests can now register extra options, so there should not be any unknown options. Signed-off-by: Thomas Wood --- lib/igt_core.c | 27 --- 1 file changed, 4 insertions(+), 23 deletions(-) diff --git a/lib/igt_core.c b/lib/igt_core.c index 0867c27..42b22fc 100644

[Intel-gfx] [PATCH i-g-t 2/8] tests: remove unused getopt header includes

2014-07-23 Thread Thomas Wood
Signed-off-by: Thomas Wood --- lib/drmtest.c | 1 - lib/igt_aux.c | 1 - lib/rendercopy_gen6.c | 1 - lib/rendercopy_gen7.c | 1 - lib/rendercopy_gen8.c | 1 - lib/rendercopy_i830.c | 1 - lib/rendercopy_i915.c

Re: [Intel-gfx] [PATCH] igt_core: Inject subtest message into dmesg

2014-07-24 Thread Thomas Wood
On 24 July 2014 13:36, Daniel Vetter wrote: > On Thu, Jul 24, 2014 at 12:48:33PM +0100, Chris Wilson wrote: >> One of the side-effects we test for are kernel oops and knowing the >> guilty subtest can help speed up debugging. We can write to /dev/kmsg to >> inject messages into dmesg, so let's do

Re: [Intel-gfx] [PATCH] intel-gpu-tools: fix version.h creation in android

2014-07-24 Thread Thomas Wood
On 24 July 2014 15:40, wrote: > From: Tim Gore > > commit 743dc7997aa9f5210055896940d87c88983dcda6 > breaks the build under Android because version.h > is not created. This happens because the android > make executes from the ANDROID_BUILD_TOP directory > rather than from the directory containin

[Intel-gfx] [PATCH i-g-t] testdisplay: only set terminal attributes when in foreground process group

2014-07-25 Thread Thomas Wood
attributes if the process is not in the foreground process group. Signed-off-by: Thomas Wood --- tests/testdisplay.c | 5 + 1 file changed, 5 insertions(+) diff --git a/tests/testdisplay.c b/tests/testdisplay.c index 6d8fe3a..f60e66d 100644 --- a/tests/testdisplay.c +++ b/tests/testdisplay.c

Re: [Intel-gfx] [PATCH v2] intel-gpu-tools: fix version.h creation in android

2014-07-25 Thread Thomas Wood
On 24 July 2014 17:38, wrote: > From: Tim Gore > > commit 743dc7997aa9f5210055896940d87c88983dcda6 > breaks the build under Android because version.h > is not created. This happens because the android > make executes from the ANDROID_BUILD_TOP directory > rather than from the directory containin

Re: [Intel-gfx] [PATCH v2] intel-gpu-tools: fix version.h creation in android

2014-07-25 Thread Thomas Wood
On 25 July 2014 12:33, Thomas Wood wrote: > On 24 July 2014 17:38, wrote: >> From: Tim Gore >> >> commit 743dc7997aa9f5210055896940d87c88983dcda6 >> breaks the build under Android because version.h >> is not created. This happens because the android >> m

[Intel-gfx] [PATCH i-g-t] testdisplay: set a non-zero exit code if getopt detected an error

2014-07-25 Thread Thomas Wood
Signed-off-by: Thomas Wood --- tests/testdisplay.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/testdisplay.c b/tests/testdisplay.c index f60e66d..20b0615 100644 --- a/tests/testdisplay.c +++ b/tests/testdisplay.c @@ -670,7 +670,7 @@ static void __attribute__

[Intel-gfx] [PATCH i-g-t] lib: avoid getopt value conflicts with tests

2014-07-25 Thread Thomas Wood
Most tests use a printable character as the value for getopt to return, so avoid conflicts by using non-printing values for the standard options. Signed-off-by: Thomas Wood --- lib/igt_core.c | 23 +++ 1 file changed, 15 insertions(+), 8 deletions(-) diff --git a/lib

Re: [Intel-gfx] [PATCH i-g-t] lib: avoid getopt value conflicts with tests

2014-07-28 Thread Thomas Wood
On 25 July 2014 17:57, Paulo Zanoni wrote: > 2014-07-25 13:08 GMT-03:00 Thomas Wood : >> Most tests use a printable character as the value for getopt to return, >> so avoid conflicts by using non-printing values for the standard options. > > Instead of this patch, isn't

[Intel-gfx] [PATCH i-g-t] lib: check test options for conflicts

2014-07-28 Thread Thomas Wood
Check any test specific options for conflicts with the standard set of options. Signed-off-by: Thomas Wood --- lib/igt_core.c | 46 ++ 1 file changed, 42 insertions(+), 4 deletions(-) diff --git a/lib/igt_core.c b/lib/igt_core.c index 0e254e3

[Intel-gfx] [PATCH i-g-t] lib: don't abort if forcing the connector state fails

2014-07-28 Thread Thomas Wood
Ensure tests using igt_enable_connectors can still run even if the relevant debugfs files are not available. Signed-off-by: Thomas Wood --- lib/igt_kms.c | 19 ++- lib/igt_kms.h | 2 +- 2 files changed, 15 insertions(+), 6 deletions(-) diff --git a/lib/igt_kms.c b/lib

[Intel-gfx] [PATCH i-g-t] testdisplay: ignore invalid subtest options

2014-07-31 Thread Thomas Wood
testdisplay does not have any subtests and should therefore exit with the appropriate exit code if the --list-subtests or --run-subtest options are used. Signed-off-by: Thomas Wood --- tests/testdisplay.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/tests

[Intel-gfx] [PATCH] drm: fix plane rotation when restoring fbdev configuration

2014-08-14 Thread Thomas Wood
Make sure plane rotation is reset correctly when restoring the fbdev configuration by using drm_mode_plane_set_obj_prop. This calls the driver's set_property callback and ensures the rotation is actually changed. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=82236 Signed-off-by: T

[Intel-gfx] [PATCH i-g-t 1/2] lib: add igt_restore_vt_mode

2014-08-14 Thread Thomas Wood
Add a function to restore the previous VT mode after igt_set_vt_graphics_mode is called. Signed-off-by: Thomas Wood --- lib/igt_kms.c | 27 +-- lib/igt_kms.h | 1 + 2 files changed, 22 insertions(+), 6 deletions(-) diff --git a/lib/igt_kms.c b/lib/igt_kms.c index

[Intel-gfx] [PATCH i-g-t 0/2] Check plane rotation is reset after VT mode is restored

2014-08-14 Thread Thomas Wood
cached value for the rotation and the actual value. https://bugs.freedesktop.org/show_bug.cgi?id=82236 Thomas Wood (2): lib: add igt_restore_vt_mode tests: check plane rotation is reset after the VT mode is restored lib/igt_kms.c| 27 +-- lib/igt_kms.h

[Intel-gfx] [PATCH i-g-t 2/2] tests: check plane rotation is reset after the VT mode is restored

2014-08-14 Thread Thomas Wood
/show_bug.cgi?id=82236 Signed-off-by: Thomas Wood --- tests/kms_rotation_crc.c | 15 ++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/tests/kms_rotation_crc.c b/tests/kms_rotation_crc.c index 9146b4f..9f272fa 100644 --- a/tests/kms_rotation_crc.c +++ b/tests/kms_rotation_crc.c

[Intel-gfx] [PATCH i-g-t] intel_reg: install and load the register files

2015-06-10 Thread Thomas Wood
Cc: Jani Nikula Signed-off-by: Thomas Wood --- configure.ac | 5 +++-- tools/Makefile.am| 3 ++- tools/intel_reg.c| 4 ++-- tools/quick_dump/Makefile.am | 13 - 4 files changed, 15 insertions(+), 10 deletions(-) diff --git a/configure.ac b

[Intel-gfx] [PATCH i-g-t] tools: print a warning for tools replaced by intel_reg

2015-06-10 Thread Thomas Wood
Cc: Jani Nikula Signed-off-by: Thomas Wood --- tools/intel_iosf_sb_read.c | 3 +++ tools/intel_iosf_sb_write.c | 3 +++ tools/intel_reg_dumper.c| 3 +++ tools/intel_reg_read.c | 3 +++ tools/intel_reg_snapshot.c | 4 tools/intel_reg_write.c | 3 +++ tools/intel_vga_read.c

[Intel-gfx] [ANNOUNCE] intel-gpu-tools 1.11

2015-06-11 Thread Thomas Wood
A new intel-gpu-tools quarterly release is available with the following changes: - Various new tests and tools - Single combined test list (supported by piglit since commit 8a122bb) - Optional dependency on libunwind to provide automatic stack traces on test failures. (Thomas Wood) - Add

Re: [Intel-gfx] [PATCH i-g-t] Android.mk: Disable tools that do not build for android

2015-06-15 Thread Thomas Wood
On 15 June 2015 at 14:04, Derek Morton wrote: > Disable the tools / demo code that do not currently build > for android until they can be fixed. What needs to be fixed? > > Affected tools / demos > intel_reg > intel_display_crc > intel_sprite_on > > Signed-off-by: Derek Morton > --- > Android

Re: [Intel-gfx] [PATCH i-g-t] intel_reg: install and load the register files

2015-06-15 Thread Thomas Wood
On 10 June 2015 at 11:30, Thomas Wood wrote: > Cc: Jani Nikula > Signed-off-by: Thomas Wood I haven't pushed this yet because there seems to be a discrepancy between the built in register list and that from the quick_dump files. Jani also suggested it may be a better idea to use t

Re: [Intel-gfx] [PATCH i-g-t] tools: print a warning for tools replaced by intel_reg

2015-06-15 Thread Thomas Wood
On 15 June 2015 at 16:51, Jani Nikula wrote: > On Mon, 15 Jun 2015, Daniel Vetter wrote: >> On Wed, Jun 10, 2015 at 11:41:03AM +0100, Thomas Wood wrote: >>> Cc: Jani Nikula >>> Signed-off-by: Thomas Wood >> >> I'd go even one step further and do

[Intel-gfx] [PATCH i-g-t] docs: override section id to avoid '/' in filenames

2015-06-29 Thread Thomas Wood
The section id is generated from the section title and is used to create the html output filename, which therefore causes problems if it includes a '/' character. Cc: Damien Lespiau Signed-off-by: Thomas Wood --- lib/intel_mmio.c | 1 + 1 file changed, 1 insertion(+) diff -

Re: [Intel-gfx] [PATCH i-g-t 4/4] build: Add an option to not use the git hash in version

2015-07-02 Thread Thomas Wood
On 2 July 2015 at 00:21, Damien Lespiau wrote: > When developing, it's quite annoying that the version changes every > commit, causing the library to be rebuild and everything single binary everything → every > re-linked. > > Add a config option to skip that. > > I remember Ville asking for this

Re: [Intel-gfx] [PATCH v3 5/5] drm/i915: Expose I915_EXEC_RESOURCE_STREAMER flag

2015-07-06 Thread Thomas Wood
On 6 July 2015 at 09:46, Abdiel Janulgue wrote: > > > On 07/06/2015 11:28 AM, Daniel Vetter wrote: >> On Thu, Jul 02, 2015 at 11:15:40AM +0100, Chris Wilson wrote: >>> On Wed, Jul 01, 2015 at 10:12:23AM +0300, Abdiel Janulgue wrote: Ensures that the batch buffer is executed by the resource st

Re: [Intel-gfx] [PATCH 2/2 i-g-t] lib/igt.cocci: Add 64-bit and float compare functions

2015-07-07 Thread Thomas Wood
gt;> > thusassert(a >= b); was transformed to >> > >> > insist(a, >=, b); >> > >> > So the order of operands and the specific comparator remain clearly >> > visible, >> > rather than being interchanged or logically

Re: [Intel-gfx] [PATCH i-g-t] kms_addfb_basic: Require fb modifiers for unused field tests

2015-08-24 Thread Thomas Wood
On 20 August 2015 at 15:43, Ander Conselvan de Oliveira wrote: > The drm core doesn't check unused fields of ADDFB2 for pre-FB_MODIFIERS > userspace, so require that and use the local version of the defines. > > Signed-off-by: Ander Conselvan de Oliveira > > --- > tests/kms_addfb_basic.c | 19 +

Re: [Intel-gfx] [PATCH] intel-gpu-tools: Fixes-compiler-warnings-about-wrong-function-type

2015-08-26 Thread Thomas Wood
On 24 August 2015 at 10:59, Stefan Dirsch wrote: > Hi > > Find a simple buildfix against current intel-gpu-tools git sources attached. I assume the compiler warning is about uninitialised values and unused variables? It looks like the Makefile is not using the debug cflags so these warning do not

[Intel-gfx] [PATCH i-g-t] tests/tools: add --as-needed to linker flags

2015-08-28 Thread Thomas Wood
to the execution speed and memory consumption. Signed-off-by: Thomas Wood --- tests/Makefile.am | 1 + tools/Makefile.am | 1 + 2 files changed, 2 insertions(+) diff --git a/tests/Makefile.am b/tests/Makefile.am index dcac2f3..5aa480b 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am

[Intel-gfx] [PATCH i-g-t] tools/null_state_gen: fix various compiler warnings

2015-08-28 Thread Thomas Wood
Add the debug and warning flags to cflags and fix the resulting issues. Signed-off-by: Thomas Wood --- tools/null_state_gen/Makefile.am | 2 ++ tools/null_state_gen/intel_batchbuffer.c | 7 +++--- tools/null_state_gen/intel_batchbuffer.h | 4 +++- tools/null_state_gen

[Intel-gfx] [PATCH i-g-t 1/2] tests/gem_storedw_loop: skip on gen6 bsd

2015-09-03 Thread Thomas Wood
Signed-off-by: Thomas Wood --- tests/gem_storedw_loop.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/tests/gem_storedw_loop.c b/tests/gem_storedw_loop.c index 2263397..1bb276e 100644 --- a/tests/gem_storedw_loop.c +++ b/tests/gem_storedw_loop.c @@ -144,6

[Intel-gfx] [PATCH i-g-t 2/2] tests/gem_storedw_loop: remove redundant ppgtt check

2015-09-03 Thread Thomas Wood
All tests require ppgtt, so checking for it later on has no effect. Signed-off-by: Thomas Wood --- tests/gem_storedw_loop.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/tests/gem_storedw_loop.c b/tests/gem_storedw_loop.c index 1bb276e..08a6ad6 100644 --- a/tests

[Intel-gfx] [PATCH i-g-t] tools: remove quick_dump

2015-09-04 Thread Thomas Wood
Remove quick_dump as it has been replaced by the intel_reg tool and move the register definition files to tools/registers. Signed-off-by: Thomas Wood --- README | 13 --- configure.ac | 27 + man

[Intel-gfx] [PATCH i-g-t] tools: install the register definition files

2015-09-04 Thread Thomas Wood
Install the register definition files and use them by default in intel_reg. Suggested-by: Jani Nikula Signed-off-by: Thomas Wood --- configure.ac| 5 +++-- tools/Makefile.am | 2 +- tools/intel_reg.c | 4 +++- tools/registers/Makefile.am | 3 ++- 4 files

[Intel-gfx] [PATCH i-g-t v2] tools: install the register definition files

2015-09-04 Thread Thomas Wood
Install the register definition files and use them by default in intel_reg. v2: remove redundant path check Suggested-by: Jani Nikula Signed-off-by: Thomas Wood --- configure.ac| 5 +++-- tools/Makefile.am | 2 +- tools/intel_reg.c | 4 ++-- tools/registers

[Intel-gfx] [PATCH i-g-t 2/2] tests/gem_pwrite_snooped: fix const cast warning

2015-09-07 Thread Thomas Wood
Signed-off-by: Thomas Wood --- tests/gem_pwrite_snooped.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/gem_pwrite_snooped.c b/tests/gem_pwrite_snooped.c index d3f6223..29142c3 100644 --- a/tests/gem_pwrite_snooped.c +++ b/tests/gem_pwrite_snooped.c @@ -76,14

[Intel-gfx] [PATCH i-g-t 1/2] build: fix unused-result warnings

2015-09-07 Thread Thomas Wood
Signed-off-by: Thomas Wood --- benchmarks/kms_vblank.c| 7 --- debugger/eudb.c| 4 +++- lib/igt_aux.c | 8 ++-- overlay/gpu-top.c | 4 +++- overlay/overlay.c | 4 ++-- tools/intel_l3_udev_listener.c | 4 ++-- tools

[Intel-gfx] [PATCH i-g-t] tests: remove gem_storedw_loop_* tests

2015-09-07 Thread Thomas Wood
These have been replaced by subtests in gem_storedw_loop. Signed-off-by: Thomas Wood --- tests/.gitignore| 4 -- tests/Makefile.sources | 4 -- tests/gem_storedw_loop_blt.c| 150 --- tests/gem_storedw_loop_bsd.c| 153

Re: [Intel-gfx] [PATCH i-g-t 2/2] tests/gem_pwrite_snooped: fix const cast warning

2015-09-07 Thread Thomas Wood
On 7 September 2015 at 13:53, Ville Syrjälä wrote: > On Mon, Sep 07, 2015 at 12:34:12PM +0100, Thomas Wood wrote: >> Signed-off-by: Thomas Wood >> --- >> tests/gem_pwrite_snooped.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --g

[Intel-gfx] [PATCH i-g-t] intel_reg: ensure "intel_reg help" always works

2015-09-07 Thread Thomas Wood
Signed-off-by: Thomas Wood --- tools/intel_reg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/intel_reg.c b/tools/intel_reg.c index 95760db..2b3c686 100644 --- a/tools/intel_reg.c +++ b/tools/intel_reg.c @@ -865,7 +865,7 @@ int main(int argc, char *argv

[Intel-gfx] [PATCH i-g-t] tests/gem_pwrite_snooped: disable const cast warning

2015-09-08 Thread Thomas Wood
Disable -Wcast-qual temporarily to allow memchr_inv to return non-const data (similar to memchr), without causing a compiler warning. Cc: Ville Syrjälä Signed-off-by: Thomas Wood --- tests/gem_pwrite_snooped.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tests/gem_pwrite_snooped.c b

Re: [Intel-gfx] [PATCH 0/3] remove crtc<->pipe mapping code

2015-09-08 Thread Thomas Wood
On 4 September 2015 at 19:22, Micah Fedke wrote: > This patchset removes the code that looks up a pipe number from a crtc ID. > The > pipe number is equivalent to the index of the crtc in the array of crtcs > returned by the kernel for a drmModeGetResources() call. This may not have > been the

Re: [Intel-gfx] [PATCH 3/3] overlay: remove crtc<->pipe mapping code from kms-overlay

2015-09-08 Thread Thomas Wood
On 4 September 2015 at 19:22, Micah Fedke wrote: > the crtc id is now always equivalent to its index in the array of crtcs > returned by the kernel > > --- > overlay/Makefile.am | 4 ++-- > overlay/kms/kms-overlay.c | 7 ++- > 2 files changed, 4 insertions(+), 7 deletions(-) > > diff --

[Intel-gfx] [PATCH i-g-t 1/2] tools/aubdump: remove void pointer arithmetic

2015-09-08 Thread Thomas Wood
A gcc extension allows void pointer arithmetic by treating the size of void as 1, but this generates a warning when -Wpointer-arith is used. Signed-off-by: Thomas Wood --- tools/aubdump.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/aubdump.c b/tools/aubdump.c

[Intel-gfx] [PATCH i-g-t 2/2] null_state_gen: add const to intel_batch_state_copy data

2015-09-08 Thread Thomas Wood
The data is not modified by the function and is often declared const. Signed-off-by: Thomas Wood --- tools/null_state_gen/intel_batchbuffer.c | 6 +++--- tools/null_state_gen/intel_batchbuffer.h | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/tools/null_state_gen

Re: [Intel-gfx] [PATCH i-g-t] Add a link training test

2015-09-09 Thread Thomas Wood
On 8 September 2015 at 13:28, Ander Conselvan de Oliveira wrote: > This adds a test that compiles the link training code from i915 into a > separate executable and uses it to train a fake sink device. The test > also uses device information from i915 to exercise the different code > paths for diff

Re: [Intel-gfx] [PATCH i-g-t] intel_reg: ensure "intel_reg help" always works

2015-09-09 Thread Thomas Wood
On 9 September 2015 at 13:20, Jani Nikula wrote: > On Mon, 07 Sep 2015, Thomas Wood wrote: >> Signed-off-by: Thomas Wood > > I'm lagging behind with my mails, and I see you already pushed > this... but care to explain the scenario where 'intel_reg help' does

Re: [Intel-gfx] [PATCH i-g-t] tests/gem_ctx_param_basic.c: fix non-root-set-no-zeromap subtest

2015-09-09 Thread Thomas Wood
On 9 September 2015 at 09:46, wrote: > From: Daniele Ceraolo Spurio > > The test expects an ioctl failure when it tries to set > CONTEXT_PARAM_NO_ZEROMAP from a non-root process. However, there is no > requirement in the kernel for the user to be root to set this parameter, > so the test is fail

Re: [Intel-gfx] [PATCH 1/3] tools/intel_reg: Use pci device from config on write

2015-09-09 Thread Thomas Wood
On 28 August 2015 at 16:16, Jani Nikula wrote: > On Fri, 28 Aug 2015, Mika Kuoppala wrote: >> Use the pre configured pci device from config also >> in write path. >> >> Cc: Jani Nikula >> Signed-off-by: Mika Kuoppala >> --- >> tools/intel_reg.c | 2 +- >> 1 file changed, 1 insertion(+), 1 dele

Re: [Intel-gfx] [PATCH i-g-t] tools/Android.mk: Fix compile error in intel_reg.c

2015-09-09 Thread Thomas Wood
On 9 September 2015 at 14:30, Derek Morton wrote: > The patch "tools: install the register definition files" caused > a build error on android as it added 'PKGDATADIR' which was not > defined in the Android build environment. This patch adds that > define to tools/Android.mk. It also copies the fi

Re: [Intel-gfx] [PATCH v3 0/7] igt: adding parameter to drm_open_any and drm_open_any_master to allow specification of non-intel GPUs

2015-09-09 Thread Thomas Wood
On 14 August 2015 at 16:22, Micah Fedke wrote: > Changes since last version of patch: > > Now using the core_* tests as demonstrations rather than drm_read. Apologies for not getting to this sooner, but it no longer applies to master. Can you rebase the series and send it again? > > Micah Fedke

[Intel-gfx] [PATCH i-g-t] lib: don't use igt_warn in signal handlers

2015-09-10 Thread Thomas Wood
igt_wan and other log functions are not async-signal safe, so should not be used in signal handlers. Reported-by: Paulo Zanoni Signed-off-by: Thomas Wood --- lib/igt_aux.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/lib/igt_aux.c b/lib/igt_aux.c index

Re: [Intel-gfx] [PATCH i-g-t v3 1/2] tests: Add blob-property test

2015-09-10 Thread Thomas Wood
On 10 September 2015 at 07:06, Daniel Stone wrote: > Hi, > > On 10 September 2015 at 06:57, Daniel Stone wrote: >> Exercises the new blob-creation ioctl, testing lifetimes and behaviour >> of user-created blobs, as well as exercising all the invariant >> conditions we guarantee from modes exposed

<    1   2   3   4   5   >