[Intel-gfx] [PATCH 1/3] drm/edid: fix length check when adding extra 3D modes

Signed-off-by: Thomas Wood --- drivers/gpu/drm/drm_edid.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index 52e060e..0a1e4a5 100644 --- a/drivers/gpu/drm/drm_edid.c +++ b/drivers/gpu/drm/drm_edid.c @@ -2674,7 +2674,7

[Intel-gfx] [PATCH 3/3] drm/edid: parse the list of additional 3D modes

Parse 2D_VIC_order_X and 3D_Structure_X from the list at the end of the HDMI Vendor Specific Data Block. v2: Use an offset value depending on 3D_Multi_present and add detail_present. (Ville Syrjälä) Signed-off-by: Thomas Wood --- drivers/gpu/drm/drm_edid.c | 64

[Intel-gfx] [PATCH 2/3] drm/edid: split VIC display mode lookup into a separate function

Signed-off-by: Thomas Wood --- drivers/gpu/drm/drm_edid.c | 67 +++--- 1 file changed, 39 insertions(+), 28 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index 0a1e4a5..f1d6e1e 100644 --- a/drivers/gpu/drm/drm_edid.c

[Intel-gfx] [PATCH] drm/edid: parse the list of additional 3D modes

Syrjälä) Fix one length check and remove another. (Ville Syrjälä) Signed-off-by: Thomas Wood --- drivers/gpu/drm/drm_edid.c | 94 +++--- 1 file changed, 73 insertions(+), 21 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c

[Intel-gfx] [PATCH i-g-t] assembler: define YY_NO_INPUT to prevent unused symbol warnings

Signed-off-by: Thomas Wood --- assembler/lex.l | 1 + 1 file changed, 1 insertion(+) diff --git a/assembler/lex.l b/assembler/lex.l index 4f1f961..81a52ba 100644 --- a/assembler/lex.l +++ b/assembler/lex.l @@ -12,6 +12,7 @@ extern char *input_filename; /* Locations */ int yycolumn = 1

[Intel-gfx] [PATCH i-g-t] lib: fix signed/unsigned comparison issues

Store the result of set_vt_mode as a signed value so that errors can be caught correctly. Signed-off-by: Thomas Wood --- lib/igt_kms.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/lib/igt_kms.c b/lib/igt_kms.c index 3960d24..5f341ff 100644 --- a/lib/igt_kms.c

[Intel-gfx] [PATCH i-g-t 0/3] Various small fixes

The following patches fix various issues in intel-gpu-tools that were found by static analysis and compiler warnings. Thomas Wood (3): debugger: fix the -p option assembler: fix condition for printing a warning tests/gem_seqno_wrap: fix over allocation of buffers assembler/gram.y

[Intel-gfx] [PATCH i-g-t 3/3] tests/gem_seqno_wrap: fix over allocation of buffers

Signed-off-by: Thomas Wood --- tests/gem_seqno_wrap.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/gem_seqno_wrap.c b/tests/gem_seqno_wrap.c index 40c6227..e37365f 100644 --- a/tests/gem_seqno_wrap.c +++ b/tests/gem_seqno_wrap.c @@ -207,13 +207,13 @@ static int

[Intel-gfx] [PATCH i-g-t 1/3] debugger: fix the -p option

Signed-off-by: Thomas Wood --- debugger/eudb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/debugger/eudb.c b/debugger/eudb.c index ff77e42..4cbc2d7 100644 --- a/debugger/eudb.c +++ b/debugger/eudb.c @@ -538,7 +538,7 @@ int main(int argc, char* argv

[Intel-gfx] [PATCH i-g-t 2/3] assembler: fix condition for printing a warning

Signed-off-by: Thomas Wood --- assembler/gram.y | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/assembler/gram.y b/assembler/gram.y index ad4cb29..f4145bd 100644 --- a/assembler/gram.y +++ b/assembler/gram.y @@ -351,7 +351,7 @@ static bool validate_src_reg(struct

Re: [Intel-gfx] [PATCH i-g-t 3/3] tests/gem_seqno_wrap: fix over allocation of buffers

> [PATCH i-g-t 3/3] tests/gem_seqno_wrap: fix over allocation of buffers For clarity, this should probably be "fix over allocation of arrays", since the arrays were being allocated as an array of buffers instead of an array of pointers to buffers. Regards, Thomas

[Intel-gfx] [PATCH i-g-t] testdisplay: Allow getopt to print error messages

By not assigning opterr, getopt will print its own error message that includes information about whether an option is unknown or just requires an additional argument. Signed-off-by: Thomas Wood --- tests/testdisplay.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/tests/testdisplay.c b

[Intel-gfx] [PATCH] drm: add support for additional stereo 3D modes

Parse the 3D_Structure_ALL and 3D_MASK fields of the HDMI Vendor Specific Data Block to expose more stereo 3D modes. Signed-off-by: Thomas Wood --- drivers/gpu/drm/drm_edid.c | 93 ++ 1 file changed, 85 insertions(+), 8 deletions(-) diff --git a

[Intel-gfx] [PATCH] drm: add support for additional stereo 3D modes

On 11 October 2013 12:12, Ville Syrjälä wrote: > On Thu, Oct 10, 2013 at 02:19:15PM +0100, Thomas Wood wrote: >> Parse the 3D_Structure_ALL and 3D_MASK fields of the HDMI Vendor >> Specific Data Block to expose more stereo 3D modes. >> >> Signed-off-by: Thomas Wood

[Intel-gfx] [PATCH v2] drm: add support for additional stereo 3D modes

Parse the 3D_Structure_ALL and 3D_MASK fields of the HDMI Vendor Specific Data Block to expose more stereo 3D modes. Signed-off-by: Thomas Wood --- drivers/gpu/drm/drm_edid.c | 105 + 1 file changed, 96 insertions(+), 9 deletions(-) diff --git a

[Intel-gfx] [PATCH v3] drm: add support for additional stereo 3D modes

(Ville Syrjälä) Check that the value of HDMI_3D_LEN is large enough to include 3D_Structure_ALL and 3D_MASK, if they are present. (Ville Syrjälä) v3: Increment offset before the length checks. (Ville Syrjälä) Signed-off-by: Thomas Wood --- drivers/gpu/drm/drm_edid.c

Re: [Intel-gfx] [PATCH i-g-t 2/2] tests/pm_sseu: Create new test pm_sseu

On 10 March 2015 at 21:17, wrote: > From: Jeff McGee > > New test pm_sseu is intended for any subtest related to the > slice/subslice/EU power gating feature. The sole initial subtest, > 'full-enable', confirms that the slice/subslice/EU state is at > full enablement when the render engine is ac

[Intel-gfx] [PATCH i-g-t] lib: move igt_interactive_debug into igt_core.c

igt_interactive_debug should be defined in igt_core.c, rather than the header, to avoid it being defined more than once. Reported-by: Damien Lespiau Signed-off-by: Thomas Wood --- lib/igt_core.c | 1 + lib/igt_core.h | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/lib

[Intel-gfx] [ANNOUNCE] intel-gpu-tools 1.10

tions. - New CRITICAL log level for really serious stuff (Thomas Wood). - Interactive test mode can now be enabled by the shared cmdline option --interactive-debug=$var (Rodrigo Vivi). - Improved logging to kmsg to better line up test runs with kernel messages (Chris Wilson). - Record all log l

[Intel-gfx] [PATCH i-g-t] tests: create a single combined test list

All tests now respond in a consistent way such that separate lists for tests with and without subtests are no longer necessary. Signed-off-by: Thomas Wood --- tests/Makefile.am | 23 --- 1 file changed, 4 insertions(+), 19 deletions(-) diff --git a/tests/Makefile.am b/tests

[Intel-gfx] [PATCH i-g-t] lib: print a stack trace when a test assertion fails

Add an optional dependency on libunwind to print stack traces when a test assertion fails. Signed-off-by: Thomas Wood --- benchmarks/Makefile.am | 4 ++-- configure.ac | 10 ++ debugger/Makefile.am | 3 ++- demos/Makefile.am | 4 ++-- lib/Makefile.am| 5

Re: [Intel-gfx] [PATCH 1/2] i-g-t: Adding plane scaling test case

On 21 March 2015 at 00:11, Chandra Konduru wrote: > From: chandra konduru > > This patch is adding i-g-t plane scaling test case to test couple basic > display plane scaling usages. Additional test scenarios can be added later. Unfortunately both patches in this series don't apply cleanly to cur

Re: [Intel-gfx] [PATCH i-g-t] tests: install test programs to libexec

On 25 March 2015 at 10:43, Joonas Lahtinen wrote: > Install the test programs by default so that they can be packaged. Some tests require extra files such as images that will also need to be installed and have an appropriate path used in the test. The IGT_DATADIR defined in lib/Makefile.am and te

[Intel-gfx] [PATCH i-g-t] Add default debug flags for tests

Include debugging symbols in tests by default to improve stack traces and also set the compiler optimisation level to improve the debugging experience. Signed-off-by: Thomas Wood --- configure.ac | 14 m4/as-compiler-flag.m4 | 62

[Intel-gfx] [PATCH i-g-t] docs: limit the number of subtests listed

Avoid producing longs lists of subtests in the documentation and instead provide instructions on how to obtain the full list. Signed-off-by: Thomas Wood --- docs/reference/intel-gpu-tools/Makefile.am | 22 +++--- 1 file changed, 15 insertions(+), 7 deletions(-) diff --git a

[Intel-gfx] [PATCH i-g-t] igt.cocci: check the return values of various functions

Add rules to fix unused-result warnings when compiling with _FORTIFY_SOURCE defined and apply them to the library and tests. Signed-off-by: Thomas Wood --- lib/igt.cocci | 28 lib/igt_core.c| 20 lib/igt_debugfs.c | 6

Re: [Intel-gfx] [PATCH i-g-t 1/2 v2] lib: Add media spin

On 25 March 2015 at 02:50, He, Shuang wrote: > (He Shuang on behalf of Liu Lei) > Tested-by: Lei,Liu lei.a@intel.com Thanks, both patches in this series are now merged. > > I-G-T test result: > ./pm_sseu > IGT-Version: 1.9-g07be8fe (x86_64) (Linux: > 4.0.0-rc3_drm-intel-nightly_c09a3b_2015

Re: [Intel-gfx] [PATCH i-g-t v2] tests: install test programs to libexec

On 26 March 2015 at 16:05, Joonas Lahtinen wrote: > Install the test programs by default so that they can be packaged. Could you also explain why the tests should be packaged? > > v2: > - Install more tests including scripts and their data > > Signed-off-by: Joonas Lahtinen > --- > tests/Make

Re: [Intel-gfx] [PATCH igt 1/2] lib/kms: Add a way to override an output's mode

On 11 March 2015 at 11:33, Ander Conselvan de Oliveira wrote: > So that it is possible to use a custom mode with the simplified mode set API. > --- > lib/igt_kms.c | 9 + > lib/igt_kms.h | 4 > 2 files changed, 13 insertions(+) > > diff --git a/lib/igt_kms.c b/lib/igt_kms.c > index 2

Re: [Intel-gfx] [PATCH igt 2/2] tests: Add test for pipe B and C interactions in IVB

On 11 March 2015 at 11:33, Ander Conselvan de Oliveira wrote: > The tests exercise different combinations of enabling pipe B with modes > that require more than 2 lanes and then enabling pipe C. > > v2: Added a couple more tests for different pipe transitions. (Ander) > Use custom modes to mak

[Intel-gfx] [PATCH i-g-t 2/2] lib: add debug flags

Signed-off-by: Thomas Wood --- lib/Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/Makefile.am b/lib/Makefile.am index 4db90d4..870b1a1 100644 --- a/lib/Makefile.am +++ b/lib/Makefile.am @@ -9,7 +9,7 @@ noinst_LTLIBRARIES = libintel_tools.la noinst_HEADERS

[Intel-gfx] [PATCH i-g-t 1/2] gem_exec_blt: fix subtest enumeration

Wrap the sysfs_read and sysfs_write calls in an igt_fixture block so they are not executed during subtest enumeration. Cc: Chris Wilson Signed-off-by: Thomas Wood --- tests/gem_exec_blt.c | 16 ++-- 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/tests/gem_exec_blt.c

Re: [Intel-gfx] [PATCH i-g-t] tests: Add kms_legacy_colorkey

On 27 March 2015 at 19:18, wrote: > From: Ville Syrjälä > > Add a quick test to make sure the legacy set colorkey ioctl only works > for sprite planes. > > Signed-off-by: Ville Syrjälä > --- > lib/igt_kms.h | 4 +++ > tests/.gitignore| 1 + > tests/Makefile.sources

Re: [Intel-gfx] [PATCH i-g-t 2/2] tests: Add test for pipe B and C interactions in IVB

On 30 March 2015 at 08:03, Ander Conselvan de Oliveira wrote: > The tests exercise different combinations of enabling pipe B with modes > that require more than 2 lanes and then enabling pipe C. > > v2: Added a couple more tests for different pipe transitions. (Ander) > Use custom modes to mak

[Intel-gfx] [PATCH i-g-t 2/2] tests: apply igt.cocci

Signed-off-by: Thomas Wood --- tests/core_getclient.c | 2 +- tests/core_getstats.c | 2 +- tests/drm_import_export.c | 2 -- tests/eviction_common.c| 7 --- tests/gem_close_race.c | 2 +- tests/gem_cs_prefetch.c| 2

[Intel-gfx] [PATCH i-g-t 1/2] lib: add some defines to help spatch parsing

Add simple definitions for various macros to help spatch parse the special igt control flow blocks and other macros correctly. Signed-off-by: Thomas Wood --- lib/igt-spatch.h | 41 + lib/igt.cocci| 6 +++--- 2 files changed, 44 insertions(+), 3

Re: [Intel-gfx] [PATCH v4] tests: Add test for pipe B and C interactions in IVB

On 30 March 2015 at 12:38, Ander Conselvan de Oliveira wrote: > The tests exercise different combinations of enabling pipe B with modes > that require more than 2 lanes and then enabling pipe C. > > v2: Added a couple more tests for different pipe transitions. (Ander) > Use custom modes to mak

Re: [Intel-gfx] [PATCH i-g-t v4] tests: install test programs to libexec

about why we do this. > (Chris Wilson & Thomas Wood) > - Change libexec into pkglibexec to comply to standard > (Thomas Wood) > - Do not install $(common_files). (Thomas Wood) > - Make it really obvious the installed files are tests by using > tests directory name t

Re: [Intel-gfx] [RFC i-g-t v5] tests/gem_exec_pad_to_size: Test object padding at execbuf

On 2 April 2015 at 13:54, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > This tests the new EXEC_OBJECT_PAD_TO_SIZE exec_object2 flag. Just two things from an i-g-t perspective: the new binary needs adding to .gitignore and it would be good to include a short description of the test using the

Re: [Intel-gfx] [PATCH i-g-t v5] tests: install test programs to libexec

d files. > > v2: > - Install more tests including scripts and their data > > v3: > - Add clarification to commit message about why we do this. > (Chris Wilson & Thomas Wood) > - Change libexec into pkglibexec to comply to standard > (Thomas Wood) > - Do not in

[Intel-gfx] [PATCH i-g-t] tests/kms_fbc_crc: fix fread() return value assertion

=89833 Signed-off-by: Thomas Wood --- tests/kms_fbc_crc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/kms_fbc_crc.c b/tests/kms_fbc_crc.c index 10e1ca4..ccdec33 100644 --- a/tests/kms_fbc_crc.c +++ b/tests/kms_fbc_crc.c @@ -510,7 +510,7 @@ igt_main

[Intel-gfx] [PATCH i-g-t 2/2] tests: use standard install prefix for programs, scripts and data

Use the pkglibexec and pkgdata prefixes rather than setting bindir and datadir. This also removes the extra 'tests' directory from within the package libexec and data directories. Cc: Joonas Lahtinen Signed-off-by: Thomas Wood --- tests/Makefile.am | 15 +++-

[Intel-gfx] [PATCH i-g-t 1/2] tests: ensure scripts and data are included in the distribution

Prefix the test scripts and data variables with dist_ to ensure they are included in the distribution. Cc: Joonas Lahtinen Signed-off-by: Thomas Wood --- tests/Makefile.am | 4 ++-- tests/Makefile.sources | 6 -- 2 files changed, 2 insertions(+), 8 deletions(-) diff --git a/tests

[Intel-gfx] [PATCH i-g-t v2 1/2] tests: create a single combined test list

All tests now respond in a consistent way such that separate lists for tests with and without subtests are no longer necessary. v2: fix other references to the test list Signed-off-by: Thomas Wood --- docs/reference/intel-gpu-tools/Makefile.am | 2 +- lib/tests/igt_command_line.sh

[Intel-gfx] [PATCH i-g-t 2/2] tests: install the test list

Cc: Joonas Lahtinen Signed-off-by: Thomas Wood --- tests/Makefile.am | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/Makefile.am b/tests/Makefile.am index 11f7f96..d5fb4fd 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -5,8 +5,6 @@ if HAVE_NOUVEAU endif

Re: [Intel-gfx] [PATCH i-g-t 2/2] tests: use standard install prefix for programs, scripts and data

On 9 April 2015 at 07:45, Joonas Lahtinen wrote: > On ke, 2015-04-08 at 14:56 +0100, Thomas Wood wrote: >> Use the pkglibexec and pkgdata prefixes rather than setting bindir and >> datadir. This also removes the extra 'tests' directory from within the >> packa

[Intel-gfx] [PATCH i-g-t 2/2] lib: use test failure status for igt_set_timeout

Use a failure status code for timeout to avoid confusion between tests that take too long to execute versus a failure due to an operation taking longer than expected. Signed-off-by: Thomas Wood --- lib/igt_core.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lib

[Intel-gfx] [PATCH i-g-t 1/2] lib: add a define for test failure exit status

Signed-off-by: Thomas Wood --- lib/igt.cocci | 2 +- lib/igt_core.c | 6 +++--- lib/igt_core.h | 18 -- lib/intel_batchbuffer.c| 2 +- tests/gem_ring_sync_copy.c | 2 +- tests/kms_sink_crc_basic.c | 2 +- 6 files changed, 19

[Intel-gfx] [PATCH i-g-t 2/2] lib: load images from the data directory in igt_paint_image

Update igt_paint_image so that it can read images from the package data directory. Signed-off-by: Thomas Wood --- lib/Android.mk | 2 +- lib/Makefile.am | 3 ++- lib/igt_fb.c| 23 +-- tests/testdisplay.c | 35 ++- 4 files

[Intel-gfx] [PATCH i-g-t 1/2] lib: use a critical warning when unable to open a data file

Signed-off-by: Thomas Wood --- lib/igt_core.c | 5 + tests/testdisplay.c | 5 + 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/lib/igt_core.c b/lib/igt_core.c index daef8c6..700604f 100644 --- a/lib/igt_core.c +++ b/lib/igt_core.c @@ -1751,5 +1751,10 @@ FILE

Re: [Intel-gfx] [PATCH i-g-t v5] tests/gem_mmap_gtt: add huge BO test

On 14 April 2015 at 12:14, Joonas Lahtinen wrote: > Add a straightforward test that allocates a BO that is bigger than > (by 1 page currently) the mappable aperture, tests mmap access to it > by CPU directly and through GTT in sequence. > > Currently it is expected for the GTT access to gracefully

Re: [Intel-gfx] [PATCH v3] i-g-t: Adding test case to test background color.

On 30 March 2015 at 21:44, Chandra Konduru wrote: > From: chandra konduru > > Adding i-g-t test case to test display crtc background color. > > v2: > - Added IGT_TEST_DESCRIPTION() (Thomas Wood) > - Added to .gitignore (Thomas Wood) > - Added additional details to func

[Intel-gfx] [PATCH i-g-t 5/7] configure: include the skylake quick_dump files in EXTRA_DIST

Signed-off-by: Thomas Wood --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index 9cdd202..03e856d 100644 --- a/configure.ac +++ b/configure.ac @@ -201,7 +201,7 @@ fi AM_CONDITIONAL(BUILD_TESTS, [test "x$BUILD_TESTS&qu

[Intel-gfx] [PATCH i-g-t 3/4] Build the docs directory last

Ensure that other components are built before generating the documentation. Signed-off-by: Thomas Wood --- Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile.am b/Makefile.am index 1dacb17..0c799d2 100644 --- a/Makefile.am +++ b/Makefile.am @@ -21,7 +21,7

[Intel-gfx] [PATCH i-g-t 1/4] lib: add the ability to include a description with a test

Signed-off-by: Thomas Wood --- lib/igt_core.c | 19 --- lib/igt_core.h | 3 +++ 2 files changed, 19 insertions(+), 3 deletions(-) diff --git a/lib/igt_core.c b/lib/igt_core.c index e3d5fb0..3861121 100644 --- a/lib/igt_core.c +++ b/lib/igt_core.c @@ -223,6 +223,7 @@ bool

[Intel-gfx] [PATCH i-g-t 2/4] docs: add some test descriptions

Signed-off-by: Thomas Wood --- tests/core_getclient.c | 5 ++--- tests/core_getstats.c | 3 +++ tests/core_getversion.c | 6 +++--- tests/kms_3d.c | 2 ++ tests/kms_cursor_crc.c | 8 tests/kms_fbc_crc.c | 5 + tests/kms_fence_pin_leak.c

[Intel-gfx] [PATCH i-g-t 4/4] doc: include descriptions for the test programs

Signed-off-by: Thomas Wood --- docs/reference/intel-gpu-tools/Makefile.am | 20 ++- .../intel-gpu-tools/igt_test_programs.xml.header | 65 ++ .../intel-gpu-tools/intel-gpu-tools-docs.xml | 1 + 3 files changed, 84 insertions(+), 2 deletions(-) create

[Intel-gfx] [PATCH i-g-t 1/2] lib/igt_core.h: fix igt_skip_on_f requirement message

Signed-off-by: Thomas Wood --- lib/igt_core.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/igt_core.h b/lib/igt_core.h index b8f6702..5318c5e 100644 --- a/lib/igt_core.h +++ b/lib/igt_core.h @@ -397,7 +397,7 @@ void igt_exit(void) __attribute__((noreturn

[Intel-gfx] [PATCH i-g-t 2/2] lib/igt_core.h: add debug messages for test requirements

Signed-off-by: Thomas Wood --- lib/igt_core.h | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/lib/igt_core.h b/lib/igt_core.h index 5318c5e..f7a92ce 100644 --- a/lib/igt_core.h +++ b/lib/igt_core.h @@ -199,7 +199,7 @@ void __igt_skip_check(const char *file, const int

[Intel-gfx] [PATCH i-g-t] lib: ensure the library is build before the tests

This fixes the build problems introduced by commit 685e577 (Move library selftests to lib/tests). Cc: Daniel Vetter Signed-off-by: Thomas Wood --- lib/Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/Makefile.am b/lib/Makefile.am index 6b1e984..ab82302 100644

[Intel-gfx] [PATCH i-g-t 1/2] build: fix distcheck

Fix distcheck issues introduced by commit 685e577 (Move library selftests to lib/tests). Cc: Daniel Vetter Signed-off-by: Thomas Wood --- lib/tests/Makefile.am | 2 +- tests/Makefile.sources | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/lib/tests/Makefile.am b/lib/tests

[Intel-gfx] [PATCH i-g-t 2/2] lib/tests: use the "check_" prefix for tests

The "check_" prefix ensures the test programs are not installed and are only built when "make check" is run. Signed-off-by: Thomas Wood --- lib/tests/Makefile.am | 5 + lib/tests/Makefile.sources | 12 2 files changed, 5 insertions(+), 12 deletions(

[Intel-gfx] [PATCH i-g-t v2 0/6] Test Descriptions

The following patch series fixes various issues with the previous series and also adds support for the "--help-description" option to testdisplay and the shell script based tests. Thomas Wood (6): lib: add the ability to include a description with a test docs: add some test de

[Intel-gfx] [PATCH i-g-t v2 3/6] Build the docs directory last

Ensure that other components are built before generating the documentation. v2: build the docs directory after any optional directories Signed-off-by: Thomas Wood --- Makefile.am | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/Makefile.am b/Makefile.am index 1dacb17

[Intel-gfx] [PATCH i-g-t v2 2/6] docs: add some test descriptions

Signed-off-by: Thomas Wood --- tests/core_getclient.c | 5 ++--- tests/core_getstats.c | 3 +++ tests/core_getversion.c | 6 +++--- tests/kms_3d.c | 2 ++ tests/kms_cursor_crc.c | 8 tests/kms_fbc_crc.c | 5 + tests/kms_fence_pin_leak.c

[Intel-gfx] [PATCH i-g-t v2 4/6] docs: include descriptions for the test programs

v2: fix various distcheck issues Signed-off-by: Thomas Wood --- docs/reference/intel-gpu-tools/.gitignore | 1 + docs/reference/intel-gpu-tools/Makefile.am | 27 +++-- .../intel-gpu-tools/igt_test_programs.xml.header | 65 ++ .../intel-gpu-tools/intel

[Intel-gfx] [PATCH i-g-t v2 5/6] testdisplay: add a test description

Signed-off-by: Thomas Wood --- tests/testdisplay.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/tests/testdisplay.c b/tests/testdisplay.c index 09e07f0..d00d64a 100644 --- a/tests/testdisplay.c +++ b/tests/testdisplay.c @@ -72,6 +72,7 @@ #include #define SUBTEST_OPTS 1 +#define

[Intel-gfx] [PATCH i-g-t v2 1/6] lib: add the ability to include a description with a test

The IGT_TEST_DESCRIPTION macro can be used to define a description for a test. v2: Remove semicolon from end of macro (Damien Lespiau) Add API documentation for the macro. Signed-off-by: Thomas Wood --- lib/igt_core.c | 19 --- lib/igt_core.h | 12 2 files

[Intel-gfx] [PATCH i-g-t v2 6/6] tests/drm_lib.sh: add a "--help-description" option

Signed-off-by: Thomas Wood --- tests/drm_lib.sh | 5 + 1 file changed, 5 insertions(+) diff --git a/tests/drm_lib.sh b/tests/drm_lib.sh index 6a8a310..c50664c 100755 --- a/tests/drm_lib.sh +++ b/tests/drm_lib.sh @@ -12,11 +12,16 @@ for arg in $@ ; do --debug

[Intel-gfx] [PATCH i-g-t 3/5] testdisplay: ensure invalid long option exit status is non-zero

The optopt variable is not set if an invalid long option is used, so check the current option character instead. Signed-off-by: Thomas Wood --- tests/testdisplay.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/tests/testdisplay.c b/tests/testdisplay.c index

[Intel-gfx] [PATCH i-g-t 4/5] testdiplay: add a "--help" option

Signed-off-by: Thomas Wood --- tests/testdisplay.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/testdisplay.c b/tests/testdisplay.c index 8c6bc62..b7e1541 100644 --- a/tests/testdisplay.c +++ b/tests/testdisplay.c @@ -642,6 +642,7 @@ int main(int argc, char **argv) struct

[Intel-gfx] [PATCH i-g-t 2/5] lib/tests: don't use hard error status to indicate test failure

Signed-off-by: Thomas Wood --- lib/tests/igt_command_line.sh | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/tests/igt_command_line.sh b/lib/tests/igt_command_line.sh index 7e6ca67..5cf2584 100755 --- a/lib/tests/igt_command_line.sh +++ b/lib/tests

[Intel-gfx] [PATCH i-g-t 5/5] configure: fix issues when running outside the source tree

Signed-off-by: Thomas Wood --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index d3faa19..a2569b8 100644 --- a/configure.ac +++ b/configure.ac @@ -203,7 +203,7 @@ AC_DEFINE_UNQUOTED(TARGET_CPU_PLATFORM, ["$host_cpu"]

[Intel-gfx] [PATCH i-g-t 1/5] lib/tests: fix tests and test list location

The igt_command_line.sh script was moved by commit 685e577 (Move library selftests to lib/tests), but the location of the tests and the test lists was not updated. Cc: Daniel Vetter Signed-off-by: Thomas Wood --- lib/tests/Makefile.am | 4 lib/tests/igt_command_line.sh | 18

Re: [Intel-gfx] [PATCH i-g-t 1/4] lib: add the ability to include a description with a test

On 3 November 2014 12:26, Daniel Vetter wrote: > On Tue, Oct 28, 2014 at 03:10:25PM +, Damien Lespiau wrote: >> On Tue, Oct 28, 2014 at 03:03:53PM +0000, Thomas Wood wrote: >> > +extern const char* __igt_test_description __attribute__((weak)); >> > +#define IGT_TES

Re: [Intel-gfx] [PATCH i-g-t 2/5] lib/tests: don't use hard error status to indicate test failure

On 3 November 2014 15:02, Daniel Vetter wrote: > On Mon, Nov 03, 2014 at 11:31:02AM +0000, Thomas Wood wrote: >> Signed-off-by: Thomas Wood >> --- >> lib/tests/igt_command_line.sh | 8 >> 1 file changed, 4 insertions(+), 4 deletions(-) >> >> diff

[Intel-gfx] [PATCH i-g-t] tests: use igt_debugfs where possible

Signed-off-by: Thomas Wood --- lib/igt_kms.c | 39 +-- tests/gem_flink_race.c | 9 ++--- tests/kms_flip.c | 11 +-- tests/kms_sink_crc_basic.c | 4 +++- tests/pm_rpm.c | 3 +-- tests/prime_self_import.c

[Intel-gfx] [PATCH i-g-t] tools/quick_dump: don't include generated sources in the distribution

This also ensures that "make dist" works even if SWIG is not available. BUILT_SOURCES is not required because the files are already explicit dependencies of other rules. Signed-off-by: Thomas Wood --- tools/quick_dump/Makefile.am | 7 +++ 1 file changed, 3 insertions(+), 4

[Intel-gfx] [PATCH i-g-t v2] tools/quick_dump: don't include generated sources in the distribution

This also ensures that "make dist" works even if SWIG is not available. BUILT_SOURCES is not required because the files are already explicit dependencies of other rules. v2: make sure SWIG is not invoked with the incorrect output filename Signed-off-by: Thomas Wood --- tools/

[Intel-gfx] [PATCH i-g-t 2/2] configure: require automake 1.12

The check tests require AM_TESTS_ENVIRONMENT, which was added in automake 1.12. Signed-off-by: Thomas Wood --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index a2569b8..bb0b16d 100644 --- a/configure.ac +++ b/configure.ac

[Intel-gfx] [PATCH i-g-t 1/2] tests: ensure the script based tests are included in the distribution

TESTS_scripts was accidentally removed from EXTRA_DIST in commit 685e577 (Move library selftests to lib/tests). Cc: Daniel Vetter Signed-off-by: Thomas Wood --- tests/Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/Makefile.am b/tests/Makefile.am index

[Intel-gfx] [PATCH i-g-t 2/3] tests/kms_flip: add a timeout for the nonblocking-read test

kms_flip/nonblocking-read will block indefinitely if it fails, so introduce a timeout to indicate test failure. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=85718 Signed-off-by: Thomas Wood --- tests/kms_flip.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/kms_flip.c b

[Intel-gfx] [PATCH i-g-t 1/3] lib/tests: add a test for igt_set_timeout

Signed-off-by: Thomas Wood --- lib/tests/.gitignore | 1 + lib/tests/Makefile.sources | 2 ++ lib/tests/igt_timeout.c| 8 3 files changed, 11 insertions(+) create mode 100644 lib/tests/igt_timeout.c diff --git a/lib/tests/.gitignore b/lib/tests/.gitignore index caf5348

[Intel-gfx] [PATCH i-g-t 3/3] lib: only skip subsequent tests if a timeout occurs outside of a subtest

Make timeout behaviour more consistent with igt_fail, where subsequent subtests are only skipped if the failure occurs outside of a subtest. Signed-off-by: Thomas Wood --- lib/igt_core.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/lib/igt_core.c b/lib

[Intel-gfx] [PATCH i-g-t] configure: update bug reporting url

Signed-off-by: Thomas Wood --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index bb0b16d..f0d7917 100644 --- a/configure.ac +++ b/configure.ac @@ -23,7 +23,7 @@ AC_PREREQ([2.60]) AC_INIT([intel-gpu-tools], [1.8

[Intel-gfx] [PATCH i-g-t] lib: fix igt_reset_connectors

-off-by: Thomas Wood --- lib/igt_kms.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/igt_kms.c b/lib/igt_kms.c index 5edd5ec..cba0c27 100644 --- a/lib/igt_kms.c +++ b/lib/igt_kms.c @@ -1773,8 +1773,8 @@ void igt_reset_connectors(void) * functions that are not

[Intel-gfx] [PATCH i-g-t 1/3] lib: fix symbol names in documentation comments

Signed-off-by: Thomas Wood --- lib/drmtest.c | 2 +- lib/igt_core.h | 2 +- lib/intel_batchbuffer.c | 4 ++-- lib/ioctl_wrappers.c| 4 ++-- 4 files changed, 6 insertions(+), 6 deletions(-) diff --git a/lib/drmtest.c b/lib/drmtest.c index 3d828e1..813c315 100644 --- a/lib

[Intel-gfx] [PATCH i-g-t 3/3] lib: ensure subtests are not added to simple tests

Simple tests do not support subtests, so fail if igt_subtest is used in one. Signed-off-by: Thomas Wood --- lib/igt_core.c | 1 + lib/tests/.gitignore | 1 + lib/tests/Makefile.sources | 2 ++ lib/tests/igt_simple_test_subtests.c | 31

[Intel-gfx] [PATCH i-g-t 2/3] tests: use subtests in gem_tiled_swapping

Signed-off-by: Thomas Wood --- tests/gem_tiled_swapping.c | 64 -- 1 file changed, 34 insertions(+), 30 deletions(-) diff --git a/tests/gem_tiled_swapping.c b/tests/gem_tiled_swapping.c index 69d1cfa..11bb245 100644 --- a/tests/gem_tiled_swapping.c

[Intel-gfx] [PATCH i-g-t 3/6] docs: add exit status documentation

Signed-off-by: Thomas Wood --- .../intel-gpu-tools/igt_test_programs.xml | 39 ++ 1 file changed, 39 insertions(+) diff --git a/docs/reference/intel-gpu-tools/igt_test_programs.xml b/docs/reference/intel-gpu-tools/igt_test_programs.xml index 2969894..07285fe 100644

[Intel-gfx] [PATCH i-g-t 1/6] docs: split the test program documentation into sections

Signed-off-by: Thomas Wood --- docs/reference/intel-gpu-tools/.gitignore | 2 +- docs/reference/intel-gpu-tools/Makefile.am | 77 +-- .../intel-gpu-tools/igt_test_programs.xml | 151 + .../intel-gpu-tools/igt_test_programs.xml.header

[Intel-gfx] [PATCH i-g-t 4/6] docs: add a glossary of test name terms

Add a glossary of test name terms based on the details in tests/NAMING-CONVENTION. Signed-off-by: Thomas Wood --- docs/reference/intel-gpu-tools/Makefile.am | 10 +- .../intel-gpu-tools/igt_test_programs.xml | 106 + 2 files changed, 114 insertions(+), 2

[Intel-gfx] [PATCH i-g-t 2/6] docs: add subtest lists to test descriptions

Signed-off-by: Thomas Wood --- docs/reference/intel-gpu-tools/Makefile.am | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/docs/reference/intel-gpu-tools/Makefile.am b/docs/reference/intel-gpu-tools/Makefile.am index cd9c771..d7ef4df 100644 --- a/docs/reference

[Intel-gfx] [PATCH i-g-t 5/6] docs: treat the test description as cdata

Enclose the test description in cdata tags since the test descriptions come from the tests themselves and may not be escaped for use in xml. --- docs/reference/intel-gpu-tools/Makefile.am | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/reference/intel-gpu-tools/Makefil

[Intel-gfx] [PATCH i-g-t 6/6] tests: add more test descriptions

Add more test descriptions based on exiting comments. Signed-off-by: Thomas Wood --- tests/drm_vma_limiter.c| 2 ++ tests/gem_bad_length.c | 4 +++- tests/gem_bad_reloc.c | 3 +++ tests/gem_caching.c| 3 +++ tests

[Intel-gfx] [PATCH i-g-t 3/4] tests: use base edid

Use the base edid for testing, which includes several different display modes. Signed-off-by: Thomas Wood --- tests/kms_3d.c | 4 ++-- tests/kms_force_connector.c | 31 --- 2 files changed, 14 insertions(+), 21 deletions(-) diff --git a/tests/kms_3d.c

[Intel-gfx] [PATCH i-g-t 2/4] tests/kms_force_connect: split into subtests

Signed-off-by: Thomas Wood --- tests/kms_force_connector.c | 167 +++- 1 file changed, 89 insertions(+), 78 deletions(-) diff --git a/tests/kms_force_connector.c b/tests/kms_force_connector.c index 34c33b0..d446eaa 100644 --- a/tests/kms_force_connector.c

[Intel-gfx] [PATCH i-g-t 1/4] igt_kms: add a base edid

Add a basic edid block that includes several different display modes. Signed-off-by: Thomas Wood --- lib/igt_kms.c | 110 ++ lib/igt_kms.h | 3 ++ 2 files changed, 113 insertions(+) diff --git a/lib/igt_kms.c b/lib/igt_kms.c index

[Intel-gfx] [PATCH i-g-t 4/4] lib: remove igt_edid.h

This has been replaced by igt_kms_get_base_edid(). Signed-off-by: Thomas Wood --- .../intel-gpu-tools/intel-gpu-tools-docs.xml | 1 - lib/Makefile.sources | 1 - lib/igt_edid.h | 125 - lib/igt_kms.c

[Intel-gfx] [PATCH i-g-t 2/5] tests/gem_tiled_swapping: use igt_info logging wrapper

Signed-off-by: Thomas Wood --- tests/gem_tiled_swapping.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/tests/gem_tiled_swapping.c b/tests/gem_tiled_swapping.c index 11bb245..7637cf3 100644 --- a/tests/gem_tiled_swapping.c +++ b/tests/gem_tiled_swapping.c

<    1   2   3   4   5   >