Re: [Intel-gfx] [PATCH] tests/kms_color:Color IGT

2015-11-24 Thread Thomas Wood
Please make sure your patch is tagged with "i-g-t" so it is correctly identified by patchwork, as described in: http://lists.freedesktop.org/archives/intel-gfx/2015-November/079712.html It would also be helpful if the subject line briefly mentions what the patch does. On 20 November 2015 at 10:

Re: [Intel-gfx] [PATCH i-g-t] scripts: Add feature list file for piglit 'summary feature'

2015-11-26 Thread Thomas Wood
On 25 November 2015 at 12:12, Gabriel Feceoru wrote: > This is a placeholder for the feature list file. Its content is just > an example. It would be useful if the example applied directly to intel-gpu-tools tests. Perhaps just a single feature to start with? Since this isn't a script as such, w

Re: [Intel-gfx] [PATCH i-g-t] scripts: Add support to retest tests wich changed results

2015-11-27 Thread Thomas Wood
On 27 November 2015 at 12:40, Gabriel Feceoru wrote: > This script takes multiple test results and prints the diffs, useful > for detecting noise in subsequent executions. > It gives the option to re-run these tests. This feature might be useful in Piglit itself. It sounds similar to the ideas me

[Intel-gfx] [PATCH i-g-t] tests/gem_request_retire: add test description

2015-11-30 Thread Thomas Wood
Cc: Tvrtko Ursulin Signed-off-by: Thomas Wood --- tests/gem_request_retire.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tests/gem_request_retire.c b/tests/gem_request_retire.c index 0c7c45e..545a245 100644 --- a/tests/gem_request_retire.c +++ b/tests/gem_request_retire.c @@ -49,6

Re: [Intel-gfx] [PATCH i-g-t 1/3] tests/kms_force_connector: Fixes

2015-12-01 Thread Thomas Wood
On 1 December 2015 at 08:08, Daniel Vetter wrote: > Two things: > - Somehow the kernel's mode list changed with our EDID. No idea > whether that's the right thing here since I'm not really an EDID > expert. But then again the testcase wants to check that the > injection works, not validate t

Re: [Intel-gfx] [PATCH i-g-t 3/3] tests/kms_force_connector: Include in BAT set

2015-12-01 Thread Thomas Wood
On 1 December 2015 at 10:24, Daniel Vetter wrote: > Forcing connector state is a basic piece of our test infrastructure > that we use in all the kms_ tests. It allows us to run tests even if > no outputs are connected. > > They're also really fast, so perfect candidates for inclusion into the > BA

[Intel-gfx] [PATCH i-g-t 1/3] lib: add missing documentation for drm open functions

2015-12-01 Thread Thomas Wood
Signed-off-by: Thomas Wood --- lib/drmtest.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/lib/drmtest.c b/lib/drmtest.c index 16a3638..2896af0 100644 --- a/lib/drmtest.c +++ b/lib/drmtest.c @@ -225,11 +225,10 @@ int drm_get_card(void) /** * __drm_open_driver

[Intel-gfx] [PATCH i-g-t 2/3] lib: document intel_pipe_crc_source enum values

2015-12-01 Thread Thomas Wood
Signed-off-by: Thomas Wood --- lib/igt_debugfs.h | 11 +++ 1 file changed, 11 insertions(+) diff --git a/lib/igt_debugfs.h b/lib/igt_debugfs.h index ee9ff40..3d5a811 100644 --- a/lib/igt_debugfs.h +++ b/lib/igt_debugfs.h @@ -77,6 +77,17 @@ typedef struct

[Intel-gfx] [PATCH i-g-t 3/3] docs: exclude gpgpu_fill.h

2015-12-01 Thread Thomas Wood
gpgpu_fill.h is only used internally by the library. Signed-off-by: Thomas Wood --- docs/reference/intel-gpu-tools/Makefile.am | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/docs/reference/intel-gpu-tools/Makefile.am b/docs/reference/intel-gpu-tools/Makefile.am

[Intel-gfx] [PATCH i-g-t 2/2] tests/core_setmaster_vs_auth: add test description macro

2015-12-02 Thread Thomas Wood
Signed-off-by: Thomas Wood --- tests/core_setmaster_vs_auth.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tests/core_setmaster_vs_auth.c b/tests/core_setmaster_vs_auth.c index 44ec752..97add9c 100644 --- a/tests/core_setmaster_vs_auth.c +++ b/tests/core_setmaster_vs_auth.c @@ -45,6

[Intel-gfx] [PATCH i-g-t 1/2] tests/core_setmaster_vs_auth: use igt_simple_main

2015-12-02 Thread Thomas Wood
This test has no subtests, so should use igt_simple_main. Signed-off-by: Thomas Wood --- tests/core_setmaster_vs_auth.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/core_setmaster_vs_auth.c b/tests/core_setmaster_vs_auth.c index efb27b1..44ec752 100644 --- a/tests

[Intel-gfx] [ANNOUNCE] intel-gpu-tools 1.13

2015-12-02 Thread Thomas Wood
) - New test: core_setmaster_vs_auth checks that drop/setMaster correctly transfer master state (Thomas Hellstrom/Daniel Vetter) - Wildcard characters are now accepted when using the --run-subtest command line option to specify multiple subtests to run. (Thomas Wood) - Add support for Broxton

Re: [Intel-gfx] [PATCH i-g-t 2/3] tests/drm_lib.sh: Skip when i915 debugfs wasn't found

2015-12-03 Thread Thomas Wood
On 3 December 2015 at 06:45, Daniel Vetter wrote: > Instead of failing. We might want to move this into i915 tests > eventually, but this is good for now. > > Signed-off-by: Daniel Vetter > --- > tests/drm_lib.sh | 7 ++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/test

Re: [Intel-gfx] [PATCH i-g-t 2/3] tests/drm_lib.sh: Skip when i915 debugfs wasn't found

2015-12-03 Thread Thomas Wood
On 3 December 2015 at 10:46, Morton, Derek J wrote: >> >> >>-Original Message- >>From: Intel-gfx [mailto:intel-gfx-boun...@lists.freedesktop.org] On Behalf Of >>Thomas Wood >>Sent: Thursday, December 3, 2015 10:08 AM >>To: Daniel Vetter >

[Intel-gfx] [PATCH i-g-t] tests: add exit value constants for shell script tests

2015-12-03 Thread Thomas Wood
Signed-off-by: Thomas Wood --- tests/check_drm_clients | 2 +- tests/debugfs_emon_crash | 2 +- tests/drm_lib.sh | 22 ++ tests/drv_debugfs_reader | 2 +- tests/drv_missed_irq_hang | 14 +++--- tests/drv_module_reload_basic | 8

[Intel-gfx] [PATCH i-g-t] tests: update .gitignore and add a Makefile rule to create it

2015-12-03 Thread Thomas Wood
Signed-off-by: Thomas Wood --- tests/.gitignore | 13 +++-- tests/Makefile.am | 4 2 files changed, 11 insertions(+), 6 deletions(-) diff --git a/tests/.gitignore b/tests/.gitignore index ba1becd..9dfc7f3 100644 --- a/tests/.gitignore +++ b/tests/.gitignore @@ -1,7 +1,6

Re: [Intel-gfx] [PATCH i-g-t] tests: add exit value constants for shell script tests

2015-12-03 Thread Thomas Wood
On 3 December 2015 at 12:17, Morton, Derek J wrote: > 1 comment / question inline, otherwise looks ok to me. > > //Derek > >> >> >>-Original Message- >>From: Intel-gfx [mailto:intel-gfx-boun...@lists.freedesktop.org] On Behalf Of >>Thomas Wood &

[Intel-gfx] [PATCH i-g-t v2] tests: update .gitignore and add a Makefile rule to create it

2015-12-07 Thread Thomas Wood
v2: generate the .gitignore file with the default target Signed-off-by: Thomas Wood --- tests/.gitignore | 13 +++-- tests/Makefile.am | 4 2 files changed, 11 insertions(+), 6 deletions(-) diff --git a/tests/.gitignore b/tests/.gitignore index 6377007..f127bfc 100644 --- a

Re: [Intel-gfx] [PATCH i-g-t 1/2] lib/kms: Turn the based_edid into a template

2015-12-07 Thread Thomas Wood
based_edid should be "base edid"? On 4 December 2015 at 14:08, wrote: > From: Ville Syrjälä > > Signed-off-by: Ville Syrjälä > --- > lib/Makefile.sources| 1 + > lib/igt_edid_template.h | 74 > lib/igt_kms.c | 90 > +++-

Re: [Intel-gfx] [PATCH i-g-t v2] tests: update .gitignore and add a Makefile rule to create it

2015-12-15 Thread Thomas Wood
gt;Cc: intel-gfx@lists.freedesktop.org >>Subject: Re: [Intel-gfx] [PATCH i-g-t v2] tests: update .gitignore and add a >>Makefile rule to create it >> >>On Mon, Dec 07, 2015 at 03:12:15PM +, Thomas Wood wrote: >>> v2: generate the .gitignore file with the defa

Re: [Intel-gfx] [PATCH i-g-t] lib/igt_pm: Lib for power management

2015-12-18 Thread Thomas Wood
On 15 December 2015 at 09:14, David Weinehall wrote: > Move power management related code to a separate library. > Initially this is done only for workarounds that apply to external > components. Modify the users of such workarounds accordingly. > This currently involves HD audio and SATA link po

Re: [Intel-gfx] [PATCH i-g-t 6/6] tests/kms_chv_cursor_fail: Add a test to exercise CHV pipe C cursor fail

2015-12-21 Thread Thomas Wood
On 18 December 2015 at 17:25, wrote: > From: Ville Syrjälä > > The test tries to anger CHV pipe C cursor by walking the edges of the > screen while moving the cursor across the screen edge. > > The actual hw issue only occurs on pipe C, and only on the left screen > edge. The testcase can walk a

Re: [Intel-gfx] [PATCH i-g-t 2/6] lib: Extract ssme common fb create+fill methods into helpers

2015-12-21 Thread Thomas Wood
On 18 December 2015 at 17:25, wrote: > From: Ville Syrjälä > > Several tests do one or more of the followin: > * igt_create_fb() + igt_paint_test_pattern() > * igt_create_color_fb() + igt_paint_test_pattern() > * igt_create_fb() + igt_paint_image() > > Extract them into new helpes: igt_create_pa

Re: [Intel-gfx] [PATCH i-g-t] core_prop_blob ioctl_wrappers: Fix new tests/benchmarks for android

2015-10-14 Thread Thomas Wood
On 13 October 2015 at 16:35, Daniel Vetter wrote: > On Tue, Oct 13, 2015 at 04:16:18PM +0100, Derek Morton wrote: >> Changes since #1b492e311 have broken the Android build. This patch >> fixes the build for Android. >> >> core_prop_blob was using ioctls not in the android kernel. Added a >> igt_re

Re: [Intel-gfx] [PATCH i-g-t v2] tests/core_prop_blob: Fix core_prop_blob for android

2015-10-15 Thread Thomas Wood
equire_propblob() to core_prop_blob.c (Daniel Vetter) > Moved gem_blt.c to a seperate patch (Thomas Wood) > > Signed-off-by: Derek Morton > --- > tests/core_prop_blob.c | 71 > -- > 1 file changed, 52 insertions(+), 19

Re: [Intel-gfx] [PATCH i-g-t] tests: Add gem_exec_nop_concurrent test

2015-10-16 Thread Thomas Wood
On 15 October 2015 at 09:05, Derek Morton wrote: > This test is based on gem_exec_nop but submits nop batch buffers concurrently > from different threads to check for ring hangs and other issues during > concurrent submissions. Is there any reason not to include this as extra subtests in gem_exec

Re: [Intel-gfx] [PATCH i-g-t 1/3] Rename gem_concurren_all over gem_concurrent_blit

2015-10-23 Thread Thomas Wood
gem_concurrent_all is misspelled in the subject. On 23 October 2015 at 12:42, David Weinehall wrote: > We'll both rename gem_concurrent_all over gem_concurrent_blit > and change gem_concurrent_blit in this changeset. To make > this easier to follow we first do the the rename. Please add a Signed

Re: [Intel-gfx] [PATCH i-g-t 2/3] Unify handling of slow/combinatorial tests

2015-10-23 Thread Thomas Wood
On 23 October 2015 at 12:42, David Weinehall wrote: > Some tests should not be run by default, due to their slow, > and sometimes superfluous, nature. > > We still want to be able to run these tests though in some cases. > Until now there's been no unified way of handling this. Remedy > this by in

Re: [Intel-gfx] [PATCH i-g-t 2/3] Unify handling of slow/combinatorial tests

2015-10-26 Thread Thomas Wood
On 26 October 2015 at 15:28, David Weinehall wrote: > On Fri, Oct 23, 2015 at 03:55:23PM +0100, Thomas Wood wrote: >> On 23 October 2015 at 12:42, David Weinehall >> wrote: >> > Some tests should not be run by default, due to their slow, >> > and sometimes superf

Re: [Intel-gfx] [PATCH i-g-t 2/3] Unify handling of slow/combinatorial tests

2015-10-28 Thread Thomas Wood
On 28 October 2015 at 11:29, David Weinehall wrote: > Some tests should not be run by default, due to their slow, > and sometimes superfluous, nature. > > We still want to be able to run these tests in some cases. > Until now there's been no unified way of handling this. Remedy > this by introduci

Re: [Intel-gfx] [PATCH] lib/igt_kms: Introduce get_first_connected_output to retrieve a valid output

2015-10-29 Thread Thomas Wood
On 29 October 2015 at 02:09, Vivek Kasireddy wrote: > In some cases, we just need one valid output to perform a test. > This macro can help in these situations by avoiding iterating > over all the outputs. > > Suggested-by: Matt Roper > CC: Tvrtko Ursulin > CC: Matt Roper > Signed-off-by: Vivek

[Intel-gfx] [PATCH i-g-t 1/8] kms_force_connector: use comparison macros to make debug output clearer

2015-11-02 Thread Thomas Wood
Signed-off-by: Thomas Wood --- tests/kms_force_connector.c | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/tests/kms_force_connector.c b/tests/kms_force_connector.c index 7485ca8..4ba1e0b 100644 --- a/tests/kms_force_connector.c +++ b/tests

[Intel-gfx] [PATCH i-g-t 4/8] tests: remove unnecessary igt_exit calls

2015-11-02 Thread Thomas Wood
Signed-off-by: Thomas Wood --- tests/gem_render_linear_blits.c | 2 -- tests/gem_render_tiled_blits.c | 2 -- tests/kms_3d.c | 2 -- tests/kms_force_connector.c | 2 -- 4 files changed, 8 deletions(-) diff --git a/tests/gem_render_linear_blits.c b/tests

[Intel-gfx] [PATCH i-g-t 8/8] tests/kms_fbc_crc: ensure context is initialized correctly

2015-11-02 Thread Thomas Wood
maybe-uninitialized] rendercopy(batch, context, ^ kms_fbc_crc.c:271:22: note: ‘context’ was declared here drm_intel_context *context = NULL; ^ Cc: Paulo Zanoni Signed-off-by: Thomas Wood --- tests/kms_fbc_crc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/

[Intel-gfx] [PATCH i-g-t 2/8] lib: highlight subtest results on terminals

2015-11-02 Thread Thomas Wood
Make subtest results easier to identify by making them bold when the output is a terminal. Signed-off-by: Thomas Wood --- lib/igt_core.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/lib/igt_core.c b/lib/igt_core.c index 59127ca..7123455 100644 --- a/lib

[Intel-gfx] [PATCH i-g-t 3/8] Add missing noreturn attribute to various functions

2015-11-02 Thread Thomas Wood
Signed-off-by: Thomas Wood --- debugger/eudb.c | 2 +- lib/igt_core.c | 2 +- tests/gem_madvise.c | 2 +- tests/pm_rpm.c | 2 +- tests/testdisplay.c | 2 +- tools/intel_display_poller.c | 2 +- tools/intel_gpu_frequency.c | 2 +- 7

[Intel-gfx] [PATCH i-g-t 5/8] tests: remove duplicate struct member initializers

2015-11-02 Thread Thomas Wood
Signed-off-by: Thomas Wood --- tests/kms_frontbuffer_tracking.c | 1 - tests/pm_lpsp.c | 1 - 2 files changed, 2 deletions(-) diff --git a/tests/kms_frontbuffer_tracking.c b/tests/kms_frontbuffer_tracking.c index 15707b9..13b91ad 100644 --- a/tests/kms_frontbuffer_tracking.c

[Intel-gfx] [PATCH i-g-t 7/8] lib: add PIPE_ANY to the pipe enum

2015-11-02 Thread Thomas Wood
This avoids compiler warnings about invalid enum values. Signed-off-by: Thomas Wood --- lib/igt_kms.h | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/lib/igt_kms.h b/lib/igt_kms.h index 09c08aa..965c47c 100644 --- a/lib/igt_kms.h +++ b/lib/igt_kms.h @@ -40,6 +40,7

[Intel-gfx] [PATCH i-g-t 6/8] Fix comparison of unsigned integers

2015-11-02 Thread Thomas Wood
Signed-off-by: Thomas Wood --- benchmarks/gem_exec_reloc.c | 2 -- overlay/gem-interrupts.c| 7 +-- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/benchmarks/gem_exec_reloc.c b/benchmarks/gem_exec_reloc.c index 5be482a..2ef6df5 100644 --- a/benchmarks/gem_exec_reloc.c

Re: [Intel-gfx] [PATCH] igt/kms_rotation_crc: Add a subtest to validate Y-tiled obj + Y fb modifier (v3)

2015-11-02 Thread Thomas Wood
On 27 October 2015 at 10:37, Tvrtko Ursulin wrote: > > On 23/10/15 12:35, Daniel Vetter wrote: >> >> On Fri, Oct 23, 2015 at 09:51:06AM +0100, Tvrtko Ursulin wrote: >>> >>> >>> Hi, >>> >>> On 23/10/15 02:34, Vivek Kasireddy wrote: The main goal of this subtest is to trigger the following

Re: [Intel-gfx] [PATCH i-g-t 1/8] kms_force_connector: use comparison macros to make debug output clearer

2015-11-02 Thread Thomas Wood
On 2 November 2015 at 11:48, Thomas Wood wrote: > Signed-off-by: Thomas Wood > --- > tests/kms_force_connector.c | 17 + > 1 file changed, 9 insertions(+), 8 deletions(-) > > diff --git a/tests/kms_force_connector.c b/tests/kms_force_connector.c > index 74

[Intel-gfx] [PATCH i-g-t 1/5] tests/kms_force_connector: free the display struct when no longer needed

2015-11-02 Thread Thomas Wood
Signed-off-by: Thomas Wood --- tests/kms_force_connector.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tests/kms_force_connector.c b/tests/kms_force_connector.c index 7485ca8..f48b187 100644 --- a/tests/kms_force_connector.c +++ b/tests/kms_force_connector.c @@ -36,7

[Intel-gfx] [PATCH i-g-t 3/5] tests/kms_force_connector: skip if the required connector is connected

2015-11-02 Thread Thomas Wood
Signed-off-by: Thomas Wood --- tests/kms_force_connector.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/kms_force_connector.c b/tests/kms_force_connector.c index f48b187..1e5ec6f 100644 --- a/tests/kms_force_connector.c +++ b/tests/kms_force_connector.c @@ -56,6 +56,7 @@ igt_main

[Intel-gfx] [PATCH i-g-t 5/5] tests/kms_force_connector: use comparison macros

2015-11-02 Thread Thomas Wood
Use the comparison macros to make debug output clearer. v2: fix incorrect comparison Signed-off-by: Thomas Wood --- tests/kms_force_connector.c | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/tests/kms_force_connector.c b/tests/kms_force_connector.c index

[Intel-gfx] [PATCH i-g-t 4/5] tests/kms_force_connector: add an option to reset connector force states

2015-11-02 Thread Thomas Wood
Signed-off-by: Thomas Wood --- tests/kms_force_connector.c | 44 +++- 1 file changed, 43 insertions(+), 1 deletion(-) diff --git a/tests/kms_force_connector.c b/tests/kms_force_connector.c index 1e5ec6f..2cb149a 100644 --- a/tests/kms_force_connector.c

[Intel-gfx] [PATCH i-g-t 2/5] lib: add documentation for igt_display_init/fini

2015-11-02 Thread Thomas Wood
Signed-off-by: Thomas Wood --- lib/igt_kms.c | 16 1 file changed, 16 insertions(+) diff --git a/lib/igt_kms.c b/lib/igt_kms.c index 51d735d..878e1fb 100644 --- a/lib/igt_kms.c +++ b/lib/igt_kms.c @@ -962,6 +962,15 @@ static int get_drm_plane_type(int drm_fd, uint32_t plane_id

Re: [Intel-gfx] [PATCH i-g-t 8/8] tests/kms_fbc_crc: ensure context is initialized correctly

2015-11-09 Thread Thomas Wood
On 4 November 2015 at 19:36, Zanoni, Paulo R wrote: > Em Seg, 2015-11-02 às 11:48 +0000, Thomas Wood escreveu: >> Initialization was included in commit a976d7e (tests/kms_fbc_crc: >> refactor context >> handling code), but won't be executed since it is declared before th

[Intel-gfx] [PATCH i-g-t] lib: add a environment variable to control output

2015-11-09 Thread Thomas Wood
Disable output of terminal control characters and progress meters when IGT_PLAIN_OUTPUT is set in the environment. Cc: Derek Morton Signed-off-by: Thomas Wood --- lib/igt_aux.c | 2 +- lib/igt_core.c | 23 ++- lib/igt_core.h | 2 ++ 3 files changed, 17 insertions(+), 10

Re: [Intel-gfx] [PATCH i-g-t] lib: add a environment variable to control output

2015-11-10 Thread Thomas Wood
On 9 November 2015 at 20:58, Chris Wilson wrote: > On Mon, Nov 09, 2015 at 05:17:13PM +0000, Thomas Wood wrote: >> Disable output of terminal control characters and progress meters when >> IGT_PLAIN_OUTPUT is set in the environment. >> >> Cc: Derek Morton &g

[Intel-gfx] [PATCH i-g-t 1/2] tests/kms_force_connector: clear forced edid in reset

2015-11-10 Thread Thomas Wood
Signed-off-by: Thomas Wood --- tests/kms_force_connector.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tests/kms_force_connector.c b/tests/kms_force_connector.c index f34f21a..a79c974 100644 --- a/tests/kms_force_connector.c +++ b/tests/kms_force_connector.c @@ -47,6

[Intel-gfx] [PATCH i-g-t 2/2] tests/kms_force_connector: reset connectors and edid on exit

2015-11-10 Thread Thomas Wood
Signed-off-by: Thomas Wood --- tests/kms_force_connector.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/tests/kms_force_connector.c b/tests/kms_force_connector.c index a79c974..cf918a7 100644 --- a/tests/kms_force_connector.c +++ b/tests/kms_force_connector.c

Re: [Intel-gfx] [PATCH] igt/igt_kms: Introduce get_first_connected_output (v2)

2015-11-13 Thread Thomas Wood
explains how to manage the version tag in the subject line. > > Suggested-by: Matt Roper > Cc: Thomas Wood > Signed-off-by: Vivek Kasireddy > --- > lib/igt_kms.h | 12 > 1 file changed, 12 insertions(+) > > diff --git a/lib/igt_kms.h b/lib/igt_kms.h &

Re: [Intel-gfx] [PATCH] igt/igt_kms: Introduce get_first_connected_output (v2)

2015-11-16 Thread Thomas Wood
On 14 November 2015 at 03:08, Vivek Kasireddy wrote: > On Fri, 13 Nov 2015 15:59:21 + > Thomas Wood wrote: > >> On 5 November 2015 at 01:34, Vivek Kasireddy >> wrote: >> > In some cases, we just need one valid (connected) output to perform >> &g

Re: [Intel-gfx] [PATCH i-g-t] Add dmesg capture and dumping to tests and a test for it.

2015-11-17 Thread Thomas Wood
On 16 November 2015 at 13:22, Joonas Lahtinen wrote: > Cc: Thomas Wood > Cc: Chris Wilson > Cc: Damien Lespiau > Signed-off-by: Joonas Lahtinen > --- > lib/igt_core.c | 113 > ++--- > tests/Makefile.sources | 1

Re: [Intel-gfx] [PATCH i-g-t] Add dmesg capture and dumping to tests and a test for it.

2015-11-18 Thread Thomas Wood
On 18 November 2015 at 15:44, Daniel Vetter wrote: > On Mon, Nov 16, 2015 at 03:22:23PM +0200, Joonas Lahtinen wrote: >> Cc: Thomas Wood >> Cc: Chris Wilson >> Cc: Damien Lespiau >> Signed-off-by: Joonas Lahtinen > > Given that we have all that in piglit al

[Intel-gfx] [PATCH i-g-t 2/2] lib: set a timeout when reading crc values

2014-05-12 Thread Thomas Wood
Signed-off-by: Thomas Wood --- lib/igt_debugfs.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lib/igt_debugfs.c b/lib/igt_debugfs.c index 4fd2e5a..0912f5b 100644 --- a/lib/igt_debugfs.c +++ b/lib/igt_debugfs.c @@ -459,7 +459,10 @@ static bool read_one_crc(igt_pipe_crc_t *pipe_crc

[Intel-gfx] [PATCH i-g-t 1/2] lib: add igt_set_timeout

2014-05-12 Thread Thomas Wood
Add a function to stop and fail a test after the specified number of seconds have elapsed. Signed-off-by: Thomas Wood --- lib/igt_core.c | 44 +--- lib/igt_core.h | 2 ++ 2 files changed, 43 insertions(+), 3 deletions(-) diff --git a/lib/igt_core.c b

[Intel-gfx] [PATCH] drm/sysfs: expose the "force" connector attribute

2014-05-19 Thread Thomas Wood
Signed-off-by: Thomas Wood --- drivers/gpu/drm/drm_sysfs.c | 49 + 1 file changed, 49 insertions(+) diff --git a/drivers/gpu/drm/drm_sysfs.c b/drivers/gpu/drm/drm_sysfs.c index c22c309..257816e 100644 --- a/drivers/gpu/drm/drm_sysfs.c +++ b/drivers

[Intel-gfx] [PATCH i-g-t 0/2] enabling connectors

2014-05-19 Thread Thomas Wood
This series makes use of: http://lists.freedesktop.org/archives/intel-gfx/2014-May/045553.html to allow tests to enable or disable connectors as required. Thomas Wood (2): lib: add functions to change connector states tests: enable the VGA connector in the kms flip and pipe crc tests lib

[Intel-gfx] [PATCH i-g-t 2/2] tests: enable the VGA connector in the kms flip and pipe crc tests

2014-05-19 Thread Thomas Wood
Signed-off-by: Thomas Wood --- tests/kms_flip.c | 7 +++ tests/kms_pipe_crc_basic.c | 5 + 2 files changed, 12 insertions(+) diff --git a/tests/kms_flip.c b/tests/kms_flip.c index f2ec9ef..7d6e102 100644 --- a/tests/kms_flip.c +++ b/tests/kms_flip.c @@ -1566,6 +1566,8 @@ int

[Intel-gfx] [PATCH i-g-t 1/2] lib: add functions to change connector states

2014-05-19 Thread Thomas Wood
Add a function to force a particular state on a connector and a convenience function to find and set the state on the VGA connector. Signed-off-by: Thomas Wood --- lib/igt_kms.c | 78 lib/igt_kms.h | 12 +++ tests

Re: [Intel-gfx] [PATCH] drm/sysfs: expose the "force" connector attribute

2014-05-19 Thread Thomas Wood
On 19 May 2014 15:13, David Herrmann wrote: > Hi > > On Mon, May 19, 2014 at 3:37 PM, Thomas Wood wrote: >> Signed-off-by: Thomas Wood > > The commit-msg lacks any discussion why this change is done. What is > the reason to do that? Isn't the kernel-command-line en

Re: [Intel-gfx] [PATCH i-g-t 1/2] lib: add functions to change connector states

2014-05-19 Thread Thomas Wood
On 19 May 2014 15:28, Daniel Vetter wrote: > On Mon, May 19, 2014 at 02:42:07PM +0100, Thomas Wood wrote: >> Add a function to force a particular state on a connector and a >> convenience function to find and set the state on the VGA connector. >> >> Signed-off-by:

Re: [Intel-gfx] [PATCH 1/5] drm/i915: Check for FIFO underuns when disabling reporting on gmch platforms

2014-05-21 Thread Thomas Wood
On 16 May 2014 17:40, wrote: > From: Ville Syrjälä > > FIFO underruns don't generate an interrupt on gmch platforms, so we > should check whether there were any that we failed to notice when > we're disabling FIFO underrun reporting. > > Signed-off-by: Ville Syrj

Re: [Intel-gfx] [PATCH 4/5] drm/i915: Simplify the uncleared FIFO underrun detection

2014-05-21 Thread Thomas Wood
K as we > still claim the interrupt. > > Signed-off-by: Ville Syrjälä checkpatch.pl complains that there are lines over 80 characters, but otherwise: Reviewed-by: Thomas Wood > --- > drivers/gpu/drm/i915/i915_irq.c | 13 ++--- > 1 file changed, 2 insertions(+), 11 deletio

Re: [Intel-gfx] [PATCH 2/5] drm/i915: Check for FIFO underruns at the end of modeset on gmch

2014-05-21 Thread Thomas Wood
e underruns on other pipes, > check for underruns on all pipes. > > Signed-off-by: Ville Syrjälä Reviewed-by: Thomas Wood > --- > drivers/gpu/drm/i915/i915_irq.c | 28 > drivers/gpu/drm/i915/intel_display.c | 6 ++ > drivers/gpu/drm/i91

Re: [Intel-gfx] [PATCH 5/5] drm/i915: Shuffle fifo underrun disable/enable points for gmch platforms

2014-05-21 Thread Thomas Wood
till a mystery, but for now I'm going to assume it behaves > like gen4+. > > Signed-off-by: Ville Syrjälä This doesn't apply to drm-intel-nightly, but looks fine in principle: Reviewed-by: Thomas Wood > --- > drivers/gpu/drm/i915/intel_display.c | 30

[Intel-gfx] [PATCH 3/3] drm/debugfs: add an "edid_override" file per connector

2014-05-29 Thread Thomas Wood
Add a file to debugfs for each connector that allows the edid data to be overridden. Signed-off-by: Thomas Wood --- drivers/gpu/drm/drm_crtc.c | 4 +++ drivers/gpu/drm/drm_debugfs.c | 56 ++ drivers/gpu/drm/drm_probe_helper.c | 9

[Intel-gfx] [PATCH 2/3] drm/debugfs: add a "force" file per connector

2014-05-29 Thread Thomas Wood
Add a file to debugfs for each connector to enable modification of the "force" connector attribute. This allows connectors to be enabled or disabled for testing and debugging purposes. Signed-off-by: Thomas Wood --- drivers/gpu/drm/drm_crtc.c| 17 ++- drivers/gpu/drm/drm

[Intel-gfx] [PATCH 0/3] connector debugfs properties

2014-05-29 Thread Thomas Wood
expose the force connector attribute and allow the edid value to be overridden. Thomas Wood (3): drm: add register and unregister functions for connectors drm/debugfs: add a "force" file per connector drm/debugfs: add an "edid_override" file per connector Documentat

[Intel-gfx] [PATCH 1/3] drm: add register and unregister functions for connectors

2014-05-29 Thread Thomas Wood
Introduce generic functions to register and unregister connectors. This provides a common place to add and remove associated user space interfaces. Signed-off-by: Thomas Wood --- Documentation/DocBook/drm.tmpl| 6 +++--- drivers/gpu/drm/armada/armada_output.c| 4

[Intel-gfx] [i-g-t 2/2] quick_dump: read the architecture files for items to add to EXTRA_DIST

2014-06-09 Thread Thomas Wood
Each architecture file contains a list of the text files it requires, so use this to add to the list of files to distribute. Signed-off-by: Thomas Wood --- configure.ac | 6 ++ tools/quick_dump/Makefile.am | 9 + 2 files changed, 7 insertions(+), 8 deletions(-) diff

[Intel-gfx] [i-g-t 1/2] tools: fix distcheck

2014-06-09 Thread Thomas Wood
Fix include paths and references to missing files. Signed-off-by: Thomas Wood --- tools/null_state_gen/Makefile.am | 3 +++ tools/null_state_gen/intel_renderstate_gen6.c | 4 ++-- tools/null_state_gen/intel_renderstate_gen7.c | 4 ++-- tools/null_state_gen/intel_renderstate_gen8.c

[Intel-gfx] [i-g-t 2/7] lib: remove /** from comments that are not API documentation

2014-06-10 Thread Thomas Wood
These comments are not gtk-doc comments, so replacing /** with /* prevents any gtk-doc warnings. Signed-off-by: Thomas Wood --- lib/i915_3d.h | 26 ++-- lib/intel_reg.h | 404 +- lib/rendercopy_gen8.c | 6 +- 3 files changed, 218

[Intel-gfx] [i-g-t 3/7] README: update the section on modifying and rebuilding documentation

2014-06-10 Thread Thomas Wood
Signed-off-by: Thomas Wood --- README | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/README b/README index cfa186d..5e98565 100644 --- a/README +++ b/README @@ -108,16 +108,14 @@ docs/ reference documenation in docs/reference/ You need to have the gtk

[Intel-gfx] [i-g-t 5/7] gitignore: add missing files and keep lists sorted

2014-06-10 Thread Thomas Wood
Signed-off-by: Thomas Wood --- tests/.gitignore| 11 +++ tools/null_state_gen/.gitignore | 1 + 2 files changed, 8 insertions(+), 4 deletions(-) create mode 100644 tools/null_state_gen/.gitignore diff --git a/tests/.gitignore b/tests/.gitignore index d7ad054..a61d025

[Intel-gfx] [i-g-t 6/7] lib: various documentation fixes

2014-06-10 Thread Thomas Wood
Fix some documentation comments and mark some struct members private. Signed-off-by: Thomas Wood --- lib/igt_aux.c | 5 ++--- lib/igt_core.c | 10 +- lib/igt_kms.h | 2 ++ lib/intel_batchbuffer.h | 5 + 4 files changed, 10 insertions(+), 12 deletions

[Intel-gfx] [i-g-t 1/7] README: update piglit instructions

2014-06-10 Thread Thomas Wood
Piglit now has a top level "piglit" command and the location of the tests can now be read from an environment variable. Signed-off-by: Thomas Wood --- README | 27 ++- 1 file changed, 10 insertions(+), 17 deletions(-) diff --git a/README b/README index 2cfb5c

[Intel-gfx] [i-g-t 7/7] docs: add missing sections to intel-gpu-tools-docs.xml

2014-06-10 Thread Thomas Wood
Signed-off-by: Thomas Wood --- docs/reference/intel-gpu-tools/intel-gpu-tools-docs.xml | 4 1 file changed, 4 insertions(+) diff --git a/docs/reference/intel-gpu-tools/intel-gpu-tools-docs.xml b/docs/reference/intel-gpu-tools/intel-gpu-tools-docs.xml index dcfff33..96cf77f 100644 --- a

[Intel-gfx] [i-g-t 4/7] docs: add the sections file

2014-06-10 Thread Thomas Wood
This file can contain custom changes to the control the documentation output and therefore should be included in the repository. Signed-off-by: Thomas Wood --- docs/reference/intel-gpu-tools/.gitignore | 1 - .../intel-gpu-tools/intel-gpu-tools-sections.txt | 378

Re: [Intel-gfx] [i-g-t 1/7] README: update piglit instructions

2014-06-10 Thread Thomas Wood
On 10 June 2014 15:37, Daniel Vetter wrote: > On Tue, Jun 10, 2014 at 03:30:51PM +0100, Thomas Wood wrote: >> Piglit now has a top level "piglit" command and the location of the >> tests can now be read from an environment variable. >> >> Signed-off-by

Re: [Intel-gfx] [i-g-t 3/7] README: update the section on modifying and rebuilding documentation

2014-06-11 Thread Thomas Wood
On 10 June 2014 15:38, Daniel Vetter wrote: > On Tue, Jun 10, 2014 at 03:30:53PM +0100, Thomas Wood wrote: >> Signed-off-by: Thomas Wood >> --- >> README | 12 +--- >> 1 file changed, 5 insertions(+), 7 deletions(-) >> >> diff --git a/README b/

Re: [Intel-gfx] [i-g-t 4/7] docs: add the sections file

2014-06-11 Thread Thomas Wood
On 10 June 2014 15:40, Daniel Vetter wrote: > On Tue, Jun 10, 2014 at 03:30:54PM +0100, Thomas Wood wrote: >> This file can contain custom changes to the control the documentation >> output and therefore should be included in the repository. >> >> Signed-off-by: Thomas

Re: [Intel-gfx] [i-g-t 7/7] docs: add missing sections to intel-gpu-tools-docs.xml

2014-06-11 Thread Thomas Wood
On 10 June 2014 15:47, Daniel Vetter wrote: > On Tue, Jun 10, 2014 at 03:30:57PM +0100, Thomas Wood wrote: >> Signed-off-by: Thomas Wood > > I've intentionally left these out since they're not really part of the > core test library ... E.g. all public rendercopy f

[Intel-gfx] [PATCH i-g-t] docs: add private headers to IGNORE_HFILES

2014-06-11 Thread Thomas Wood
Signed-off-by: Thomas Wood --- docs/reference/intel-gpu-tools/Makefile.am | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/docs/reference/intel-gpu-tools/Makefile.am b/docs/reference/intel-gpu-tools/Makefile.am index daaa3f4..549f34b 100644 --- a/docs/reference/intel-gpu

[Intel-gfx] [PATCH i-g-t] docs: always rebuild the sections file

2014-06-11 Thread Thomas Wood
Always rebuild the sections file since it currently doesn't contain any custom modifications. Signed-off-by: Thomas Wood --- docs/reference/intel-gpu-tools/Makefile.am | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/reference/intel-gpu-tools/Makefile.am b

[Intel-gfx] [PATCH i-g-t] docs: remove unused annotation glossary include

2014-06-11 Thread Thomas Wood
API annotations are not used anywhere in the documentation, so the annotation glossary is not built. Signed-off-by: Thomas Wood --- docs/reference/intel-gpu-tools/intel-gpu-tools-docs.xml | 2 -- 1 file changed, 2 deletions(-) diff --git a/docs/reference/intel-gpu-tools/intel-gpu-tools

[Intel-gfx] [PATCH i-g-t] tests: fix sub-test enumeration

2014-02-12 Thread Thomas Wood
Ensure sub-tests can be listed correctly by doing any test setup within an igt_fixture block. Signed-off-by: Thomas Wood --- tests/gem_evict_alignment.c | 7 --- tests/gem_pwrite_pread.c| 4 ++-- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/tests/gem_evict_alignment.c

[Intel-gfx] [PATCH i-g-t 1/2] Add API documentation support

2014-03-11 Thread Thomas Wood
Add optional support for building API documentation using gtk-doc. Signed-off-by: Thomas Wood --- .gitignore | 3 + Makefile.am| 2 +- NEWS | 2 + autogen.sh

[Intel-gfx] [PATCH i-g-t 2/2] drmtest: reformat the API documentation

2014-03-11 Thread Thomas Wood
Make the existing documentation compatible with gtk-doc. Signed-off-by: Thomas Wood --- lib/drmtest.c | 19 - lib/drmtest.h | 65 +-- 2 files changed, 60 insertions(+), 24 deletions(-) diff --git a/lib/drmtest.c b/lib

[Intel-gfx] [PATCH i-g-t 0/3] Various small changes

2014-03-11 Thread Thomas Wood
The following patches contain two small fixes and one enhancement for intel-gpu-tools. Thomas Wood (3): tests: add missing assertion lib: print the name of the currently running subtest lib: Add i915_pciids.h to Makefile.sources lib/Makefile.sources | 1 + lib/drmtest.c| 5

[Intel-gfx] [PATCH i-g-t 3/3] lib: Add missing header to Makefile.sources

2014-03-11 Thread Thomas Wood
i915_pciids.h was missing from Makefile.sources, which caused distcheck to fail. Signed-off-by: Thomas Wood --- lib/Makefile.sources | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/Makefile.sources b/lib/Makefile.sources index 5072057..cac9d12 100644 --- a/lib/Makefile.sources +++ b/lib

[Intel-gfx] [PATCH i-g-t 1/3] tests: add missing assertion

2014-03-11 Thread Thomas Wood
Signed-off-by: Thomas Wood --- tests/pm_psr.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/pm_psr.c b/tests/pm_psr.c index def8e12..5d28c7a 100644 --- a/tests/pm_psr.c +++ b/tests/pm_psr.c @@ -57,6 +57,7 @@ static int get_perf(const char *path) igt_assert(ret != 0

[Intel-gfx] [PATCH i-g-t 2/3] lib: print the name of the currently running subtest

2014-03-11 Thread Thomas Wood
Signed-off-by: Thomas Wood --- lib/drmtest.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/lib/drmtest.c b/lib/drmtest.c index 9f6e701..b8d3542 100644 --- a/lib/drmtest.c +++ b/lib/drmtest.c @@ -1007,6 +1007,9 @@ bool __igt_run_subtest(const char *subtest_name

[Intel-gfx] [PATCH i-g-t] tests: create files that list the available tests

2014-04-02 Thread Thomas Wood
Add Makefile targets to create two text files containing the list of available single and multi-test programs. This enables the tests to be enumerated without requiring the build system. Signed-off-by: Thomas Wood --- tests/.gitignore | 2 ++ tests/Makefile.am | 14 +- 2 files

[Intel-gfx] [PATCH] drm: fix the addition of the side-by-side (half) flag for extra 3D modes

2013-11-28 Thread Thomas Wood
Ensure the side-by-side (half) flag is added to any existing flags when adding modes from 3D_Structure_ALL. Signed-off-by: Thomas Wood --- drivers/gpu/drm/drm_edid.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index

[Intel-gfx] [PATCH 1/2] drm/edid: split VIC display mode lookup into a separate function

2013-11-28 Thread Thomas Wood
Signed-off-by: Thomas Wood --- drivers/gpu/drm/drm_edid.c | 67 +++--- 1 file changed, 39 insertions(+), 28 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index 52e060e..1dd82cd 100644 --- a/drivers/gpu/drm/drm_edid.c

[Intel-gfx] Parse the list of additional 3D modes

2013-11-28 Thread Thomas Wood
Hi, The following two patches add support for parsing the list of additional 3D modes at the end of the vendor specific data block. The first splits the VIC display mode lookup into a separate function so that it can be reused. The second patch parses the list, adding any support modes to the conn

[Intel-gfx] [PATCH 2/2] drm/edid: parse the list of additional 3D modes

2013-11-28 Thread Thomas Wood
Parse 2D_VIC_order_X and 3D_Structure_X from the list at the end of the HDMI Vendor Specific Data Block. Signed-off-by: Thomas Wood --- drivers/gpu/drm/drm_edid.c | 50 ++ 1 file changed, 50 insertions(+) diff --git a/drivers/gpu/drm/drm_edid.c b

[Intel-gfx] Parse the list of additional 3D modes (v2)

2013-11-29 Thread Thomas Wood
Here's an updated series of patches taking into account Ville's review. Regards, Thomas ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx

  1   2   3   4   5   >