Re: [Intel-gfx] [PATCH 13/13] drm: allow render capable master with DRM_AUTH ioctls

2019-05-27 Thread Thomas Hellstrom
On 5/27/19 10:17 AM, Emil Velikov wrote: From: Emil Velikov There are cases (in mesa and applications) where one would open the primary node without properly authenticating the client. Sometimes we don't check if the authentication succeeds, but there's also cases we simply forget to do it. T

Re: [Intel-gfx] [PATCH 13/13] drm: allow render capable master with DRM_AUTH ioctls

2019-05-27 Thread Thomas Hellstrom
On 5/27/19 3:16 PM, Daniel Vetter wrote: On Mon, May 27, 2019 at 02:39:18PM +0200, Thomas Hellstrom wrote: On 5/27/19 10:17 AM, Emil Velikov wrote: From: Emil Velikov There are cases (in mesa and applications) where one would open the primary node without properly authenticating the client

Re: [Intel-gfx] [PATCH 10/15] drm/vmwgfx: Delete mmaping functions

2019-11-18 Thread Thomas Hellstrom
dd a backlog item to revisit this. > > One more aside: The (un)map_dma_buf can't ever be called because > ->attach rejects everything. Might want to drop a BUG_ON(1) in there. > Same for ->detach. And this. > > Signed-off-by: Daniel Vetter > Cc: VMware Graphics

Re: [Intel-gfx] [PATCH 1/3] dma_resv: prime lockdep annotations

2019-10-21 Thread Thomas Hellstrom
an allocate mm! (Chris). Horrible worker hack out, clean > initcall solution in. > > v4: Annotate with __init (Rob Herring) > > Cc: Rob Herring > Cc: Alex Deucher > Cc: Christian König > Cc: Chris Wilson > Cc: Thomas Zimmermann > Cc: Rob Herring > Cc: Tomeu

Re: [Intel-gfx] [PATCH v3 20/22] drm/vmwgfx: Convert to CRTC VBLANK callbacks

2020-01-20 Thread Thomas Hellstrom
wgfx_stdu.c | 3 +++ > 6 files changed, 15 insertions(+), 9 deletions(-) > Acked-by: Thomas Hellstrom ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH 3/4] drm/vmwgfx: Drop DRM_CONTROL_ALLOW

2018-04-20 Thread Thomas Hellstrom
On 04/20/2018 08:51 AM, Daniel Vetter wrote: Control nodes are no more! Signed-off-by: Daniel Vetter Cc: VMware Graphics Cc: Sinclair Yeh Cc: Thomas Hellstrom --- drivers/gpu/drm/vmwgfx/vmwgfx_drv.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu

Re: [Intel-gfx] [PATCH 3/4] drm/vmwgfx: Drop DRM_CONTROL_ALLOW

2018-04-24 Thread Thomas Hellstrom
On 04/24/2018 03:01 PM, Daniel Vetter wrote: On Fri, Apr 20, 2018 at 07:56:34PM +0200, Thomas Hellstrom wrote: On 04/20/2018 08:51 AM, Daniel Vetter wrote: Control nodes are no more! Signed-off-by: Daniel Vetter Cc: VMware Graphics Cc: Sinclair Yeh Cc: Thomas Hellstrom --- drivers/gpu

Re: [Intel-gfx] [PATCH] drm: More debug info for fb leaks in mode_config_cleanup

2018-04-24 Thread Thomas Hellstrom
Hi, On 12/07/2017 03:49 PM, Daniel Vetter wrote: We're spotting this very rarely in CI, but have no idea. Let's add more debug info about what's going on here. References: https://bugs.freedesktop.org/show_bug.cgi?id=102707 Signed-off-by: Daniel Vetter --- drivers/gpu/drm/drm_mode_config.c |

Re: [Intel-gfx] [PATCH] drm: More debug info for fb leaks in mode_config_cleanup

2018-04-24 Thread Thomas Hellstrom
Hi! On 12/07/2017 03:49 PM, Daniel Vetter wrote: We're spotting this very rarely in CI, but have no idea. Let's add more debug info about what's going on here. References:https://bugs.freedesktop.org/show_bug.cgi?id=102707 Signed-off-by: Daniel Vetter --- drivers/gpu/drm/drm_mode_config.c | 3

Re: [Intel-gfx] [PATCH] drm: More debug info for fb leaks in mode_config_cleanup

2018-04-25 Thread Thomas Hellstrom
On 04/25/2018 08:49 AM, Daniel Vetter wrote: On Wed, Apr 25, 2018 at 8:42 AM, Thomas Hellstrom wrote: Hi, On 12/07/2017 03:49 PM, Daniel Vetter wrote: We're spotting this very rarely in CI, but have no idea. Let's add more debug info about what's going on here. Ref

Re: [Intel-gfx] [PATCH 09/20] drm/kms: Nuke dirty_info property

2016-08-09 Thread Thomas Hellstrom
0aa3ce3214259e69557be5b4ce0d781ffa4 > Author: Jakob Bornecrantz > Date: Thu Dec 3 23:25:47 2009 + > > drm: Add dirty ioctl and property > > Cc: Jakob Bornecrantz > Cc: Dave Airlie > Cc: Sinclair Yeh > Cc: Thomas Hellstrom > Signed-off-by: Daniel Vetter >

Re: [Intel-gfx] [PATCH 09/20] drm/kms: Nuke dirty_info property

2016-08-10 Thread Thomas Hellstrom
On 08/09/2016 04:08 PM, Daniel Vetter wrote: > On Tue, Aug 9, 2016 at 3:59 PM, Thomas Hellstrom > wrote: >> Hmm. >> >> I don't have a strong opinion on this, but IMO the original idea of >> allowing a user-space driver to optimize away the dirty calls isn'

Re: [Intel-gfx] [PATCH 04/18] drm/vmwgfx: Remove confused comment from vmw_du_connector_atomic_set_property

2018-10-02 Thread Thomas Hellstrom
gt;> >> Signed-off-by: Daniel Vetter >> Cc: VMware Graphics >> Cc: Sinclair Yeh >> Cc: Thomas Hellstrom >> --- >> drivers/gpu/drm/vmwgfx/vmwgfx_kms.c | 6 -- >> 1 file changed, 6 deletions(-) >> >> diff --git a/drivers/gpu/drm/vmwgfx/vmwg

Re: [Intel-gfx] [PATCH 07/18] drm/vmwgfx: Add FIXME comments for customer page_flip handlers

2018-10-02 Thread Thomas Hellstrom
Hi, Daniel, On 10/02/2018 03:35 PM, Daniel Vetter wrote: > The idea behind allowing drivers to override legacy ioctls (instead of > using the generic implementations unconditionally) is to handle bugs > in old driver-specific userspace. Like e.g. vmw_kms_set_config does, > to work around some vmwg

Re: [Intel-gfx] [PATCH 14/14] drm/vmwgfx: Add FIXME comments for customer page_flip handlers

2018-09-04 Thread Thomas Hellstrom
On 09/03/2018 06:54 PM, Daniel Vetter wrote: The idea behind allowing drivers to override legacy ioctls (instead of using the generic implementations unconditionally) is to handle bugs in old driver-specific userspace. Like e.g. vmw_kms_set_config does, to work around some vmwgfx userspace not cl

[Intel-gfx] drm-next xf86-video-vmware breakage Was [PATCH 02/10] drm/uapi: Validate the mode flags/type

2018-03-21 Thread Thomas Hellstrom
Hi, Ville, On 11/14/2017 07:32 PM, Ville Syrjala wrote: From: Ville Syrjälä Currently userspace is allowed to feed in any king of garbage in the high bits of the mode flags/type, as are drivers when probing modes. Reject any mode with bogus flags/type. Hopefully this won't break any current u

Re: [Intel-gfx] drm-next xf86-video-vmware breakage Was [PATCH 02/10] drm/uapi: Validate the mode flags/type

2018-03-21 Thread Thomas Hellstrom
On 03/21/2018 09:51 PM, Ville Syrjälä wrote: On Wed, Mar 21, 2018 at 09:45:09PM +0100, Thomas Hellstrom wrote: Hi, Ville, On 11/14/2017 07:32 PM, Ville Syrjala wrote: From: Ville Syrjälä Currently userspace is allowed to feed in any king of garbage in the high bits of the mode flags/type

Re: [Intel-gfx] [PATCH] drm: Fix uabi regression by allowing garbage mode->type from userspace

2018-03-22 Thread Thomas Hellstrom
ype is just a hint anyway, and more useful for the kernel->userspace direction. Reported-by: Thomas Hellstrom CC: Thomas Hellstrom Cc: Adam Jackson Cc: Alex Deucher Fixes: c6ed6dad5cfb ("drm/uapi: Validate the mode flags/type") References: https://lists.freedesktop.org/archives/d

Re: [Intel-gfx] [PATCH 12/23] drm/vmwgfx: Stop consulting plane->fb

2018-03-22 Thread Thomas Hellstrom
On 03/22/2018 04:23 PM, Ville Syrjala wrote: From: Ville Syrjälä We want to get rid of plane->fb on atomic drivers. Stop looking at it. Cc: VMware Graphics Cc: Sinclair Yeh Cc: Thomas Hellstrom Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/vmwgfx/vmwgfx_kms.c | 6 +++--- 1 f

Re: [Intel-gfx] [PATCH 3/7] drm/vmwgfx: Stop using plane->fb in vmw_kms_helper_dirty()

2018-04-05 Thread Thomas Hellstrom
ckdep assert to catch wrongdoers. Cc: Thomas Hellstrom Cc: Sinclair Yeh Cc: VMware Graphics Cc: Daniel Vetter Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/vmwgfx/vmwgfx_kms.c | 15 --- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx

Re: [Intel-gfx] [PATCH 4/9] drm: Begin an API for in-kernel clients

2018-05-23 Thread Thomas Hellstrom
Hi, Noralf. A couple of issues below: On 05/23/2018 04:34 PM, Noralf Trønnes wrote: This the beginning of an API for in-kernel clients. First out is a way to get a framebuffer backed by a dumb buffer. Only GEM drivers are supported. The original idea of using an exported dma-buf was dropped be

Re: [Intel-gfx] [PATCH 4/9] drm: Begin an API for in-kernel clients

2018-05-24 Thread Thomas Hellstrom
On 05/24/2018 10:32 AM, Daniel Vetter wrote: On Wed, May 23, 2018 at 11:45:00PM +0200, Thomas Hellstrom wrote: Hi, Noralf. A couple of issues below: On 05/23/2018 04:34 PM, Noralf Trønnes wrote: This the beginning of an API for in-kernel clients. First out is a way to get a framebuffer

Re: [Intel-gfx] [PATCH 4/9] drm: Begin an API for in-kernel clients

2018-05-24 Thread Thomas Hellstrom
On 05/24/2018 12:14 PM, Daniel Vetter wrote: On Thu, May 24, 2018 at 11:25:04AM +0200, Thomas Hellstrom wrote: On 05/24/2018 10:32 AM, Daniel Vetter wrote: On Wed, May 23, 2018 at 11:45:00PM +0200, Thomas Hellstrom wrote: Hi, Noralf. A couple of issues below: On 05/23/2018 04:34 PM, Noralf

Re: [Intel-gfx] [PATCH i-g-t] tests: add core_setmaster_vs_auth

2015-12-01 Thread Thomas Hellstrom
t; > v2: Use correct test stanza ... and I need coffee. > > Cc: Thomas Hellstrom > Signed-off-by: Daniel Vetter > --- > tests/.gitignore | 1 + > tests/Makefile.sources | 1 + > tests/core_setmaster_vs_auth.c | 73 >

Re: [Intel-gfx] [PATCH 11/28] drm/vmwgfx: Drop dummy save/restore hooks

2015-12-08 Thread Thomas Hellstrom
Reviewed-by: Thomas Hellstrom On 12/04/2015 09:45 AM, Daniel Vetter wrote: > These hooks will be gone soon. > > Cc: Thomas Hellstrom > Signed-off-by: Daniel Vetter > --- > drivers/gpu/drm/vmwgfx/vmwgfx_kms.c | 16 > drivers/gpu/drm/vmwgfx/vmwgfx_ldu.c

Re: [Intel-gfx] linux-next: manual merge of the drm-misc tree with Linus' tree

2015-12-13 Thread Thomas Hellstrom
On 12/14/2015 02:12 AM, Stephen Rothwell wrote: > Hi all, > > Today's linux-next merge of the drm-misc tree got conflicts in: > > drivers/gpu/drm/vmwgfx/vmwgfx_ldu.c > drivers/gpu/drm/vmwgfx/vmwgfx_scrn.c > drivers/gpu/drm/vmwgfx/vmwgfx_stdu.c > > between commit: > > 8fbf9d92a7bc ("drm/vmwg

Re: [Intel-gfx] [PATCH] drm: move allocation out of drm_get_format_name()

2016-11-04 Thread Thomas Hellstrom
For the vmwgfx part: Acked-by: Thomas Hellstrom On 11/05/2016 08:33 AM, Eric Engestrom wrote: > Fixes: 90844f00049e9f42573fd31d7c32e8fd31d3fd07 > > drm: make drm_get_format_name thread-safe > > Signed-off-by: Eric Engestrom > [danvet: Clarify that the return

Re: [Intel-gfx] [PATCH] drm/core: Do not preserve framebuffer on rmfb, v3.

2016-05-03 Thread Thomas Hellstrom
Hi, Sorry for the late response, been very busy with other stuff lately. I've tested this version against drm-fixes and it indeed fixes the problem, as far as I can tell. Tested-by: Thomas Hellstrom On 03/31/2016 01:26 PM, Maarten Lankhorst wrote: > It turns out that preserving fram

Re: [Intel-gfx] [PATCH] [RFC] drm: Nerf DRM_CONTROL nodes

2017-02-19 Thread Thomas Hellstrom
Hi! This patch breaks the vmwgfx resolutionKMS daemon which opens a control node to tell DRM about the monitor layout... /Thomas On 10/28/2016 10:10 AM, Daniel Vetter wrote: > Looking at the ioctl permission checks I noticed that it's impossible > to import gem buffers into a control nodes, and

Re: [Intel-gfx] [PATCH] [RFC] drm: Nerf DRM_CONTROL nodes

2017-02-19 Thread Thomas Hellstrom
So I think we need a quick revert of this commit or a quick stable follow-up to unbreak things on our side. /Thomas On 02/19/2017 03:54 PM, Thomas Hellstrom wrote: > Hi! > > This patch breaks the vmwgfx resolutionKMS daemon which opens a control > node to tell DRM about the mo

[Intel-gfx] DRM_CONTROL node breakage (Re: [PATCH] [RFC] drm: Nerf DRM_CONTROL nodes)

2017-02-20 Thread Thomas Hellstrom
ease cycles of open-vm-tools the open-vm-tools version was just about to be released. It's necessary for non-xorg /Thomas On 02/20/2017 11:22 PM, Daniel Vetter wrote: > On Sun, Feb 19, 2017 at 4:21 PM, Thomas Hellstrom wrote: >> So I think we need a quick revert of this commit o

Re: [Intel-gfx] DRM_CONTROL node breakage (Re: [PATCH] [RFC] drm: Nerf DRM_CONTROL nodes)

2017-02-21 Thread Thomas Hellstrom
On 02/21/2017 06:34 AM, David Airlie wrote: >> No. >> >> IMO Not fixing this immediately through stable is out of the question. >> The deal is that we don't break userspace. >> Having said that, I'm not against a long term vmwgfx-only solution. But >> let's fix this now. >> >> Admittedly we missed

Re: [Intel-gfx] [PATCH] [RFC] drm: Nerf DRM_CONTROL nodes

2017-02-21 Thread Thomas Hellstrom
On 02/20/2017 11:22 PM, Daniel Vetter wrote: > On Sun, Feb 19, 2017 at 4:21 PM, Thomas Hellstrom wrote: >> So I think we need a quick revert of this commit or a quick stable >> follow-up to unbreak things on our side. > I'd much prefer we just register control nodes

Re: [Intel-gfx] [PATCH 21/21] drm/vmwgfx: Nuke preclose hook

2016-01-08 Thread Thomas Hellstrom
On 01/08/2016 09:36 PM, Daniel Vetter wrote: > Again since the drm core takes care of event unlinking/disarming this > is now just needless code. > > Cc: Thomas Hellström > Signed-off-by: Daniel Vetter Hmm, IIRC this is actually a list of events that core drm is not aware of yet. They sit on thi

Re: [Intel-gfx] [PATCH 21/21] drm/vmwgfx: Nuke preclose hook

2016-01-10 Thread Thomas Hellstrom
On 01/09/2016 11:43 AM, Daniel Vetter wrote: > On Fri, Jan 8, 2016 at 9:53 PM, Thomas Hellstrom > wrote: >> On 01/08/2016 09:36 PM, Daniel Vetter wrote: >>> Again since the drm core takes care of event unlinking/disarming this >>> is now just needless code

Re: [Intel-gfx] [PATCH] drm/vmwgfx: Nuke preclose hook

2016-01-10 Thread Thomas Hellstrom
In general, looks good. Two things though. 1) vc4_drv.h looks like it ended up in the wrong patch. 2) Should be able to nuke also struct vmw_fpriv::fence_events and struct vmw_event_fence_action::fpriv_head? /Thomas On 01/10/2016 11:02 PM, Daniel Vetter wrote: > Again since the drm core takes ca

Re: [Intel-gfx] [PATCH 5/5] drm/vmwgfx: Nuke preclose hook

2016-01-11 Thread Thomas Hellstrom
LGTM. Reviewed-by: Thomas Hellstrom On 01/10/2016 11:26 PM, Daniel Vetter wrote: > Again since the drm core takes care of event unlinking/disarming this > is now just needless code. > > v2: I've completely missed eaction->fpriv_head and all the related > code. We need to

Re: [Intel-gfx] [PATCH 11/13] drm/vmwgfx: Drop drm_vblank_cleanup

2017-06-26 Thread Thomas Hellstrom
With the below fixed, Reviewed-by: Thomas Hellstrom On 06/23/2017 04:10 PM, Sean Paul wrote: On Wed, Jun 21, 2017 at 10:28:48AM +0200, Daniel Vetter wrote: Again stopping the vblank before uninstalling the irq handler is kinda the wrong way round, but the fb_off stuff should take care of

Re: [Intel-gfx] [PATCH 4/8] drm: Nuke drm_atomic_helper_crtc_set_property

2017-08-03 Thread Thomas Hellstrom
Acked-by: Thomas Hellstrom On 07/25/2017 10:01 AM, Daniel Vetter wrote: It's dead code because this is now handled in the core. Signed-off-by: Daniel Vetter Cc: Boris Brezillon Cc: Daniel Vetter Cc: Jani Nikula Cc: Sean Paul Cc: David Airlie Cc: Ben Skeggs Cc: Tomi Valkeine

Re: [Intel-gfx] linux-next: Signed-off-by missing for commit in the drm-misc-fixes tree

2018-01-18 Thread Thomas Hellstrom
Hi, Stephen, That would be me. I've historically only added my signed-off-by:s on commits I've (co-) authored myself, as the committer info is already registered, But I take it that's not the correct approach? /Thomas On 01/18/2018 09:23 PM, Stephen Rothwell wrote: Hi all, Commit 8a51

Re: [Intel-gfx] [PATCH 06/19] drm/vmwgfx: Drop the cursor locking hack

2017-03-22 Thread Thomas Hellstrom
On 03/22/2017 10:50 PM, Daniel Vetter wrote: > It's been around forever, no one bothered to address the FIXME, so I > presume it's all fine. > > Cc: Sinclair Yeh > Cc: Thomas Hellstrom > Signed-off-by: Daniel Vetter NAK. We need to properly address this. Probably

Re: [Intel-gfx] [PATCH 06/19] drm/vmwgfx: Drop the cursor locking hack

2017-03-23 Thread Thomas Hellstrom
Hi, Daniel, On 03/23/2017 08:31 AM, Daniel Vetter wrote: > On Thu, Mar 23, 2017 at 08:28:32AM +0100, Daniel Vetter wrote: >> On Thu, Mar 23, 2017 at 07:22:31AM +0100, Thomas Hellstrom wrote: >>> On 03/22/2017 10:50 PM, Daniel Vetter wrote: >>>> It's been around

Re: [Intel-gfx] [PATCH 06/19] drm/vmwgfx: Drop the cursor locking hack

2017-03-23 Thread Thomas Hellstrom
On 03/23/2017 11:10 AM, Daniel Vetter wrote: > On Thu, Mar 23, 2017 at 09:35:25AM +0100, Thomas Hellstrom wrote: >> Hi, Daniel, >> >> On 03/23/2017 08:31 AM, Daniel Vetter wrote: >>> On Thu, Mar 23, 2017 at 08:28:32AM +0100, Daniel Vetter wrote: >>>>

Re: [Intel-gfx] [PATCH 06/19] drm/vmwgfx: Drop the cursor locking hack

2017-03-27 Thread Thomas Hellstrom
On 03/27/2017 08:28 AM, Daniel Vetter wrote: > We discussed this quickly on irc, transcribing. > > On Mon, Mar 27, 2017 at 5:01 AM, Michel Dänzer wrote: >> Strictly speaking, the (virtual) hardware is too limited to support the >> legacy KMS cursor API. AFAIR e.g. weston at least used to make use

Re: [Intel-gfx] [PATCH 06/19] drm/vmwgfx: Drop the cursor locking hack

2017-03-29 Thread Thomas Hellstrom
On 03/29/2017 10:00 AM, Daniel Vetter wrote: > On Mon, Mar 27, 2017 at 10:31:51AM +0200, Thomas Hellstrom wrote: >> On 03/27/2017 08:28 AM, Daniel Vetter wrote: >>> We discussed this quickly on irc, transcribing. >>> >>> On Mon, Mar 27, 2017 at 5:01 AM, Michel D

Re: [Intel-gfx] [PATCH 4/4] drm: Resurrect atomic rmfb code, v2

2017-01-25 Thread Thomas Hellstrom
On 01/25/2017 05:54 AM, Daniel Vetter wrote: > On Tue, Jan 24, 2017 at 01:44:54PM -0800, Matt Roper wrote: >> On Wed, Jan 11, 2017 at 05:15:47PM +0100, Daniel Vetter wrote: >>> On Thu, Dec 15, 2016 at 03:29:45PM +0100, Maarten Lankhorst wrote: From: Daniel Vetter This was somehow lo

[PULL] drm-xe-fixes

2024-01-25 Thread Thomas Hellstrom
Hi, Dave, Sima The Xe fixes PR for 6.8-rc2. Thanks, Thomas. The following changes since commit 6613476e225e090cc9aad49be7fa504e290dd33d: Linux 6.8-rc1 (2024-01-21 14:11:32 -0800) are available in the Git repository at: https://gitlab.freedesktop.org/drm/xe/kernel.git tags/drm-xe-fixes-202

[PULL] drm-xe-fixes

2024-06-20 Thread Thomas Hellstrom
Hi, Dave, Sima A single fix this week. Thanks, Thomas drm-xe-fixes-2024-06-20: Driver Changes: - Fix for invalid register access The following changes since commit 6ba59ff4227927d3a8530fc2973b80e94b54d58f: Linux 6.10-rc4 (2024-06-16 13:40:16 -0700) are available in the Git repository at:

[PULL] drm-xe-fixes

2024-07-04 Thread Thomas Hellstrom
Hi Dave and Sima Two small fixes this week. Thanks, Thomas drm-xe-fixes-2024-07-04: Driver Changes: - One copy/paste mistake fix. - One error path fix causing an error pointer dereference. The following changes since commit 22a40d14b572deb80c0648557f4bd502d7e83826: Linux 6.10-rc6 (2024-06-30

[PULL] drm-xe-fixes

2024-02-01 Thread Thomas Hellstrom
Hi Dave and Sima, The xe fixes for 6.8-rc2. drm-xe-fixes-2024-02-01: UAPI Changes: - Only allow a single user-fence per exec / bind. The reason for this clarification fix is a limitation in the implementation which can be lifted moving forward, if needed. Driver Changes: - A crash fix - A fi

[PULL] drm-xe-fixes

2024-02-08 Thread Thomas Hellstrom
Dave, Sima The drm-xe-fixes pull for -rc4. Thanks, Thomas drm-xe-fixes-2024-02-08: Driver Changes: - Fix a loop in an error path - Fix a missing dma-fence reference - Fix a retry path on userptr REMAP - Workaround for a false gcc warning - Fix missing map of the usm batch buffer in the migrate

[PULL] drm-xe-fixes

2024-02-15 Thread Thomas Hellstrom
Hi Dave, Sima! The xe fixes pull request for -rc5. drm-xe-fixes-2024-02-15: Driver Changes: - Fix an out-of-bounds shift. - Fix the display code thinking xe uses shmem - Fix a warning about index out-of-bound - Fix a clang-16 compilation warning Thanks, Thomas The following changes since commit

[PULL] drm-xe-fixes

2024-02-22 Thread Thomas Hellstrom
Hi, Dave Sima The Xe pull request for 6.8-rc6 The uAPI fixes / adjustments we've been discussing are starting to appear, and I will hopefully have the rest for next week's PR. In addition two driver fixes. drm-xe-fixes-2024-02-22: UAPI Changes: - Remove support for persistent exec_queues - Drop a

[PULL] drm-xe-fixes

2024-02-29 Thread Thomas Hellstrom
Dave, Sima The xe fixes for -rc7. It's mostly uapi sanitizing and future-proofing, and a couple of driver fixes. drm-xe-fixes-2024-02-29: UAPI Changes: - A couple of tracepoint updates from Priyanka and Lucas. - Make sure BINDs are completed before accepting UNBINDs on LR vms. - Don't arbitrarily

[PULL] drm-xe-fixes

2024-03-07 Thread Thomas Hellstrom
Hi Dave, Sima A single error path fix for 6.8 final (-rc8). Thanks, Thomas drm-xe-fixes-2024-03-07: Driver Changes: - An error path fix. The following changes since commit 90d35da658da8cff0d4ecbb5113f5fac9d00eb72: Linux 6.8-rc7 (2024-03-03 13:02:52 -0800) are available in the Git repository

[PULL] drm-xe-next-fixes

2024-05-02 Thread Thomas Hellstrom
Dave, Sima This week's small set of fixes for drm-next. drm-xe-next-fixes-2024-05-02: Driver Changes: - Fix for a backmerge going slightly wrong. - An UAF fix - Avoid a WA error on LNL. Thanks, Thomas The following changes since commit 4a56c0ed5aa0bcbe1f5f7d755fb1fe1ebf48ae9c: Merge tag 'amd

[PULL] drm-xe-next-fixes

2024-05-09 Thread Thomas Hellstrom
Hi, Dave & Sima This weeks -next-fixes. Two fixes breifly described below. Driver Changes: - Use ordered WQ for G2H handler. (Matthew Brost) - Use flexible-array rather than zero-sized (Lucas De Marchi) Thanks, Thomas The following changes since commit 3bc8848bb7f7478e6806e4522b06b63f40a53e1e:

[PULL] drm-xe-fixes

2024-05-30 Thread Thomas Hellstrom
Hi Dave, Sima The drm-xe-fixes for -rc2 Only three fixes so far. I'm holding back one additional fix to be able to sort out whether it's correct or need more work. drm-xe-fixes-2024-05-30: Driver Changes: - One pcode polling timeout change - One fix for deadlocks for faulting VMs - One error-pat

[PULL] drm-xe-fixes

2024-06-04 Thread Thomas Hellstrom
Dave and Sima, A single fix for a missing Local Memory Translation Table update for -rc3. Thanks, Thomas drm-xe-fixes-2024-06-04: Driver Changes: - drm/xe/pf: Update the LMTT when freeing VF GT config The following changes since commit 6c5cd0807c79eb4c0cda70b48f6be668a241d584: drm/xe: Proper

[PULL] drm-xe-fixes

2024-06-13 Thread Thomas Hellstrom
Hi Dave & Sima, This week's drm-xe-fixes PR. Except from the maintainer update, nothing major, really. The "drm/xe: move disable_c6 call" required some conflict resolution (both visible and silent) which was also reflected in a conflict with drm-next when building drm-tip. drm-xe-fixes-2024-06-1

[PULL] drm-xe-next

2024-04-23 Thread Thomas Hellstrom
Hi, Dave, Sima The main -next 6.10 pull request for the xe driver. I scanned through the patches and tried to provide a somewhat condensed log below. Nothing spectacular in the uAPI changes. Among other things there are some flags that are reinstated now that we have published UMD for them. Unfo

Re: [Intel-gfx] [BUG] completely bonkers use of set_need_resched + VM_FAULT_NOPAGE

2013-09-12 Thread Thomas Hellstrom
On 09/12/2013 05:58 PM, Daniel Vetter wrote: On Thu, Sep 12, 2013 at 5:43 PM, Peter Zijlstra wrote: The one in ttm is just bonghits to shut up lockdep: ttm can recurse into it's own pagefault handler and then deadlock, the trylock just keeps lockdep quiet. Could you describe how it could recu

Re: [Intel-gfx] [BUG] completely bonkers use of set_need_resched + VM_FAULT_NOPAGE

2013-09-12 Thread Thomas Hellstrom
On 09/12/2013 05:45 PM, Maarten Lankhorst wrote: Op 12-09-13 17:36, Daniel Vetter schreef: On Thu, Sep 12, 2013 at 5:06 PM, Peter Zijlstra wrote: So I'm poking around the preemption code and stumbled upon: drivers/gpu/drm/i915/i915_gem.c:set_need_resched(); drivers/gpu/drm/ttm

Re: [Intel-gfx] [BUG] completely bonkers use of set_need_resched + VM_FAULT_NOPAGE

2013-09-12 Thread Thomas Hellstrom
On 09/12/2013 10:39 PM, Thomas Gleixner wrote: On Thu, 12 Sep 2013, Daniel Vetter wrote: On Thu, Sep 12, 2013 at 10:20 PM, Thomas Gleixner wrote: I think for ttm drivers it's just execbuf being exploitable. But on drm/i915 we've had the same issue with the pwrite/pread ioctls, so a simple glB

Re: [Intel-gfx] [BUG] completely bonkers use of set_need_resched + VM_FAULT_NOPAGE

2013-09-12 Thread Thomas Hellstrom
On 09/12/2013 11:50 PM, Maarten Lankhorst wrote: Op 12-09-13 18:44, Thomas Hellstrom schreef: On 09/12/2013 05:45 PM, Maarten Lankhorst wrote: Op 12-09-13 17:36, Daniel Vetter schreef: On Thu, Sep 12, 2013 at 5:06 PM, Peter Zijlstra wrote: So I'm poking around the preemption cod

Re: [Intel-gfx] [BUG] completely bonkers use of set_need_resched + VM_FAULT_NOPAGE

2013-09-12 Thread Thomas Hellstrom
On 09/12/2013 11:50 PM, Maarten Lankhorst wrote: Op 12-09-13 18:44, Thomas Hellstrom schreef: On 09/12/2013 05:45 PM, Maarten Lankhorst wrote: Op 12-09-13 17:36, Daniel Vetter schreef: On Thu, Sep 12, 2013 at 5:06 PM, Peter Zijlstra wrote: So I'm poking around the preemption cod

Re: [Intel-gfx] [BUG] completely bonkers use of set_need_resched + VM_FAULT_NOPAGE

2013-09-13 Thread Thomas Hellstrom
On 09/13/2013 09:16 AM, Maarten Lankhorst wrote: Op 13-09-13 08:44, Thomas Hellstrom schreef: On 09/12/2013 11:50 PM, Maarten Lankhorst wrote: Op 12-09-13 18:44, Thomas Hellstrom schreef: On 09/12/2013 05:45 PM, Maarten Lankhorst wrote: Op 12-09-13 17:36, Daniel Vetter schreef: On Thu, Sep

Re: [Intel-gfx] [BUG] completely bonkers use of set_need_resched + VM_FAULT_NOPAGE

2013-09-13 Thread Thomas Hellstrom
On 09/13/2013 09:51 AM, Maarten Lankhorst wrote: Op 13-09-13 09:46, Thomas Hellstrom schreef: On 09/13/2013 09:16 AM, Maarten Lankhorst wrote: Op 13-09-13 08:44, Thomas Hellstrom schreef: On 09/12/2013 11:50 PM, Maarten Lankhorst wrote: Op 12-09-13 18:44, Thomas Hellstrom schreef: On 09/12

Re: [Intel-gfx] [BUG] completely bonkers use of set_need_resched + VM_FAULT_NOPAGE

2013-09-13 Thread Thomas Hellstrom
On 09/13/2013 10:32 AM, Daniel Vetter wrote: On Fri, Sep 13, 2013 at 10:23 AM, Thomas Hellstrom wrote: As previously mentioned, copy_from_user should return -EFAULT, since the VMAs are marked with VM_IO. It should not recurse into fault(), so evil user-space looses. I haven't put a prin

Re: [Intel-gfx] [BUG] completely bonkers use of set_need_resched + VM_FAULT_NOPAGE

2013-09-13 Thread Thomas Hellstrom
On 09/13/2013 10:58 AM, Maarten Lankhorst wrote: Op 13-09-13 10:23, Thomas Hellstrom schreef: On 09/13/2013 09:51 AM, Maarten Lankhorst wrote: Op 13-09-13 09:46, Thomas Hellstrom schreef: On 09/13/2013 09:16 AM, Maarten Lankhorst wrote: Op 13-09-13 08:44, Thomas Hellstrom schreef: On 09/12

Re: [Intel-gfx] [RFC PATCH] drm/nouveau: fix nested locking in mmap handler

2013-09-24 Thread Thomas Hellstrom
On 09/23/2013 05:33 PM, Maarten Lankhorst wrote: Hey, Op 13-09-13 11:00, Peter Zijlstra schreef: On Fri, Sep 13, 2013 at 10:41:54AM +0200, Daniel Vetter wrote: On Fri, Sep 13, 2013 at 10:29 AM, Peter Zijlstra wrote: On Fri, Sep 13, 2013 at 09:46:03AM +0200, Thomas Hellstrom wrote: if

Re: [Intel-gfx] [RFC PATCH] drm/nouveau: fix nested locking in mmap handler

2013-09-24 Thread Thomas Hellstrom
On 09/24/2013 09:34 AM, Maarten Lankhorst wrote: Op 24-09-13 09:22, Thomas Hellstrom schreef: On 09/23/2013 05:33 PM, Maarten Lankhorst wrote: Hey, Op 13-09-13 11:00, Peter Zijlstra schreef: On Fri, Sep 13, 2013 at 10:41:54AM +0200, Daniel Vetter wrote: On Fri, Sep 13, 2013 at 10:29 AM

Re: [Intel-gfx] [RFC PATCH] drm/nouveau: fix nested locking in mmap handler

2013-09-24 Thread Thomas Hellstrom
On 09/24/2013 12:11 PM, Maarten Lankhorst wrote: Op 24-09-13 11:36, Daniel Vetter schreef: On Tue, Sep 24, 2013 at 11:03:37AM +0200, Thomas Hellstrom wrote: On 09/24/2013 09:34 AM, Maarten Lankhorst wrote: Op 24-09-13 09:22, Thomas Hellstrom schreef: On 09/23/2013 05:33 PM, Maarten Lankhorst

Re: [Intel-gfx] [RFC PATCH] drm/nouveau: fix nested locking in mmap handler

2013-09-24 Thread Thomas Hellstrom
On 09/24/2013 01:32 PM, Maarten Lankhorst wrote: Op 24-09-13 12:33, Thomas Hellstrom schreef: On 09/24/2013 12:11 PM, Maarten Lankhorst wrote: It seems userspace only updates offset and domain in nouveau. If it fails to update it would result in the same affect as when the buffer gets moved

Re: [Intel-gfx] [RFC PATCH] drm/nouveau: fix nested locking in mmap handler

2013-09-24 Thread Thomas Hellstrom
On 09/24/2013 11:43 AM, Maarten Lankhorst wrote: Op 24-09-13 11:03, Thomas Hellstrom schreef: On 09/24/2013 09:34 AM, Maarten Lankhorst wrote: Op 24-09-13 09:22, Thomas Hellstrom schreef: Actually, it's not the locking order bo:reserve -> mmap_sem that triggers the lockdep warnin

Re: [Intel-gfx] [RFC PATCH] drm/radeon: fixup locking inversion between mmap_sem and reservations

2013-10-08 Thread Thomas Hellstrom
On 10/08/2013 04:55 PM, Jerome Glisse wrote: On Tue, Oct 08, 2013 at 04:45:18PM +0200, Christian König wrote: Am 08.10.2013 16:33, schrieb Jerome Glisse: On Tue, Oct 08, 2013 at 04:14:40PM +0200, Maarten Lankhorst wrote: Allocate and copy all kernel memory before doing reservations. This preve

Re: [Intel-gfx] [RFC PATCH] drm/radeon: fixup locking inversion between mmap_sem and reservations

2013-10-08 Thread Thomas Hellstrom
On 10/08/2013 06:47 PM, Jerome Glisse wrote: On Tue, Oct 08, 2013 at 06:29:35PM +0200, Thomas Hellstrom wrote: On 10/08/2013 04:55 PM, Jerome Glisse wrote: On Tue, Oct 08, 2013 at 04:45:18PM +0200, Christian König wrote: Am 08.10.2013 16:33, schrieb Jerome Glisse: On Tue, Oct 08, 2013 at 04

Re: [Intel-gfx] [PATCH v4] dma-buf: Add ioctls to allow userspace to flush

2015-08-25 Thread Thomas Hellstrom
Hi, Tiago. On 08/26/2015 02:02 AM, Tiago Vignatti wrote: > From: Daniel Vetter > > The userspace might need some sort of cache coherency management e.g. when CPU > and GPU domains are being accessed through dma-buf at the same time. To > circumvent this problem there are begin/end coherency marke

Re: [Intel-gfx] [PATCH v4] dma-buf: Add ioctls to allow userspace to flush

2015-08-26 Thread Thomas Hellstrom
On 08/26/2015 02:10 PM, Daniel Vetter wrote: > On Wed, Aug 26, 2015 at 08:49:00AM +0200, Thomas Hellstrom wrote: >> Hi, Tiago. >> >> On 08/26/2015 02:02 AM, Tiago Vignatti wrote: >>> From: Daniel Vetter >>> >>> The userspace might need some sort

Re: [Intel-gfx] [PATCH v4] dma-buf: Add ioctls to allow userspace to flush

2015-08-26 Thread Thomas Hellstrom
On 08/26/2015 04:32 PM, Tiago Vignatti wrote: > On 08/26/2015 09:58 AM, Daniel Vetter wrote: >> The other is that right now there's no user nor implementation in sight >> which actually does range-based flush optimizations, so I'm pretty much >> expecting we'll get it wrong. Maybe instead we should

Re: [Intel-gfx] [PATCH v4] dma-buf: Add ioctls to allow userspace to flush

2015-08-26 Thread Thomas Hellstrom
> 26 aug 2015 kl. 16:58 skrev Tiago Vignatti : > >> On 08/26/2015 11:51 AM, Daniel Vetter wrote: >>> On Wed, Aug 26, 2015 at 11:32:30AM -0300, Tiago Vignatti wrote: On 08/26/2015 09:58 AM, Daniel Vetter wrote: The other is that right now there's no user nor implementation in sight >>

Re: [Intel-gfx] [PATCH] drm/mm: Support 4 GiB and larger ranges

2015-01-26 Thread Thomas Hellstrom
On 01/26/2015 11:51 PM, Dave Airlie wrote: > On 23 January 2015 at 18:05, Thierry Reding wrote: >> From: Thierry Reding >> >> The current implementation is limited by the number of addresses that >> fit into an unsigned long. This causes problems on 32-bit Tegra where >> unsigned long is 32-bit b

Re: [Intel-gfx] [PATCH] drm/mm: Support 4 GiB and larger ranges

2015-01-27 Thread Thomas Hellstrom
On 01/27/2015 09:15 AM, Thierry Reding wrote: > On Tue, Jan 27, 2015 at 07:07:44AM +0100, Thomas Hellstrom wrote: >> On 01/26/2015 11:51 PM, Dave Airlie wrote: >>> On 23 January 2015 at 18:05, Thierry Reding wrote: >>>> From: Thierry Reding >>>> >>

Re: [Intel-gfx] [PATCH v4] mmap on the dma-buf directly

2015-08-14 Thread Thomas Hellstrom
On 08/13/2015 01:29 AM, Tiago Vignatti wrote: > Hi, > > The idea is to create a GEM bo in one process and pass the prime handle of the > it to another process, which in turn uses the handle only to map and write. > This could be useful for Chrome OS architecture, where the Web content > ("unprivile

[PULL] drm-xe-next

2024-10-17 Thread Thomas Hellstrom
Dave, Simona This week's -next PR. Note the implicit fencing uapi fix. Thanks, Thomas drm-xe-next-2024-10-17: UAPI Changes: - (Implicit) Fix the exec unnecessary implicit fencing (Matt Brost) Driver Changes: - Fix an inverted if statement (Colin) - Fixes around display d3cold vs non-d3cold runt

[PULL] drm-xe-next

2024-10-10 Thread Thomas Hellstrom
Hi Dave & Simona First drm-xe-next pull request for 6.13 Thanks, Thomas drm-xe-next-2024-10-10: Cross-subsystem Changes: - Add drm_line_printer (Michal) Driver Changes: - Fix an UAF (Matt Auld) - Sanity check compression and coherency mode (Matt Auld) - Some PIC-ID work (Jani) - Use IS_ENABLED(

[PULL] drm-xe-next

2024-10-24 Thread Thomas Hellstrom
Hi, Dave & Simona, This week's drm-xe-next PR Thanks, Thomas drm-xe-next-2024-10-24: UAPI Changes: - Define and parse OA sync properties (Ashutosh) Driver Changes: - Add caller info to xe_gt_reset_async (Nirmoy) - A large forcewake rework / cleanup (Himal) - A g2h response timeout fix (Badal)

[PULL] drm-xe-next

2024-10-31 Thread Thomas Hellstrom
Hi, Dave, Simona This week's drm-xe-next pull request, including also the changes that we decided not to pull last week. Note that this PR introduces a run-time warning when flushing xe workqueues. That is fixed by the patch 746ae46c11137ba21f0c0c68f082a9d8c1222c78 currently present in drm-misc-f

[PULL] drm-xe-next-fixes

2024-11-28 Thread Thomas Hellstrom
Hi Dave, Simona An all-Matt drm-xe-next-fixes PR this week. Thanks, Thomas drm-xe-next-fixes-2024-11-28: Driver Changes: - Update xe2 graphics name string (Matt Roper) - Fix a couple of guc submit races (Matt Auld) - Fix pat index usage in migrate (Matt Auld) - Ensure non-cached migrate pagetabl

[PULL] drm-xe-next-fixes

2024-11-15 Thread Thomas Hellstrom
Hi Dave, Simona A single NULL ptr deref fix this week. Thanks, Thomas drm-xe-next-fixes-2024-11-15: Driver Changes: - Fix a NULL pointer deref (Everest K.C.) The following changes since commit 56b70bf9ec460ad7d7d94dfb7a54a8829741e16e: Merge tag 'drm-misc-next-2024-11-08' of https://gitlab.f

[PULL] drm-xe-fixes

2024-12-04 Thread Thomas Hellstrom
Hi Dave, Simona Two xe fixes for -rc2 Thanks, Thomas drm-xe-fixes-2024-12-04: Driver Changes: - Missing init value and 64-bit write-order check (Zhanjung) - Fix a memory allocation issue causing lockdep violation (John) The following changes since commit 40384c840ea1944d7c5a392e8975ed088ecf0b37:

[PULL] drm-xe-fixes

2024-12-12 Thread Thomas Hellstrom
Dave, Simona This week'd drm-xe-fixes PR. Thanks, Thomas drm-xe-fixes-2024-12-12: - Fix a KUNIT test error message (Mirsad Todorovac) - Fix an invalidation fence PM ref leak (Daniele) - Fix a register pool UAF (Lucas) The following changes since commit 5dce85fecb87751ec94526e1ac516dd7871e2e0c:

[PULL] drm-xe-next-fixes

2024-11-21 Thread Thomas Hellstrom
Hi Dave, Simona A couple of fixes to drm-xe-next. I'm currently looking into as to why they are not CC'd stable and will ensure they get backported if needed. Thanks, Thomas drm-xe-next-fixes-2024-11-21: Driver Changes: - Wake up waiters after wait condition set to true (Nirmoy Das) - Mark the p

[PULL] drm-xe-fixes

2025-01-02 Thread Thomas Hellstrom
Hi Dave, Simona! Happy new year! This PR supersedes the one sent out 24-12-23, since that didn't seem to get pulled over the holidays. There's one extra commit (The OA fixes). The rest of the summary is repeated. Thanks, Thomas drm-xe-fixes-2025-01-02: This supersedes drm-xe-fixes-2024-12-23. U

[PULL] drm-xe-fixes

2024-12-23 Thread Thomas Hellstrom
Hi Dave, Simona The Xe fixes for -rc5. Thanks, Thomas drm-xe-fixes-2024-12-23: UAPI Changes: - Revert some devcoredump file format changes breaking a mesa debug tool (John) Driver Changes: - Fixes around waits when moving to system (Nirmoy) - Fix a typo when checking for LMEM provisioning (Mi

[PULL] drm-xe-fixes

2025-01-09 Thread Thomas Hellstrom
Hi Dave, Simona Two fixes this week. Thanks, Thomas drm-xe-fixes-2025-01-09: Driver Changes: - Avoid a NULL ptr deref when wedging (Lucas) - Fix power gate sequence on DG1 (Rodrigo) The following changes since commit f0ed39830e6064d62f9c5393505677a26569bb56: xe/oa: Fix query mode of operation

[PULL] drm-xe-fixes

2025-01-16 Thread Thomas Hellstrom
Hi Dave, Simona! The hopefully last drm-xe-fixes for 6.13 It's a little bigger than I was hoping for but nothing that really stands out. Thanks, Thomas drm-xe-fixes-2025-01-16: Driver Changes: - Add steering info support for GuC register lists (Jesus Narvaez) - Add means to wait for reset and sy

[PULL] drm-xe-fixes

2025-03-20 Thread Thomas Hellstrom
Hi Dave, Simona! Rodrigo is out this week, but sending a PR for a single fix. Thanks, Thomas drm-xe-fixes-2025-03-20: Driver Changes: - Fix for an error if exporting a dma-buf multiple time (Tomasz) The following changes since commit f5d4e81774c42d9c2ea3980e570f3330ff2ed5d2: drm/xe: remove re