Re: [Intel-gfx] [PATCH 05/18] drm/bochs: Don't grab dev->struct_mutex for in mmap offset ioctl

2015-08-10 Thread Thierry Reding
ed > variant (since the drm core still cares). > > Signed-off-by: Daniel Vetter > --- > drivers/gpu/drm/bochs/bochs_mm.c | 16 > 1 file changed, 4 insertions(+), 12 deletions(-) Reviewed-by: Thierry Reding signature.asc Description: PGP signature

Re: [Intel-gfx] [PATCH 04/18] drm/ast: Don't grab dev->struct_mutex for in mmap offset ioctl

2015-08-10 Thread Thierry Reding
ed > variant (since the drm core still cares). > > Signed-off-by: Daniel Vetter > --- > drivers/gpu/drm/ast/ast_main.c | 16 +--- > 1 file changed, 5 insertions(+), 11 deletions(-) Reviewed-by: Thierry Reding signature.asc Description: PGP signature

Re: [Intel-gfx] [PATCH 07/18] drm/mga200g: Hold a proper reference for cursor_set

2015-08-10 Thread Thierry Reding
it stop grabbing dev->struct_mutex, it doesn't protect > anything here. > > Signed-off-by: Daniel Vetter > --- > drivers/gpu/drm/mgag200/mgag200_cursor.c | 22 ++ > 1 file changed, 10 insertions(+), 12 deletions(-) Reviewed-by: Thierry Redi

Re: [Intel-gfx] [PATCH 06/18] drm/mga200g: Don't grab dev->struct_mutex for in mmap offset ioctl

2015-08-10 Thread Thierry Reding
ed > variant (since the drm core still cares). > > Signed-off-by: Daniel Vetter > --- > drivers/gpu/drm/mgag200/mgag200_main.c | 16 > 1 file changed, 4 insertions(+), 12 deletions(-) Reviewed-by: Thierry Redin

Re: [Intel-gfx] [PATCH 17/18] drm/amdgpu: Don't take dev->struct_mutex in bo_force_delete

2015-08-10 Thread Thierry Reding
adeone/radeon/ Otherwise: Reviewed-by: Thierry Reding signature.asc Description: PGP signature ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH 08/18] drm/cirrus: Don't grab dev->struct_mutex for in mmap offset ioctl

2015-08-10 Thread Thierry Reding
ed > variant (since the drm core still cares). > > Signed-off-by: Daniel Vetter > --- > drivers/gpu/drm/cirrus/cirrus_main.c | 15 --- > 1 file changed, 4 insertions(+), 11 deletions(-) Reviewed-by: Thierry Reding signature.asc Description: PGP signature

Re: [Intel-gfx] [PATCH 09/18] drm/cma-helper: Don't grab dev->struct_mutex for in mmap offset ioctl

2015-08-10 Thread Thierry Reding
ed > variant (since the drm core still cares). > > Cc: Laurent Pinchart > Cc: Rob Clark > Signed-off-by: Daniel Vetter > --- > drivers/gpu/drm/drm_gem_cma_helper.c | 7 +-- > 1 file changed, 1 insertion(+), 6 deletions(-) Reviewed-by: Thierry

Re: [Intel-gfx] [PATCH 10/18] drm/rockchip: Don't grab dev->struct_mutex for in mmap offset ioctl

2015-08-10 Thread Thierry Reding
27;s no guarantee the mmap isn't still around when > gem_free_object is called. Which the kerneldoc of dma_mmap_attrs > explicitly forbids. Same is true for Exynos, which seems to be the source for copy/paste here. Anyway, for this change: Reviewed-b

Re: [Intel-gfx] [PATCH 11/18] drm/armada: Don't grab dev->struct_mutex for in mmap offset ioctl

2015-08-10 Thread Thierry Reding
ed > variant (since the drm core still cares). > > While at it also fix a leak when this ioctl is called on an imported > buffer. > > Cc: Russell King > Signed-off-by: Daniel Vetter > --- > drivers/gpu/drm/armada/armada_gem.c | 11 --- > 1 file changed, 4 i

Re: [Intel-gfx] [PATCH 12/18] drm/nouveau: Don't take dev->struct_mutex in fbcon init

2015-08-10 Thread Thierry Reding
niel Vetter > --- > drivers/gpu/drm/nouveau/nouveau_fbcon.c | 11 +++ > 1 file changed, 3 insertions(+), 8 deletions(-) Reviewed-by: Thierry Reding signature.asc Description: PGP signature ___ Intel-gfx mailing list Intel-gfx@lists.freedes

Re: [Intel-gfx] [PATCH 13/18] drm/nouveau: Don't take dev->struct_mutex in ttm_fini

2015-08-10 Thread Thierry Reding
eau/nouveau_ttm.c | 2 -- > 1 file changed, 2 deletions(-) Reviewed-by: Thierry Reding signature.asc Description: PGP signature ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH 14/18] drm/qxl: Don't take dev->struct_mutex in bo_force_delete

2015-08-10 Thread Thierry Reding
by: Daniel Vetter > --- > drivers/gpu/drm/qxl/qxl_object.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) Reviewed-by: Thierry Reding signature.asc Description: PGP signature ___ Intel-gfx mailing list Intel-gfx@lists.freedesk

Re: [Intel-gfx] [PATCH 15/18] drm/radeon: Don't take dev->struct_mutex in bo_force_delete

2015-08-10 Thread Thierry Reding
" > Signed-off-by: Daniel Vetter > --- > drivers/gpu/drm/radeon/radeon_object.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) Reviewed-by: Thierry Reding signature.asc Description: PGP signature ___ Intel-gfx

Re: [Intel-gfx] [PATCH 16/18] drm/radeon: Don't take dev->struct_mutex in pm functions

2015-08-10 Thread Thierry Reding
: Alex Deucher > Cc: "Christian König" > Signed-off-by: Daniel Vetter > --- > drivers/gpu/drm/radeon/radeon_pm.c | 5 - > 1 file changed, 5 deletions(-) Reviewed-by: Thierry Reding signature.asc Description: PGP signature __

Re: [Intel-gfx] [PATCH 18/18] drm/amdgpu: don't grab dev->struct_mutex in pm functions

2015-08-10 Thread Thierry Reding
code can't race with itself. Which makes struct_mutex completely > redundnant. Remove it. > > Cc: Alex Deucher > Cc: "Christian König" > Signed-off-by: Daniel Vetter > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c | 2 -- > 1 file changed, 2 deletions(-) Re

Re: [Intel-gfx] [PATCH 01/18] drm/gem: rip out drm vma accounting for gem mmaps

2015-08-10 Thread Thierry Reding
On Thu, Jul 09, 2015 at 11:32:33PM +0200, Daniel Vetter wrote: > Doesn't really add anything which can't be figured out through > proc files. And more clearly separates the new gem mmap handling > code from the old drm maps mmap handling code, which is surely a > good thing. > > Cc: Martin Peres

Re: [Intel-gfx] [PATCH 00/18] dev->struct_mutex crusade

2015-08-10 Thread Thierry Reding
On Thu, Jul 09, 2015 at 11:32:32PM +0200, Daniel Vetter wrote: > Hi all, > > I wanted to take another look at struct_mutex usage in modern (gem) drivers > and > noticed that for a fair lot we're very to be completely struct_mutex free. > > This pile here is the the simple part, which mostly just

Re: [Intel-gfx] [PATCH 1/2] drm/tegra: don't take dev->struct_mutex in mmap offset ioctl

2015-08-10 Thread Thierry Reding
On Mon, Aug 10, 2015 at 01:31:42PM +0200, Daniel Vetter wrote: > On Mon, Aug 10, 2015 at 12:30:21PM +0200, Thierry Reding wrote: > > On Wed, Jul 15, 2015 at 03:38:51PM +0200, Daniel Vetter wrote: > > > Since David Herrmann's mmap vma manager rework we don't need to grab

Re: [Intel-gfx] [PATCH] drm/i915: Use CONFIG_DRM_FBDEV_EMULATION

2015-08-10 Thread Thierry Reding
On Mon, Aug 10, 2015 at 01:34:08PM +0200, Daniel Vetter wrote: > Instead of our own duplicated one. This fixes a bug in the driver > unload code if DRM_FBDEV_EMULATION=n but DRM_I915_FBDEV=y because we > try to unregister the nonexistent fbdev drm_framebuffer. > > Cc: Archit Taneja > Cc: Maarten

Re: [Intel-gfx] [PATCH 00/18] dev->struct_mutex crusade

2015-08-10 Thread Thierry Reding
On Mon, Aug 10, 2015 at 12:53:23PM +0100, Chris Wilson wrote: > On Mon, Aug 10, 2015 at 01:35:58PM +0200, Thierry Reding wrote: > > On Thu, Jul 09, 2015 at 11:32:32PM +0200, Daniel Vetter wrote: > > > Hi all, > > > > > > I wanted to take another look

Re: [Intel-gfx] [PATCH 1/2] drm/edid: Use ARRAY_SIZE in drm_add_modes_noedid

2015-08-10 Thread Thierry Reding
struct drm_device *dev = connector->dev; > > - count = sizeof(drm_dmt_modes) / sizeof(struct drm_display_mode); > + count = ARRAY_SIZE(drm_dmt_modes); > if (hdisplay < 0) > hdisplay = 0; > if (vdisplay < 0)

Re: [Intel-gfx] [PATCH 2/2] drm/doc: Update docs about device instance setup

2015-08-10 Thread Thierry Reding
On Mon, Aug 10, 2015 at 11:55:38AM +0200, Daniel Vetter wrote: > ->load is depracated, bus functionst are deprecated and everyone > should use drm_dev_alloc®ister. Why would you want to deprecated ->load()? Even if you use drm_dev_alloc() and drm_dev_register(), there's still use for ->load() beca

Re: [Intel-gfx] [PATCH 2/2] drm/doc: Update docs about device instance setup

2015-08-10 Thread Thierry Reding
On Mon, Aug 10, 2015 at 02:07:49PM +0200, Daniel Vetter wrote: > On Mon, Aug 10, 2015 at 01:59:07PM +0200, Thierry Reding wrote: > > On Mon, Aug 10, 2015 at 11:55:38AM +0200, Daniel Vetter wrote: > > > ->load is depracated, bus functionst are deprecated and everyone > >

[Intel-gfx] [PATCH] drm/i915: Fix build warning on 32-bit

2015-08-14 Thread Thierry Reding
From: Thierry Reding The gtt.stolen_size field is of type size_t, and so should be printed using %zu to avoid build warnings on either 32-bit and 64-bit builds. Signed-off-by: Thierry Reding --- drivers/gpu/drm/i915/i915_gem_stolen.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

Re: [Intel-gfx] linux-next: build warnings after merge of the drm-misc tree

2015-08-14 Thread Thierry Reding
On Fri, Aug 14, 2015 at 03:35:32PM +1000, Stephen Rothwell wrote: > Hi all, > > After merging the drm-misc tree, today's linux-next build (arm > multi_v7_defconfig) produced these warnings: > > drivers/gpu/drm/exynos/exynos_drm_drv.c:290:2: warning: initialization from > incompatible pointer typ

Re: [Intel-gfx] [PATCH 1/7] drm: Renaming DP training vswing pre emph defines

2014-08-26 Thread Thierry Reding
On Fri, Aug 08, 2014 at 04:23:40PM +0530, sonika.jin...@intel.com wrote: > From: Sonika Jindal > > Adding new defines, older one will be removed in the last patch in the series. > This is to rename the defines to have levels instead of values for vswing and > pre-emph levels as the values may dif

Re: [Intel-gfx] [PATCH 1/7] drm: Renaming DP training vswing pre emph defines

2014-08-27 Thread Thierry Reding
On Wed, Aug 27, 2014 at 08:51:35AM +0100, Damien Lespiau wrote: > On Wed, Aug 27, 2014 at 08:47:54AM +0100, Damien Lespiau wrote: > > > An alternative would be to provide a second set of defines for eDP 1.4 > > > where the name implies the meaning and then use them as appropriate. > > > > We went

Re: [Intel-gfx] [PATCH 1/7] drm: Renaming DP training vswing pre emph defines

2014-08-27 Thread Thierry Reding
On Wed, Aug 27, 2014 at 08:47:54AM +0100, Damien Lespiau wrote: > On Tue, Aug 26, 2014 at 01:28:19PM +0200, Thierry Reding wrote: > > On Fri, Aug 08, 2014 at 04:23:40PM +0530, sonika.jin...@intel.com wrote: > > > From: Sonika Jindal > > > > > > Adding new d

Re: [Intel-gfx] [PULL] topic/vblank-rework, take 2

2014-10-08 Thread Thierry Reding
nized page-flips won't work. While at it, get rid of the legacy drm_vblank_pre_modeset() and drm_vblank_post_modeset() calls that are replaced by drm_vblank_on() and drm_vblank_off(). Reported-by: Alexandre Courbot Signed-off-by: Thierry Reding --- drivers/gpu/drm/tegra/dc.c | 7 ++---

Re: [Intel-gfx] [RFC PATCH 0/3] drm driver for baytrail's vxd392

2014-10-14 Thread Thierry Reding
On Mon, Oct 13, 2014 at 08:15:00PM +0800, Yao Cheng wrote: > drm/ipvr is a new GEM driver for baytrail's vxd392, which accelerates VP8 > video decoding. > The driver name "ipvr" means the PowerVR's IP wrapped by Intel. In the > future, ipvr may support other platforms such as Merrifield. > Code i

Re: [Intel-gfx] [RFC PATCH 0/3] drm driver for baytrail's vxd392

2014-10-15 Thread Thierry Reding
On Wed, Oct 15, 2014 at 01:18:02AM -0700, Stéphane Marchesin wrote: > On Wed, Oct 15, 2014 at 1:13 AM, Thierry Reding > wrote: > > > On Tue, Oct 14, 2014 at 08:50:35AM -0700, Sean V Kelley wrote: > > > On Tue, Oct 14, 2014 at 4:53 AM, Thierry Reding > > > wrote

<    1   2   3   4   5