Re: [Intel-gfx] [PATCH 06/28] drm/bridge: Improve kerneldoc

2015-12-07 Thread Thierry Reding
On Fri, Dec 04, 2015 at 09:45:47AM +0100, Daniel Vetter wrote: > Especially document the assumptions and semantics of the callbacks > carefully. Just a warm-up excercise really. > > v2: Spelling fixes (Eric). > > v3: Consolidate more with existing docs: > > - Remove the overview section explaini

Re: [Intel-gfx] [PATCH 07/28] drm: Update drm_plane_funcs kerneldoc

2015-12-07 Thread Thierry Reding
On Fri, Dec 04, 2015 at 09:45:48AM +0100, Daniel Vetter wrote: > diff --git a/include/drm/drm_crtc.h b/include/drm/drm_crtc.h [...] > + /** > + * @destroy: > + * > + * Clean up CRTC resources. This is only called at driver unload time Perhaps drop "only" because there are more t

Re: [Intel-gfx] [PATCH 08/28] drm/noveau: Ditch NULL save/restore hook assignments

2015-12-07 Thread Thierry Reding
On Fri, Dec 04, 2015 at 09:45:49AM +0100, Daniel Vetter wrote: > gcc does this for us, and these hooks will be gone soon. In the subject: s/noveau/nouveau/, otherwise: Reviewed-by: Thierry Reding signature.asc Description: PGP signature ___ In

Re: [Intel-gfx] [PATCH 09/28] drm/qxl: Drop dummy save/restore hooks

2015-12-07 Thread Thierry Reding
On Fri, Dec 04, 2015 at 09:45:50AM +0100, Daniel Vetter wrote: > These hooks will be gone soon. > > Cc: Dave Airlie > Signed-off-by: Daniel Vetter > --- > drivers/gpu/drm/qxl/qxl_display.c | 12 > 1 file changed, 12 deletions(-) Reviewed-by: Thierry Re

Re: [Intel-gfx] [PATCH 10/28] drm/virtio: Drop dummy save/restore functions

2015-12-07 Thread Thierry Reding
On Fri, Dec 04, 2015 at 09:45:51AM +0100, Daniel Vetter wrote: > These hooks will be gone soon. > > Cc: Dave Airlie > Signed-off-by: Daniel Vetter > --- > drivers/gpu/drm/virtio/virtgpu_display.c | 12 > 1 file changed, 12 deletions(-) Reviewed-by: Thierry Re

Re: [Intel-gfx] [PATCH 11/28] drm/vmwgfx: Drop dummy save/restore hooks

2015-12-07 Thread Thierry Reding
drivers/gpu/drm/vmwgfx/vmwgfx_scrn.c | 4 > drivers/gpu/drm/vmwgfx/vmwgfx_stdu.c | 4 > 4 files changed, 28 deletions(-) Reviewed-by: Thierry Reding signature.asc Description: PGP signature ___ Intel-gfx mailing list Intel-

Re: [Intel-gfx] [PATCH 12/28] drm/gma500: Move to private save/restore hooks

2015-12-07 Thread Thierry Reding
rm/gma500/psb_intel_display.c | 2 -- > drivers/gpu/drm/gma500/psb_intel_drv.h | 3 +++ > drivers/gpu/drm/gma500/psb_intel_lvds.c| 5 +++-- > drivers/gpu/drm/gma500/psb_intel_sdvo.c| 5 +++-- > drivers/gpu/drm/vmwgfx/vmwgfx_scrn.c | 2 -- > 14 files

Re: [Intel-gfx] [PATCH] drm/nouveau: Use private save/restore hooks for CRTCs

2015-12-07 Thread Thierry Reding
insertions(+), 7 deletions(-) Looks good to me: Reviewed-by: Thierry Reding signature.asc Description: PGP signature ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH 01/28] drm: Polish fbdev helper struct docs

2015-12-07 Thread Thierry Reding
On Mon, Dec 07, 2015 at 12:50:24PM +0100, Daniel Vetter wrote: > On Mon, Dec 07, 2015 at 11:45:22AM +0100, Thierry Reding wrote: > > On Fri, Dec 04, 2015 at 09:45:42AM +0100, Daniel Vetter wrote: > > > Mostly this is just adding extensive docs for the callbacks, but also

Re: [Intel-gfx] [PATCH 14/28] drm: Remove crtc/connector->save/restore hooks

2015-12-07 Thread Thierry Reding
.h | 11 --- > 1 file changed, 11 deletions(-) Reviewed-by: Thierry Reding signature.asc Description: PGP signature ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH] drm: Move encoder->save/restore into nouveau

2015-12-07 Thread Thierry Reding
- > drivers/gpu/drm/nouveau/dispnv04/tvnv04.c | 5 +++-- > drivers/gpu/drm/nouveau/dispnv04/tvnv17.c | 5 +++-- > drivers/gpu/drm/nouveau/nouveau_encoder.h | 3 +++ > include/drm/drm_modeset_helper_vtables.h | 4 > 7 files changed, 27 insertions(+), 36 deletions(-) R

Re: [Intel-gfx] [PATCH 16/28] drm: Document drm_atomic_*_get_property

2015-12-07 Thread Thierry Reding
erty value from CRTC state > + * @crtc: the drm CRTC to set a property on > + * @state: the state object to get the property value from > + * @property: the property to set > + * @val: pointer to where the value should be written to Nit: I find this difficult to write and read, a

Re: [Intel-gfx] [PATCH 17/28] drm: Document drm_connector_funcs

2015-12-07 Thread Thierry Reding
gned-off-by: Daniel Vetter > --- > include/drm/drm_crtc.h | 84 > -- > 1 file changed, 74 insertions(+), 10 deletions(-) Reviewed-by: Thierry Reding signature.asc Description: PGP signature

Re: [Intel-gfx] [PATCH 18/28] drm: connector->dpms is not optional

2015-12-07 Thread Thierry Reding
m_connector_funcs we have, no > one botched this ;-) > > Signed-off-by: Daniel Vetter > --- > drivers/gpu/drm/drm_crtc.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) Reviewed-by: Thierry Reding signature.asc Description: PGP signature ___

Re: [Intel-gfx] [PATCH 19/28] drm: document drm_crtc_funcs

2015-12-07 Thread Thierry Reding
nding events in their > + * ->preclose driver function. > + * > + * This callback is optional. > + * > + * NOTE: > + * > + * Very early versions of the KMS ABI mandated that the driver must > + * block (but not reject) any rendering to t

Re: [Intel-gfx] [PATCH 03/28] drm: Reorganize helper vtables and their docs

2015-12-07 Thread Thierry Reding
On Mon, Dec 07, 2015 at 12:59:33PM +0100, Daniel Vetter wrote: > On Mon, Dec 07, 2015 at 12:00:09PM +0100, Thierry Reding wrote: > > On Fri, Dec 04, 2015 at 09:45:44AM +0100, Daniel Vetter wrote: > > [...] > > > diff --git a/drivers/gpu/drm/drm_crtc_helper.c

Re: [Intel-gfx] [PATCH 20/28] drm: Add kerneldoc for drm_framebuffer_funcs

2015-12-07 Thread Thierry Reding
I'd drop "(yet) " because of "currently". > + * > + * See documentation in drm_mode.h for the struct drm_mode_fb_dirty_cmd > + * for more information as all the semantics and arguments have a one to > + * one mapping on this fun

Re: [Intel-gfx] [PATCH 07/28] drm: Update drm_plane_funcs kerneldoc

2015-12-07 Thread Thierry Reding
On Mon, Dec 07, 2015 at 01:34:16PM +0100, Daniel Vetter wrote: > On Mon, Dec 07, 2015 at 12:46:38PM +0100, Thierry Reding wrote: > > On Fri, Dec 04, 2015 at 09:45:48AM +0100, Daniel Vetter wrote: > > > diff --git a/include/drm/drm_crtc.h b/incl

Re: [Intel-gfx] [PATCH 21/28] drm: Kerneldoc for drm_mode_config_funcs

2015-12-07 Thread Thierry Reding
On Fri, Dec 04, 2015 at 09:46:02AM +0100, Daniel Vetter wrote: [...] > diff --git a/include/drm/drm_crtc.h b/include/drm/drm_crtc.h [...] > struct drm_mode_config_funcs { > + /** > + * @fb_create: > + * > + * Create a new framebuffer object. The core does basic checks on the > +

Re: [Intel-gfx] [PATCH 22/28] drm/atomic-helper: Reject attempts at re-stealing encoders

2015-12-07 Thread Thierry Reding
On Fri, Dec 04, 2015 at 09:46:03AM +0100, Daniel Vetter wrote: > This can happen when we run out of encoders for a multi-crtc modeset, > or also when userspace is silly and tries to clone multiple connectors > that need the same encoder on the same crtc. > > Reported-and-Tested-and-Reviewed-by: Ma

Re: [Intel-gfx] [PATCH 23/28] drm: Document drm_plane_helper_funcs

2015-12-07 Thread Thierry Reding
On Fri, Dec 04, 2015 at 09:46:04AM +0100, Daniel Vetter wrote: > Plus related hooks used to do atomic plane updates since they only > really make sense as a package. > > Signed-off-by: Daniel Vetter > --- > include/drm/drm_modeset_helper_vtables.h | 209 > +-- > 1 fi

Re: [Intel-gfx] [PATCH 24/28] drm: Document drm_connector_helper_funcs

2015-12-07 Thread Thierry Reding
On Fri, Dec 04, 2015 at 09:46:05AM +0100, Daniel Vetter wrote: > Nothing special, except the somewhat awkard split in probe helper "awkward" > callbacks between here and drm_crtc_funcs. > > Signed-off-by: Daniel Vetter > --- > include/drm/drm_modeset_helper_vtables.h | 106 > +

Re: [Intel-gfx] [PATCH 25/28] drm/atomic-helper: Mention the new system/resume helpers the docs

2015-12-07 Thread Thierry Reding
sertions(+) Reviewed-by: Thierry Reding signature.asc Description: PGP signature ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH 26/28] drm: Move drm_display_mode an related docs into kerneldoc

2015-12-07 Thread Thierry Reding
On Fri, Dec 04, 2015 at 09:46:07AM +0100, Daniel Vetter wrote: [...] > diff --git a/include/drm/drm_modes.h b/include/drm/drm_modes.h [...] > @@ -96,17 +141,124 @@ enum drm_mode_status { > > #define DRM_MODE_FLAG_3D_MAX DRM_MODE_FLAG_3D_SIDE_BY_SIDE_HALF > > +/** > + * struct drm_display_mode

Re: [Intel-gfx] [PATCH 27/28] drm: Document drm_encoder/crtc_helper_funcs

2015-12-07 Thread Thierry Reding
On Fri, Dec 04, 2015 at 09:46:08AM +0100, Daniel Vetter wrote: > Mostly this is about all the callbacks used to modesets by both legacy "used for modesets"? > CRTC helpers and atomic helpers and I figured it doesn't make all that > much sense to split this up. > > Signed-off-by: Daniel Vetter >

Re: [Intel-gfx] [PATCH 28/28] drm/atomic-helper: Reject legacy flips on a disabled pipe

2015-12-07 Thread Thierry Reding
On Fri, Dec 04, 2015 at 09:46:09AM +0100, Daniel Vetter wrote: > We want this for consistency with existing page_flip semantics. > > Since this spurred quite a discussion on IRC also document why we > reject even generation when the pipe is off: It's not that it's hard > to implement, but userspac

Re: [Intel-gfx] [PATCH 24/28] drm: Document drm_connector_helper_funcs

2015-12-07 Thread Thierry Reding
On Mon, Dec 07, 2015 at 03:48:37PM +0100, Daniel Vetter wrote: > On Mon, Dec 07, 2015 at 03:42:22PM +0100, Thierry Reding wrote: > > On Fri, Dec 04, 2015 at 09:46:05AM +0100, Daniel Vetter wrote: > > > Nothing special, except the somewhat awkard split in probe helper

Re: [Intel-gfx] [PATCH] drm: Documentation style guide

2015-12-14 Thread Thierry Reding
turns" explaining the expected return values in > + different cases and their meanings. Currently there's no consensus > whether > + that section name should be all upper-case or not, and whether it > should > + end in a colon or not. Go with the file-local s

Re: [Intel-gfx] [PATCH 3/5] drm: Move more framebuffer doc from docbook to kerneldoc

2015-12-14 Thread Thierry Reding
data, which > + * should by done by calling drm_helper_mode_fill_fb_struct(). "should be done" > + * > + * The initializing is finalized by calling drm_framebuffer_init(), "The initialization" Other than that, looks good: Reviewed-by: Thierry Reding sig

Re: [Intel-gfx] [PATCH 2/5] drm/atomic-helper: Drop unneeded argument from check_pending_encoder

2015-12-14 Thread Thierry Reding
7;s > a conflict or not. > > Reported-by: Thierry Reding > Cc: Thierry Reding > Signed-off-by: Daniel Vetter > --- > drivers/gpu/drm/drm_atomic_helper.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) Reviewed-by: Thierry Reding

Re: [Intel-gfx] [PATCH 2/2] pwm: lpss: Add get_state callback

2016-12-04 Thread Thierry Reding
On Fri, Dec 02, 2016 at 11:17:36AM +0100, Hans de Goede wrote: > Add a get_state callback so that the initial state correctly reflects > the actual hardware state. > > Signed-off-by: Hans de Goede > --- > drivers/pwm/pwm-lpss.c | 28 > 1 file changed, 28 insertions(+

Re: [Intel-gfx] [PATCH 1/2] pwm: lpss: Make builtin and add lookup-table so that i915 can find the pwm_backlight

2016-12-04 Thread Thierry Reding
On Fri, Dec 02, 2016 at 11:17:35AM +0100, Hans de Goede wrote: > The primary consumer of the lpss pwm is the i915 kms driver, but > currently that driver cannot get the pwm because i915 platforms are > not using devicetree and pwm-lpss does not call pwm_add_table. > > Another problem is that i915

Re: [Intel-gfx] [PATCH 1/2] pwm: lpss: Make builtin and add lookup-table so that i915 can find the pwm_backlight

2016-12-05 Thread Thierry Reding
On Mon, Dec 05, 2016 at 09:18:03AM +0100, Hans de Goede wrote: > Hi, > > On 05-12-16 08:46, Thierry Reding wrote: > > On Fri, Dec 02, 2016 at 11:17:35AM +0100, Hans de Goede wrote: > > > The primary consumer of the lpss pwm is the i915 kms driver, but > > > cur

Re: [Intel-gfx] [PATCH] drm: parse hf-vsdb

2016-12-05 Thread Thierry Reding
On Tue, Nov 29, 2016 at 08:24:39PM +0530, Shashank Sharma wrote: > HDMI 2.0 / CEA-861-F specs define a new CEA extension data block, > called hdmi-forum vendor specific data block (HF-VSDB). This block > contains information about sink's support for HDMI 2.0 compliant > features. These features are

Re: [Intel-gfx] [PATCH] mfd: intel_soc_pmic_core: Terminate panel control GPIO lookup table correctly

2016-04-25 Thread Thierry Reding
> Cc: Linus Walleij > Cc: Alexandre Courbot > Cc: Thierry Reding > Cc: Lee Jones > Cc: sta...@vger.kernel.org > Fixes: 61dd2ca2d44e ("mfd: intel_soc_pmic_core: Add lookup table for Panel > Control as GPIO signal") > Signed-off-by: Ville Syrjälä > --- > driv

Re: [Intel-gfx] [PATCH 27/35] drm/tegra: Use lockless gem BO free callback

2016-05-10 Thread Thierry Reding
On Tue, Apr 26, 2016 at 07:30:00PM +0200, Daniel Vetter wrote: > No dev->struct_mutex anywhere to be seen. > > Cc: Thierry Reding > Cc: Terje Bergström > Cc: linux-te...@vger.kernel.org > Signed-off-by: Daniel Vetter > --- > drivers/gpu/drm/tegra/drm.c | 2 +- >

Re: [Intel-gfx] [PATCH 10/10] drm/tegra: Don't set a gamma table size

2016-03-30 Thread Thierry Reding
On Wed, Mar 30, 2016 at 11:51:25AM +0200, Daniel Vetter wrote: > tegra doesn't have any functions to set gamma tables, so this is > completely defunct. > > Not nice to lie to userspace, so let's stop! > > Cc: Thierry Reding > Signed-off-by: Daniel Vetter > ---

Re: [Intel-gfx] [PATCH 05/10] drm: Give drm_agp_clear drm_legacy_ prefix

2016-03-30 Thread Thierry Reding
On Wed, Mar 30, 2016 at 06:09:04PM +0800, kbuild test robot wrote: > Hi Daniel, > > [auto build test ERROR on drm/drm-next] > [also build test ERROR on v4.6-rc1 next-20160330] > [if your patch is applied to the wrong git tree, please drop us a note to > help improving the system] > > url: >

Re: [Intel-gfx] [PATCH 06/10] drm: Put legacy lastclose work into drm_legacy_dev_reinit

2016-03-30 Thread Thierry Reding
On Wed, Mar 30, 2016 at 11:45:16AM +0200, Daniel Vetter wrote: [...] > diff --git a/include/drm/drm_agpsupport.h b/include/drm/drm_agpsupport.h > index e134e9ca422b..b2d912670a7f 100644 > --- a/include/drm/drm_agpsupport.h > +++ b/include/drm/drm_agpsupport.h > @@ -93,7 +93,7 @@ static inline struc

Re: [Intel-gfx] [PATCH 10/10] drm/tegra: Don't set a gamma table size

2016-03-31 Thread Thierry Reding
On Wed, Mar 30, 2016 at 11:51:25AM +0200, Daniel Vetter wrote: > tegra doesn't have any functions to set gamma tables, so this is > completely defunct. > > Not nice to lie to userspace, so let's stop! > > Cc: Thierry Reding > Signed-off-by: Daniel Vetter > ---

Re: [Intel-gfx] [PATCH v5 08/46] hwmon: pwm-fan: use pwm_get_args() where appropriate

2016-04-04 Thread Thierry Reding
On Thu, Mar 31, 2016 at 09:07:09AM +0200, Boris Brezillon wrote: > Hi Guenter, > > On Wed, 30 Mar 2016 15:52:44 -0700 > Guenter Roeck wrote: > > > On Wed, Mar 30, 2016 at 10:03:31PM +0200, Boris Brezillon wrote: > > > The PWM framework has clarified the concept of reference PWM config > > > (the

Re: [Intel-gfx] [PATCH v5 32/46] pwm: deprecate pwm_config(), pwm_enable() and pwm_disable()

2016-04-04 Thread Thierry Reding
On Thu, Mar 31, 2016 at 08:54:54PM +0200, Boris Brezillon wrote: > Hi Dmitry, > > On Thu, 31 Mar 2016 10:38:58 -0700 > Dmitry Torokhov wrote: > > > Hi Boris, > > > > On Wed, Mar 30, 2016 at 10:03:55PM +0200, Boris Brezillon wrote: > > > Prefix those function as deprecated to encourage all exist

Re: [Intel-gfx] [PATCH v5 34/46] clk: pwm: switch to the atomic API

2016-04-04 Thread Thierry Reding
On Thu, Mar 31, 2016 at 08:57:35AM +0200, Boris Brezillon wrote: > Hi Stephen, > > On Wed, 30 Mar 2016 15:01:49 -0700 > Stephen Boyd wrote: > > > On 03/30, Boris Brezillon wrote: > > > diff --git a/drivers/clk/clk-pwm.c b/drivers/clk/clk-pwm.c > > > index ebcd738..49ec5b1 100644 > > > --- a/driv

Re: [Intel-gfx] [PATCH v5 36/46] input: misc: max77693: switch to the atomic API

2016-04-04 Thread Thierry Reding
On Thu, Mar 31, 2016 at 08:57:18PM +0200, Boris Brezillon wrote: > On Thu, 31 Mar 2016 10:48:01 -0700 > Dmitry Torokhov wrote: > > > Hi Boris, > > > > On Wed, Mar 30, 2016 at 10:03:59PM +0200, Boris Brezillon wrote: > > > pwm_config/enable/disable() have been deprecated and should be replaced >

Re: [Intel-gfx] [PATCH v5 01/46] pwm: rcar: make use of pwm_is_enabled()

2016-04-12 Thread Thierry Reding
On Wed, Mar 30, 2016 at 10:03:24PM +0200, Boris Brezillon wrote: > Commit 5c31252c4a86 ("pwm: Add the pwm_is_enabled() helper") introduced a > new function to test whether a PWM device is enabled or not without > manipulating PWM internal fields. > Hiding this is necessary if we want to smoothly mo

Re: [Intel-gfx] [PATCH v5 02/46] backlight: pwm_bl: remove useless call to pwm_set_period()

2016-04-12 Thread Thierry Reding
On Wed, Mar 30, 2016 at 10:03:25PM +0200, Boris Brezillon wrote: > The PWM period will be set when calling pwm_config. Remove this useless > call to pwm_set_period(), which might mess up with the internal PWM state. > > Signed-off-by: Boris Brezillon > Acked-by: Lee Jones > --- > drivers/video/

Re: [Intel-gfx] [PATCH v5 03/46] backlight: lm3630a_bl: stop messing with the pwm->period field

2016-04-12 Thread Thierry Reding
On Wed, Mar 30, 2016 at 10:03:26PM +0200, Boris Brezillon wrote: > pwm->period field is not supposed to be changed by PWM users. The only > ones authorized to change it are the PWM core and PWM drivers. > > Signed-off-by: Boris Brezillon > --- > drivers/video/backlight/lm3630a_bl.c | 3 +-- > 1

Re: [Intel-gfx] [PATCH v5 04/46] pwm: get rid of pwm->lock

2016-04-12 Thread Thierry Reding
On Wed, Mar 30, 2016 at 10:03:27PM +0200, Boris Brezillon wrote: > PWM devices are not protected against concurrent accesses. The lock in > pwm_device might let PWM users think it is, but it's actually only > protecting the enabled state. > > Removing this lock should be fine as long as all PWM us

Re: [Intel-gfx] [PATCH v5 05/46] pwm: introduce the pwm_args concept

2016-04-12 Thread Thierry Reding
On Wed, Mar 30, 2016 at 10:03:28PM +0200, Boris Brezillon wrote: > Currently the PWM core mixes the current PWM state with the per-platform > reference config (specified through the PWM lookup table, DT definition or > directly hardcoded in PWM drivers). > > Create a pwm_args struct to store this

Re: [Intel-gfx] [PATCH v5 04/46] pwm: get rid of pwm->lock

2016-04-12 Thread Thierry Reding
On Tue, Apr 12, 2016 at 01:32:55PM +0200, Boris Brezillon wrote: > Hi Thierry, > > On Tue, 12 Apr 2016 13:22:46 +0200 > Thierry Reding wrote: > > > On Wed, Mar 30, 2016 at 10:03:27PM +0200, Boris Brezillon wrote: > > > PWM devices are not protected against co

Re: [Intel-gfx] [PATCH v5 15/46] pwm: introduce the pwm_state concept

2016-04-12 Thread Thierry Reding
On Wed, Mar 30, 2016 at 10:03:38PM +0200, Boris Brezillon wrote: > The PWM state, represented by its period, duty_cycle and polarity, > is currently directly stored in the PWM device. > Declare a pwm_state structure embedding those field so that we can later > use this struct to atomically update a

Re: [Intel-gfx] [PATCH v5 16/46] pwm: move the enabled/disabled info into pwm_state

2016-04-12 Thread Thierry Reding
On Wed, Mar 30, 2016 at 10:03:39PM +0200, Boris Brezillon wrote: [...] > @@ -145,7 +146,11 @@ static inline void pwm_get_state(const struct pwm_device > *pwm, > > static inline bool pwm_is_enabled(const struct pwm_device *pwm) > { > - return test_bit(PWMF_ENABLED, &pwm->flags); > + str

Re: [Intel-gfx] [PATCH v5 05/46] pwm: introduce the pwm_args concept

2016-04-12 Thread Thierry Reding
On Tue, Apr 12, 2016 at 02:04:12PM +0200, Boris Brezillon wrote: > On Tue, 12 Apr 2016 13:39:12 +0200 > Thierry Reding wrote: > > > On Wed, Mar 30, 2016 at 10:03:28PM +0200, Boris Brezillon wrote: > > > Currently the PWM core mixes the current PWM state with the per-

Re: [Intel-gfx] [PATCH v5 15/46] pwm: introduce the pwm_state concept

2016-04-12 Thread Thierry Reding
On Tue, Apr 12, 2016 at 02:17:18PM +0200, Boris Brezillon wrote: > On Tue, 12 Apr 2016 13:49:04 +0200 > Thierry Reding wrote: > > > On Wed, Mar 30, 2016 at 10:03:38PM +0200, Boris Brezillon wrote: > > > The PWM state, represented by its period, duty_cycle and pola

Re: [Intel-gfx] [PATCH v5 15/46] pwm: introduce the pwm_state concept

2016-04-12 Thread Thierry Reding
On Tue, Apr 12, 2016 at 02:45:08PM +0200, Boris Brezillon wrote: > On Tue, 12 Apr 2016 14:21:41 +0200 > Thierry Reding wrote: > > > On Tue, Apr 12, 2016 at 02:17:18PM +0200, Boris Brezillon wrote: > > > On Tue, 12 Apr 2016 13:49:04 +0200 > > > Thierry Reding wro

Re: [Intel-gfx] [PATCH v5 05/46] pwm: introduce the pwm_args concept

2016-04-12 Thread Thierry Reding
On Tue, Apr 12, 2016 at 03:06:27PM +0200, Boris Brezillon wrote: > On Tue, 12 Apr 2016 13:39:12 +0200 > Thierry Reding wrote: > > > On Wed, Mar 30, 2016 at 10:03:28PM +0200, Boris Brezillon wrote: > > > Currently the PWM core mixes the current PWM state with the per-

Re: [Intel-gfx] [PATCH v5 15/46] pwm: introduce the pwm_state concept

2016-04-12 Thread Thierry Reding
On Tue, Apr 12, 2016 at 03:26:44PM +0200, Boris Brezillon wrote: > On Tue, 12 Apr 2016 15:11:18 +0200 > Thierry Reding wrote: > > > On Tue, Apr 12, 2016 at 02:45:08PM +0200, Boris Brezillon wrote: > > > On Tue, 12 Apr 2016 14:21:41 +0200 > > > Thierry Reding wro

Re: [Intel-gfx] [PATCH v5 02/46] backlight: pwm_bl: remove useless call to pwm_set_period()

2016-04-12 Thread Thierry Reding
On Tue, Apr 12, 2016 at 03:16:53PM +0100, Lee Jones wrote: > On Tue, 12 Apr 2016, Thierry Reding wrote: > > > On Wed, Mar 30, 2016 at 10:03:25PM +0200, Boris Brezillon wrote: > > > The PWM period will be set when calling pwm_config. Remove this useless > > > call to

Re: [Intel-gfx] [PATCH v5 03/46] backlight: lm3630a_bl: stop messing with the pwm->period field

2016-04-12 Thread Thierry Reding
On Tue, Apr 12, 2016 at 03:16:13PM +0100, Lee Jones wrote: > On Tue, 12 Apr 2016, Thierry Reding wrote: > > > On Wed, Mar 30, 2016 at 10:03:26PM +0200, Boris Brezillon wrote: > > > pwm->period field is not supposed to be changed by PWM users. The only > > > one

Re: [Intel-gfx] [PATCH v2 2/3] pwm/core: Try to get the module from pwm_get

2017-01-30 Thread Thierry Reding
On Sun, Jan 22, 2017 at 05:14:08PM +0100, Hans de Goede wrote: > Add a module_name string to the pwm_lookup struct and if specified > and pwmchip_find_by_name() does not find the pwmchip try calling > request_module with the specified name. > > Signed-off-by: Hans de Goede > --- > drivers/pwm/co

Re: [Intel-gfx] [PATCH v2 3/3] acpi: lpss: call pwm_add_table() for bsw PWM device

2017-01-30 Thread Thierry Reding
cklight") call returns the lpss' pwm0. > > The PWM subsystem does not want to have pwm_add_table() calls > directly in PWM drivers (this leads to probe ordering issues), > so lets do it here since the acpi-lpss code is always builtin. > > Signed-off-by: Hans de Goede

Re: [Intel-gfx] [PATCH v2 3/3] acpi: lpss: call pwm_add_table() for bsw PWM device

2017-01-30 Thread Thierry Reding
On Mon, Jan 30, 2017 at 11:33:10AM +0200, Mika Westerberg wrote: > On Mon, Jan 30, 2017 at 09:28:09AM +0100, Rafael J. Wysocki wrote: > > On Mon, Jan 30, 2017 at 9:18 AM, Thierry Reding > > wrote: > > > On Sun, Jan 22, 2017 at 05:14:09PM +0100, Hans de Goede wrote: >

Re: [Intel-gfx] [PATCH 3/6] drm/edid: detect SCDC support in HF-VSDB

2017-02-01 Thread Thierry Reding
bool scdc_rr; > }; > > /** > @@ -188,6 +209,11 @@ struct drm_display_info { >* @cea_rev: CEA revision of the HDMI sink. >*/ > u8 cea_rev; > + > + /** > + * @hdmi_info: advance features of a HDMI sink. > + */ > + struc

Re: [Intel-gfx] [PATCH 4/6] drm: scrambling support in drm layer

2017-02-01 Thread Thierry Reding
On Wed, Feb 01, 2017 at 06:14:39PM +0530, Shashank Sharma wrote: > HDMI 2.0 spec mandates scrambling for modes with pixel clock higher > than 340Mhz. This patch adds few new functions in drm layer for > core drivers to enable/disable scrambling. > > This patch adds: > - A function to detect scramb

Re: [Intel-gfx] [PATCH 3/6] drm/edid: detect SCDC support in HF-VSDB

2017-02-02 Thread Thierry Reding
On Thu, Feb 02, 2017 at 10:58:43AM +0530, Sharma, Shashank wrote: > Thanks for the review Thierry. My comments inline. > > Regards > Shashank > On 2/1/2017 9:40 PM, Thierry Reding wrote: > > On Wed, Feb 01, 2017 at 06:14:38PM +0530, Shashank Sharma wrote: > >

Re: [Intel-gfx] [PATCH 4/6] drm: scrambling support in drm layer

2017-02-02 Thread Thierry Reding
On Thu, Feb 02, 2017 at 11:08:22AM +0530, Sharma, Shashank wrote: > Regards > > Shashank > > > On 2/1/2017 10:02 PM, Thierry Reding wrote: > > On Wed, Feb 01, 2017 at 06:14:39PM +0530, Shashank Sharma wrote: > > > HDMI 2.0 spec mandates scrambling for modes w

Re: [Intel-gfx] [PATCH v2 3/6] drm/edid: detect SCDC support in HF-VSDB

2017-02-07 Thread Thierry Reding
request supported) etc in it. > > > > > > Ville: > > > - Change rr -> read_request > > > - Call drm_detect_scrambling function drm_parse_hf_vsdb so that all > > >of HF-VSDB parsing can be kept in same function, in incremental > > >patches.

Re: [Intel-gfx] [PATCH] drm: Reduce EDID warnings from DRM_ERROR to DRM_NOTE

2017-02-12 Thread Thierry Reding
On Fri, Feb 10, 2017 at 07:59:13PM +, Chris Wilson wrote: > The warnings from parsing the EDID are not driver errors, but the > "normal but significant" conditions from the external device. As such, > they do not need the ferocity of an *ERROR*, but can use the less harsh > DRM_NOTE instead. >

Re: [Intel-gfx] [PATCH] drm/docs: more leftovers from the big vtable documentation pile

2015-12-28 Thread Thierry Reding
t; Cc: Laurent Pinchart > Cc: Thierry Reding > Signed-off-by: Daniel Vetter > --- > Documentation/DocBook/gpu.tmpl | 188 > --- > include/drm/drm_modeset_helper_vtables.h | 28 - > 2 files changed, 25 insertions(+), 191 deletion

Re: [Intel-gfx] [PATCH v5 2/2] drm/i915: Check DP no aux transaction bit on link training

2016-01-04 Thread Thierry Reding
On Tue, Dec 22, 2015 at 04:53:41PM +0100, Lukas Wunner wrote: > Hi Mika, > > On Mon, Dec 21, 2015 at 01:39:15PM +0200, Mika Kahola wrote: > > Check if no AUX transactions are required on DP link training. > > If this bit is set, we can reuse the known good drive current > > and pre-emphasis level

Re: [Intel-gfx] [PATCH] drm/docs: more leftovers from the big vtable documentation pile

2016-01-05 Thread Thierry Reding
On Mon, Jan 04, 2016 at 07:53:36AM +0100, Daniel Vetter wrote: > Another pile of vfuncs from the old gpu.tmpl xml documentation that > I've forgotten to delete. I spotted a few more things to > clarify/extend in the new kerneldoc while going through this once > more. > > v2: Spelling fixes (Thierr

Re: [Intel-gfx] [PATCH] drm/docs: more leftovers from the big vtable documentation pile

2016-01-05 Thread Thierry Reding
On Mon, Jan 04, 2016 at 07:49:41AM +0100, Daniel Vetter wrote: > On Mon, Dec 28, 2015 at 11:22:52AM +0100, Thierry Reding wrote: > > On Wed, Dec 16, 2015 at 06:18:25PM +0100, Daniel Vetter wrote: > > > Another pile of vfuncs from the old gpu.tmpl xml documentation that >

Re: [Intel-gfx] [PATCH 19/22] drm/tegra: Stop cancelling page flip events

2016-01-13 Thread Thierry Reding
On Mon, Jan 11, 2016 at 10:41:13PM +0100, Daniel Vetter wrote: > The core takes care of that now. > > v2: Fixup misplaced hunk. > > Cc: Thierry Reding > Cc: Terje Bergström > Acked-by: Daniel Stone > Reviewed-by: Alex Deucher > Signed-off-by: Daniel Vetter >

Re: [Intel-gfx] [PATCH v3 01/14] drm: add HDMI 2.0 VIC support for AVI info-frames

2017-06-14 Thread Thierry Reding
On Wed, Jun 14, 2017 at 11:17:32PM +0530, Shashank Sharma wrote: [...] > diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c > index 2e55599..d312fe1 100644 > --- a/drivers/gpu/drm/drm_edid.c > +++ b/drivers/gpu/drm/drm_edid.c > @@ -4334,12 +4334,14 @@ EXPORT_SYMBOL(drm_set_preferr

Re: [Intel-gfx] [PATCH 10/37] drm/doc: vblank cleanup

2017-06-15 Thread Thierry Reding
(). Given all of the above, for the series: Acked-by: Thierry Reding signature.asc Description: PGP signature ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH 33/37] drm/tegra: Drop drm_vblank_cleanup

2017-06-15 Thread Thierry Reding
On Wed, May 24, 2017 at 04:52:08PM +0200, Daniel Vetter wrote: > Again, doesn't seem to serve a purpose. > > Cc: Thierry Reding > Signed-off-by: Daniel Vetter > --- > drivers/gpu/drm/tegra/drm.c | 5 + > 1 file changed, 1 insertion(+), 4 deletions(-) I'm

[Intel-gfx] [maintainer-tools PATCH] dim: Add apply and push shorthands for current branch

2017-07-31 Thread Thierry Reding
From: Thierry Reding The new apply and push commands are shorthands for applying patches to and pushing the current branch, respectively. Signed-off-by: Thierry Reding --- dim | 27 +++ dim.rst | 8 2 files changed, 35 insertions(+) diff --git a/dim b

[Intel-gfx] [maintainer-tools PATCH v2 1/2] dim: Add apply and push shorthands for current branch

2017-07-31 Thread Thierry Reding
From: Thierry Reding The new apply and push commands are shorthands for applying patches to and pushing the current branch, respectively. v2: use git symbolic-ref to find current branch (Daniel Vetter) Signed-off-by: Thierry Reding --- dim | 18 ++ dim.rst | 8

[Intel-gfx] [maintainer-tools PATCH 2/2] dim: Simplify test for current branch

2017-07-31 Thread Thierry Reding
From: Thierry Reding Instead of listing branches and grepping for the current branch, simply read the name of the current branch and compare. Suggested-by: Daniel Vetter Signed-off-by: Thierry Reding --- dim | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dim b/dim index

Re: [Intel-gfx] [PATCH 06/18] drm: use ARRAY_SIZE

2017-10-02 Thread Thierry Reding
gpu/drm/nouveau/nvkm/subdev/bios/init.c | 7 --- > drivers/gpu/drm/via/via_verifier.c | 10 ++++-- > 6 files changed, 24 insertions(+), 23 deletions(-) Reviewed-by: Thierry Reding signature.asc Description: PGP signature ___

Re: [Intel-gfx] [PATCH 0/7] drm/edid and drivers: ELD refactoring

2017-11-06 Thread Thierry Reding
too. > > BR, > Jani. > > Cc: Alex Deucher > Cc: Christian König > Cc: Archit Taneja > Cc: Andrzej Hajda > Cc: Russell King > Cc: CK Hu > Cc: Philipp Zabel > Cc: Ben Skeggs > Cc: Mark Yao > Cc: Benjamin Gaignard > Cc: Vincent Abriou > Cc: Th

Re: [Intel-gfx] [PATCH 00/15] drm: More plane clipping polish

2017-11-24 Thread Thierry Reding
> Cc: Noralf Trønnes > Cc: nouv...@lists.freedesktop.org > Cc: Philipp Zabel > Cc: Rob Clark > Cc: Shawn Guo > Cc: Sinclair Yeh > Cc: Thierry Reding > Cc: Thomas Hellstrom > Cc: VMware Graphics > > Ville Syrjälä (15): > drm/i915: Reject odd pi

Re: [Intel-gfx] [PATCH 12/15] drm/tegra/dc: Use drm_mode_get_hv_timing() to populate plane clip rectangle

2017-11-24 Thread Thierry Reding
rm_mode_get_hv_timing() > uses. > > Once everyone agrees on this we can move the clip handling into > drm_atomic_helper_check_plane_state(). > > Cc: Laurent Pinchart > Cc: Thierry Reding > Cc: linux-te...@vger.kernel.org > Signed-off-by: Ville Syrjälä > --- > drivers

Re: [Intel-gfx] [PATCH 1/3] drm/dp: WARN about invalid/unknown link rates and bw codes

2017-10-09 Thread Thierry Reding
On Mon, Oct 09, 2017 at 12:29:57PM +0300, Jani Nikula wrote: > Falling back to the lowest value is likely the only thing we can do, but > doing it silently seems like a bad thing to do. Catch it early and make > loud noises. > > Cc: Alex Deucher > Cc: Thierry Reding > Cc:

Re: [Intel-gfx] [PATCH 0/9] drm/i915: Plane assert/readout cleanups etc.

2017-10-12 Thread Thierry Reding
gen2/3 and chv primary plane windowing support on on top > just because it's been bugging me for years, and I was already > in the neighbourhood. > > Series available here: > git://github.com/vsyrjala/linux.git plane_sanitation_2 > > Cc: Thierry Reding > Cc: Alex Villa

Re: [Intel-gfx] [PATCH 0/9] drm/i915: Plane assert/readout cleanups etc.

2017-10-12 Thread Thierry Reding
On Thu, Oct 12, 2017 at 03:19:53PM +0300, Ville Syrjälä wrote: > On Thu, Oct 12, 2017 at 01:35:20PM +0200, Thierry Reding wrote: > > On Wed, Oct 11, 2017 at 07:04:46PM +0300, Ville Syrjala wrote: > > > From: Ville Syrjälä > > > > > > This series aims to clea

[Intel-gfx] [PATCH i-g-t 1/7] tests/perf: Fix a bunch of warnings on 32-bit systems

2017-10-12 Thread Thierry Reding
From: Thierry Reding Data types are defined differently on 32-bit systems, causing gcc to complain about printf format specifiers not matching the size of the variables passed in. Use PRIu64 and %zu where appropriate. Signed-off-by: Thierry Reding --- tests/perf.c | 32

[Intel-gfx] [PATCH i-g-t 3/7] lib: Fix compilation on non-x86

2017-10-12 Thread Thierry Reding
From: Thierry Reding The meson build avoids the failure by excluding the igt_x86.c file from the compilation. autotools being what they are don't support that in an easy way, so just use the preprocessor to avoid the duplicate function definitions. Since igt_x86.c will now be ignored fo

[Intel-gfx] [PATCH i-g-t 4/7] lib/drmtest: Fix typo

2017-10-12 Thread Thierry Reding
From: Thierry Reding "other" was misspelled as "otehr". Fix it. Signed-off-by: Thierry Reding --- lib/drmtest.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/drmtest.c b/lib/drmtest.c index 8a07152c701a..24a5ea0f6a0f 100644 --- a/lib/drmtest.c

[Intel-gfx] [PATCH i-g-t 2/7] tools/aubdump: Avoid ISO C90 warning

2017-10-12 Thread Thierry Reding
From: Thierry Reding GCC will warn about ISO C90 forbidding to mix declarations and code. Declare the variable at the beginning of the function to suppress the warning. Signed-off-by: Thierry Reding --- tools/aubdump.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a

[Intel-gfx] [PATCH i-g-t 6/7] lib/drmtest: Support Tegra

2017-10-12 Thread Thierry Reding
From: Thierry Reding Add a driver definition for Tegra and wire up all the necessary pieces to identify its devices. Signed-off-by: Thierry Reding --- lib/drmtest.c | 10 ++ lib/drmtest.h | 1 + 2 files changed, 11 insertions(+) diff --git a/lib/drmtest.c b/lib/drmtest.c index

[Intel-gfx] [PATCH i-g-t 5/7] lib/drmtest: Support nouveau

2017-10-12 Thread Thierry Reding
From: Thierry Reding Add a driver definition for nouveau and wire up all the necessary pieces to identify its devices. Signed-off-by: Thierry Reding --- lib/drmtest.c | 14 -- lib/drmtest.h | 1 + 2 files changed, 13 insertions(+), 2 deletions(-) diff --git a/lib/drmtest.c b/lib

[Intel-gfx] [PATCH i-g-t 7/7] lib/drmtest: Allow the test device to be overridden

2017-10-12 Thread Thierry Reding
From: Thierry Reding On setups where the device to be tested is not the first one, allow users to override it using the IGT_DEVICE environment variable. Signed-off-by: Thierry Reding --- lib/drmtest.c | 91 --- 1 file changed, 56

Re: [Intel-gfx] [PATCH i-g-t 3/7] lib: Fix compilation on non-x86

2017-10-12 Thread Thierry Reding
On Thu, Oct 12, 2017 at 04:44:14PM +0300, Ville Syrjälä wrote: > On Thu, Oct 12, 2017 at 03:29:39PM +0200, Thierry Reding wrote: > > From: Thierry Reding > > > > The meson build avoids the failure by excluding the igt_x86.c file from > > the compilation. autotool

Re: [Intel-gfx] [PATCH 06/10] drm/tegra: Handle 64-bit return from drm_crtc_vblank_count()

2018-02-15 Thread Thierry Reding
ready correct. > > > > Cc: Keith Packard > > Cc: Thierry Reding > > > Thierry, > > Can I get an Ack on this please? Acked-by: Thierry Reding signature.asc Description: PGP signature ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH v3 05/10] pwm: add PWM mode to pwm_config()

2018-02-28 Thread Thierry Reding
On Thu, Feb 22, 2018 at 02:01:16PM +0200, Claudiu Beznea wrote: > Add PWM mode to pwm_config() function. The drivers which uses pwm_config() > were adapted to this change. > > Signed-off-by: Claudiu Beznea > --- > arch/arm/mach-s3c24xx/mach-rx1950.c | 11 +-- > drivers/bus/ts-nbus.c

[Intel-gfx] [PATCH 4/6] drm/i915: Use correct path to trace include

2017-09-01 Thread Thierry Reding
From: Thierry Reding The header comment in include/trace/define_trace.h specifies that the TRACE_INCLUDE_PATH needs to be relative to the define_trace.h header rather than the trace file including it. Most instances get that wrong and work around it by adding the $(src) directory to the include

[Intel-gfx] [PATCH i-g-t 1/2] tests/testdisplay: Explicitly use GLIB_CFLAGS

2018-02-05 Thread Thierry Reding
From: Thierry Reding testdisplay.h includes the glib.h header file but the Makefile does not explicitly pass a -I option with the path containing that header, hence causing the build to fail. Note that this doesn't seem to happen with a recent enough version of cairo, which implicitly pro

[Intel-gfx] [PATCH i-g-t 2/2] tools/intel_dp_compliance: Add missing GLIB_CFLAGS

2018-02-05 Thread Thierry Reding
From: Thierry Reding intel_dp_compliance.h includes the glib.h header file but the Makefile does not explicitly pass a -I option with the path containing that header, hence causing the build to fail. Note that this doesn't seem to happen with a recent enough version of cairo, which impli

Re: [Intel-gfx] [PATCH 06/10] drm/tegra: Handle 64-bit return from drm_crtc_vblank_count()

2018-02-07 Thread Thierry Reding
ready correct. > > > > Cc: Keith Packard > > Cc: Thierry Reding > > > Thierry, > > Can I get an Ack on this please? > > > Signed-off-by: Dhinakaran Pandiyan > > --- > > drivers/gpu/drm/tegra/dc.c | 2 +- > > 1 file changed, 1 insert

<    1   2   3   4   5   >