Re: [Intel-gfx] [PATCH V4 2/2] drm/i915: start adding dp mst audio

2015-12-13 Thread Takashi Iwai
On Fri, 11 Dec 2015 15:05:08 +0100, Takashi Iwai wrote: > > On Fri, 11 Dec 2015 07:07:53 +0100, > Libin Yang wrote: > > > > Add Takashi and ALSA mail list. > > > > On 12/10/2015 05:02 PM, Daniel Vetter wrote: > > > On Tue, Dec 08, 2015 at 04:01:2

Re: [Intel-gfx] [PATCH V4 2/2] drm/i915: start adding dp mst audio

2015-12-14 Thread Takashi Iwai
On Mon, 14 Dec 2015 10:33:44 +0100, Jani Nikula wrote: > > On Fri, 11 Dec 2015, Takashi Iwai wrote: > > On Fri, 11 Dec 2015 07:07:53 +0100, > > Libin Yang wrote: > >> > >> >>> diff --git a/drivers/gpu/drm/i915/intel_audio.c > >> >>&

Re: [Intel-gfx] [PATCH V4 2/2] drm/i915: start adding dp mst audio

2015-12-14 Thread Takashi Iwai
On Mon, 14 Dec 2015 11:34:53 +0100, Jani Nikula wrote: > > On Mon, 14 Dec 2015, Takashi Iwai wrote: > > On Mon, 14 Dec 2015 10:33:44 +0100, > > Jani Nikula wrote: > >> > >> On Fri, 11 Dec 2015, Takashi Iwai wrote: > >> > On Fri, 11

Re: [Intel-gfx] [GIT PULL] Add get_eld audio component for i915/HD-audio

2015-12-21 Thread Takashi Iwai
On Thu, 10 Dec 2015 14:16:03 +0100, Takashi Iwai wrote: > > Hi Daniel, > > please pull the get_eld op addition from: > > git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git > tags/drm-i915-get-eld > > The topmost commit is 0bdf5a05647a6

Re: [Intel-gfx] [GIT PULL] Add get_eld audio component for i915/HD-audio

2015-12-21 Thread Takashi Iwai
On Mon, 21 Dec 2015 10:59:41 +0100, Daniel Vetter wrote: > > On Mon, Dec 21, 2015 at 10:25:14AM +0100, Takashi Iwai wrote: > > On Thu, 10 Dec 2015 14:16:03 +0100, > > Takashi Iwai wrote: > > > > > > Hi Daniel, > > > > > > please

Re: [Intel-gfx] kernel crash in snd_hda_intel

2016-02-15 Thread Takashi Iwai
.jack > saves the snd_jack pointer created in hda_jack. > > Signed-off-by: Libin Yang > Signed-off-by: Takashi Iwai > > > > > [ 79.020523] BUG: unable to handle kernel paging request at > 00015d80 > [ 79.021314] IP: [] queued

Re: [Intel-gfx] kernel crash in snd_hda_intel

2016-02-15 Thread Takashi Iwai
On Mon, 15 Feb 2016 13:57:00 +0100, Gabriel Feceoru wrote: > > > > On 15.02.2016 12:23, Takashi Iwai wrote: > > On Fri, 12 Feb 2016 17:47:21 +0100, > > Gabriel Feceoru wrote: > >> > >> !!! This caused a regression in the i-g-t drv_module_reload_basic t

Re: [Intel-gfx] kernel crash in snd_hda_intel

2016-02-15 Thread Takashi Iwai
On Mon, 15 Feb 2016 14:20:46 +0100, Gabriel Feceoru wrote: > > > > On 15.02.2016 14:57, Takashi Iwai wrote: > > On Mon, 15 Feb 2016 13:57:00 +0100, > > Gabriel Feceoru wrote: > >> > >> > >> > >> On 15.02.2016 12:23, Takashi Iwai wr

Re: [Intel-gfx] [BUG] [REGRESSION] [BISECTED] -rc1 breaks audio over HDMI for i915

2016-02-23 Thread Takashi Iwai
On Mon, 22 Feb 2016 22:37:28 +0100, Martin Kepplinger wrote: > > Am 2016-02-22 um 20:10 schrieb Takashi Iwai: > > On Mon, 22 Feb 2016 19:58:18 +0100, > > Martin Kepplinger wrote: > >> > >> Am 2016-02-22 um 15:12 schrieb Takashi Iwai: > >>>

Re: [Intel-gfx] [BUG] [REGRESSION] [BISECTED] -rc1 breaks audio over HDMI for i915

2016-02-24 Thread Takashi Iwai
On Wed, 24 Feb 2016 08:51:32 +0100, Takashi Iwai wrote: > > Since dig_port_map[] is used only for the audio callback, we can > assign it dynamically just before the callbacks. > > Could you try the patch below? (It's totally untested.) The one below might be safer, it&#x

Re: [Intel-gfx] [BUG] [REGRESSION] [BISECTED] -rc1 breaks audio over HDMI for i915

2016-02-24 Thread Takashi Iwai
On Tue, 23 Feb 2016 20:09:02 +0100, Martin Kepplinger wrote: > > Am 2016-02-23 um 18:14 schrieb Ville Syrjälä: > > On Tue, Feb 23, 2016 at 05:57:40PM +0100, Takashi Iwai wrote: > >> On Mon, 22 Feb 2016 22:37:28 +0100, > >> Martin Kepplinger wrote: > >>

[Intel-gfx] [PATCH] drm/i915: Fix bogus dig_port_map[] assignment for pre-HSW

2016-02-24 Thread Takashi Iwai
given port. Fixes: 0bdf5a05647a ('drm/i915: Add reverse mapping between port and intel_encoder') Reported-and-tested-by: Martin Kepplinger Signed-off-by: Takashi Iwai --- drivers/gpu/drm/i915/intel_audio.c | 3 +++ drivers/gpu/drm/i915/intel_ddi.c | 1 - drivers/gpu/drm/i915/intel_d

Re: [Intel-gfx] snd-hda-intel runtime PM fail after module reload

2016-02-25 Thread Takashi Iwai
On Thu, 25 Feb 2016 20:19:08 +0100, Ville Syrjälä wrote: > > Hi, > > My investigation into some sporadic i915 runtime PM failures seem to > point the finger at snd-hda-intel. > > I just tried to play around unloding and reloading snd-hda-intel and > sometimes I get snd-hda-intel loaded with runt

Re: [Intel-gfx] snd-hda-intel runtime PM fail after module reload

2016-02-25 Thread Takashi Iwai
On Thu, 25 Feb 2016 22:57:34 +0100, Ville Syrjälä wrote: > > On Thu, Feb 25, 2016 at 09:28:59PM +0100, Takashi Iwai wrote: > > On Thu, 25 Feb 2016 20:19:08 +0100, > > Ville Syrjälä wrote: > > > > > > Hi, > > > > > > My investigati

Re: [Intel-gfx] [PATCH] drm/i915: Fix bogus dig_port_map[] assignment for pre-HSW

2016-02-26 Thread Takashi Iwai
Sorry, Cc to Jani was missing mistakenly. Please check this. It's a regression in 4.5-rc. thanks, Takashi On Wed, 24 Feb 2016 15:35:22 +0100, Takashi Iwai wrote: > > The recent commit [0bdf5a05647a: drm/i915: Add reverse mapping between > port and intel_encoder] introduced a r

Re: [Intel-gfx] [PATCH] drm/i915: add audio_ptr pointer check

2016-03-01 Thread Takashi Iwai
On Wed, 02 Mar 2016 03:24:31 +0100, libin.y...@linux.intel.com wrote: > > From: Libin Yang > > check to make sure audio_ptr is not NULL before > using it. I don't think non-NULL is mandatory. If any invalid access is seen, it should be fixed rather in the audio side. thanks, Takashi > > S

Re: [Intel-gfx] [PATCH] drm/i915: add audio_ptr pointer check

2016-03-02 Thread Takashi Iwai
On Wed, 02 Mar 2016 08:59:23 +0100, Yang, Libin wrote: > > Hi Takashi, > > > -Original Message- > > From: Takashi Iwai [mailto:ti...@suse.de] > > Sent: Wednesday, March 02, 2016 3:44 PM > > To: libin.y...@linux.intel.com > > Cc: intel-gfx@list

Re: [Intel-gfx] [PATCH] drm/i915: Fix bogus dig_port_map[] assignment for pre-HSW

2016-03-03 Thread Takashi Iwai
On Mon, 29 Feb 2016 15:39:53 +0100, Jani Nikula wrote: > > On Mon, 29 Feb 2016, Martin Kepplinger wrote: > > Am 2016-02-26 um 20:59 schrieb Takashi Iwai: > >> Sorry, Cc to Jani was missing mistakenly. > >> > >> Please check this. It's a r

Re: [Intel-gfx] [alsa-devel] [PATCH 1/2] ALSA: hda - hdmi add wmb barrier for audio component

2016-03-04 Thread Takashi Iwai
On Fri, 04 Mar 2016 07:33:06 +0100, libin.y...@linux.intel.com wrote: > > From: Libin Yang > > To make sure audio_ptr is set before intel_audio_codec_enable() > or intel_audio_codec_disable() calling pin_eld_notify(), > this patch adds wmb barrier to prevent optimizing. > > Signed-off-by: Libin

Re: [Intel-gfx] [RFC PATCH v3 2/7] drm/i915: Add support for audio driver notifications

2016-11-29 Thread Takashi Iwai
On Mon, 28 Nov 2016 22:56:24 +0100, Pierre-Louis Bossart wrote: > > On 11/28/16 1:30 PM, Ville Syrjälä wrote: > > On Mon, Nov 28, 2016 at 01:13:31PM -0600, Pierre-Louis Bossart wrote: > >> > >> On 11/28/16 11:01 AM, Ville Syrjälä wrote: > +if (pdata->notify_audio_lpe)

Re: [Intel-gfx] [alsa-devel] [PATCH v4 0/3] support DP MST audio

2016-12-06 Thread Takashi Iwai
On Tue, 06 Dec 2016 08:51:43 +0100, Daniel Vetter wrote: > > On Tue, Dec 6, 2016 at 8:20 AM, Takashi Iwai wrote: > > On Tue, 06 Dec 2016 03:58:21 +0100, > > Yang, Libin wrote: > >> > >> The patchset is based on drm-tip branch in > >> git://anongit.fr

Re: [Intel-gfx] [PATCH 0/7] Add support for Legacy HDMI audio drivers

2016-12-14 Thread Takashi Iwai
On Mon, 12 Dec 2016 19:10:36 +0100, Jerome Anand wrote: > > Legacy (CherryTrail/ Baytrail) HDMI audio drivers added > > Legacy hdmi audio-Gfx interaction/ interfacing is updated to use > irq chip framework > > Jerome Anand (7): > drm/i915: setup bridge for HDMI LPE audio driver > drm/i915: A

Re: [Intel-gfx] [PATCH 1/7] drm/i915: setup bridge for HDMI LPE audio driver

2016-12-14 Thread Takashi Iwai
On Mon, 12 Dec 2016 19:10:37 +0100, Jerome Anand wrote: > > --- /dev/null > +++ b/drivers/gpu/drm/i915/intel_lpe_audio.c (snip) > +static struct platform_device* Missing space. > +lpe_audio_platdev_create(struct drm_i915_private *dev_priv) > +{ > + struct drm_device *dev = &dev_priv->drm; >

Re: [Intel-gfx] [PATCH 2/7] drm/i915: Add support for audio driver notifications

2016-12-14 Thread Takashi Iwai
On Mon, 12 Dec 2016 19:10:38 +0100, Jerome Anand wrote: > > Notifiations like mode change, hot plug and edid to > the audio driver are added. This is inturn used by the > audio driver for its functionality. > > A new interface file capturing the notifications needed by the > audio driver is added

Re: [Intel-gfx] [PATCH 3/7] ALSA: add shell for Intel HDMI LPE audio driver

2016-12-14 Thread Takashi Iwai
On Mon, 12 Dec 2016 19:10:39 +0100, Jerome Anand wrote: > > On Baytrail and Cherrytrail, HDaudio may be fused out or disabled > by the BIOS. This driver enables an alternate path to the i915 > display registers and DMA. > > Although there is no hardware path between i915 display and LPE/SST > aud

Re: [Intel-gfx] [PATCH 4/7] ALSA: x86: hdmi: Add audio support for BYT and CHT

2016-12-14 Thread Takashi Iwai
On Mon, 12 Dec 2016 19:10:40 +0100, Jerome Anand wrote: > > Hdmi audio driver based on the child platform device > created by gfx driver is implemented. > This audio driver is derived from legacy intel > hdmi audio driver. > > The interfaces for interaction between gfx and audio > are updated and

Re: [Intel-gfx] [PATCH 5/7] ALSA: x86: hdmi: Improve position reporting

2016-12-14 Thread Takashi Iwai
On Mon, 12 Dec 2016 19:10:41 +0100, Jerome Anand wrote: > > Use a hw register to calculate sub-period position reports. > This makes PulseAudio happier. > > Signed-off-by: David Henningsson > Signed-off-by: Pierre-Louis Bossart > Signed-off-by: Jerome Anand There is no big merit to keep this

Re: [Intel-gfx] [PATCH 6/7] ALSA: x86: hdmi: Fixup some monitor

2016-12-14 Thread Takashi Iwai
On Mon, 12 Dec 2016 19:10:42 +0100, Jerome Anand wrote: > > This change was given to Canonical apparently to fix an issue with > on some monitor brand. It's not clear what this patch does but it doesn't > seem to have side effects. > > Signed-off-by: David Henningsson > Signed-off-by: Pierre-Lou

Re: [Intel-gfx] [PATCH 7/7] ALSA: x86: hdmi: continue playback even when display resolution changes

2016-12-14 Thread Takashi Iwai
On Mon, 12 Dec 2016 19:10:43 +0100, Jerome Anand wrote: > > When the display resolution changes, the drm disables the > display pipes due to which audio rendering stops. At this > time, we need to ensure the existing audio pointers and > buffers are cleared out so that the playback can restarted >

Re: [Intel-gfx] [PATCH 1/7] drm/i915: setup bridge for HDMI LPE audio driver

2016-12-14 Thread Takashi Iwai
On Wed, 14 Dec 2016 13:52:27 +0100, Daniel Vetter wrote: > > ... for merging through sound tree. Since we're super early in 4.11 a > topic branch for me to pull in to avoid sync headaches would be good. Sure, I'll branch from some vanilla rc like 4.10-rc1. thanks, Takashi _

Re: [Intel-gfx] [PATCH 2/7] drm/i915: Add support for audio driver notifications

2016-12-14 Thread Takashi Iwai
On Wed, 14 Dec 2016 13:55:52 +0100, Daniel Vetter wrote: > > Only noticed it here, but why again do we need to re-roll our intel-only > hdmi/eld notification? The one we have for hda is somewhat justified since > it went in at roughly the same time as the new shared one across a bunch > of soc. Bu

Re: [Intel-gfx] [PATCH 5/7] ALSA: x86: hdmi: Improve position reporting

2016-12-14 Thread Takashi Iwai
On Wed, 14 Dec 2016 15:09:20 +0100, Pierre-Louis Bossart wrote: > > On 12/14/16 6:57 AM, Takashi Iwai wrote: > > On Mon, 12 Dec 2016 19:10:41 +0100, > > Jerome Anand wrote: > >> > >> Use a hw register to calculate sub-period position reports. > >> Th

Re: [Intel-gfx] [PATCH 3/7] ALSA: add shell for Intel HDMI LPE audio driver

2016-12-15 Thread Takashi Iwai
On Thu, 15 Dec 2016 11:55:23 +0100, Anand, Jerome wrote: > > > > > -Original Message- > > From: Takashi Iwai [mailto:ti...@suse.de] > > Sent: Wednesday, December 14, 2016 6:16 PM > > To: Anand, Jerome > > Cc: intel-gfx@lists.freedesktop.org; alsa

Re: [Intel-gfx] [alsa-devel] [PATCH 3/7] ALSA: add shell for Intel HDMI LPE audio driver

2016-12-15 Thread Takashi Iwai
On Thu, 15 Dec 2016 21:37:03 +0100, Pierre-Louis Bossart wrote: > > > >>> Subject: Re: [PATCH 3/7] ALSA: add shell for Intel HDMI LPE audio driver > > >>> Why do we need a "shell" and indirect calls? > >>> This is a small driver set, so it's not utterly unacceptable, but it > >>> still makes >

Re: [Intel-gfx] [PATCH 1/3] drm/i915/hda: Add audio component stub

2016-04-25 Thread Takashi Iwai
On Thu, 07 Apr 2016 14:30:45 +0200, Imre Deak wrote: > > On to, 2016-04-07 at 14:55 +0300, Ville Syrjälä wrote: > > On Thu, Apr 07, 2016 at 12:57:22PM +0200, Takashi Iwai wrote: > > > From: Imre Deak > > > > > > User may pass nomodeset or i915.mod

Re: [Intel-gfx] [PATCH v2 1/3] drm/i915/hda: Add audio component stub

2016-05-13 Thread Takashi Iwai
ead of > suppressing the error. (Ville) > - Register the component only for the real PCI device function. > > CC: Ville Syrjälä > Signed-off-by: Imre Deak > Signed-off-by: Takashi Iwai I haven't received v2 for the rest two patches. I suppose they are unchanged from v1?

Re: [Intel-gfx] [PATCH v2 1/3] drm/i915/hda: Add audio component stub

2016-05-13 Thread Takashi Iwai
On Fri, 13 May 2016 11:50:09 +0200, Imre Deak wrote: > > On Fri, 2016-05-13 at 09:48 +0200, Takashi Iwai wrote: > > On Thu, 12 May 2016 20:06:53 +0200, > > Imre Deak wrote: > > > > > > User may pass nomodeset or i915.modeset=0 option to disable i915 KMS >

Re: [Intel-gfx] [PATCH v2 1/3] drm/i915/hda: Add audio component stub

2016-05-17 Thread Takashi Iwai
-audio) can know clearly the > > slave state. > > > > v2: > > - Fail the probe in case component registration fails, instead of > > suppressing the error. (Ville) > > - Register the component only for the real PCI device function. > > > > CC: Ville Sy

Re: [Intel-gfx] [PATCH v2 1/3] drm/i915/hda: Add audio component stub

2016-05-17 Thread Takashi Iwai
On Tue, 17 May 2016 11:42:17 +0200, Daniel Vetter wrote: > > On Tue, May 17, 2016 at 09:37:12AM +0200, Takashi Iwai wrote: > > On Tue, 17 May 2016 09:20:48 +0200, > > Daniel Vetter wrote: > > > > > > On Thu, May 12, 2016 at 09:06:53PM +0300, Imre Deak wrote

Re: [Intel-gfx] [PATCH v2 1/3] drm/i915/hda: Add audio component stub

2016-05-17 Thread Takashi Iwai
016-05-17 at 11:59 +0200, Takashi Iwai wrote: > > > > > On Tue, 17 May 2016 11:42:17 +0200, > > > > > Daniel Vetter wrote: > > > > > > > > > > > > On Tue, May 17, 2016 at 09:37:12AM +0200, Takashi Iwai wrote: > > > > >

Re: [Intel-gfx] [PATCH v2 1/3] drm/i915/hda: Add audio component stub

2016-05-17 Thread Takashi Iwai
May 17, 2016 at 01:22:52PM +0300, Imre Deak wrote: > > > > > On ti, 2016-05-17 at 11:59 +0200, Takashi Iwai wrote: > > > > > > On Tue, 17 May 2016 11:42:17 +0200, > > > > > > Daniel Vetter wrote: > > > > > > > > > >

Re: [Intel-gfx] [PATCH v2 1/3] drm/i915/hda: Add audio component stub

2016-05-17 Thread Takashi Iwai
On ti, 2016-05-17 at 13:10 +0200, Daniel Vetter wrote: > > > > > On Tue, May 17, 2016 at 01:22:52PM +0300, Imre Deak wrote: > > > > > > On ti, 2016-05-17 at 11:59 +0200, Takashi Iwai wrote: > > > > > > > On Tue, 17 May 2016 11:42:17 +0200, >

Re: [Intel-gfx] [PATCH v2 1/3] drm/i915/hda: Add audio component stub

2016-05-17 Thread Takashi Iwai
On Tue, 17 May 2016 14:56:16 +0200, Daniel Vetter wrote: > > On Tue, May 17, 2016 at 02:47:44PM +0200, Takashi Iwai wrote: > > On Tue, 17 May 2016 14:34:21 +0200, > > Daniel Vetter wrote: > > > > > > On Tue, May 17, 2016 at 03:11:02PM +0300, Imre Deak wrote

Re: [Intel-gfx] [PATCH v2 1/3] drm/i915/hda: Add audio component stub

2016-05-17 Thread Takashi Iwai
On Tue, 17 May 2016 14:53:40 +0200, Takashi Iwai wrote: > > On Tue, 17 May 2016 14:39:26 +0200, > Daniel Vetter wrote: > > > > And if we _really_ want this to work at runtime too, then we need a > > system-wide nomodeset option that snd-hda can look up and act accord

Re: [Intel-gfx] [PATCH v2 1/3] drm/i915/hda: Add audio component stub

2016-05-17 Thread Takashi Iwai
On Tue, 17 May 2016 15:59:17 +0200, Daniel Vetter wrote: > > On Tue, May 17, 2016 at 03:57:30PM +0200, Takashi Iwai wrote: > > On Tue, 17 May 2016 14:53:40 +0200, > > Takashi Iwai wrote: > > > > > > On Tue, 17 May 2016 14:39:26 +0200, > > > Da

Re: [Intel-gfx] [PATCH v2 1/3] drm/i915/hda: Add audio component stub

2016-05-17 Thread Takashi Iwai
On Tue, 17 May 2016 18:18:27 +0200, Daniel Vetter wrote: > > On Tue, May 17, 2016 at 3:20 PM, Takashi Iwai wrote: > >> Ok, I looked at patch 3, and that indeed would lead to trouble without > >> patch 1. But the real trouble is the unconditional wait_completion in &

Re: [Intel-gfx] [PATCH v2 1/3] drm/i915/hda: Add audio component stub

2016-05-17 Thread Takashi Iwai
On Tue, 17 May 2016 18:23:40 +0200, Daniel Vetter wrote: > > On Tue, May 17, 2016 at 6:18 PM, Daniel Vetter wrote: > > On Tue, May 17, 2016 at 3:20 PM, Takashi Iwai wrote: > >>> Ok, I looked at patch 3, and that indeed would lead to trouble without > >>>

Re: [Intel-gfx] [PATCH v2 1/3] drm/i915/hda: Add audio component stub

2016-05-18 Thread Takashi Iwai
On Tue, 17 May 2016 23:11:10 +0200, Daniel Vetter wrote: > > On Tue, May 17, 2016 at 08:19:32PM +0200, Takashi Iwai wrote: > > On Tue, 17 May 2016 18:23:40 +0200, > > Daniel Vetter wrote: > > > > > > On Tue, May 17, 2016 at 6:18 PM, Daniel Vetter wrote: >

Re: [Intel-gfx] New snd-hda warning spew

2016-03-18 Thread Takashi Iwai
On Fri, 18 Mar 2016 20:07:53 +0100, Ville Syrjälä wrote: > > On Fri, Mar 18, 2016 at 07:56:36PM +0100, Takashi Iwai wrote: > > On Fri, 18 Mar 2016 19:51:43 +0100, > > Takashi Iwai wrote: > > > > > > On Fri, 18 Mar 2016 18:49:19 +0100, > > > Ville S

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/bxt: Fix off-by-one error in Broxton PLL IDs (rev3)

2016-03-19 Thread Takashi Iwai
On Thu, 17 Mar 2016 08:57:23 +0100, Tomi Sarvela wrote: > > On Wednesday 16 March 2016 16:40:24 Takashi Iwai wrote: > > On Wed, 16 Mar 2016 16:37:06 +0100, Daniel Vetter wrote: > > > On Wed, Mar 16, 2016 at 02:37:24PM +0200, Tomi Sarvela wrote: > > > > > >

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/bxt: Fix off-by-one error in Broxton PLL IDs (rev3)

2016-03-19 Thread Takashi Iwai
On Fri, 18 Mar 2016 09:12:53 +0100, Tomi Sarvela wrote: > > On Friday 18 March 2016 09:00:13 Takashi Iwai wrote: > > On Fri, 18 Mar 2016 08:36:27 +0100, > > > > Do you have the commit of the last working kernel? > > > > > The unit tests that hang qu

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/bxt: Fix off-by-one error in Broxton PLL IDs (rev3)

2016-03-19 Thread Takashi Iwai
On Wed, 16 Mar 2016 16:37:06 +0100, Daniel Vetter wrote: > > On Wed, Mar 16, 2016 at 02:37:24PM +0200, Tomi Sarvela wrote: > > On Wednesday 16 March 2016 10:48:43 Imre Deak wrote: > > > Tomi, noticed two things that maybe infrastructure related, see below: > > > > > > > Test drv_module_reload_bas

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/bxt: Fix off-by-one error in Broxton PLL IDs (rev3)

2016-03-19 Thread Takashi Iwai
On Fri, 18 Mar 2016 08:36:27 +0100, Tomi Sarvela wrote: > > On Thursday 17 March 2016 18:00:52 Takashi Iwai wrote: > ... > > > > CI_DRM_1147 git://anongit.freedesktop.org/drm-intel > > > dbbc6d276864d7b7a3a1edb04f0511153f9c3852 > > > > > > Not

Re: [Intel-gfx] [PATCH] drm/i915: intel_audio clear eld buf when disconnecting monitor

2016-03-21 Thread Takashi Iwai
On Mon, 21 Mar 2016 06:03:29 +0100, libin.y...@linux.intel.com wrote: > > From: Libin Yang > > When disconnecting monitor, dev_priv->dig_port_map[port] > will be set NULL, which causes eld will not be updated in > i915_audio_component_get_eld(). > > This patch clears the eld buf when dev_priv->

Re: [Intel-gfx] [PATCH] drm/i915: intel_audio clear eld buf when disconnecting monitor

2016-03-21 Thread Takashi Iwai
On Mon, 21 Mar 2016 15:17:37 +0100, Yang, Libin wrote: > > > > -Original Message- > > From: Takashi Iwai [mailto:ti...@suse.de] > > Sent: Monday, March 21, 2016 6:45 PM > > To: libin.y...@linux.intel.com > > Cc: intel-gfx@lists.freedesktop.org

Re: [Intel-gfx] [PATCH] drm/i915: intel_audio clear eld buf when disconnecting monitor

2016-03-21 Thread Takashi Iwai
On Mon, 21 Mar 2016 16:00:21 +0100, Takashi Iwai wrote: > > On Mon, 21 Mar 2016 15:17:37 +0100, > Yang, Libin wrote: > > > > > > > -Original Message- > > > From: Takashi Iwai [mailto:ti...@suse.de] > > > Sent: Monday, March 21, 2016 6:45

Re: [Intel-gfx] [PATCH] drm/i915: intel_audio clear eld buf when disconnecting monitor

2016-03-21 Thread Takashi Iwai
On Mon, 21 Mar 2016 16:12:05 +0100, Takashi Iwai wrote: > > On Mon, 21 Mar 2016 16:00:21 +0100, > Takashi Iwai wrote: > > > > On Mon, 21 Mar 2016 15:17:37 +0100, > > Yang, Libin wrote: > > > > > > > > > > -Original Message- >

Re: [Intel-gfx] [PATCH] drm/i915: intel_audio clear eld buf when disconnecting monitor

2016-03-21 Thread Takashi Iwai
On Mon, 21 Mar 2016 16:19:31 +0100, Takashi Iwai wrote: > > On Mon, 21 Mar 2016 16:12:05 +0100, > Takashi Iwai wrote: > > > > On Mon, 21 Mar 2016 16:00:21 +0100, > > Takashi Iwai wrote: > > > > > > On Mon, 21 Mar

Re: [Intel-gfx] [PATCH] drm/i915: intel_audio clear eld buf when disconnecting monitor

2016-03-22 Thread Takashi Iwai
On Tue, 22 Mar 2016 02:47:14 +0100, Yang, Libin wrote: > > Hi Takashi, > > > -Original Message- > > From: Takashi Iwai [mailto:ti...@suse.de] > > Sent: Monday, March 21, 2016 11:30 PM > > To: Yang, Libin > > Cc: libin.y...@linux.intel.com; intel

[Intel-gfx] [PATCH 1/3] drm/i915/hda: Add audio component stub

2016-04-07 Thread Takashi Iwai
ut with the new "disabled" ops flag, so that the master component (HD-audio) can know clearly the slave state. Signed-off-by: Imre Deak Signed-off-by: Takashi Iwai --- drivers/gpu/drm/i915/i915_drv.c| 34 + drivers/gpu/dr

[Intel-gfx] [PATCH 3/3] ALSA: hda - Support deferred i915 audio component binding

2016-04-07 Thread Takashi Iwai
be racy and lead to the refcount unbalance. Signed-off-by: Takashi Iwai --- sound/hda/hdac_i915.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/sound/hda/hdac_i915.c b/sound/hda/hdac_i915.c index 812777f9af1f..6455d239a928 100644 --- a/sound/hda/hdac_i915.c +++ b

[Intel-gfx] [PATCH 0/3] More robust i915 / audio binding

2016-04-07 Thread Takashi Iwai
Hi, here is a patchset to make the i915 / audio binding more robustly. It's based on Imre's work to implement the stub component ops for notifying the i915 disablement. Takashi === Imre Deak (1): drm/i915/hda: Add audio component stub Takashi Iwai (2): ALSA: hda - Immediately f

[Intel-gfx] [PATCH 2/3] ALSA: hda - Immediately fail if the i915 audio component is disabled

2016-04-07 Thread Takashi Iwai
Since i915 notifies its disabled state via the stub component binding, we can bail out immediately once when the disabled flag is detected. Based on the original patch by Imre Deak Signed-off-by: Takashi Iwai --- sound/hda/hdac_i915.c | 16 +--- 1 file changed, 13 insertions(+), 3

Re: [Intel-gfx] Broken DPMS with DisplayPort on CHV (also BYT?)

2017-01-26 Thread Takashi Iwai
On Thu, 26 Jan 2017 14:58:55 +0100, Ville Syrjälä wrote: > > On Wed, Jan 25, 2017 at 01:56:35PM +0100, Takashi Iwai wrote: > > Hi, > > > > we've got a bug report about the blank monitor on Cherry Trail > > machines. And, Intel team (Cc'ed) spotted o

Re: [Intel-gfx] [RFC PATCH 0/5] DisplayPort Audio on Cherrytrail

2017-01-27 Thread Takashi Iwai
On Thu, 26 Jan 2017 21:05:36 +0100, Pierre-Louis Bossart wrote: > > The following patches enable DisplayPort Audio on Cherrytrail machines > when applied on top of Takashi's topic/intel-lpe-audio branch (tested > on Zotac PI330) > > There are a couple of opens where I could use some help: > - is

Re: [Intel-gfx] Broken DPMS with DisplayPort on CHV (also BYT?)

2017-01-27 Thread Takashi Iwai
On Thu, 26 Jan 2017 15:19:44 +0100, Takashi Iwai wrote: > > On Thu, 26 Jan 2017 14:58:55 +0100, > Ville Syrjälä wrote: > > > > Hmm. Have you tried 9f2bdb006a7e ("drm/i915: Prevent PPS stealing > > from a normal DP port on VLV/CHV") ? > > No, it's

[Intel-gfx] [PATCH RFC 3/3] ALSA: x86: Use config base depending on the pipe

2017-01-27 Thread Takashi Iwai
ff-by: Takashi Iwai --- sound/x86/intel_hdmi_lpe_audio.c | 32 +--- 1 file changed, 21 insertions(+), 11 deletions(-) diff --git a/sound/x86/intel_hdmi_lpe_audio.c b/sound/x86/intel_hdmi_lpe_audio.c index 23e5b34dcf41..55bc2cfd21c4 100644 --- a/soun

[Intel-gfx] [PATCH RFC 0/3] Pass pipe to LPE audio

2017-01-27 Thread Takashi Iwai
Hi, this is a patch series to pass the pipe over LPE audio notification, based on Pierre's latest patchset ("[RFC PATCH 0/5] DisplayPort Audio on Cherrytrail"). Takashi === Takashi Iwai (3): drm/i915: Avoid MST pipe handling for LPE audio drm/i915: Pass pipe to LPE aud

[Intel-gfx] [PATCH RFC 2/3] drm/i915: Pass pipe to LPE audio notification

2017-01-27 Thread Takashi Iwai
The LPE audio configuration depends on the pipe, thus we need to pass the currently used pipe. It's now embedded in struct intel_hdmi_lpe_audio_eld as well as port id. Signed-off-by: Takashi Iwai --- drivers/gpu/drm/i915/i915_drv.h| 2 +- drivers/gpu/drm/i915/intel_audio.c

[Intel-gfx] [PATCH RFC 1/3] drm/i915: Avoid MST pipe handling for LPE audio

2017-01-27 Thread Takashi Iwai
ssart Signed-off-by: Takashi Iwai --- drivers/gpu/drm/i915/intel_audio.c | 21 +++-- 1 file changed, 11 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_audio.c b/drivers/gpu/drm/i915/intel_audio.c index 1645ce42b898..d4e6d1136cfe 100644 --- a/drivers/gpu/drm

Re: [Intel-gfx] [alsa-devel] [PATCH RFC 1/3] drm/i915: Avoid MST pipe handling for LPE audio

2017-01-27 Thread Takashi Iwai
On Fri, 27 Jan 2017 15:15:14 +0100, Pierre-Louis Bossart wrote: > > > > On 01/27/2017 04:36 AM, Takashi Iwai wrote: > > The pipe gets cleared to -1 for non-MST before the ELD audio > > notification due to the MST audio support. This makes sense for > > HD-audio

Re: [Intel-gfx] [RFC PATCH 4/5] drm: i915: add DisplayPort amp unmute for LPE audio mode

2017-01-27 Thread Takashi Iwai
On Fri, 27 Jan 2017 15:35:47 +0100, Ville Syrjälä wrote: > > On Fri, Jan 27, 2017 at 03:17:34PM +0200, Ville Syrjälä wrote: > > On Fri, Jan 27, 2017 at 12:08:58PM +0200, Jani Nikula wrote: > > > On Thu, 26 Jan 2017, Pierre-Louis Bossart > > > wrote: > > > > Enable chicken bit on LPE mode setup a

Re: [Intel-gfx] Broken DPMS with DisplayPort on CHV (also BYT?)

2017-01-30 Thread Takashi Iwai
t's found in http://download.opensuse.org/repositories/home:/tiwai:/bnc1019061-3/standard/ Takashi > > Regards > > Jeffrey > > >>> Takashi Iwai 2017/1/27 下午 18:29 >>>On Thu, 26 Jan 2017 > >>> 15:19:44 +0100, > Takashi Iwai wrote:

[Intel-gfx] [PATCH 0/7] DisplayPort audio support on Cherrytrail

2017-01-31 Thread Takashi Iwai
yPort amp unmute for LPE audio mode ALSA: x86: intel_hdmi: add definitions and logic for DP audio ALSA: x86: Use config base depending on the pipe Takashi Iwai (3): drm/i915: Avoid MST pipe handling for LPE audio drm/i915: Pass pipe to LPE audio notification drm/i915: Pass platform devi

[Intel-gfx] [PATCH 1/7] drm/i915: add DP support in LPE audio mode

2017-01-31 Thread Takashi Iwai
From: Pierre-Louis Bossart If DisplayPort is detected, pass flag and link rate to audio driver Signed-off-by: Pierre-Louis Bossart Signed-off-by: Takashi Iwai --- drivers/gpu/drm/i915/i915_drv.h| 3 ++- drivers/gpu/drm/i915/intel_audio.c | 19 +++ drivers/gpu/drm

[Intel-gfx] [PATCH 3/7] drm/i915: Avoid MST pipe handling for LPE audio

2017-01-31 Thread Takashi Iwai
ssart Signed-off-by: Takashi Iwai --- drivers/gpu/drm/i915/intel_audio.c | 21 +++-- 1 file changed, 11 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_audio.c b/drivers/gpu/drm/i915/intel_audio.c index 1645ce42b898..d4e6d1136cfe 100644 --- a/drivers/gpu/drm

[Intel-gfx] [PATCH 5/7] ALSA: x86: intel_hdmi: add definitions and logic for DP audio

2017-01-31 Thread Takashi Iwai
Louis Bossart Signed-off-by: Takashi Iwai --- sound/x86/intel_hdmi_audio.c | 173 +-- sound/x86/intel_hdmi_audio.h | 8 +- sound/x86/intel_hdmi_lpe_audio.c | 36 +++- sound/x86/intel_hdmi_lpe_audio.h | 29 +++ 4 files changed, 216 insertions(+

[Intel-gfx] [PATCH 6/7] ALSA: x86: Use config base depending on the pipe

2017-01-31 Thread Takashi Iwai
Signed-off-by: Pierre-Louis Bossart Signed-off-by: Takashi Iwai --- sound/x86/intel_hdmi_lpe_audio.c | 26 +- 1 file changed, 21 insertions(+), 5 deletions(-) diff --git a/sound/x86/intel_hdmi_lpe_audio.c b/sound/x86/intel_hdmi_lpe_audio.c index cea05dfc081a..6d630f20bca8

[Intel-gfx] [PATCH 7/7] drm/i915: Pass platform device to LPE audio notifier

2017-01-31 Thread Takashi Iwai
This allows the LPE HDMI driver to clean up its global variable reference. Also drop to pass the eld pointer because the connection status and the ELD bytes can be retrieved from the attached pdata. Signed-off-by: Takashi Iwai --- drivers/gpu/drm/i915/intel_lpe_audio.c | 3 +-- include/drm

[Intel-gfx] [PATCH 2/7] drm/i915: add DisplayPort amp unmute for LPE audio mode

2017-01-31 Thread Takashi Iwai
this phase was removed. Signed-off-by: Pierre-Louis Bossart Signed-off-by: Takashi Iwai --- drivers/gpu/drm/i915/i915_reg.h| 10 ++ drivers/gpu/drm/i915/intel_lpe_audio.c | 17 + 2 files changed, 27 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drive

[Intel-gfx] [PATCH 4/7] drm/i915: Pass pipe to LPE audio notification

2017-01-31 Thread Takashi Iwai
The LPE audio configuration depends on the pipe, thus we need to pass the currently used pipe. It's now embedded in struct intel_hdmi_lpe_audio_eld as well as port id. Signed-off-by: Takashi Iwai --- drivers/gpu/drm/i915/i915_drv.h| 2 +- drivers/gpu/drm/i915/intel_audio.c

Re: [Intel-gfx] [PATCH 2/7] drm/i915: add DisplayPort amp unmute for LPE audio mode

2017-02-01 Thread Takashi Iwai
On Wed, 01 Feb 2017 15:45:24 +0100, Ville Syrjälä wrote: > > On Tue, Jan 31, 2017 at 10:36:44PM +0100, Takashi Iwai wrote: > > From: Pierre-Louis Bossart > > > > Enable unmute/mute amp notification. This doesn't seem to affect > > HDMI support so this i

Re: [Intel-gfx] [PATCH 2/7] drm/i915: add DisplayPort amp unmute for LPE audio mode

2017-02-01 Thread Takashi Iwai
ch set a chicken bit at address 0x62F38 prior to the mute/unmute but this register doesn't seem to do anything so this phase was removed. v1->v2: Drop needless pipe A check, avoid temporary reg offset variable. v2->v3: Add "_" prefix to VLV_AUD_PORT_EN_X_DBG as they are intern

Re: [Intel-gfx] [PATCH 2/7] drm/i915: add DisplayPort amp unmute for LPE audio mode

2017-02-02 Thread Takashi Iwai
On Tue, 31 Jan 2017 22:36:44 +0100, Takashi Iwai wrote: > > From: Pierre-Louis Bossart > > Enable unmute/mute amp notification. This doesn't seem to affect > HDMI support so this is done unconditionally. > > An earlier version of this patch set a chicken bit at addr

Re: [Intel-gfx] [PATCH 2/7] drm/i915: add DisplayPort amp unmute for LPE audio mode

2017-02-02 Thread Takashi Iwai
On Thu, 02 Feb 2017 11:06:05 +0100, Ville Syrjälä wrote: > > On Thu, Feb 02, 2017 at 10:57:30AM +0100, Takashi Iwai wrote: > > On Tue, 31 Jan 2017 22:36:44 +0100, > > Takashi Iwai wrote: > > > > > > From: Pierre-Louis Bossart > > > > > >

Re: [Intel-gfx] [PATCH] drm/i915: Enable VLV audio chicken bit for LPE audio

2017-02-03 Thread Takashi Iwai
On Thu, 02 Feb 2017 11:12:53 +0100, Takashi Iwai wrote: > > The audio chicken bit (register offset 0x62f38) seems required to make > DP audio working on some machines. At least, on Dell Wyse 3040, I > failed to get the audio unless this bit is set once. > > Strangely, the b

Re: [Intel-gfx] [PATCH] drm/i915: Enable VLV audio chicken bit for LPE audio

2017-02-03 Thread Takashi Iwai
On Fri, 03 Feb 2017 15:54:33 +0100, Ville Syrjälä wrote: > > On Fri, Feb 03, 2017 at 02:32:37PM +0100, Takashi Iwai wrote: > > On Thu, 02 Feb 2017 11:12:53 +0100, > > Takashi Iwai wrote: > > > > > > The audio chicken bit (register offset 0x62f38) seems requir

Re: [Intel-gfx] [PATCH] ALSA: x86: Fix spinlock usage in the trigger callback

2017-02-15 Thread Takashi Iwai
io] > [ 168.729545] process_one_work+0x1eb/0x6e0 > [ 168.734022] ? process_one_work+0x15f/0x6e0 > [ 168.738693] worker_thread+0x4f/0x4a0 > [ 168.742781] ? schedule+0x4a/0x90 > [ 168.746483] ? preempt_count_sub+0xa6/0x110 > [ 168.751154] kthread+0x10e/0x150 > [ 168.754757] ? apply_wq

Re: [Intel-gfx] [PATCH] ALSA: x86: Fix spinlock usage in the trigger callback

2017-02-16 Thread Takashi Iwai
On Thu, 16 Feb 2017 15:46:16 +0100, Ville Syrjälä wrote: > > On Wed, Feb 15, 2017 at 10:21:08PM +0100, Takashi Iwai wrote: > > On Wed, 15 Feb 2017 20:15:50 +0100, > > ville.syrj...@linux.intel.com wrote: > > > > > > From: Ville Syrjälä > > > &

[Intel-gfx] [PATCH] drm/i915/gvt: Fix superfluous newline in GVT_DISPLAY_READY env var

2017-02-20 Thread Takashi Iwai
n of size 20 snprintf(display_ready_str, 20, "GVT_DISPLAY_READY=%d\n", ready); ^~~~ Fixes: 04d348ae3f0a ("drm/i915/gvt: vGPU display virtualization") Bugzilla: https://bugzilla.suse.com/show_bug.cgi?id=1025903 Reported-by: Richard Biene

Re: [Intel-gfx] [PATCH 1/2] i2c: designware: Never suspend i2c-busses used for accessing the system PMIC

2017-02-27 Thread Takashi Iwai
On Mon, 27 Feb 2017 10:38:29 +0100, Hans de Goede wrote: > > index a8e74ca..a4ac473 100644 > --- a/drivers/i2c/busses/i2c-designware-core.h > +++ b/drivers/i2c/busses/i2c-designware-core.h > @@ -79,7 +79,7 @@ > * @pm_qos: pm_qos_request used while holding a hardware lock on the bus > * @acquir

Re: [Intel-gfx] [PATCH 1/2] i2c: designware: Never suspend i2c-busses used for accessing the system PMIC

2017-02-27 Thread Takashi Iwai
On Mon, 27 Feb 2017 11:32:45 +0100, Hans de Goede wrote: > > Hi, > > On 27-02-17 11:25, Takashi Iwai wrote: > > On Mon, 27 Feb 2017 10:38:29 +0100, > > Hans de Goede wrote: > >> > >> index a8e74ca..a4ac473 100644 > >> --- a/drivers/i2c/busses/

Re: [Intel-gfx] [PATCH] ACPI / bus: Introduce a list of ids for "always present" devices

2017-02-27 Thread Takashi Iwai
On Mon, 27 Feb 2017 15:25:32 +0100, Hans de Goede wrote: > > Hi, > > On 27-02-17 14:30, Rafael J. Wysocki wrote: > > +Mika & Andy > > > > On Saturday, February 25, 2017 07:23:28 PM Hans de Goede wrote: > >> Several cherrytrail devices (all of which ship with windows 10) hide the > >> lpss pwm con

Re: [Intel-gfx] [PATCH] ACPI / bus: Introduce a list of ids for "always present" devices

2017-02-27 Thread Takashi Iwai
On Mon, 27 Feb 2017 22:27:58 +0100, Rafael J. Wysocki wrote: > > On Mon, Feb 27, 2017 at 3:40 PM, Takashi Iwai wrote: > > On Mon, 27 Feb 2017 15:25:32 +0100, > > Hans de Goede wrote: > >> > >> Hi, > >> > >> On 27-02-17 14:30, Rafael J. Wysock

[Intel-gfx] 4.2-rc4 kernel warnings on HSW laptop

2015-10-10 Thread Takashi Iwai
Hi, I noticed that a HSW laptop gets a few new warnings since 4.2-rc kernels. One error messages pops at each boot time: Console: switching to colour dummy device 80x25 [drm] Replacing VGA console driver [drm] Supports vblank timestamp caching Rev 2 (21.10.2013). [drm] Driver supports precis

Re: [Intel-gfx] 4.2-rc4 kernel warnings on HSW laptop [regression]

2015-10-12 Thread Takashi Iwai
On Mon, 12 Oct 2015 09:04:20 +0200, Daniel Vetter wrote: > > Another pile of regressions for Jairo to track ... > > On Sat, Oct 10, 2015 at 11:46:29AM +0200, Takashi Iwai wrote: > > Hi, > > > > I noticed that a HSW laptop gets a few new warnings since 4.2-rc &g

Re: [Intel-gfx] 4.2-rc4 kernel warnings on HSW laptop [regression]

2015-10-12 Thread Takashi Iwai
On Mon, 12 Oct 2015 14:29:19 +0200, Takashi Iwai wrote: > > > > Then a warning when I start powertop: > > > > > > WARNING: CPU: 1 PID: 1674 at drivers/gpu/drm/drm_atomic.c:889 > > > drm_atomic_get_property+0x232/0x2b0 [drm]() > > > CPU

Re: [Intel-gfx] [PATCH v2] drm/i915: Improve kernel-doc for i915_audio_component struct

2015-10-13 Thread Takashi Iwai
On Mon, 12 Oct 2015 10:17:51 +0200, David Henningsson wrote: > > > > On 2015-10-12 10:07, David Henningsson wrote: > > To make kernel-doc happy, the i915_audio_component_audio_ops struct > > cannot be nested. > > > > Signed-off-by: David Henningsson > > --- > > Changes since v1: > > * Added

Re: [Intel-gfx] [PATCH v6 4/4] drm/i915: set proper N/CTS in modeset

2015-10-19 Thread Takashi Iwai
On Mon, 19 Oct 2015 10:25:22 +0200, Jani Nikula wrote: > > On Wed, 02 Sep 2015, Takashi Iwai wrote: > > On Wed, 02 Sep 2015 11:02:42 +0200, > > Jani Nikula wrote: > >> > >> >> Nitpick. I'd prefer some sharing with the similar blocks from the > &

[Intel-gfx] A wrong DDI encoder override from HDMI to DP at hotplug

2015-11-18 Thread Takashi Iwai
Hi, currently a DDI port may register both DP and HDMI and it shares the same encoder. The bug we've got a report is about this encoder type: namely, a machine using DDI port D for HDMI is screwed up because the encoder is switched to DP suddently. The details are found in: http://bugzilla.ope

<    1   2   3   4   5   6   7   >