Re: [Intel-gfx] [PATCH] Lower threshold for pixel doubling.

2013-05-29 Thread Stuart Abercrombie
=8fcf9a81179ee8577ddab5e904c58fbfd14cf59c . Stuart On Mon, May 20, 2013 at 11:15 AM, Stuart Abercrombie < sabercrom...@chromium.org> wrote: > 90% of core speed (=180MHz dot clock) is too high for 2048x1280 to get > pixel doubling on Pineview, which it needs to avoid underruns, so > l

Re: [Intel-gfx] [PATCH] Lower threshold for pixel doubling.

2013-05-29 Thread Stuart Abercrombie
at 170MHz. Stuart On Wed, May 29, 2013 at 8:22 AM, Daniel Vetter wrote: > On Tue, May 28, 2013 at 10:39:07AM -0700, Stuart Abercrombie wrote: > > Any comments? > > > > Without this, plugging one of the older Chromebook models into a Dell > U3011 > > monitor p

[Intel-gfx] [PATCH] Avoid i915 flip unpin/HPD event handler deadlock.

2013-08-30 Thread Stuart Abercrombie
Both of these were taking the mode_config mutex but executed from the same work queue. If intel_crtc_page_flip happened to flush a work queue containing an HPD event handler work item, deadlock resulted, since the mutex required by the HPD handler was taken before the flush. Instead use a separat

[Intel-gfx] [PATCH] Lower threshold for pixel doubling.

2013-05-20 Thread Stuart Abercrombie
90% of core speed (=180MHz dot clock) is too high for 2048x1280 to get pixel doubling on Pineview, which it needs to avoid underruns, so lower this to 85%. Signed-off-by: Stuart Abercrombie --- drivers/gpu/drm/i915/intel_display.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff

[Intel-gfx] [PATCH] Poll for HDMI disconnects.

2012-10-11 Thread Stuart Abercrombie
Following a hotplug interrupt the driver uses a successful EDID read to indicate HDMI sink presence. This leads to missing HDMI cable unplug events because the DDC lines can remain up, allowing an EDID read to complete, well after the HPD line goes down during unplugging Since it is only the d

Re: [Intel-gfx] [PATCH] Poll for HDMI disconnects.

2012-10-12 Thread Stuart Abercrombie
> Nope, the real fix is to simply check the status of the hpd line before > trying the edid read. We already have that for g4x class chips, check > g4x_hdmi_connected. We'd need to add similar checks for all other > platforms. > -Daniel That would be preferable. Unfortunately we did not find a wa

Re: [Intel-gfx] [PATCH] Poll for HDMI disconnects.

2012-10-12 Thread Stuart Abercrombie
> In the hotplug register, like on g4x. But that moved to to PCH_IIR on pch > platforms. I plan to rework the entire hotplug handling for 3.8, hence why > I haven't bothered to wire this up yet. You are saying that the HPD line state is available in the register called SDEIIR in the code? The doc

Re: [Intel-gfx] [PATCH] Poll for HDMI disconnects.

2012-10-12 Thread Stuart Abercrombie
> My docs here say that the SDE_ISR reg contains what we want - high > level irq bit when the hpd line is enabled. I admit, I haven't tested > this ... I'm looking at 2.1.1 in this http://intellinuxgraphics.org/documentation/SNB/IHD_OS_Vol3_Part3.pdf. All it has relating to hotplug in SDEIIR are

Re: [Intel-gfx] [PATCH] Poll for HDMI disconnects.

2012-10-12 Thread Stuart Abercrombie
> I've tried to be slightly lazy than in my previous mail and quickly > tested this on my snb here: Bit 23 in SDEISR (0xc4000) is set when the > cable is plugged in, and cleared when nothing is plugged in. Afaict it > works as advertised. Note tha the SDE irq definitions nicely > differentiates bet