Re: [Intel-gfx] [PATCH 1/5] drm/i915: Rename intel_wa_registers with a i915_ prefix

2014-09-01 Thread Siluvery, Arun
On 30/08/2014 16:50, Damien Lespiau wrote: Those debugfs files are prefixed by i915, the name of the kernel module, presumably to make the difference with files exposed by core DRM. Also, add a ',' at the end of the last entry. This is to ease the conflict resolution when rebasing internal patch

Re: [Intel-gfx] [PATCH 5/5] drm/i915: Don't restrict i915_wa_registers to BDW

2014-09-01 Thread Siluvery, Arun
On 30/08/2014 16:51, Damien Lespiau wrote: We have CHV code that already makes the test obsolete. Besides, when num_wa_regs is 0 (platforms not gathering that W/A data), we expose something sensible already. Signed-off-by: Damien Lespiau --- drivers/gpu/drm/i915/i915_debugfs.c | 5 - 1 f

Re: [Intel-gfx] [PATCH 4/4] drm/i915: Rework workaround data exporting to debugfs

2014-09-01 Thread Siluvery, Arun
On 01/09/2014 15:06, Damien Lespiau wrote: On Mon, Sep 01, 2014 at 02:28:53PM +0100, Arun Siluvery wrote: Now w/a are organized in an array so we know exactly how many of them are applied; use the same array while exporting data to debugfs and remove the temporary array we currently have in driv

Re: [Intel-gfx] [PATCH igt] gem_workarounds: intel_wa_registers is now prefixed with i915

2014-09-03 Thread Siluvery, Arun
On 30/08/2014 22:46, Damien Lespiau wrote: Signed-off-by: Damien Lespiau --- tests/gem_workarounds.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/gem_workarounds.c b/tests/gem_workarounds.c index 6826562..32156d2 100644 --- a/tests/gem_workarounds.c +++ b/tests/ge

Re: [Intel-gfx] [PATCH 0/5] A few fixes on top of the wa_regs patches

2014-09-03 Thread Siluvery, Arun
On 30/08/2014 16:50, Damien Lespiau wrote: Hi Arun, I've compiled a few patches that I think solve some small-ish issues around your wa_regs series. Could you please have a look at them and comment/give your r-b tag if you judge appropriate? On top of those patches, I'd love some comments on th

Re: [Intel-gfx] [PATCH 3/4] drm/i915: Build workaround list in ring initialization

2014-10-13 Thread Siluvery, Arun
On 07/10/2014 15:21, Mika Kuoppala wrote: If we build the workaround list in ring initialization and decouple it from the actual writing of values, we gain the ability to decide where and how we want to apply the values. The advantage of this will become more clear when we need to initialize wor

Re: [Intel-gfx] [PATCH 4/4] drm/i915: Check workaround status on dfs read time

2014-10-13 Thread Siluvery, Arun
On 07/10/2014 15:21, Mika Kuoppala wrote: As the workaround list has the value as initialization time constant, we can do the simple checking on the go without negleting igt. Signed-off-by: Mika Kuoppala --- drivers/gpu/drm/i915/i915_debugfs.c | 14 +++--- 1 file changed, 7 insertion

Re: [Intel-gfx] [PATCH 3/4] drm/i915: Build workaround list in ring initialization

2014-10-20 Thread Siluvery, Arun
On 07/10/2014 15:21, Mika Kuoppala wrote: If we build the workaround list in ring initialization and decouple it from the actual writing of values, we gain the ability to decide where and how we want to apply the values. The advantage of this will become more clear when we need to initialize wor

Re: [Intel-gfx] [PATCH] drm/i915: add missing forcewake put on i915_wa_registers()

2014-10-22 Thread Siluvery, Arun
On 22/10/2014 08:35, Ville Syrjälä wrote: On Tue, Oct 21, 2014 at 07:40:35PM +0200, Daniel Vetter wrote: On Tue, Oct 21, 2014 at 02:58:08PM -0200, Paulo Zanoni wrote: From: Paulo Zanoni Otherwise, a simple "cat" to the debugfs file can make the machine use much more power than needed, and pre

Re: [Intel-gfx] [PATCH] drm/i915: Emit even number of dwords when emitting LRIs

2014-10-23 Thread Siluvery, Arun
On 23/10/2014 14:41, Ville Syrjälä wrote: On Thu, Oct 23, 2014 at 01:50:23PM +0100, Chris Wilson wrote: On Thu, Oct 23, 2014 at 01:42:38PM +0100, Damien Lespiau wrote: On Thu, Oct 23, 2014 at 02:21:02PM +0200, Daniel Vetter wrote: On Wed, Oct 22, 2014 at 06:59:52PM +0100, Arun Siluvery wrote:

Re: [Intel-gfx] [PATCH] drm/i915: Add means to apply WA conditionally

2014-10-23 Thread Siluvery, Arun
On 23/10/2014 16:51, Daniel Vetter wrote: On Thu, Oct 23, 2014 at 04:29:30PM +0100, Arun Siluvery wrote: We would want to apply some of the workarounds based on a condition to a particular platform or Gen but we may not know all possible controlling parameters in advance hence allow to define op

<    1   2