Re: [Intel-gfx] [PATCH v3] drm/dp: Add Additional DP2 Headers

_CUSTOM_PATTERN_263_256 0x2250 > > + > > +/* DSC Extended Capability Branch Total DSC Resources */ > > +#define DP_DSC_SUPPORT_AND_DSC_DECODER_COUNT 0x2260 /* 2.0 > > */ > > +# define DP_DSC_DECODER_COUNT_MASK (0b111 << 5) > > +# define DP_DSC_DECODER_COUNT

[Intel-gfx] [PATCH i-g-t] Make force work with multiple drivers available

that using Bochs and VKMS. This patch handles this scenario by ensuring that IGT uses the forced module specified via IGT_FORCE_DRIVER. Signed-off-by: Rodrigo Siqueira --- lib/drmtest.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/lib/drmtest.c b/lib/drmtest.c

Re: [Intel-gfx] [PATCH i-g-t] Make force work with multiple drivers available

On 01/14, Petri Latvala wrote: > On Fri, Jan 11, 2019 at 11:13:37AM -0200, Rodrigo Siqueira wrote: > > The force option allows users to specify which driver they want that IGT > > uses. Nonetheless, if the user has two or more loaded drivers in his > > system, the force op

Re: [Intel-gfx] [PATCH i-g-t] tests/kms_flip: Add test to check suspend/resume

915 driver and I noticed that the test took much more than 30 seconds to finish. Is it right? Thanks Best Regards > }; > int i; > > -- > 2.17.1 > -- Rodrigo Siqueira https://siqueira.tech Graduate Student Department of Computer Science University of São Paulo

Re: [Intel-gfx] [PATCH i-g-t v2] tests/kms_flip: Add test to check suspend/resume

{ 10, TEST_FLIP | TEST_SUSPEND, "flip-vs-suspend" }, > }; > int i; > > -- > 2.17.1 > Reviewed-by: Rodrigo Siqueira signature.asc Description: PGP signature ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] [PATCH V3 i-g-t] Skip VBlank tests in modules without VBlank

: Chris Wilson: - Change function name from igt_there_is_vblank to kms_has_vblank - Move vblank function check from igt_aux to igt_kms - Utilizes memset in dummy_vbl variable - Directly return the result of drmWaitVBlank() Signed-off-by: Rodrigo Siqueira --- lib/igt_kms.c| 11

[Intel-gfx] [PATCH V2 i-g-t] lib: Drop __kms_addfb() wrapper

__kms_addfb() Signed-off-by: Rodrigo Siqueira --- lib/igt_fb.c| 14 +- lib/ioctl_wrappers.c| 33 - lib/ioctl_wrappers.h| 11 --- tests/kms_available_modes_crc.c | 14 +- tests/kms_draw_crc.c

[Intel-gfx] [RESEND PATCH V7 i-g-t] tests/kms_flip: Skip VBlank tests in modules without VBlank

vblank function check from igt_aux to igt_kms - Utilizes memset in dummy_vbl variable - Directly return the result of drmWaitVBlank() Signed-off-by: Rodrigo Siqueira --- lib/igt_kms.c| 21 + lib/igt_kms.h| 2 ++ tests/kms_flip.c | 22 ++ 3 files

Re: [Intel-gfx] [igt-dev] [PATCH V2 i-g-t] lib: Drop __kms_addfb() wrapper

Hi Simon, Thank you very much for your review. I'll fix the issue in the next version. On Mon, May 20, 2019 at 3:22 AM Ser, Simon wrote: > > Hi Rodrigo, > > On Sun, 2019-05-19 at 20:00 -0300, Rodrigo Siqueira wrote: > > The function __kms_addfb() and drmModeAddFB

[Intel-gfx] [PATCH V3 i-g-t] lib: Drop __kms_addfb() wrapper

array initialization - Drop __kms_addfb() Signed-off-by: Rodrigo Siqueira --- lib/igt_aux.h | 3 +++ lib/igt_fb.c| 14 +- lib/ioctl_wrappers.c| 33 - lib/ioctl_wrappers.h| 11

[Intel-gfx] [PATCH i-g-t] lib: Rework __kms_addfb() function

The function __kms_addfb() and drmModeAddFB2WithModifiers() have a similar code. Due to this similarity, this commit replace part of the code inside __kms_addfb() by using drmModeAddFB2WithModifiers(). Signed-off-by: Rodrigo Siqueira --- lib/ioctl_wrappers.c | 27 ++- 1

Re: [Intel-gfx] [PATCH i-g-t] lib: Rework __kms_addfb() function

Hi, First of all, thank you for your review. I just have a few questions below. On 04/10, Arkadiusz Hiler wrote: > On Wed, Apr 03, 2019 at 07:24:39PM -0300, Rodrigo Siqueira wrote: > > The function __kms_addfb() and drmModeAddFB2WithModifiers() have a > > similar code. Due to

[Intel-gfx] [RESEND PATCH v6 i-g-t] tests/kms_flip: Skip VBlank tests in modules without VBlank

dummy_vbl variable - Directly return the result of drmWaitVBlank() Signed-off-by: Rodrigo Siqueira --- Updates: 1. Rebase the code with the last updates from the master. 2. Patch tested on VC4, Bochs, VKMS, and i915. lib/igt_kms.c| 20 lib/igt_kms.h| 2 ++ tests

Re: [Intel-gfx] [RESEND PATCH v6 i-g-t] tests/kms_flip: Skip VBlank tests in modules without VBlank

On 04/18, Chris Wilson wrote: > Quoting Rodrigo Siqueira (2019-04-18 15:01:49) > > +bool kms_has_vblank(int fd) > > +{ > > + drmVBlank dummy_vbl; > > + > > + memset(&dummy_vbl, 0, sizeof(drmVBlank)); > > + d

[Intel-gfx] [PATCH v7 i-g-t] tests/kms_flip: Skip VBlank tests in modules without VBlank

check from igt_aux to igt_kms - Utilizes memset in dummy_vbl variable - Directly return the result of drmWaitVBlank() Signed-off-by: Rodrigo Siqueira --- lib/igt_kms.c| 21 + lib/igt_kms.h| 2 ++ tests/kms_flip.c | 22 ++ 3 files changed, 45

[Intel-gfx] [PATCH V4 i-g-t] Skip VBlank tests in modules without VBlank

in dummy_vbl variable - Directly return the result of drmWaitVBlank() Signed-off-by: Rodrigo Siqueira --- lib/igt_kms.c| 20 lib/igt_kms.h| 2 ++ tests/kms_flip.c | 27 +-- 3 files changed, 47 insertions(+), 2 deletions(-) diff --git a/lib

[Intel-gfx] [PATCH i-g-t 0/7] kms_flip: cleanups

patchset can be seen in two parts: 1. Eliminates unreachable tests 2. Basic cleanups with the goal to improve the code readability In particular, the patch number three enables kms_flip to work without any issue in any non-intel drivers. Rodrigo Siqueira (7): kms_flip: Removes unreachable code

[Intel-gfx] [PATCH i-g-t 1/7] kms_flip: Removes unreachable code related to TEST_RPM

This commit removes the code related to TEST_RPM test because the kms_flip never sets this flags, i.e., TEST_RPM is not used. Take a look at commit 07a3fccf to see why this flag is never set. Signed-off-by: Rodrigo Siqueira --- tests/kms_flip.c | 15 --- 1 file changed, 15 deletions

[Intel-gfx] [PATCH i-g-t 2/7] kms_flip: Removes unreachable code related to TEST_TS_CONT

This commit removes the code related to TEST_TS_CONT test because the kms_flip never sets this flags, i.e., TEST_TS_CONT is not used. Take a look at commit 07a3fccf to see why this flag is never set. Signed-off-by: Rodrigo Siqueira --- tests/kms_flip.c | 16 1 file changed, 16

[Intel-gfx] [PATCH i-g-t 3/7] kms_flip: Fix warning related to i915 gem dependence

: Invalid argument Assuming 131072kB available aperture size. May lead to reduced performance or incorrect rendering. get chip id failed: -1 [22] This commit handles this specific dependence with the i915 driver which make the kms_flip logs better. Signed-off-by: Rodrigo Siqueira --- tests

[Intel-gfx] [PATCH i-g-t 4/7] kms_flip: Remove unreachable condition in wait_for_events

cond assert condition will not be reached because of the first assertion. This commit removes the code duplication and update the error message. Signed-off-by: Rodrigo Siqueira --- tests/kms_flip.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/tests/kms_flip.c b/tests

[Intel-gfx] [PATCH i-g-t 5/7] kms_flip: Remove magic constant in run_test_on_crtc_set()

. This patch creates two constant with the goal to improve the readability. Signed-off-by: Rodrigo Siqueira --- tests/kms_flip.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/tests/kms_flip.c b/tests/kms_flip.c index 9ef77de9..42ae3ebc 100755 --- a/tests

[Intel-gfx] [PATCH i-g-t 6/7] kms_flip: Rework set_mode()

This patch removes the duplicate code inside the function set_mode(). Signed-off-by: Rodrigo Siqueira --- tests/kms_flip.c | 26 ++ 1 file changed, 14 insertions(+), 12 deletions(-) diff --git a/tests/kms_flip.c b/tests/kms_flip.c index 42ae3ebc..de3ab600 100755 --- a

[Intel-gfx] [PATCH i-g-t 7/7] kms_flip: Standardize return value for fb_is_bound

The function fb_is_bound() mix integer value with booleans for handling the return value. This commit standardizes the return value of fb_is_bound() for using only booleans. Signed-off-by: Rodrigo Siqueira --- tests/kms_flip.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t v2] Add support for forcing specific module

On 12/17, Daniel Vetter wrote: > On Wed, Sep 05, 2018 at 05:38:27PM -0300, Rodrigo Siqueira wrote: > > This commit adds a new option for forcing the use of a specific driver > > indicated via an environment variable. > > > > Changes since V1: > > Petri: > >

Re: [Intel-gfx] [PATCH] drm/vblank: Document and fix vblank count barrier semantics

> > Cc: Ville Syrjälä > Cc: Keith Packard > References: 570e86963a51 ("drm: Widen vblank count to 64-bits [v3]") > Cc: Rodrigo Siqueira > Cc: Chris Wilson > Signed-off-by: Daniel Vetter > --- > drivers/gpu/drm/drm_vblank.c | 45 +

Re: [Intel-gfx] [PATCH 2/3] drm/vkms: Use wait_for_flip_done

wait_for_vblanks by drm_atomic_helper_wait_for_flip_done? I noticed that only six drivers use these functions; they are: * atmel-hlcdc * mediatek * msm * tegra * tilcdc * virtio If we change these drivers, can we drop the helper drm_atomic_helper_wait_for_vblanks? Reviewed-by: Rodrigo Siqueira Thanks > Signed

Re: [Intel-gfx] [PATCH 3/3] drm/vkms: Reduce critical section in vblank_simulate

Thanks for this patch! It looks good for me. Reviewed-by: Rodrigo Siqueira On 07/19, Daniel Vetter wrote: > We can reduce the critical section in vkms_vblank_simulate under > output->lock quite a lot: > > - hrtimer_forward_now just needs to be ordered correctly wrt > drm_

Re: [Intel-gfx] [PATCH] drm/vblank: Document and fix vblank count barrier semantics

Hi, thanks for the explanation. I noticed that I forgot to add my r-b. Reviewed-by: Rodrigo Siqueira On 09/03, Daniel Vetter wrote: > On Tue, Sep 03, 2019 at 08:47:03AM -0400, Rodrigo Siqueira wrote: > > Hi Daniel, > > > > All the series look really good for me. I just ha

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t v5 1/6] lib/igt_kms: Add writeback support

patchset I will be glad to help since I’m using it \o/ Best Regards Rodrigo Siqueira On 02/04, Brian Starkey wrote: > Hi Liviu, > > On Tue, Jan 15, 2019 at 05:47:42PM +, Liviu Dudau wrote: > > From: Brian Starkey > > [snip] > > > > > +/** > >

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t 7/7] kms_flip: Standardize return value for fb_is_bound

On 03/06, Maarten Lankhorst wrote: > Op 04-03-2019 om 16:32 schreef Rodrigo Siqueira: > > The function fb_is_bound() mix integer value with booleans for handling > > the return value. This commit standardizes the return value of > > fb_is_bound() for using only booleans.

Re: [Intel-gfx] [PATCH 16/17] drm/vkms: Convert to using __drm_atomic_helper_crtc_reset() for reset.

On 03/01, Maarten Lankhorst wrote: > Convert vkms to using __drm_atomic_helper_crtc_reset(), instead of > writing its own version. Instead of open coding destroy_state(), > call it directly for freeing the old state. > > Signed-off-by: Maarten Lankhorst > Cc: Rodrigo Siqu

[Intel-gfx] [RFC i-g-t] lib/igt_kms: Set capabilities before get resource

real patch. 1. https://patchwork.freedesktop.org/series/39229/ Signed-off-by: Rodrigo Siqueira --- lib/igt_kms.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/igt_kms.c b/lib/igt_kms.c index 7ebab4ca..2de9ac41 100644 --- a/lib/igt_kms.c +++ b/lib/igt_kms.c @@ -18

[Intel-gfx] [PATCH V5 i-g-t] tests/kms_flip: Skip VBlank tests in modules without VBlank

drmWaitVBlank() Signed-off-by: Rodrigo Siqueira --- lib/igt_kms.c| 20 lib/igt_kms.h| 2 ++ tests/kms_flip.c | 22 ++ 3 files changed, 44 insertions(+) diff --git a/lib/igt_kms.c b/lib/igt_kms.c index e1eacc1e..1d2d7188 100644 --- a/lib/igt_kms.c

Re: [Intel-gfx] [igt-dev] [PATCH V5 i-g-t] tests/kms_flip: Skip VBlank tests in modules without VBlank

On 03/18, Ville Syrjälä wrote: > On Sat, Mar 16, 2019 at 11:00:23AM -0300, Rodrigo Siqueira wrote: > > The kms_flip test relies on VBlank support, and this situation may > > exclude some virtual drivers to take advantage of this set of tests. > > This commit adds a mecha

Re: [Intel-gfx] [igt-dev] [PATCH V5 i-g-t] tests/kms_flip: Skip VBlank tests in modules without VBlank

On 03/18, Chris Wilson wrote: > Quoting Rodrigo Siqueira (2019-03-18 21:35:44) > > On 03/18, Ville Syrjälä wrote: > > > On Sat, Mar 16, 2019 at 11:00:23AM -0300, Rodrigo Siqueira wrote: > > > > The kms_flip test relies on VBlank support, and this situation may > &

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t v5 1/6] lib/igt_kms: Add writeback support

On 03/18, Liviu Dudau wrote: > On Wed, Mar 06, 2019 at 06:30:05PM -0300, Rodrigo Siqueira wrote: > > Hi Liviu, > > > > I’m using your patchset to guide my implementation of writeback in the > > VKMS, so, first of all, thanks :) > > > > During my

Re: [Intel-gfx] [igt-dev] [PATCH V5 i-g-t] tests/kms_flip: Skip VBlank tests in modules without VBlank

On 03/18, Chris Wilson wrote: > Quoting Rodrigo Siqueira (2019-03-18 21:53:42) > > On 03/18, Chris Wilson wrote: > > > Quoting Rodrigo Siqueira (2019-03-18 21:35:44) > > > > On 03/18, Ville Syrjälä wrote: > > > > > On Sat, Mar 16, 2019 at 11:00:23AM -

[Intel-gfx] [PATCH V6 i-g-t] tests/kms_flip: Skip VBlank tests in modules without VBlank

dummy_vbl variable - Directly return the result of drmWaitVBlank() Signed-off-by: Rodrigo Siqueira --- lib/igt_kms.c| 20 lib/igt_kms.h| 2 ++ tests/kms_flip.c | 22 ++ 3 files changed, 44 insertions(+) diff --git a/lib/igt_kms.c b/lib/igt_kms.c

Re: [Intel-gfx] [PATCH V3 i-g-t] lib: Drop __kms_addfb() wrapper

Hi Chris, Thank you for your feedback and the explanation about igt_ioctl, now I've got it. On Mon, May 27, 2019 at 7:13 AM Chris Wilson wrote: > > Quoting Rodrigo Siqueira (2019-05-27 02:19:51) > > The function __kms_addfb() and drmModeAddFB2WithModifiers() have a > > si

[Intel-gfx] [PATCH V8 i-g-t] tests/kms_flip: Skip VBlank tests in modules without VBlank

commit message V1: Chris Wilson - Change function name from igt_there_is_vblank to kms_has_vblank - Move vblank function check from igt_aux to igt_kms - Utilizes memset in dummy_vbl variable - Directly return the result of drmWaitVBlank() Signed-off-by: Rodrigo Siqueira --- lib/igt_kms.c

Re: [Intel-gfx] [PATCH V8 i-g-t] tests/kms_flip: Skip VBlank tests in modules without VBlank

On 06/06, Ser, Simon wrote: > On Tue, 2019-06-04 at 23:30 -0300, Rodrigo Siqueira wrote: > > The kms_flip test relies on VBlank support, and this situation may > > exclude some virtual drivers to take advantage of this set of tests. > > This commit adds a mechanism that c

[Intel-gfx] [RESEND PATCH V3] drm/drm_vblank: Change EINVAL by the correct errno

Vetter and Chris Wilson - Replace ENOTTY by EOPNOTSUPP - Return EINVAL if the parameters are wrong Signed-off-by: Rodrigo Siqueira --- Update: Now IGT has a way to validate if a driver has vblank support or not. See: https://gitlab.freedesktop.org/drm/igt-gpu-tools/commit/2d244aed69165753f

[Intel-gfx] [PATCH V6 i-g-t 0/6] igt: Add support for testing writeback connectors

teback.c | 492 + tests/meson.build | 1 + 7 files changed, 692 insertions(+), 38 deletions(-) create mode 100644 tests/kms_writeback.c -- 2.21.0 -- Rodrigo Siqueira https://siqueira.tech signature.asc Description: PGP signature __

Re: [Intel-gfx] Drop use of DRM_WAIT_ON() [Was: drm/drm_vblank: Change EINVAL by the correct errno]

wrote: > > Hi Rodrigo. > > On Wed, Jun 12, 2019 at 11:10:54PM -0300, Rodrigo Siqueira wrote: > > For historical reason, the function drm_wait_vblank_ioctl always return > > -EINVAL if something gets wrong. This scenario limits the flexibility > > for the userspace mak

Re: [Intel-gfx] [PATCH V6 i-g-t 1/6] lib/igt_kms: Add writeback support

* @drm_fd: A drm file descriptor > > diff --git a/lib/igt_kms.h b/lib/igt_kms.h > > index a448a003..cacc6b90 100644 > > --- a/lib/igt_kms.h > > +++ b/lib/igt_kms.h > > @@ -123,6 +123,9 @@ enum igt_atomic_connector_properties { > > IGT_CONNECTOR_BROADCAST_R

[Intel-gfx] [PATCH V4] drm/drm_vblank: Change EINVAL by the correct errno

3: - Return EINVAL for _DRM_VBLANK_SIGNAL (Daniel) Change since V2: Daniel Vetter and Chris Wilson - Replace ENOTTY by EOPNOTSUPP - Return EINVAL if the parameters are wrong Signed-off-by: Rodrigo Siqueira --- drivers/gpu/drm/drm_vblank.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

Re: [Intel-gfx] [PATCH V4] drm/drm_vblank: Change EINVAL by the correct errno

On 06/19, Daniel Vetter wrote: > On Wed, Jun 19, 2019 at 09:48:56AM +0200, Daniel Vetter wrote: > > On Tue, Jun 18, 2019 at 11:07:50PM -0300, Rodrigo Siqueira wrote: > > > For historical reason, the function drm_wait_vblank_ioctl always return > > > -EINVAL if somethin

Re: [Intel-gfx] [PATCH V4] drm/drm_vblank: Change EINVAL by the correct errno

On Wed, Jun 26, 2019 at 4:53 AM Daniel Vetter wrote: > > On Wed, Jun 26, 2019 at 4:00 AM Rodrigo Siqueira > wrote: > > > > On 06/19, Daniel Vetter wrote: > > > On Wed, Jun 19, 2019 at 09:48:56AM +0200, Daniel Vetter wrote: > > > > On Tue, Jun 18, 2019 a

[Intel-gfx] [PATCH V5] drm/drm_vblank: Change EINVAL by the correct errno

ce_ioctl Change since V3: - Return EINVAL for _DRM_VBLANK_SIGNAL (Daniel) Change since V2: Daniel Vetter and Chris Wilson - Replace ENOTTY by EOPNOTSUPP - Return EINVAL if the parameters are wrong Cc: Keith Packard Cc: Maarten Lankhorst Cc: Ville Syrjälä Cc: Chris Wilson Cc: Dan

Re: [Intel-gfx] [PATCH] drm/vkms: prime import support

in prime configurations > without using any actual hardware (e.g. in the cloud). > > Cc: Rodrigo Siqueira > Cc: Haneen Mohammed > Cc: Daniel Vetter > Signed-off-by: Oleg Vasilev > --- > drivers/gpu/drm/vkms/vkms_drv.c | 6 + > drivers/gpu/drm/vkms/vkms_drv.h

Re: [Intel-gfx] [igt-dev] [PATCH V6 i-g-t 1/6] lib/igt_kms: Add writeback support

On Wed, Jul 3, 2019 at 9:15 AM Ser, Simon wrote: > > On Tue, 2019-06-18 at 18:56 -0300, Rodrigo Siqueira wrote: > > On Thu, Jun 13, 2019 at 11:54 AM Liviu Dudau wrote: > > > On Wed, Jun 12, 2019 at 11:16:02PM -0300, Brian Starkey wrote: > > > > Add support in

Re: [Intel-gfx] [igt-dev] [PATCH V6 i-g-t 1/6] lib/igt_kms: Add writeback support

On Tue, Jul 9, 2019 at 11:42 AM Ser, Simon wrote: > > On Tue, 2019-07-09 at 11:32 -0300, Rodrigo Siqueira wrote: > > On Wed, Jul 3, 2019 at 9:15 AM Ser, Simon wrote: > > > On Tue, 2019-06-18 at 18:56 -0300, Rodrigo Siqueira wrote: > > > > On Thu, Jun

[Intel-gfx] [PATCH V6] drm/drm_vblank: Change EINVAL by the correct errno

h Packard Cc: Maarten Lankhorst Cc: Ville Syrjälä Cc: Chris Wilson Cc: Daniel Vetter Cc: Pekka Paalanen Signed-off-by: Rodrigo Siqueira --- drivers/gpu/drm/drm_vblank.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/drm_vblank.c b/drivers/gpu/drm/dr

[Intel-gfx] [PATCH v7 i-g-t 0/4] Add support for testing writeback connectors

Hi, A couple of months ago, I updated and re-submitted a patchset made by Brian Starkey and Liviu Dudau for adding a writeback connectors test to IGT. It is important to highlight that DRM already have writeback connectors support, which is a way to expose in DRM the hardware functionality from di

Re: [Intel-gfx] [PATCH v2 19/21] drm/vkms: Convert to CRTC VBLANK callbacks

Hi, Thanks for the patch, I reviewed and tested it. Everything looks fine for VKMS. Reviewed-by: Rodrigo Siqueira Tested-by: Rodrigo Siqueira On 01/15, Thomas Zimmermann wrote: > VBLANK callbacks in struct drm_driver are deprecated in favor of > their equivalents in struct drm_crtc

Re: [Intel-gfx] [PATCH v7 i-g-t 3/4] lib: Add function to hash a framebuffer

Wilson > > > > Signed-off-by: Brian Starkey > > [rebased and updated to the most recent API] > > Signed-off-by: Liviu Dudau > > [rebased and updated the patch to address feedback] > > Signed-off-by: Rodrigo Siqueira > > Reviewed-by: Simon Ser >

Re: [Intel-gfx] [PATCH v7 i-g-t 4/4] kms_writeback: Add writeback-check-output

_fb instead of out_fb for getting the expected CRC > > - Drop unnecessary parentheses > > - Replace igt_fb_mod_to_tiling to DRM_FORMAT_MOD_LINEAR > > > > Signed-off-by: Brian Starkey > > [rebased and updated the patch to address feedback] > > Signed-off-by: Rod

Re: [Intel-gfx] [PATCH v7 i-g-t 4/4] kms_writeback: Add writeback-check-output

On 04/22, Maxime Ripard wrote: > Hi! > > On Tue, Apr 21, 2020 at 05:07:05PM -0400, Rodrigo Siqueira wrote: > > On 04/15, Maxime Ripard wrote: > > > On Mon, Oct 21, 2019 at 10:00:39PM -0300, Brian Starkey wrote: > > > > Add a test which makes commit

[Intel-gfx] [PATCH i-g-t v8 0/4] Add support for testing writeback connectors

Hi, A couple of months ago, I updated and re-submitted a patchset made by Brian Starkey and Liviu Dudau for adding a writeback connectors test to IGT. It is important to highlight that DRM already have writeback connectors support, which is a way to expose in DRM the hardware functionality from di

[Intel-gfx] [PATCH i-g-t v8 1/4] lib/igt_kms: Add writeback support

Dudau [rebased and updated to the latest igt style] Signed-off-by: Rodrigo Siqueira Reviewed-by: Liviu Dudau Reviewed-by: Simon Ser --- lib/igt_kms.c | 57 +++ lib/igt_kms.h | 6 ++ 2 files changed, 63 insertions(+) diff --git a/lib/igt_kms.c b

[Intel-gfx] [PATCH i-g-t v8 4/4] kms_writeback: Add writeback-check-output

ssage if sync_fence_wait fail * Drop color_idx variable * Compute expected CRC based on input framebuffer in writeback_sequence * Remove unnecessary parentheses * Replace int variable for unsigned int Signed-off-by: Brian Starkey [rebased and updated] Signed-off-by: Rodrigo Siqueira Reviewed-by:

[Intel-gfx] [PATCH i-g-t v8 2/4] kms_writeback: Add initial writeback tests

-test related to "writeback-invalid-out-fence" * Replace ret by fb_id in igt_main Reviewed-by: Liviu Dudau Signed-off-by: Brian Starkey [rebased and updated do_writeback_test() function to address feedback] Signed-off-by: Liviu Dudau Signed-off-by: Rodrigo Siqueira --- tests/Makefil

[Intel-gfx] [PATCH i-g-t v8 3/4] lib: Add function to hash a framebuffer

(which can take advantage of word-access speedup), we can do the hash on a cached copy, which is much faster (10x speedup on my platform). Changes since V7 (Maxime Ripard): * Maxime Ripard: - Replace `gem_mmap__gtt` by `igt_fb_map_buffer` on `igt_fb_get_crc()` * Rodrigo Siqueira: - Rename

Re: [Intel-gfx] [igt-dev] [PATCH V6 i-g-t 2/6] kms_writeback: Add initial writeback tests

igt_assert_f(strchr(valid_chars, c[i]), > > +"Unexpected character %c\n", c[i]); > > Honestly, I'm not a fan of this check. There's no guarantee that fourcc > codes will be made from ASCII characters, in fac

Re: [Intel-gfx] [igt-dev] [PATCH V6 i-g-t 3/6] lib: Add function to hash a framebuffer

_format_is_yuv: > > > * @drm_format: drm fourcc > > > diff --git a/lib/igt_fb.h b/lib/igt_fb.h > > > index adefebe1..a2741c05 100644 > > > --- a/lib/igt_fb.h > > > +++ b/lib/igt_fb.h > > > @@ -37,6 +37,7 @@ > > > #include > > > > > > #include "igt_color_encoding.h" > > > +#include "igt_debugfs.h" > > > > > > /* > > > * Internal format to denote a buffer compatible with pixman's > > > @@ -194,5 +195,7 @@ int igt_format_plane_bpp(uint32_t drm_format, int > > > plane); > > > void igt_format_array_fill(uint32_t **formats_array, unsigned int *count, > > > bool allow_yuv); > > > > > > +int igt_fb_get_crc(struct igt_fb *fb, igt_crc_t *crc); > > > + > > > #endif /* __IGT_FB_H__ */ > > > > > > ___ > > > igt-dev mailing list > > > igt-...@lists.freedesktop.org > > > https://lists.freedesktop.org/mailman/listinfo/igt-dev > > ___ > > igt-dev mailing list > > igt-...@lists.freedesktop.org > > https://lists.freedesktop.org/mailman/listinfo/igt-dev -- Rodrigo Siqueira https://siqueira.tech signature.asc Description: PGP signature ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [igt-dev] [PATCH V6 i-g-t 2/6] kms_writeback: Add initial writeback tests

On 07/12, Ser, Simon wrote: > On Thu, 2019-07-11 at 23:44 -0300, Rodrigo Siqueira wrote: > > On 07/10, Ser, Simon wrote: > > > Hi, > > > > > > Thanks for the patch! Here are a few comments. > > > > > > For bonus points, it would be nice t

Re: [Intel-gfx] [igt-dev] [PATCH V6 i-g-t 3/6] lib: Add function to hash a framebuffer

On 07/12, Ser, Simon wrote: > On Thu, 2019-07-11 at 23:49 -0300, Rodrigo Siqueira wrote: > > On 07/10, Ser, Simon wrote: > > > On Wed, 2019-07-10 at 15:30 +, Ser, Simon wrote: > > > > Mostly LGTM, here are a few nits. > > > > > > > >

Re: [Intel-gfx] [igt-dev] [PATCH V6 i-g-t 5/6] lib/igt_kms: Add igt_output_clone_pipe for cloning

old_pipe->outputs &= ~(1 << igt_output_idx(output)); > > + } > > > > - if (pipe != PIPE_NONE) > > + if (pipe != PIPE_NONE) { > > pipe_obj = &display->pipes[pipe]; > > + pipe_obj->outputs = (1 << igt_output_idx(

Re: [Intel-gfx] [igt-dev] [PATCH V6 i-g-t 2/6] kms_writeback: Add initial writeback tests

t; > > + if (output->use_override_mode) > > > > > > > > + memcpy(&mode, &output->override_mode, > > > > > > > > sizeof(mode)); > > > > > > > > + else > > > > > >

Re: [Intel-gfx] [PATCH V5] drm: Add support for DP 1.4 Compliance edid corruption test

127d6e1d3338..957a3d00ee05 100644 > --- a/include/drm/drm_dp_helper.h > +++ b/include/drm/drm_dp_helper.h > @@ -1459,6 +1459,9 @@ static inline ssize_t drm_dp_dpcd_writeb(struct > drm_dp_aux *aux, > int drm_dp_dpcd_read_link_status(struct drm_dp_aux *aux, >u8 status[DP_LIN

Re: [Intel-gfx] [PATCH V6] drm: Add support for DP 1.4 Compliance edid corruption test

gt; > /** @debugfs_entry: debugfs directory for this connector */ > struct dentry *debugfs_entry; > diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h > index 127d6e1d3338..957a3d00ee05 100644 > --- a/include/drm/drm_dp_helper.h > +++ b/include/drm/drm_dp_h

Re: [Intel-gfx] [PATCH 04/25] drm/vkms: Annotate vblank timer

Hi, Everything looks fine to me, I just noticed that the amdgpu patches did not apply smoothly, however it was trivial to fix the issues. Reviewed-by: Rodrigo Siqueira Melissa, Since you are using vkms regularly, could you test this patch and review it? Remember to add your Tested-by when you

[Intel-gfx] [PATCH i-g-t v9 4/4] kms_writeback: Add writeback-check-output

d and updated] Signed-off-by: Rodrigo Siqueira Reviewed-by: Liviu Dudau --- tests/kms_writeback.c | 134 ++ 1 file changed, 134 insertions(+) diff --git a/tests/kms_writeback.c b/tests/kms_writeback.c index f8025538..60dbda2a 100644 --- a/tests/kms_writeb

[Intel-gfx] [PATCH i-g-t v9 0/4] Add support for testing writeback connectors

Hi, A couple of months ago I updated and re-submitted a patchset made by Brian Starkey and Liviu Dudau for adding a writeback connectors test to IGT. It is important to highlight that DRM already have writeback connectors support, which is a way to expose in DRM the hardware functionality from dis

[Intel-gfx] [PATCH i-g-t v9 3/4] lib: Add function to hash a framebuffer

(which can take advantage of word-access speedup), we can do the hash on a cached copy, which is much faster (10x speedup on my platform). Changes since V7 (Maxime Ripard): * Maxime Ripard: - Replace `gem_mmap__gtt` by `igt_fb_map_buffer` on `igt_fb_get_crc()` * Rodrigo Siqueira: - Rename

[Intel-gfx] [PATCH i-g-t v9 2/4] kms_writeback: Add initial writeback tests

by: Liviu Dudau Signed-off-by: Rodrigo Siqueira --- tests/Makefile.sources | 1 + tests/kms_writeback.c | 316 + tests/meson.build | 1 + 3 files changed, 318 insertions(+) create mode 100644 tests/kms_writeback.c diff --git a/tests/Makefile.

[Intel-gfx] [PATCH i-g-t v9 1/4] lib/igt_kms: Add writeback support

updated to the latest igt style] Signed-off-by: Liviu Dudau [rebased and updated to the latest igt style] Signed-off-by: Rodrigo Siqueira Reviewed-by: Liviu Dudau Reviewed-by: Simon Ser --- lib/igt_kms.c | 52 +++ lib/igt_kms.h | 6 ++ 2

Re: [Intel-gfx] [PATCH 14/51] drm/vkms: Use drmm_add_final_kfree

Hi, Thanks for the patch. I reviewed and tested this patch, and everything looks fine. Reviewed-by: Rodrigo Siqueira Tested-by: Rodrigo Siqueira On 02/27, Daniel Vetter wrote: > With this we can drop the final kfree from the release function. > > v2: After drm_dev_init/drmm_add_fi

Re: [Intel-gfx] [PATCH 2/2] drm/atomic: Create and use __drm_atomic_helper_crtc_reset() everywhere

lt > Cc: VMware Graphics > Cc: Sinclair Yeh > Cc: Thomas Hellstrom > Cc: Tony Cheng > Cc: Shirish S > Cc: Mikita Lipski > Cc: Bhawanpreet Lakha > Cc: David Francis > Cc: Anthony Koo > Cc: Jeykumar Sankaran > Cc: Jordan Crouse > Cc: Bruce Wang >

[Intel-gfx] [FOR CI] drm/drm_vblank: Change EINVAL by the correct errno

Vetter and Chris Wilson - Replace ENOTTY by EOPNOTSUPP - Return EINVAL if the parameters are wrong Signed-off-by: Rodrigo Siqueira --- drivers/gpu/drm/drm_vblank.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/drm_vblank.c b/drivers/gpu/drm/drm_vbla

[Intel-gfx] [PATCH i-g-t 0/7] GCC warning cleanup

This patchset fixes all the current GCC 8.1.1 warnings found in the IGT. Rodrigo Siqueira (7): Remove parameter aliases with another argument Cast void * pointer used in arithmetic to uint32_t* Fix comparison that always evaluates to false Fix truncate string in the snprintf Make string

[Intel-gfx] [PATCH i-g-t 1/7] Remove parameter aliases with another argument

d-off-by: Rodrigo Siqueira --- lib/igt_core.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/igt_core.c b/lib/igt_core.c index 3313050c..fa22f12d 100644 --- a/lib/igt_core.c +++ b/lib/igt_core.c @@ -1169,10 +1169,10 @@ bool igt_can_fail(void) static bool run_under_

[Intel-gfx] [PATCH i-g-t 2/7] Cast void * pointer used in arithmetic to uint32_t*

commit cast the ptr pointer, which is a void *, to uint32_t * in the pointer arithmetic operation. Signed-off-by: Rodrigo Siqueira --- lib/igt_fb.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/lib/igt_fb.c b/lib/igt_fb.c index ae71d967..ca905038 100644 --- a/lib/igt_fb.c

[Intel-gfx] [PATCH i-g-t 4/7] Fix truncate string in the snprintf

2 and 1025 bytes into a destination of size 1024 [..] Signed-off-by: Rodrigo Siqueira --- tools/intel_reg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/intel_reg.c b/tools/intel_reg.c index ddff2794..15ebb86a 100644 --- a/tools/intel_reg.c +++ b/tools/intel_reg.c

[Intel-gfx] [PATCH i-g-t 3/7] Fix comparison that always evaluates to false

will be false. This commit changes the comparison to DPLLB_MODE_DAC_SERIAL. Signed-off-by: Rodrigo Siqueira --- tools/intel_reg_decode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/intel_reg_decode.c b/tools/intel_reg_decode.c index f3c7d74a..5a632e09 1006

[Intel-gfx] [PATCH i-g-t 5/7] Make string commands dynamic allocate

destination of size 4096 [..] This patch changes the approach for allocating memory to handle QEMU commands by dynamically allocate space to save the whole command. Signed-off-by: Rodrigo Siqueira --- tools/intel_gvtg_test.c | 27 ++- 1 file changed, 18 insertions(+), 9

[Intel-gfx] [PATCH i-g-t 6/7] Fix truncate string in the strncpy

This patch fix the following GCC Warnings: warning: ‘strncpy’ output truncated before terminating nul copying 36 bytes from a string of the same length [-Wstringop-truncation] [..] Signed-off-by: Rodrigo Siqueira --- tests/perf.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions

[Intel-gfx] [PATCH i-g-t 7/7] Avoid truncate string in __igt_lsof_fds

of size 4096 [..] This commit fixes this problem by changing the string size passed by __igt_lsoft to __igt_lsof_fds. The max size for the string is strlen("/proc/%d/cwd")+1 where "%d" can be estimated with CEILING(LOG_10(INT_MAX)), in this sense, it is safe to define a path si

[Intel-gfx] [PATCH i-g-t 0/2] Add support to force specific module load

ink: https://www.spinics.net/lists/intel-gfx/msg166764.html Rodrigo Siqueira (2): Increase the string size for a module name Add support for forcing specific module lib/drmtest.c| 39 +++ lib/igt_core.c | 23 +++ lib/igt_core.h

[Intel-gfx] [PATCH i-g-t 1/2] Increase the string size for a module name

Some modules name are larger than 5 characters, this can be a problem to add support for other modules. This patch, increase the maximum size in order to enable other modules to use IGT. Signed-off-by: Rodrigo Siqueira --- lib/drmtest.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions

[Intel-gfx] [PATCH i-g-t 2/2] Add support for forcing specific module

This commit adds a new option for forcing the use of a specific module indicated via command line. The force command expects a module name which will be used on the target test (changing the standard behavior). Signed-off-by: Rodrigo Siqueira --- lib/drmtest.c| 33

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t 2/7] Cast void * pointer used in arithmetic to uint32_t*

Hi, Thanks for the feedback, I'm just a little bit confused about the next step here. Is it worth to fix this patch and the others? I got confused since you said that IGT will remove autotools and some of the warnings here does not appear on meson. Best Regards Rodrigo Siqueira On

[Intel-gfx] [PATCH v2 i-g-t 1/2] Make string commands dynamic allocate

-off-by: Rodrigo Siqueira --- tools/intel_gvtg_test.c | 25 - 1 file changed, 16 insertions(+), 9 deletions(-) diff --git a/tools/intel_gvtg_test.c b/tools/intel_gvtg_test.c index 659b7956..ad5ee6a6 100644 --- a/tools/intel_gvtg_test.c +++ b/tools/intel_gvtg_test.c

[Intel-gfx] [PATCH v2 i-g-t 0/2] Fix some GCC warnings

During the compilation, some GCC (8.1) warnings are shown. This patchset address some of the warnings problems. Changes since v2: - Reduce the total amount of bytes allocated during command handling operation - Remove unnecessary memset operation - Improved commit message Rodrigo Siqueira

[Intel-gfx] [PATCH v2 i-g-t 2/2] Fix truncate string in the snprintf

size of decode to support the combination. Changes since V1: - Improve commit message Signed-off-by: Rodrigo Siqueira --- tools/intel_reg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/intel_reg.c b/tools/intel_reg.c index ddff2794..15ebb86a 100644 --- a/tools/intel

Re: [Intel-gfx] [PATCH i-g-t 0/2] Add support to force specific module load

Hi, I would like to know if there is any improvement that I can do for this patchset. Thanks On 07/07, Rodrigo Siqueira wrote: > This patchset adds support for forcing a specific module to be loaded > via command line. This feature can bring benefits for developers that > need to cre

Re: [Intel-gfx] [PATCH v2 i-g-t 0/2] Fix some GCC warnings

Hi, I would like to know if there is any improvement that I can do for this patchset. Thanks On 07/29, Rodrigo Siqueira wrote: > During the compilation, some GCC (8.1) warnings are shown. This patchset > address some of the warnings problems. > > Changes since v2: > - Reduce t

[Intel-gfx] [PATCH i-g-t] Skip VBlank tests in modules without VBlank

: Rodrigo Siqueira --- lib/igt_aux.c| 14 ++ lib/igt_aux.h| 2 ++ tests/kms_flip.c | 26 -- 3 files changed, 40 insertions(+), 2 deletions(-) diff --git a/lib/igt_aux.c b/lib/igt_aux.c index 1250d5c5..da5be4bb 100644 --- a/lib/igt_aux.c +++ b/lib/igt_aux.c

Re: [Intel-gfx] [PATCH i-g-t 1/2] Increase the string size for a module name

On 08/21, Petri Latvala wrote: > On Sat, Jul 07, 2018 at 08:24:39PM -0300, Rodrigo Siqueira wrote: > > Some modules name are larger than 5 characters, this can be a problem to > > add support for other modules. This patch, increase the maximum size in > > order to enable oth

  1   2   >