Re: [Intel-gfx] [PATCH i-g-t] tests/i915_pm_freq_api: Ignore zero register value

2023-08-14 Thread Riana Tauro
me_status is active (igt_get_runtime_pm_status() == IGT_RUNTIME_PM_STATUS_ACTIVE) ? Thanks Riana Tauro /* Manually trigger a GT reset */ fd = igt_debugfs_gt_open(i915, gt, "reset", O_WRONLY); igt_require(fd >= 0); igt_ignore_w

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t] tests/i915_pm_freq_api: Ignore zero register value

2023-08-16 Thread Riana Tauro
On 8/14/2023 12:54 PM, Riana Tauro wrote: Hi Vinay On 8/9/2023 6:20 AM, Vinay Belgaumkar wrote: Register read for requested_freq can return 0 when system is in runtime_pm. Make allowance for this case. Link: https://gitlab.freedesktop.org/drm/intel/issues/8736 Link: https

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t] tests/i915_pm_freq_api: Test s2idle instead of S3

2023-08-31 Thread Riana Tauro
On 8/31/2023 5:08 AM, Vinay Belgaumkar wrote: Test skips whenever S3 is not supported, use s2idle instead, which is widely enabled. Cc: Anshuman Gupta Signed-off-by: Vinay Belgaumkar Looks good to me Reviewed-by: Riana Tauro --- tests/i915/i915_pm_freq_api.c | 2 +- 1 file changed, 1

[Intel-gfx] [PATCH v8 0/4] Add hwmon support for dgfx selftests

2023-04-04 Thread Riana Tauro
add check for single gt in hwmon function Rev7 : Same as Rev 5 with a single gt check in hwmon function Rev8 : Skip power comparison in live_rc6_manual for discrete graphics Riana Tauro (3): drm/i915/selftests: Rename librapl library to libpower drm/i915/hwmon: Add helper

[Intel-gfx] [PATCH v8 1/4] drm/i915/selftests: Rename librapl library to libpower

2023-04-04 Thread Riana Tauro
Rename librapl files to libpower and replace librapl with libpower prefix. No functional changes v2: update commit message (Anshuman) v3: fix license year Signed-off-by: Riana Tauro Reviewed-by: Anshuman Gupta Reviewed-by: Ashutosh Dixit --- drivers/gpu/drm/i915/Makefile

[Intel-gfx] [PATCH v8 2/4] drm/i915/hwmon: Add helper function to obtain energy values

2023-04-04 Thread Riana Tauro
function of energy to remove redundant code (Anshuman) v4 : fix kernel-doc (Anshuman) add per-gt hwmon support (Ashutosh) v5 : add check to return package level energy only when there is a single gt and gt level energy is not available. (Ashutosh) Signed-off-by: Riana Tauro Reviewed-by

[Intel-gfx] [PATCH v8 3/4] drm/i915/selftests: Add hwmon support in libpower for dgfx

2023-04-04 Thread Riana Tauro
(Ashutosh) Signed-off-by: Tilak Tangudu Co-developed-by: Riana Tauro Signed-off-by: Riana Tauro Reviewed-by: Anshuman Gupta Reviewed-by: Ashutosh Dixit --- drivers/gpu/drm/i915/gt/selftest_rc6.c| 10 drivers/gpu/drm/i915/gt/selftest_rps.c| 24 +- drivers/gpu/drm

[Intel-gfx] [PATCH v8 4/4] drm/i915/selftests: skip comparison of power for discrete graphics

2023-04-04 Thread Riana Tauro
skip comparison of power for discrete graphics TODO : measure power of GT in discrete graphics and modify the condition. Signed-off-by: Riana Tauro --- drivers/gpu/drm/i915/gt/selftest_rc6.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/gt

[Intel-gfx] [PATCH v9 0/4] Add hwmon support for dgfx selftests

2023-04-04 Thread Riana Tauro
add check for single gt in hwmon function Rev7 : Same as Rev 5 with a single gt check in hwmon function Rev8 : Skip power comparison in live_rc6_manual for discrete graphics Rev9 : Update commit message Riana Tauro (3): drm/i915/selftests: Rename librapl library to libpower

[Intel-gfx] [PATCH v9 1/4] drm/i915/selftests: Rename librapl library to libpower

2023-04-04 Thread Riana Tauro
Rename librapl files to libpower and replace librapl with libpower prefix. No functional changes v2: update commit message (Anshuman) v3: fix license year Signed-off-by: Riana Tauro Reviewed-by: Anshuman Gupta Reviewed-by: Ashutosh Dixit --- drivers/gpu/drm/i915/Makefile

[Intel-gfx] [PATCH v9 2/4] drm/i915/hwmon: Add helper function to obtain energy values

2023-04-04 Thread Riana Tauro
function of energy to remove redundant code (Anshuman) v4 : fix kernel-doc (Anshuman) add per-gt hwmon support (Ashutosh) v5 : add check to return package level energy only when there is a single gt and gt level energy is not available. (Ashutosh) Signed-off-by: Riana Tauro Reviewed-by

[Intel-gfx] [PATCH v9 3/4] drm/i915/selftests: Add hwmon support in libpower for dgfx

2023-04-04 Thread Riana Tauro
(Ashutosh) Signed-off-by: Tilak Tangudu Co-developed-by: Riana Tauro Signed-off-by: Riana Tauro Reviewed-by: Anshuman Gupta Reviewed-by: Ashutosh Dixit --- drivers/gpu/drm/i915/gt/selftest_rc6.c| 10 drivers/gpu/drm/i915/gt/selftest_rps.c| 24 +- drivers/gpu/drm

[Intel-gfx] [PATCH v9 4/4] drm/i915/selftests: skip comparison of power for discrete graphics

2023-04-04 Thread Riana Tauro
graphics and modify the condition v2: update commit message (Anshuman) Signed-off-by: Riana Tauro Reviewed-by: Anshuman Gupta --- drivers/gpu/drm/i915/gt/selftest_rc6.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/gt/selftest_rc6.c b/drivers

[Intel-gfx] [PATCH v10 2/4] drm/i915/hwmon: Add helper function to obtain energy values

2023-04-05 Thread Riana Tauro
function of energy to remove redundant code (Anshuman) v4 : fix kernel-doc (Anshuman) add per-gt hwmon support (Ashutosh) v5 : add check to return package level energy only when there is a single gt and gt level energy is not available. (Ashutosh) Signed-off-by: Riana Tauro Reviewed-by

[Intel-gfx] [PATCH v10 1/4] drm/i915/selftests: Rename librapl library to libpower

2023-04-05 Thread Riana Tauro
Rename librapl files to libpower and replace librapl with libpower prefix. No functional changes v2: update commit message (Anshuman) v3: fix license year Signed-off-by: Riana Tauro Reviewed-by: Anshuman Gupta Reviewed-by: Ashutosh Dixit --- drivers/gpu/drm/i915/Makefile

[Intel-gfx] [PATCH v10 3/4] drm/i915/selftests: Add hwmon support in libpower for dgfx

2023-04-05 Thread Riana Tauro
(Ashutosh) Signed-off-by: Tilak Tangudu Co-developed-by: Riana Tauro Signed-off-by: Riana Tauro Reviewed-by: Anshuman Gupta Reviewed-by: Ashutosh Dixit --- drivers/gpu/drm/i915/gt/selftest_rc6.c| 10 drivers/gpu/drm/i915/gt/selftest_rps.c| 24 +- drivers/gpu/drm

[Intel-gfx] [PATCH v10 4/4] drm/i915/selftests: skip comparison of power for discrete graphics

2023-04-05 Thread Riana Tauro
graphics and modify the condition v2: update commit message (Anshuman) Signed-off-by: Riana Tauro Reviewed-by: Anshuman Gupta --- drivers/gpu/drm/i915/gt/selftest_rc6.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/gt/selftest_rc6.c b/drivers

[Intel-gfx] [PATCH v10 0/4] Add hwmon support for dgfx selftests

2023-04-05 Thread Riana Tauro
add check for single gt in hwmon function Rev7 : Same as Rev 5 with a single gt check in hwmon function Rev8 : Skip power comparison in live_rc6_manual for discrete graphics Rev9 : Update commit message Rev10: No functional changes Fix a spelling Riana Tauro (3): drm

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t] tests/i915_pm_freq_api: Set min/max to expected values

2023-09-20 Thread Riana Tauro
-off-by: Vinay Belgaumkar LGTM Reviewed-by: Riana Tauro --- tests/intel/i915_pm_freq_api.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/tests/intel/i915_pm_freq_api.c b/tests/intel/i915_pm_freq_api.c index 03bd0d05b..6018692a2 100644 --- a/tests/intel

[Intel-gfx] [PATCH 1/1] drm/i915/guc/slpc: Add SLPC selftest live_slpc_power

2022-09-22 Thread Riana Tauro
A fundamental assumption is that at lower frequencies, not only do we run slower, but we save power compared to higher frequencies. live_slpc_power checks if running at low frequency saves power Signed-off-by: Riana Tauro --- drivers/gpu/drm/i915/gt/selftest_slpc.c | 116

[Intel-gfx] [PATCH 0/1] Add SLPC selftest live_slpc_power

2022-09-22 Thread Riana Tauro
live_slpc_power tests if running at low frequency saves power Riana Tauro (1): drm/i915/guc/slpc: Add SLPC selftest live_slpc_power drivers/gpu/drm/i915/gt/selftest_slpc.c | 116 ++-- 1 file changed, 107 insertions(+), 9 deletions(-) -- 2.25.1

[Intel-gfx] [PATCH 0/3] Add SLPC selftest live_slpc_power

2022-09-23 Thread Riana Tauro
live_slpc_power tests if running at low frequency saves power Rev2 : Add multi-tile support Riana Tauro (3): drm/i915/guc/slpc: Run SLPC selftests on all tiles drm/i915/selftests: Add helper function measure_power drm/i915/guc/slpc: Add SLPC selftest live_slpc_power drivers/gpu/drm/i915

[Intel-gfx] [PATCH 3/3] drm/i915/guc/slpc: Add SLPC selftest live_slpc_power

2022-09-23 Thread Riana Tauro
A fundamental assumption is that at lower frequencies, not only do we run slower, but we save power compared to higher frequencies. live_slpc_power checks if running at low frequency saves power v2: re-use code to measure power fixed cosmetic review comments (Vinay) Signed-off-by: Riana

[Intel-gfx] [PATCH 2/3] drm/i915/selftests: Add helper function measure_power

2022-09-23 Thread Riana Tauro
move the power measurement and the triangle filter to a different function. No functional changes. Signed-off-by: Riana Tauro --- drivers/gpu/drm/i915/gt/selftest_rps.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/gt/selftest_rps.c b

[Intel-gfx] [PATCH 1/3] drm/i915/guc/slpc: Run SLPC selftests on all tiles

2022-09-23 Thread Riana Tauro
Run slpc selftests on all tiles Signed-off-by: Riana Tauro --- drivers/gpu/drm/i915/gt/selftest_slpc.c | 45 - 1 file changed, 37 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/i915/gt/selftest_slpc.c b/drivers/gpu/drm/i915/gt/selftest_slpc.c index

[Intel-gfx] [PATCH v4 0/3] Add hwmon support for dgfx selftests

2022-11-29 Thread Riana Tauro
Rename librapl library to libpower. Add hwmon support in libpower for dgfx. Use libpower in selftests. Rev2 : Update commit message Rev3 : Remove redundant code Rev4 : Add hwmon per-gt support Riana Tauro (3): drm/i915/selftests: Rename librapl library to libpower drm/i915/hwmon: Add helper

[Intel-gfx] [PATCH v4 2/3] drm/i915/hwmon: Add helper function to obtain energy values

2022-11-29 Thread Riana Tauro
redundant code (Anshuman) v4 : fix kernel-doc (Anshuman) add per-gt hwmon support (Ashutosh) Signed-off-by: Riana Tauro Reviewed-by: Anshuman Gupta --- drivers/gpu/drm/i915/i915_hwmon.c | 28 drivers/gpu/drm/i915/i915_hwmon.h | 3 +++ 2 files changed, 31 insertions

[Intel-gfx] [PATCH v4 3/3] drm/i915/selftests: Add hwmon support in libpower for dgfx

2022-11-29 Thread Riana Tauro
: Tilak Tangudu Signed-off-by: Riana Tauro --- drivers/gpu/drm/i915/gt/selftest_rc6.c| 10 drivers/gpu/drm/i915/gt/selftest_rps.c| 24 +- drivers/gpu/drm/i915/gt/selftest_slpc.c | 4 +-- drivers/gpu/drm/i915/selftests/libpower.c | 31

[Intel-gfx] [PATCH v4 1/3] drm/i915/selftests: Rename librapl library to libpower

2022-11-29 Thread Riana Tauro
Rename librapl files to libpower and replace librapl with libpower prefix. No functional changes v2: update commit message (Anshuman) Signed-off-by: Riana Tauro Reviewed-by: Anshuman Gupta --- drivers/gpu/drm/i915/Makefile | 2 +- drivers/gpu/drm/i915/gt/selftest_rc6.c

[Intel-gfx] [PATCH v5 0/3] Add hwmon support for dgfx selftests

2022-11-29 Thread Riana Tauro
Rename librapl library to libpower. Add hwmon support in libpower for dgfx. Use libpower in selftests. Rev2 : Update commit message Rev3 : Remove redundant code Rev4 : Add hwmon per-gt support Rev5 : No functional changes. Change author for last patch Riana Tauro (2): drm/i915

[Intel-gfx] [PATCH v5 2/3] drm/i915/hwmon: Add helper function to obtain energy values

2022-11-29 Thread Riana Tauro
redundant code (Anshuman) v4 : fix kernel-doc (Anshuman) add per-gt hwmon support (Ashutosh) Signed-off-by: Riana Tauro Reviewed-by: Anshuman Gupta --- drivers/gpu/drm/i915/i915_hwmon.c | 28 drivers/gpu/drm/i915/i915_hwmon.h | 3 +++ 2 files changed, 31 insertions

[Intel-gfx] [PATCH v5 1/3] drm/i915/selftests: Rename librapl library to libpower

2022-11-29 Thread Riana Tauro
Rename librapl files to libpower and replace librapl with libpower prefix. No functional changes v2: update commit message (Anshuman) Signed-off-by: Riana Tauro Reviewed-by: Anshuman Gupta --- drivers/gpu/drm/i915/Makefile | 2 +- drivers/gpu/drm/i915/gt/selftest_rc6.c

[Intel-gfx] [PATCH v5 3/3] drm/i915/selftests: Add hwmon support in libpower for dgfx

2022-11-29 Thread Riana Tauro
(Ashutosh) Signed-off-by: Tilak Tangudu Co-developed-by: Riana Tauro Signed-off-by: Riana Tauro Reviewed-by: Anshuman Gupta --- drivers/gpu/drm/i915/gt/selftest_rc6.c| 10 drivers/gpu/drm/i915/gt/selftest_rps.c| 24 +- drivers/gpu/drm/i915/gt/selftest_slpc.c | 4

[Intel-gfx] [PATCH v6 3/3] drm/i915/selftests: use libpower to get power consumption

2022-12-06 Thread Riana Tauro
From: Tilak Tangudu use libpower library to verify power consumption values in selftests. v2: add per-gt hwmon support (Ashutosh) v3: remove libpower changes (Ashutosh) Signed-off-by: Tilak Tangudu Co-developed-by: Riana Tauro Signed-off-by: Riana Tauro Reviewed-by: Anshuman Gupta Reviewed

[Intel-gfx] [PATCH v6 1/3] drm/i915/selftests: Rename librapl library to libpower

2022-12-06 Thread Riana Tauro
Rename librapl files to libpower and replace librapl with libpower prefix. No functional changes v2: update commit message (Anshuman) Signed-off-by: Riana Tauro Reviewed-by: Anshuman Gupta Reviewed-by: Ashutosh Dixit --- drivers/gpu/drm/i915/Makefile | 2 +- drivers/gpu

[Intel-gfx] [PATCH v6 0/3] Add hwmon support for dgfx selftests

2022-12-06 Thread Riana Tauro
patch add check for single gt in hwmon function Riana Tauro (2): drm/i915/selftests: Rename librapl library to libpower drm/i915/hwmon: Add hwmon support in libpower for dgfx Tilak Tangudu (1): drm/i915/selftests: use libpower to get power consumption drivers/gpu/drm/i915/Makefile

[Intel-gfx] [PATCH v6 2/3] drm/i915/hwmon: Add hwmon support in libpower for dgfx

2022-12-06 Thread Riana Tauro
changes (Ashutosh) Signed-off-by: Riana Tauro Co-developed-by: Tilak Tangudu Signed-off-by: Tilak Tangudu Reviewed-by: Anshuman Gupta --- drivers/gpu/drm/i915/i915_hwmon.c | 28 drivers/gpu/drm/i915/i915_hwmon.h | 3 +++ drivers/gpu/drm/i915/selftests

[Intel-gfx] [PATCH v7 0/3] Add hwmon support for dgfx selftests

2022-12-07 Thread Riana Tauro
add check for single gt in hwmon function Rev7 : Same as Rev 5 with a single gt check in hwmon function Riana Tauro (2): drm/i915/selftests: Rename librapl library to libpower drm/i915/hwmon: Add helper function to obtain energy values Tilak Tangudu (1): drm/i915/selftests

[Intel-gfx] [PATCH v7 1/3] drm/i915/selftests: Rename librapl library to libpower

2022-12-07 Thread Riana Tauro
Rename librapl files to libpower and replace librapl with libpower prefix. No functional changes v2: update commit message (Anshuman) Signed-off-by: Riana Tauro Reviewed-by: Anshuman Gupta Reviewed-by: Ashutosh Dixit --- drivers/gpu/drm/i915/Makefile | 2 +- drivers/gpu

[Intel-gfx] [PATCH v7 2/3] drm/i915/hwmon: Add helper function to obtain energy values

2022-12-07 Thread Riana Tauro
function of energy to remove redundant code (Anshuman) v4 : fix kernel-doc (Anshuman) add per-gt hwmon support (Ashutosh) v5 : add check to return package level energy only when there is a single gt and gt level energy is not available. (Ashutosh) Signed-off-by: Riana Tauro Reviewed-by

[Intel-gfx] [PATCH v7 3/3] drm/i915/selftests: Add hwmon support in libpower for dgfx

2022-12-07 Thread Riana Tauro
(Ashutosh) Signed-off-by: Tilak Tangudu Co-developed-by: Riana Tauro Signed-off-by: Riana Tauro Reviewed-by: Anshuman Gupta Reviewed-by: Ashutosh Dixit --- drivers/gpu/drm/i915/gt/selftest_rc6.c| 10 drivers/gpu/drm/i915/gt/selftest_rps.c| 24 +- drivers/gpu/drm

[Intel-gfx] [PATCH 0/3] Add hwmon support for dgfx selftests

2022-10-18 Thread Riana Tauro
Rename librapl library to libpower. Add hwmon support in libpower for dgfx. Riana Tauro (2): drm/i915/selftests: Rename librapl library to libpower drm/i915/hwmon: Add helper function to obtain energy values Tilak Tangudu (1): drm/i915/selftests: Add hwmon support in libpower for dgfx

[Intel-gfx] [PATCH 1/3] drm/i915/selftests: Rename librapl library to libpower

2022-10-18 Thread Riana Tauro
Rename functions in librapl library to libpower. No functional changes. Signed-off-by: Riana Tauro --- drivers/gpu/drm/i915/Makefile | 2 +- drivers/gpu/drm/i915/gt/selftest_rc6.c | 12 ++-- drivers/gpu/drm/i915/gt/selftest_rps.c | 8

[Intel-gfx] [PATCH 2/3] drm/i915/hwmon: Add helper function to obtain energy values

2022-10-18 Thread Riana Tauro
Add an interface to obtain hwmon energy values. This is used by selftest to verify power consumption Signed-off-by: Riana Tauro --- drivers/gpu/drm/i915/i915_hwmon.c | 23 --- drivers/gpu/drm/i915/i915_hwmon.h | 1 + 2 files changed, 21 insertions(+), 3 deletions(-) diff

[Intel-gfx] [PATCH 3/3] drm/i915/selftests: Add hwmon support in libpower for dgfx

2022-10-18 Thread Riana Tauro
Signed-off-by: Riana Tauro --- drivers/gpu/drm/i915/gt/selftest_rc6.c| 8 +++--- drivers/gpu/drm/i915/gt/selftest_rps.c| 22 +++ drivers/gpu/drm/i915/gt/selftest_slpc.c | 2 +- drivers/gpu/drm/i915/selftests/libpower.c | 33 --- drivers/gpu/drm/i915/selftests

[Intel-gfx] [PATCH 0/1] Add selftest for slpc tile interaction

2022-10-28 Thread Riana Tauro
This tests runs a workload on tiles simultaneously by requesting for RP0 frequency and fails if there is a throttling error Riana Tauro (1): drm/i915/guc/slpc: Add selftest for slpc tile-tile interaction drivers/gpu/drm/i915/gt/selftest_slpc.c | 63 + 1 file changed

[Intel-gfx] [PATCH 1/1] drm/i915/guc/slpc: Add selftest for slpc tile-tile interaction

2022-10-28 Thread Riana Tauro
Run a workload on tiles simultaneously by requesting for RP0 frequency. Pcode can however limit the frequency being granted due to throttling reasons. This test fails if there is any throttling Signed-off-by: Riana Tauro --- drivers/gpu/drm/i915/gt/selftest_slpc.c | 63

[Intel-gfx] [PATCH v2 0/1] Add selftest for slpc tile interaction

2022-10-28 Thread Riana Tauro
This test runs a workload on tiles simultaneously by requesting for RP0 frequency and fails if there is a throttling error. Rev2 : Fix build error Riana Tauro (1): drm/i915/guc/slpc: Add selftest for slpc tile-tile interaction drivers/gpu/drm/i915/gt/selftest_slpc.c | 63

[Intel-gfx] [PATCH v2 1/1] drm/i915/guc/slpc: Add selftest for slpc tile-tile interaction

2022-10-28 Thread Riana Tauro
Run a workload on tiles simultaneously by requesting for RP0 frequency. Pcode can however limit the frequency being granted due to throttling reasons. This test fails if there is any throttling v2: Fix build error Signed-off-by: Riana Tauro --- drivers/gpu/drm/i915/gt/selftest_slpc.c | 63

[Intel-gfx] [PATCH v3 0/1] Add selftest for slpc tile interaction

2022-10-30 Thread Riana Tauro
This test runs a workload on tiles simultaneously by requesting for RP0 frequency and fails if there is a throttling error. Rev2 : Fix build error Rev3 : Addressed cosmetic review comments Riana Tauro (1): drm/i915/guc/slpc: Add selftest for slpc tile-tile interaction drivers/gpu/drm/i915

[Intel-gfx] [PATCH v3 1/1] drm/i915/guc/slpc: Add selftest for slpc tile-tile interaction

2022-10-30 Thread Riana Tauro
(Tvrtko) Signed-off-by: Riana Tauro --- drivers/gpu/drm/i915/gt/selftest_slpc.c | 60 + 1 file changed, 60 insertions(+) diff --git a/drivers/gpu/drm/i915/gt/selftest_slpc.c b/drivers/gpu/drm/i915/gt/selftest_slpc.c index 82ec95a299f6..427e714b432b 100644 --- a/drivers/gpu

[Intel-gfx] [PATCH v2 0/3] Add hwmon support for dgfx selftests

2022-11-06 Thread Riana Tauro
Rename librapl library to libpower. Add hwmon support in libpower for dgfx. Use libpower in selftests. Rev2 : Update commit message Riana Tauro (2): drm/i915/selftests: Rename librapl library to libpower drm/i915/hwmon: Add helper function to obtain energy values Tilak Tangudu (1): drm

[Intel-gfx] [PATCH v2 1/3] drm/i915/selftests: Rename librapl library to libpower

2022-11-06 Thread Riana Tauro
Rename librapl files to libpower and replace librapl with libpower prefix. No functional changes v2: update commit message (Anshuman) Signed-off-by: Riana Tauro --- drivers/gpu/drm/i915/Makefile | 2 +- drivers/gpu/drm/i915/gt/selftest_rc6.c | 12

[Intel-gfx] [PATCH v2 2/3] drm/i915/hwmon: Add helper function to obtain energy values

2022-11-06 Thread Riana Tauro
Add an interface to obtain hwmon energy values. This is used by selftest to verify power consumption v2 : use i915_hwmon prefix (Anshuman) Signed-off-by: Riana Tauro --- drivers/gpu/drm/i915/i915_hwmon.c | 23 --- drivers/gpu/drm/i915/i915_hwmon.h | 1 + 2 files changed

[Intel-gfx] [PATCH v2 3/3] drm/i915/selftests: Add hwmon support in libpower for dgfx

2022-11-06 Thread Riana Tauro
Signed-off-by: Riana Tauro --- drivers/gpu/drm/i915/gt/selftest_rc6.c| 8 +++--- drivers/gpu/drm/i915/gt/selftest_rps.c| 22 +++ drivers/gpu/drm/i915/gt/selftest_slpc.c | 2 +- drivers/gpu/drm/i915/selftests/libpower.c | 33 --- drivers/gpu/drm/i915/selftests

[Intel-gfx] [PATCH v4 0/1] Add selftest for slpc tile interaction

2022-11-09 Thread Riana Tauro
This test runs a workload on tiles simultaneously by requesting for RP0 frequency and checks if there is throttling Rev2 : Fix build error Rev3 : Addressed cosmetic review comments Rev4 : Run test on media engines if gt type is GT_MEDIA Riana Tauro (1): drm/i915/guc/slpc: Add selftest for

[Intel-gfx] [PATCH v4 1/1] drm/i915/guc/slpc: Add selftest for slpc tile-tile interaction

2022-11-09 Thread Riana Tauro
IS_ERR_OR_NULL to check worker Addressed cosmetic review comments (Tvrtko) v4: do not skip test on media engines if gt type is GT_MEDIA. Use correct PERF_LIMIT_REASONS register for MTL (Vinay) Signed-off-by: Riana Tauro --- drivers/gpu/drm/i915/gt/selftest_slpc.c | 70 +++-- 1

[Intel-gfx] [PATCH v3 0/3] Add hwmon support for dgfx selftests

2022-11-20 Thread Riana Tauro
Rename librapl library to libpower. Add hwmon support in libpower for dgfx. Use libpower in selftests. Rev2 : Update commit message Rev3 : Remove redundant code Riana Tauro (2): drm/i915/selftests: Rename librapl library to libpower drm/i915/hwmon: Add helper function to obtain energy

[Intel-gfx] [PATCH v3 1/3] drm/i915/selftests: Rename librapl library to libpower

2022-11-20 Thread Riana Tauro
Rename librapl files to libpower and replace librapl with libpower prefix. No functional changes v2: update commit message (Anshuman) Signed-off-by: Riana Tauro Reviewed-by: Anshuman Gupta --- drivers/gpu/drm/i915/Makefile | 2 +- drivers/gpu/drm/i915/gt/selftest_rc6.c

[Intel-gfx] [PATCH v3 3/3] drm/i915/selftests: Add hwmon support in libpower for dgfx

2022-11-20 Thread Riana Tauro
Signed-off-by: Riana Tauro --- drivers/gpu/drm/i915/gt/selftest_rc6.c| 8 +++--- drivers/gpu/drm/i915/gt/selftest_rps.c| 22 +++ drivers/gpu/drm/i915/gt/selftest_slpc.c | 2 +- drivers/gpu/drm/i915/selftests/libpower.c | 33 --- drivers/gpu/drm/i915/selftests

[Intel-gfx] [PATCH v3 2/3] drm/i915/hwmon: Add helper function to obtain energy values

2022-11-20 Thread Riana Tauro
Add an interface to obtain hwmon energy values. This is used by selftest to verify power consumption v2 : use i915_hwmon prefix (Anshuman) v3 : re-use is_visible function of energy to remove redundant code (Anshuman) Signed-off-by: Riana Tauro --- drivers/gpu/drm/i915/i915_hwmon.c | 17

Re: [PATCH v1] drm/i915/hwmon: expose fan speed

2024-07-22 Thread Riana Tauro
Hi Raag On 7/12/2024 5:53 PM, Raag Jadav wrote: Add hwmon support for fan1_input attribute, which will expose fan speed in RPM. With this in place we can monitor fan speed using lm-sensors tool. $ sensors i915-pci-0300 Adapter: PCI adapter in0: 653.00 mV fan1:3833 RPM power1:

Re: [PATCH v1] drm/i915/hwmon: expose fan speed

2024-07-23 Thread Riana Tauro
On 7/23/2024 3:53 PM, Raag Jadav wrote: On Mon, Jul 22, 2024 at 04:20:51PM +0530, Riana Tauro wrote: Hi Raag On 7/12/2024 5:53 PM, Raag Jadav wrote: Add hwmon support for fan1_input attribute, which will expose fan speed in RPM. With this in place we can monitor fan speed using lm-sensors

Re: [PATCH i-g-t] tests/xe_gt_freq: Avoid RPe usage in subtests

2024-07-28 Thread Riana Tauro
Hi Vinay On 7/26/2024 10:38 AM, Nilawar, Badal wrote: Hi Vinay, On 24-07-2024 22:29, Vinay Belgaumkar wrote: We are seeing several instances where the RPe, which can be altered by pcode dynamically, is causing subtests to fail randomly. Instead of relying on it, we can use a mid frequency val

Re: [PATCH v2 i-g-t] tests/xe_gt_freq: Avoid RPe usage in subtests

2024-07-29 Thread Riana Tauro
/drm/xe/kernel/-/issues/2262 Link: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/2256 Link: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/2203 Link: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/2412 Cc: Riana Tauro Cc: Badal Nilawar Signed-off-by: Vinay Belgaumkar

Re: [PATCH v4 i-g-t] tests/xe_gt_freq: Avoid RPe usage in subtests

2024-07-30 Thread Riana Tauro
: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/2412 Closes? Cc: Riana Tauro Cc: Badal Nilawar Signed-off-by: Vinay Belgaumkar --- tests/intel/xe_gt_freq.c | 57 1 file changed, 40 insertions(+), 17 deletions(-) diff --git a/tests/intel

Re: [PATCH v4 i-g-t] tests/xe_gt_freq: Avoid RPe usage in subtests

2024-07-31 Thread Riana Tauro
://gitlab.freedesktop.org/drm/xe/kernel/-/issues/2412 Cc: Riana Tauro Cc: Badal Nilawar Signed-off-by: Vinay Belgaumkar Looks good to me Reviewed-by: Riana Tauro --- tests/intel/xe_gt_freq.c | 57 1 file changed, 40 insertions(+), 17 deletions

Re: [PATCH v2] drm/i915/hwmon: expose fan speed

2024-08-06 Thread Riana Tauro
: N/A (max = 43.00 W) energy1: 32.02 kJ v2: - Add mutex protection - Handle overflow - Add ABI documentation - Aesthetic adjustments Signed-off-by: Raag Jadav Add the name in front of the comments given by reviewer in version history With that Reviewed-by: Riana Tauro

Re: [PATCH v2] drm/i915/selftests: Increasing the sleep time for live_rc6_manual

2024-02-09 Thread Riana Tauro
iptive and improved commit message (Anshuman)" Thanks Riana Tauro --- drivers/gpu/drm/i915/gt/selftest_rc6.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/gt/selftest_rc6.c b/drivers/gpu/drm/i915/gt/selftest_rc6.c index a7189c2d660c..1aa1446c8f

Re: [PATCH v2] drm/i915/hwmon: expose package temperature

2024-09-06 Thread Riana Tauro
Hi Raag On 9/6/2024 3:01 PM, Raag Jadav wrote: Add hwmon support for temp1_input attribute, which will expose package temperature in millidegree Celsius. With this in place we can monitor package temperature using lm-sensors tool. $ sensors i915-pci-0300 Adapter: PCI adapter in0: 990.00

Re: [PATCH v3] drm/i915/hwmon: expose package temperature

2024-09-12 Thread Riana Tauro
Reviewed-by: Andi Shyti Looks good to me Reviewed-by: Riana Tauro --- .../ABI/testing/sysfs-driver-intel-i915-hwmon | 8 drivers/gpu/drm/i915/i915_hwmon.c | 40 +++ drivers/gpu/drm/i915/intel_mchbar_regs.h | 4 ++ 3 files changed, 52 insertions(+) diff

Re: [PATCH v2 4/4] drm/i915/dg2: Implement Wa_14022698537

2024-10-15 Thread Riana Tauro
Hi Raag On 10/11/2024 4:02 PM, Raag Jadav wrote: G8 power state entry is disabled due to a limitation on DG2, so we enable it from driver with Wa_14022698537. Fow now we enable it for typo all DG2 devices with the exception of a few, for which, we enable only when paired with whitelisted CPU m

Re: [PATCH v2 3/4] drm/i915/wa: Introduce intel_wa_cpu.c for CPU specific workarounds

2024-10-15 Thread Riana Tauro
Hi Raag On 10/11/2024 4:02 PM, Raag Jadav wrote: Having similar naming convention in intel-family.h and intel_device_info.h results in redefinition of a few platforms. Define CPU IDs in its own file to avoid this. Signed-off-by: Raag Jadav --- drivers/gpu/drm/i915/Makefile | 1

Re: [PATCH v2 3/4] drm/i915/wa: Introduce intel_wa_cpu.c for CPU specific workarounds

2024-10-22 Thread Riana Tauro
Hi Raag On 10/16/2024 2:31 PM, Raag Jadav wrote: On Tue, Oct 15, 2024 at 03:56:10PM +0530, Riana Tauro wrote: Hi Raag On 10/11/2024 4:02 PM, Raag Jadav wrote: Having similar naming convention in intel-family.h and intel_device_info.h results in redefinition of a few platforms. Define CPU

Re: [PATCH i-g-t] tests/xe/pmu: Add pmu tests

2024-11-03 Thread Riana Tauro
Hi Vinay On 10/31/2024 2:22 AM, Vinay Belgaumkar wrote: Simple tests for validating the PMU implementation for GT C6 residencies and frequency. These tests validate the kernel series which is currently in review here - https://patchwork.freedesktop.org/series/139121/ Cc: Rodrigo Vivi Signed-o

Re: [PATCH v3 1/4] drm/intel/pciids: Refactor DG2 PCI IDs into segment ranges

2024-11-19 Thread Riana Tauro
On 10/30/2024 8:04 PM, Raag Jadav wrote: Refactor DG2 PCI IDs into D, E and M ranges which will be useful for segment specific features. v3: Rework subplatform naming (Jani) Signed-off-by: Raag Jadav Looks good to me Reviewed-by: Riana Tauro --- include/drm/intel/pciids.h | 55

Re: [PATCH i-g-t v7 2/3] lib/igt_perf: Add utils to extract PMU event info

2025-01-31 Thread Riana Tauro
On 1/31/2025 3:00 AM, Vinay Belgaumkar wrote: Functions to parse event ID and GT bit shift for PMU events. v2: Review comments (Riana) v3: Review comments (Lucas) Cc: Riana Tauro Cc: Lucas De Marchi Cc: Kamil Konieczny Cc: Rodrigo Vivi Signed-off-by: Vinay Belgaumkar Looks good to me

Re: [PATCH i-g-t v7 3/3] tests/xe/pmu: Add pmu tests for gt-c6

2025-01-31 Thread Riana Tauro
comments (Lucas) Cc: Lucas De Marchi Cc: Riana Tauro Cc: Rodrigo Vivi Signed-off-by: Vinay Belgaumkar --- tests/intel/xe_pmu.c | 149 +++ tests/meson.build| 1 + 2 files changed, 150 insertions(+) create mode 100644 tests/intel/xe_pmu.c diff

Re: [PATCH i-g-t v6 1/2] lib/igt_perf: Add utils to extract PMU event info

2025-01-29 Thread Riana Tauro
On 1/28/2025 5:00 AM, Lucas De Marchi wrote: On Mon, Jan 27, 2025 at 02:33:00PM -0800, Vinay Belgaumkar wrote: Functions to parse event ID and GT bit shift for PMU events. v2: Review comments (Riana) Cc: Riana Tauro Cc: Lucas De Marchi Cc: Kamil Konieczny Cc: Rodrigo Vivi Signed-off-by

Re: [PATCH v3 3/4] drm/i915: Introduce intel_cpu_info.c for CPU IDs

2024-12-09 Thread Riana Tauro
_MATCH_VFM(INTEL_ROCKETLAKE, NULL), + {} +}; + +/** + * intel_match_g8_cpu - match current CPU against g8_cpu_ids[] + * + * This matches current CPU against g8_cpu_ids[], which are applicable + * for G8 workaround. nit: [] is not necessaray Looks good to me Reviewed-by: Riana Tauro + * + * Retu

Re: [PATCH v3 4/4] drm/i915/dg2: Implement Wa_14022698537

2024-12-10 Thread Riana Tauro
works with Native ASMP and reduces idle power consumption. %s/ASMP/ASPM With that Reviewed-by: Riana Tauro $ echo powersave > /sys/module/pcie_aspm/parameters/policy $ lspci -s :03:00.0 -vvv LnkCtl: ASPM L1 Enabled; RCB 64 bytes, Disabled- CommClk- v2: Fix Wa_ID and include it in subj

Re: [PATCH v1] drm/i915/selftests: Correct frequency handling in RPS power measurement

2025-01-08 Thread Riana Tauro
print this twice. With the above fixed Reviewed-by: Riana Tauro continue; }

Re: [PATCH i-g-t v4 1/2] lib/igt_perf: Add utils to extract PMU event info

2025-01-27 Thread Riana Tauro
Hi Vinay On 1/27/2025 1:44 PM, Vinay Belgaumkar wrote: Functions to parse event ID and GT bit shift for PMU events. Cc: Lucas De Marchi Cc: Kamil Konieczny Cc: Rodrigo Vivi Signed-off-by: Vinay Belgaumkar --- lib/igt_perf.c | 68 ++ lib/igt

Re: [PATCH i-g-t v4 2/2] tests/xe/pmu: Add pmu tests

2025-01-27 Thread Riana Tauro
-residency and remove freq tests. v3: Keep just gt-c6 tests, add frequency tests later. Cc: Lucas De Marchi Cc: Riana Tauro Cc: Rodrigo Vivi Signed-off-by: Vinay Belgaumkar --- lib/igt_perf.c | 8 +- lib/igt_perf.h | 2 + tests/intel/xe_pmu.c | 191

Re: [PATCH v2] drm/i915/selftests: Correct frequency handling in RPS power measurement

2025-01-12 Thread Riana Tauro
measurement. Update live_rps_power test to use the correct frequency values for logging and comparison. v2:    - Improved frequency logging (Riana) Signed-off-by: Sk Anirban Reviewed-by: Riana Tauro ---   drivers/gpu/drm/i915/gt/selftest_rps.c | 11 ++-   1 file changed, 6 insertions(+), 5

Re: [PATCH i-g-t 2/2] tests/xe_pmu: Add frequency test

2025-04-09 Thread Riana Tauro
Hi Vinay On 4/8/2025 5:14 AM, Vinay Belgaumkar wrote: Add a basic test that uses PMU to read GT actual and requested frequencies while running a workload. v2: Rebase and comments (Riana) Cc: Lucas De Marchi Cc: Rodrigo Vivi Cc: Riana Tauro Signed-off-by: Vinay Belgaumkar --- tests/intel

Re: [PATCH i-g-t 2/2] tests/xe_pmu: Add frequency test

2025-04-11 Thread Riana Tauro
Hi Vinay On 4/10/2025 7:03 AM, Vinay Belgaumkar wrote: Add a basic test that uses PMU to read GT actual and requested frequencies while running a workload. v2: Rebase and comments (Riana) v3: Address review comments (Kamil and Riana) Cc: Lucas De Marchi Cc: Rodrigo Vivi Cc: Riana Tauro Cc

Re: [PATCH i-g-t 1/2] lib/xe_gt: Move get/set GT freq utils to lib

2025-04-03 Thread Riana Tauro
er to xe drm fd + * @gt_id: GT id + * @freq_name: which GT freq(min, max, act, cur) to read + * + * Read the min/max/act/cur GT frequency rp0/rpn/rpe enum that matches the string would be better in case some other test sends a wrong name, but upto you With addition of the missing names and descriptive

Re: [PATCH i-g-t 2/2] tests/xe_pmu: Add frequency test

2025-04-03 Thread Riana Tauro
Hi Vinay VF igt patches were merged so this will need a rebase On 4/2/2025 7:09 AM, Vinay Belgaumkar wrote: Add a basic test that uses PMU to read GT actual and requested frequencies while running a workload. Cc: Lucas De Marchi Cc: Rodrigo Vivi Signed-off-by: Vinay Belgaumkar --- tests/i