Re: [Intel-gfx] [PATCH v14 06/12] swiotlb: Use is_swiotlb_force_bounce for swiotlb data bouncing

2021-06-28 Thread Qian Cai
On 6/23/2021 2:37 PM, Will Deacon wrote: > On Wed, Jun 23, 2021 at 12:39:29PM -0400, Qian Cai wrote: >> >> >> On 6/18/2021 11:40 PM, Claire Chang wrote: >>> Propagate the swiotlb_force into io_tlb_default_mem->force_bounce and >>> use it to determine wh

Re: [Intel-gfx] [PATCH v14 06/12] swiotlb: Use is_swiotlb_force_bounce for swiotlb data bouncing

2021-06-28 Thread Qian Cai
On 6/18/2021 11:40 PM, Claire Chang wrote: > Propagate the swiotlb_force into io_tlb_default_mem->force_bounce and > use it to determine whether to bounce the data or not. This will be > useful later to allow for different pools. > > Signed-off-by: Claire Chang > Reviewed-by: Christoph Hellwig

Re: [Intel-gfx] [PATCH v14 06/12] swiotlb: Use is_swiotlb_force_bounce for swiotlb data bouncing

2021-06-28 Thread Qian Cai
On 6/24/2021 7:48 AM, Will Deacon wrote: > Ok, diff below which attempts to tackle the offset issue I mentioned as > well. Qian Cai -- please can you try with these changes? This works fine. > > Will > > --->8 > > diff --git a/include/linux/swiotlb.h b/incl

[Intel-gfx] [PATCH -next] treewide: remove unused argument in lock_release()

2019-09-20 Thread Qian Cai
Since the commit b4adfe8e05f1 ("locking/lockdep: Remove unused argument in __lock_release"), @nested is no longer used in lock_release(), so remove it from all lock_release() calls and friends. Signed-off-by: Qian Cai --- drivers/gpu/drm/drm_connector.c | 2 +- drive

Re: [Intel-gfx] [PATCH -next] treewide: remove unused argument in lock_release()

2019-09-20 Thread Qian Cai
On Fri, 2019-09-20 at 10:38 +0100, Will Deacon wrote: > On Thu, Sep 19, 2019 at 12:09:40PM -0400, Qian Cai wrote: > > Since the commit b4adfe8e05f1 ("locking/lockdep: Remove unused argument > > in __lock_release"), @nested is no longer used in lock_release(), so > >

Re: [Intel-gfx] ✗ Fi.CI.BUILD: failure for treewide: remove unused argument in lock_release()

2019-09-23 Thread Qian Cai
On Fri, 2019-09-20 at 17:30 +, Patchwork wrote: > == Series Details == > > Series: treewide: remove unused argument in lock_release() > URL : https://patchwork.freedesktop.org/series/67007/ > State : failure > > == Summary == > > CALLscripts/checksyscalls.sh > CALLscripts/atomic/

Re: [Intel-gfx] [PATCH -next] treewide: remove unused argument in lock_release()

2019-10-02 Thread Qian Cai
On Mon, 2019-09-30 at 09:29 +0200, Peter Zijlstra wrote: > On Thu, Sep 19, 2019 at 12:09:40PM -0400, Qian Cai wrote: > > Since the commit b4adfe8e05f1 ("locking/lockdep: Remove unused argument > > in __lock_release"), @nested is no longer used in lock_release(),

Re: [Intel-gfx] [PATCH] mm: Track mmu notifiers in fs_reclaim_acquire/release

2020-06-22 Thread Qian Cai
On Sun, Jun 21, 2020 at 10:01:03PM +0200, Daniel Vetter wrote: > On Sun, Jun 21, 2020 at 08:07:08PM +0200, Daniel Vetter wrote: > > On Sun, Jun 21, 2020 at 7:42 PM Qian Cai wrote: > > > > > > On Wed, Jun 10, 2020 at 09:41:01PM +0200, Daniel Vetter wrote: > > >

Re: [Intel-gfx] [PATCH 01/18] mm: Track mmu notifiers in fs_reclaim_acquire/release

2020-06-22 Thread Qian Cai
On Thu, Jun 04, 2020 at 10:12:07AM +0200, Daniel Vetter wrote: > fs_reclaim_acquire/release nicely catch recursion issues when > allocating GFP_KERNEL memory against shrinkers (which gpu drivers tend > to use to keep the excessive caches in check). For mmu notifier > recursions we do have lockdep a

Re: [Intel-gfx] [PATCH] mm: Track mmu notifiers in fs_reclaim_acquire/release

2020-06-22 Thread Qian Cai
On Wed, Jun 10, 2020 at 09:41:01PM +0200, Daniel Vetter wrote: > fs_reclaim_acquire/release nicely catch recursion issues when > allocating GFP_KERNEL memory against shrinkers (which gpu drivers tend > to use to keep the excessive caches in check). For mmu notifier > recursions we do have lockdep a

Re: [Intel-gfx] [PATCH 01/18] mm: Track mmu notifiers in fs_reclaim_acquire/release

2020-06-22 Thread Qian Cai
On Sun, Jun 21, 2020 at 07:28:40PM +0200, Daniel Vetter wrote: > On Sun, Jun 21, 2020 at 7:01 PM Qian Cai wrote: > > > > On Thu, Jun 04, 2020 at 10:12:07AM +0200, Daniel Vetter wrote: > > > fs_reclaim_acquire/release nicely catch recursion issues when > > > all

Re: [Intel-gfx] [PATCH] mm: Track mmu notifiers in fs_reclaim_acquire/release

2020-06-23 Thread Qian Cai
On Sun, Jun 21, 2020 at 10:01:03PM +0200, Daniel Vetter wrote: > On Sun, Jun 21, 2020 at 08:07:08PM +0200, Daniel Vetter wrote: > > On Sun, Jun 21, 2020 at 7:42 PM Qian Cai wrote: > > > > > > On Wed, Jun 10, 2020 at 09:41:01PM +0200, Daniel Vetter wrote: > > >

Re: [Intel-gfx] [PATCH] mm: Track mmu notifiers in fs_reclaim_acquire/release

2020-06-29 Thread Qian Cai
> On Jun 23, 2020, at 6:13 PM, Daniel Vetter wrote: > > Ok I tested this. I can't use your script to repro because > - I don't have a setup with xfs, and the splat points at an issue in xfs > - reproducing lockdep splats in shrinker callbacks is always a bit tricky What’s xfs setup are you tal

Re: [Intel-gfx] [PATCH v2 3/8] mm: Optimise madvise WILLNEED

2020-09-14 Thread Qian Cai
On Thu, 2020-09-10 at 19:33 +0100, Matthew Wilcox (Oracle) wrote: > Instead of calling find_get_entry() for every page index, use an XArray > iterator to skip over NULL entries, and avoid calling get_page(), > because we only want the swap entries. > > Signed-off-by: Matthew Wilcox (Oracle) > Ack

Re: [Intel-gfx] [PATCH v2 3/8] mm: Optimise madvise WILLNEED

2020-09-14 Thread Qian Cai
On Mon, 2020-09-14 at 12:17 -0400, Qian Cai wrote: > On Thu, 2020-09-10 at 19:33 +0100, Matthew Wilcox (Oracle) wrote: > > Instead of calling find_get_entry() for every page index, use an XArray > > iterator to skip over NULL entries, and avoid calling get_page(), > > because

Re: [Intel-gfx] [PATCH v2 3/8] mm: Optimise madvise WILLNEED

2020-09-14 Thread Qian Cai
On Mon, 2020-09-14 at 17:50 +0100, Matthew Wilcox wrote: > On Mon, Sep 14, 2020 at 12:17:07PM -0400, Qian Cai wrote: > > Reverting the "Return head pages from find_*_entry" patchset [1] up to this > > patch fixed the issue that LTP madvise06 test [2] would trigger endl

[Intel-gfx] [tip: locking/core] locking/lockdep: Remove unused @nested argument from lock_release()

2019-10-09 Thread tip-bot2 for Qian Cai
The following commit has been merged into the locking/core branch of tip: Commit-ID: 5facae4f3549b5cf7c0e10ec312a65ffd43b5726 Gitweb: https://git.kernel.org/tip/5facae4f3549b5cf7c0e10ec312a65ffd43b5726 Author:Qian Cai AuthorDate:Thu, 19 Sep 2019 12:09:40 -04:00 Committer